@selesai/code 0.8.3 → 0.8.5

package/dist/extensions/pi-subagents/test/integration/acceptance-file-report.test.ts

@@ -158,7 +158,7 @@ describe("acceptance file reports", { skip: !runSync ? "pi packages not availabl
 			const outputPath = path.join(tempDir, "report.md");
 			conflictingReportsCall(outputPath, "satisfied", "not-satisfied");
 
-			const result = await runSync!(tempDir, makeAgentConfigs(["builder"]), "builder", "Write the findings report.", {
+			const result = await runSync!(tempDir, makeAgentConfigs(["worker"]), "worker", "Write the findings report.", {
 				runId: "acceptance-file-only",
 				outputPath,
 				outputMode: "file-only",
@@ -179,7 +179,7 @@ describe("acceptance file reports", { skip: !runSync ? "pi packages not availabl
 				writeFiles: [{ path: outputPath, content: fileReport }],
 			});
 
-			const result = await runSync!(tempDir, makeAgentConfigs(["builder"]), "builder", "Write the findings report.", {
+			const result = await runSync!(tempDir, makeAgentConfigs(["worker"]), "worker", "Write the findings report.", {
 				runId: "acceptance-foreground-saved-receipt",
 				outputPath,
 				outputMode: "file-only",
@@ -203,7 +203,7 @@ describe("acceptance file reports", { skip: !runSync ? "pi packages not availabl
 			const artifactsDir = path.join(tempDir, "report-only-artifacts");
 			mockPi.onCall({ output: acceptanceReport("satisfied", "report-only evidence") });
 
-			const result = await runSync!(tempDir, [makeAgent("builder", { completionGuard: false })], "builder", "Implement and report the fix.", {
+			const result = await runSync!(tempDir, [makeAgent("worker", { completionGuard: false })], "worker", "Implement and report the fix.", {
 				runId: "acceptance-report-only",
 				acceptance: { level: "checked", criteria: ["Report the findings"] },
 				artifactsDir,
@@ -225,7 +225,7 @@ describe("acceptance file reports", { skip: !runSync ? "pi packages not availabl
 			const artifactsDir = path.join(tempDir, "rejected-artifacts");
 			conflictingReportsCall(outputPath, "satisfied", "not-satisfied");
 
-			const result = await runSync!(tempDir, makeAgentConfigs(["builder"]), "builder", "Write the findings report.", {
+			const result = await runSync!(tempDir, makeAgentConfigs(["worker"]), "worker", "Write the findings report.", {
 				runId: "acceptance-inline-text-first",
 				outputPath,
 				acceptance: { level: "checked", criteria: ["Report the findings"] },
@@ -235,6 +235,8 @@ describe("acceptance file reports", { skip: !runSync ? "pi packages not availabl
 
 			assert.equal(result.acceptance?.status, "rejected");
 			assert.equal(result.exitCode, 1);
+			assert.match(result.finalOutput ?? "", /Output saved to:/);
+			assert.match(result.finalOutput ?? "", new RegExp(outputPath.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")));
 			assert.match(result.error ?? "", /Acceptance rejected: Required criterion 'criterion-1' was reported as not-satisfied\./);
 			assert.ok(result.artifactPaths);
 			const metadata = JSON.parse(fs.readFileSync(result.artifactPaths.metadataPath, "utf-8")) as { exitCode?: number; error?: string; acceptance?: AcceptanceSummary };
@@ -242,13 +244,98 @@ describe("acceptance file reports", { skip: !runSync ? "pi packages not availabl
 			assert.match(metadata.error ?? "", /Acceptance rejected/);
 			assert.equal(metadata.acceptance?.status, "rejected");
 			assert.equal(metadata.acceptance?.runtimeChecks?.find((check) => check.id === "criterion:criterion-1")?.status, "failed");
+			const outputArtifact = fs.readFileSync(result.artifactPaths.outputPath, "utf-8");
+			assert.match(outputArtifact, /Output saved to:/);
+			assert.match(outputArtifact, new RegExp(outputPath.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")));
+		});
+
+		it("inline mode keeps one saved output reference after rejection", { skip: !createSubagentExecutor ? "executor not available" : undefined }, async () => {
+			const outputPath = path.join(tempDir, "report.md");
+			const artifactsDir = path.join(tempDir, "rejected-inline-artifacts");
+			conflictingReportsCall(outputPath, "satisfied", "not-satisfied");
+			const executor = createSubagentExecutor!({
+				pi: { events: createEventBus(), getSessionName: () => undefined },
+				state: { baseCwd: tempDir, currentSessionId: null, asyncJobs: new Map(), foregroundControls: new Map(), lastForegroundControlId: null },
+				config: { artifactDir: "temp" },
+				asyncByDefault: false,
+				tempArtifactsDir: artifactsDir,
+				getSubagentSessionRoot: () => tempDir,
+				expandTilde: (p: string) => p,
+				discoverAgents: () => ({ agents: [makeAgent("worker", { completionGuard: false })] }),
+			});
+
+			const result = await executor.execute(
+				"acceptance-inline-single-reference-rejection",
+				{
+					agent: "worker",
+					task: "Write the findings report.",
+					output: outputPath,
+					acceptance: { level: "checked", criteria: ["Report the findings"] },
+				},
+				new AbortController().signal,
+				undefined,
+				makeMinimalCtx(tempDir),
+			);
+
+			assert.equal(result.isError, true);
+			const content = result.content[0]?.text ?? "";
+			assert.equal(content.match(/Output saved to:/g)?.length, 1);
+			assert.match(content, new RegExp(outputPath.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")));
+			assert.equal(result.details?.results?.[0]?.acceptance?.status, "rejected");
+			assert.match(result.details?.results?.[0]?.finalOutput ?? "", /Output saved to:/);
+		});
+
+		it("inline mode keeps the saved output visible after maxOutput truncation on rejection", { skip: !createSubagentExecutor ? "executor not available" : undefined }, async () => {
+			const outputPath = path.join(tempDir, "report.md");
+			const artifactsDir = path.join(tempDir, "rejected-max-output-artifacts");
+			const fileReport = `# Findings\n${"Saved report detail. ".repeat(300)}\n${acceptanceReport("satisfied", "from child-written file")}`;
+			mockPi.onCall({
+				jsonl: [
+					...events.completedWrite(outputPath, fileReport),
+					events.assistantMessage(`Report written to the output file.\n${acceptanceReport("not-satisfied", "from assistant text")}`),
+				],
+				writeFiles: [{ path: outputPath, content: fileReport }],
+			});
+			const executor = createSubagentExecutor!({
+				pi: { events: createEventBus(), getSessionName: () => undefined },
+				state: { baseCwd: tempDir, currentSessionId: null, asyncJobs: new Map(), foregroundControls: new Map(), lastForegroundControlId: null },
+				config: { artifactDir: "temp" },
+				asyncByDefault: false,
+				tempArtifactsDir: artifactsDir,
+				getSubagentSessionRoot: () => tempDir,
+				expandTilde: (p: string) => p,
+				discoverAgents: () => ({ agents: [makeAgent("worker", { completionGuard: false })] }),
+			});
+
+			const result = await executor.execute(
+				"acceptance-inline-max-output-rejection",
+				{
+					agent: "worker",
+					task: "Write the findings report.",
+					output: outputPath,
+					acceptance: { level: "checked", criteria: ["Report the findings"] },
+					maxOutput: { bytes: 40, lines: 1 },
+				},
+				new AbortController().signal,
+				undefined,
+				makeMinimalCtx(tempDir),
+			);
+
+			assert.equal(result.isError, true);
+			const content = result.content[0]?.text ?? "";
+			assert.match(content, /\[TRUNCATED:/);
+			assert.match(content, /Output saved to:/);
+			assert.match(content, new RegExp(outputPath.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")));
+			assert.doesNotMatch(content, /Saved report detail/);
+			assert.equal(result.details?.results?.[0]?.acceptance?.status, "rejected");
+			assert.match(result.details?.results?.[0]?.finalOutput ?? "", /Output saved to:/);
 		});
 
 		it("inline mode accepts on the text report regardless of a failing file report", async () => {
 			const outputPath = path.join(tempDir, "report.md");
 			conflictingReportsCall(outputPath, "not-satisfied", "satisfied");
 
-			const result = await runSync!(tempDir, makeAgentConfigs(["builder"]), "builder", "Write the findings report.", {
+			const result = await runSync!(tempDir, makeAgentConfigs(["worker"]), "worker", "Write the findings report.", {
 				runId: "acceptance-inline-file-fallback-only",
 				outputPath,
 				acceptance: { level: "checked", criteria: ["Report the findings"] },
@@ -281,7 +368,7 @@ describe("acceptance file reports", { skip: !runSync ? "pi packages not availabl
 				],
 			});
 
-			const result = await runSync!(tempDir, makeAgentConfigs(["builder"]), "builder", "Write the findings report.", {
+			const result = await runSync!(tempDir, makeAgentConfigs(["worker"]), "worker", "Write the findings report.", {
 				runId: "acceptance-failed-write",
 				outputPath,
 				outputMode: "file-only",
@@ -304,7 +391,7 @@ describe("acceptance file reports", { skip: !runSync ? "pi packages not availabl
 				writeFiles: [{ path: outputPath, content: malformedReport }],
 			});
 
-			const result = await runSync!(tempDir, makeAgentConfigs(["builder"]), "builder", "Write the findings report.", {
+			const result = await runSync!(tempDir, makeAgentConfigs(["worker"]), "worker", "Write the findings report.", {
 				runId: "acceptance-malformed-file-report",
 				outputPath,
 				outputMode: "file-only",
@@ -320,9 +407,9 @@ describe("acceptance file reports", { skip: !runSync ? "pi packages not availabl
 	describe("background runner", { skip: isAsyncAvailable && !isAsyncAvailable() ? "jiti not available" : undefined }, () => {
 		function runAsyncSingle(id: string, outputPath: string, outputMode: "inline" | "file-only", artifactConfig = DISABLED_ARTIFACTS) {
 			executeAsyncSingle!(id, {
-				agent: "builder",
+				agent: "worker",
 				task: "Write the findings report.",
-				agentConfig: makeAgent("builder", { completionGuard: false }),
+				agentConfig: makeAgent("worker", { completionGuard: false }),
 				ctx: { pi: { events: { emit() {} } }, cwd: tempDir, currentSessionId: "session-file-report" },
 				artifactConfig,
 				artifactsDir: path.join(tempDir, ".pi-subagents", "artifacts"),
@@ -350,7 +437,7 @@ describe("acceptance file reports", { skip: !runSync ? "pi packages not availabl
 
 		it("file-only mode persists async acceptance metadata when final assistant text is only a receipt", async () => {
 			const outputPath = path.join(tempDir, "saved-review.md");
-			const fileReport = `# Review\n${acceptanceReport("satisfied", "saved commentator verdict")}`;
+			const fileReport = `# Review\n${acceptanceReport("satisfied", "saved reviewer verdict")}`;
 			mockPi.onCall({
 				jsonl: [...events.completedWrite(outputPath, fileReport), events.assistantMessage("Output saved to the configured file.")],
 				writeFiles: [{ path: outputPath, content: fileReport }],
@@ -361,12 +448,12 @@ describe("acceptance file reports", { skip: !runSync ? "pi packages not availabl
 			const payload = await waitForAsyncResult(id);
 			assert.equal(payload.success, true);
 			assert.equal(payload.results[0]?.acceptance?.status, "checked");
-			assert.equal(payload.results[0]?.acceptance?.childReport?.criteriaSatisfied?.[0]?.evidence, "saved commentator verdict");
+			assert.equal(payload.results[0]?.acceptance?.childReport?.criteriaSatisfied?.[0]?.evidence, "saved reviewer verdict");
 			const metadataPath = payload.results[0]?.artifactPaths?.metadataPath;
 			assert.ok(metadataPath);
 			const metadata = JSON.parse(fs.readFileSync(metadataPath, "utf-8")) as { acceptance?: AcceptanceSummary };
 			assert.equal(metadata.acceptance?.status, "checked");
-			assert.equal(metadata.acceptance?.childReport?.criteriaSatisfied?.[0]?.evidence, "saved commentator verdict");
+			assert.equal(metadata.acceptance?.childReport?.criteriaSatisfied?.[0]?.evidence, "saved reviewer verdict");
 		});
 
 		it("inline mode accepts from the text report and strips fences from the resolved file output", async () => {
@@ -405,7 +492,7 @@ describe("acceptance file reports", { skip: !runSync ? "pi packages not availabl
 				tempArtifactsDir: tempDir,
 				getSubagentSessionRoot: () => tempDir,
 				expandTilde: (p: string) => p,
-				discoverAgents: () => ({ agents: [makeAgent("builder", { completionGuard: false })] }),
+				discoverAgents: () => ({ agents: [makeAgent("worker", { completionGuard: false })] }),
 			});
 
 			const acceptance = { level: "checked", criteria: ["Report the findings"] };
@@ -413,8 +500,8 @@ describe("acceptance file reports", { skip: !runSync ? "pi packages not availabl
 				"acceptance-parallel-files",
 				{
 					tasks: [
-						{ agent: "builder", task: "Alpha task: write the report.", output: alphaPath, outputMode: "file-only", acceptance },
-						{ agent: "builder", task: "Beta task: write the report.", output: betaPath, outputMode: "file-only", acceptance },
+						{ agent: "worker", task: "Alpha task: write the report.", output: alphaPath, outputMode: "file-only", acceptance },
+						{ agent: "worker", task: "Beta task: write the report.", output: betaPath, outputMode: "file-only", acceptance },
 					],
 					async: true,
 					clarify: false,