@selesai/code 0.13.15 → 0.13.18

package/dist/extensions/pi-hermes-memory/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-hermes-memory",
-  "version": "0.9.7",
+  "version": "0.9.8",
   "description": "Bundled Selesai fork of pi-hermes-memory: persistent memory, session search, and secret scanning.",
   "type": "module",
   "main": "src/index.ts",
@@ -51,15 +51,15 @@
     "@earendil-works/pi-coding-agent": ">=0.80.6"
   },
   "devDependencies": {
-    "@earendil-works/pi-ai": "0.84.4",
-    "@earendil-works/pi-coding-agent": "0.84.4",
+    "@earendil-works/pi-ai": "0.85.1",
+    "@earendil-works/pi-coding-agent": "0.85.1",
     "@types/better-sqlite3": "^7.6.13",
     "tsx": "^4.21.0",
     "typebox": "^1.1.33",
     "typescript": "^6.0.3"
   },
   "dependencies": {
-    "@earendil-works/pi-tui": "0.84.4",
+    "@earendil-works/pi-tui": "0.85.1",
     "better-sqlite3": "^13.0.3",
     "strip-ansi": "7.2.0"
   }

package/dist/extensions/pi-hermes-memory/src/config.ts

@@ -15,6 +15,7 @@ import {
   DEFAULT_OVERFLOW_GRACE_MS,
   DEFAULT_FAILURE_INJECTION_MAX_AGE_DAYS,
   DEFAULT_FAILURE_INJECTION_MAX_ENTRIES,
+  DEFAULT_SESSION_RETENTION_DAYS,
 } from "./constants.js";
 import { AGENT_ROOT, normalizeConfiguredMemoryDir, normalizeProjectsMemoryDir } from "./paths.js";
 
@@ -66,6 +67,8 @@ const DEFAULT_CONFIG: MemoryConfig = {
   standingInstructionsEnabled: true,
   projectsMemoryDir: DEFAULT_PROJECTS_MEMORY_DIR,
   sessionSearch: { variant: "legacy" },
+  quickCheckOnOpen: true,
+  sessionRetentionDays: DEFAULT_SESSION_RETENTION_DAYS,
 };
 
 export const DEFAULT_CONFIG_PATH = path.join(
@@ -136,6 +139,12 @@ export function loadConfig(configPath = DEFAULT_CONFIG_PATH): MemoryConfig {
       if (typeof parsed.failureInjectionMaxAgeDays === "number") config.failureInjectionMaxAgeDays = parsed.failureInjectionMaxAgeDays;
       if (typeof parsed.failureInjectionMaxEntries === "number") config.failureInjectionMaxEntries = parsed.failureInjectionMaxEntries;
       if (typeof parsed.nudgeToolCalls === "number") config.nudgeToolCalls = parsed.nudgeToolCalls;
+      // Accept any finite number >= 0 so a user can both opt in (positive value)
+      // and explicitly disable retention with 0. Invalid/negative values are
+      // ignored, keeping the current (default) semantics.
+      if (typeof parsed.sessionRetentionDays === "number" && Number.isFinite(parsed.sessionRetentionDays) && parsed.sessionRetentionDays >= 0) {
+        config.sessionRetentionDays = parsed.sessionRetentionDays;
+      }
       if (typeof parsed.standingInstructionsEnabled === "boolean") config.standingInstructionsEnabled = parsed.standingInstructionsEnabled;
       if (typeof parsed.projectCharLimit === "number") config.projectCharLimit = parsed.projectCharLimit;
       if (typeof parsed.memoryDir === "string") {
@@ -153,10 +162,33 @@ export function loadConfig(configPath = DEFAULT_CONFIG_PATH): MemoryConfig {
       ) {
         config.sessionSearch = { variant: parsed.sessionSearch.variant };
       }
+      if (typeof parsed.quickCheckOnOpen === "boolean") config.quickCheckOnOpen = parsed.quickCheckOnOpen;
       if (typeof parsed.llmModelOverride === "string") {
         const trimmed = parsed.llmModelOverride.trim();
         if (trimmed.length > 0) config.llmModelOverride = trimmed;
       }
+      // Support array form for primary override too (e.g. llmModelOverride: ["a/b","c/d"]) — first entry is primary, rest are fallbacks
+      if (Array.isArray(parsed.llmModelOverride) && parsed.llmModelOverride.every((v: unknown) => typeof v === "string")) {
+        const cleaned = (parsed.llmModelOverride as string[]).map((s) => s.trim()).filter(Boolean);
+        if (cleaned.length > 0) {
+          config.llmModelOverride = cleaned[0];
+          const fallbacks = cleaned.slice(1);
+          if (fallbacks.length > 0) config.llmFallbackModels = fallbacks;
+        }
+      }
+      if (isStringArray(parsed.llmFallbackModels)) {
+        const cleaned = (parsed.llmFallbackModels as string[]).map((s) => s.trim()).filter(Boolean);
+        if (cleaned.length > 0) config.llmFallbackModels = [...new Set([...(config.llmFallbackModels ?? []), ...cleaned])];
+      }
+      // Backward-compat alias: llmModelFallbacks / fallbackModels
+      if (isStringArray((parsed as Record<string, unknown>).llmModelFallbacks)) {
+        const cleaned = ((parsed as Record<string, unknown>).llmModelFallbacks as string[]).map((s: string) => s.trim()).filter(Boolean);
+        if (cleaned.length > 0) config.llmFallbackModels = [...new Set([...(config.llmFallbackModels ?? []), ...cleaned])];
+      }
+      if (isStringArray((parsed as Record<string, unknown>).fallbackModels)) {
+        const cleaned = ((parsed as Record<string, unknown>).fallbackModels as string[]).map((s: string) => s.trim()).filter(Boolean);
+        if (cleaned.length > 0) config.llmFallbackModels = [...new Set([...(config.llmFallbackModels ?? []), ...cleaned])];
+      }
       if (isThinkingLevel(parsed.llmThinkingOverride)) config.llmThinkingOverride = parsed.llmThinkingOverride;
       if (isStringArray(parsed.childExtensionPaths)) {
         const childExtensionPaths = [...new Set<string>(

package/dist/extensions/pi-hermes-memory/src/constants.ts

@@ -40,6 +40,16 @@ export const DEFAULT_OVERFLOW_GRACE_MS = 180000;
 export const DEFAULT_FAILURE_INJECTION_MAX_AGE_DAYS = 7;
 export const DEFAULT_FAILURE_INJECTION_MAX_ENTRIES = 5;
 
+// ─── Session retention defaults ───
+/**
+ * Default session retention window in days. `0` means retention pruning is
+ * DISABLED by default -- existing searchable session history is never silently
+ * deleted. Users opt in by setting `sessionRetentionDays` to a positive value
+ * in their config; setting it back to `0` (or omitting it) disables pruning
+ * (see #183).
+ */
+export const DEFAULT_SESSION_RETENTION_DAYS = 0;
+
 // ─── File names ───
 export const MEMORY_FILE = "MEMORY.md";
 export const USER_FILE = "USER.md";
@@ -66,7 +76,7 @@ Memory write targets:
 - failure: failures, corrections, insights, conventions, preferences, and tool quirks captured as categorized lessons.
 
 memory_search filters:
-- target accepts "memory", "user", or "failure".
+- target accepts "memory", "user", "failure", or "project" (project-attributed memory entries).
 - project filters project-scoped memories by project name.
 - category filters categorized failure/lesson memories only.
 
@@ -80,7 +90,7 @@ Accepted memory categories:
 
 Search guidance:
 - For user preferences, search target="user" with concrete terms from the request.
-- For project conventions or repo decisions, search with the current project filter and concrete terms from the request.
+- For project conventions or repo decisions, search with the current project filter and concrete terms from the request; when the project name is unknown, search target="project" to match project-attributed memories regardless of name.
 - For debugging, test failures, build errors, or repeated mistakes, search target="failure" and categories "failure", "correction", "insight", or "tool-quirk".
 - For general durable learnings, search target="memory" with concrete terms from the request.
 - Use category only for categorized failure/lesson searches; ordinary user, global, and project memories may not have a category.

package/dist/extensions/pi-hermes-memory/src/handlers/background-review.ts

@@ -31,9 +31,11 @@ export interface BackgroundReviewDeps {
   runDirectReview?: typeof runDirectMemoryCompletion;
   execChildPrompt?: typeof execChildPrompt;
   /** Test-only hook: called once runReview() has fully settled (after the
-   * fire-and-forget review work completes and reviewInProgress resets),
+   * fire-and-forget review work completes and activeReview clears),
    * since production callers never await runReview() directly. */
   onReviewSettled?: () => void;
+  /** Test-only override for session_shutdown's wait bound. */
+  shutdownGraceMs?: number;
 }
 
 export interface ReviewPromptInput {
@@ -113,17 +115,40 @@ function diagnosticDetail(value: unknown): string {
   return detail.replace(/\s+/g, " ").slice(0, 300);
 }
 
+/** Shutdown wait only. Review still uses its own 120s timeout; 1s covers abort
+ * listener + cancel-file write without hanging Pi's awaited session_shutdown. */
+const SESSION_REVIEW_SHUTDOWN_GRACE_MS = 1000;
+
+function awaitUpTo(promise: Promise<void>, ms: number): Promise<void> {
+  return new Promise((resolve) => {
+    const timer = setTimeout(resolve, ms);
+    promise.then(
+      () => {
+        clearTimeout(timer);
+        resolve();
+      },
+      () => {
+        clearTimeout(timer);
+        resolve();
+      },
+    );
+  });
+}
+
 async function runSubprocessReview(
   pi: ExtensionAPI,
   prompt: string,
   config: MemoryConfig,
   execChild: typeof execChildPrompt,
-  ctx: Pick<ExtensionContext, "cwd" | "model" | "signal">,
+  ctx: Pick<ExtensionContext, "cwd" | "model">,
+  signal: AbortSignal,
 ): Promise<{ code: number; stdout?: string; stderr?: string }> {
   return execChild(pi, prompt, config, {
     cwd: ctx.cwd,
     model: resolveChildPiModel(ctx.model),
-    signal: ctx.signal,
+    // Session-scoped signal only. The turn signal belongs to the interactive
+    // agent run; forwarding it cancels unrelated review on a later user abort.
+    signal,
     timeoutMs: 120000,
   });
 }
@@ -140,11 +165,27 @@ export function setupBackgroundReview(
   const runDirectReview = options.deps?.runDirectReview ?? runDirectMemoryCompletion;
   const execChild = options.deps?.execChildPrompt ?? execChildPrompt;
   const onReviewSettled = options.deps?.onReviewSettled;
+  const shutdownGraceMs = options.deps?.shutdownGraceMs ?? SESSION_REVIEW_SHUTDOWN_GRACE_MS;
 
   let turnsSinceReview = 0;
   let toolCallsSinceReview = 0;
   let userTurnCount = 0;
-  let reviewInProgress = false;
+  let activeReview: Promise<void> | undefined;
+  const sessionAbort = new AbortController();
+  let shutdownPromise: Promise<void> | undefined;
+
+  const sessionCancelled = () => sessionAbort.signal.aborted;
+
+  const shutdownReview = (): Promise<void> => {
+    shutdownPromise ??= (async () => {
+      sessionAbort.abort();
+      const inFlight = activeReview;
+      if (inFlight) await awaitUpTo(inFlight, shutdownGraceMs);
+    })();
+    return shutdownPromise;
+  };
+
+  pi.on("session_shutdown", () => shutdownReview());
 
   pi.on("message_end", async (event, _ctx) => {
     if (event.message.role === "user") {
@@ -156,7 +197,8 @@ export function setupBackgroundReview(
     turnsSinceReview++;
 
     if (!config.reviewEnabled) return;
-    if (reviewInProgress) return;
+    if (sessionCancelled()) return;
+    if (activeReview) return;
 
     try {
       const msg = event.message;
@@ -179,49 +221,52 @@ export function setupBackgroundReview(
 
     if (!turnThresholdMet && !toolCallThresholdMet) return;
     if (userTurnCount < 3) return;
+    if (sessionCancelled()) return;
 
     turnsSinceReview = 0;
     toolCallsSinceReview = 0;
-    reviewInProgress = true;
-
-    let allParts: string[] = [];
-    try {
-      const entries = ctx.sessionManager.getBranch();
-      allParts = collectMessageParts(entries);
-    } catch {
-      reviewInProgress = false;
-      return;
-    }
-    if (allParts.length < 4) {
-      reviewInProgress = false;
-      return;
-    }
-
-    const parts = applyRecentMessageLimit(allParts, config.reviewRecentMessages);
-    const activeProjectStore = resolveProjectStore(projectStore);
-    const activeProjectName = resolveProjectName(projectName);
-    const promptInput: ReviewPromptInput = {
-      parts,
-      currentMemory: store.getMemoryEntries().join("\n§\n"),
-      currentUser: store.getUserEntries().join("\n§\n"),
-      currentProject: activeProjectStore ? activeProjectStore.getMemoryEntries().join("\n§\n") : null,
-    };
-
-    const subprocessPrompt = buildSubprocessReviewPrompt(promptInput);
-    const directPrompt = buildDirectReviewUserPrompt(promptInput);
-
-    const finishReview = () => {
-      reviewInProgress = false;
-      onReviewSettled?.();
-    };
 
     const notifyIfSaved = (saved: boolean) => {
+      if (sessionCancelled()) return;
       if (saved) {
         ctx.ui.notify("💾 Memory auto-reviewed and updated", "info");
       }
     };
 
+    const notifyTransportFailure = (directFailure: string, subprocessDetail: unknown) => {
+      if (sessionCancelled()) return;
+      ctx.ui.notify(
+        `Memory auto-review failed in both transports. Direct: ${diagnosticDetail(directFailure)}. `
+          + `Subprocess: ${diagnosticDetail(subprocessDetail)}. Check the active model/provider or set llmModelOverride.`,
+        "warning",
+      );
+    };
+
     const runReview = async (): Promise<void> => {
+      if (sessionCancelled()) return;
+
+      let allParts: string[] = [];
+      try {
+        const entries = ctx.sessionManager.getBranch();
+        allParts = collectMessageParts(entries);
+      } catch {
+        return;
+      }
+      if (allParts.length < 4) return;
+      if (sessionCancelled()) return;
+
+      const parts = applyRecentMessageLimit(allParts, config.reviewRecentMessages);
+      const activeProjectStore = resolveProjectStore(projectStore);
+      const activeProjectName = resolveProjectName(projectName);
+      const promptInput: ReviewPromptInput = {
+        parts,
+        currentMemory: store.getMemoryEntries().join("\n§\n"),
+        currentUser: store.getUserEntries().join("\n§\n"),
+        currentProject: activeProjectStore ? activeProjectStore.getMemoryEntries().join("\n§\n") : null,
+      };
+      const subprocessPrompt = buildSubprocessReviewPrompt(promptInput);
+      const directPrompt = buildDirectReviewUserPrompt(promptInput);
+
       let directFailure: string | undefined;
 
       if (usesDirectTransport(config)) {
@@ -239,17 +284,20 @@ export function setupBackgroundReview(
               ].join("\n"),
               config,
               timeoutMs: 120000,
+              signal: sessionAbort.signal,
             },
             dbManager,
             activeProjectName,
           );
 
+          if (sessionCancelled()) return;
+
           if (directResult.ok) {
             notifyIfSaved(shouldNotifyDirect(directResult));
             return;
           }
 
-          if (directResult.fallbackReason === "empty") {
+          if (directResult.fallbackReason === "empty" || directResult.fallbackReason === "aborted") {
             return;
           }
           directFailure = [
@@ -257,41 +305,51 @@ export function setupBackgroundReview(
             directResult.error,
           ].filter(Boolean).join(": ");
         } catch (error) {
+          if (sessionCancelled()) return;
           directFailure = diagnosticDetail(error);
         }
       }
 
+      if (sessionCancelled()) return;
+
       let subprocessResult: { code: number; stdout?: string; stderr?: string };
       try {
-        subprocessResult = await runSubprocessReview(pi, subprocessPrompt, config, execChild, ctx);
+        subprocessResult = await runSubprocessReview(
+          pi,
+          subprocessPrompt,
+          config,
+          execChild,
+          ctx,
+          sessionAbort.signal,
+        );
       } catch (error) {
         if (directFailure) {
-          ctx.ui.notify(
-            `Memory auto-review failed in both transports. Direct: ${diagnosticDetail(directFailure)}. `
-              + `Subprocess: ${diagnosticDetail(error)}. Check the active model/provider or set llmModelOverride.`,
-            "warning",
-          );
+          notifyTransportFailure(directFailure, error);
         }
         return;
       }
 
+      if (sessionCancelled()) return;
+
       if (subprocessResult.code === 0) {
         notifyIfSaved(shouldNotifySubprocess(subprocessResult.stdout));
       } else if (directFailure) {
         const subprocessDetail = subprocessResult.stderr?.trim() || subprocessResult.stdout?.trim()
           || `exit code ${subprocessResult.code}`;
-        ctx.ui.notify(
-          `Memory auto-review failed in both transports. Direct: ${diagnosticDetail(directFailure)}. `
-            + `Subprocess: ${diagnosticDetail(subprocessDetail)}. Check the active model/provider or set llmModelOverride.`,
-          "warning",
-        );
+        notifyTransportFailure(directFailure, subprocessDetail);
       }
     };
 
-    runReview()
+    // Occupy the in-flight slot before runReview's synchronous preamble so a
+    // nested turn_end cannot start a second review.
+    activeReview = Promise.resolve()
+      .then(() => runReview())
       .catch(() => {
         // Best-effort only; transport failures are diagnosed after both paths settle.
       })
-      .finally(finishReview);
+      .finally(() => {
+        activeReview = undefined;
+        onReviewSettled?.();
+      });
   });
 }

package/dist/extensions/pi-hermes-memory/src/handlers/index-sessions.ts

@@ -6,13 +6,14 @@ import path from 'node:path';
 import fs from 'node:fs';
 import type { ExtensionAPI, ExtensionCommandContext } from "@earendil-works/pi-coding-agent";
 import { DatabaseManager } from '../store/db.js';
-import { indexAllSessions, getSessionStats } from '../store/session-indexer.js';
+import { indexAllSessions, getSessionStats, retentionCutoffMs } from '../store/session-indexer.js';
+import type { MemoryConfig } from '../types.js';
 import { AGENT_ROOT } from '../paths.js';
 
 const SESSIONS_DIR = process.env.SELESAI_CODING_AGENT_SESSION_DIR
   || path.join(AGENT_ROOT, 'sessions');
 
-export function registerIndexSessionsCommand(pi: ExtensionAPI): void {
+export function registerIndexSessionsCommand(pi: ExtensionAPI, config: MemoryConfig): void {
   pi.registerCommand("memory-index-sessions", {
     description: "Import past Pi sessions into the search database",
     handler: async (_args, ctx: ExtensionCommandContext) => {
@@ -39,7 +40,9 @@ export function registerIndexSessionsCommand(pi: ExtensionAPI): void {
         const dbManager = new DatabaseManager(memoryDir);
 
         try {
-          const result = indexAllSessions(dbManager, SESSIONS_DIR);
+          // Retention is honored here too: a manual reindex must not re-add the
+          // expired sessions the auto pruning just deleted.
+          const result = indexAllSessions(dbManager, SESSIONS_DIR, undefined, retentionCutoffMs(config.sessionRetentionDays));
           const stats = getSessionStats(dbManager);
 
           let output = `\n✅ Session indexing complete!\n\n`;
@@ -47,6 +50,9 @@ export function registerIndexSessionsCommand(pi: ExtensionAPI): void {
           output += `├─ Sessions processed: ${result.sessionsProcessed}\n`;
           output += `├─ Sessions indexed: ${result.sessionsIndexed}\n`;
           output += `├─ Sessions skipped (already indexed): ${result.sessionsSkipped}\n`;
+          if (result.expiredSkipped) {
+            output += `├─ Sessions skipped (outside retention): ${result.expiredSkipped}\n`;
+          }
           output += `└─ Messages indexed: ${result.messagesIndexed}\n`;
 
           if (stats.projects.length > 0) {