@selesai/code 0.13.15 → 0.13.18

package/dist/extensions/pi-subagents/test/unit/subagent-startup-retry.test.ts

@@ -1,104 +0,0 @@
-import assert from "node:assert/strict";
-import { describe, it } from "node:test";
-import type { Usage } from "../../src/shared/types.ts";
-import {
-	MAX_SUBAGENT_STARTUP_FAILURE_DURATION_MS,
-	SUBAGENT_STARTUP_RETRY_DELAYS_MS,
-	formatSubagentExtensionConflictError,
-	formatSubagentStartupRetryExhaustedError,
-	formatSubagentStartupRetryNote,
-	isRetryableSubagentStartupFailure,
-	waitForSubagentStartupRetry,
-	type SubagentStartupFailureEvidence,
-} from "../../src/runs/shared/subagent-startup-retry.ts";
-
-function emptyUsage(): Usage {
-	return { input: 0, output: 0, cacheRead: 0, cacheWrite: 0, cost: 0, turns: 0 };
-}
-
-function startupFailure(overrides: Partial<SubagentStartupFailureEvidence> = {}): SubagentStartupFailureEvidence {
-	return {
-		exitCode: 1,
-		messageCount: 0,
-		toolCount: 0,
-		usage: emptyUsage(),
-		durationMs: 20,
-		...overrides,
-	};
-}
-
-describe("subagent startup retry", () => {
-	it("uses a bounded retry schedule", () => {
-		assert.deepEqual(SUBAGENT_STARTUP_RETRY_DELAYS_MS, [250, 750, 1500]);
-	});
-
-	it("classifies a short non-zero exit with no child activity", () => {
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure()), true);
-	});
-
-	it("retries only the canonical zero-activity SIGKILL startup failure", () => {
-		assert.equal(
-			isRetryableSubagentStartupFailure(startupFailure({
-				processSignal: "SIGKILL",
-				error: "Subagent process terminated by signal SIGKILL.",
-			})),
-			true,
-		);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ processSignal: "SIGKILL" })), true);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ processSignal: "SIGTERM" })), false);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ processSignal: "SIGKILL", error: "authentication failed" })), false);
-	});
-
-	it("rejects successful, long-running, and diagnosed exits", () => {
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ exitCode: 0 })), false);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ durationMs: MAX_SUBAGENT_STARTUP_FAILURE_DURATION_MS + 1 })), false);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ error: "authentication failed" })), false);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ finalOutput: "partial response" })), false);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ protocolError: { code: "protocol_output_limit" } })), false);
-	});
-
-	it("rejects any model, tool, usage, mutation, or lifecycle activity", () => {
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ messageCount: 1 })), false);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ toolCount: 1 })), false);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ usage: { ...emptyUsage(), input: 1 } })), false);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ usage: { ...emptyUsage(), turns: 1 } })), false);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ observedMutationAttempt: true })), false);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ detached: true })), false);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ interrupted: true })), false);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ timedOut: true })), false);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ stopped: true })), false);
-		assert.equal(isRetryableSubagentStartupFailure(startupFailure({ turnBudgetExceeded: true })), false);
-	});
-
-	it("adds actionable guidance for ambient extension registration conflicts", () => {
-		const conflict = 'Error: Failed to load extension "/tmp/pi-mcp-adapter-clone/index.ts": Tool "mcpScript" conflicts with /tmp/pi-mcp-adapter/index.ts\nError: Failed to load extension "/tmp/pi-mcp-adapter-clone/index.ts": Flag "--mcp-config" conflicts with /tmp/pi-mcp-adapter/index.ts';
-		const formatted = formatSubagentExtensionConflictError(conflict, {
-			agent: "reviewer",
-			ambientExtensionsEnabled: true,
-		});
-
-		assert.match(formatted ?? "", /loaded conflicting ambient Pi extensions/);
-		assert.match(formatted ?? "", /\.selesai[\\/]settings\.json/);
-		assert.match(formatted ?? "", /\{"subagents":\{"agentOverrides":\{"reviewer":\{"extensions":\[\]\}\}\}\}/);
-		assert.equal(formatSubagentExtensionConflictError(conflict, { agent: "reviewer", ambientExtensionsEnabled: false }), conflict);
-		assert.equal(formatSubagentExtensionConflictError("authentication failed", { agent: "reviewer", ambientExtensionsEnabled: true }), "authentication failed");
-	});
-
-	it("formats retry and exhaustion diagnostics without task content", () => {
-		assert.equal(
-			formatSubagentStartupRetryNote({ model: "openai/test", attempt: 1, maxAttempts: 4, delayMs: 250 }),
-			"[startup-retry] openai/test exited before model or tool activity (attempt 1/4). Retrying the same model in 250ms.",
-		);
-		assert.match(
-			formatSubagentStartupRetryExhaustedError({ model: "openai/test", attempts: 4 }),
-			/failed to start after 4 attempts.*concurrent Pi startup race.*lower subagent concurrency/i,
-		);
-	});
-
-	it("cancels a pending retry delay", async () => {
-		const controller = new AbortController();
-		const wait = waitForSubagentStartupRetry(5000, [controller.signal]);
-		controller.abort();
-		assert.equal(await wait, false);
-	});
-});

package/dist/extensions/pi-subagents/test/unit/windows-hide-spawn.test.ts

@@ -1,49 +0,0 @@
-import assert from "node:assert/strict";
-import * as fs from "node:fs";
-import * as path from "node:path";
-import { fileURLToPath } from "node:url";
-import { describe, it } from "node:test";
-
-const projectRoot = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "..", "..");
-
-function assertNestedPiSpawnHidesWindows(sourcePath: string): void {
-	const source = fs.readFileSync(path.join(projectRoot, sourcePath), "utf-8");
-	assert.match(
-		source,
-		/spawn\(spawnSpec\.command,\s*spawnSpec\.args,\s*\{[^}]*windowsHide:\s*true/s,
-		`${sourcePath} nested Pi spawn should set windowsHide: true`,
-	);
-}
-
-describe("nested child Pi process visibility", () => {
-	it("publishes detached terminal results before terminal status", () => {
-		const sourcePath = "src/runs/background/subagent-runner.ts";
-		const source = fs.readFileSync(path.join(projectRoot, sourcePath), "utf-8");
-		const terminalBlockStart = source.indexOf("\tstatusPayload.endedAt = runEndedAt;");
-		const resultWrite = source.indexOf("\trunPersistence.write(resultPath, {", terminalBlockStart);
-		const terminalStatusWrite = source.indexOf("\twriteStatusPayload();", terminalBlockStart);
-
-		assert.ok(terminalBlockStart >= 0, `${sourcePath} terminal block should exist`);
-		assert.ok(resultWrite > terminalBlockStart, `${sourcePath} should publish the terminal result`);
-		assert.ok(terminalStatusWrite > resultWrite, `${sourcePath} must not expose terminal status before the terminal result`);
-	});
-
-	it("hides foreground child Pi process windows on Windows", () => {
-		assertNestedPiSpawnHidesWindows("src/runs/foreground/execution.ts");
-	});
-
-	it("hides background child Pi process windows on Windows", () => {
-		assertNestedPiSpawnHidesWindows("src/runs/background/subagent-runner.ts");
-	});
-
-	it("hides mutation-evidence Git process windows on Windows", () => {
-		const sourcePath = "src/runs/shared/mutation-evidence.ts";
-		const source = fs.readFileSync(path.join(projectRoot, sourcePath), "utf-8");
-		const gitExecCalls = source.match(/execFileSync\(\s*"git"[\s\S]*?\{[^}]*\}\s*\)/g) ?? [];
-
-		assert.equal(gitExecCalls.length, 2, `${sourcePath} should have exactly two Git execFileSync calls`);
-		for (const call of gitExecCalls) {
-			assert.match(call, /\bwindowsHide:\s*true\b/, `${sourcePath} Git execFileSync should set windowsHide: true`);
-		}
-	});
-});