@selesai/code 0.13.15 → 0.13.18

package/dist/extensions/pi-subagents/src/runs/shared/subagent-startup-retry.ts

@@ -1,116 +0,0 @@
-import type { Usage } from "../../shared/types.ts";
-import { formatProcessSignalError } from "./process-signal.ts";
-
-/**
- * Retry delays for child processes that exit before any model or tool activity.
- * The schedule is intentionally short and bounded to avoid amplifying persistent
- * launch failures while allowing concurrent Pi startup locks to clear.
- */
-export const SUBAGENT_STARTUP_RETRY_DELAYS_MS = [250, 750, 1500] as const;
-
-/** A genuine startup race should fail well before a model request can complete. */
-export const MAX_SUBAGENT_STARTUP_FAILURE_DURATION_MS = 2000;
-
-const SIGKILL_PROCESS_SIGNAL_ERROR = formatProcessSignalError("SIGKILL");
-const EXTENSION_REGISTRATION_CONFLICT_PATTERN = /Failed to load extension\b[^\n]*:\s*(?:Tool|Flag)\s+"[^"]+"\s+conflicts with\b/i;
-
-export interface SubagentStartupFailureEvidence {
-	exitCode: number | null | undefined;
-	error?: string;
-	finalOutput?: string;
-	messageCount: number;
-	toolCount: number;
-	usage: Usage;
-	durationMs: number;
-	protocolError?: unknown;
-	processSignal?: string | null;
-	observedMutationAttempt?: boolean;
-	detached?: boolean;
-	interrupted?: boolean;
-	timedOut?: boolean;
-	stopped?: boolean;
-	turnBudgetExceeded?: boolean;
-}
-
-export function formatSubagentExtensionConflictError(
-	error: string | undefined,
-	input: { agent: string; ambientExtensionsEnabled: boolean },
-): string | undefined {
-	if (!error || !input.ambientExtensionsEnabled || !EXTENSION_REGISTRATION_CONFLICT_PATTERN.test(error)) return error;
-	const settings = JSON.stringify({
-		subagents: { agentOverrides: { [input.agent]: { extensions: [] } } },
-	});
-	return `${error}\n\nSubagent startup loaded conflicting ambient Pi extensions. Retry this run after disabling ambient extension discovery for agent ${JSON.stringify(input.agent)} in project .selesai/settings.json: ${settings}. Replace the empty array with only the required extension entry paths when this agent needs extension tools.`;
-}
-
-function hasUsage(usage: Usage): boolean {
-	return usage.input !== 0
-		|| usage.output !== 0
-		|| usage.cacheRead !== 0
-		|| usage.cacheWrite !== 0
-		|| usage.cost !== 0
-		|| usage.turns !== 0;
-}
-
-/**
- * Classify only unexplained, zero-activity child exits as startup failures.
- * This intentionally fails closed: any model output, tool activity, usage,
- * mutation evidence, diagnostic, or lifecycle interruption prevents a retry.
- */
-export function isRetryableSubagentStartupFailure(evidence: SubagentStartupFailureEvidence): boolean {
-	return evidence.exitCode !== undefined
-		&& evidence.exitCode !== null
-		&& evidence.exitCode !== 0
-		&& (!evidence.error?.trim() || evidence.error === SIGKILL_PROCESS_SIGNAL_ERROR)
-		&& !evidence.finalOutput?.trim()
-		&& evidence.messageCount === 0
-		&& evidence.toolCount === 0
-		&& !hasUsage(evidence.usage)
-		&& evidence.durationMs >= 0
-		&& evidence.durationMs <= MAX_SUBAGENT_STARTUP_FAILURE_DURATION_MS
-		&& evidence.protocolError === undefined
-		&& (evidence.processSignal === undefined || evidence.processSignal === null || evidence.processSignal === "SIGKILL")
-		&& evidence.observedMutationAttempt !== true
-		&& evidence.detached !== true
-		&& evidence.interrupted !== true
-		&& evidence.timedOut !== true
-		&& evidence.stopped !== true
-		&& evidence.turnBudgetExceeded !== true;
-}
-
-export function formatSubagentStartupRetryNote(input: {
-	model: string;
-	attempt: number;
-	maxAttempts: number;
-	delayMs: number;
-}): string {
-	return `[startup-retry] ${input.model} exited before model or tool activity (attempt ${input.attempt}/${input.maxAttempts}). Retrying the same model in ${input.delayMs}ms.`;
-}
-
-export function formatSubagentStartupRetryExhaustedError(input: {
-	model: string;
-	attempts: number;
-}): string {
-	return `Subagent failed to start after ${input.attempts} attempts on ${input.model}; no model, tool, output, usage, or diagnostic activity was observed. This may be a concurrent Pi startup race. Retry the run or temporarily lower subagent concurrency.`;
-}
-
-/** Wait for a retry delay, returning false when any lifecycle signal aborts it. */
-export async function waitForSubagentStartupRetry(delayMs: number, signals: Array<AbortSignal | undefined>): Promise<boolean> {
-	const activeSignals = signals.filter((signal): signal is AbortSignal => Boolean(signal));
-	if (activeSignals.some((signal) => signal.aborted)) return false;
-	if (delayMs <= 0) return true;
-
-	return await new Promise<boolean>((resolve) => {
-		let settled = false;
-		const finish = (shouldRetry: boolean): void => {
-			if (settled) return;
-			settled = true;
-			clearTimeout(timer);
-			for (const signal of activeSignals) signal.removeEventListener("abort", abort);
-			resolve(shouldRetry);
-		};
-		const abort = (): void => finish(false);
-		const timer = setTimeout(() => finish(true), delayMs);
-		for (const signal of activeSignals) signal.addEventListener("abort", abort, { once: true });
-	});
-}

package/dist/extensions/pi-subagents/src/shared/post-exit-stdio-guard.ts

@@ -1,85 +0,0 @@
-import type { ChildProcess } from "node:child_process";
-
-interface PostExitStdioGuardOptions {
-	idleMs: number;
-	hardMs: number;
-}
-
-interface ChildWithPipedStdio {
-	stdout: ChildProcess["stdout"];
-	stderr: ChildProcess["stderr"];
-	on: ChildProcess["on"];
-}
-
-interface ChildWithKill {
-	kill(signal?: NodeJS.Signals | number): boolean;
-}
-
-export function trySignalChild(child: ChildWithKill, signal: NodeJS.Signals): boolean {
-	try {
-		return child.kill(signal);
-	} catch {
-		return false;
-	}
-}
-
-export function attachPostExitStdioGuard(
-	child: ChildWithPipedStdio,
-	options: PostExitStdioGuardOptions,
-): () => void {
-	const { idleMs, hardMs } = options;
-	let exited = false;
-	let stdoutEnded = false;
-	let stderrEnded = false;
-	let idleTimer: NodeJS.Timeout | undefined;
-	let hardTimer: NodeJS.Timeout | undefined;
-
-	const destroyUnendedStdio = () => {
-		if (!stdoutEnded) {
-			try { child.stdout?.destroy(); } catch {}
-		}
-		if (!stderrEnded) {
-			try { child.stderr?.destroy(); } catch {}
-		}
-	};
-
-	const clearTimers = () => {
-		if (idleTimer) {
-			clearTimeout(idleTimer);
-			idleTimer = undefined;
-		}
-		if (hardTimer) {
-			clearTimeout(hardTimer);
-			hardTimer = undefined;
-		}
-	};
-
-	const armIdleTimer = () => {
-		if (!exited) return;
-		if (idleTimer) clearTimeout(idleTimer);
-		idleTimer = setTimeout(destroyUnendedStdio, idleMs);
-		idleTimer.unref?.();
-	};
-
-	child.stdout?.on("data", armIdleTimer);
-	child.stderr?.on("data", armIdleTimer);
-	child.stdout?.on("end", () => {
-		stdoutEnded = true;
-		if (stdoutEnded && stderrEnded) clearTimers();
-	});
-	child.stderr?.on("end", () => {
-		stderrEnded = true;
-		if (stdoutEnded && stderrEnded) clearTimers();
-	});
-	child.on("exit", () => {
-		exited = true;
-		armIdleTimer();
-		if (hardTimer) return;
-		hardTimer = setTimeout(destroyUnendedStdio, hardMs);
-		hardTimer.unref?.();
-	});
-	child.on("close", clearTimers);
-	child.on("error", clearTimers);
-
-	return clearTimers;
-}

package/dist/extensions/pi-subagents/test/e2e/real-session-subagent.test.ts

@@ -1,224 +0,0 @@
-/**
- * Real Pi-session end-to-end test for the subagent extension.
- *
- * Spawns an actual child `pi` subprocess (a repo-local child CLI that runs a
- * real `AgentSession` backed by a faux provider) and exercises the extension's
- * real foreground execution path: the parent session calls the `subagent` tool,
- * the tool spawns the child, the child streams jsonl events, the extension's
- * real stdout parser extracts the result, and the marker flows back as a tool
- * result that the parent relays. No real API keys are used.
- *
- * Skips gracefully when the pi runtime packages are not importable.
- */
-
-import { afterEach, describe, it } from "node:test";
-import assert from "node:assert/strict";
-import * as os from "node:os";
-import * as path from "node:path";
-import { tryImport } from "../support/helpers.ts";
-import type { RealSessionRun } from "../support/real-session-runner.ts";
-
-const piCodingAgent = await tryImport<{ __piSubagentsTestShim?: boolean }>("@selesai/code");
-const piAi = await tryImport<unknown>("@earendil-works/pi-ai");
-const available = Boolean(piCodingAgent && !piCodingAgent.__piSubagentsTestShim && piAi);
-
-const CHILD_MARKER = "CHILD_REAL_SESSION_OK";
-// Env vars the runner must clear so a parent that was itself spawned as a
-// subagent child can still launch fresh children. The values are deliberately
-// bogus sentinels (nonexistent paths) so a leaked value would break spawning.
-const BOGUS_EXTRA_DIRS = path.join(os.tmpdir(), "nonexistent-pi-subagents-e2e-extra-dirs");
-const BOGUS_PI_BINARY = path.join(os.tmpdir(), "nonexistent-pi-binary-e2e");
-const BOGUS_PI_PACKAGE_ROOT = path.join(os.tmpdir(), "nonexistent-pi-coding-agent-package-root-e2e");
-const ISOLATED_ENV_KEYS = [
-	"SELESAI_SUBAGENT_CHILD",
-	"SELESAI_SUBAGENT_FANOUT_CHILD",
-	"SELESAI_SUBAGENT_DEPTH",
-	"SELESAI_SUBAGENT_MAX_DEPTH",
-	"SELESAI_SUBAGENT_EXTRA_AGENT_DIRS",
-	"SELESAI_SUBAGENT_PARENT_SESSION",
-	"SELESAI_SUBAGENT_SELESAI_BINARY",
-	"SELESAI_SUBAGENTS_CODING_AGENT_PACKAGE_ROOT",
-] as const;
-
-describe("real Pi-session subagent E2E", { skip: !available ? "pi runtime packages not available" : undefined }, () => {
-	let run: RealSessionRun | undefined;
-
-	afterEach(async () => {
-		await run?.dispose();
-		run = undefined;
-	});
-
-	it("loads requested extension tools in direct and workflow children and diagnoses missing providers", async () => {
-		const { runRealSubagentSession, subagentCall, subagentToolResults } = await import("../support/real-session-runner.ts");
-		const extensionAgent = `---
-name: extension-worker
-description: Uses a child-only fixture tool
-tools: read, fixture_search
-subagentOnlyExtensions: ./fixture-extension.ts
-completionGuard: false
----
-Use the available tools.`;
-		const missingAgent = `---
-name: missing-extension-worker
-description: Requests an extension tool without loading its provider
-tools: read, missing_search
-completionGuard: false
----
-Use the available tools.`;
-		const fixtureExtension = `export default function (pi) {
-	pi.registerTool({
-		name: "fixture_search",
-		label: "Fixture Search",
-		description: "Search the E2E fixture.",
-		parameters: { type: "object", properties: { query: { type: "string" } }, required: ["query"], additionalProperties: false },
-		async execute() { return { content: [{ type: "text", text: "fixture result" }] }; },
-	});
-}`;
-
-		run = await runRealSubagentSession({
-			prompt: "Run the direct, workflow, and missing-provider child checks.",
-			childText: CHILD_MARKER,
-			reportChildTools: true,
-			projectFiles: {
-				".selesai/agents/extension-worker.md": extensionAgent,
-				".selesai/agents/missing-extension-worker.md": missingAgent,
-				"fixture-extension.ts": fixtureExtension,
-			},
-			respond(context) {
-				const resultCount = (context.messages as Array<{ role?: string; toolName?: string }>).filter((message) => message.role === "toolResult" && message.toolName === "subagent").length;
-				if (resultCount === 0) {
-					return subagentCall({ agent: "extension-worker", task: "Report active tools.", context: "fresh", async: false, clarify: false, agentScope: "project" }, "call-direct-extension");
-				}
-				if (resultCount === 1) {
-					return subagentCall({
-						workflowScript: `return await runs.all([
-							{ key: "extension", agent: "extension-worker", task: "Report active tools." },
-							{
-								key: "structured",
-								agent: "extension-worker",
-								task: "Submit the required structured marker.",
-								outputSchema: {
-									type: "object",
-									properties: { marker: { type: "string" } },
-									required: ["marker"],
-									additionalProperties: false,
-								},
-							},
-						]);`,
-						async: false,
-						clarify: false,
-						agentScope: "project",
-					}, "call-workflow-extension");
-				}
-				if (resultCount === 2) {
-					return subagentCall({ agent: "missing-extension-worker", task: "Report active tools.", context: "fresh", async: false, clarify: false, agentScope: "project" }, "call-missing-extension");
-				}
-				return "Child tool checks complete.";
-			},
-			timeoutMs: 60_000,
-		});
-
-		const results = subagentToolResults(run.parentSession);
-		const toolMessages = run.parentSession.messages.filter((message) => message.role === "toolResult" && (message as { toolName?: string }).toolName === "subagent");
-		const workflowDetails = JSON.stringify((toolMessages[1] as { details?: unknown } | undefined)?.details);
-		assert.equal(results.length, 3);
-		assert.match(results[0] ?? "", /ACTIVE_TOOLS:[^\n]*fixture_search/);
-		assert.match(results[0] ?? "", /ACTIVE_TOOLS:[^\n]*read/);
-		assert.match(workflowDetails, /ACTIVE_TOOLS:[^\n]*fixture_search/);
-		assert.match(workflowDetails, /ACTIVE_TOOLS:[^\n]*read/);
-		assert.match(workflowDetails, /STRUCTURED_OUTPUT_OK/);
-		assert.match(results[2] ?? "", /requested unavailable child tools: missing_search/);
-		assert.match(results[2] ?? "", /subagentOnlyExtensions/);
-	});
-
-	it("accepts child tools registered by async before_agent_start hooks", async () => {
-		const { runRealSubagentSession, subagentCall, subagentToolResults } = await import("../support/real-session-runner.ts");
-		const asyncExtensionAgent = `---
-name: async-extension-worker
-description: Uses a child-only tool registered from before_agent_start
-tools: read, fixture_async_search
-subagentOnlyExtensions: ./fixture-async-extension.ts
-completionGuard: false
----
-Report active tools.`;
-		const fixtureAsyncExtension = `export default function (pi) {
-	pi.on("before_agent_start", async () => {
-		await new Promise((resolve) => setTimeout(resolve, 0));
-		pi.registerTool({
-			name: "fixture_async_search",
-			label: "Fixture Async Search",
-			description: "Search the async E2E fixture.",
-			parameters: { type: "object", properties: { query: { type: "string" } }, required: ["query"], additionalProperties: false },
-			async execute() { return { content: [{ type: "text", text: "async fixture result" }] }; },
-		});
-	});
-}`;
-
-		run = await runRealSubagentSession({
-			prompt: "Run the async child tool check.",
-			childText: CHILD_MARKER,
-			reportChildTools: true,
-			projectFiles: {
-				".selesai/agents/async-extension-worker.md": asyncExtensionAgent,
-				"fixture-async-extension.ts": fixtureAsyncExtension,
-			},
-			respond(context) {
-				const resultCount = (context.messages as Array<{ role?: string; toolName?: string }>).filter((message) => message.role === "toolResult" && message.toolName === "subagent").length;
-				if (resultCount > 0) return "Async child tool check complete.";
-				return subagentCall({ agent: "async-extension-worker", task: "Report active tools.", context: "fresh", async: false, clarify: false, agentScope: "project" }, "call-async-extension");
-			},
-			timeoutMs: 60_000,
-		});
-
-		const results = subagentToolResults(run.parentSession);
-		assert.equal(results.length, 1);
-		assert.match(results[0] ?? "", /ACTIVE_TOOLS:[^\n]*fixture_async_search/);
-		assert.doesNotMatch(results[0] ?? "", /requested unavailable child tools/);
-	});
-
-	it("boots the extension in a real parent session and delivers a faux child result", async () => {
-		const { routeParentThroughSubagent, runRealSubagentSession, subagentToolResults } = await import("../support/real-session-runner.ts");
-
-		const previousEnv = new Map(ISOLATED_ENV_KEYS.map((key) => [key, process.env[key]]));
-		process.env.SELESAI_SUBAGENT_CHILD = "1";
-		process.env.SELESAI_SUBAGENT_FANOUT_CHILD = "1";
-		process.env.SELESAI_SUBAGENT_DEPTH = "1";
-		process.env.SELESAI_SUBAGENT_MAX_DEPTH = "1";
-		process.env.SELESAI_SUBAGENT_EXTRA_AGENT_DIRS = BOGUS_EXTRA_DIRS;
-		process.env.SELESAI_SUBAGENT_PARENT_SESSION = "polluted-parent";
-		process.env.SELESAI_SUBAGENT_SELESAI_BINARY = BOGUS_PI_BINARY;
-		process.env.SELESAI_SUBAGENTS_CODING_AGENT_PACKAGE_ROOT = BOGUS_PI_PACKAGE_ROOT;
-
-		try {
-			run = await runRealSubagentSession({
-				prompt: "Delegate to a worker and report its exact result.",
-				childText: CHILD_MARKER,
-				respond: routeParentThroughSubagent({
-					childMarker: CHILD_MARKER,
-					subagentArgs: {
-						agent: "worker",
-						task: "Return the marker from the faux child provider.",
-						context: "fresh",
-						async: false,
-						clarify: false,
-						agentScope: "project",
-					},
-				}),
-			});
-
-			const toolResults = subagentToolResults(run.parentSession);
-			assert.equal(toolResults.length, 1);
-			assert.match(toolResults[0]!, new RegExp(CHILD_MARKER));
-			assert.match(run.responseText, new RegExp(CHILD_MARKER));
-			assert.doesNotMatch(run.responseText, /CHILD_MISSING/);
-			assert.ok(run.modelCalls >= 2, `expected parent tool-call and final turns, got ${run.modelCalls}`);
-		} finally {
-			await run?.dispose();
-			run = undefined;
-			for (const [key, value] of previousEnv) {
-				if (value === undefined) delete process.env[key];
-				else process.env[key] = value;
-			}
-		}
-	});
-});