@scalebun/react-native 1.10.5 → 1.10.7

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (64) hide show
  1. package/android/src/main/java/com/scalebun/rn/ota/ScaleBunOtaModule.kt +75 -0
  2. package/android/src/oldarch/java/com/scalebun/rn/ota/ScaleBunOtaSpec.kt +12 -0
  3. package/dist/scalebun.full.js +485 -51
  4. package/dist/scalebun.slim.js +485 -51
  5. package/ios/Core/DeviceIdentity.swift +50 -0
  6. package/ios/Ota/ScaleBunOtaBridge.mm +6 -0
  7. package/ios/Ota/ScaleBunOtaModule.swift +67 -0
  8. package/ios/Profiler/ScaleBunProfilerModule.swift +2 -8
  9. package/ios/ReplaySdk.swift +3 -1
  10. package/lib/commonjs/analytics/EventTracker.js +22 -0
  11. package/lib/commonjs/core/config/schema.js +34 -1
  12. package/lib/commonjs/core/constants/version.js +1 -1
  13. package/lib/commonjs/core/context/device.js +5 -0
  14. package/lib/commonjs/features/journey/ScaleBunDebugRoot.js +24 -0
  15. package/lib/commonjs/features/journey/uiState.js +87 -0
  16. package/lib/commonjs/features/ota/crypto/builtinVerifier.js +248 -0
  17. package/lib/commonjs/features/ota/crypto/loadEd25519.js +40 -0
  18. package/lib/commonjs/features/ota/crypto/loadSha512.js +40 -0
  19. package/lib/commonjs/features/ota/crypto/nativeVerifier.js +121 -0
  20. package/lib/commonjs/features/ota/signature.js +87 -27
  21. package/lib/commonjs/metro/serializerCompose.js +32 -0
  22. package/lib/commonjs/public/ScaleBunFacade.js +108 -11
  23. package/lib/module/analytics/EventTracker.js +22 -0
  24. package/lib/module/core/config/schema.js +34 -1
  25. package/lib/module/core/constants/version.js +1 -1
  26. package/lib/module/core/context/device.js +5 -0
  27. package/lib/module/features/journey/ScaleBunDebugRoot.js +24 -0
  28. package/lib/module/features/journey/uiState.js +79 -0
  29. package/lib/module/features/ota/crypto/builtinVerifier.js +240 -0
  30. package/lib/module/features/ota/crypto/loadEd25519.js +34 -0
  31. package/lib/module/features/ota/crypto/loadSha512.js +34 -0
  32. package/lib/module/features/ota/crypto/nativeVerifier.js +113 -0
  33. package/lib/module/features/ota/signature.js +87 -27
  34. package/lib/module/metro/serializerCompose.js +32 -0
  35. package/lib/module/public/ScaleBunFacade.js +109 -12
  36. package/lib/typescript/analytics/EventTracker.d.ts +15 -0
  37. package/lib/typescript/core/config/schema.d.ts +2 -0
  38. package/lib/typescript/core/constants/version.d.ts +1 -1
  39. package/lib/typescript/core/context/device.d.ts +1 -0
  40. package/lib/typescript/features/journey/uiState.d.ts +53 -0
  41. package/lib/typescript/features/ota/OtaTypes.d.ts +50 -0
  42. package/lib/typescript/features/ota/crypto/builtinVerifier.d.ts +53 -0
  43. package/lib/typescript/features/ota/crypto/loadEd25519.d.ts +30 -0
  44. package/lib/typescript/features/ota/crypto/loadSha512.d.ts +15 -0
  45. package/lib/typescript/features/ota/crypto/nativeVerifier.d.ts +35 -0
  46. package/lib/typescript/features/ota/signature.d.ts +22 -7
  47. package/lib/typescript/public/ScaleBunFacade.d.ts +43 -6
  48. package/lib/typescript/specs/NativeScaleBunOta.d.ts +23 -0
  49. package/package.json +18 -3
  50. package/src/analytics/EventTracker.ts +19 -0
  51. package/src/core/config/schema.ts +30 -3
  52. package/src/core/constants/version.ts +1 -1
  53. package/src/core/context/device.ts +6 -0
  54. package/src/features/journey/ScaleBunDebugRoot.tsx +22 -0
  55. package/src/features/journey/uiState.ts +84 -0
  56. package/src/features/ota/OtaTypes.ts +51 -0
  57. package/src/features/ota/crypto/builtinVerifier.ts +257 -0
  58. package/src/features/ota/crypto/loadEd25519.ts +41 -0
  59. package/src/features/ota/crypto/loadSha512.ts +35 -0
  60. package/src/features/ota/crypto/nativeVerifier.ts +117 -0
  61. package/src/features/ota/signature.ts +108 -25
  62. package/src/metro/serializerCompose.ts +38 -2
  63. package/src/public/ScaleBunFacade.ts +128 -14
  64. package/src/specs/NativeScaleBunOta.ts +24 -0
@@ -0,0 +1,257 @@
1
+ /**
2
+ * Built-in ed25519 verifier, assembled from OPTIONAL peer dependencies.
3
+ *
4
+ * WHAT THIS REPLACES. Pinning `ota.publicSigningKey` used to require the host
5
+ * app to write its own `verifySignature` — roughly a hundred lines of hex and
6
+ * base64 decoding wrapped around a crypto library. That put the single most
7
+ * security-critical operation in the product, the one deciding whether remote
8
+ * code is authentic before it executes, in code the SDK could neither test nor
9
+ * audit. Three failure modes all landed on the app author:
10
+ *
11
+ * - A verifier that always returns `true` silently disables the feature, and
12
+ * nothing can detect it.
13
+ * - @noble's hash-provider property moved between major versions, so a
14
+ * routine dependency bump made every update fail closed with no signal
15
+ * pointing at the cause.
16
+ * - Hand-written base64 decoders tend to omit base64url, so a signature
17
+ * containing `-` or `_` is rejected as a forgery.
18
+ *
19
+ * All three are now the SDK's problem, which is where they belong. A host that
20
+ * installs `@noble/ed25519` and `@noble/hashes` gets verification by pinning a
21
+ * key and writing no code at all.
22
+ *
23
+ * WHY OPTIONAL AND NOT A HARD DEPENDENCY. Most apps never adopt bundle
24
+ * signing, and they should not carry curve arithmetic they will not run. The
25
+ * `verifySignature` hook remains supported and still WINS over this, for teams
26
+ * with their own crypto policy or a native implementation to delegate to.
27
+ *
28
+ * WHAT THIS DOES NOT FIX. Verification still happens in JS, inside the very
29
+ * bundle it protects. An attacker who lands one malicious bundle by other means
30
+ * can neuter the check for every update after it. Closing that needs native
31
+ * verification — CryptoKit on iOS (13.4+, already the deployment target) and
32
+ * `Signature.getInstance("Ed25519")` on Android API 33+, with a fallback below.
33
+ */
34
+
35
+ import { loadEd25519, type NobleEd25519 } from './loadEd25519';
36
+ import { loadSha512, type Sha512Fn } from './loadSha512';
37
+ import { logger } from '../../../core/logger/internalLogger';
38
+ import type { SignatureVerifier } from '../signature';
39
+
40
+ const ED25519_SIGNATURE_BYTES = 64;
41
+ const ED25519_PUBLIC_KEY_BYTES = 32;
42
+
43
+ /** Hex → bytes. Returns null rather than throwing; callers treat null as "reject". */
44
+ function hexToBytes(hex: string): Uint8Array | null {
45
+ const clean = hex.trim().toLowerCase().replace(/^0x/, '');
46
+ if (clean.length === 0 || clean.length % 2 !== 0 || /[^0-9a-f]/.test(clean)) return null;
47
+ const out = new Uint8Array(clean.length / 2);
48
+ for (let i = 0; i < out.length; i++) {
49
+ out[i] = parseInt(clean.slice(i * 2, i * 2 + 2), 16);
50
+ }
51
+ return out;
52
+ }
53
+
54
+ const B64_ALPHABET = 'ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+/';
55
+
56
+ /**
57
+ * Base64 → bytes, accepting base64url as well.
58
+ *
59
+ * The `-`/`_` handling is the point. A verifier that omits it rejects a
60
+ * perfectly valid signature as a forgery the moment the signing side emits
61
+ * base64url, and the resulting symptom — updates silently stop installing —
62
+ * looks nothing like a decoding bug.
63
+ */
64
+ function base64ToBytes(b64: string): Uint8Array | null {
65
+ const s = b64.trim().replace(/-/g, '+').replace(/_/g, '/').replace(/=+$/, '');
66
+ if (s.length === 0) return null;
67
+ const out: number[] = [];
68
+ let buffer = 0;
69
+ let bits = 0;
70
+ for (const ch of s) {
71
+ const idx = B64_ALPHABET.indexOf(ch);
72
+ if (idx === -1) return null;
73
+ buffer = (buffer << 6) | idx;
74
+ bits += 6;
75
+ if (bits >= 8) {
76
+ bits -= 8;
77
+ out.push((buffer >> bits) & 0xff);
78
+ }
79
+ }
80
+ return Uint8Array.from(out);
81
+ }
82
+
83
+ /**
84
+ * Decode a detached signature that may arrive hex- or base64-encoded.
85
+ *
86
+ * Tries the unambiguous case first: 128 hex characters is exactly 64 bytes and
87
+ * cannot be anything else. Otherwise base64, then hex as a last resort. Only a
88
+ * result of exactly 64 bytes is accepted, so a string that decodes under the
89
+ * wrong scheme is rejected rather than fed to the curve code as garbage.
90
+ */
91
+ export function decodeSignature(sig: string): Uint8Array | null {
92
+ const trimmed = sig.trim();
93
+ if (/^(0x)?[0-9a-fA-F]{128}$/.test(trimmed)) {
94
+ const hex = hexToBytes(trimmed);
95
+ if (hex && hex.length === ED25519_SIGNATURE_BYTES) return hex;
96
+ }
97
+ const b64 = base64ToBytes(trimmed);
98
+ if (b64 && b64.length === ED25519_SIGNATURE_BYTES) return b64;
99
+ const hex = hexToBytes(trimmed);
100
+ if (hex && hex.length === ED25519_SIGNATURE_BYTES) return hex;
101
+ return null;
102
+ }
103
+
104
+ /**
105
+ * Give @noble its SHA-512 provider.
106
+ *
107
+ * The property it reads moved between major versions — v2 wants
108
+ * `etc.sha512Sync`, v3 wants `hashes.sha512` — so both are populated when
109
+ * present. Getting this wrong does not fail loudly: verification simply throws
110
+ * from inside the curve code and the outer catch converts it to "rejected",
111
+ * which is indistinguishable from an actual forgery. That ambiguity is exactly
112
+ * what made this a bad thing to ask app authors to maintain.
113
+ */
114
+ function wireSha512(ed: NobleEd25519, sha512: Sha512Fn): boolean {
115
+ // VARIADIC ON PURPOSE. @noble calls its hash provider with several byte
116
+ // arrays to be hashed as one concatenated message. A wrapper taking a
117
+ // single argument hashes only the first, silently produces the wrong
118
+ // digest, and every genuine signature is then reported as INVALID — no
119
+ // error, no exception, just an authenticity check that always says no.
120
+ // Verified against a real CLI-produced signature; the single-argument form
121
+ // failed every positive case while passing every negative one, which is
122
+ // the most misleading shape a bug of this kind can take.
123
+ const concat = (parts: Uint8Array[]): Uint8Array => {
124
+ if (parts.length === 1) return parts[0];
125
+ let total = 0;
126
+ for (const p of parts) total += p.length;
127
+ const out = new Uint8Array(total);
128
+ let off = 0;
129
+ for (const p of parts) {
130
+ out.set(p, off);
131
+ off += p.length;
132
+ }
133
+ return out;
134
+ };
135
+ const sync = (...msgs: Uint8Array[]) => sha512(concat(msgs));
136
+ const asyncFn = async (...msgs: Uint8Array[]) => sha512(concat(msgs));
137
+
138
+ // EACH BRANCH GETS ITS OWN try. Wrapping both in one is a trap, and it cost
139
+ // an afternoon: under v3 the `hashes` assignment succeeds and the `etc`
140
+ // object is FROZEN, so the v2-shaped assignment throws "object is not
141
+ // extensible" — discarding a verifier that was, by then, already correctly
142
+ // wired. Only "neither shape took" means unavailable.
143
+ let wired = false;
144
+
145
+ try {
146
+ if (ed.hashes && typeof ed.hashes === 'object') {
147
+ if (typeof ed.hashes.sha512 !== 'function') ed.hashes.sha512 = sync;
148
+ if (typeof ed.hashes.sha512Async !== 'function') ed.hashes.sha512Async = asyncFn;
149
+ wired = typeof ed.hashes.sha512 === 'function';
150
+ }
151
+ } catch {
152
+ /* frozen or absent — try the other shape */
153
+ }
154
+
155
+ try {
156
+ if (ed.etc && typeof ed.etc === 'object') {
157
+ if (typeof ed.etc.sha512Sync !== 'function') ed.etc.sha512Sync = sync;
158
+ if (typeof ed.etc.sha512Async !== 'function') ed.etc.sha512Async = asyncFn;
159
+ wired = wired || typeof ed.etc.sha512Sync === 'function';
160
+ }
161
+ } catch {
162
+ /* frozen or absent — `wired` already records whether the other shape took */
163
+ }
164
+
165
+ return wired;
166
+ }
167
+
168
+ let resolved: SignatureVerifier | null | undefined;
169
+
170
+ /**
171
+ * The built-in verifier, or null when the optional deps are not installed.
172
+ * Resolution is cached, including the negative result — a missing dependency
173
+ * does not become present at runtime, and retrying the require on every update
174
+ * check would be pure overhead.
175
+ */
176
+ export function getBuiltinVerifier(): SignatureVerifier | null {
177
+ if (resolved !== undefined) return resolved;
178
+
179
+ const ed = loadEd25519();
180
+ const sha512 = loadSha512();
181
+
182
+ if (!ed || !sha512) {
183
+ resolved = null;
184
+ return null;
185
+ }
186
+
187
+ if (!wireSha512(ed, sha512)) {
188
+ // A shape neither branch matched — a @noble major this SDK predates.
189
+ // Report "no verifier", which is actionable, rather than letting every
190
+ // update fail deep inside the curve code with an opaque error.
191
+ logger.error(
192
+ '[OTA] @noble/ed25519 is installed but its SHA-512 provider could not be ' +
193
+ 'wired (unrecognised version shape). Supply `ota.verifySignature` ' +
194
+ 'yourself, or pin a @noble/ed25519 version this SDK supports.',
195
+ );
196
+ resolved = null;
197
+ return null;
198
+ }
199
+
200
+ resolved = async ({ messageHex, signature, publicKey }) => {
201
+ const message = hexToBytes(messageHex);
202
+ const pub = hexToBytes(publicKey);
203
+ const sig = decodeSignature(signature);
204
+
205
+ if (!message) {
206
+ logger.error('[OTA] Bundle SHA-256 is not valid hex — refusing to stage.');
207
+ return false;
208
+ }
209
+ if (!pub || pub.length !== ED25519_PUBLIC_KEY_BYTES) {
210
+ // Worth naming precisely: a mistyped or wrongly-encoded key would
211
+ // otherwise present as "every update is a forgery".
212
+ logger.error(
213
+ `[OTA] ota.publicSigningKey must be ${ED25519_PUBLIC_KEY_BYTES} bytes of hex ` +
214
+ `(${ED25519_PUBLIC_KEY_BYTES * 2} characters) — got ` +
215
+ `${pub ? `${pub.length} bytes` : 'a value that is not hex'}.`,
216
+ );
217
+ return false;
218
+ }
219
+ if (!sig) {
220
+ logger.error('[OTA] Bundle signature is not a 64-byte hex/base64 value.');
221
+ return false;
222
+ }
223
+
224
+ // @noble THROWS rather than returning false for bytes that are not a
225
+ // well-formed point — which is most forgeries, since a tampered
226
+ // signature usually decodes to garbage rather than to a valid-but-wrong
227
+ // point. Swallowing that here is deliberate: from the SDK's side a
228
+ // malformed signature IS a rejection, and letting it escape would
229
+ // surface as `verifier_threw`, the outcome reserved for a HOST verifier
230
+ // misbehaving. Conflating "this bundle is forged" with "your verifier
231
+ // is broken" would point every investigation in the wrong direction.
232
+ try {
233
+ // SYNC FIRST, and this is not a style preference. @noble's
234
+ // `verifyAsync` reaches for `crypto.subtle` — "crypto.subtle must be
235
+ // defined, consider polyfill" — which React Native does not provide
236
+ // and neither does a plain Node test environment. The sync `verify`
237
+ // uses the SHA-512 provider wired above and needs no WebCrypto, so
238
+ // it is the path that actually works on a phone. Verification is a
239
+ // few hundred microseconds over a 32-byte digest, once per update
240
+ // check, so there is nothing to gain from the async form anyway.
241
+ if (typeof ed.verify === 'function') return ed.verify(sig, message, pub);
242
+ if (typeof ed.verifyAsync === 'function') return await ed.verifyAsync(sig, message, pub);
243
+ return false;
244
+ } catch {
245
+ return false;
246
+ }
247
+ };
248
+
249
+ __DEV__ &&
250
+ logger.debug('[OTA] Using built-in ed25519 verifier (@noble/ed25519 detected).');
251
+ return resolved;
252
+ }
253
+
254
+ /** Test seam — clears the cached resolution. */
255
+ export function _resetBuiltinVerifier(): void {
256
+ resolved = undefined;
257
+ }
@@ -0,0 +1,41 @@
1
+ /**
2
+ * Isolated lazy loader for the OPTIONAL `@noble/ed25519` dep.
3
+ *
4
+ * WHY ITS OWN FILE: Metro's dependency collector emits a dependency map one
5
+ * entry short for a module containing TWO OR MORE different-string inline
6
+ * `require()` calls, so the require indices desync and `_dependencyMap[N]`
7
+ * reads `undefined` ("Requiring unknown module 'undefined'"). Exactly ONE
8
+ * inline require per module avoids the miscount. `loadSha512` is a sibling file
9
+ * for the same reason — see `push/adapters/loadNotifee.ts`, which hit this first.
10
+ *
11
+ * The string must still be STATICALLY resolvable at bundle time; hosts that do
12
+ * not install it stub it via `withScaleBun`.
13
+ */
14
+
15
+ /** The subset of the @noble/ed25519 surface this SDK uses. */
16
+ export interface NobleEd25519 {
17
+ verifyAsync?: (sig: Uint8Array, msg: Uint8Array, pub: Uint8Array) => Promise<boolean>;
18
+ verify?: (sig: Uint8Array, msg: Uint8Array, pub: Uint8Array) => boolean;
19
+ /** v3 shape: `ed.hashes.sha512` */
20
+ hashes?: { sha512?: unknown; sha512Async?: unknown };
21
+ /** v2 shape: `ed.etc.sha512Sync` */
22
+ etc?: { sha512Sync?: unknown; sha512Async?: unknown };
23
+ }
24
+
25
+ export function loadEd25519(): NobleEd25519 | null {
26
+ try {
27
+ const mod = require('@noble/ed25519');
28
+ const ed = (mod?.default ?? mod) as NobleEd25519;
29
+ // Validate the API actually used, not mere truthiness: when the package
30
+ // is absent `withScaleBun` resolves it to an EMPTY STUB MODULE, which is
31
+ // a perfectly truthy object. A stub must read as "unavailable", because
32
+ // treating it as available would make every signed update fail with a
33
+ // crypto error instead of the actionable "no verifier" message.
34
+ if (typeof ed?.verifyAsync === 'function' || typeof ed?.verify === 'function') {
35
+ return ed;
36
+ }
37
+ return null;
38
+ } catch {
39
+ return null;
40
+ }
41
+ }
@@ -0,0 +1,35 @@
1
+ /**
2
+ * Isolated lazy loader for the OPTIONAL `@noble/hashes` SHA-512.
3
+ *
4
+ * Separate file from `loadEd25519` because Metro miscounts a module holding two
5
+ * different-string inline `require()` calls — see the comment there.
6
+ *
7
+ * ed25519 is defined in terms of SHA-512, and React Native has no native
8
+ * SHA-512, so @noble/ed25519 cannot verify anything until a hash provider is
9
+ * wired into it. Which property it expects differs by major version, so the
10
+ * wiring lives in `builtinVerifier`, not here; this module only obtains the
11
+ * function.
12
+ */
13
+
14
+ export type Sha512Fn = (msg: Uint8Array) => Uint8Array;
15
+
16
+ export function loadSha512(): Sha512Fn | null {
17
+ try {
18
+ // The `.js` SUFFIX IS REQUIRED, not stylistic. @noble/hashes v2 declares
19
+ // its exports map with extensions — `"./sha2.js"`, not `"./sha2"` — so
20
+ // the extensionless form misses the map entirely. Node still resolves it
21
+ // by falling back to file-based lookup, which is why it passes here,
22
+ // but Metro prints
23
+ // "Attempted to import … not listed in the exports … Falling back to
24
+ // file-based resolution"
25
+ // on every bundle, and that fallback is exactly what a stricter resolver
26
+ // (or a future Metro) drops. Caught while bundling a real Expo app.
27
+ const mod = require('@noble/hashes/sha2.js');
28
+ const sha512 = (mod?.sha512 ?? mod?.default?.sha512) as Sha512Fn | undefined;
29
+ // A stubbed module yields undefined here, which correctly reads as
30
+ // "unavailable" rather than throwing deep inside the curve code later.
31
+ return typeof sha512 === 'function' ? sha512 : null;
32
+ } catch {
33
+ return null;
34
+ }
35
+ }
@@ -0,0 +1,117 @@
1
+ /**
2
+ * Native ed25519 verifier — platform crypto wrapped as a SignatureVerifier.
3
+ *
4
+ * WHY IT EXISTS. The built-in @noble verifier runs in JS, inside the very
5
+ * bundle it protects: an attacker who lands one malicious bundle can neuter a
6
+ * JS check for every update after it. Platform crypto (CryptoKit on iOS,
7
+ * Android's conscrypt on API 33+) sits outside the bundle's reach — and using
8
+ * it also drops the runtime dependency on the optional @noble peers wherever
9
+ * the OS provides ed25519.
10
+ *
11
+ * WHAT IT DOES NOT FIX, stated plainly: the ORCHESTRATION still lives in JS.
12
+ * A hostile bundle can skip calling any verifier and drive the native staging
13
+ * methods directly. Moving the crypto native shrinks the attack surface (no
14
+ * more tampering with a bundled crypto lib to flip a verdict) but the full
15
+ * close needs native-ENFORCED staging with a natively-pinned key — an
16
+ * architectural change tracked separately, not smuggled into this one.
17
+ *
18
+ * VERDICT CONTRACT (mirrors the spec): the native side resolves
19
+ * 'valid' | 'invalid' | 'unavailable'. 'invalid' is a definitive NO.
20
+ * 'unavailable' (Android < 33, malformed input, machinery failure) means this
21
+ * source cannot answer — the composed verifier below then delegates to the
22
+ * @noble builtin, and when that is absent too it THROWS, which the policy
23
+ * layer converts to a rejection. Every path that cannot verify refuses.
24
+ */
25
+
26
+ import NativeScaleBunOta from '../../../specs/NativeScaleBunOta';
27
+ import { logger } from '../../../core/logger/internalLogger';
28
+ import { decodeSignature, getBuiltinVerifier } from './builtinVerifier';
29
+ import type { SignatureVerifier } from '../signature';
30
+
31
+ const ED25519_PUBLIC_KEY_HEX_CHARS = 64;
32
+
33
+ /** bytes → lowercase hex (the native side takes clean hex only). */
34
+ function bytesToHex(bytes: Uint8Array): string {
35
+ let out = '';
36
+ for (const b of bytes) out += b.toString(16).padStart(2, '0');
37
+ return out;
38
+ }
39
+
40
+ /** Strict lowercase-hex normalization; null when the value is not hex. */
41
+ function normalizeHex(value: string, expectedChars: number): string | null {
42
+ const clean = value.trim().toLowerCase().replace(/^0x/, '');
43
+ if (clean.length !== expectedChars || /[^0-9a-f]/.test(clean)) return null;
44
+ return clean;
45
+ }
46
+
47
+ let resolved: SignatureVerifier | null | undefined;
48
+
49
+ /**
50
+ * The native-first verifier, or null when the native module (or its
51
+ * verifyEd25519 method — an app running new JS against an old binary) is
52
+ * absent. Cached like the builtin: module availability does not change at
53
+ * runtime, and this is consulted on every update check.
54
+ */
55
+ export function getNativeVerifier(): SignatureVerifier | null {
56
+ if (resolved !== undefined) return resolved;
57
+
58
+ const native = NativeScaleBunOta;
59
+ if (!native || typeof (native as any).verifyEd25519 !== 'function') {
60
+ // Old binary, Jest, web/SSR — not an error, just not this source.
61
+ resolved = null;
62
+ return null;
63
+ }
64
+
65
+ resolved = async ({ messageHex, signature, publicKey }) => {
66
+ // All decoding and validation happens HERE, in one place, so both
67
+ // platforms' native code only ever sees clean fixed-length hex. The
68
+ // signature may arrive hex or base64 (the wire allows both) — reuse
69
+ // the builtin's decoder rather than growing a second, subtly
70
+ // different one.
71
+ const message = normalizeHex(messageHex, 64);
72
+ const key = normalizeHex(publicKey, ED25519_PUBLIC_KEY_HEX_CHARS);
73
+ const sigBytes = decodeSignature(signature);
74
+ if (!message || !key || !sigBytes) {
75
+ // Same messages-by-symptom philosophy as the builtin: a mistyped
76
+ // key must not present as "every update is a forgery".
77
+ logger.error(
78
+ '[OTA] Signature inputs malformed (bundle hash, signature, or public key) — refusing to stage.',
79
+ );
80
+ return false;
81
+ }
82
+
83
+ let verdict: string;
84
+ try {
85
+ verdict = await (native as any).verifyEd25519(message, bytesToHex(sigBytes), key);
86
+ } catch (err: any) {
87
+ // A rejected promise is machinery failure, not a forgery verdict.
88
+ logger.warn(`[OTA] Native ed25519 verify failed to run: ${err?.message ?? err}`);
89
+ verdict = 'unavailable';
90
+ }
91
+
92
+ if (verdict === 'valid') return true;
93
+ if (verdict === 'invalid') return false;
94
+
95
+ // 'unavailable' (Android < 33) — fall back to the JS verifier so those
96
+ // devices keep verifying rather than losing enforcement.
97
+ const builtin = getBuiltinVerifier();
98
+ if (builtin) {
99
+ return builtin({ messageHex, signature, publicKey });
100
+ }
101
+ // No source can verify. Throwing (rather than returning false) keeps
102
+ // the policy layer's outcome labels honest: this surfaces as machinery
103
+ // failure with an actionable message, not as "the bundle is forged".
104
+ throw new Error(
105
+ 'ed25519 unavailable: this OS has no native implementation (Android < 13) and the ' +
106
+ 'optional peers @noble/ed25519 + @noble/hashes are not installed.',
107
+ );
108
+ };
109
+
110
+ __DEV__ && logger.debug('[OTA] Using native ed25519 verifier (platform crypto).');
111
+ return resolved;
112
+ }
113
+
114
+ /** Test seam — clears the cached resolution. */
115
+ export function _resetNativeVerifier(): void {
116
+ resolved = undefined;
117
+ }
@@ -1,4 +1,6 @@
1
1
  import { logger } from '../../core/logger/internalLogger';
2
+ import { getBuiltinVerifier } from './crypto/builtinVerifier';
3
+ import { getNativeVerifier } from './crypto/nativeVerifier';
2
4
 
3
5
  /**
4
6
  * Bundle signature verification (OTA-03).
@@ -13,10 +15,17 @@ import { logger } from '../../core/logger/internalLogger';
13
15
  * download and nothing else. On a platform whose entire purpose is remote code
14
16
  * delivery, that is the control that matters most.
15
17
  *
16
- * WHY IT IS SHAPED LIKE THIS. The SDK ships zero third-party runtime
17
- * dependencies, and React Native has no built-in ed25519. So verification is
18
- * delegated to a host-provided verifier when one is installed, and the SDK's job
19
- * is to decide unambiguouslywhat happens when there is not one.
18
+ * WHY IT IS SHAPED LIKE THIS. React Native has no built-in ed25519, so the
19
+ * verification primitive has to come from somewhere. It is resolved in order:
20
+ * a host-supplied verifier, else the built-in one assembled from the OPTIONAL
21
+ * `@noble/ed25519` + `@noble/hashes` peers, else nothing and the SDK's job is
22
+ * to decide, unambiguously, what happens in that last case.
23
+ *
24
+ * The built-in path exists because requiring every adopter to hand-write a
25
+ * verifier put the most security-critical operation in the product in code the
26
+ * SDK could neither test nor audit, and made a routine dependency bump able to
27
+ * silently stop all updates. See `crypto/builtinVerifier.ts`. Signing stays
28
+ * opt-in, and apps that never adopt it carry no curve arithmetic.
20
29
  *
21
30
  * THE POLICY, which is the important part:
22
31
  *
@@ -44,15 +53,26 @@ export type SignatureVerifier = (input: {
44
53
  }) => boolean | Promise<boolean>;
45
54
 
46
55
  export interface SignatureConfig {
47
- /** ed25519 public key shipped in the app binary. Absent = signing not adopted. */
48
- publicKey?: string;
56
+ /**
57
+ * ed25519 public key(s) shipped in the app binary. Absent = signing not
58
+ * adopted. An ARRAY pins several keys at once and a bundle is accepted when
59
+ * ANY of them verifies — this is what makes key rotation possible without an
60
+ * app-store release: ship a build pinning [old, new], start signing with new,
61
+ * drop old from the next build. With a single pinnable key, losing the
62
+ * private key meant no OTA capability until a new binary cleared review —
63
+ * the exact emergency OTA exists to solve.
64
+ */
65
+ publicKey?: string | string[];
49
66
  /** Host-provided ed25519 verification function. */
50
67
  verifier?: SignatureVerifier;
51
68
  }
52
69
 
53
70
  export type SignatureOutcome =
54
71
  | { ok: true; reason: 'verified' | 'not_configured' }
55
- | { ok: false; reason: 'no_verifier' | 'invalid_signature' | 'missing_signature' | 'verifier_threw' };
72
+ | {
73
+ ok: false;
74
+ reason: 'no_verifier' | 'invalid_signature' | 'missing_signature' | 'verifier_threw' | 'no_keys';
75
+ };
56
76
 
57
77
  let warnedNotConfigured = false;
58
78
 
@@ -69,10 +89,18 @@ export async function verifyBundleSignature(
69
89
  signature: string | undefined,
70
90
  config: SignatureConfig | undefined,
71
91
  ): Promise<SignatureOutcome> {
72
- const publicKey = config?.publicKey;
92
+ const rawKey = config?.publicKey;
93
+
94
+ // Normalize to a list. A single non-empty string is the pre-rotation config
95
+ // shape and behaves exactly as before; an array pins several keys at once.
96
+ const keys = (Array.isArray(rawKey) ? rawKey : rawKey ? [rawKey] : []).filter(
97
+ (k): k is string => typeof k === 'string' && k.trim().length > 0,
98
+ );
73
99
 
74
- // Signing not adopted by this app — nothing to enforce.
75
- if (!publicKey) {
100
+ // Signing not adopted by this app — nothing to enforce. Parity note: a
101
+ // falsy single value (undefined, '') has always meant "not configured" and
102
+ // still does.
103
+ if (rawKey === undefined || rawKey === '' || rawKey === null) {
76
104
  if (!warnedNotConfigured) {
77
105
  warnedNotConfigured = true;
78
106
  logger.warn(
@@ -83,6 +111,20 @@ export async function verifyBundleSignature(
83
111
  return { ok: true, reason: 'not_configured' };
84
112
  }
85
113
 
114
+ // The host PROVIDED a key config that resolves to zero usable keys — an
115
+ // empty array, or an array of blank strings. That is a broken attempt to
116
+ // enable signing, not an absence of one, and the two must not collapse:
117
+ // treating `publicSigningKeys: []` as "not configured" would let a config
118
+ // mistake silently downgrade an app to unverified installs. Fail closed.
119
+ if (keys.length === 0) {
120
+ logger.error(
121
+ '[OTA] Signing key config resolves to zero usable keys (empty array or blank ' +
122
+ 'strings) — refusing to stage. Remove the config to disable signing, or pin ' +
123
+ 'at least one real key.',
124
+ );
125
+ return { ok: false, reason: 'no_keys' };
126
+ }
127
+
86
128
  // The app opted in, so a bundle without a signature is a refusal, not a pass.
87
129
  if (!signature) {
88
130
  logger.error(
@@ -91,30 +133,71 @@ export async function verifyBundleSignature(
91
133
  return { ok: false, reason: 'missing_signature' };
92
134
  }
93
135
 
94
- if (typeof config?.verifier !== 'function') {
136
+ // Resolution order, and the order matters:
137
+ // 1. A host-supplied verifier ALWAYS wins. A team with its own crypto
138
+ // policy must be able to override whatever the SDK would otherwise pick.
139
+ // 2. Otherwise the NATIVE verifier (CryptoKit / Android 13+ platform
140
+ // ed25519). Preferred over the JS one because it runs outside the
141
+ // bundle it protects and needs no optional peers; on OS levels without
142
+ // ed25519 it delegates to the builtin internally.
143
+ // 3. Otherwise the built-in @noble verifier, if the optional peers are
144
+ // installed. This is the path that removes ~100 lines of hand-written
145
+ // crypto plumbing from every app that adopts signing.
146
+ // 4. Otherwise reject, because a configured key is a request for
147
+ // enforcement and quietly installing unverified code would turn a
148
+ // security feature into a placebo.
149
+ const verifier =
150
+ typeof config?.verifier === 'function'
151
+ ? config.verifier
152
+ : (getNativeVerifier() ?? getBuiltinVerifier());
153
+
154
+ if (!verifier) {
95
155
  logger.error(
96
156
  '[OTA] A signing key is configured but no signature verifier is available — ' +
97
- 'refusing to stage. Provide `ota.verifySignature` so signatures can be checked.',
157
+ 'refusing to stage. Either install the optional peers ' +
158
+ '`@noble/ed25519` and `@noble/hashes` (the SDK then verifies with no ' +
159
+ 'further code), or provide your own `ota.verifySignature`.',
98
160
  );
99
161
  return { ok: false, reason: 'no_verifier' };
100
162
  }
101
163
 
102
- try {
103
- const valid = await config.verifier({
104
- messageHex: bundleSha256,
105
- signature,
106
- publicKey,
107
- });
108
- if (!valid) {
109
- logger.error('[OTA] Bundle signature is INVALID refusing to stage.');
110
- return { ok: false, reason: 'invalid_signature' };
164
+ // Try every pinned key; any single match accepts. The verifier contract is
165
+ // unchanged (one key per call) so host-supplied verifiers keep working.
166
+ //
167
+ // Outcome labelling when nothing matched, and why it matters: if at least
168
+ // one verifier call RAN TO COMPLETION and said no, the bundle failed
169
+ // verification — 'invalid_signature'. Only when EVERY call threw is the
170
+ // machinery itself suspect — 'verifier_threw'. Collapsing those (e.g. by
171
+ // letting the last key's throw win) would point an investigation at the
172
+ // host's verifier when the actual event was a forged bundle, or vice versa.
173
+ let sawThrow = false;
174
+ let sawCompletion = false;
175
+ for (const key of keys) {
176
+ try {
177
+ const valid = await verifier({
178
+ messageHex: bundleSha256,
179
+ signature,
180
+ publicKey: key,
181
+ });
182
+ sawCompletion = true;
183
+ if (valid) return { ok: true, reason: 'verified' };
184
+ } catch (err: any) {
185
+ // A throwing verifier is treated as a failed verification for this key,
186
+ // never as a pass — but the remaining keys still get their chance.
187
+ sawThrow = true;
188
+ logger.error(`[OTA] Signature verifier threw: ${err?.message ?? err}`);
111
189
  }
112
- return { ok: true, reason: 'verified' };
113
- } catch (err: any) {
114
- // A throwing verifier is treated as a failed verification, never as a pass.
115
- logger.error(`[OTA] Signature verifier threw: ${err?.message ?? err}`);
190
+ }
191
+
192
+ if (sawThrow && !sawCompletion) {
116
193
  return { ok: false, reason: 'verifier_threw' };
117
194
  }
195
+ logger.error(
196
+ keys.length > 1
197
+ ? `[OTA] Bundle signature is INVALID under all ${keys.length} pinned keys — refusing to stage.`
198
+ : '[OTA] Bundle signature is INVALID — refusing to stage.',
199
+ );
200
+ return { ok: false, reason: 'invalid_signature' };
118
201
  }
119
202
 
120
203
  /** Test seam — resets the once-per-process "not configured" warning. */