@scalebun/react-native 1.10.5 → 1.10.7

package/src/metro/serializerCompose.ts

@@ -106,6 +106,9 @@ export function discoverArtifacts(packageRoot: string): ArtifactMapping[] {
     return out;
 }
 
+/** One-shot guard so an Expo build does not print the pass-through notice per bundle. */
+let warnedUnknownShape = false;
+
 /**
  * Build the composing serializer. `hostSerializer` is the app's own customSerializer, if any.
  */
@@ -122,10 +125,43 @@ export function createComposingSerializer(
             const hostResult = await hostSerializer(entryPoint, preModules, graph, options);
             if (typeof hostResult === 'string') {
                 code = hostResult;
+            } else if (hostResult && typeof (hostResult as any).code !== 'string') {
+                /**
+                 * A shape this wrapper does not understand — pass it back UNTOUCHED.
+                 *
+                 * Expo is the case that matters. `expo/metro-config` installs a
+                 * serializer returning `{ artifacts: [...] }`, a multi-artifact
+                 * shape with no top-level `code`. Reading `.code` off it yielded
+                 * undefined, and returning `{ code: undefined, map }` made every
+                 * `expo export:embed` die with:
+                 *
+                 *   Serializer did not return expected format. The project copy
+                 *   of `expo/metro-config` may be out of date.
+                 *
+                 * — a message that sends you to upgrade Expo, which is not the
+                 * problem. The result: `withScaleBun` broke PRODUCTION BUNDLING
+                 * FOR EVERY EXPO APP, and the SDK's own marketing test app could
+                 * not build. Found by bundling it.
+                 *
+                 * Passing it through costs ScaleBun's source-map composition on
+                 * Expo (OTA stack traces stay mapped to the bundle rather than to
+                 * original sources). That is a real loss and strictly better than
+                 * a build that cannot run at all. Composing INTO an artifact
+                 * array is the follow-up; it must not be guessed at here.
+                 */
+                if (!warnedUnknownShape) {
+                    warnedUnknownShape = true;
+                    console.warn(
+                        '[ScaleBun/metro] The host serializer returned a shape this SDK does not ' +
+                            'compose (Expo returns { artifacts }). Passing it through unchanged — ' +
+                            'the build is correct, but ScaleBun source-map composition is skipped.',
+                    );
+                }
+                return hostResult as never;
             } else {
-                code = hostResult.code;
+                code = (hostResult as { code: string; map: string }).code;
                 try {
-                    mapObj = JSON.parse(hostResult.map);
+                    mapObj = JSON.parse((hostResult as { code: string; map: string }).map);
                 } catch {
                     // Host emitted an unparsable map; fall through and rebuild from the graph so
                     // the build still succeeds with a correct map rather than failing here.

package/src/public/ScaleBunFacade.ts

@@ -20,7 +20,7 @@ import { PersistentQueue } from '../pipeline/queue/persistentQueue';
 import { MemoryBackend, createStorageBackend } from '../storage/StorageBackend';
 import { HttpClient } from '../transport/http/httpClient';
 import { getDeviceId } from '../core/id/deviceId';
-import { mergeDeviceContext, resolveEventPlatform } from '../core/context/device';
+import { mergeDeviceContext, nativeDeviceContext, resolveEventPlatform } from '../core/context/device';
 import { coreContainer } from '../core/di/container';
 import { flushQueue } from '../pipeline/queue/flushQueue';
 import {
@@ -48,6 +48,7 @@ import type {
 } from '../features/replay/public/types';
 import { SDKBootstrapper } from '../bootstrap/SDKBootstrapper';
 import { EventTracker } from '../analytics/EventTracker';
+import { bridgeAdapter } from '../features/replay/bridge/adapters/bridgeAdapter';
 import {
     emitAutomaticEvent,
     type AutomaticEventName,
@@ -274,12 +275,17 @@ class ScaleBunFacade {
     /**
      * Boot the OTA orchestrator when the init config asks for it.
      *
-     * `publicSigningKey` is honoured here so signature enforcement is reachable
-     * from configuration alone. The SDK ships no ed25519 implementation, so a
-     * host that pins a key must also supply `ota.verifySignature`; pinning a key
-     * without a verifier is fail-CLOSED by design (signature.ts) — an update
-     * that cannot be verified is not installed. We say that out loud rather than
-     * letting the app discover it as a silent no-update condition.
+     * `publicSigningKey` / `publicSigningKeys` are honoured here so signature
+     * enforcement is reachable from configuration alone. The list form exists
+     * for key ROTATION: a build pinning [old, new] keeps verifying while the
+     * server moves to the new key, so replacing a key never needs an emergency
+     * store release. Both fields merge (deduplicated) into one pinned set.
+     *
+     * Verification comes from `ota.verifySignature` when supplied, else the
+     * built-in @noble-based verifier (optional peers). Pinning keys with
+     * NEITHER available is fail-CLOSED by design (signature.ts) — an update
+     * that cannot be verified is not installed. We say that out loud rather
+     * than letting the app discover it as a silent no-update condition.
      */
     private _maybeStartOta(rawConfig: any): void {
         const ota = rawConfig?.ota;
@@ -289,16 +295,49 @@ class ScaleBunFacade {
             // module (or touch the native spec) at import time.
             // eslint-disable-next-line @typescript-eslint/no-var-requires
             const { otaOrchestrator } = require('../features/ota/OtaOrchestrator');
-            const publicKey = ota.publicSigningKey;
+            const rawSingle = ota.publicSigningKey;
+            const rawList = ota.publicSigningKeys;
+            const publicKeys = Array.from(
+                new Set(
+                    [
+                        ...(typeof rawSingle === 'string' && rawSingle ? [rawSingle] : []),
+                        ...(Array.isArray(rawList) ? rawList : []),
+                    ].filter((k: unknown): k is string => typeof k === 'string' && k.trim().length > 0),
+                ),
+            );
+            // Signing was REQUESTED if a usable key exists, or the host passed a
+            // keys array at all — an empty one included. `publicSigningKeys: []`
+            // is a broken attempt to enable signing, and it must flow through to
+            // signature.ts's fail-closed handling, not silently disable signing.
+            const signingRequested = publicKeys.length > 0 || Array.isArray(rawList);
             const verifier = ota.verifySignature;
-            if (publicKey && typeof verifier !== 'function') {
-                logger.warn(
-                    '[ScaleBun] ota.publicSigningKey is set but ota.verifySignature is not a function. ' +
-                        'Signature checking is fail-closed: updates will be REJECTED until a verifier is supplied.',
-                );
+            if (signingRequested && typeof verifier !== 'function') {
+                // A host verifier is optional since the built-in one landed — the
+                // old unconditional warning here told every correctly-configured
+                // app that its updates would be rejected. Warn only when neither
+                // verifier can actually be resolved.
+                // eslint-disable-next-line @typescript-eslint/no-var-requires
+                const { getBuiltinVerifier } = require('../features/ota/crypto/builtinVerifier');
+                if (!getBuiltinVerifier()) {
+                    logger.warn(
+                        '[ScaleBun] A signing key is pinned but no signature verifier is available. ' +
+                            'Signature checking is fail-closed: updates will be REJECTED until one exists. ' +
+                            'Install the optional peers `@noble/ed25519` + `@noble/hashes` (no further ' +
+                            'code needed), or supply `ota.verifySignature`.',
+                    );
+                }
             }
             otaOrchestrator.init({
-                ...(publicKey ? { signature: { publicKey, verifier } } : {}),
+                ...(signingRequested
+                    ? {
+                          signature: {
+                              // Single key stays a plain string — the shape every
+                              // existing consumer and test already handles.
+                              publicKey: publicKeys.length === 1 ? publicKeys[0] : publicKeys,
+                              verifier,
+                          },
+                      }
+                    : {}),
                 ...(typeof ota.healthyTimeoutMs === 'number'
                     ? { healthyTimeoutMs: ota.healthyTimeoutMs }
                     : {}),
@@ -368,6 +407,8 @@ class ScaleBunFacade {
                  * the whole time. The SDK knows the device; the integrator is guessing at it.
                  * Everything outside the detected keys is still theirs.
                  */
+                // Everything Platform.constants knows. On iOS that is neither the model nor the
+                // manufacturer, so the bridge completes it below once it answers.
                 context: mergeDeviceContext(rawConfig?.context),
                 // Use the same foreground id as replay/journey capture. The
                 // callback is resolved per event because the session subsystem
@@ -384,6 +425,19 @@ class ScaleBunFacade {
             this._eventTracker.start();
             __DEV__ && logger.info('[ScaleBun] Envelope event tracking started → /v1/batch.');
 
+            // Complete the device context from the native bridge.
+            //
+            // `Platform.constants` answers Android synchronously — model and manufacturer ride the
+            // first event. It answers NEITHER on iOS, so without this every iOS installation
+            // reported no device model at all: `nativeDeviceContext` existed for exactly this and
+            // had no caller, and the bridge's own answer was `UIDevice.current.model` — the string
+            // "iPhone", identical on every iPhone ever made.
+            //
+            // Fire-and-forget on purpose. The bridge is async and absent entirely on Expo Go or an
+            // older native binary; waiting on it would delay the first event, and failing on it
+            // would take analytics down over a nice-to-have field.
+            this._applyNativeDeviceContext(this._eventTracker);
+
             // Android: capture the Play Install Referrer once per install → feeds the
             // deterministic click_id path + a one-off install_referrer event (UTM/gclid).
             // Fire-and-forget; no-op off Android.
@@ -405,6 +459,30 @@ class ScaleBunFacade {
         }
     }
 
+
+    /**
+     * Fold the native bridge's device facts into the analytics context once it answers.
+     *
+     * Detected values never overwrite a populated one with an empty one — `nativeDeviceContext`
+     * drops absent keys and `applyDetectedContext` ignores an empty patch — so a bridge that
+     * cannot answer leaves whatever `Platform.constants` already found.
+     */
+    private _applyNativeDeviceContext(tracker: EventTracker): void {
+        Promise.resolve()
+            .then(() => bridgeAdapter.getDeviceInfo())
+            .then(info => {
+                if (!info) return;
+                tracker.applyDetectedContext(
+                    nativeDeviceContext({
+                        osVersion: info.osVersion,
+                        deviceModel: info.deviceModel,
+                        // iOS ships no manufacturer over the bridge; it is a constant there and the
+                        // static path already set it. Android's arrives via Platform.constants.
+                    }),
+                );
+            })
+            .catch(() => { /* bridge unavailable — the static context stands */ });
+    }
     /**
      * Android-only: read the Play Install Referrer once per install and route it into
      * attribution. `scalebun_click_id` → the deterministic click path; the full
@@ -486,6 +564,42 @@ class ScaleBunFacade {
     }
 
     /** Convenience: emit a Phase 1 purchase event (revenue + currency + transaction_id). */
+    /**
+     * Declare which UI state the user is looking at, so taps are attributed to the surface they
+     * happened on rather than averaged across every variant of the screen.
+     *
+     *     ScaleBun.setUiState('filter-sheet', 'open');
+     *     ScaleBun.setUiState('checkout-step', 'payment');
+     *
+     * Call it when the state CHANGES — the value is read at tap time, so it only has to be right by
+     * the time the next tap lands. On React Native this is the ONLY source of UI state: unlike the web,
+     * there is no queryable accessibility tree that says a sheet is up, and guessing would produce a
+     * state key that is right on some apps and silently wrong on others.
+     *
+     * Names and values are identifiers, not content: they become query keys in the dashboard, so a
+     * person's name or a cart total does not belong in one. `;`, `:` and `|` are stripped and both
+     * halves are capped at 32 characters.
+     */
+    public setUiState(name: string, value: string): void {
+        try {
+            const { setUiState } = require('../features/journey/uiState');
+            setUiState(name, value);
+        } catch { /* no-throw: a state declaration must never break the host */ }
+    }
+
+    /**
+     * Stop reporting a UI state dimension — or, with no argument, all of them.
+     *
+     * Clear on screen unmount. A declaration left behind follows the user onto a surface where it means
+     * nothing, and every tap there is filed under a state that was not on screen.
+     */
+    public clearUiState(name?: string): void {
+        try {
+            const { clearUiState } = require('../features/journey/uiState');
+            clearUiState(name);
+        } catch { /* no-throw */ }
+    }
+
     public trackPurchase(input: { revenue: number; currency: string; transactionId: string; [k: string]: any }): void {
         noThrow(() => this._eventTracker?.trackPurchase(input));
     }

package/src/specs/NativeScaleBunOta.ts

@@ -85,6 +85,30 @@ export interface Spec extends TurboModule {
    * `recreateReactContextInBackground()` (bridge). iOS: RCTReloadCommand.
    */
   restartApp(): void;
+
+  /**
+   * Verify a detached ed25519 signature in NATIVE code.
+   *
+   * Exists because the JS verifier runs inside the very bundle it protects —
+   * an attacker who lands one malicious bundle can neuter a JS check for every
+   * update after it. Platform crypto is outside the bundle's reach, and it also
+   * removes the runtime dependency on the optional @noble peers wherever the OS
+   * provides ed25519 (iOS 13+ CryptoKit everywhere; Android API 33+).
+   *
+   * All three arguments are lowercase hex, pre-validated by the JS caller:
+   * the 32-byte bundle SHA-256 (the signature is over its RAW BYTES, matching
+   * the CLI's signing contract), the 64-byte signature, the 32-byte public key.
+   *
+   * Resolves a verdict STRING, not a boolean, because "the signature is wrong"
+   * and "this OS cannot check" must never collapse into one value:
+   *   'valid'       — signature verifies under the key
+   *   'invalid'     — it does not; the caller must refuse the bundle
+   *   'unavailable' — this OS level has no ed25519 (Android < 33); the caller
+   *                   falls back to the JS verifier
+   * A rejected promise is machinery failure and the caller treats it as
+   * 'unavailable' — never as 'valid'.
+   */
+  verifyEd25519(messageHex: string, signatureHex: string, publicKeyHex: string): Promise<string>;
 }
 
 /**