@sapui5/sap.ushell 1.140.0 → 1.141.1

package/src/main/js/sap/ushell/adapters/local/FlpLaunchPageAdapter.js

@@ -3,7 +3,7 @@
 /**
  * @fileOverview The Unified Shell's page builder adapter for the 'demo' platform.
  *
- * @version 1.140.0
+ * @version 1.141.1
  */
 sap.ui.define([
     "sap/base/Log",
@@ -47,7 +47,7 @@ sap.ui.define([
     View,
     Device,
     ResourceModel,
-    OData,
+    datajs,
     hasher,
     jQuery,
     Config,
@@ -96,13 +96,13 @@ sap.ui.define([
                 serviceRefreshInterval = 10000;
             }
             oTile.intervalTimer = window.setInterval(() => {
-                OData.read(
+                datajs.read(
                     `${oTile.properties.serviceUrl}?id=${oTile.id}&t=${new Date().getTime()}`,
                     () => {
                         Log.debug(`Dynamic tile service call succeed for tile ${oTile.id}`);
                     },
-                    (sMessage) => {
-                        Log.debug(`Dynamic tile service call failed for tile ${oTile.id}, error message:${sMessage}`);
+                    (oDataJsError) => {
+                        Log.debug(`Dynamic tile service call failed for tile ${oTile.id}, error message:${oDataJsError.message}`);
                     });
             }, ushellUtils.sanitizeTimeoutDelay(serviceRefreshInterval));
         }
@@ -345,7 +345,7 @@ sap.ui.define([
                         .done((oExistingGroup) => {
                             // Use the reject function in order to specify that an error has occurred.
                             // Pass the existing group's title that we got from the server to the reject function
-                            oDfd.reject(oExistingGroup.title);
+                            oDfd.reject(new Error("Failed to set group title"), oExistingGroup.title);
                         })
                         // In case loading the existing group also fails, also call the reject function.
                         // TODO: what should the UI do in that case? leave the group as is or pass the title that we have from the oGroup parameter?
@@ -562,20 +562,20 @@ sap.ui.define([
                     if (!bFail) {
                         this._getTileView(oTile).done(oDfd.resolve);
                     } else {
-                        oDfd.reject();
+                        oDfd.reject(new Error("Failed to get tile view"));
                     }
                 }, getRequestTime());
             } else if (!bFail) {
                 this._getTileView(oTile).done(oDfd.resolve);
             } else {
-                oDfd.reject();
+                oDfd.reject(new Error("Failed to get tile view"));
             }
 
             return oDfd.promise();
         };
 
         this._getTileView = function (oTileData) {
-            let sError = "unknown error";
+            let sErrorText = "unknown error";
             const bIsLink = this.getTileType(oTileData) === "link";
             const oDfd = new jQuery.Deferred();
 
@@ -615,21 +615,21 @@ sap.ui.define([
 
                                 oDfd.resolve(oTileUI);
                             });
-                        } catch (e) {
+                        } catch (oError) {
                             oDfd.resolve(new GenericTile({
-                                header: e && (`${e.name}: ${e.message}`) || this.translationBundle.getText("failedTileCreationMsg"),
+                                header: oError && (`${oError.name}: ${oError.message}`) || this.translationBundle.getText("failedTileCreationMsg"),
                                 frameType: this._parseTileSizeToGenericTileFormat(oTileData.size)
                             }));
                         }
                         return;
                     }
 
-                    sError = `TileType: ${oTileData.tileType} not found!`;
+                    sErrorText = `TileType: ${oTileData.tileType} not found!`;
                 } else {
-                    sError = "No TileType defined!";
+                    sErrorText = "No TileType defined!";
                 }
                 oDfd.resolve(new GenericTile({
-                    header: sError,
+                    header: sErrorText,
                     frameType: this._parseTileSizeToGenericTileFormat(oTileData.size)
                 }));
             });
@@ -642,7 +642,7 @@ sap.ui.define([
 
             Promise.resolve().then(async () => {
                 let oCatalogTileInstancePromise;
-                let sError = "unknown error";
+                let sErrorText = "unknown error";
                 const bIsLink = this.getTileType(oTileData) === "link";
 
                 await this._translateTileProperties(oTileData);
@@ -681,20 +681,20 @@ sap.ui.define([
                                 this._applyDynamicTileInfoState(oCatalogTileUI);
                                 oDeferred.resolve(oCatalogTileUI);
                             });
-                        } catch (e) {
+                        } catch (oError) {
                             oDeferred.resolve(new GenericTile({
-                                header: e && (`${e.name}: ${e.message}`) || this.translationBundle.getText("failedTileCreationMsg"),
+                                header: oError && (`${oError.name}: ${oError.message}`) || this.translationBundle.getText("failedTileCreationMsg"),
                                 frameType: this._parseTileSizeToGenericTileFormat(oTileData.size)
                             }));
                         }
                         return;
                     }
-                    sError = `TileType: ${oTileData.tileType} not found!`;
+                    sErrorText = `TileType: ${oTileData.tileType} not found!`;
                 }
 
-                sError = "No TileType defined!";
+                sErrorText = "No TileType defined!";
                 oDeferred.resolve(new GenericTile({
-                    header: sError,
+                    header: sErrorText,
                     frameType: this._parseTileSizeToGenericTileFormat(oTileData.size)
                 }));
             });
@@ -1431,8 +1431,8 @@ sap.ui.define([
                 });
                 oDeferred.resolve(iCount);
             });
-            oGetGroupsPromise.fail(() => {
-                oDeferred.reject();
+            oGetGroupsPromise.fail((oError) => {
+                oDeferred.reject(oError);
             });
 
             return oDeferred.promise();

package/src/main/js/sap/ushell/adapters/local/LaunchPageAdapter.js

@@ -4,7 +4,7 @@
  * @fileOverview The Unified Shell's page builder adapter for the 'demo' platform.
  *
  * @deprecated since 1.100
- * @version 1.140.0
+ * @version 1.141.1
  */
 sap.ui.define([
     "sap/ushell/adapters/local/FlpLaunchPageAdapter"

package/src/main/js/sap/ushell/adapters/local/MenuAdapter.js

@@ -51,16 +51,16 @@ sap.ui.define([
      * @since 1.105.0
      * @private
      */
-    MenuAdapter.prototype.getContentNodes = function () {
+    MenuAdapter.prototype.getContentNodes = async function () {
         const vMenuData = this._oAdapterConfig.menuData;
 
         if (!vMenuData) {
             Log.error("No menuData specified in the adapter configuration.", null, "sap.ushell.adapters.local.MenuAdapter");
-            return Promise.reject(new Error("No menuData specified in the adapter configuration."));
+            throw new Error("No menuData specified in the adapter configuration.");
         }
 
         if (typeof vMenuData === "object") {
-            return Promise.resolve(vMenuData);
+            return vMenuData;
         }
 
         return fetch(vMenuData,
@@ -76,7 +76,7 @@ sap.ui.define([
             })
             .catch((oError) => {
                 Log.error("Menu entries were requested but could not be loaded from JSON file", oError);
-                return Promise.reject(new Error("Menu entries could not be fetched"));
+                throw new Error("Menu entries could not be fetched");
             });
     };
 

package/src/main/js/sap/ushell/adapters/local/NavTargetResolutionAdapter.js

@@ -2,7 +2,7 @@
 
 /**
  * @fileOverview The NavTargetResolution adapter for the demo platform used in scube ui5appruntime.scube.
- * @version 1.140.0
+ * @version 1.141.1
  * @deprecated since 1.120
  * @private
  */

package/src/main/js/sap/ushell/adapters/local/NavTargetResolutionInternalAdapter.js

@@ -2,7 +2,7 @@
 
 /**
  * @fileOverview The NavTargetResolutionInternal adapter for the demo platform.
- * @version 1.140.0
+ * @version 1.141.1
  * @since 1.120
  * @private
  */
@@ -97,7 +97,7 @@ sap.ui.define([
                     }
                     oDeferred.resolve(oReturnedResult);
                 } else {
-                    oDeferred.reject(`Could not resolve link '${sHashFragment}'`);
+                    oDeferred.reject(new Error(`Could not resolve link '${sHashFragment}'`));
                 }
             }
 
@@ -138,7 +138,7 @@ sap.ui.define([
                     if (aResult) {
                         oDeferred.resolve(aResult);
                     } else {
-                        oDeferred.reject(`Could not get links for '${sSemanticObject}'`);
+                        oDeferred.reject(new Error(`Could not get links for '${sSemanticObject}'`));
                     }
                 });
             }
@@ -184,7 +184,7 @@ sap.ui.define([
                 const oDeferredWrapper = new jQuery.Deferred();
                 aDeferrers.push(oDeferredWrapper.promise());
                 that.resolveHashFragment(sIntent)
-                    .fail((sErrorMessage) => {
+                    .fail((oError) => {
                         setResult(sIntent, false);
                         oDeferredWrapper.resolve();
                     })

package/src/main/js/sap/ushell/adapters/local/PageBuildingAdapter.js

@@ -3,7 +3,7 @@
 /**
  * @fileOverview The Unified Shell's page builder adapter for the 'demo' platform.
  * It creates chip instances from chip raw data. Compared to the other platforms this adapter has restricted functionality.
- * @version 1.140.0
+ * @version 1.141.1
  */
 sap.ui.define([
     "sap/ui/core/ComponentContainer",

package/src/main/js/sap/ushell/adapters/local/PagePersistenceAdapter.js

@@ -2,7 +2,7 @@
 
 /**
  * @fileOverview PagePersistenceAdapter for the local platform.
- * @version 1.140.0
+ * @version 1.141.1
  */
 sap.ui.define([
     "sap/ushell/utils",
@@ -45,7 +45,7 @@ sap.ui.define([
             if (oData.page.id === id) {
                 resolve(oData);
             }
-            reject({ error: `No page with id '${id}' was found.` });
+            reject(new Error(`No page with id '${id}' was found.`));
         });
     };
 

package/src/main/js/sap/ushell/adapters/local/PersonalizationAdapter.js

@@ -6,7 +6,7 @@
  *
  * The local personalization adapter can be configured to store data either in
  * the local storage (default) or in memory.
- * @version 1.140.0
+ * @version 1.141.1
  */
 sap.ui.define([
     "sap/ushell/utils",
@@ -78,7 +78,7 @@ sap.ui.define([
                 if (bDeletedAllPersonalizations) {
                     resolve();
                 } else {
-                    reject("could not delete personalization");
+                    reject(new Error("could not delete personalization"));
                 }
             }, 0);
         });

package/src/main/js/sap/ushell/adapters/local/PersonalizationV2Adapter.js

@@ -6,7 +6,7 @@
  *
  * The local personalization adapter can be configured to store data either in
  * the local storage (default) or in memory.
- * @version 1.140.0
+ * @version 1.141.1
  */
 sap.ui.define([
     "./PersonalizationAdapter"

package/src/main/js/sap/ushell/adapters/local/SearchAdapter.js

@@ -2,7 +2,7 @@
 /**
  * @fileOverview The Search adapter for the demo platform.
  *
- * @version 1.140.0
+ * @version 1.141.1
  */
 sap.ui.define([
 ], () => {

package/src/main/js/sap/ushell/adapters/local/SearchCEPAdapter.js

@@ -3,7 +3,7 @@
 /**
  * @fileOverview The Unified Shell's Search adapter for CEP Search
  *
- * @version 1.140.0
+ * @version 1.141.1
  */
 /* eslint-disable quote-props */
 sap.ui.define([], () => {
@@ -532,7 +532,7 @@ sap.ui.define([], () => {
                 "icon": "sap-icon://search",
                 "inboundIdentifier": "38cd162a-e185-448c-9c37-a4fc02b3d39d___GenericDefaultSemantic-__GenericDefaultAction",
                 // eslint-disable-next-line max-len
-                "url": "http://localhost:8080/ushell/test-resources/sap/ushell/shells/demo/FioriLaunchpad.Isolation.html?sap-isolation-enabled=true&sap-ui-debug=true#Action-search&/top=20&filter={\"dataSource\":{\"type\":\"Category\",\"id\":\"All\",\"label\":\"All\",\"labelPlural\":\"All\"},\"searchTerm\":\"app\",\"rootCondition\":{\"type\":\"Complex\",\"operator\":\"And\",\"conditions\":[]}}",
+                "url": "http://localhost:8080/ushell/test-resources/sap/ushell/shells/demo/FioriLaunchpad.Isolation.html?sap-ui-debug=true#Action-search&/top=20&filter={\"dataSource\":{\"type\":\"Category\",\"id\":\"All\",\"label\":\"All\",\"labelPlural\":\"All\"},\"searchTerm\":\"app\",\"rootCondition\":{\"type\":\"Complex\",\"operator\":\"And\",\"conditions\":[]}}",
                 "target": "_blank",
                 "recent": false,
                 "semanticObject": "Action",

package/src/main/js/sap/ushell/adapters/local/SupportTicketAdapter.js

@@ -3,7 +3,7 @@
 /**
  * @fileOverview The SupportTicket adapter for the local platform.
  *
- * @version 1.140.0
+ * @version 1.141.1
  */
 sap.ui.define([
 ], () => {

package/src/main/js/sap/ushell/adapters/local/Ui5ComponentLoaderAdapter.js

@@ -3,7 +3,7 @@
 /**
  * @fileOverview The Unified Shell's Ui5ComponentLoaderAdapter for the local platform
  *
- * @version 1.140.0
+ * @version 1.141.1
  */
 sap.ui.define([
 ], () => {

package/src/main/js/sap/ushell/adapters/local/UserDefaultParameterPersistenceAdapter.js

@@ -6,7 +6,7 @@
  *               TODO will be replaced by true persistence within this SP!
  *               This adapter delegates to the Personalization Adapter
  *
- * @version 1.140.0
+ * @version 1.141.1
  */
 sap.ui.define([
     "sap/ui/thirdparty/jquery",
@@ -71,9 +71,9 @@ sap.ui.define([
             oContainer.save(50)
                 .then(oDeferred.resolve.bind(oDeferred))
                 .catch(oDeferred.reject.bind(oDeferred));
-        }).fail((sMsg) => {
-            Log.error(sMsg);
-            oDeferred.reject(sMsg);
+        }).fail((oError) => {
+            Log.error("Parameter save failed", oError);
+            oDeferred.reject(oError);
         });
         return oDeferred.promise();
     };
@@ -102,9 +102,9 @@ sap.ui.define([
             oContainer.save()
                 .then(oDeferred.resolve.bind(oDeferred))
                 .catch(oDeferred.reject.bind(oDeferred));
-        }).fail((sMsg) => {
-            Log.error(sMsg);
-            oDeferred.reject(sMsg);
+        }).fail((oError) => {
+            Log.error("Parameter delete failed", oError);
+            oDeferred.reject(oError);
         });
         return oDeferred.promise();
     };
@@ -129,11 +129,11 @@ sap.ui.define([
             if (v) {
                 oDeferred.resolve(v);
             } else {
-                oDeferred.reject("no value ");
+                oDeferred.reject(new Error("no value "));
             }
-        }).fail((sMsg) => {
-            Log.error(sMsg);
-            oDeferred.reject(sMsg);
+        }).fail((oError) => {
+            Log.error("Parameter load failed", oError);
+            oDeferred.reject(oError);
         });
         return oDeferred.promise();
     };
@@ -155,9 +155,9 @@ sap.ui.define([
         this._getUDContainer(oSystemContext).done((oContainer) => {
             const v = oContainer.getItemKeys();
             oDeferred.resolve(v);
-        }).fail((sMsg) => {
-            Log.error(sMsg);
-            oDeferred.reject(sMsg);
+        }).fail((oError) => {
+            Log.error("Parameter load failed", oError);
+            oDeferred.reject(oError);
         });
         return oDeferred.promise();
     };

package/src/main/js/sap/ushell/adapters/local/UserInfoAdapter.js

@@ -2,7 +2,7 @@
 
 /**
  * @fileOverview The UserInfo adapter for the demo platform.
- * @version 1.140.0
+ * @version 1.141.1
  */
 sap.ui.define([
     "sap/ui/thirdparty/jquery",
@@ -54,11 +54,6 @@ sap.ui.define([
         this.updateUserPreferences = function (oUser) {
             const oDeferred = new jQuery.Deferred();
 
-            function logError (vError) {
-                const sError = `Failed to update user preferences: ${vError && vError.message ? vError.message : vError}`;
-                Log.error(sError, vError && vError.stack, "com.sap.ushell.adapters.local.UserInfo");
-            }
-
             Container.getServiceAsync("PersonalizationV2").then((oPersonalizationService) => {
                 const oScope = {
                     keyCategory: oPersonalizationService.KeyCategory.FIXED_KEY,
@@ -81,14 +76,14 @@ sap.ui.define([
                             .then(() => {
                                 oDeferred.resolve();
                             })
-                            .catch((vError) => {
-                                logError(vError);
-                                oDeferred.reject(vError);
+                            .catch((oError) => {
+                                Log.error("Failed to update user preferences:", oError, "com.sap.ushell.adapters.local.UserInfo");
+                                oDeferred.reject(oError);
                             });
                     })
-                    .catch((vError) => {
-                        logError(vError);
-                        oDeferred.reject(vError);
+                    .catch((oError) => {
+                        Log.error("Failed to update user preferences:", oError, "com.sap.ushell.adapters.local.UserInfo");
+                        oDeferred.reject(oError);
                     });
             });
 
@@ -105,7 +100,7 @@ sap.ui.define([
 
             // we need to have at least one theme
             if (oUserThemeConfiguration.length === 0) {
-                oDeferred.reject("no themes were configured");
+                oDeferred.reject(new Error("no themes were configured"));
             } else {
                 oDeferred.resolve({
                     options: oUserThemeConfiguration

package/src/main/js/sap/ushell/api/common/ComponentInstantiation.js

@@ -82,7 +82,7 @@ sap.ui.define([
                 return oComponentPropertiesWithComponentHandle.componentHandle.getInstance();
             } catch (oError) {
                 Log.error(`Cannot create UI5 component: ${oError.toString()}`, oError.stack, "sap.ushell.api.common.ComponentInstantiation");
-                return Promise.reject(oError);
+                throw oError;
             }
         }
 
@@ -112,7 +112,7 @@ sap.ui.define([
 
             const sCanonicalIntent = UrlParsing.constructShellHash(UrlParsing.parseShellHash(sIntent));
             if (!sCanonicalIntent) {
-                return Promise.reject("Navigation intent invalid!");
+                throw new Error("Navigation intent invalid!");
             }
 
             const NavTargetResolutionInternal = await Container.getServiceAsync("NavTargetResolutionInternal");
@@ -155,7 +155,7 @@ sap.ui.define([
                 oInstantiationData);
             } else if (oResolvedHashFragment.applicationType !== ApplicationType.URL.type && !(/^SAPUI5\.Component=/.test(oResolvedHashFragment.additionalInformation))) {
                 // For applications that are not of type 'URL', the additionalInformation has to provide a UI5 component.
-                return Promise.reject("The resolved target mapping is not of type UI5 component.");
+                throw new Error("The resolved target mapping is not of type UI5 component.");
             }
 
             return this.#createInstantiationData(oResolvedHashFragment, oInstantiationData);
@@ -178,8 +178,8 @@ sap.ui.define([
                 const Ui5ComponentLoader = await Container.getServiceAsync("Ui5ComponentLoader");
                 return Ui5ComponentLoader.createComponentData(oResolvedHashFragment);
             } catch (oError) {
-                Log.error(`Cannot get UI5 component data: ${oError}`, oError.stack, "sap.ushell.api.common.ComponentInstantiation");
-                return Promise.reject(oError);
+                Log.error("Cannot get UI5 component data:", oError, "sap.ushell.api.common.ComponentInstantiation");
+                throw oError;
             }
         }
 

package/src/main/js/sap/ushell/api/performance/Extension.js

@@ -23,8 +23,8 @@ sap.ui.define([
     /**
      * @alias sap.ushell.api.performance.Extension
      * @namespace
-     * @description The Extension class provides methods to manage navigation sources in the FESR (Front End Statistical Records).
-     * It allows adding the navigation sources
+     * @description The extension class provides methods to manage navigation sources in the Front End Statistical Records (FESR).
+     * It allows adding the navigation sources.
      *
      * @since 1.139.0
      * @private

package/src/main/js/sap/ushell/api/performance/NavigationSource.js

@@ -8,14 +8,14 @@ sap.ui.define([], () => {
     /**
      * @alias sap.ushell.api.performance.Extension.knownNavigationSources
      * @enum {string}
-     * Object that denotes all known navigation sources.
+     * Navigation sources can be used for the Front End Statistical Records (FESR).
      * @private
      * @ui5-restricted ux.eng.s4producthomes1
      * @since 1.139.0
      */
     this.oNavigationSource = {
         /**
-         * App Finder navigation source.
+         * App finder navigation source.
          * @since 1.139.0
          * @public
          */
@@ -27,13 +27,13 @@ sap.ui.define([], () => {
          */
         Application: "appl",
         /**
-         * Frequently Used navigation source.
+         * Frequently used navigation source.
          * @since 1.139.0
          * @public
          */
         FrequentlyUsed: "frUs",
         /**
-         * Recently Used navigation source.
+         * Recently used navigation source.
          * @since 1.139.0
          * @public
          */
@@ -45,19 +45,19 @@ sap.ui.define([], () => {
          */
         Situation: "situ",
         /**
-         * Search Tile navigation source.
+         * Search tile navigation source.
          * @since 1.139.0
          * @public
          */
         SearchCEP: "seCP",
         /**
-         * Search Direct Link navigation source.
+         * Search direct link navigation source.
          * @since 1.139.0
          * @public
          */
         SearchDirectLaunch: "seDL",
         /**
-         * Search Enterprise navigation source.
+         * Search enterprise navigation source.
          * @since 1.139.0
          * @public
          */
@@ -75,7 +75,7 @@ sap.ui.define([], () => {
          */
         Task: "task",
         /**
-         * To-Do navigation source.
+         * To-do navigation source.
          * @since 1.139.0
          * @public
          */