@sapui5/sap.ushell 1.140.0 → 1.141.1

package/src/main/js/sap/ushell/adapters/cdm/LaunchPageAdapter.js

@@ -4,7 +4,7 @@
  * @fileOverview The Unified Shell's LaunchPageAdapter for the
  *               'CDM' platform - Version 2 (V2)
  * @deprecated since 1.100
- * @version 1.140.0
+ * @version 1.141.1
  */
 sap.ui.define([
     "sap/ushell/adapters/cdm/_LaunchPage/readHome",
@@ -33,7 +33,8 @@ sap.ui.define([
     "sap/base/Log",
     "sap/ushell/UI5ComponentType",
     "sap/ushell/EventHub",
-    "sap/ushell/Container"
+    "sap/ushell/Container",
+    "sap/ushell/utils/LaunchpadError"
 ], (
     oReadHomePageUtils,
     oModifyHomePageUtils, // TODO should be loaded lazy only when really needed
@@ -61,7 +62,8 @@ sap.ui.define([
     Log,
     UI5ComponentType,
     EventHub,
-    Container
+    Container,
+    LaunchpadError
 ) => {
     "use strict";
 
@@ -214,8 +216,9 @@ sap.ui.define([
                 };
 
                 oDeferred.resolve(oTileResolutionResult);
-            }).fail((sErrorMsg) => {
-                oDeferred.reject(`Hash '${sIntent}' could not be resolved to a tile. ${sErrorMsg}`);
+            }).fail((oError) => {
+                Log.error(`Hash '${sIntent}' could not be resolved to a tile.`, oError);
+                oDeferred.reject(oError);
             });
 
             return oDeferred.promise();
@@ -244,8 +247,8 @@ sap.ui.define([
                         .then((oResult) => {
                             oDeferred.resolve(oResult);
                         })
-                        .catch((sErrorMessage) => {
-                            oDeferred.reject(sErrorMessage);
+                        .catch((oError) => {
+                            oDeferred.reject(oError);
                         });
                     return oDeferred.promise();
                 }
@@ -425,8 +428,18 @@ sap.ui.define([
 
             oResultPromise.done((oResolvedTile) => {
                 updateCaches(oResolvedTile);
-            }).fail((vFailureInfo) => {
-                mFailureCache[oTile.id] = vFailureInfo;
+            }).fail((oError) => {
+                if (oError instanceof LaunchpadError) {
+                    mFailureCache[oTile.id] = {
+                        logLevel: oError.details?.logLevel || oLogLevel.ERROR,
+                        message: oError.message
+                    };
+                } else {
+                    mFailureCache[oTile.id] = {
+                        logLevel: oLogLevel.ERROR,
+                        message: oError.toString()
+                    };
+                }
             });
 
             return oResultPromise;
@@ -446,31 +459,30 @@ sap.ui.define([
          *  to the fail handler which will be called in this case.
          */
         this._resolveTileByAppId = function (oTile, oSite) {
-            function reject (iLogLevel, sMessage) {
+            function createRejectDeferred (iLogLevel, sMessage) {
+                const oError = new LaunchpadError(sMessage, { logLevel: iLogLevel });
+
                 return new jQuery.Deferred()
-                    .reject({
-                        logLevel: iLogLevel,
-                        message: sMessage
-                    })
+                    .reject(oError)
                     .promise();
             }
 
             if (!isPlainObject(oTile)) {
-                return reject(oLogLevel.ERROR, "Cannot resolve tile: oTile must be an object");
+                return createRejectDeferred(oLogLevel.ERROR, "Cannot resolve tile: oTile must be an object");
             }
             if (!isPlainObject(oSite)) {
-                return reject(oLogLevel.ERROR, "Cannot resolve tile: oSite must be an object");
+                return createRejectDeferred(oLogLevel.ERROR, "Cannot resolve tile: oSite must be an object");
             }
 
             const sAppId = oTile.appId || oTile.appIDHint;
             if (!sAppId) {
-                return reject(oLogLevel.ERROR,
+                return createRejectDeferred(oLogLevel.ERROR,
                     ["Cannot resolve tile '", oTile.id, "': either appId or appIDHint must be specified"].join(""));
             }
 
             const oAppDescriptor = oSite.applications && oSite.applications[sAppId];
             if (!oAppDescriptor) {
-                return reject(oLogLevel.INFO,
+                return createRejectDeferred(oLogLevel.INFO,
                     ["Tile '",
                         oTile.id,
                         "' filtered from result: no app found for appId '",
@@ -482,7 +494,7 @@ sap.ui.define([
             // for referenced apps, this is an error
             const oInboundResult = this._getFirstInbound(oAppDescriptor);
             if (!oInboundResult) {
-                return reject(oLogLevel.ERROR,
+                return createRejectDeferred(oLogLevel.ERROR,
                     ["Cannot resolve tile '",
                         oTile.id,
                         "': app '",
@@ -501,7 +513,7 @@ sap.ui.define([
             oApp.isLink = false; // TODO remove as it should go one level up
 
             if (!this._isFormFactorSupported(oApp)) {
-                return reject(oLogLevel.INFO,
+                return createRejectDeferred(oLogLevel.INFO,
                     ["Tile '", oTile.id, "' filtered from result: form factor not supported"].join(""));
             }
 
@@ -731,8 +743,8 @@ sap.ui.define([
                                 that._logTileResolutionFailures(that._mFailedResolvedTiles);
                             });
                     })
-                    .fail((sErrorMessage0) => {
-                        Log.error(`Delivering homepage groups failed - ${sErrorMessage0}`);
+                    .fail((oError) => {
+                        Log.error("Delivering homepage groups failed", oError);
                         that._assureLoadedDeferred.resolve([]);
                         // ensure that following _assureLoaded calls get resolved with a new parameter
                         delete that._assureLoadedDeferred;
@@ -814,8 +826,9 @@ sap.ui.define([
                     .done(() => {
                         oDeferred.resolve(_oDefaultGroup);
                     })
-                    .fail((sMessage) => {
-                        oDeferred.reject(`Failed to access default group. ${sMessage}`);
+                    .fail((oError) => {
+                        Log.error("Failed to access default group.", oError);
+                        oDeferred.reject(oError);
                     });
             } else {
                 oDeferred.resolve(_oDefaultGroup);
@@ -887,7 +900,7 @@ sap.ui.define([
             const that = this;
 
             if (!this._isValidTitle(sTitle)) {
-                return oDeferred.reject("No valid group title").promise();
+                return oDeferred.reject(new Error("No valid group title")).promise();
             }
 
             const sGenericErrorMessage = `Failed to add the group with title '${sTitle
@@ -907,12 +920,13 @@ sap.ui.define([
                             delete that._assureLoadedDeferred;
                             oDeferred.resolve(oSite.groups[sGeneratedId], sGeneratedId);
                         })
-                        .fail((sErrorMsg0) => {
-                            oDeferred.reject(sErrorMsg0);
+                        .fail((oError) => {
+                            oDeferred.reject(oError);
                         });
                 })
-                .fail((sErrorMsg) => {
-                    oDeferred.reject(sGenericErrorMessage + sErrorMsg);
+                .fail((oError) => {
+                    Log.error(sGenericErrorMessage, oError);
+                    oDeferred.reject(oError);
                 });
 
             return oDeferred.promise();
@@ -947,10 +961,10 @@ sap.ui.define([
             const oCdmSiteService = this.oCDMService;
 
             if (typeof oGroup !== "object" || !oReadHomePageUtils.getGroupId(oGroup)) {
-                return oDeferred.reject("Unexpected group value").promise();
+                return oDeferred.reject(new Error("Unexpected group value")).promise();
             }
             if (!that._isValidTitle(sNewTitle)) {
-                return oDeferred.reject("Unexpected oGroup title value").promise();
+                return oDeferred.reject(new Error("Unexpected oGroup title value")).promise();
             }
             const sGenericErrorMessage = `Failed to set new title for group with id '${
                 oReadHomePageUtils.getGroupId(oGroup)}'. `;
@@ -968,13 +982,14 @@ sap.ui.define([
                         .done(() => {
                             oDeferred.resolve();
                         })
-                        .fail((sErrorMsg) => {
-                            Log.error(sErrorMsg);
-                            oDeferred.reject(sOldTitle);
+                        .fail((oError) => {
+                            Log.error("Failed to update the group title", oError);
+                            oDeferred.reject(oError, sOldTitle);
                         });
                 })
-                .fail((sError) => {
-                    oDeferred.reject(sOldTitle, sGenericErrorMessage + sError);
+                .fail((oError) => {
+                    Log.error(sGenericErrorMessage, oError);
+                    oDeferred.reject(oError, sOldTitle);
                 });
 
             return oDeferred.promise();
@@ -1025,15 +1040,17 @@ sap.ui.define([
                             .done(() => {
                                 oDeferred.resolve();
                             })
-                            .fail((oErrorMsg0) => {
-                                oDeferred.reject(`Hiding of groups did not work as expected - ${oErrorMsg0}`);
+                            .fail((oError) => {
+                                Log.error("Hiding of groups did not work as expected", oError);
+                                oDeferred.reject(oError);
                             });
                     })
-                    .fail((sError) => {
-                        oDeferred.reject(sGenericErrorMessage + sError);
+                    .fail((oError) => {
+                        Log.error(sGenericErrorMessage, oError);
+                        oDeferred.reject(oError);
                     });
             } else {
-                oDeferred.reject("Invalid input parameter aHiddenGroupIds. Please pass a valid input parameter.");
+                oDeferred.reject(new Error("Invalid input parameter aHiddenGroupIds. Please pass a valid input parameter."));
             }
 
             return oDeferred.promise();
@@ -1068,7 +1085,7 @@ sap.ui.define([
             const oCdmSiteService = this.oCDMService;
 
             if (!oGroup || !oReadHomePageUtils.getGroupId(oGroup) || nNewIndex < 0) {
-                return oDeferred.reject("Unable to move groups - invalid parameters").promise();
+                return oDeferred.reject(new Error("Unable to move groups - invalid parameters")).promise();
             }
 
             const sGenericErrorMessage = `Failed to move group with id '${oGroup.identification.id}'. `;
@@ -1079,7 +1096,7 @@ sap.ui.define([
                     const sGroupId = oReadHomePageUtils.getGroupId(oGroup);
 
                     if (!aGroupsOrder) {
-                        return oDeferred.reject("groupsOrder not found - abort operation of adding a group.");
+                        return oDeferred.reject(new Error("groupsOrder not found - abort operation of adding a group.")).promise();
                     } else if (aGroupsOrder.indexOf(sGroupId) === nNewIndex) {
                         return oDeferred.resolve();
                     }
@@ -1088,7 +1105,7 @@ sap.ui.define([
                     const aGroupsOrderAfterMove = oUshellUtils.moveElementInsideOfArray(aGroupsOrder, aGroupsOrder.indexOf(sGroupId), nNewIndex);
 
                     if (!aGroupsOrderAfterMove) {
-                        return oDeferred.reject("invalid move group operation - abort.");
+                        return oDeferred.reject(new Error("invalid move group operation - abort.")).promise();
                     }
 
                     oModifyHomePageUtils.setGroupsOrder(oSite, aGroupsOrderAfterMove);
@@ -1098,13 +1115,14 @@ sap.ui.define([
                         .done(() => {
                             oDeferred.resolve();
                         })
-                        .fail((sErrorMsg) => {
-                            oDeferred.reject(sErrorMsg);
+                        .fail((oError) => {
+                            oDeferred.reject(oError);
                         });
                     return undefined;
                 })
-                .fail((sError) => {
-                    oDeferred.reject(sGenericErrorMessage + sError);
+                .fail((oError) => {
+                    Log.error(sGenericErrorMessage, oError);
+                    oDeferred.reject(oError);
                 });
             return oDeferred.promise();
         };
@@ -1123,11 +1141,11 @@ sap.ui.define([
             const oCdmSiteService = this.oCDMService;
 
             if (typeof oGroup !== "object") {
-                return oDeferred.reject("invalid group parameter").promise();
+                return oDeferred.reject(new Error("invalid group parameter")).promise();
             }
             const sGroupId = oReadHomePageUtils.getGroupId(oGroup);
             if (!sGroupId) {
-                return oDeferred.reject("group without id given").promise();
+                return oDeferred.reject(new Error("group without id given")).promise();
             }
 
             const sGenericErrorMessage = `Failed to remove group with id '${sGroupId}'. `;
@@ -1141,12 +1159,13 @@ sap.ui.define([
                         .done(() => {
                             oDeferred.resolve();
                         })
-                        .fail((sErrorMsg) => {
-                            oDeferred.reject(sErrorMsg);
+                        .fail((oError) => {
+                            oDeferred.reject(oError);
                         });
                 })
-                .fail((sError) => {
-                    oDeferred.reject(sGenericErrorMessage + sError);
+                .fail((oError) => {
+                    Log.error(sGenericErrorMessage, oError);
+                    oDeferred.reject(oError);
                 });
 
             return oDeferred.promise();
@@ -1192,21 +1211,24 @@ sap.ui.define([
                                         .done(() => {
                                             oDeferred.resolve(oGroupFromOriginalSite);
                                         })
-                                        .fail((sErrorMsg1) => {
-                                            oDeferred.reject(`Group could not be reset - ${sErrorMsg1}`, aSiteGroupsBackup);
+                                        .fail((oError) => {
+                                            Log.error("Group could not be reset", oError);
+                                            oDeferred.reject(oError, aSiteGroupsBackup);
                                         });
                                 })
-                                .fail((sErrorMsg) => {
-                                    oDeferred.reject(`Group could not be reset - ${sErrorMsg}`, aSiteGroupsBackup);
+                                .fail((oError) => {
+                                    Log.error("Group could not be reset", oError);
+                                    oDeferred.reject(oError, aSiteGroupsBackup);
                                 });
                         } else {
-                            oDeferred.reject("Group could not be reset as it was created by the user", aSiteGroupsBackup);
+                            oDeferred.reject(new Error("Group could not be reset as it was created by the user"), aSiteGroupsBackup);
                         }
                     })
-                    .fail((sError) => {
+                    .fail((oError) => {
                         // reject with the original groups cannot be done in this case as
                         // loading of site failed
-                        oDeferred.reject(sGenericErrorMessage + sError, []);
+                        Log.error(sGenericErrorMessage, oError);
+                        oDeferred.reject(oError, []);
                     });
             }
             return oDeferred.promise();
@@ -1674,14 +1696,14 @@ sap.ui.define([
         this.getTileView = function (oGroupTile) {
             const that = this;
             return new jQuery.Deferred((oDeferred) => {
-                return that._getTileView(oGroupTile, false).then((oTileUI) => {
-                    oDeferred.resolve(oTileUI);
-                }, (sReason) => {
-                    const sErrorMessage = `Tile with ID '${oGroupTile.id}' could not be initialized${sReason ? `:\n${sReason}` : "."}`;
-
-                    Log.error(sErrorMessage, null, oGroupTile.tileType);
-                    oDeferred.reject(sErrorMessage);
-                });
+                return that._getTileView(oGroupTile, false)
+                    .then((oTileUI) => {
+                        oDeferred.resolve(oTileUI);
+                    })
+                    .catch((oError) => {
+                        Log.error(`Tile with ID '${oGroupTile.id}' could not be initialized`, oError, oGroupTile.tileType);
+                        oDeferred.reject(oError);
+                    });
             }).promise();
         };
 
@@ -1838,7 +1860,7 @@ sap.ui.define([
 
             if (!oTileComponentProperties.name) {
                 return oDeferred
-                    .reject(`Cannot find name of tile component for tile with id: '${oTile.id}'`)
+                    .reject(new Error(`Cannot find name of tile component for tile with id: '${oTile.id}'`))
                     .promise();
             }
 
@@ -1984,7 +2006,7 @@ sap.ui.define([
             if (typeof oGroupTile !== "object" || !oGroupTile.id) {
                 sErrorMessage = `Invalid input parameter passed to _getTileView: ${oGroupTile}`;
                 Log.error(sErrorMessage);
-                return oDeferred.reject(sErrorMessage).promise();
+                return oDeferred.reject(new Error(sErrorMessage)).promise();
             }
 
             const oResolvedTile = this._mResolvedTiles[oGroupTile.id];
@@ -1994,7 +2016,7 @@ sap.ui.define([
 
             sErrorMessage = `No resolved tile found for tile ID: ${oGroupTile.id}`;
             Log.error(sErrorMessage);
-            return oDeferred.reject(sErrorMessage).promise();
+            return oDeferred.reject(new Error(sErrorMessage)).promise();
         };
 
         /**
@@ -2036,7 +2058,7 @@ sap.ui.define([
             if (typeof oCatalogTile !== "object") {
                 const sErrorMessage = `Invalid input parameter passed to _getCatalogTileView: ${oCatalogTile}`;
                 Log.error(sErrorMessage);
-                return oDeferred.reject(sErrorMessage).promise();
+                return oDeferred.reject(new Error(sErrorMessage)).promise();
             }
             // As catalog tiles are already passed as resolved catalog tiles,
             // we do not distinguish between the unresolved and resolved variant
@@ -2230,8 +2252,8 @@ sap.ui.define([
                 .done(() => {
                     oDeferred.resolve(oTileToBeAdded);
                 })
-                .fail((sMessage) => {
-                    oDeferred.reject(sMessage);
+                .fail((oError) => {
+                    oDeferred.reject(oError);
                 });
 
             return oDeferred.promise();
@@ -2321,7 +2343,6 @@ sap.ui.define([
          */
         this.addTile = function (oCatalogTile, oGroup) {
             const oDeferred = new jQuery.Deferred();
-            let sGenericErrorMessage;
             const oCdmSiteService = this.oCDMService;
 
             if (!oGroup) {
@@ -2346,14 +2367,13 @@ sap.ui.define([
                         .done(() => {
                             oDeferred.resolve(oGroupTile);
                         })
-                        .fail((sReason) => {
-                            oDeferred.reject(sReason);
+                        .fail((oError) => {
+                            oDeferred.reject(oError);
                         });
                 })
-                .fail((sError) => {
-                    sGenericErrorMessage = `Failed to add tile with id '${oGroupTile.id
-                    }' to group with id '${oGroup.identification.id}'. `;
-                    oDeferred.reject(sGenericErrorMessage + sError);
+                .fail((oError) => {
+                    Log.error(`Failed to add tile with id '${oGroupTile.id}' to group with id '${oGroup.identification.id}'. `, oError);
+                    oDeferred.reject(oError);
                 });
 
             return oDeferred.promise();
@@ -2380,7 +2400,7 @@ sap.ui.define([
 
             if (!oGroup || typeof oGroup !== "object" || !oGroup.identification || !oGroup.identification.id ||
                 !oTile || typeof oTile !== "object" || !oTile.id) {
-                return oDeferred.reject({}, "Failed to remove tile. No valid input parameters passed to removeTile method.").promise();
+                return oDeferred.reject(new Error("Failed to remove tile. No valid input parameters passed to removeTile method."), {}).promise();
             }
 
             const sGenericErrorMessage = `Failed to remove tile with id '${oTile.id}' from group with id '${oGroup.identification.id}'. `;
@@ -2394,8 +2414,9 @@ sap.ui.define([
 
                     try {
                         oPayload = oSite.groups[oGroup.identification.id].payload;
-                    } catch (e) {
-                        oDeferred.reject(oSite.groups[oGroup.identification.id], sGenericErrorMessage);
+                    } catch (oError) {
+                        Log.error(sGenericErrorMessage, oError);
+                        oDeferred.reject(oError, oSite.groups[oGroup.identification.id]);
                     }
 
                     // according to the tile type set oPayload tile / links to be truncated.
@@ -2419,14 +2440,15 @@ sap.ui.define([
                         .done(() => {
                             oDeferred.resolve();
                         })
-                        .fail((sErrorMsg) => {
-                            Log.error(sErrorMsg);
-                            oDeferred.reject(oSite.groups[oGroup.identification.id], sErrorMsg);
+                        .fail((oError) => {
+                            Log.error("Failed to remove tile", oError);
+                            oDeferred.reject(oError, oSite.groups[oGroup.identification.id]);
                         });
                 })
-                .fail((sError) => {
+                .fail((oError) => {
+                    Log.error(sGenericErrorMessage, oError);
                     // Reject an empty group object, as site with correct group data could not get accessed
-                    oDeferred.reject({}, sGenericErrorMessage + sError);
+                    oDeferred.reject(oError, {});
                 });
 
             return oDeferred.promise();
@@ -2462,7 +2484,7 @@ sap.ui.define([
                 iTargetIndex === undefined || iTargetIndex < 0 ||
                 !oSourceGroup || !oSourceGroup.identification || !oSourceGroup.identification.id ||
                 !oTargetGroup || !oTargetGroup.identification || !oTargetGroup.identification.id) {
-                return oDeferred.reject("Invalid input parameters").promise();
+                return oDeferred.reject(new Error("Invalid input parameters")).promise();
             }
 
             const sGenericErrorMessage = `Failed to move tile with id '${oTile.id}'. `;
@@ -2516,15 +2538,15 @@ sap.ui.define([
                         .done(() => {
                             oDeferred.resolve(oTile);
                         })
-                        .fail((sError) => {
-                            Log.error(sGenericErrorMessage + sError);
-                            oDeferred.reject(sGenericErrorMessage + sError);
+                        .fail((oError) => {
+                            Log.error(sGenericErrorMessage, oError);
+                            oDeferred.reject(oError);
                         });
                     return undefined;
                 })
-                .fail((sError) => {
-                    Log.error(sGenericErrorMessage + sError);
-                    oDeferred.reject(sGenericErrorMessage + sError);
+                .fail((oError) => {
+                    Log.error(sGenericErrorMessage, oError);
+                    oDeferred.reject(oError);
                 });
 
             return oDeferred.promise();
@@ -2574,26 +2596,28 @@ sap.ui.define([
 
             // setTimeout is required here. Otherwise the the oDeferred.notify() would
             // be a synchronous call, which would cause wrong behavior in some scenarios
-            Container.getServiceAsync("CommonDataModel").then((oCDMSiteService) => {
-                oCDMSiteService.getSite().done((oSite) => {
-                    // catalogs from site should be loaded first as they require
-                    // loading of less resources
-                    Object.keys(oSite.catalogs).forEach((sCatalogId) => {
-                        processCatalog(oSite, sCatalogId, aCatalogs, oDeferred);
+            Container.getServiceAsync("CommonDataModel")
+                .then((oCDMSiteService) => {
+                    oCDMSiteService.getSite().done((oSite) => {
+                        // catalogs from site should be loaded first as they require
+                        // loading of less resources
+                        Object.keys(oSite.catalogs).forEach((sCatalogId) => {
+                            processCatalog(oSite, sCatalogId, aCatalogs, oDeferred);
+                        });
+                        // In our tests we use indices to access specific
+                        // catalogs from the getCatalogs response. For this
+                        // reason we are sorting the result. As stated in the
+                        // documentation, this shouldn't really matter for the
+                        // caller. The caller should not code against a
+                        // specific sort order.
+                        //
+                        // Note that oA.identification.id is a string and
+                        // usually not a number Note that "A" is bigger than
+                        // "1"
+                        oDeferred.resolve(aCatalogs.sort(that._compareCatalogs));
                     });
-                    // In our tests we use indices to access specific
-                    // catalogs from the getCatalogs response. For this
-                    // reason we are sorting the result. As stated in the
-                    // documentation, this shouldn't really matter for the
-                    // caller. The caller should not code against a
-                    // specific sort order.
-                    //
-                    // Note that oA.identification.id is a string and
-                    // usually not a number Note that "A" is bigger than
-                    // "1"
-                    oDeferred.resolve(aCatalogs.sort(that._compareCatalogs));
-                });
-            }, 0);
+                })
+                .catch(oDeferred.reject);
             return oDeferred.promise();
         };
 
@@ -2794,7 +2818,7 @@ sap.ui.define([
             const oDeferred = new jQuery.Deferred();
 
             if (typeof oCatalog !== "object" || oCatalog === null) {
-                return oDeferred.reject(`Invalid input parameter '${oCatalog}' passed to getCatalogTiles.`).promise();
+                return oDeferred.reject(new Error(`Invalid input parameter '${oCatalog}' passed to getCatalogTiles.`)).promise();
             }
 
             that.oCDMService.getSite()
@@ -2803,8 +2827,9 @@ sap.ui.define([
                         .done(oDeferred.resolve)
                         .fail(oDeferred.reject);
                 })
-                .fail((sErrorMessage2) => {
-                    oDeferred.reject(`Failed to get site: ${sErrorMessage2}`);
+                .fail((oError) => {
+                    Log.error("Failed to get site", oError);
+                    oDeferred.reject(oError);
                 });
 
             return oDeferred.promise();
@@ -3342,18 +3367,19 @@ sap.ui.define([
                                     .done(() => {
                                         oDeferred.resolve(oTile);
                                     })
-                                    .fail((sReason) => {
-                                        oDeferred.reject(sReason);
+                                    .fail((oError) => {
+                                        oDeferred.reject(oError);
                                     });
                             })
-                            .fail((sErrorMsg) => {
+                            .fail((oError) => {
+                                Log.error("Bookmark creation failed because:", oError);
                                 // Note: do not add error message to oThisAdapter._mFailedResolvedTiles[oTile.id]
                                 // as the tile was not created which makes the cache useless
-                                oDeferred.reject(`Bookmark creation failed because: ${sErrorMsg}`);
+                                oDeferred.reject(oError);
                             });
                     })
-                    .fail((sReason) => {
-                        oDeferred.reject(sReason);
+                    .fail((oError) => {
+                        oDeferred.reject(oError);
                     });
             }).promise();
         };
@@ -3586,7 +3612,7 @@ sap.ui.define([
             const oDeferred = new jQuery.Deferred();
 
             if (!oTile || !oTile.id || !oSettingsView) {
-                return oDeferred.reject().promise();
+                return oDeferred.reject(new Error("Invalid tile or settings view")).promise();
             }
 
             const sNewTitle = oSettingsView.oTitleInput.getValue();
@@ -3651,9 +3677,9 @@ sap.ui.define([
             Container.getServiceAsync("CommonDataModel")
                 .then((oCdmService) => {
                     oCdmService.save()
-                        .fail((sErrorMsg0) => {
-                            Log.error(sErrorMsg0);
-                            oDeferred.reject(`Could not save personalization changes: ${sErrorMsg0}`);
+                        .fail((oError) => {
+                            Log.error("Could not save personalization changes:", oError);
+                            oDeferred.reject(oError);
                         })
                         .done(() => {
                             oDeferred.resolve();