@sapui5/sap.ushell 1.140.0 → 1.141.1

package/src/main/js/sap/ushell/bootstrap/common/common.read.metatags.js

@@ -18,8 +18,8 @@ sap.ui.define(["sap/base/Log"], (Log) => {
         Array.prototype.forEach.call(oMetaNodeList, (oMetaNode) => {
             try {
                 aItems.push(fnParse(oMetaNode.content));
-            } catch (e) {
-                Log.error(e.message, e.stack, S_COMPONENT);
+            } catch (oError) {
+                Log.error("Metatag Read failed", oError, S_COMPONENT);
             }
         });
 

package/src/main/js/sap/ushell/bootstrap/common/common.util.js

@@ -119,10 +119,10 @@ sap.ui.define([
             try {
                 // UI5's config cannot be used here, so check local storage
                 bSapStatistics = window.localStorage.getItem("sap-ui-statistics") === "X";
-            } catch (e) {
+            } catch (oError) {
                 Log.warning(
                     "failed to read sap-statistics setting from local storage",
-                    null,
+                    oError,
                     "sap.ushell.bootstrap.common.common.util"
                 );
             }

package/src/main/js/sap/ushell/bootstrap/sandbox2/sandbox.js

@@ -31,7 +31,7 @@ sap.ui.define([
                     return oData;
                 }
                 logError();
-            } catch (e) {
+            } catch {
                 logError();
             }
         },

package/src/main/js/sap/ushell/bootstrap/sandbox2.js

@@ -7,7 +7,7 @@
  * @fileOverview The Unified Shell's bootstrap code for development sandbox scenarios.
  * This is the version that creates spaces/pages runtime environment.
  *
- * @version 1.140.0
+ * @version 1.141.1
  */
 
 (function () {

package/src/main/js/sap/ushell/components/CatalogsManager.js

@@ -354,9 +354,9 @@ sap.ui.define([
                             oCatalogModel: oCatalogModel
                         });
                     })
-                    .fail((sError) => {
+                    .fail((oError) => {
                         MessagingHelper.showLocalizedErrorHelper("fail_to_load_catalog_tiles_msg");
-                        reject(sError);
+                        reject(oError);
                     });
             });
         },
@@ -727,7 +727,7 @@ sap.ui.define([
             const that = this;
             const oDeferred = new jQuery.Deferred();
             if (!ushellUtils.validHash(sTitle)) {
-                return oDeferred.reject({ status: 0, action: "createNewGroup" }); // 0 - failure
+                return oDeferred.reject(new Error("Invalid group title"));
             }
 
             const oResultPromise = this.oLaunchPageService.addGroup(sTitle);

package/src/main/js/sap/ushell/components/HomepageManager.js

@@ -492,10 +492,10 @@ sap.ui.define([
                             // the tile is added to our model in "_addBookmarkToModel" here we just show the success toast.
                             oMessagingHelper.showLocalizedMessage("tile_created_msg");
                         })
-                        .catch((sMsg) => {
+                        .catch((oError) => {
                             Log.error(
                                 "Failed to add bookmark",
-                                sMsg,
+                                oError,
                                 "sap.ushell.ui.footerbar.AddBookmarkButton"
                             );
                             oMessagingHelper.showLocalizedError("fail_to_add_tile_msg");
@@ -756,15 +756,14 @@ sap.ui.define([
             }
 
             function deleteGroup () {
-                this.oPageOperationAdapter.deleteGroup(oDeletedGroupModel).then(
-                    () => {
+                this.oPageOperationAdapter.deleteGroup(oDeletedGroupModel)
+                    .then(() => {
                         oMessagingHelper.showLocalizedMessage("group_deleted_msg", [oDeletedGroupModel.title]);
                         this._checkRequestQueue();
-                    },
-                    () => {
+                    })
+                    .catch(() => {
                         this._resetGroupsOnFailure("fail_to_delete_group_msg");
-                    }
-                );
+                    });
             }
 
             this._addRequest(deleteGroup.bind(this));
@@ -790,8 +789,8 @@ sap.ui.define([
             oModel.setProperty(`/groups/${nGroupIndex}/sortable`, false);
 
             function resetGroup () {
-                that.oPageOperationAdapter.resetGroup(oGroupModel, bDefaultGroup).then(
-                    (oResetedObject) => {
+                that.oPageOperationAdapter.resetGroup(oGroupModel, bDefaultGroup)
+                    .then((oResetedObject) => {
                         that._handleAfterSortable((sGroupId, oOldGroupModel, oResetedGroupModel) => {
                             const aGroups = that.oModel.getProperty("/groups");
                             const nGroupIndex = oGroupsHelper.getIndexOfGroup(aGroups, sGroupId);
@@ -818,10 +817,10 @@ sap.ui.define([
                             }
                         })(sGroupId, oGroupModel, oResetedObject);
                         that._checkRequestQueue();
-                    }, () => {
+                    })
+                    .catch(() => {
                         that._resetGroupsOnFailure("fail_to_reset_group_msg");
-                    }
-                );
+                    });
             }
             this._addRequest(resetGroup);
         },
@@ -885,12 +884,11 @@ sap.ui.define([
                         };
                         return that.oPageOperationAdapter.moveGroup(oGroup, iIndexTo, oIndicesInModel);
                     }
-                ).then(
-                    that._checkRequestQueue.bind(that),
-                    () => {
+                )
+                    .then(that._checkRequestQueue.bind(that))
+                    .catch(() => {
                         that._resetGroupsOnFailure("fail_to_move_group_msg");
-                    }
-                );
+                    });
             }
 
             this._addRequest(moveGroup);
@@ -975,8 +973,8 @@ sap.ui.define([
                     );
                 }
 
-                oAddGroupPromise.then(
-                    (oNewPreparedGroupModel) => {
+                oAddGroupPromise
+                    .then((oNewPreparedGroupModel) => {
                         // Theoretically can be case that the server is slow and user start the dnd tiles.
                         that._handleAfterSortable((sGroupId, oNewGroupModel) => {
                             // group model can be changed
@@ -997,20 +995,20 @@ sap.ui.define([
 
                             that._checkRequestQueue();
                         })(sModelGroupId, oNewPreparedGroupModel);
-                    }, () => {
+                    })
+                    .catch(() => {
                         that._resetGroupsOnFailure("fail_to_create_group_msg");
-                    }
-                );
+                    });
             }
 
             function renameGroup () {
-                this.oPageOperationAdapter.renameGroup(oGroupModel, sNewTitle, sOldTitle).then(
-                    () => {
+                this.oPageOperationAdapter.renameGroup(oGroupModel, sNewTitle, sOldTitle)
+                    .then(() => {
                         that._checkRequestQueue();
-                    }, () => {
+                    })
+                    .catch(() => {
                         that._resetGroupsOnFailure("fail_to_rename_group_msg");
-                    }
-                );
+                    });
             }
 
             // Check, if the group has already been persisted
@@ -1064,7 +1062,8 @@ sap.ui.define([
 
             function deleteTile (group, tileModel) {
                 this.oPageOperationAdapter.removeTile(group, tileModel)
-                    .then(this._checkRequestQueue.bind(this), this._resetGroupsOnFailure.bind(this, "fail_to_remove_tile_msg"));
+                    .then(this._checkRequestQueue.bind(this))
+                    .catch(this._resetGroupsOnFailure.bind(this, "fail_to_remove_tile_msg"));
             }
 
             /**
@@ -1207,50 +1206,52 @@ sap.ui.define([
                     (sOldType === "links") ? "tile" : "link"
                 );
 
-                oResultPromise.then((oNewTileInfo) => {
-                    // we call to _handleAfterSortable to handle the case in which convertTile is called by dragAndDrop flow
-                    that._handleAfterSortable((sTileId, oNewTileInfo) => {
-                        const sTilePath = that._getPathOfTile(sTileId);
-                        const oView = oNewTileInfo.content;
-
-                        // If we cannot find the tile, it might have been deleted -> Check!
-                        if (sTilePath) {
-                            if (sOldType === "tiles") { // it means we convert to link
-                                that._attachLinkPressHandlers(oView);
-                                that._changeLinkScope(oView, bActionMode ? "Actions" : "Display");
-                            }
+                oResultPromise
+                    .then((oNewTileInfo) => {
+                        // we call to _handleAfterSortable to handle the case in which convertTile is called by dragAndDrop flow
+                        that._handleAfterSortable((sTileId, oNewTileInfo) => {
+                            const sTilePath = that._getPathOfTile(sTileId);
+                            const oView = oNewTileInfo.content;
+
+                            // If we cannot find the tile, it might have been deleted -> Check!
+                            if (sTilePath) {
+                                if (sOldType === "tiles") { // it means we convert to link
+                                    that._attachLinkPressHandlers(oView);
+                                    that._changeLinkScope(oView, bActionMode ? "Actions" : "Display");
+                                }
 
-                            if (oSourceGroup === oTargetGroup) {
-                                MessageToast.show(oResources.i18n.getText("PageRuntime.Message.VisualizationConverted"));
-                            } else {
-                                MessageToast.show(oResources.i18n.getText("PageRuntime.Message.VisualizationMovedAndConverted"));
-                            }
+                                if (oSourceGroup === oTargetGroup) {
+                                    MessageToast.show(oResources.i18n.getText("PageRuntime.Message.VisualizationConverted"));
+                                } else {
+                                    MessageToast.show(oResources.i18n.getText("PageRuntime.Message.VisualizationMovedAndConverted"));
+                                }
 
-                            const oTargetGroupInfo = {
-                                tileIndex: newTileIndex,
-                                groupIndex: newGroupIndex,
-                                group: oTargetGroup
-                            };
-                            const tileInfo = {
-                                tile: oTileModel,
-                                view: oView,
-                                type: sOldType,
-                                tileObj: oNewTileInfo.object
-                            };
-                            // setting a flag on the Tile's object to disable opening the Tile's action until backend requests finish (see DashboardContent.view)
-                            oTileModel.tileIsBeingMoved = true;
-                            that.replaceTileViewAfterConvert(sourceInfo, oTargetGroupInfo, tileInfo);
-                            oEventHub.emit("updateGroups", Date.now());
-                            oUtils.handleTilesVisibility();
-                            if (oData.callBack) {
-                                oData.callBack(oView);
+                                const oTargetGroupInfo = {
+                                    tileIndex: newTileIndex,
+                                    groupIndex: newGroupIndex,
+                                    group: oTargetGroup
+                                };
+                                const tileInfo = {
+                                    tile: oTileModel,
+                                    view: oView,
+                                    type: sOldType,
+                                    tileObj: oNewTileInfo.object
+                                };
+                                // setting a flag on the Tile's object to disable opening the Tile's action until backend requests finish (see DashboardContent.view)
+                                oTileModel.tileIsBeingMoved = true;
+                                that.replaceTileViewAfterConvert(sourceInfo, oTargetGroupInfo, tileInfo);
+                                oEventHub.emit("updateGroups", Date.now());
+                                oUtils.handleTilesVisibility();
+                                if (oData.callBack) {
+                                    oData.callBack(oView);
+                                }
                             }
-                        }
-                    })(sTileId, oNewTileInfo);
-                    that._checkRequestQueue();
-                }, () => {
-                    that._handleAfterSortable(that._resetGroupsOnFailure.bind(that))("fail_to_move_tile_msg");
-                });
+                        })(sTileId, oNewTileInfo);
+                        that._checkRequestQueue();
+                    })
+                    .catch(() => {
+                        that._handleAfterSortable(that._resetGroupsOnFailure.bind(that))("fail_to_move_tile_msg");
+                    });
             }
             this._addRequest(convertTile.bind(this));
         },
@@ -1475,52 +1476,54 @@ sap.ui.define([
                     oSourceGroup,
                     oTargetGroup,
                     sType
-                ).then((oNewTileInfo) => {
-                    const sTilePath = that._getPathOfTile(sTileId);
-                    if (sTilePath) {
-                        that.oModel.setProperty(`${sTilePath}/object`, oNewTileInfo.object);
-                        that.oModel.setProperty(`${sTilePath}/originalTileId`, oNewTileInfo.originalTileId);
-
-                        const oldViewContent = that.oModel.getProperty(`${sTilePath}/content`);
-                        const oView = oNewTileInfo.content;
-
-                        // set the new view
-                        if (sToItems === "links") {
-                            that._changeLinkScope(oView, bActionMode ? "Actions" : "Display");
-                            that._attachLinkPressHandlers(oView);
-                            that._handleTileAppearanceAnimation(oView);
-                            oTileInfo.oTile.content = [oView];
-                            that.oModel.setProperty(sTilePath, extend({}, oTileInfo.oTile));
-                            that.oModel.setProperty(
-                                `/groups/${oGroupInfo.newGroupIndex}/${sToItems}`,
-                                that.oModel.getProperty(`/groups/${oGroupInfo.newGroupIndex}/${sToItems}`)
-                            );
-                        } else {
-                            that.oModel.setProperty(`${sTilePath}/content`, [oView]);
-                        }
+                )
+                    .then((oNewTileInfo) => {
+                        const sTilePath = that._getPathOfTile(sTileId);
+                        if (sTilePath) {
+                            that.oModel.setProperty(`${sTilePath}/object`, oNewTileInfo.object);
+                            that.oModel.setProperty(`${sTilePath}/originalTileId`, oNewTileInfo.originalTileId);
 
-                        // destroy the old view
-                        if (oldViewContent && oldViewContent[0]) {
-                            const origOnAfterRendering = oView.onAfterRendering;
-                            oView.onAfterRendering = function () {
-                                origOnAfterRendering.apply(this);
-                                oldViewContent[0].destroy();
-                                oView.onAfterRendering = origOnAfterRendering;
-                            };
-                        }
+                            const oldViewContent = that.oModel.getProperty(`${sTilePath}/content`);
+                            const oView = oNewTileInfo.content;
 
-                        // reset the move-scenario flag
-                        that.oModel.setProperty(`${sTilePath}/tileIsBeingMoved`, false);
-                        if (oData.callBack) {
-                            oData.callBack(oView);
-                        }
+                            // set the new view
+                            if (sToItems === "links") {
+                                that._changeLinkScope(oView, bActionMode ? "Actions" : "Display");
+                                that._attachLinkPressHandlers(oView);
+                                that._handleTileAppearanceAnimation(oView);
+                                oTileInfo.oTile.content = [oView];
+                                that.oModel.setProperty(sTilePath, extend({}, oTileInfo.oTile));
+                                that.oModel.setProperty(
+                                    `/groups/${oGroupInfo.newGroupIndex}/${sToItems}`,
+                                    that.oModel.getProperty(`/groups/${oGroupInfo.newGroupIndex}/${sToItems}`)
+                                );
+                            } else {
+                                that.oModel.setProperty(`${sTilePath}/content`, [oView]);
+                            }
 
-                        MessageToast.show(oResources.i18n.getText("PageRuntime.Message.VisualizationMoved"));
-                    }
-                    that._checkRequestQueue();
-                }, () => {
-                    that._resetGroupsOnFailure("fail_to_move_tile_msg");
-                });
+                            // destroy the old view
+                            if (oldViewContent && oldViewContent[0]) {
+                                const origOnAfterRendering = oView.onAfterRendering;
+                                oView.onAfterRendering = function () {
+                                    origOnAfterRendering.apply(this);
+                                    oldViewContent[0].destroy();
+                                    oView.onAfterRendering = origOnAfterRendering;
+                                };
+                            }
+
+                            // reset the move-scenario flag
+                            that.oModel.setProperty(`${sTilePath}/tileIsBeingMoved`, false);
+                            if (oData.callBack) {
+                                oData.callBack(oView);
+                            }
+
+                            MessageToast.show(oResources.i18n.getText("PageRuntime.Message.VisualizationMoved"));
+                        }
+                        that._checkRequestQueue();
+                    })
+                    .catch(() => {
+                        that._resetGroupsOnFailure("fail_to_move_tile_msg");
+                    });
             }
             this._addRequest(moveTile.bind(this));
         },
@@ -1871,7 +1874,7 @@ sap.ui.define([
             this.bIsGroupsModelLoading = true;
             try {
                 iGroupsInModel = this.oModel.getProperty("/groups").length;
-            } catch (err) {
+            } catch {
                 // can be that groups is not defined in model
             }
 
@@ -2486,7 +2489,7 @@ sap.ui.define([
 
             if (this.bIsGroupsRequestPending) {
                 Log.info("loadPersonalizedGroups was skipped because there is already a pending request.");
-                oDeferred.reject();
+                oDeferred.reject(new Error("loadPersonalizedGroups was skipped because there is already a pending request."));
                 return oDeferred.promise();
             }
             this.bIsGroupsRequestPending = true;
@@ -2501,8 +2504,8 @@ sap.ui.define([
                     that.bIsGroupsRequestPending = false;
                     oDeferred.resolve();
                 })
-                .catch((vError) => {
-                    Log.error("Loading of personalized groups failed.", vError, "sap.ushell.components.HomepageManager");
+                .catch((oError) => {
+                    Log.error("Loading of personalized groups failed.", oError, "sap.ushell.components.HomepageManager");
                     oMessagingHelper.showLocalizedError("fail_to_load_groups_msg");
                     that.bIsGroupsRequestPending = false;
                 });

package/src/main/js/sap/ushell/components/SharedComponentUtils.js

@@ -6,14 +6,16 @@ sap.ui.define([
     "sap/ushell/EventHub",
     "sap/base/Log",
     "sap/ui/core/Component",
-    "sap/ushell/Container"
+    "sap/ushell/Container",
+    "sap/ushell/utils"
 ], (
     Device,
     Config,
     EventHub,
     Log,
     Component,
-    Container
+    Container,
+    ushellUtils
 ) => {
     "use strict";
 
@@ -28,14 +30,23 @@ sap.ui.define([
             EventHub.join(
                 EventHub.once("CoreResourcesComplementLoaded"), // sap/ushell/UserActivityLog is preloaded as part of core-ext
                 Config.on("/core/extension/SupportTicket")
-            ).do((oCoreExtResult, bConfigured) => {
-                sap.ui.require(["sap/ushell/UserActivityLog"], (userActivityLog) => {
-                    if (bConfigured) {
-                        userActivityLog.activate();
-                    } else {
-                        userActivityLog.deactivate();
-                    }
-                });
+            ).do(async (oCoreExtResult, bConfigured) => {
+                let UserActivityLog = sap.ui.require("sap/ushell/UserActivityLog");
+
+                if (bConfigured && !UserActivityLog) {
+                    // only load if required
+                    UserActivityLog = (await ushellUtils.requireAsync(["sap/ushell/UserActivityLog"]))[0];
+                }
+
+                if (!UserActivityLog) {
+                    return;
+                }
+
+                if (bConfigured) {
+                    UserActivityLog.activate();
+                } else {
+                    UserActivityLog.deactivate();
+                }
             });
         },
 
@@ -97,9 +108,9 @@ sap.ui.define([
                 .then((oPersonalizer) => {
                     return oPersonalizer.getPersData();
                 })
-                .catch((sError) => {
-                    Log.error(`Failed to load ${sItem} from the personalization`, sError, "sap.ushell.components.flp.settings.FlpSettings");
-                    return Promise.reject(sError);
+                .catch((oError) => {
+                    Log.error(`Failed to load ${sItem} from the personalization`, oError, "sap.ushell.components.flp.settings.FlpSettings");
+                    throw oError;
                 });
         },
 

package/src/main/js/sap/ushell/components/_HomepageManager/PersistentPageOperationAdapter.js

@@ -328,8 +328,8 @@ sap.ui.define([
                             })
                             .fail(reject);
                     }
-                } catch (err) {
-                    reject();
+                } catch (oError) {
+                    reject(oError);
                 }
             });
         },
@@ -343,8 +343,8 @@ sap.ui.define([
                             resolve();
                         })
                         .fail(reject);
-                } catch (Ex) {
-                    reject();
+                } catch (oError) {
+                    reject(oError);
                 }
             });
         },
@@ -360,8 +360,8 @@ sap.ui.define([
                             resolve();
                         })
                         .fail(reject);
-                } catch (err) {
-                    reject();
+                } catch (oError) {
+                    reject(oError);
                 }
             });
         },
@@ -375,8 +375,8 @@ sap.ui.define([
                             resolve();
                         })
                         .fail(reject);
-                } catch (err) {
-                    reject();
+                } catch (oError) {
+                    reject(oError);
                 }
             });
         },
@@ -399,20 +399,20 @@ sap.ui.define([
                             );
                         })
                         .fail(reject);
-                } catch (err) {
-                    reject();
+                } catch (oError) {
+                    reject(oError);
                 }
             });
         },
 
         refreshGroup: function (sGroupId) {
             const that = this;
-            const sErrorMsg = `Failed to refresh group with id:${sGroupId} in the model`;
+            const sErrorMessage = `Failed to refresh group with id:${sGroupId} in the model`;
 
             return new Promise((resolve) => {
                 that.oPageBuilderService.getGroups()
-                    .fail(() => {
-                        Log.error(sErrorMsg, null, "sap.ushell.components.HomepageManager");
+                    .fail((oError) => {
+                        Log.error(sErrorMessage, oError, "sap.ushell.components.HomepageManager");
                         resolve(null);
                     })
                     .done((aGroups) => {
@@ -499,8 +499,8 @@ sap.ui.define([
                         resolve(oTargetTile);
                     });
                     oResultPromise.fail(reject);
-                } catch (err) {
-                    reject();
+                } catch (oError) {
+                    reject(oError);
                 }
             });
             return oPromise.then(this._getTileViewAsPromise.bind(this)).then((oView) => {
@@ -524,8 +524,8 @@ sap.ui.define([
                                 resolve();
                             })
                         .fail(reject);
-                } catch (err) {
-                    reject();
+                } catch (oError) {
+                    reject(oError);
                 }
             });
         },

package/src/main/js/sap/ushell/components/_HomepageManager/TransientPageOperationAdapter.js

@@ -177,12 +177,12 @@ sap.ui.define([
             return Promise.resolve();
         },
 
-        resetGroup: function (/* oGroupModel, bDefaultGroup */) {
-            return Promise.reject("Reset group not supported in transient mode");
+        resetGroup: async function (/* oGroupModel, bDefaultGroup */) {
+            throw new Error("Reset group not supported in transient mode");
         },
 
-        refreshGroup: function (/* sGroupId */) {
-            return Promise.reject("Refresh group not supported in transient mode");
+        refreshGroup: async function (/* sGroupId */) {
+            throw new Error("Refresh group not supported in transient mode");
         },
 
         getIndexOfGroup: function (/* aGroups, oServerGroupObject */) {

package/src/main/js/sap/ushell/components/appfinder/AppFinder.controller.js

@@ -1,5 +1,6 @@
 // Copyright (c) 2009-2025 SAP SE, All Rights Reserved
 sap.ui.define([
+    "sap/base/Log",
     "sap/base/util/extend",
     "sap/ui/core/EventBus",
     "sap/ui/core/mvc/View",
@@ -14,6 +15,7 @@ sap.ui.define([
     "sap/ui/thirdparty/hasher",
     "sap/ushell/Container"
 ], (
+    Log,
     extend,
     EventBus,
     View,
@@ -589,7 +591,7 @@ sap.ui.define([
             let oDataParam;
             try {
                 oDataParam = JSON.parse(sDataParam);
-            } catch (e) {
+            } catch {
                 oDataParam = sDataParam;
             }
 
@@ -656,8 +658,9 @@ sap.ui.define([
                     }
                     oDeferred.resolve(systemsModel);
                 })
-                .catch((sErrorMsg) => {
-                    oDeferred.reject(`An error occurred while retrieving the systems: ${sErrorMsg}`);
+                .catch((oError) => {
+                    Log.error("An error occurred while retrieving the systems:", oError);
+                    oDeferred.reject(oError);
                 });
             return oDeferred.promise();
         },

package/src/main/js/sap/ushell/components/appfinder/Catalog.controller.js

@@ -149,7 +149,7 @@ sap.ui.define([
             let oUrlParameters;
             try {
                 oUrlParameters = JSON.parse(sUrlParameters);
-            } catch (e) {
+            } catch {
                 oUrlParameters = sUrlParameters;
             }
             const hashTag = (oUrlParameters && oUrlParameters.tagFilter && oUrlParameters.tagFilter) || [];
@@ -157,7 +157,7 @@ sap.ui.define([
             if (hashTag) {
                 try {
                     this.tagFilter = JSON.parse(hashTag);
-                } catch (e) {
+                } catch {
                     this.tagFilter = [];
                 }
             } else {