@sapui5/sap.ushell 1.139.0 → 1.141.0

package/src/main/js/sap/ushell/services/PluginManager.js

@@ -2,7 +2,7 @@
 
 /**
  * @fileOverview The Unified Shell's PluginManager service. Allows handling the loading of Fiori Launchpad plugins.
- * @version 1.139.0
+ * @version 1.141.0
  */
 sap.ui.define([
     "sap/base/Log",
@@ -95,14 +95,14 @@ sap.ui.define([
                 if (oPlugin.hasOwnProperty("component")) {
                     // only add handler to promise in case that the component has already been loaded
                     if (that._mInitializedComponentPromise.hasOwnProperty(oPlugin.component)) {
-                        that._mInitializedComponentPromise[oPlugin.component].then(
-                            () => {
+                        that._mInitializedComponentPromise[oPlugin.component]
+                            .catch(() => {
+                                // note, no error logging here
+                                // continue even on error case
+                            })
+                            .then(() => {
                                 that._instantiateComponent(oPlugin, oPluginDeferred, oPostMessageInterface);
-                            },
-                            () => { // note, no error logging here
-                                that._instantiateComponent(oPlugin, oPluginDeferred, oPostMessageInterface);
-                            }
-                        );
+                            });
                     } else {
                         that._mInitializedComponentPromise[oPlugin.component] = that._instantiateComponent(oPlugin, oPluginDeferred, oPostMessageInterface);
                     }
@@ -211,22 +211,22 @@ sap.ui.define([
                 getExtensions: fnGetExtensions.bind(null, oPlugin.component)
             };
 
-            function makeRejectHandler (sErrorLogMessage) {
+            function makeRejectHandler (sErrorMessage) {
                 return function (oError) {
-                    sErrorLogMessage = sErrorLogMessage ||
+                    sErrorMessage = sErrorMessage ||
                         `Cannot create UI5 plugin component: (componentId/appdescrId :${oApplicationProperties.ui5ComponentName})\n${
                             oError} properties ${JSON.stringify(oApplicationProperties)
                         }\n This indicates a plugin misconfiguration, see e.g. Note 2316443.`;
 
-                    // errors always logged per component
-                    oError = oError || "";
-                    Log.error(sErrorLogMessage,
-                        oError.stack, // stacktrace not only available for all browsers
-                        S_COMPONENT_NAME);
+                    Log.error(
+                        sErrorMessage,
+                        oError, // stacktrace not only available for all browsers
+                        S_COMPONENT_NAME
+                    );
                     if (oPluginDeferred) {
-                        oPluginDeferred.reject.apply(this, arguments);
+                        oPluginDeferred.reject(oError);
                     }
-                    oDeferred.reject.apply(this, arguments);
+                    oDeferred.reject(oError);
                 };
             }
 
@@ -360,8 +360,8 @@ sap.ui.define([
                 if (this._oConfig.isBlueBox !== true) {
                     this._buildNamesOfPluginsWithAgents();
                 }
-            } catch (e) {
-                Log.error("failed to build plugin agents names list", (e.message || e.toString()), "sap.ushell.services.PluginManager");
+            } catch (oError) {
+                Log.error("failed to build plugin agents names list", oError, "sap.ushell.services.PluginManager");
             }
 
             aPluginCategoriesToLoad.forEach((sCategory) => {
@@ -421,8 +421,8 @@ sap.ui.define([
                     );
                     try {
                         await ushellUtils.requireAsync([sModulePath]);
-                    } catch (e) {
-                        Log.error(`Plugin module ${sModulePath} is not found.`);
+                    } catch (oError) {
+                        Log.error(`Plugin module ${sModulePath} is not found.`, oError);
                     }
                     continue;
                 }
@@ -604,7 +604,7 @@ sap.ui.define([
             } else {
                 // plugin category is not supported
                 Log.error(`Plugins with category ${sPluginCategory} cannot be loaded by the PluginManager`, S_COMPONENT_NAME);
-                that._oCategoryLoadingProgress[sPluginCategory].reject(`Plugins with category ${sPluginCategory} cannot be loaded by the PluginManager`);
+                that._oCategoryLoadingProgress[sPluginCategory].reject(new Error(`Plugins with category ${sPluginCategory} cannot be loaded by the PluginManager`));
             }
 
             return that._oCategoryLoadingProgress[sPluginCategory].promise();

package/src/main/js/sap/ushell/services/ReferenceResolver.js

@@ -2,7 +2,7 @@
 
 /**
  * @fileOverview resolves references
- * @version 1.139.0
+ * @version 1.141.0
  */
 sap.ui.define([
     "sap/base/Log",
@@ -713,7 +713,7 @@ sap.ui.define([
                 let aDynamicDate;
                 try {
                     aDynamicDate = DynamicDateRange.toDates(oDateValue);
-                } catch (error) {
+                } catch (oError) {
                     return oResult;
                 }
 

package/src/main/js/sap/ushell/services/Search.js

@@ -2,7 +2,7 @@
 
 /**
  * @fileOverview The Unified Shell's search service which provides Enterprise Search via SINA.
- * @version 1.139.0
+ * @version 1.141.0
  */
 sap.ui.define([
     "sap/ui/core/Lib"

package/src/main/js/sap/ushell/services/SearchCEP.js

@@ -3,7 +3,7 @@
 /**
  * @fileOverview The Unified Shell's Search for myHome.
  *
- * @version 1.139.0
+ * @version 1.141.0
  */
 sap.ui.define([
     "sap/base/Log",
@@ -222,7 +222,7 @@ sap.ui.define([
      * @private
      * @since 1.116.0
      */
-    SearchCEP.prototype.registerExternalSearchProvider = function (oProviderConfig) {
+    SearchCEP.prototype.registerExternalSearchProvider = async function (oProviderConfig) {
         const oProvider = deepExtend(oProviderConfig);
         const fnNoOpFunction = Function.prototype;
         const oParameterCheck = {
@@ -244,7 +244,7 @@ sap.ui.define([
         for (const sKey in oParameterCheck) {
             if (!oProvider[sKey]) {
                 Log.error(oParameterCheck[sKey]);
-                return Promise.reject();
+                throw new Error(oParameterCheck[sKey]);
             }
         }
 

package/src/main/js/sap/ushell/services/SearchableContent.js

@@ -2,7 +2,7 @@
 
 /**
  * @fileOverview This module exposes the searchable content.
- * @version 1.139.0
+ * @version 1.141.0
  */
 sap.ui.define([
     "sap/ushell/Config",
@@ -142,7 +142,7 @@ sap.ui.define([
                 return aApps;
             } catch (oError) {
                 Log.error("SearchableContent@getApps in classic mode failed", oError);
-                return Promise.reject(oError);
+                throw oError;
             }
         }
 

package/src/main/js/sap/ushell/services/ShellNavigation.js

@@ -2,7 +2,7 @@
 
 /**
  * @fileOverview Shell Navigation Service.
- * @version 1.139.0
+ * @version 1.141.0
  * @deprecated since 1.120. Use {@link sap.ushell.services.Navigation} for Navigation instead.
  */
 sap.ui.define([

package/src/main/js/sap/ushell/services/ShellNavigationHashChanger.js

@@ -830,8 +830,8 @@ sap.ui.define([
                 if (sFilterResult === this.NavigationFilterStatus.Keep) {
                     bShouldKeep = true;
                 }
-            } catch (e) {
-                Log.error("Error while calling Navigation filter! ignoring filter...", e.message, "sap.ushell.services.ShellNavigationHashChanger");
+            } catch (oError) {
+                Log.error("Error while calling Navigation filter! ignoring filter...", oError, "sap.ushell.services.ShellNavigationHashChanger");
             }
         }
 

package/src/main/js/sap/ushell/services/ShellNavigationInternal.js

@@ -120,7 +120,7 @@ sap.ui.define([
             return this.NavigationFilterStatus.Continue;
         };
 
-        /////////////////////////////// api for external usage
+        // ///////////////////////////// api for external usage
 
         /**
          * Returns the current navigation context.

package/src/main/js/sap/ushell/services/SmartNavigation.js

@@ -12,7 +12,7 @@
  * it is pertinent that the API user employs this service's version of <code>toExternal()</code> for cross application
  * navigation (instead) of using the one provided by CrossApplicationNavigation service.</p>
  *
- * @version 1.139.0
+ * @version 1.141.0
  *
  * @deprecated since 1.112. Please use the CrossApplicationNavigation service instead.
  */
@@ -406,8 +406,7 @@ sap.ui.define([
             return `${oTarget.semanticObject}-${oTarget.action}`;
         }
 
-        // eslint-disable-next-line no-throw-literal
-        throw `Invalid intent \`${sIntent}\``;
+        throw new Error(`Invalid intent \`${sIntent}\``);
     };
 
     /**

package/src/main/js/sap/ushell/services/SpaceContent.js

@@ -2,7 +2,7 @@
 
 /**
  * @fileOverview APIs for the S/4 MyHome
- * @version 1.139.0
+ * @version 1.141.0
  */
 sap.ui.define([
     "sap/ushell/Config",

package/src/main/js/sap/ushell/services/UITracer.js

@@ -3,7 +3,7 @@
 /**
  * @fileOverview The Unified Shell's UI tracing service.
  *
- * @version 1.139.0
+ * @version 1.141.0
  */
 sap.ui.define([
     "sap/ushell/EventHub",
@@ -226,8 +226,8 @@ sap.ui.define([
         if (oConfigMeta) {
             try {
                 oConfigMeta = JSON.parse(oConfigMeta);
-            } catch (ex) {
-                Log.error("UITracer: unable to parse sap.flp.cf.Config", ex);
+            } catch (oError) {
+                Log.error("UITracer: unable to parse sap.flp.cf.Config", oError);
             }
             if (oConfigMeta && oConfigMeta.scenario) {
                 if (oConfigMeta.scenario === "LAUNCHPAD" && this._sSiteId === "sap.start.site") {
@@ -337,7 +337,7 @@ sap.ui.define([
                     "sap.ushell.services.UITracer"
                 );
                 return true;
-            } catch (ex) {
+            } catch (oError) {
                 return false;
             }
         }
@@ -412,7 +412,7 @@ sap.ui.define([
                     "",
                     "sap.ushell.services.UITracer"
                 );
-            } catch (ex) {
+            } catch (oError) {
                 Log.debug(
                     `UITracer: _sendTrace failed ${this._sServiceUrl} with size ${oBlob.size} byte, entry count ${this._aTrace.length}`,
                     "",

package/src/main/js/sap/ushell/services/URLParsing.js

@@ -18,13 +18,13 @@ sap.ui.define([
     "sap/ushell/utils",
     "sap/ushell/utils/UrlParsing",
     "sap/ushell/Container"
-], function (
+], (
     Log,
     BaseObject,
     utils,
     UrlParsingUtil,
     Container
-) {
+) => {
     "use strict";
 
     // usage : sap.ushell.Container.getServiceAsync("URLParsing").then(function (URLParsing) {
@@ -228,8 +228,8 @@ sap.ui.define([
          * @since 1.34.0
          * @private
          */
-        this.privparamsToString = function (oParams, sDelimiter, sAssign) {
-            return UrlParsingUtil.privparamsToString(oParams, sDelimiter, sAssign);
+        this.urlParametersToString = function (oParams, sDelimiter, sAssign) {
+            return UrlParsingUtil.urlParametersToString(oParams, sDelimiter, sAssign);
         };
 
         /**
@@ -399,20 +399,20 @@ sap.ui.define([
          * @deprecated since 1.31. Please use {@link sap.ui.model.odata.ODataUtils#setOrigin} instead.
          */
         this.addSystemToServiceUrl = function (sServiceUrl, vComponentOrSystem) {
-            var sSystem = vComponentOrSystem;
+            let sSystem = vComponentOrSystem;
 
             if (!sServiceUrl || sServiceUrl.indexOf("/") !== 0 || sServiceUrl.indexOf("//") === 0) {
-                throw new utils.Error("Invalid URL: " + sServiceUrl,
+                throw new utils.Error(`Invalid URL: ${sServiceUrl}`,
                     "sap.ushell.services.URLParsing");
             }
             if (BaseObject.isA(vComponentOrSystem, "sap.ui.core.Component")) {
-                var oComponentData = (typeof vComponentOrSystem.getComponentData === "function") && vComponentOrSystem.getComponentData();
+                const oComponentData = (typeof vComponentOrSystem.getComponentData === "function") && vComponentOrSystem.getComponentData();
                 sSystem = oComponentData && oComponentData.startupParameters && oComponentData.startupParameters["sap-system"]
                     && oComponentData.startupParameters["sap-system"][0];
             }
 
             // Container.getService is OK here. The NavTargetResolutionInternal service should be present already and the function is deprecated.
-            var oResolution = Container.getService("NavTargetResolutionInternal").getCurrentResolution(); // LEGACY API (deprecated)
+            const oResolution = Container.getService("NavTargetResolutionInternal").getCurrentResolution(); // LEGACY API (deprecated)
             // note: if component is specified but lacks sap-system, we do not do a fallback!
             if (!sSystem && !vComponentOrSystem && oResolution && oResolution.url) {
                 sSystem = new URL(oResolution.url, window.location.href).searchParams.get("sap-system");
@@ -421,10 +421,10 @@ sap.ui.define([
                 // do nothing, mo present
             } else if (/^[^?]*(;o=([/;?]|$))/.test(sServiceUrl)) {
                 // URL with ";o=" *not* followed by system: insert system
-                sServiceUrl = sServiceUrl.replace(/;o=([/;?]|$)/, (sSystem ? ";o=" + sSystem : "") + "$1");
+                sServiceUrl = sServiceUrl.replace(/;o=([/;?]|$)/, `${sSystem ? `;o=${sSystem}` : ""}$1`);
             } else if (!/^[^?]*;o=/.test(sServiceUrl) && sSystem) {
                 // URL without ";o=": append system
-                sServiceUrl = sServiceUrl.replace(/(\/[^?]*?)(\/$|$|(\/?\?.*))/, "$1;o=" + sSystem + "$2");
+                sServiceUrl = sServiceUrl.replace(/(\/[^?]*?)(\/$|$|(\/?\?.*))/, `$1;o=${sSystem}$2`);
             }
 
             Container.addRemoteSystemForServiceUrl(sServiceUrl);

package/src/main/js/sap/ushell/services/URLShortening.js

@@ -6,7 +6,7 @@
  * Service wrapper for the sap/ushell/utils/UrlShortening module.
  * @deprecated since 1.118. Please use the UrlShortening module directly.
  *
- * @version 1.139.0
+ * @version 1.141.0
  */
 sap.ui.define(["sap/ushell/utils/UrlShortening"], (UrlShortening) => {
     "use strict";

package/src/main/js/sap/ushell/services/URLTemplate.js

@@ -1,7 +1,7 @@
 // Copyright (c) 2009-2025 SAP SE, All Rights Reserved
 /**
  * @fileOverview The URLTemplate service provides utilities when working with URL templates
- * @version 1.139.0
+ * @version 1.141.0
  */
 sap.ui.define([
 ], (

package/src/main/js/sap/ushell/services/Ui5ComponentLoader.js

@@ -4,7 +4,7 @@
  * @fileOverview The Unified Shell's UI5 component loader service.
  * This is a shell-internal service and no public or application facing API!
  *
- * @version 1.139.0
+ * @version 1.141.0
  */
 sap.ui.define([
     "sap/base/Log",
@@ -312,7 +312,7 @@ sap.ui.define([
         );
 
         // Avoid warnings in ApplicationContainer.
-        // TODO: can be removed when ApplicationContainer construction is changed.
+        // TODO [FLPCOREANDUX-10024]: can be removed when ApplicationContainer construction is changed.
         delete oInstantiationData.appPropertiesSafe.loadCoreExt;
         delete oInstantiationData.appPropertiesSafe.loadDefaultDependencies;
 
@@ -352,29 +352,29 @@ sap.ui.define([
             }
 
             return oOriginalInputAppProperties;
-        } catch (vError) {
+        } catch (oError) {
             const sApplicationName = oComponentProperties.name;
             const sComponentProperties = JSON.stringify(oComponentProperties, null, 4);
 
             let sErrorReason = `The issue is most likely caused by application ${sApplicationName}`;
             let sAppPropertiesErrorMsg = `Failed to load UI5 component with properties: '${sComponentProperties}'.`;
 
-            if (vError.stack) {
-                sAppPropertiesErrorMsg += ` Error likely caused by:\n${vError.stack}`;
+            if (oError.stack) {
+                sAppPropertiesErrorMsg += ` Error likely caused by:\n${oError.stack}`;
             } else {
                 // Error usually appears in the stack trace if the app
                 // threw with new Error... but if it didn't we add it here:
-                sAppPropertiesErrorMsg += ` Error: '${vError}'`;
+                sAppPropertiesErrorMsg += ` Error: '${oError}'`;
             }
 
-            if (vError.status === "parsererror") {
+            if (oError.status === "parsererror") {
                 sErrorReason += ", as one or more of its resources could not be parsed";
             }
             sErrorReason += ". Please create a support incident and assign it to the support component of the respective application.";
 
             Log.error(sErrorReason, sAppPropertiesErrorMsg, sApplicationName);
 
-            throw vError;
+            throw oError;
         }
     };
 
@@ -580,9 +580,9 @@ sap.ui.define([
             // i.e. there is no need to check if the module has been loaded before
             // TODO: sap.ui.loader._.loadJSResourceAsync is private.
             return sap.ui.loader._.loadJSResourceAsync(sResource);
-        })).catch((vError) => {
-            Log.error(`Ui5ComponentLoader: failed to load bundle resources: [${aBundleResources.join(", ")}]`);
-            return Promise.reject(vError);
+        })).catch((oError) => {
+            Log.error(`Ui5ComponentLoader: failed to load bundle resources: [${aBundleResources.join(", ")}]`, oError);
+            throw oError;
         });
     };
 
@@ -645,7 +645,7 @@ sap.ui.define([
             AsyncHintsHelper.modifyUrls(oComponentProperties.asyncHints, this._removeCacheBusterTokenFromUrl);
         }
 
-        //This code is for the Flexible UI team, to allow loading application with a specific manifest version:
+        // This code is for the Flexible UI team, to allow loading application with a specific manifest version:
         // 1. first, we need to check if the "sap.ui.fl" is loaded
         // 2. then we need to call special api provided by the FL team to give us the manifest
         //    version to load based on the app id
@@ -662,19 +662,19 @@ sap.ui.define([
                         oComponentProperties.manifest = oManifestUrl.toString();
                     }
                     return oComponentProperties;
-                } catch (ex) {
-                    //if exception occurred in the process of getting the manifest version, continue without it so the component
-                    //can be created
+                } catch (oError) {
+                    // if exception occurred in the process of getting the manifest version, continue without it so the component
+                    // can be created
                     Log.error("Error when trying to get manifest version from 'sap.ui.fl.apply.api.FlexRuntimeInfoAPI'",
-                        ex,
+                        oError,
                         "sap.ushell.services.Ui5ComponentLoader");
                     return oComponentProperties;
                 }
-            } catch (ex) {
-                //if the "sap.ui.require" fails, we simply resolve in order to continue as is, so the component
-                //will be created without the manifest version (to avoid empty UI)
+            } catch (oError) {
+                // if the "sap.ui.require" fails, we simply resolve in order to continue as is, so the component
+                // will be created without the manifest version (to avoid empty UI)
                 Log.error("Error when trying to load 'sap/ui/fl/apply/api/FlexRuntimeInfoAPI'",
-                    ex,
+                    oError,
                     "sap.ushell.services.Ui5ComponentLoader");
                 return oComponentProperties;
             }

package/src/main/js/sap/ushell/services/UserDefaultParameterPersistence.js

@@ -14,7 +14,7 @@
  *
  * This is *not* an application facing service, but for Shell Internal usage.
  *
- * @version 1.139.0
+ * @version 1.141.0
  */
 sap.ui.define([
     "sap/base/Log",

package/src/main/js/sap/ushell/services/UserDefaultParameters.js

@@ -7,7 +7,7 @@
  *               This service should be accessed by the application
  *               via the CrossApplicationNavigation service.
  *
- * @version 1.139.0
+ * @version 1.141.0
  */
 sap.ui.define([
     "sap/base/Log",
@@ -481,8 +481,8 @@ sap.ui.define([
                 this._oWasParameterPersisted[sParameterName] = true;
 
                 await this._storeValue(sParameterName, oNewValue, false, oSystemContext)
-                    .catch((err) => {
-                        Log.error(err.message);
+                    .catch((oError) => {
+                        Log.error("Failed to store user default parameter: ", oError);
                     });
             }
 
@@ -512,7 +512,7 @@ sap.ui.define([
         /**
          * Converts an array of parameter names to an object with the parameter names as keys.
          * @param {string[]} aParameterNames the parameters in an array format.
-         * @returns {object<string, object>} the parameters in an object format.
+         * @returns {Object<string, object>} the parameters in an object format.
          *
          * @private
          */
@@ -533,7 +533,7 @@ sap.ui.define([
         this._getComponentNameOfPlugin = function (oPlugin) {
             try {
                 return oPlugin.getMetadata().getComponentName() || "";
-            } catch (error) {
+            } catch (oError) {
                 return "'name of plugin could not be determined'";
             }
         };
@@ -554,8 +554,8 @@ sap.ui.define([
                         const oResultMetadata = await ushellUtils.promisify(oDeferred);
 
                         return oResultMetadata;
-                    } catch (error) {
-                        Log.error(`Error invoking getEditorMetaData on plugin: ${error}${error.stack}`, null,
+                    } catch (oError) {
+                        Log.error("Error invoking getEditorMetaData on plugin:", oError,
                             "sap.ushell.services.UserDefaultParameters");
                         return;
                     }

package/src/main/js/sap/ushell/services/UserInfo.js

@@ -3,7 +3,7 @@
 /**
  * @fileOverview The Unified Shell's user information service. Allows retrieving information about the logged-in user.
  *
- * @version 1.139.0
+ * @version 1.141.0
  */
 sap.ui.define([
     "sap/base/Log",
@@ -190,7 +190,7 @@ sap.ui.define([
             if (oAdapter.getThemeRoot) {
                 const sThemeRoot = await oAdapter.getThemeRoot(sThemeId);
                 if (sThemeRoot !== undefined) {
-                    Container.getUser().addThemeRootForTheme({id: sThemeId, root:sThemeRoot});
+                    Container.getUser().addThemeRootForTheme({id: sThemeId, root: sThemeRoot});
                 }
             }
         };
@@ -204,8 +204,8 @@ sap.ui.define([
          */
         this.updateUserPreferences = function () {
             const oPromise = oAdapter.updateUserPreferences(Container.getUser());
-            oPromise.fail(() => {
-                Log.error("updateAttributes: ");
+            oPromise.fail((oError) => {
+                Log.error("updateAttributes failed:", oError);
             });
             return oPromise;
         };

package/src/main/js/sap/ushell/services/UserRecents/RecentAppsUsage.js

@@ -62,7 +62,7 @@ sap.ui.define([
                 return this.oAppsUsageData;
             } catch (oError) {
                 Log.error("Load data in Init failed", oError, "sap.ushell.services.UserRecents.RecentAppsUsage");
-                return Promise.reject(oError);
+                throw oError;
             }
         }
     };
@@ -99,7 +99,7 @@ sap.ui.define([
      */
     RecentAppsUsage.prototype.addAppUsage = async function (sHash) {
         if (!ushellUtils.validHash(sHash)) { // Check hash validity
-            return Promise.reject("Non valid hash");
+            throw new Error("Non valid hash");
         }
 
         await this.init();

package/src/main/js/sap/ushell/services/UserRecents/UserRecentsBase.js

@@ -46,9 +46,9 @@ sap.ui.define([
         try {
             const oContainer = await UserRecentsBase.prototype.oContainerPromise;
             return oContainer.getItemValue(this.sPersonalizationItemName);
-        } catch (error) {
-            Log.error("Personalization service does not work:", error);
-            return Promise.reject(error);
+        } catch (oError) {
+            Log.error("Personalization service does not work:", oError);
+            throw oError;
         }
     };
 
@@ -64,9 +64,9 @@ sap.ui.define([
             const oContainer = await UserRecentsBase.prototype.oContainerPromise;
             oContainer.setItemValue(this.sPersonalizationItemName, vData);
             await oContainer.save();
-        } catch (error) {
-            Log.error("Personalization service does not work:", error);
-            return Promise.reject(error);
+        } catch (oError) {
+            Log.error("Personalization service does not work:", oError);
+            throw oError;
         }
     };
 

package/src/main/js/sap/ushell/services/UserRecents.js

@@ -2,7 +2,7 @@
 
 /**
  * @fileOverview The Unified Shell's user activity service.
- * @version 1.139.0
+ * @version 1.141.0
  */
 sap.ui.define([
     "sap/base/util/ObjectPath",