@sapui5/sap.ushell 1.139.0 → 1.141.0

package/src/main/js/sap/ushell/components/tiles/indicatorArea/AreaChartTile.controller.js

@@ -128,10 +128,11 @@ sap.ui.define([
             const goaltype = this.DEFINITION_DATA.EVALUATION.GOAL_TYPE;
             const evaluationValues = this.DEFINITION_DATA.EVALUATION_VALUES;
             const cachedValue = sap.ushell.components.tiles.indicatorTileUtils.cache.getKpivalueById(that.oConfig.TILE_PROPERTIES.id);
+            let tempData;
 
             if (sap.ushell.components.tiles.indicatorTileUtils.util.isDualTile(that.oConfig)) {
                 if (cachedValue) {
-                    var tempData = cachedValue.Data && JSON.parse(cachedValue.Data);
+                    tempData = cachedValue.Data && JSON.parse(cachedValue.Data);
                 }
             }
             const chipUpdateTime = that.oTileApi.configuration.getParameterValueAsString("timeStamp");
@@ -171,154 +172,7 @@ sap.ui.define([
                         break;
                 }
             }
-            const isRefreshClick = sap.ushell.components.tiles.indicatorTileUtils.util.getBoolValue(bRefreshClick);
-            if ((tempData && !tempData.rightData) || !cachedValue || (!isCacheValid && that.oTileApi.visible.isVisible()) || isRefreshClick || (isAutoRefresh && that.oTileApi.visible.isVisible()) || that.getView().getViewData().refresh) {
-                if (that.kpiValueFetchDeferred) {
-                    that.kpiValueFetchDeferred = false;
-                    const oQuery = sap.ushell.components.tiles.indicatorTileUtils.util.prepareQueryServiceUri(that.oRunTimeODataModel, sEntitySet, fullyFormedMeasure, dimensionName, variantData);
-                    if (oQuery) {
-                        this.queryUriForTrendChart = oQuery.uri;
-                        const writeData = {};
-                        try {
-                            this.trendChartODataReadRef = oQuery.model.read(oQuery.uri, null, null, true, (data) => {
-                                that.kpiValueFetchDeferred = true;
-                                if (data && data.results && data.results.length) {
-                                    if (oQuery.unit[0]) {
-                                        that.unit = data.results[0][oQuery.unit[0].name];
-                                        that.CURRENCY_CODE = that.unit;
-                                        writeData.unit = oQuery.unit[0];
-                                        writeData.unit.name = oQuery.unit[0].name;
-                                    }
-                                    that.queryUriResponseForTrendChart = data;
-                                    dimensionName = sap.ushell.components.tiles.indicatorTileUtils.util.findTextPropertyForDimension(that.oRunTimeODataModel, sEntitySet, dimensionName);
-                                    data.results.splice(10);
-                                    data.firstXlabel = data.results[0][dimensionName];
-                                    data.lastXlabel = data.results[data.results.length - 1][dimensionName];
-                                    writeData.data = data;
-                                    if (writeData && writeData.data && writeData.data.results && writeData.data.results.length) {
-                                        for (let itr = 0; itr < writeData.data.results.length; itr++) {
-                                            delete writeData.data.results[itr].__metadata;
-                                        }
-                                    }
-                                    writeData.isCurM = that.isCurrencyMeasure(that.oConfig.EVALUATION.COLUMN_NAME);
-                                    writeData.dimensionName = dimensionName;
-                                    _applyData(data, that.DEFINITION_DATA.EVALUATION.VALUES_SOURCE);
 
-                                    const cacheData = {};
-                                    that.cacheTime = sap.ushell.components.tiles.indicatorTileUtils.util.getUTCDate();
-                                    cacheData.ChipId = that.oConfig.TILE_PROPERTIES.id;
-                                    cacheData.Data = JSON.stringify(writeData);
-                                    cacheData.CacheMaxAge = Number(that.chipCacheTime);
-                                    cacheData.CacheMaxAgeUnit = that.chipCacheTimeUnit;
-                                    cacheData.CacheType = 1;
-
-                                    const localCache = that.getLocalCache(cacheData);
-
-                                    if (that.DEFINITION_DATA.TILE_PROPERTIES.frameType == FrameType.TwoByOne) {
-                                        const tempCacheData = sap.ushell.components.tiles.indicatorTileUtils.cache.getKpivalueById(that.oConfig.TILE_PROPERTIES.id);
-                                        let avilableCacheData;
-                                        if (tempCacheData) {
-                                            if (!tempCacheData.CachedTime) {
-                                                tempCacheData.CachedTime = sap.ushell.components.tiles.indicatorTileUtils.util.getUTCDate();
-                                            }
-                                            avilableCacheData = tempCacheData.Data;
-                                            if (avilableCacheData) {
-                                                avilableCacheData = JSON.parse(avilableCacheData);
-                                                avilableCacheData.rightData = writeData;
-                                            }
-                                            tempCacheData.Data = JSON.stringify(avilableCacheData);
-                                            sap.ushell.components.tiles.indicatorTileUtils.cache.setKpivalueById(that.oConfig.TILE_PROPERTIES.id, tempCacheData);
-                                        } else {
-                                            avilableCacheData = {};
-                                            avilableCacheData.rightData = writeData;
-                                            localCache.Data = JSON.stringify(avilableCacheData);
-                                            sap.ushell.components.tiles.indicatorTileUtils.cache.setKpivalueById(that.oConfig.TILE_PROPERTIES.id, localCache);
-                                        }
-                                        that.cacheWriteData = writeData;
-                                        that.getView().getViewData().deferredObj.resolve();
-                                    } else {
-                                        sap.ushell.components.tiles.indicatorTileUtils.cache.setKpivalueById(that.oConfig.TILE_PROPERTIES.id, localCache);
-                                        let bUpdate = false;
-                                        if (cachedValue) {
-                                            bUpdate = true;
-                                        }
-                                        if (that.chipCacheTime) {
-                                            sap.ushell.components.tiles.indicatorTileUtils.util.writeFrontendCacheByChipAndUserId(that.oTileApi, that.oConfig.TILE_PROPERTIES.id, cacheData,
-                                                bUpdate, (data) => {
-                                                    if (data) {
-                                                        that.cacheTime = data && data.CachedTime;
-                                                        sap.ushell.components.tiles.indicatorTileUtils.cache.setKpivalueById(that.oConfig.TILE_PROPERTIES.id, data);
-                                                        that.setTimeStamp();
-                                                    }
-                                                    if (that.chipCacheTime &&
-                                                        !sap.ushell.components.tiles.indicatorTileUtils.util.isDualTile(that.oConfig)) {
-                                                        that.setTimeStamp(that.cacheTime);
-                                                    }
-                                                });
-                                        }
-                                        that.oKpiTileView.oGenericTile.setState(LoadState.Loaded);
-                                        that.updateDatajobScheduled = false;
-                                        const key = `${that.oConfig.TILE_PROPERTIES.id}data`;
-                                        let runningJob = sap.ushell.components.tiles.indicatorTileUtils.util.getScheduledJob(key);
-                                        if (runningJob) {
-                                            clearTimeout(runningJob);
-                                            runningJob = undefined;
-                                        }
-                                        that.scheduleJob(that.cacheTime);
-                                    }
-                                } else {
-                                    that.setNoData();
-                                }
-                            }, (eObject) => {
-                                that.kpiValueFetchDeferred = true;
-                                if (eObject && eObject.response) {
-                                    that.logError("Data call failed");
-                                }
-                            });
-                        } catch (e) {
-                            that.kpiValueFetchDeferred = true;
-                            that.logError(e);
-                        }
-                    } else {
-                        that.kpiValueFetchDeferred = true;
-                        that.logError();
-                    }
-                }
-            } else if (cachedValue && cachedValue.Data) {
-                try {
-                    let kpiData;
-                    const tileType = that.oConfig && that.oConfig.TILE_PROPERTIES && that.oConfig.TILE_PROPERTIES.tileType;
-                    if (tileType.indexOf("DT-") == -1) {
-                        kpiData = cachedValue.Data && JSON.parse(cachedValue.Data);
-                    } else {
-                        kpiData = cachedValue.Data && JSON.parse(cachedValue.Data);
-                        kpiData = kpiData.rightData;
-                    }
-
-                    if (kpiData.unit) {
-                        that.unit = kpiData.data.results[0][kpiData.unit.name];
-                        that.CURRENCY_CODE = that.unit;
-                    }
-                    that.cacheTime = cachedValue.CachedTime;
-                    if (that.chipCacheTime &&
-                        !sap.ushell.components.tiles.indicatorTileUtils.util.isDualTile(that.oConfig)) {
-                        that.setTimeStamp(that.cacheTime);
-                    }
-                    that.queryUriResponseForTrendChart = kpiData.data;
-                    dimensionName = kpiData.dimensionName;
-                    _applyData(kpiData.data, that.DEFINITION_DATA.EVALUATION.VALUES_SOURCE);
-                    if (that.oConfig.TILE_PROPERTIES.frameType == FrameType.OneByOne) {
-                        that.oKpiTileView.oGenericTile.setState(LoadState.Loaded);
-                    } else {
-                        that.getView().getViewData().deferredObj.resolve();
-                    }
-                    that.scheduleJob(that.cacheTime);
-                } catch (e) {
-                    that.logError(e);
-                }
-            } else {
-                that.setNoData();
-            }
             function _applyData (data, type) {
                 const dimensionArray = [];
                 const measureArray = [];
@@ -376,10 +230,12 @@ sap.ui.define([
                     formattedLastYLabel += " %";
                 }
                 const lastYLabel = formattedLastYLabel.toString();
+                let minDimension;
+                let maxDimension;
 
                 try {
-                    var minDimension = sap.ushell.components.tiles.indicatorTileUtils.util.formatOdataObjectToString(Math.min.apply(Math, dimensionArray)); // to obtain the starting value
-                    var maxDimension = sap.ushell.components.tiles.indicatorTileUtils.util.formatOdataObjectToString(Math.max.apply(Math, dimensionArray)); // to obtain the last value
+                    minDimension = sap.ushell.components.tiles.indicatorTileUtils.util.formatOdataObjectToString(Math.min.apply(Math, dimensionArray)); // to obtain the starting value
+                    maxDimension = sap.ushell.components.tiles.indicatorTileUtils.util.formatOdataObjectToString(Math.max.apply(Math, dimensionArray)); // to obtain the last value
                 } catch (e) {
                     that.logError(e);
                 }
@@ -580,7 +436,7 @@ sap.ui.define([
                         break;
                 }
 
-                const buildChartItem = function (sName, a, b, type) {
+                function buildChartItem (sName, a, b, type) {
                     return new AreaMicroChartItem({
                         color: `{/${sName}/color}`,
                         points: {
@@ -591,7 +447,7 @@ sap.ui.define([
                             })
                         }
                     });
-                };
+                }
                 const TileRef = that.getView().oNVConfContS; // that.getTile().getTileContent()[0].getContent();
                 TileRef.setTarget(buildChartItem("target", dimensionName, targetMeasure));
                 TileRef.setInnerMinThreshold(buildChartItem("innerMinThreshold", dimensionName, innerMinThresholdMeasure));
@@ -607,6 +463,155 @@ sap.ui.define([
                     that._updateTileModel(updatedModel);
                 }
             }
+
+            const isRefreshClick = sap.ushell.components.tiles.indicatorTileUtils.util.getBoolValue(bRefreshClick);
+            if ((tempData && !tempData.rightData) || !cachedValue || (!isCacheValid && that.oTileApi.visible.isVisible()) || isRefreshClick || (isAutoRefresh && that.oTileApi.visible.isVisible()) || that.getView().getViewData().refresh) {
+                if (that.kpiValueFetchDeferred) {
+                    that.kpiValueFetchDeferred = false;
+                    const oQuery = sap.ushell.components.tiles.indicatorTileUtils.util.prepareQueryServiceUri(that.oRunTimeODataModel, sEntitySet, fullyFormedMeasure, dimensionName, variantData);
+                    if (oQuery) {
+                        this.queryUriForTrendChart = oQuery.uri;
+                        const writeData = {};
+                        try {
+                            this.trendChartODataReadRef = oQuery.model.read(oQuery.uri, null, null, true, (data) => {
+                                that.kpiValueFetchDeferred = true;
+                                if (data && data.results && data.results.length) {
+                                    if (oQuery.unit[0]) {
+                                        that.unit = data.results[0][oQuery.unit[0].name];
+                                        that.CURRENCY_CODE = that.unit;
+                                        writeData.unit = oQuery.unit[0];
+                                        writeData.unit.name = oQuery.unit[0].name;
+                                    }
+                                    that.queryUriResponseForTrendChart = data;
+                                    dimensionName = sap.ushell.components.tiles.indicatorTileUtils.util.findTextPropertyForDimension(that.oRunTimeODataModel, sEntitySet, dimensionName);
+                                    data.results.splice(10);
+                                    data.firstXlabel = data.results[0][dimensionName];
+                                    data.lastXlabel = data.results[data.results.length - 1][dimensionName];
+                                    writeData.data = data;
+                                    if (writeData && writeData.data && writeData.data.results && writeData.data.results.length) {
+                                        for (let itr = 0; itr < writeData.data.results.length; itr++) {
+                                            delete writeData.data.results[itr].__metadata;
+                                        }
+                                    }
+                                    writeData.isCurM = that.isCurrencyMeasure(that.oConfig.EVALUATION.COLUMN_NAME);
+                                    writeData.dimensionName = dimensionName;
+                                    _applyData(data, that.DEFINITION_DATA.EVALUATION.VALUES_SOURCE);
+
+                                    const cacheData = {};
+                                    that.cacheTime = sap.ushell.components.tiles.indicatorTileUtils.util.getUTCDate();
+                                    cacheData.ChipId = that.oConfig.TILE_PROPERTIES.id;
+                                    cacheData.Data = JSON.stringify(writeData);
+                                    cacheData.CacheMaxAge = Number(that.chipCacheTime);
+                                    cacheData.CacheMaxAgeUnit = that.chipCacheTimeUnit;
+                                    cacheData.CacheType = 1;
+
+                                    const localCache = that.getLocalCache(cacheData);
+
+                                    if (that.DEFINITION_DATA.TILE_PROPERTIES.frameType == FrameType.TwoByOne) {
+                                        const tempCacheData = sap.ushell.components.tiles.indicatorTileUtils.cache.getKpivalueById(that.oConfig.TILE_PROPERTIES.id);
+                                        let avilableCacheData;
+                                        if (tempCacheData) {
+                                            if (!tempCacheData.CachedTime) {
+                                                tempCacheData.CachedTime = sap.ushell.components.tiles.indicatorTileUtils.util.getUTCDate();
+                                            }
+                                            avilableCacheData = tempCacheData.Data;
+                                            if (avilableCacheData) {
+                                                avilableCacheData = JSON.parse(avilableCacheData);
+                                                avilableCacheData.rightData = writeData;
+                                            }
+                                            tempCacheData.Data = JSON.stringify(avilableCacheData);
+                                            sap.ushell.components.tiles.indicatorTileUtils.cache.setKpivalueById(that.oConfig.TILE_PROPERTIES.id, tempCacheData);
+                                        } else {
+                                            avilableCacheData = {};
+                                            avilableCacheData.rightData = writeData;
+                                            localCache.Data = JSON.stringify(avilableCacheData);
+                                            sap.ushell.components.tiles.indicatorTileUtils.cache.setKpivalueById(that.oConfig.TILE_PROPERTIES.id, localCache);
+                                        }
+                                        that.cacheWriteData = writeData;
+                                        that.getView().getViewData().deferredObj.resolve();
+                                    } else {
+                                        sap.ushell.components.tiles.indicatorTileUtils.cache.setKpivalueById(that.oConfig.TILE_PROPERTIES.id, localCache);
+                                        let bUpdate = false;
+                                        if (cachedValue) {
+                                            bUpdate = true;
+                                        }
+                                        if (that.chipCacheTime) {
+                                            sap.ushell.components.tiles.indicatorTileUtils.util.writeFrontendCacheByChipAndUserId(that.oTileApi, that.oConfig.TILE_PROPERTIES.id, cacheData,
+                                                bUpdate, (data) => {
+                                                    if (data) {
+                                                        that.cacheTime = data && data.CachedTime;
+                                                        sap.ushell.components.tiles.indicatorTileUtils.cache.setKpivalueById(that.oConfig.TILE_PROPERTIES.id, data);
+                                                        that.setTimeStamp();
+                                                    }
+                                                    if (that.chipCacheTime &&
+                                                        !sap.ushell.components.tiles.indicatorTileUtils.util.isDualTile(that.oConfig)) {
+                                                        that.setTimeStamp(that.cacheTime);
+                                                    }
+                                                });
+                                        }
+                                        that.oKpiTileView.oGenericTile.setState(LoadState.Loaded);
+                                        that.updateDatajobScheduled = false;
+                                        const key = `${that.oConfig.TILE_PROPERTIES.id}data`;
+                                        let runningJob = sap.ushell.components.tiles.indicatorTileUtils.util.getScheduledJob(key);
+                                        if (runningJob) {
+                                            clearTimeout(runningJob);
+                                            runningJob = undefined;
+                                        }
+                                        that.scheduleJob(that.cacheTime);
+                                    }
+                                } else {
+                                    that.setNoData();
+                                }
+                            }, (eObject) => {
+                                that.kpiValueFetchDeferred = true;
+                                if (eObject && eObject.response) {
+                                    that.logError("Data call failed");
+                                }
+                            });
+                        } catch (e) {
+                            that.kpiValueFetchDeferred = true;
+                            that.logError(e);
+                        }
+                    } else {
+                        that.kpiValueFetchDeferred = true;
+                        that.logError();
+                    }
+                }
+            } else if (cachedValue && cachedValue.Data) {
+                try {
+                    let kpiData;
+                    const tileType = that.oConfig && that.oConfig.TILE_PROPERTIES && that.oConfig.TILE_PROPERTIES.tileType;
+                    if (tileType.indexOf("DT-") == -1) {
+                        kpiData = cachedValue.Data && JSON.parse(cachedValue.Data);
+                    } else {
+                        kpiData = cachedValue.Data && JSON.parse(cachedValue.Data);
+                        kpiData = kpiData.rightData;
+                    }
+
+                    if (kpiData.unit) {
+                        that.unit = kpiData.data.results[0][kpiData.unit.name];
+                        that.CURRENCY_CODE = that.unit;
+                    }
+                    that.cacheTime = cachedValue.CachedTime;
+                    if (that.chipCacheTime &&
+                        !sap.ushell.components.tiles.indicatorTileUtils.util.isDualTile(that.oConfig)) {
+                        that.setTimeStamp(that.cacheTime);
+                    }
+                    that.queryUriResponseForTrendChart = kpiData.data;
+                    dimensionName = kpiData.dimensionName;
+                    _applyData(kpiData.data, that.DEFINITION_DATA.EVALUATION.VALUES_SOURCE);
+                    if (that.oConfig.TILE_PROPERTIES.frameType == FrameType.OneByOne) {
+                        that.oKpiTileView.oGenericTile.setState(LoadState.Loaded);
+                    } else {
+                        that.getView().getViewData().deferredObj.resolve();
+                    }
+                    that.scheduleJob(that.cacheTime);
+                } catch (e) {
+                    that.logError(e);
+                }
+            } else {
+                that.setNoData();
+            }
         }
     });
     return AreaChartTileController;

package/src/main/js/sap/ushell/components/tiles/indicatorDual/DualTile.controller.js

@@ -425,7 +425,7 @@ sap.ui.define([
                             if (data) {
                                 sap.ushell.components.tiles.indicatorTileUtils.cache.setKpivalueById(that.oConfig.TILE_PROPERTIES.id, data);
                                 that.cacheTime = data.CachedTime;
-                                that.setTimeStamp.call(that);
+                                that.setTimeStamp();
                             }
                         });
                 }
@@ -433,7 +433,7 @@ sap.ui.define([
                     if (!that.cacheTime) {
                         that.cacheTime = cachedValue.CachedTime;
                     }
-                    that.setTimeStamp.call(that);
+                    that.setTimeStamp();
                     sap.ushell.components.tiles.indicatorTileUtils.util.scheduleFetchDataJob.call(that, that.oTileApi.visible.isVisible());
                 }
             }).fail(() => {

package/src/main/js/sap/ushell/components/tiles/indicatorDual/DualTile.view.js

@@ -53,6 +53,26 @@ sap.ui.define([
             return "sap.ushell.components.tiles.indicatorDual.DualTile";
         },
         createContent: function () {
+            function buildChartItem (sName) {
+                return new AreaMicroChartItem({
+                    color: "Good",
+                    points: {
+                        path: `/${sName}/data`,
+                        template: new AreaMicroChartPoint({
+                            x: "{day}",
+                            y: "{balance}"
+                        })
+                    }
+                });
+            }
+
+            function buildMACLabel (sName) {
+                return new AreaMicroChartLabel({
+                    label: `{/${sName}/label}`,
+                    color: `{/${sName}/color}`
+                });
+            }
+
             this.setHeight("100%");
             this.setWidth("100%");
 
@@ -137,26 +157,7 @@ sap.ui.define([
                     break;
 
                 case "DT-TT":
-                    var buildChartItem = function (sName) {
-                        return new AreaMicroChartItem({
-                            color: "Good",
-                            points: {
-                                path: `/${sName}/data`,
-                                template: new AreaMicroChartPoint({
-                                    x: "{day}",
-                                    y: "{balance}"
-                                })
-                            }
-                        });
-                    };
-
-                    var buildMACLabel = function (sName) {
-                        return new AreaMicroChartLabel({
-                            label: `{/${sName}/label}`,
-                            color: `{/${sName}/color}`
-                        });
-                    };
-                    var areaChart = new AreaMicroChart({
+                    const areaChart = new AreaMicroChart({
                         width: "{/width}",
                         height: "{/height}",
                         size: "{/size}",
@@ -186,12 +187,12 @@ sap.ui.define([
                     break;
 
                 case "DT-AT":
-                    var oBCDataTmpl = new BulletMicroChartData({
+                    const oBCDataTmpl = new BulletMicroChartData({
                         value: "{value}",
                         color: "{color}"
                     });
 
-                    var oBChart = new BulletMicroChart({
+                    const oBChart = new BulletMicroChart({
                         size: Size.Auto,
                         scale: "{/scale}",
                         actual: {

package/src/main/js/sap/ushell/components/tiles/indicatorDualComparison/DualComparison.controller.js

@@ -175,9 +175,10 @@ sap.ui.define([
             let tempVar;
             let aTitles = [];
             const that = this;
+            let eachData;
 
             for (i = 0; i < data.results.length; i++) {
-                var eachData = data.results[i];
+                eachData = data.results[i];
             }
             aTitles = sap.ushell.components.tiles.indicatorTileUtils.util.getAllMeasuresWithLabelText(this.oConfig.EVALUATION.ODATA_URL, this.oConfig.EVALUATION.ODATA_ENTITYSET);
             for (i = 0, l = aTitles.length; i < l; i++) {
@@ -235,6 +236,7 @@ sap.ui.define([
                 const sUri = this.oConfig.EVALUATION.ODATA_URL;
                 const entitySet = this.oConfig.EVALUATION.ODATA_ENTITYSET;
                 let measure;
+                let measures;
                 if (this.oConfig.TILE_PROPERTIES.semanticMeasure) {
                     /*
                      * Semantic Measure Inclusion (for Future use)
@@ -245,7 +247,7 @@ sap.ui.define([
                     measure = `${this.oConfig.EVALUATION.COLUMN_NAME},${this.oConfig.TILE_PROPERTIES.semanticMeasure}`;
                 } else {
                     measure = this.oConfig.EVALUATION.COLUMN_NAME;
-                    var measures = measure;
+                    measures = measure;
                     if (this.oConfig.TILE_PROPERTIES.COLUMN_NAMES) {
                         for (let j = 0; j < this.oConfig.TILE_PROPERTIES.COLUMN_NAMES.length; j++) {
                             if (this.oConfig.TILE_PROPERTIES.COLUMN_NAMES[j].COLUMN_NAME != this.oConfig.EVALUATION.COLUMN_NAME) {

package/src/main/js/sap/ushell/components/tiles/indicatorDualDeviation/DualDeviation.controller.js

@@ -214,7 +214,7 @@ sap.ui.define([
                                     }
                                     that.writeData.numericData = data;
 
-                                    let oScaledValue = ""; let trendIndicator;
+                                    let oScaledValue = "";
                                     let calculatedValueForScaling = kpiValue;
                                     if (that.oConfig.EVALUATION.SCALING == -2) {
                                         calculatedValueForScaling *= 100;
@@ -223,7 +223,7 @@ sap.ui.define([
 
                                     oScaledValue = sap.ushell.components.tiles.indicatorTileUtils.util.getLocaleFormattedValue(Number(calculatedValueForScaling),
                                         that.oConfig.EVALUATION.SCALING, that.oConfig.EVALUATION.DECIMAL_PRECISION);
-                                    trendIndicator = that.getTrendIndicator(sThresholdObject.trendValue, calculatedValueForScaling);
+                                    const trendIndicator = that.getTrendIndicator(sThresholdObject.trendValue, calculatedValueForScaling);
                                     if (that.oConfig.EVALUATION.SCALING == -2) {
                                         that._updateTileModel({
                                             scale: "%"
@@ -258,7 +258,7 @@ sap.ui.define([
                         }
                     }
                 } else if (cachedValue.data && cachedValue.data.results && cachedValue.data.results.length) {
-                    let calculatedValueForScaling; let oScaledValue; let trendIndicator;
+                    let calculatedValueForScaling;
                     sThresholdObject = that.setThresholdValues();
                     calculatedValueForScaling = cachedValue.data.results[0][that.DEFINITION_DATA.EVALUATION.COLUMN_NAME];
                     if (that.oConfig.EVALUATION.SCALING == -2) {
@@ -271,9 +271,9 @@ sap.ui.define([
                             scale: "%"
                         });
                     }
-                    oScaledValue = sap.ushell.components.tiles.indicatorTileUtils.util.getLocaleFormattedValue(Number(calculatedValueForScaling),
+                    const oScaledValue = sap.ushell.components.tiles.indicatorTileUtils.util.getLocaleFormattedValue(Number(calculatedValueForScaling),
                         that.oConfig.EVALUATION.SCALING, that.oConfig.EVALUATION.DECIMAL_PRECISION);
-                    trendIndicator = that.getTrendIndicator(sThresholdObject.trendValue, calculatedValueForScaling);
+                    const trendIndicator = that.getTrendIndicator(sThresholdObject.trendValue, calculatedValueForScaling);
 
                     if (cachedValue.unit) {
                         that._updateTileModel({