@sapui5/sap.ushell 1.139.0 → 1.141.0

package/src/main/js/sap/ushell/thirdparty/webcomponents.js

@@ -90,19 +90,19 @@ sap.ui.define(['require', 'sap/ushell/thirdparty/webcomponents-base', 'sap/ushel
         }
         return data;
     };
-    availableLocales.forEach(localeId => webcomponentsBase.C(localeId, importAndCheck$2));
+    availableLocales.forEach(localeId => webcomponentsBase.C$1(localeId, importAndCheck$2));
 
     // @ts-nocheck
     const loadThemeProperties$1 = async (themeName) => {
         switch (themeName) {
-            case "sap_fiori_3": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-theming-sap-fiori_3-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css3'], resolve, reject); })).default;
-            case "sap_fiori_3_dark": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-theming-sap-fiori_3_dark-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css4'], resolve, reject); })).default;
-            case "sap_fiori_3_hcb": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-theming-sap-fiori_3_hcb-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css5'], resolve, reject); })).default;
-            case "sap_fiori_3_hcw": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-theming-sap-fiori_3_hcw-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css6'], resolve, reject); })).default;
-            case "sap_horizon": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-theming-sap-horizon-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css7'], resolve, reject); })).default;
-            case "sap_horizon_dark": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-theming-sap-horizon_dark-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css8'], resolve, reject); })).default;
-            case "sap_horizon_hcb": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-theming-sap-horizon_hcb-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css9'], resolve, reject); })).default;
-            case "sap_horizon_hcw": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-theming-sap-horizon_hcw-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css10'], resolve, reject); })).default;
+            case "sap_fiori_3": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-theming-sap-fiori_3-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css4'], resolve, reject); })).default;
+            case "sap_fiori_3_dark": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-theming-sap-fiori_3_dark-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css5'], resolve, reject); })).default;
+            case "sap_fiori_3_hcb": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-theming-sap-fiori_3_hcb-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css6'], resolve, reject); })).default;
+            case "sap_fiori_3_hcw": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-theming-sap-fiori_3_hcw-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css7'], resolve, reject); })).default;
+            case "sap_horizon": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-theming-sap-horizon-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css8'], resolve, reject); })).default;
+            case "sap_horizon_dark": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-theming-sap-horizon_dark-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css9'], resolve, reject); })).default;
+            case "sap_horizon_hcb": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-theming-sap-horizon_hcb-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css10'], resolve, reject); })).default;
+            case "sap_horizon_hcw": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-theming-sap-horizon_hcw-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css11'], resolve, reject); })).default;
             default: throw "unknown theme";
         }
     };
@@ -114,7 +114,7 @@ sap.ui.define(['require', 'sap/ushell/thirdparty/webcomponents-base', 'sap/ushel
         return data;
     };
     ["sap_fiori_3", "sap_fiori_3_dark", "sap_fiori_3_hcb", "sap_fiori_3_hcw", "sap_horizon", "sap_horizon_dark", "sap_horizon_hcb", "sap_horizon_hcw"]
-        .forEach(themeName => Icons.p("@ui5/webcomponents-theming", themeName, loadAndCheck$1));
+        .forEach(themeName => Icons.p("@" + "u" + "i" + "5" + "/" + "w" + "e" + "b" + "c" + "o" + "m" + "p" + "o" + "n" + "e" + "n" + "t" + "s" + "-" + "t" + "h" + "e" + "m" + "i" + "n" + "g", themeName, loadAndCheck$1));
 
     // @ts-nocheck
     const importMessageBundle$1 = async (localeId) => {
@@ -128,11 +128,11 @@ sap.ui.define(['require', 'sap/ushell/thirdparty/webcomponents-base', 'sap/ushel
             case "da": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-icons-messagebundle-da" */ 'sap/ushell/thirdparty/_dynamics/messagebundle_da'], resolve, reject); })).default;
             case "de": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-icons-messagebundle-de" */ 'sap/ushell/thirdparty/_dynamics/messagebundle_de'], resolve, reject); })).default;
             case "el": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-icons-messagebundle-el" */ 'sap/ushell/thirdparty/_dynamics/messagebundle_el'], resolve, reject); })).default;
-            case "en": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-icons-messagebundle-en" */ 'sap/ushell/thirdparty/_dynamics/messagebundle_en'], resolve, reject); })).default;
+            case "en": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-icons-messagebundle-en" */ 'sap/ushell/thirdparty/_dynamics/messagebundle_en2'], resolve, reject); })).default;
             case "en_GB": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-icons-messagebundle-en_GB" */ 'sap/ushell/thirdparty/_dynamics/messagebundle_en_GB'], resolve, reject); })).default;
-            case "en_US_sappsd": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-icons-messagebundle-en_US_sappsd" */ 'sap/ushell/thirdparty/_dynamics/messagebundle_en_US_sappsd'], resolve, reject); })).default;
-            case "en_US_saprigi": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-icons-messagebundle-en_US_saprigi" */ 'sap/ushell/thirdparty/_dynamics/messagebundle_en_US_saprigi'], resolve, reject); })).default;
-            case "en_US_saptrc": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-icons-messagebundle-en_US_saptrc" */ 'sap/ushell/thirdparty/_dynamics/messagebundle_en_US_saptrc'], resolve, reject); })).default;
+            case "en_US_sappsd": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-icons-messagebundle-en_US_sappsd" */ 'sap/ushell/thirdparty/_dynamics/messagebundle_en_US_sappsd2'], resolve, reject); })).default;
+            case "en_US_saprigi": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-icons-messagebundle-en_US_saprigi" */ 'sap/ushell/thirdparty/_dynamics/messagebundle_en_US_saprigi2'], resolve, reject); })).default;
+            case "en_US_saptrc": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-icons-messagebundle-en_US_saptrc" */ 'sap/ushell/thirdparty/_dynamics/messagebundle_en_US_saptrc2'], resolve, reject); })).default;
             case "es": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-icons-messagebundle-es" */ 'sap/ushell/thirdparty/_dynamics/messagebundle_es'], resolve, reject); })).default;
             case "es_MX": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-icons-messagebundle-es_MX" */ 'sap/ushell/thirdparty/_dynamics/messagebundle_es_MX'], resolve, reject); })).default;
             case "et": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-icons-messagebundle-et" */ 'sap/ushell/thirdparty/_dynamics/messagebundle_et'], resolve, reject); })).default;
@@ -232,20 +232,20 @@ sap.ui.define(['require', 'sap/ushell/thirdparty/webcomponents-base', 'sap/ushel
         "zh_CN",
         "zh_TW",];
     localeIds$1.forEach(localeId => {
-        Icons.$$1("@ui5/webcomponents-icons", localeId, importAndCheck$1);
+        Icons.$("@" + "u" + "i" + "5" + "/" + "w" + "e" + "b" + "c" + "o" + "m" + "p" + "o" + "n" + "e" + "n" + "t" + "s" + "-" + "i" + "c" + "o" + "n" + "s", localeId, importAndCheck$1);
     });
 
     // @ts-nocheck
     const loadThemeProperties = async (themeName) => {
         switch (themeName) {
-            case "sap_fiori_3": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-sap-fiori_3-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css11'], resolve, reject); })).default;
-            case "sap_fiori_3_dark": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-sap-fiori_3_dark-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css12'], resolve, reject); })).default;
-            case "sap_fiori_3_hcb": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-sap-fiori_3_hcb-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css13'], resolve, reject); })).default;
-            case "sap_fiori_3_hcw": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-sap-fiori_3_hcw-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css14'], resolve, reject); })).default;
-            case "sap_horizon": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-sap-horizon-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css15'], resolve, reject); })).default;
-            case "sap_horizon_dark": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-sap-horizon_dark-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css16'], resolve, reject); })).default;
-            case "sap_horizon_hcb": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-sap-horizon_hcb-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css17'], resolve, reject); })).default;
-            case "sap_horizon_hcw": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-sap-horizon_hcw-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css18'], resolve, reject); })).default;
+            case "sap_fiori_3": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-sap-fiori_3-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css12'], resolve, reject); })).default;
+            case "sap_fiori_3_dark": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-sap-fiori_3_dark-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css13'], resolve, reject); })).default;
+            case "sap_fiori_3_hcb": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-sap-fiori_3_hcb-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css14'], resolve, reject); })).default;
+            case "sap_fiori_3_hcw": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-sap-fiori_3_hcw-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css15'], resolve, reject); })).default;
+            case "sap_horizon": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-sap-horizon-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css16'], resolve, reject); })).default;
+            case "sap_horizon_dark": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-sap-horizon_dark-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css17'], resolve, reject); })).default;
+            case "sap_horizon_hcb": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-sap-horizon_hcb-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css18'], resolve, reject); })).default;
+            case "sap_horizon_hcw": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-sap-horizon_hcw-parameters-bundle" */ 'sap/ushell/thirdparty/_dynamics/parameters-bundle.css19'], resolve, reject); })).default;
             default: throw "unknown theme";
         }
     };
@@ -257,7 +257,7 @@ sap.ui.define(['require', 'sap/ushell/thirdparty/webcomponents-base', 'sap/ushel
         return data;
     };
     ["sap_fiori_3", "sap_fiori_3_dark", "sap_fiori_3_hcb", "sap_fiori_3_hcw", "sap_horizon", "sap_horizon_dark", "sap_horizon_hcb", "sap_horizon_hcw"]
-        .forEach(themeName => Icons.p("@ui5/webcomponents", themeName, loadAndCheck));
+        .forEach(themeName => Icons.p("@" + "u" + "i" + "5" + "/" + "w" + "e" + "b" + "c" + "o" + "m" + "p" + "o" + "n" + "e" + "n" + "t" + "s", themeName, loadAndCheck));
 
     // @ts-nocheck
     const importMessageBundle = async (localeId) => {
@@ -271,11 +271,11 @@ sap.ui.define(['require', 'sap/ushell/thirdparty/webcomponents-base', 'sap/ushel
             case "da": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-messagebundle-da" */ 'sap/ushell/thirdparty/_dynamics/messagebundle_da2'], resolve, reject); })).default;
             case "de": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-messagebundle-de" */ 'sap/ushell/thirdparty/_dynamics/messagebundle_de2'], resolve, reject); })).default;
             case "el": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-messagebundle-el" */ 'sap/ushell/thirdparty/_dynamics/messagebundle_el2'], resolve, reject); })).default;
-            case "en": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-messagebundle-en" */ 'sap/ushell/thirdparty/_dynamics/messagebundle_en2'], resolve, reject); })).default;
+            case "en": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-messagebundle-en" */ 'sap/ushell/thirdparty/_dynamics/messagebundle_en3'], resolve, reject); })).default;
             case "en_GB": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-messagebundle-en_GB" */ 'sap/ushell/thirdparty/_dynamics/messagebundle_en_GB2'], resolve, reject); })).default;
-            case "en_US_sappsd": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-messagebundle-en_US_sappsd" */ 'sap/ushell/thirdparty/_dynamics/messagebundle_en_US_sappsd2'], resolve, reject); })).default;
-            case "en_US_saprigi": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-messagebundle-en_US_saprigi" */ 'sap/ushell/thirdparty/_dynamics/messagebundle_en_US_saprigi2'], resolve, reject); })).default;
-            case "en_US_saptrc": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-messagebundle-en_US_saptrc" */ 'sap/ushell/thirdparty/_dynamics/messagebundle_en_US_saptrc2'], resolve, reject); })).default;
+            case "en_US_sappsd": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-messagebundle-en_US_sappsd" */ 'sap/ushell/thirdparty/_dynamics/messagebundle_en_US_sappsd3'], resolve, reject); })).default;
+            case "en_US_saprigi": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-messagebundle-en_US_saprigi" */ 'sap/ushell/thirdparty/_dynamics/messagebundle_en_US_saprigi3'], resolve, reject); })).default;
+            case "en_US_saptrc": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-messagebundle-en_US_saptrc" */ 'sap/ushell/thirdparty/_dynamics/messagebundle_en_US_saptrc3'], resolve, reject); })).default;
             case "es": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-messagebundle-es" */ 'sap/ushell/thirdparty/_dynamics/messagebundle_es2'], resolve, reject); })).default;
             case "es_MX": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-messagebundle-es_MX" */ 'sap/ushell/thirdparty/_dynamics/messagebundle_es_MX2'], resolve, reject); })).default;
             case "et": return (await new Promise(function (resolve, reject) { require([/* webpackChunkName: "ui5-webcomponents-messagebundle-et" */ 'sap/ushell/thirdparty/_dynamics/messagebundle_et2'], resolve, reject); })).default;
@@ -375,7 +375,7 @@ sap.ui.define(['require', 'sap/ushell/thirdparty/webcomponents-base', 'sap/ushel
         "zh_CN",
         "zh_TW",];
     localeIds.forEach(localeId => {
-        Icons.$$1("@ui5/webcomponents", localeId, importAndCheck);
+        Icons.$("@" + "u" + "i" + "5" + "/" + "w" + "e" + "b" + "c" + "o" + "m" + "p" + "o" + "n" + "e" + "n" + "t" + "s", localeId, importAndCheck);
     });
 
 }));

package/src/main/js/sap/ushell/ui/QuickAccess.js

@@ -13,7 +13,9 @@ sap.ui.define([
     "sap/ushell/utils",
     "sap/ushell/utils/WindowUtils",
     "sap/ushell/utils/AppType",
-    "sap/ushell/EventHub"
+    "sap/ushell/EventHub",
+    "sap/ushell/api/performance/Extension",
+    "sap/ushell/api/performance/NavigationSource"
 ], (
     Element,
     Fragment,
@@ -27,7 +29,9 @@ sap.ui.define([
     utils,
     WindowUtils,
     AppTypeUtils,
-    EventHub
+    EventHub,
+    Extension,
+    NavigationSource
 ) => {
     "use strict";
 
@@ -35,6 +39,7 @@ sap.ui.define([
     const AppType = ushellLibrary.AppType;
 
     const oQuickAccess = {
+        oExtension: new Extension(),
         oModel: new JSONModel({
             recentActivities: [],
             frequentActivities: []
@@ -102,27 +107,25 @@ sap.ui.define([
 
             const oUserRecentsService = await Container.getServiceAsync("UserRecents");
             const aRecentActivities = await new Promise((resolve) => {
-                oUserRecentsService.getRecentActivity().then(
-                    (aActivities) => {
+                oUserRecentsService.getRecentActivity()
+                    .then((aActivities) => {
                         resolve(aActivities.map((oActivity) => {
                             oActivity.timestamp = utils.formatDate(oActivity.timestamp);
                             return oActivity;
                         }));
-                    },
-                    () => {
+                    })
+                    .catch(() => {
                         resolve([]);
-                    }
-                );
+                    });
             });
             const aFrequentActivities = await new Promise((resolve) => {
-                oUserRecentsService.getFrequentActivity().then(
-                    (aActivity) => {
+                oUserRecentsService.getFrequentActivity()
+                    .then((aActivity) => {
                         resolve(aActivity);
-                    },
-                    () => {
+                    })
+                    .catch(() => {
                         resolve([]);
-                    }
-                );
+                    });
             });
 
             this.oModel.setData({
@@ -197,6 +200,11 @@ sap.ui.define([
             const sPath = oEvent.getParameter("listItem").getBindingContextPath();
             const oItemModel = this.oModel.getProperty(sPath);
 
+            this.oExtension.addNavigationSource(
+                /recentActivities/.test(sPath) ?
+                    NavigationSource.RecentlyUsed :
+                    NavigationSource.FrequentlyUsed
+            );
             EventHub.emit("UITracer.trace", {
                 reason: "LaunchApp",
                 source: "Link",

package/src/main/js/sap/ushell/ui/ShellHeader.js

@@ -572,11 +572,11 @@ sap.ui.define([
         // restore all hidden elements to unhide some or all of them when the user makes the window wider
         oBeginContainer.style.flexBasis = "";
         oEndContainer.style.display = "";
-        aElements.forEach((e) => {
-            if (e.getAttribute("id") === "shellAppTitle") {
-                e.classList.remove("sapUiPseudoInvisibleText");
+        aElements.forEach((oElement) => {
+            if (oElement.getAttribute("id") === "shellAppTitle") {
+                oElement.classList.remove("sapUiPseudoInvisibleText");
             } else {
-                e.style.display = "";
+                oElement.style.display = "";
             }
         });
 

package/src/main/js/sap/ushell/ui/appfinder/AppBoxInternal.js

@@ -150,9 +150,9 @@ sap.ui.define([
     // browser events
     AppBoxInternal.prototype.onclick = AppBoxInternal.prototype.firePress;
 
-    AppBoxInternal.prototype.onsapspace = function (e) {
-        e.preventDefault();
-        this.firePress(e);
+    AppBoxInternal.prototype.onsapspace = function (oEvent) {
+        oEvent.preventDefault();
+        this.firePress(oEvent);
     };
 
     AppBoxInternal.prototype.onsapenter = AppBoxInternal.prototype.onsapspace;

package/src/main/js/sap/ushell/ui/cards/RecentActivitiesExtension.js

@@ -3,7 +3,7 @@
 /**
  * @fileOverview Extension for recent activities card
  *
- * @version 1.139.0
+ * @version 1.141.0
  */
 sap.ui.define([
     "sap/ui/integration/Extension",

package/src/main/js/sap/ushell/ui/footerbar/AboutDialog.controller.js

@@ -85,8 +85,8 @@ sap.ui.define([
             const oAboutDialog = this._getDialog();
 
             // application info
-            this._setupAppInfoModel().catch((error) => {
-                Log.error("Failed to setup application info model.", error);
+            this._setupAppInfoModel().catch((oError) => {
+                Log.error("Failed to setup application info model.", oError);
             });
             // system information
             const oSystemInformation = this._getSystemInformation();
@@ -239,8 +239,8 @@ sap.ui.define([
                         oAboutDialog.setModel(new JSONModel(oApplicationInformation), "AppInfo");
                         resolve();
                     })
-                    .catch((error) => {
-                        reject(error);
+                    .catch((oError) => {
+                        reject(oError);
                     });
             });
         },

package/src/main/js/sap/ushell/ui/footerbar/AddBookmarkButton.js

@@ -480,11 +480,11 @@ sap.ui.define([
                         status: "resolved"
                     };
                 })
-                .catch((sMsg) => {
-                    Log.error("Failed to add one a bookmark: ", sMsg, "sap.ushell.ui.footerbar.AddBookmarkButton");
+                .catch((oError) => {
+                    Log.error("Failed to add one a bookmark: ", oError, "sap.ushell.ui.footerbar.AddBookmarkButton");
                     return {
                         pageId: oContentNode.id,
-                        error: sMsg,
+                        error: oError.message,
                         status: "failed"
                     };
                 });
@@ -577,7 +577,7 @@ sap.ui.define([
      * @returns {Promise} A promise which resolves on success
      * @deprecated since 1.118.
      */
-    AddBookmarkButton.prototype._handleOKButtonPressClassicMode = function () {
+    AddBookmarkButton.prototype._handleOKButtonPressClassicMode = async function () {
         const oBookmarkTileView = this.getBookmarkTileView();
         const oBookmarkTileController = oBookmarkTileView.getController();
         const oBookmarkData = oBookmarkTileController.getBookmarkTileData();
@@ -587,7 +587,7 @@ sap.ui.define([
             if (oTitle) {
                 oTitle.setValueState(ValueState.Error);
                 oTitle.setValueStateText(ushellResources.i18n.getText("bookmarkTitleInputError"));
-                return Promise.reject();
+                throw new Error("Invalid bookmark title");
             }
         }
         this.oDialog.setBusy(true);
@@ -607,8 +607,8 @@ sap.ui.define([
                 .then(() => {
                     oMessageService.info(ushellResources.i18n.getText("tile_created_msg"));
                 })
-                .catch((sMsg) => {
-                    Log.error("Failed to add bookmark", sMsg, "sap.ushell.ui.footerbar.AddBookmarkButton");
+                .catch((oError) => {
+                    Log.error("Failed to add bookmark", oError, "sap.ushell.ui.footerbar.AddBookmarkButton");
                     oMessageService.error(ushellResources.i18n.getText("fail_to_add_tile_msg"));
                 });
         });

package/src/main/js/sap/ushell/ui/footerbar/ContactSupportDialog.controller.js

@@ -114,7 +114,7 @@ sap.ui.define([
                 try {
                     await oSupportTicketService.createTicket({ subject: sSubject, text: sText, clientContext: this.oClientContext });
                     oMessageService.info(resources.i18n.getText("supportTicketCreationSuccess"));
-                } catch (error) {
+                } catch (oError) {
                     oMessageService.error(resources.i18n.getText("supportTicketCreationFailed"));
                 }
                 this.closeDialog();

package/src/main/js/sap/ushell/ui/footerbar/JamShareButton.js

@@ -81,6 +81,10 @@ sap.ui.define([
 
         if (Container.inAppRuntime()) {
             this.adjustFLPUrl(this.getJamData())
+                .catch((oError) => {
+                    Log.error("Could not retrieve FLP URL", oError, "sap.ushell.ui.footerbar.JamShareButton");
+                    throw oError;
+                })
                 .then(() => {
                     return this.oShareComponentPromise.then((oShareComponent) => {
                         oShareComponent.open();
@@ -88,9 +92,6 @@ sap.ui.define([
                             cb();
                         }
                     });
-                }, (sError) => {
-                    Log.error("Could not retrieve FLP URL", sError, "sap.ushell.ui.footerbar.JamShareButton");
-                    return undefined;
                 });
         } else {
             return this.oShareComponentPromise.then((oShareComponent) => {

package/src/main/js/sap/ushell/ui/footerbar/SendAsEmailButton.js

@@ -73,8 +73,8 @@ sap.ui.define([
         // If we're running over an IFrame...
         if (Container.inAppRuntime()) {
             // DO NOT CHANGE the line below, this is to optimize the bundle build process
-            sap.ui.require(["sap/ushell/appRuntime/ui5/AppRuntimeService"], (AppRuntimeService) => {
-                AppRuntimeService.sendMessageToOuterShell(
+            sap.ui.require(["sap/ushell/appRuntime/ui5/AppCommunicationMgr"], (AppCommunicationMgr) => {
+                AppCommunicationMgr.sendMessageToOuterShell(
                     "sap.ushell.services.ShellUIService.sendEmailWithFLPButton",
                     { bSetAppStateToPublic: true }
                 );

package/src/main/js/sap/ushell/ui/launchpad/CatalogsContainer.js

@@ -189,7 +189,7 @@ sap.ui.define([
             Measurement.resume("FLP:DashboardManager.CatalogsRendering");
             this.filterElements();
             Measurement.pause("FLP:DashboardManager.CatalogsRendering");
-        } catch (ex) {
+        } catch (oError) {
             Control.prototype.updateAggregation.apply(this, arguments);
         }
     };
@@ -317,8 +317,7 @@ sap.ui.define([
 
         // validate data is still can be added to the screen object and still the ordering will be ok else call refresh.
         if (!TileContainerUtils.validateOrder(aBindingContexts, aItems, indexSearchMissingFilteredElem)) {
-            // eslint-disable-next-line no-throw-literal
-            throw true;
+            throw new Error("Invalid order");
         }
 
         // add the missing elements and check if there is a need for header.

package/src/main/js/sap/ushell/ui/launchpad/DashboardGroupsContainer.js

@@ -111,7 +111,7 @@ sap.ui.define([
                     return groups[i];
                 }
             }
-        } catch (e) {
+        } catch {
             // continue regardless of error
         }
 

package/src/main/js/sap/ushell/ui/launchpad/ExtendedChangeDetection.js

@@ -7,7 +7,7 @@
  * of recreating them. Items which get removed from the aggregation get destroyed and items which get added to the
  * aggregation get created.
  *
- * @version 1.139.0
+ * @version 1.141.0
  */
 sap.ui.define([
     "sap/ui/base/ManagedObject",
@@ -80,7 +80,7 @@ sap.ui.define([
             try {
                 const oContext = JSON.parse(sContext);
                 return oContext[oBindingInfo.key];
-            } catch (err) {
+            } catch {
                 return sContext;
             }
         });

package/src/main/js/sap/ushell/ui/launchpad/LinkTileWrapperRenderer.js

@@ -54,8 +54,8 @@ sap.ui.define([
 
         try {
             oTileView = oControl.getTileViews()[0];
-        } catch (ex) {
-            Log.warning("Failed to load tile view: ", ex.message);
+        } catch (oError) {
+            Log.warning("Failed to load tile view: ", oError);
             tileLoadingFailed();
         }
 

package/src/main/js/sap/ushell/ui/launchpad/Section.js

@@ -3,7 +3,7 @@
 /**
  * @fileOverview Provides control sap.ushell.ui.launchpad.Section
  *
- * @version 1.139.0
+ * @version 1.141.0
  */
 sap.ui.define([
     "sap/base/Log",

package/src/main/js/sap/ushell/ui/launchpad/TileContainerUtils.js

@@ -109,8 +109,7 @@ sap.ui.define([
                 TileContainerUtils.applyFilterOnItem(elementsToDisplay[j], filters);
             } else {
                 // order problem needs to refresh.
-                // eslint-disable-next-line no-throw-literal
-                throw true;
+                throw new Error("Order problem needs to refresh");
             }
         }
 

package/src/main/js/sap/ushell/ui/launchpad/TileRenderer.js

@@ -27,8 +27,8 @@ sap.ui.define([
 
         try {
             oTileView = tile.getTileViews()[0];
-        } catch (oException) {
-            Log.warning("Failed to load tile view: ", oException.message);
+        } catch (oError) {
+            Log.warning("Failed to load tile view: ", oError);
             oTileView = tile.getFailedtoLoadViewText();
         }
         const oTileContainer = tile.getParent();

package/src/main/js/sap/ushell/ui/launchpad/VizInstance.js

@@ -611,9 +611,10 @@ sap.ui.define([
     };
 
     /**
-     * Handles the keyup event while edit mode is active
-     * If delete or backspace is pressed, the focused VizInstance gets removes.
-     * If space or enter is pressed, the navigation gets prevented.
+     * Handles the keyup event
+     * while edit mode is active:
+     *  - If delete or backspace is pressed, the focused VizInstance gets removes.
+     *  - If space or enter is pressed, the navigation gets prevented.
      *
      * @param {sap.ui.base.Event} oEvent Browser Keyboard event
      *
@@ -621,17 +622,19 @@ sap.ui.define([
      * @private
      */
     VizInstance.prototype.onkeyup = function (oEvent) {
+        this._preventDefault(oEvent);
+
         if (this.getEditable()) {
             if ((PseudoEvents.events.sapdelete.fnCheck(oEvent) || PseudoEvents.events.sapbackspace.fnCheck(oEvent))) {
                 this.firePress({
                     scope: "Actions",
                     action: "Remove"
                 });
+                return;
             }
 
             if (PseudoEvents.events.sapspace.fnCheck(oEvent) || PseudoEvents.events.sapenter.fnCheck(oEvent)) {
                 this._openActionMenu();
-                this._preventDefault(oEvent);
             }
         }
     };

package/src/main/js/sap/ushell/ui/launchpad/section/CompactArea.js

@@ -3,7 +3,7 @@
 /**
  * @fileOverview Provides control sap.ushell.ui.launchpad.section.CompactArea
  *
- * @version 1.139.0
+ * @version 1.141.0
  */
 
 sap.ui.define([

package/src/main/js/sap/ushell/ui/shell/ShellAppTitle.js

@@ -507,8 +507,8 @@ sap.ui.define([
         oNavMenuPopover.attachAfterOpen(() => {
             // fix for scrolling (By @Alexander Pashkov) on sap.m.Popover being override
             // in Mobile by UI5
-            oNavMenu.$().on("touchmove.scrollFix", (e) => {
-                e.stopPropagation();
+            oNavMenu.$().on("touchmove.scrollFix", (oEvent) => {
+                oEvent.stopPropagation();
             });
 
             // calls to afterOpen on the navigation menu itself in case some things needed to be made
@@ -749,6 +749,7 @@ sap.ui.define([
     };
 
     ShellAppTitle.prototype.onkeyup = function (oEvent) {
+        Button.prototype.onkeyup.apply(this, arguments);
         if (oEvent.keyCode === 32) { // Spacebar
             this.onclick(oEvent);
         }

package/src/main/js/sap/ushell/ui/shell/ShellNavigationMenu.js

@@ -91,39 +91,39 @@ sap.ui.define([
         delete this.jqElement;
     };
 
-    KeyboardNavigation.prototype.keydownHandler = function (e) {
-        switch (e.keyCode) {
+    KeyboardNavigation.prototype.keydownHandler = function (oEvent) {
+        switch (oEvent.keyCode) {
             case this.keyCodes.ARROW_UP:
-                this.upDownHandler(e, true);
+                this.upDownHandler(oEvent, true);
                 break;
             case this.keyCodes.ARROW_DOWN:
-                this.upDownHandler(e, false);
+                this.upDownHandler(oEvent, false);
                 break;
             case this.keyCodes.ARROW_LEFT:
-                this.leftRightHandler(e, false);
+                this.leftRightHandler(oEvent, false);
                 break;
             case this.keyCodes.ARROW_RIGHT:
-                this.leftRightHandler(e, true);
+                this.leftRightHandler(oEvent, true);
                 break;
             case this.keyCodes.HOME:
-                this.homeEndHandler(e, true);
+                this.homeEndHandler(oEvent, true);
                 break;
             case this.keyCodes.END:
-                this.homeEndHandler(e, false);
+                this.homeEndHandler(oEvent, false);
                 break;
             case this.keyCodes.PAGE_UP:
                 // PageUp acts as Home
-                this.homeEndHandler(e, true);
+                this.homeEndHandler(oEvent, true);
                 break;
             case this.keyCodes.PAGE_DOWN:
                 // PageDown acts as End
-                this.homeEndHandler(e, false);
+                this.homeEndHandler(oEvent, false);
                 break;
             case this.keyCodes.TAB:
-                if (e && e.shiftKey) {
-                    this._setItemFocus(e, jQuery("#sapUshellNavHierarchyItems li:[tabindex='0']"));
+                if (oEvent && oEvent.shiftKey) {
+                    this._setItemFocus(oEvent, jQuery("#sapUshellNavHierarchyItems li:[tabindex='0']"));
                 } else {
-                    this._setItemFocus(e, jQuery("#allMyAppsButton"));
+                    this._setItemFocus(oEvent, jQuery("#allMyAppsButton"));
                 }
                 break;
             default:
@@ -234,16 +234,16 @@ sap.ui.define([
         jqItemTo.focus();
     };
 
-    KeyboardNavigation.prototype.setFocusToLastFocusedMiniTile = function (e) {
+    KeyboardNavigation.prototype.setFocusToLastFocusedMiniTile = function (oEvent) {
         const jqLastVisitedMiniTile = jQuery(".sapUshellNavMiniTile[tabindex='0']");
 
         // if we found last-visited mini tils
         if (jqLastVisitedMiniTile && jqLastVisitedMiniTile[0]) {
             // set focus to it
-            this._setItemFocus(e, jQuery(jqLastVisitedMiniTile));
+            this._setItemFocus(oEvent, jQuery(jqLastVisitedMiniTile));
         } else {
             // set focus to first mini-tile available
-            this._setItemFocus(e, jQuery(jQuery(".sapUshellNavMiniTile")[0]));
+            this._setItemFocus(oEvent, jQuery(jQuery(".sapUshellNavMiniTile")[0]));
         }
     };
 
@@ -308,14 +308,14 @@ sap.ui.define([
             // hierarchy items list
             this.oItemsList.addEventDelegate({
                 // on tab next (Tab)
-                onsaptabnext: function (e) {
+                onsaptabnext: function (oEvent) {
                     if (jQuery(".sapUshellNavMiniTile").length) {
                         // focus last visited mini tile
-                        this.keyboardNavigation.setFocusToLastFocusedMiniTile(e);
+                        this.keyboardNavigation.setFocusToLastFocusedMiniTile(oEvent);
                     } else {
                         const oAllMyAppsBtn = Element.getElementById("allMyAppsButton");
 
-                        this.keyboardNavigation._setItemFocus(e, jQuery((oAllMyAppsBtn.getDomRef())));
+                        this.keyboardNavigation._setItemFocus(oEvent, jQuery((oAllMyAppsBtn.getDomRef())));
                     }
                 }.bind(this)
             });
@@ -440,7 +440,7 @@ sap.ui.define([
         if (Device.system.desktop) {
             oItem.addEventDelegate({
                 // on tab previous (Shift Tab)
-                onsapspace: function (e) {
+                onsapspace: function (oEvent) {
                     this.firePress();
                 }.bind(oItem)
             });