@sapui5/sap.ushell 1.138.1 → 1.139.1

package/src/main/js/sap/ushell/services/Navigation/compatibility.js

@@ -4,7 +4,7 @@
  * compatible with the CrossApplicationNavigation service.
  * This shall only be used for the AppRuntime to enable 1.x inner shell running in 2.x host.
  *
- * @version 1.138.1
+ * @version 1.139.1
  */
 
 sap.ui.define([
@@ -14,14 +14,14 @@ sap.ui.define([
     "sap/ushell/TechnicalParameters",
     "sap/ushell/utils",
     "sap/ushell/utils/type"
-], function (
+], (
     isPlainObject,
     Container,
     navigationUtils,
     TechnicalParameters,
     ushellUtils,
     typeUtils
-) {
+) => {
     "use strict";
 
     const compatibility = {};
@@ -180,7 +180,6 @@ sap.ui.define([
             });
             const aLinks = await ushellUtils.promisify(oDeferred);
             return [aLinks];
-
         }));
     };
 
@@ -195,7 +194,7 @@ sap.ui.define([
      * @param {string[]} aIntents The intents to check.
      * @param {sap.ui.core.Component} [oComponent] The root component of the application.
      *
-     * @returns {Promise<Object<string, { supported: boolean }>>} A map of intents to their supported status.
+     * @returns {Promise<object<string, { supported: boolean }>>} A map of intents to their supported status.
      *
      * @since 1.124.0
      * @private
@@ -225,6 +224,5 @@ sap.ui.define([
         }, {});
     };
 
-
     return compatibility;
 });

package/src/main/js/sap/ushell/services/Navigation/utils.js

@@ -2,20 +2,19 @@
 /**
  * @fileOverview Navigation utility functions
  *
- * @version 1.138.1
+ * @version 1.139.1
  */
 
-
 sap.ui.define([
     "sap/base/util/isPlainObject",
     "sap/base/util/ObjectPath",
     "sap/base/Log",
     "sap/ushell/Container",
     "sap/ushell/utils/UrlParsing"
-], function (isPlainObject, ObjectPath, Log, Container, UrlParsing) {
+], (isPlainObject, ObjectPath, Log, Container, UrlParsing) => {
     "use strict";
 
-    var navigationUtils = {};
+    const navigationUtils = {};
 
     /**
      * Returns the options (i.e., parameter name and elements other than
@@ -59,10 +58,10 @@ sap.ui.define([
      */
     navigationUtils.extractGetLinksParameterOptions = function (oGetLinksParams) {
         return navigationUtils._parseGetLinksParameters(oGetLinksParams)
-            .filter(function (oParsedParam) {
+            .filter((oParsedParam) => {
                 return Object.keys(oParsedParam.options).length > 0;
             })
-            .map(function (oParsedParamWithOptions) {
+            .map((oParsedParamWithOptions) => {
                 return {
                     name: oParsedParamWithOptions.name,
                     options: oParsedParamWithOptions.options
@@ -107,7 +106,7 @@ sap.ui.define([
      */
     navigationUtils.extractGetLinksParameterDefinition = function (oGetLinksParams) {
         return navigationUtils._parseGetLinksParameters(oGetLinksParams)
-            .reduce(function (oResultDefinition, oParsedParam) {
+            .reduce((oResultDefinition, oParsedParam) => {
                 oResultDefinition[oParsedParam.name] = oParsedParam.value;
                 return oResultDefinition;
             }, {} /* oResultDefinition */);
@@ -162,11 +161,11 @@ sap.ui.define([
             return [];
         }
 
-        var oParamsCopy = JSON.parse(JSON.stringify(oGetLinksParams));
+        const oParamsCopy = JSON.parse(JSON.stringify(oGetLinksParams));
 
-        return Object.keys(oParamsCopy).map(function (sParamName) {
-            var vParamValue = oParamsCopy[sParamName];
-            var oParamOptions = {};
+        return Object.keys(oParamsCopy).map((sParamName) => {
+            let vParamValue = oParamsCopy[sParamName];
+            let oParamOptions = {};
 
             if (Object.prototype.toString.apply(vParamValue) === "[object Object]") {
                 vParamValue = vParamValue.value; // take the value...
@@ -195,7 +194,7 @@ sap.ui.define([
      * @since 1.120.0
      * @private
      */
-     navigationUtils._safeParseToObject = function (sObject) {
+    navigationUtils._safeParseToObject = function (sObject) {
         try {
             return JSON.parse(sObject);
         } catch (e) {
@@ -222,10 +221,10 @@ sap.ui.define([
      * @since 1.120.0
      * @private
      */
-     navigationUtils._createAppStateFromData = function (oData) {
+    navigationUtils._createAppStateFromData = function (oData) {
         return Container.getServiceAsync("AppState")
-            .then(function (AppStateService) {
-                var oAppState = AppStateService.createEmptyAppState(null /* use default bTransient settings */);
+            .then((AppStateService) => {
+                const oAppState = AppStateService.createEmptyAppState(null /* use default bTransient settings */);
                 oAppState.setData(oData);
                 oAppState.save();
 
@@ -268,16 +267,16 @@ sap.ui.define([
      * @private
      */
     navigationUtils._extractParameter = function (vIntent, sParameterName) {
-        var sIntentWithoutParameter;
-        var aParameterValue = null;
+        let sIntentWithoutParameter;
+        let aParameterValue = null;
 
         if (typeof vIntent === "string") {
             // Avoid using URLParsing unnecessarily.
-            if (vIntent.indexOf(sParameterName + "=") === -1) {
+            if (vIntent.indexOf(`${sParameterName}=`) === -1) {
                 return { intent: vIntent, data: null };
             }
 
-            var oParsedIntent = UrlParsing.parseShellHash(vIntent);
+            const oParsedIntent = UrlParsing.parseShellHash(vIntent);
             if (!oParsedIntent) {
                 return { intent: vIntent, data: null };
             }
@@ -293,9 +292,9 @@ sap.ui.define([
         }
 
         if (isPlainObject(vIntent)) {
-            var sShellHash = ObjectPath.get("target.shellHash", vIntent);
+            const sShellHash = ObjectPath.get("target.shellHash", vIntent);
             if (typeof sShellHash === "string") {
-                var oResult = navigationUtils._extractParameter(sShellHash, sParameterName);
+                const oResult = navigationUtils._extractParameter(sShellHash, sParameterName);
 
                 // modify the source object
                 vIntent.target.shellHash = oResult.intent;
@@ -306,7 +305,7 @@ sap.ui.define([
                 };
             }
 
-            var oParameters = vIntent.params;
+            const oParameters = vIntent.params;
             if (oParameters && oParameters[sParameterName]) {
                 const vParameterValue = oParameters[sParameterName];
                 aParameterValue = typeof vParameterValue === "string" ? [ vParameterValue ] : vParameterValue;
@@ -339,22 +338,22 @@ sap.ui.define([
      * @since 1.120.0
      * @private
      */
-     navigationUtils.addXAppStateFromParameter = function (vIntent, sSourceParameter) {
-        var oXAppStateDataExtraction = navigationUtils._extractParameter(vIntent, sSourceParameter);
-        var vIntentNoXAppStateData = oXAppStateDataExtraction.intent;
+    navigationUtils.addXAppStateFromParameter = function (vIntent, sSourceParameter) {
+        const oXAppStateDataExtraction = navigationUtils._extractParameter(vIntent, sSourceParameter);
+        const vIntentNoXAppStateData = oXAppStateDataExtraction.intent;
 
-        var sXAppStateData = oXAppStateDataExtraction.data && oXAppStateDataExtraction.data[0];
+        const sXAppStateData = oXAppStateDataExtraction.data && oXAppStateDataExtraction.data[0];
         if (!sXAppStateData) {
             return Promise.resolve();
         }
 
-        var oAppStateData = navigationUtils._safeParseToObject(sXAppStateData);
+        const oAppStateData = navigationUtils._safeParseToObject(sXAppStateData);
         if (!oAppStateData) {
             return Promise.resolve();
         }
 
         return navigationUtils._createAppStateFromData(oAppStateData)
-            .then(function (sAppStateKey) {
+            .then((sAppStateKey) => {
                 navigationUtils._injectParameter(vIntentNoXAppStateData, "sap-xapp-state", sAppStateKey);
             });
     };
@@ -377,14 +376,14 @@ sap.ui.define([
      */
     navigationUtils._injectParameter = function (vIntent, sParameterName, vParameterValue) {
         if (typeof vIntent === "string") {
-            var oParsedIntent = UrlParsing.parseShellHash(vIntent);
+            const oParsedIntent = UrlParsing.parseShellHash(vIntent);
             oParsedIntent.params[sParameterName] = vParameterValue;
 
             return UrlParsing.constructShellHash(oParsedIntent);
         }
 
         if (Object.prototype.toString.apply(vIntent) === "[object Object]") {
-            var sShellHash = ObjectPath.get("target.shellHash", vIntent);
+            const sShellHash = ObjectPath.get("target.shellHash", vIntent);
             if (typeof sShellHash === "string") {
                 vIntent.target.shellHash = navigationUtils._injectParameter(
                     sShellHash, sParameterName, vParameterValue
@@ -403,7 +402,6 @@ sap.ui.define([
         return vIntent;
     };
 
-
     /**
      *
      * @param {object} oParams
@@ -419,10 +417,10 @@ sap.ui.define([
      */
 
     navigationUtils.injectParameters = function (oParams) {
-        var oParametersToInject = oParams.inject;
-        var oInjectEmptyStringNames = (oParams.injectEmptyString || {});
-        var oType = oParams.type;
-        var vArgs = oParams.args;
+        const oParametersToInject = oParams.inject;
+        const oInjectEmptyStringNames = (oParams.injectEmptyString || {});
+        const oType = oParams.type;
+        const vArgs = oParams.args;
 
         function shouldInjectValue (sVal, bInjectWhenEmptyString) {
             return (sVal || (sVal === "" && bInjectWhenEmptyString));
@@ -443,17 +441,17 @@ sap.ui.define([
             }
 
             // Arguments like {semanticObject: ..., action: ..., params: { ... } }
-            var oNewParameterObject = Object.keys(oParametersToInject).reduce(function (oInjectedParameters, sParameterToInject) {
-                var sValueToInject = oParametersToInject[sParameterToInject];
-                var bInjectWhenEmptyString = (oInjectEmptyStringNames[sParameterToInject] === true);
+            const oNewParameterObject = Object.keys(oParametersToInject).reduce((oInjectedParameters, sParameterToInject) => {
+                const sValueToInject = oParametersToInject[sParameterToInject];
+                const bInjectWhenEmptyString = (oInjectEmptyStringNames[sParameterToInject] === true);
                 // when params is a string
                 if (shouldInjectValue(sValueToInject, bInjectWhenEmptyString) && typeof oInjectedParameters === "string") {
-                    var reUrlParameter = new RegExp("[&]" + sParameterToInject);
-                    var bHasNoParameterAlready = !reUrlParameter.test(oInjectedParameters);
+                    const reUrlParameter = new RegExp(`[&]${sParameterToInject}`);
+                    const bHasNoParameterAlready = !reUrlParameter.test(oInjectedParameters);
                     if (bHasNoParameterAlready) {
                         // When oInjectedParameters is an empty string, no separator needs to be added.
-                        var sSeparator = oInjectedParameters ? "&" : "";
-                        oInjectedParameters += sSeparator + sParameterToInject + "=" + sValueToInject;
+                        const sSeparator = oInjectedParameters ? "&" : "";
+                        oInjectedParameters += `${sSeparator + sParameterToInject}=${sValueToInject}`;
                     }
                 } else if (shouldInjectValue(sValueToInject, bInjectWhenEmptyString) && !oInjectedParameters.hasOwnProperty(sParameterToInject)) {
                     oInjectedParameters[sParameterToInject] = sValueToInject;
@@ -469,16 +467,16 @@ sap.ui.define([
         }
 
         // Arguments like #Hash-fragment?with=parameters
-        var sShellHash = vArgs;
+        let sShellHash = vArgs;
         if (sShellHash) {
-            Object.keys(oParametersToInject).forEach(function (sParameterToInject) {
-                var sValueToInject = oParametersToInject[sParameterToInject];
-                var bInjectWhenEmptyString = (oInjectEmptyStringNames[sParameterToInject] === true);
-                var reUrlParameter = new RegExp("[?&]" + sParameterToInject);
-                var bHasNoParameterAlready = !reUrlParameter.test(sShellHash);
+            Object.keys(oParametersToInject).forEach((sParameterToInject) => {
+                const sValueToInject = oParametersToInject[sParameterToInject];
+                const bInjectWhenEmptyString = (oInjectEmptyStringNames[sParameterToInject] === true);
+                const reUrlParameter = new RegExp(`[?&]${sParameterToInject}`);
+                const bHasNoParameterAlready = !reUrlParameter.test(sShellHash);
                 if (shouldInjectValue(sValueToInject, bInjectWhenEmptyString) && bHasNoParameterAlready) {
-                    var sSeparator = sShellHash.indexOf("?") > -1 ? "&" : "?";
-                    sShellHash += sSeparator + sParameterToInject + "=" + sValueToInject;
+                    const sSeparator = sShellHash.indexOf("?") > -1 ? "&" : "?";
+                    sShellHash += `${sSeparator + sParameterToInject}=${sValueToInject}`;
                 }
             });
         }
@@ -501,9 +499,9 @@ sap.ui.define([
      * @since 1.120.0
      * @private
      */
-     navigationUtils.injectStickyParameters = function (oParams) {
+    navigationUtils.injectStickyParameters = function (oParams) {
         return Container.getServiceAsync("AppLifeCycle")
-            .then(function (oAppLifeCycleService) {
+            .then((oAppLifeCycleService) => {
                 return navigationUtils._injectStickyParameters(oParams, oAppLifeCycleService);
             });
     };
@@ -528,31 +526,31 @@ sap.ui.define([
         if (!oAppLifeCycleService || Object.keys(oAppLifeCycleService).length <= 0) {
             return oParams.args;
         }
-        var oCurrentApplication = oAppLifeCycleService.getCurrentApplication();
+        const oCurrentApplication = oAppLifeCycleService.getCurrentApplication();
         if (!oCurrentApplication || Object.keys(oCurrentApplication).length <= 0) {
             return oParams.args;
         }
-        var oAppIntegrationAppLifeCycle = oParams.appLifeCycle;
-        var oTechnicalParameters = oParams.technicalParameters;
-        var oStickyParametersToInject = oTechnicalParameters.getParameters({
+        const oAppIntegrationAppLifeCycle = oParams.appLifeCycle;
+        const oTechnicalParameters = oParams.technicalParameters;
+        const oStickyParametersToInject = oTechnicalParameters.getParameters({
             sticky: true
         })
-            .reduce(function (oStickyParameters, oNextParameter) {
-                var sNextParameterName = oNextParameter.name;
-                var oComponentInstance = oCurrentApplication.componentInstance;
-                var sApplicationType = oCurrentApplication.applicationType;
-                var oApplicationContainer;
+            .reduce((oStickyParameters, oNextParameter) => {
+                const sNextParameterName = oNextParameter.name;
+                const oComponentInstance = oCurrentApplication.componentInstance;
+                const sApplicationType = oCurrentApplication.applicationType;
+                let oApplicationContainer;
                 if (sApplicationType === "UI5") {
                     oApplicationContainer = {};
                 } else {
                     oApplicationContainer = oAppIntegrationAppLifeCycle.getCurrentApplication().container;
                 }
-                var sStickyParameterValue = oTechnicalParameters.getParameterValueSync(sNextParameterName, oComponentInstance, oApplicationContainer, sApplicationType);
-                var sStickyParameterName = oNextParameter.stickyName || sNextParameterName;
+                const sStickyParameterValue = oTechnicalParameters.getParameterValueSync(sNextParameterName, oComponentInstance, oApplicationContainer, sApplicationType);
+                const sStickyParameterName = oNextParameter.stickyName || sNextParameterName;
                 oStickyParameters[sStickyParameterName] = sStickyParameterValue;
                 return oStickyParameters;
             }, {});
-        var oArgs = {
+        const oArgs = {
             type: oParams.type,
             inject: oStickyParametersToInject,
             args: oParams.args

package/src/main/js/sap/ushell/services/Navigation.js

@@ -5,7 +5,7 @@
  * This file exposes an API to perform (invoke) Navigation for applications.
  * It exposes interfaces to perform a hash change and trigger a navigation.
  *
- * @version 1.138.1
+ * @version 1.139.1
  */
 sap.ui.define([
     "sap/base/Log",
@@ -16,16 +16,14 @@ sap.ui.define([
     "sap/ui/base/Object",
     "sap/ui/thirdparty/hasher",
     "sap/ushell/appIntegration/AppLifeCycle",
-    "sap/ushell/ApplicationType",
     "sap/ushell/Container",
     "sap/ushell/services/Navigation/utils",
     "sap/ushell/services/AppConfiguration",
     "sap/ushell/TechnicalParameters",
-    "sap/ushell/UI5ComponentType",
     "sap/ushell/utils",
     "sap/ushell/utils/type",
     "sap/ushell/utils/UrlParsing"
-], function (
+], (
     Log,
     deepClone,
     deepExtend,
@@ -34,16 +32,14 @@ sap.ui.define([
     BaseObject,
     hasher,
     AppLifeCycleAI,
-    ApplicationType,
     Container,
     navigationUtils,
     AppConfiguration,
     TechnicalParameters,
-    UI5ComponentType,
     ushellUtils,
     typeUtils,
     UrlParsing
-) {
+) => {
     "use strict";
 
     /**
@@ -414,7 +410,7 @@ sap.ui.define([
 
             if (!/[?&]sap-system=/.test(sShellHash)) {
                 const sSeparator = (sShellHash.indexOf("?") > -1) ? "&" : "?";
-                sShellHash += sSeparator + "sap-ushell-enc-test=" + encodeURIComponent("A B%20C");
+                sShellHash += `${sSeparator}sap-ushell-enc-test=${encodeURIComponent("A B%20C")}`;
             }
             return sShellHash;
         };
@@ -440,7 +436,7 @@ sap.ui.define([
 
                 return {
                     intent: sIntent,
-                    innerAppRoute: aParts.length > 0 ? "&/" + aParts.join("&/") : ""
+                    innerAppRoute: aParts.length > 0 ? `&/${aParts.join("&/")}` : ""
                 };
             }
 
@@ -466,7 +462,7 @@ sap.ui.define([
                     const bIsStringWithoutSeparator = typeof vAppSpecificRoute === "string" && vAppSpecificRoute.indexOf("&/") !== 0 && vAppSpecificRoute.length > 0;
 
                     return {
-                        innerAppRoute: bIsStringWithoutSeparator ? "&/" + vAppSpecificRoute : vAppSpecificRoute,
+                        innerAppRoute: bIsStringWithoutSeparator ? `&/${vAppSpecificRoute}` : vAppSpecificRoute,
                         intent: vIntent
                     };
                 }
@@ -552,7 +548,7 @@ sap.ui.define([
          */
         this.getHref = async function (oTarget = {}, oComponent) {
             try {
-                /**@type {sap.ushell.services.Navigation.Target} */
+                /** @type {sap.ushell.services.Navigation.Target} */
                 let oArgsClone = deepClone(oTarget); // clone to keep input unchanged and to avoid side effects
                 if (!oArgsClone.target) {
                     Log.debug("Navigation.getHref: No target provided using current hash as fallback", "sap.ushell.services.Navigation");
@@ -621,7 +617,7 @@ sap.ui.define([
          * Navigates back in history the number of given steps if this is supported by the underlying platform.
          * If no argument is provided it will navigate back 1 step.
          *
-         * @param {int} iSteps positive integer representing the steps to go back in the history
+         * @param {int} [iSteps=1] positive integer representing the steps to go back in the history
          *
          * @since 1.120.0
          * @public
@@ -700,7 +696,7 @@ sap.ui.define([
          */
         this.navigate = async function (oTarget, oComponent) {
             try {
-                /**@type {sap.ushell.services.Navigation.Target} */
+                /** @type {sap.ushell.services.Navigation.Target} */
                 let oArgsClone = deepClone(oTarget); // clone to keep input unchanged and to avoid side effects
                 const bWriteHistory = oTarget.writeHistory;
 
@@ -714,7 +710,7 @@ sap.ui.define([
                 const oIntent = await (oCurrentApplication && oCurrentApplication.getIntent());
 
                 // clone again because _extractInnerAppRoute might already changed the original structure
-                /**@type {sap.ushell.services.Navigation.Target} */
+                /** @type {sap.ushell.services.Navigation.Target} */
                 const oNavTarget = deepClone(oTarget);
                 this._checkIfAppNeedsToBeReloaded(oNavTarget, oCurrentApplication, oIntent, ShellNavigationInternal.hashChanger);
                 await navigationUtils.addXAppStateFromParameter(intent, "sap-xapp-state-data" /* parameter containing data */);

package/src/main/js/sap/ushell/services/NavigationDataProvider.js

@@ -8,7 +8,7 @@
  *
  * Configured with the ClientSideTargetResolutionAdapter.
  *
- * @version 1.138.1
+ * @version 1.139.1
  */
 sap.ui.define([
     "sap/ushell/resources",
@@ -35,7 +35,7 @@ sap.ui.define([
      * @experimental Since 1.68.0
      * @private
      */
-    function NavigationDataProvider (/*adapter, serviceConfiguration*/) {
+    function NavigationDataProvider (/* adapter, serviceConfiguration */) {
         this.S_COMPONENT_NAME = "sap.ushell.services.NavigationDataProvider";
         this._init.apply(this, arguments);
     }

package/src/main/js/sap/ushell/services/Notifications.js

@@ -8,10 +8,10 @@ sap.ui.define([
     "sap/ui/thirdparty/jquery",
     "sap/ushell/Container",
     "sap/ushell/services/NotificationsV2" // preload NotificationsV2 early
-], function (
+], (
     jQuery,
     Container
-) {
+) => {
     "use strict";
 
     /**
@@ -58,23 +58,22 @@ sap.ui.define([
      * @deprecated since 1.119. Please use {@link sap.ushell.services.NotificationsV2} instead.
      */
     function Notifications (oContainerInterface, sParameters, oServiceConfiguration) {
-
         // Get the reference to the NotificationsV2 service promise
         this._getNotificationsV2 = function () {
             if (!this.oNotificationsV2Promise) {
                 this.oNotificationsV2Promise = Container.getServiceAsync("NotificationsV2");
-                this.oNotificationsV2Promise.then(function (oService) {
+                this.oNotificationsV2Promise.then((oService) => {
                     this._oNotificationsV2Service = oService; // Save ref to the service for static calls, beware race conditions
-                }.bind(this));
+                });
             }
             return this.oNotificationsV2Promise;
         };
 
         // Wrap Promise into jQuery.Deferred
         this._proxyV2 = function (sMethod, aArguments) {
-            var oDeferred = new jQuery.Deferred();
+            const oDeferred = new jQuery.Deferred();
             this._getNotificationsV2()
-                .then(function (oService) {
+                .then((oService) => {
                     return oService[sMethod].apply(oService, aArguments); // Call NotificationsV2 service method instead
                 })
                 .then(oDeferred.resolve)
@@ -83,8 +82,8 @@ sap.ui.define([
         };
 
         this._proxyV2sync = function (sMethod, defaultValue, aArguments) {
-            var oService = this._oNotificationsV2Service;
-            //return oService ? oService[sMethod].apply(oService, aArguments) : defaultValue;
+            const oService = this._oNotificationsV2Service;
+            // return oService ? oService[sMethod].apply(oService, aArguments) : defaultValue;
             return oService[sMethod].apply(oService, aArguments);
         };
 
@@ -102,8 +101,8 @@ sap.ui.define([
          * @public
          */
         this.isEnabled = function () {
-            var oServiceConfig = oServiceConfiguration && oServiceConfiguration.config;
-            return !!(oServiceConfig && oServiceConfig.enabled && oServiceConfig.serviceUrl);
+            const oServiceConfig = oServiceConfiguration?.config;
+            return !!(oServiceConfig?.serviceUrl && oServiceConfig?.enabled);
         };
 
         /**
@@ -203,7 +202,7 @@ sap.ui.define([
          *
          * @param {string} sNotificationGroupId The ID of the notification header/group whose action is being executed
          * @param {string} sActionId The ID of the action that is being executed
-         * @returns {Promise<undefined>} Promise object that on success resolves to undefined or it is rejected with failed notifications
+         * @returns {Promise} Promise object that on success resolves to undefined or it is rejected with failed notifications
          *
          * @since 1.32
          * @public
@@ -329,6 +328,7 @@ sap.ui.define([
         };
 
         /**
+         * @param {object} oEntry the notification settings entry.
          * @returns {jQuery.Promise} Resolves once the settings were saved.
          *
          * @since 1.41
@@ -349,6 +349,7 @@ sap.ui.define([
         };
 
         /**
+         * @param {object} oFlags user settings flags.
          * @since 1.41
          * @private
          */
@@ -383,6 +384,8 @@ sap.ui.define([
         /**
          * adds an item to the array of dismissed notifications
          *
+         * @param {string} sId notification item id.
+         *
          * @since 1.43
          * @private
          */
@@ -492,11 +495,12 @@ sap.ui.define([
          * Returns the appropriate URI that should be used in an OData request according to the nature of the request and according to filtering that might be required.
          * The object aRequestURIs is filled with the basic and/or byIntents-filter URI, and is used for maintaining the URIs throughout the session.
          *
-         * @param {object} The value form the enumeration oOperationEnum, representing the relevant request
+         * @param {object} oRequiredURI The value form the enumeration oOperationEnum, representing the relevant request
+         * @param {object} oArgs Request options like skip and top.
          * @returns {string} The URI that should be user in the OData.read call
          */
         this._getRequestURI = function (oRequiredURI, oArgs) {
-            return this._proxyV2sync("_getDataServiceVersion", "", arguments);
+            return this._proxyV2sync("_getRequestURI", "", arguments);
         };
 
         this._readSettingsFromServer = function () {
@@ -640,7 +644,8 @@ sap.ui.define([
 
         /**
          * Returning the time, in milliseconds, left until the end of FioriClient waiting period.
-         * The required period is represented by tFioriClientInitializationPeriod, and we reduce the time passed from service initialization until now
+         * The required period is represented by tFioriClientInitializationPeriod, and we reduce the time passed from service initialization until now.
+         * @returns {int} Remaining delay.
          */
         this._getFioriClientRemainingDelay = function () {
             return this._proxyV2sync("_getFioriClientRemainingDelay", arguments);
@@ -665,6 +670,7 @@ sap.ui.define([
 
         /**
          * Helper function for Packaged App mode
+         * @returns {boolean} Returns true if the app is running in packaged mode
          */
         this._isPackagedMode = function () {
             return this._proxyV2sync("_isPackagedMode");
@@ -704,7 +710,9 @@ sap.ui.define([
 
         /**
          * Creates and returns the intents filter string of an OData request
+         * @param {string} oRequestURI URI of the OData request
          * For example: &NavigationIntent%20eq%20%27Action-toappstatesample%27%20or%20NavigationIntent%20eq%20%27Action-toappnavsample%27
+         * @returns {string} returns the intents filter string
          */
         this._getConsumedIntents = function (oRequestURI) {
             return this._proxyV2sync("_getConsumedIntents", "", arguments);
@@ -731,6 +739,10 @@ sap.ui.define([
          *
          * This function doesn't return anything, instead it resolves or rejects the given oOriginalDeferred
          *
+         * @param {jQuery.Deferred} oOriginalDeferred The original Deferred to react on.
+         * @param {function} fnFailedFunction The function that failed (e.g., markRead).
+         * @param {Array<any>} aArgsArray The arguments array of the function that failed.
+         *
          * @private
          */
         this._invalidCsrfTokenRecovery = function (oOriginalDeferred, fnFailedFunction, aArgsArray) {
@@ -760,6 +772,8 @@ sap.ui.define([
         /**
          * Write/save user settings flags to the personalization.
          * The saved data consists of the user's show high-priority notifications alerts flag value.
+         * @param {object} oFlags The flags to be saved
+         * @returns {Promise} Promise object that is resolved when the data is saved
          */
         this._writeUserSettingsFlagsToPersonalization = function (oFlags) {
             return this._proxyV2("_writeUserSettingsFlagsToPersonalization", arguments);