@sapui5/sap.ushell 1.138.1 → 1.139.1

package/src/main/js/sap/ushell/components/factsheet/tools/ODataUrlTemplating.js

@@ -4,7 +4,11 @@
  * @fileOverview This file contains an annotation parser for factsheets.
  * @deprecated since 1.111
  */
-sap.ui.define(function () {
+sap.ui.define([
+    "sap/ui/thirdparty/jquery"
+], (
+    jQuery
+) => {
     "use strict";
 
     // Exception Object
@@ -18,11 +22,11 @@ sap.ui.define(function () {
         };
     }
 
-    var ODataUrlTemplating = {
+    const ODataUrlTemplating = {
         ParameterException: ParameterException,
         resolve: function (template, data) {
-            var sEntityUrl, value, parameter, i,
-                businessParameter = template.match(/{\s*[\w.]+\s*}/g);
+            let sEntityUrl; let value; let parameter; let i;
+            const businessParameter = template.match(/{\s*[\w.]+\s*}/g);
             sEntityUrl = template;
 
             for (i = businessParameter.length - 1; i >= 0; i -= 1) {
@@ -40,7 +44,7 @@ sap.ui.define(function () {
             // Is there a parameter left
             parameter = sEntityUrl.match(/{\s*[\w.]+\s*}/g);
             if (parameter) {
-                jQuery.sap.log.error(" " + sEntityUrl);
+                jQuery.sap.log.error(` ${sEntityUrl}`);
                 // TODO: Raise exception
                 throw new this.ParameterException(parameter, template, sEntityUrl);
             }

package/src/main/js/sap/ushell/components/factsheet/views/ThingViewer.controller.js

@@ -5,7 +5,7 @@
  */
 sap.ui.define([
     "sap/ui/model/odata/ODataModel"
-], function (ODataModel) {
+], (ODataModel) => {
     "use strict";
 
     sap.ui.controller("sap.ushell.components.factsheet.views.ThingViewer", {

package/src/main/js/sap/ushell/components/factsheet/views/ThingViewer.view.js

@@ -8,7 +8,7 @@ sap.ui.define([
     "sap/ushell/components/factsheet/factory/ThingInspector",
     "sap/ui/model/odata/ODataUtils",
     "sap/ui/core/Component"
-], function (ODataUrlTemplating, ThingInspector, ODataUtils, Component) {
+], (ODataUrlTemplating, ThingInspector, ODataUtils, Component) => {
     "use strict";
 
     sap.ui.jsview("sap.ushell.components.factsheet.views.ThingViewer", {
@@ -16,9 +16,12 @@ sap.ui.define([
             return "sap.ushell.components.factsheet.views.ThingViewer";
         },
 
-        createContent: function (/*oController*/) {
-            var sEntityUrl, sAnnotationUrl, sEntityUrlTemplate, oTI, oViewData, sServiceUrl;
-            oViewData = this.getViewData();
+        createContent: function (/* oController */) {
+            let sEntityUrl;
+            let sAnnotationUrl;
+            let sEntityUrlTemplate;
+            let sServiceUrl;
+            const oViewData = this.getViewData();
 
             // Sample Hash UI2_DEMO_PRODUCT-DisplayFactSheet~6bpO?ProductID=HT-1000
             sEntityUrl = oViewData.entity || oViewData.service;// Old Parameter Name was Service
@@ -57,7 +60,7 @@ sap.ui.define([
             // With the substr the service url "/sap/opu/odata/sap/CB_FUNDS_SRV" is saved in sServiceUrl
             sServiceUrl = sEntityUrl.substr(0, sEntityUrl.lastIndexOf("/"));
             function amendServiceUrlWithSapSystemIfRequired (oComponent, sServiceUrl) {
-                var sSystem;
+                let sSystem;
                 // test for presence of the interface
                 if (sap.ui.model.odata && ODataUtils && typeof ODataUtils.setOrigin === "function") {
                     // test for presence of a sap-system parameter
@@ -76,7 +79,7 @@ sap.ui.define([
             // Now the given entity is written back to the url. In the example above the substr returns "/Fundss(FMArea='PS05',Fund='GENERAL')"
             sServiceUrl = sServiceUrl + sEntityUrl.substr(sEntityUrl.lastIndexOf("/"));
 
-            oTI = ThingInspector(sServiceUrl, sAnnotationUrl);
+            const oTI = ThingInspector(sServiceUrl, sAnnotationUrl);
 
             // Add min-height
             oTI.addStyleClass("ThingInspector");

package/src/main/js/sap/ushell/components/homeApp/error/Component.js

@@ -3,7 +3,7 @@
 sap.ui.define([
     "sap/ui/core/UIComponent",
     "sap/ushell/resources"
-], function (UIComponent, resources) {
+], (UIComponent, resources) => {
     "use strict";
 
     return UIComponent.extend("sap.ushell.components.homeApp.error.Component", {

package/src/main/js/sap/ushell/components/homeApp/error/HomeAppError.controller.js

@@ -7,17 +7,17 @@ sap.ui.define([
     "sap/ushell/resources",
     "sap/ushell/Config",
     "sap/ushell/utils"
-], function (
+], (
     Controller,
     JSONModel,
     MessageToast,
     resources,
     Config,
     utils
-) {
+) => {
     "use strict";
 
-    var messages = Config.last("/core/homeApp/component").messages || [];
+    const messages = Config.last("/core/homeApp/component").messages || [];
 
     return Controller.extend("sap.ushell.components.homeApp.error.HomeAppError", {
         onInit: function () {
@@ -30,7 +30,7 @@ sap.ui.define([
         },
 
         onCopyErrorDetailsPress: function () {
-            var bResult = utils.copyToClipboard(this._oModel.getProperty("/details"));
+            const bResult = utils.copyToClipboard(this._oModel.getProperty("/details"));
             if (bResult) {
                 MessageToast.show(resources.i18n.getText("HomeApp.CannotLoadApp.CopySuccess"), {
                     closeOnBrowserNavigation: false

package/src/main/js/sap/ushell/components/homepage/ActionMode.js

@@ -20,7 +20,7 @@
  *  - Deactivation handler
  *  - Rendering tile action menu
  *
- * @version 1.138.1
+ * @version 1.139.1
  *
  * @deprecated since 1.112
  */
@@ -36,7 +36,7 @@ sap.ui.define([
     "sap/ushell/resources",
     "sap/ushell/utils/WindowUtils",
     "sap/ushell/EventHub"
-], function (
+], (
     Log,
     Button,
     mobileLibrary,
@@ -48,11 +48,11 @@ sap.ui.define([
     resources,
     WindowUtils,
     EventHub
-) {
+) => {
     "use strict";
 
     // shortcut for sap.m.PlacementType
-    var PlacementType = mobileLibrary.PlacementType;
+    const PlacementType = mobileLibrary.PlacementType;
 
     /* global hasher */
 
@@ -68,13 +68,13 @@ sap.ui.define([
      *  1. A new button in the user menu
      *  2. A floating button
      */
-    var ActionMode = function () {
+    function ActionMode () {
         this.oEventBus = EventBus.getInstance();
 
         this.init = function (oModel) {
             this.oModel = oModel;
         };
-    };
+    }
 
     /**
      * Activation handler of Tile actions mode ("Edit Mode").
@@ -89,11 +89,11 @@ sap.ui.define([
     ActionMode.prototype._activate = function () {
         this.oModel.setProperty("/tileActionModeActive", true);
         this.aOrigHiddenGroupsIds = this.getHomepageManager().getCurrentHiddenGroupIds(this.oModel);
-        var oDashboardGroups = Element.getElementById("dashboardGroups");
+        const oDashboardGroups = Element.getElementById("dashboardGroups");
         oDashboardGroups.addLinksToUnselectedGroups();
 
         // Change action mode button display in the user actions menu
-        var oTileActionsButton = Element.getElementById("ActionModeBtn");
+        const oTileActionsButton = Element.getElementById("ActionModeBtn");
         if (oTileActionsButton) {
             oTileActionsButton.setText(resources.i18n.getText("exitEditMode"));
             // only available if the action mode button is in the shell header
@@ -120,13 +120,13 @@ sap.ui.define([
         this.oModel.setProperty("/tileActionModeActive", false);
         this.oEventBus.publish("launchpad", "actionModeInactive", this.aOrigHiddenGroupsIds);
 
-        var tileActionsMenu = Element.getElementById("TileActions");
+        const tileActionsMenu = Element.getElementById("TileActions");
         if (tileActionsMenu !== undefined) {
             tileActionsMenu.destroy();
         }
 
         // Change action mode button display in the user actions menu
-        var oTileActionsButton = Element.getElementById("ActionModeBtn");
+        const oTileActionsButton = Element.getElementById("ActionModeBtn");
         if (oTileActionsButton) {
             oTileActionsButton.setText(resources.i18n.getText("activateEditMode"));
             // only available if the action mode button is in the shell header
@@ -139,11 +139,11 @@ sap.ui.define([
     ActionMode.prototype.toggleActionMode = function (oModel, sSource, dashboardGroups) {
         dashboardGroups = dashboardGroups || [];
 
-        var visibleGroups = dashboardGroups.filter(function (group) {
+        const visibleGroups = dashboardGroups.filter((group) => {
             return group.getVisible();
         });
 
-        var oData = {
+        const oData = {
             group: visibleGroups[oModel.getProperty("/topGroupInViewPortIndex")]
         };
 
@@ -151,9 +151,9 @@ sap.ui.define([
             this._deactivate();
 
             // if the TileContainer header was focused, we need to restore focus to the closest tile
-            var oLastFocusedHeaderElement = document.querySelector(".sapUshellTileContainerHeader[tabindex='0']");
+            const oLastFocusedHeaderElement = document.querySelector(".sapUshellTileContainerHeader[tabindex='0']");
             if (oLastFocusedHeaderElement) {
-                var oTileContainerElement = oLastFocusedHeaderElement.closest("sapUshellTileContainer");
+                const oTileContainerElement = oLastFocusedHeaderElement.closest("sapUshellTileContainer");
                 if (oTileContainerElement) {
                     oData.restoreLastFocusedTileContainerById = oTileContainerElement.getAttribute("id");
                 }
@@ -164,9 +164,9 @@ sap.ui.define([
 
         // the "scrollToGroup" event gets triggered by the onAfterRendering
         // this handler should go afterwards
-        setTimeout(function () {
+        setTimeout(() => {
             this.oEventBus.publish("launchpad", "scrollToGroup", oData);
-        }.bind(this), 0);
+        }, 0);
     };
 
     /**
@@ -177,9 +177,9 @@ sap.ui.define([
      * @param {object} oGroup Group that should be placed in edit mode
      */
     ActionMode.prototype.activateGroupEditMode = function (oGroup) {
-        var aGroupContentElements = oGroup.getDomRef().getElementsByClassName("sapUshellTileContainerContent");
+        const aGroupContentElements = oGroup.getDomRef().getElementsByClassName("sapUshellTileContainerContent");
 
-        for (var i = 0; i < aGroupContentElements.length; i++) {
+        for (let i = 0; i < aGroupContentElements.length; i++) {
             aGroupContentElements[i].classList.add("sapUshellTileContainerEditMode");
         }
     };
@@ -192,9 +192,9 @@ sap.ui.define([
     };
 
     ActionMode.prototype._filterActions = function (aActions, oTileControl) {
-        var oTileModel = oTileControl.getModel();
-        var sGroupBindingPath = oTileControl.getParent().getBindingContext().getPath();
-        if (oTileModel.getProperty(sGroupBindingPath + "/isGroupLocked")) {
+        const oTileModel = oTileControl.getModel();
+        const sGroupBindingPath = oTileControl.getParent().getBindingContext().getPath();
+        if (oTileModel.getProperty(`${sGroupBindingPath}/isGroupLocked`)) {
             // edit (personalization) actions should not be displayed in locked Groups,
             // but actions defined in FLPD should be kept (e.g. Dynamic & Static Tiles can have settings actions)
             [
@@ -203,15 +203,15 @@ sap.ui.define([
                 "ConvertToTile",
                 "ConvertToLink",
                 "moveTile_action"
-            ].forEach(function (sActionKey) {
-                aActions = aActions.filter(function (oAction) {
+            ].forEach((sActionKey) => {
+                aActions = aActions.filter((oAction) => {
                     return (oAction.id !== sActionKey);
                 });
             });
         }
         if (this.getHomepageManager().getPersonalizableGroups().length < 2) {
             // the "Move" action should not be displayed if there are less than 2 personalizable Groups
-            aActions = aActions.filter(function (oAction) {
+            aActions = aActions.filter((oAction) => {
                 return (oAction.id !== "moveTile_action");
             });
         }
@@ -232,26 +232,26 @@ sap.ui.define([
      * @private
      */
     ActionMode.prototype._openActionsMenu = function (oEvent) {
-        var oTileControl = oEvent.getSource();
-        var oTile = oTileControl.getBindingContext().getObject().object;
-        var aActions = this.getHomepageManager().getTileActions(oTile);
+        const oTileControl = oEvent.getSource();
+        const oTile = oTileControl.getBindingContext().getObject().object;
+        let aActions = this.getHomepageManager().getTileActions(oTile);
         aActions = this._filterActions(aActions, oTileControl);
 
-        var aTileActionLayerDivSelectedElements = document.getElementsByClassName("sapUshellTileActionLayerDivSelected");
-        for (var i = 0; i < aTileActionLayerDivSelectedElements.length; i++) {
+        const aTileActionLayerDivSelectedElements = document.getElementsByClassName("sapUshellTileActionLayerDivSelected");
+        for (let i = 0; i < aTileActionLayerDivSelectedElements.length; i++) {
             aTileActionLayerDivSelectedElements[i].classList.remove("sapUshellTileActionLayerDivSelected");
         }
 
-        var aCoverDivs = oTileControl.getDomRef().getElementsByClassName("sapUshellTileActionLayerDiv");
-        for (var j = 0; j < aCoverDivs.length; j++) {
+        const aCoverDivs = oTileControl.getDomRef().getElementsByClassName("sapUshellTileActionLayerDiv");
+        for (let j = 0; j < aCoverDivs.length; j++) {
             aCoverDivs[j].classList.add("sapUshellTileActionLayerDivSelected");
         }
 
-        var aActionButtons = [];
+        const aActionButtons = [];
 
-        aActions.forEach(function (oAction) {
+        aActions.forEach((oAction) => {
             if (!oAction.press && !oAction.targetURL) {
-                Log.warning("Invalid Tile action discarded: " + JSON.stringify(oAction));
+                Log.warning(`Invalid Tile action discarded: ${JSON.stringify(oAction)}`);
                 return;
             }
             aActionButtons.push(new Button({
@@ -259,7 +259,7 @@ sap.ui.define([
                 icon: oAction.icon,
                 press: this._handleActionPress.bind(this, oAction, oTileControl)
             }));
-        }.bind(this));
+        });
 
         if (aActionButtons.length === 0) {
             this._openNoActionsPopover(oEvent);
@@ -268,28 +268,28 @@ sap.ui.define([
 
         // for tiles, actions menu is opened by "more" icon; for links, there is an action button not controlled by the FLP.
         // for links, we first try to access the "more" button and open the action sheet by it.
-        var oActionSheetTarget = oTileControl.getActionSheetIcon ? oTileControl.getActionSheetIcon() : undefined;
+        let oActionSheetTarget = oTileControl.getActionSheetIcon ? oTileControl.getActionSheetIcon() : undefined;
         if (!oActionSheetTarget) {
-            var oMoreAction = Element.getElementById(oTileControl.getId() + "-action-more");
+            const oMoreAction = Element.getElementById(`${oTileControl.getId()}-action-more`);
             oActionSheetTarget = (oMoreAction || oTileControl);
         }
 
-        var oActionSheet = Element.getElementById("TileActions");
+        let oActionSheet = Element.getElementById("TileActions");
         if (!oActionSheet) {
-            sap.ui.require(["sap/m/ActionSheet"], function (ActionSheet) {
+            sap.ui.require(["sap/m/ActionSheet"], (ActionSheet) => {
                 oActionSheet = new ActionSheet("TileActions", {
                     placement: PlacementType.VerticalPreferedBottom,
                     afterClose: function () {
-                        var aSelectedElements = document.getElementsByClassName("sapUshellTileActionLayerDivSelected");
-                        for (var k = 0; k < aSelectedElements.length; k++) {
+                        const aSelectedElements = document.getElementsByClassName("sapUshellTileActionLayerDivSelected");
+                        for (let k = 0; k < aSelectedElements.length; k++) {
                             aSelectedElements[k].classList.remove("sapUshellTileActionLayerDivSelected");
                         }
-                        var oEventBus = EventBus.getInstance();
+                        const oEventBus = EventBus.getInstance();
                         oEventBus.publish("dashboard", "actionSheetClose", oTileControl);
                     }
                 });
                 this._openActionSheet(oActionSheet, aActionButtons, oActionSheetTarget);
-            }.bind(this));
+            });
         } else {
             this._openActionSheet(oActionSheet, aActionButtons, oActionSheetTarget);
         }
@@ -297,19 +297,22 @@ sap.ui.define([
 
     /**
      * Opens the Action Sheet on the given target with the provided buttons.
+     *
+     * @param {object} oActionSheet the action sheet control instance.
+     * @param {object[]} aButtons the buttons that should be in the action sheet.
+     * @param {object} oTarget the target control, the action sheet should open by.
      */
-    ActionMode.prototype._openActionSheet = function (oActionSheet, aButtons, oTarget) {
-        aButtons = aButtons || [];
+    ActionMode.prototype._openActionSheet = function (oActionSheet, aButtons = [], oTarget) {
         oActionSheet.destroyButtons();
-        aButtons.forEach(function (oButton) {
+        aButtons.forEach((oButton) => {
             oActionSheet.addButton(oButton);
         });
         oActionSheet.openBy(oTarget);
     };
 
     ActionMode.prototype._openNoActionsPopover = function (oEvent) {
-        var oTileControl = oEvent.getSource();
-        var oText = new Text({ text: resources.i18n.getText("tileHasNoActions") });
+        const oTileControl = oEvent.getSource();
+        const oText = new Text({ text: resources.i18n.getText("tileHasNoActions") });
         new Popover({
             placement: PlacementType.Bottom,
             showHeader: false,

package/src/main/js/sap/ushell/components/homepage/Component.js

@@ -14,7 +14,7 @@ sap.ui.define([
     "sap/ushell/components/SharedComponentUtils",
     "sap/ushell/Config",
     "sap/ushell/resources"
-], function (
+], (
     EventBus,
     View,
     UIComponent,
@@ -23,7 +23,7 @@ sap.ui.define([
     oSharedComponentUtils,
     Config,
     resources
-) {
+) => {
     "use strict";
 
     return UIComponent.extend("sap.ushell.components.homepage.Component", {
@@ -41,11 +41,11 @@ sap.ui.define([
             // This needs to be called _after_ the model is created
             UIComponent.prototype.init.apply(this, arguments);
 
-            this.rootControlLoaded().then(function (oView) {
+            this.rootControlLoaded().then((oView) => {
                 this.oDashboardView = oView;
 
                 // TODO: Please remove all 'NewHomepageManager' references after complete alignment!
-                var oDashboardMgrData = {
+                const oDashboardMgrData = {
                     model: this.oModel,
                     view: this.oDashboardView
                 };
@@ -53,7 +53,7 @@ sap.ui.define([
 
                 this.setModel(resources.i18nModel, "i18n");
 
-                EventBus.getInstance().subscribe("sap.ushell.services.UsageAnalytics", "usageAnalyticsStarted", function () {
+                EventBus.getInstance().subscribe("sap.ushell.services.UsageAnalytics", "usageAnalyticsStarted", () => {
                     sap.ui.require(["sap/ushell/components/homepage/FLPAnalytics"]);
                 });
 
@@ -62,17 +62,17 @@ sap.ui.define([
                 // don't use the returned promise but register to the config change
                 // for future config changes
                 oSharedComponentUtils.getEffectiveHomepageSetting("/core/home/homePageGroupDisplay", "/core/home/enableHomePageSettings");
-                Config.on("/core/home/homePageGroupDisplay").do(function (sNewDisplayMode) {
+                Config.on("/core/home/homePageGroupDisplay").do((sNewDisplayMode) => {
                     this.oHomepageManager.handleDisplayModeChange(sNewDisplayMode);
-                }.bind(this));
+                });
 
                 oSharedComponentUtils.getEffectiveHomepageSetting("/core/home/sizeBehavior", "/core/home/sizeBehaviorConfigurable");
-                Config.on("/core/home/sizeBehavior").do(function (sSizeBehavior) {
-                    var oModel = this.oHomepageManager.getModel();
+                Config.on("/core/home/sizeBehavior").do((sSizeBehavior) => {
+                    const oModel = this.oHomepageManager.getModel();
 
                     oModel.setProperty("/sizeBehavior", sSizeBehavior);
-                }.bind(this));
-            }.bind(this));
+                });
+            });
         },
 
         createContent: function () {