@sapui5/sap.ushell 1.138.1 → 1.139.1

package/src/main/js/sap/ushell/components/tiles/indicatorHarveyBall/HarveyBallTile.controller.js

@@ -10,21 +10,21 @@ sap.ui.define([
     "sap/ui/model/json/JSONModel",
     "sap/suite/ui/commons/library"
     // "sap/ushell/components/tiles/indicatorTileUtils/cache" // do not migrate
-], function (
+], (
     JSONModel,
     commonsLibrary
     // cache // do not migrate
-) {
+) => {
     "use strict";
 
     // shortcut for sap.suite.ui.commons.InfoTileValueColor
-    var InfoTileValueColor = commonsLibrary.InfoTileValueColor;
+    const InfoTileValueColor = commonsLibrary.InfoTileValueColor;
 
     // shortcut for sap.suite.ui.commons.InfoTileSize
-    var InfoTileSize = commonsLibrary.InfoTileSize;
+    const InfoTileSize = commonsLibrary.InfoTileSize;
 
     // shortcut for sap.suite.ui.commons.LoadState
-    var LoadState = commonsLibrary.LoadState;
+    const LoadState = commonsLibrary.LoadState;
 
     /* eslint-disable block-scoped-var */ // TODO: remove eslint-disable
 
@@ -37,10 +37,10 @@ sap.ui.define([
             this.readChipConfiguration();
         },
         attachHandlers: function () {
-            var that = this;
-            var oChip = this.getVariable("chip");
+            const that = this;
+            const oChip = this.getVariable("chip");
             if (oChip.visible) {
-                oChip.visible.attachVisible(function (bVisible) {
+                oChip.visible.attachVisible((bVisible) => {
                     if (bVisible) {
                         that.onVisible();
                     } else {
@@ -48,9 +48,9 @@ sap.ui.define([
                     }
                 });
             }
-            this.getVariable("tile").attachPress(function () {
+            this.getVariable("tile").attachPress(() => {
                 that.abortAllOpenODataRequests();
-                var indicatorUtils = that.getVariable("indicatorUtils");
+                const indicatorUtils = that.getVariable("indicatorUtils");
                 that.getVariable("cache").setKpivalueById(that.getVariable("chipId"), null);
                 window.location.hash = indicatorUtils.getNavigationTarget(that.getVariable("evalData"), that.getVariable("system"));
             });
@@ -58,10 +58,10 @@ sap.ui.define([
         initializeVariables: function () {
             this._variables = {};
             this._oDataRequests = {};
-            var oView = this.getView();
-            var oViewData = oView.getViewData();
-            var oTile = oView.oTile;
-            var oChip = oViewData.chip;
+            const oView = this.getView();
+            const oViewData = oView.getViewData();
+            const oTile = oView.oTile;
+            const oChip = oViewData.chip;
             this.setVariable("indicatorUtils", sap.ushell.components.tiles.indicatorTileUtils.util);
             this.setVariable("cache", sap.ushell.components.tiles.indicatorTileUtils.cache);
             this.setVariable("hasAppeared", false);
@@ -78,10 +78,10 @@ sap.ui.define([
             this._variables[sKey] = oVal;
         },
         readChipConfiguration: function () {
-            var that = this;
-            var oChip = this.getVariable("chip");
-            var utils = this.getVariable("indicatorUtils");
-            utils.getParsedChip(this.getVariable("configurationString"), function (evalData) {
+            const that = this;
+            const oChip = this.getVariable("chip");
+            const utils = this.getVariable("indicatorUtils");
+            utils.getParsedChip(this.getVariable("configurationString"), (evalData) => {
                 that.setVariable("evalData", evalData);
                 that.setVariable("chipId", evalData.TILE_PROPERTIES.id);
                 that.setVariable("tileProperties", evalData.TILE_PROPERTIES);
@@ -97,7 +97,7 @@ sap.ui.define([
             });
         },
         loadPreviewData: function () {
-            var oTitle = this.getVariable("indicatorUtils").getTileTitleSubtitle(this.getVariable("chip"));
+            const oTitle = this.getVariable("indicatorUtils").getTileTitleSubtitle(this.getVariable("chip"));
             this.getView().getModel().setData({
                 fractionValue: 34,
                 value: 100,
@@ -124,18 +124,18 @@ sap.ui.define([
             delete this._oDataRequests[sKey];
         },
         abortAllOpenODataRequests: function () {
-            for (var each in this._oDataRequests) {
+            for (const each in this._oDataRequests) {
                 try {
                     this.getVariable("indicatorUtils").abortPendingODataCalls(this._oDataRequests[each]);
                     delete this._oDataRequests[each];
                 } catch (e) {
-                    //do nothing on exception
+                    // do nothing on exception
                 }
             }
         },
         fetchKpiValue: function (oParam) {
             function makeODataRequest (oModel, sUri, oConfig, fnS, fnE) {
-                var oDataRef = oModel.read(sUri, null, null, true, function (data) {
+                const oDataRef = oModel.read(sUri, null, null, true, (data) => {
                     that.deregisterOpenODataRequest(oConfig.type);
                     if (data && data.results && data.results.length) {
                         try {
@@ -154,7 +154,7 @@ sap.ui.define([
                     } else {
                         fnE.call(that, "no data");
                     }
-                }, function (e) {
+                }, (e) => {
                     that.deregisterOpenODataRequest(oConfig.type);
                     if (e && e.response) {
                         fnE.call(that, e.message);
@@ -164,24 +164,24 @@ sap.ui.define([
             }
 
             var that = this;
-            var indicatorUtils = this.getVariable("indicatorUtils");
-            var cachedValue = this.getVariable("cache").getKpivalueById(this.getVariable("chipId"));
+            const indicatorUtils = this.getVariable("indicatorUtils");
+            const cachedValue = this.getVariable("cache").getKpivalueById(this.getVariable("chipId"));
             if (cachedValue) {
                 oParam.fnS.call(that, cachedValue);
             } else {
-                var sMeasure1 = oParam.measure1, sMeasure2 = oParam.measure2;
-                var sUri = oParam.url, sEntitySet = oParam.entitySet;
-                var variantFilters = oParam.filters;
-                var fractionValueFilters = oParam.fractionFilters.concat(variantFilters);
-                var oQuery1, oQuery2;
-                var unitColumn1, unitColumn2, kpiData;
-                var semaphore = 2;//to keep track of race around condition
-                fractionValueFilters.forEach(function (cur) { // this code written only for now. to handler the exception thrown by prepareQueryServiceUri
-                    cur.value = cur.value + ""; // it assumes everyting is string and tries to call split
-                    cur.valueTo = cur.valueTo + "";
+                const sMeasure1 = oParam.measure1; const sMeasure2 = oParam.measure2;
+                const sUri = oParam.url; const sEntitySet = oParam.entitySet;
+                const variantFilters = oParam.filters;
+                const fractionValueFilters = oParam.fractionFilters.concat(variantFilters);
+                let oQuery1; let oQuery2;
+                let unitColumn1; let unitColumn2; var kpiData;
+                var semaphore = 2;// to keep track of race around condition
+                fractionValueFilters.forEach((cur) => { // this code written only for now. to handler the exception thrown by prepareQueryServiceUri
+                    cur.value = `${cur.value}`; // it assumes everyting is string and tries to call split
+                    cur.valueTo = `${cur.valueTo}`;
                 });
                 if (oParam.thresholds && oParam.thresholds.length) {
-                    oQuery1 = indicatorUtils.prepareQueryServiceUri(this.getVariable("chip").url.addSystemToServiceUrl(sUri), sEntitySet, sMeasure1 + "," + oParam.thresholds, null, variantFilters);
+                    oQuery1 = indicatorUtils.prepareQueryServiceUri(this.getVariable("chip").url.addSystemToServiceUrl(sUri), sEntitySet, `${sMeasure1},${oParam.thresholds}`, null, variantFilters);
                 } else {
                     oQuery1 = indicatorUtils.prepareQueryServiceUri(this.getVariable("chip").url.addSystemToServiceUrl(sUri), sEntitySet, sMeasure1, null, variantFilters);
                 }
@@ -214,8 +214,8 @@ sap.ui.define([
             }
         },
         _setThresholdValues: function (data) {
-            var oThreshold = this.getVariable("oThreshold"),
-                each;
+            const oThreshold = this.getVariable("oThreshold");
+            let each;
             if (oThreshold) {
                 if (this.getVariable("evalData").EVALUATION.VALUES_SOURCE == "RELATIVE") {
                     if (oThreshold.TA.COLUMN_NAME) { // only if target threshold is a measure column
@@ -236,11 +236,11 @@ sap.ui.define([
             } this.setVariable("oThreshold", oThreshold);
         },
         getThresholdObject: function () {
-            var oThreshold = this.getVariable("oThreshold");
+            let oThreshold = this.getVariable("oThreshold");
             if (!oThreshold) {
-                var aThresholds = this.getVariable("evalData").EVALUATION_VALUES;
+                const aThresholds = this.getVariable("evalData").EVALUATION_VALUES;
                 oThreshold = {};
-                for (var i = 0, l = aThresholds.length; i < l; i++) {
+                for (let i = 0, l = aThresholds.length; i < l; i++) {
                     oThreshold[aThresholds[i].TYPE] = {
                         VALUE: parseFloat(aThresholds[i].FIXED),
                         COLUMN_NAME: aThresholds[i].COLUMN_NAME
@@ -251,9 +251,9 @@ sap.ui.define([
             return oThreshold;
         },
         hasSomeValue: function () {
-            var flag = true;
+            let flag = true;
             if (arguments.length) {
-                for (var i = 0, l = arguments.length; i < l; i++) {
+                for (let i = 0, l = arguments.length; i < l; i++) {
                     if (!(arguments[i] || arguments[i] == "0")) {
                         flag = false;
                         break;
@@ -265,8 +265,8 @@ sap.ui.define([
             return flag;
         },
         getTrendColor: function (kpiValue) {
-            var color = "Neutral";
-            var oThreshold, goalType, WL, WH, CL, CH;
+            let color = "Neutral";
+            let oThreshold; let goalType; let WL; let WH; let CL; let CH;
             if (this.getVariable("tileProperties").isFractionMeasure) {
                 oThreshold = this.getThresholdObject();
                 goalType = this.getVariable("evalData").EVALUATION.GOAL_TYPE;
@@ -311,27 +311,27 @@ sap.ui.define([
             } return InfoTileValueColor[color];
         },
         _getThresholdMeasures: function () {
-            var aThresholds = [];
-            var oThreshold = this.getThresholdObject();
-            for (var each in oThreshold) {
+            const aThresholds = [];
+            const oThreshold = this.getThresholdObject();
+            for (const each in oThreshold) {
                 if (oThreshold[each].COLUMN_NAME) {
                     aThresholds.push(oThreshold[each].COLUMN_NAME);
                 }
             } return aThresholds;
         },
         onEvalFiltersFetched: function () {
-            var that = this;
+            const that = this;
             if (this.getVariable("chip").visible.isVisible() && !this.getVariable("hasAppeared")) {
                 try {
-                    var kpiDefinition = this.getVariable("evalData");
-                    var sUri = kpiDefinition.EVALUATION.ODATA_URL;
-                    var sEntitySet = kpiDefinition.EVALUATION.ODATA_ENTITYSET;
-                    var tileProperties = this.getVariable("tileProperties");
-                    var harveyFilters = [];
-                    var variantFilters = this.getVariable("indicatorUtils").prepareFilterStructure(kpiDefinition.EVALUATION_FILTERS, kpiDefinition.ADDITIONAL_FILTERS);
-                    var fractionMeasure = kpiDefinition.EVALUATION.COLUMN_NAME;
-                    var totalMeasure = fractionMeasure;
-                    var thresholdMeasures = [];
+                    const kpiDefinition = this.getVariable("evalData");
+                    const sUri = kpiDefinition.EVALUATION.ODATA_URL;
+                    const sEntitySet = kpiDefinition.EVALUATION.ODATA_ENTITYSET;
+                    const tileProperties = this.getVariable("tileProperties");
+                    let harveyFilters = [];
+                    const variantFilters = this.getVariable("indicatorUtils").prepareFilterStructure(kpiDefinition.EVALUATION_FILTERS, kpiDefinition.ADDITIONAL_FILTERS);
+                    const fractionMeasure = kpiDefinition.EVALUATION.COLUMN_NAME;
+                    let totalMeasure = fractionMeasure;
+                    let thresholdMeasures = [];
                     if (tileProperties.isFractionMeasure) {
                         totalMeasure = tileProperties.harveyTotalMeasure;
                         thresholdMeasures = this._getThresholdMeasures();
@@ -364,14 +364,14 @@ sap.ui.define([
             }
         },
         fetchEvalFilters: function (fnS) {
-            var that = this;
+            const that = this;
             try {
-                var evaluationData = this.getVariable("cache").getEvaluationById(this.getVariable("chipId"));
+                const evaluationData = this.getVariable("cache").getEvaluationById(this.getVariable("chipId"));
                 if (evaluationData) {
                     this.getVariable("evalData").EVALUATION_FILTERS = evaluationData.EVALUATION_FILTERS;
                     fnS();
                 } else {
-                    var oDataRef = this.getVariable("indicatorUtils").getFilterFromRunTimeService(this.getVariable("evalData"), function (filter) {
+                    const oDataRef = this.getVariable("indicatorUtils").getFilterFromRunTimeService(this.getVariable("evalData"), (filter) => {
                         that.deregisterOpenODataRequest("kpiFilterRequest");
                         that.getVariable("evalData").EVALUATION_FILTERS = filter;
                         that.getVariable("cache").setEvaluationById(that.getVariable("chipId"), that.getVariable("evalData"));
@@ -388,28 +388,28 @@ sap.ui.define([
             }
         },
         onKpiValueFetched: function (kpiValue, kpiValueUnit, fractionValue, fractionValueUnit) {
-            var indicatorUtil = this.getVariable("indicatorUtils");
-            var scaledKpiValue = kpiValue;
-            var scaledFractionValue = fractionValue;
-            var evalData = this.getVariable("evalData");
-            var scalingFactor = evalData.EVALUATION.SCALING;
+            const indicatorUtil = this.getVariable("indicatorUtils");
+            let scaledKpiValue = kpiValue;
+            let scaledFractionValue = fractionValue;
+            const evalData = this.getVariable("evalData");
+            const scalingFactor = evalData.EVALUATION.SCALING;
             if (scalingFactor == -2) {
                 scaledKpiValue *= 100;
                 scaledFractionValue *= 100;
             }
-            var c = this.isACurrencyMeasure(this.getVariable("totalMeasure"));
+            let c = this.isACurrencyMeasure(this.getVariable("totalMeasure"));
             scaledKpiValue = indicatorUtil.getLocaleFormattedValue(Number(scaledKpiValue), scalingFactor, null, c, kpiValueUnit);
             c = this.isACurrencyMeasure(this.getVariable("fractionMeasure"));
             scaledFractionValue = indicatorUtil.getLocaleFormattedValue(Number(scaledFractionValue), scalingFactor, null, c, kpiValueUnit);
 
-            this.getView().getModel().setProperty("/totalLabel", scaledKpiValue + " " + kpiValueUnit);
-            this.getView().getModel().setProperty("/fractionLabel", scaledFractionValue + " " + fractionValueUnit);
+            this.getView().getModel().setProperty("/totalLabel", `${scaledKpiValue} ${kpiValueUnit}`);
+            this.getView().getModel().setProperty("/fractionLabel", `${scaledFractionValue} ${fractionValueUnit}`);
             this.getView().getModel().setProperty("/color", this.getTrendColor(fractionValue));
             this.getView().getModel().setProperty("/value", kpiValue);
             this.getView().getModel().setProperty("/fractionValue", fractionValue);
 
-            var navTarget = indicatorUtil.getNavigationTarget(this.getVariable("evalData"), this.getVariable("system"));
-            this.getVariable("tile").$().wrap("<a href ='" + navTarget + "'></a>");
+            const navTarget = indicatorUtil.getNavigationTarget(this.getVariable("evalData"), this.getVariable("system"));
+            this.getVariable("tile").$().wrap(`<a href ='${navTarget}'></a>`);
             this.getVariable("tile").setState(LoadState.Loaded);
         },
         logError: function (err) {

package/src/main/js/sap/ushell/components/tiles/indicatorHarveyBall/HarveyBallTile.view.js

@@ -14,7 +14,7 @@ sap.ui.require([
     "sap/suite/ui/commons/HarveyBallMicroChartItem",
     "sap/suite/ui/commons/TileContent",
     "sap/suite/ui/commons/GenericTile"
-], function (
+], (
     NumberFormat,
     odata4analytics,
     smartBusinessUtil,
@@ -22,18 +22,18 @@ sap.ui.require([
     HarveyBallMicroChartItem,
     TileContent,
     GenericTile
-) {
+) => {
     "use strict";
 
     sap.ui.getCore().loadLibrary("sap.suite.ui.commons");
 
     sap.ui.jsview("tiles.indicatorHarveyBall.HarveyBallTile", {
         getControllerName: function () {
-            //return "tiles.indicatorHarveyBall.HarveyBallTile"; // comment to prevent the tile from loading
+            // return "tiles.indicatorHarveyBall.HarveyBallTile"; // comment to prevent the tile from loading
         },
 
-        createContent: function (/*oController*/) {
-            var microChart = new HarveyBallMicroChart({
+        createContent: function (/* oController */) {
+            const microChart = new HarveyBallMicroChart({
                 total: "{/value}",
                 size: "{/size}",
                 totalLabel: "{/totalLabel}",
@@ -44,7 +44,7 @@ sap.ui.require([
                 })]
             });
 
-            var tileContent = new TileContent({
+            const tileContent = new TileContent({
                 size: "{/size}",
                 content: microChart
             });
@@ -56,7 +56,7 @@ sap.ui.require([
                 header: "{/header}",
                 tileContent: [tileContent]
             });
-            //return this.oTile; // comment to prevent the tile from loading
+            // return this.oTile; // comment to prevent the tile from loading
         }
     });
 });

package/src/main/js/sap/ushell/components/tiles/indicatorTileUtils/cache.js

@@ -1,11 +1,11 @@
 // Copyright (c) 2009-2025 SAP SE, All Rights Reserved
 
-sap.ui.define([], function () {
+sap.ui.define([], () => {
     "use strict";
 
-    var BIGMAP = {};
-    var KPIVALUE = {};
-    var sessionContext = "HANA_CLIENT";
+    const BIGMAP = {};
+    const KPIVALUE = {};
+    const sessionContext = "HANA_CLIENT";
 
     return {
         getCacheHanaClient: function () {

package/src/main/js/sap/ushell/components/tiles/indicatorTileUtils/indicatorTileHelper.js

@@ -6,12 +6,12 @@
  *
  * @deprecated since 1.96
  */
-sap.ui.define([], function () {
+sap.ui.define([], () => {
     "use strict";
 
-    var IndicatorTileHelper = function (tile) {
+    function IndicatorTileHelper (tile) {
         this.tile = tile;
-    };
+    }
 
     IndicatorTileHelper.prototype.setErrorState = function () {
         this.getTile().setState(sap.suite.ui.commons.LoadState.Failed);
@@ -49,7 +49,7 @@ sap.ui.define([], function () {
     IndicatorTileHelper.prototype.setThresholdNeutral = function () {
     };
 
-    IndicatorTileHelper.prototype.calculateThreshold = function (/*actualValue, variantValue, improvementDirection*/) {
+    IndicatorTileHelper.prototype.calculateThreshold = function (/* actualValue, variantValue, improvementDirection */) {
     };
 
     IndicatorTileHelper.prototype.setTile = function (tile) {