@sapui5/sap.ushell 1.120.8 → 1.121.0

package/src/main/js/sap/ushell/ui/shell/ShellAppTitle.js

@@ -21,7 +21,7 @@ sap.ui.define([
     "sap/m/ResponsivePopover",
     "sap/m/Title",
     "sap/m/ToggleButton",
-    "sap/ui/core/Core",
+    "sap/ui/core/Element",
     "sap/ui/core/Icon",
     "sap/ui/core/IconPool",
     "sap/ui/Device",
@@ -41,7 +41,7 @@ sap.ui.define([
     ResponsivePopover,
     Title,
     ToggleButton,
-    Core,
+    Element,
     Icon,
     IconPool,
     Device,
@@ -184,11 +184,11 @@ sap.ui.define([
         return Config.last("/core/shellHeader/ShellAppTitleState");
     };
 
-    /*
-    * ShellAppTitle click handler:
-    * 1. Calculating UI visibility and state
-    * 2. Creating content popover
-    */
+    /**
+     * ShellAppTitle click handler:
+     * 1. Calculating UI visibility and state
+     * 2. Creating content popover
+     */
     ShellAppTitle.prototype.onclick = function (oEvent) {
         oEvent.preventDefault();
         this.firePress();
@@ -300,14 +300,14 @@ sap.ui.define([
         return bVisible;
     };
 
-    /*******************************************************************************************************/
-    /****************************************** Create Popover UI ******************************************/
+    //******************************************************************************************************
+    //***************************************** Create Popover UI ******************************************
 
-    /*
-    * Create and return the popover object that will contain the AllMyApps UI
-    */
+    /**
+     * Create and return the popover object that will contain the AllMyApps UI
+     */
     ShellAppTitle.prototype._createAllMyAppsPopover = function () {
-        var oAllMyApps = Core.byId(this.getAllMyApps());
+        var oAllMyApps = Element.getElementById(this.getAllMyApps());
 
         // do not open the all my apps popover if the data is not available yet
         if (!oAllMyApps) {
@@ -333,8 +333,6 @@ sap.ui.define([
         oAllMyAppsPopover.setModel(this.getModel());
 
         oAllMyAppsPopover.attachAfterOpen(function () {
-            oAllMyApps.getController()._afterOpen();
-
             var oHeader = oAllMyAppsPopover.getCustomHeader();
             var oBackButton = oHeader.getContentLeft()[0];
             var oToggleButton = oHeader.getContentLeft()[1];
@@ -351,7 +349,7 @@ sap.ui.define([
         return oAllMyAppsPopover;
     };
 
-    /*
+    /**
      * Called after closing the All My Apps popover
      */
     ShellAppTitle.prototype._afterCloseAllMyAppsPopover = function () {
@@ -367,11 +365,11 @@ sap.ui.define([
         }
     };
 
-    /*
-    * Create and return the popover object that will contain the ShellNavMenu UI
-    */
+    /**
+     * Create and return the popover object that will contain the ShellNavMenu UI
+     */
     ShellAppTitle.prototype._createNavMenuPopover = function () {
-        var oNavMenu = Core.byId(this.getNavigationMenu());
+        var oNavMenu = Element.getElementById(this.getNavigationMenu());
 
         this.oTitle = new Title("navMenuInnerTitle", {
             wrapping: true,
@@ -439,7 +437,7 @@ sap.ui.define([
         return oNavMenuPopover;
     };
 
-    /*
+    /**
      * Called after closing the Navigation Menu Popover
      */
     ShellAppTitle.prototype._afterCloseNavigationMenuPopover = function () {
@@ -463,7 +461,7 @@ sap.ui.define([
         Title.prototype.setText.apply(this, [text]);
     };
 
-    /*
+    /**
      * Create and return the popover header, containing back button and toggle button
      */
     ShellAppTitle.prototype._getPopoverHeader = function () {
@@ -487,13 +485,13 @@ sap.ui.define([
     };
 
     ShellAppTitle.prototype.onAfterRendering = function () {
-        var oShellHeader = Core.byId("shell-header");
+        var oShellHeader = Element.getElementById("shell-header");
         if (oShellHeader) {
             oShellHeader.refreshLayout();
         }
     };
 
-    /*
+    /**
      * Popover Back Button functionality:
      * 1. In case the Master area is in first level - switch to ShellNavMenu
      * 2. In case the Master area is in second level - return the Master area to the first level (call switchToInitialState)
@@ -532,7 +530,7 @@ sap.ui.define([
         oAllMyAppsController.updateHeaderButtonsState();
     };
 
-    /*
+    /**
      * This button should be visible only on devices, and is used for toggling between the master and the details areas
      */
     ShellAppTitle.prototype._createPopoverToggleButton = function () {
@@ -559,7 +557,7 @@ sap.ui.define([
         return oToggleButton;
     };
 
-    /*
+    /**
      * Create and return the popover footer, containing a button for switching from ShellNavMenu to AllMyApps
      */
     ShellAppTitle.prototype._getPopoverFooterContent = function () {
@@ -582,12 +580,12 @@ sap.ui.define([
         return oPopoverFooterContent;
     };
 
-    /*
+    /**
      * Opens the All My Apps popover
-    */
+     */
     ShellAppTitle.prototype._allMyAppsButtonPressHandler = function () {
         // might not be available, as AllMyApps might not be loaded yet
-        if (Core.byId(this.getAllMyApps())) {
+        if (Element.getElementById(this.getAllMyApps())) {
             Measurement.start(
                 "FLP:ShellNavMenu.footerClick",
                 "Click the footer of ShellNavMenu, Launching AllMyApps",
@@ -604,7 +602,7 @@ sap.ui.define([
     /*******************************************************************************************************/
 
     ShellAppTitle.prototype._isNavMenuEnabled = function () {
-        var oNavMenu = Core.byId(this.getNavigationMenu());
+        var oNavMenu = Element.getElementById(this.getNavigationMenu());
         return oNavMenu ? oNavMenu.getItems() && oNavMenu.getItems().length > 0 : false;
     };
 
@@ -632,7 +630,7 @@ sap.ui.define([
     };
 
     ShellAppTitle.prototype.getAllMyAppsController = function () {
-        var oAllMyApps = Core.byId(this.getAllMyApps());
+        var oAllMyApps = Element.getElementById(this.getAllMyApps());
         return oAllMyApps.getController();
     };
 
@@ -645,8 +643,8 @@ sap.ui.define([
     ShellAppTitle.prototype.onsapenter = ShellAppTitle.prototype.onclick;
 
     ShellAppTitle.prototype.exit = function () {
-        var oNavMenu = Core.byId(this.getNavigationMenu());
-        var oAllMyApps = Core.byId(this.getAllMyApps());
+        var oNavMenu = Element.getElementById(this.getNavigationMenu());
+        var oAllMyApps = Element.getElementById(this.getAllMyApps());
 
         if (oNavMenu) {
             oNavMenu.destroy();
@@ -670,4 +668,4 @@ sap.ui.define([
     };
 
     return ShellAppTitle;
-}, true);
+});

package/src/main/js/sap/ushell/ui/shell/ShellFloatingAction.js

@@ -1,10 +1,5 @@
 // Copyright (c) 2009-2023 SAP SE, All Rights Reserved
 
-/**
- * @name sap.ushell.ui.shell.ShellFloatingAction
- *
- * @private
- */
 sap.ui.define([
     "sap/ui/thirdparty/jquery",
     "sap/m/Button",
@@ -17,7 +12,15 @@ sap.ui.define([
 ) {
     "use strict";
 
-    var ShellFloatingAction = Button.extend("sap.ushell.ui.shell.ShellFloatingAction", {
+    /**
+     * @alias sap.ushell.ui.shell.ShellFloatingAction
+     * @class
+     *
+     * @extends sap.m.Button
+     *
+     * @private
+     */
+    var ShellFloatingAction = Button.extend("sap.ushell.ui.shell.ShellFloatingAction", /** @lends sap.ushell.ui.shell.ShellFloatingAction.prototype */ {
         metadata: {
             library: "sap.ushell"
         },

package/src/main/js/sap/ushell/ui/shell/ShellFloatingActionRenderer.js

@@ -1,9 +1,7 @@
 // Copyright (c) 2009-2023 SAP SE, All Rights Reserved
 
 /**
- * @class ShellFloatingAction renderer.
- * @static
- *
+ * ShellFloatingAction renderer.
  * @private
  */
 sap.ui.define([

package/src/main/js/sap/ushell/ui/shell/ShellHeadItem.js

@@ -21,21 +21,18 @@ sap.ui.define([
     var FloatingNumberType = ushellLibrary.FloatingNumberType;
 
     /**
+     * @alias sap.ushell.ui.shell.ShellHeadItem
+     * @class
+     * @classdesc Header Action item of the Shell.
      * Constructor for a new ShellHeadItem.
      *
      * @param {string} [sId] id for the new control, generated automatically if no id is given
      * @param {object} [mSettings] initial settings for the new control
      *
-     * @class Header Action item of the Shell.
      * @extends sap.ui.core.Control
      *
-     * @author SAP SE
-     * @version 1.120.8
-     *
      * @private
      * @since 1.15.1
-     * @alias sap.ushell.ui.shell.ShellHeadItem
-     * @ui5-metamodel This control/element also will be described in the UI5 (legacy) designtime metamodel
      */
     var ShellHeadItem = Control.extend("sap.ushell.ui.shell.ShellHeadItem", /** @lends sap.ushell.ui.shell.ShellHeadItem.prototype */ {
         metadata: {
@@ -145,7 +142,7 @@ sap.ui.define([
                     defaultValue: 999
                 },
                 floatingNumberType: {
-                    type: "string",
+                    type: "sap.ushell.FloatingNumberType",
                     group: "Appearance",
                     defaultValue: FloatingNumberType.None
                 }

package/src/main/js/sap/ushell/ui/shell/ShellNavigationMenu.js

@@ -10,8 +10,8 @@ sap.ui.define([
     "sap/m/List",
     "sap/m/VBox",
     "sap/ui/core/Control",
-    "sap/ui/core/Core",
     "sap/ui/Device",
+    "sap/ui/core/Element",
     "sap/ui/thirdparty/jquery",
     "sap/ui/events/KeyCodes",
     "sap/ushell/library", // css style dependency
@@ -23,8 +23,8 @@ sap.ui.define([
     List,
     VBox,
     Control,
-    Core,
     Device,
+    Element,
     jQuery,
     KeyCodes,
     ushellLibrary,
@@ -261,9 +261,9 @@ sap.ui.define([
         this.oMiniTilesBox = new FlexBox("sapUshellNavRelatedAppsFlexBox", { justifyContent: "Center" });
     };
 
-    /*
-    before open method: this is done from performance reasons, to lazy-load the non-necessary resources
-    */
+    /**
+     * before open method: this is done from performance reasons, to lazy-load the non-necessary resources
+     */
     ShellNavigationMenu.prototype._beforeOpen = function () {
         // only if this is first time (e.g. not initialized yet)
         if (!this.bInitialized) {
@@ -314,7 +314,7 @@ sap.ui.define([
                         // focus last visited mini tile
                         this.keyboardNavigation.setFocusToLastFocusedMiniTile(e);
                     } else {
-                        var oAllMyAppsBtn = Core.byId("allMyAppsButton");
+                        var oAllMyAppsBtn = Element.getElementById("allMyAppsButton");
 
                         this.keyboardNavigation._setItemFocus(e, jQuery((oAllMyAppsBtn.getDomRef())));
                     }
@@ -323,7 +323,7 @@ sap.ui.define([
         }
     };
 
-    /*
+    /**
      * methods for overriding default behavior of the aggregation management by the infrastructure,
      * in order to delegate the aggregation controls to an inner control which should render them instead
      * (the related-apps flex-box items aggregation)
@@ -378,7 +378,7 @@ sap.ui.define([
         return -1;
     };
 
-    /*
+    /**
      * methods for overriding default behavior of the aggregation management by the infrastructure,
      * in order to delegate the aggregation controls to an inner control which should render them instead
      * (the items-list items aggregation)

package/src/main/js/sap/ushell/ui/shell/SysInfoBar.js

@@ -43,21 +43,16 @@ sap.ui.define([
 
 
     /**
-     * Constructor for a new SysInfoBar.
+     * @alias sap.ushell.ui.shell.SysInfoBar
+     * @class
+     * @classdesc Constructor for a new SysInfoBar.
      *
      * @param {string} [sId] ID for the new control, generated automatically if no ID is given
      * @param {object} [mSettings] Initial settings for the new control
      *
-     * @class
-     * The Page represents a collection of sections.
      * @extends sap.ui.core.Control
      *
-     * @author SAP SE
-     * @version 1.120.8
-     *
      * @private
-     * @alias sap.ushell.ui.shell.SysInfoBar
-     * @ui5-metamodel This control/element also will be described in the UI5 (legacy) designtime metamodel
      */
     var SysInfoBar = Control.extend("sap.ushell.ui.shell.SysInfoBar", /** @lends sap.ushell.ui.shell.SysInfoBar.prototype */ {
         metadata: {

package/src/main/js/sap/ushell/ui/shell/ToolArea.js

@@ -1,7 +1,7 @@
 // Copyright (c) 2009-2023 SAP SE, All Rights Reserved
 
-/*
- * The Tool Area control is used in the FLP extensibility.
+/**
+ * @fileoverview The Tool Area control is used in the FLP extensibility.
  */
 sap.ui.define([
     "sap/ui/core/Control",

package/src/main/js/sap/ushell/ui/shell/ToolAreaItem.js

@@ -18,7 +18,7 @@ sap.ui.define([
      * A control to be placed in the tool area
      * @extends sap.ui.core.Control
      *
-     * @version 1.120.8
+     * @version 1.121.0
      *
      * @public
      * @since 1.30.5

package/src/main/js/sap/ushell/ui/tile/DynamicTile.js

@@ -19,24 +19,22 @@ sap.ui.define([
     var StateArrow = ushellLibrary.ui.tile.StateArrow;
 
     /**
-     * Constructor for a new ui/tile/DynamicTile.
+     * @alias sap.ushell.ui.tile.DynamicTile
+     * @class
+     * @classdesc Constructor for a new ui/tile/DynamicTile.
+     * An applauncher for apps that need to display dynamically updated information
      *
      * @param {string} [sId] id for the new control, generated automatically if no id is given
      * @param {object} [mSettings] initial settings for the new control
      *
-     * @class
-     * An applauncher for apps that need to display dynamically updated information
      * @extends sap.ushell.ui.tile.TileBase
      *
      * @private
-     * @name sap.ushell.ui.tile.DynamicTile
-     * @ui5-metamodel This control/element also will be described in the UI5 (legacy) designtime metamodel
      */
     var DynamicTile = TileBase.extend("sap.ushell.ui.tile.DynamicTile", /** @lends sap.ushell.ui.tile.DynamicTile.prototype */ {
         metadata: {
             library: "sap.ushell",
             properties: {
-
                 /**
                  * a number to be formatted with numberDigits decimal digits. Can be sap.ui.core.string as well.
                  */
@@ -45,7 +43,7 @@ sap.ui.define([
                 /**
                  * The state of the number, indicating positive or negative conditions
                  */
-                numberState: { type: "State", group: "Appearance", defaultValue: State.Neutral },
+                numberState: { type: "sap.ushell.ui.tile.State", group: "Appearance", defaultValue: State.Neutral },
 
                 /**
                  * The unit in which numberValue is measured
@@ -60,7 +58,7 @@ sap.ui.define([
                 /**
                  * the state of the trend indicator
                  */
-                stateArrow: { type: "StateArrow", group: "Appearance", defaultValue: StateArrow.None },
+                stateArrow: { type: "sap.ushell.ui.tile.StateArrow", group: "Appearance", defaultValue: StateArrow.None },
 
                 /**
                  * defines a scaling factor (like "%", "M" or "k") right to a scaled number

package/src/main/js/sap/ushell/ui/tile/DynamicTileRenderer.js

@@ -20,7 +20,7 @@ sap.ui.define([
     var translationBundle = resources.i18n;
 
     /**
-     * @name sap.ushell.ui.tile.DynamicTileRenderer.
+     * @alias sap.ushell.ui.tile.DynamicTileRenderer.
      * @static
      * @private
      */

package/src/main/js/sap/ushell/ui/tile/ImageTile.js

@@ -13,18 +13,17 @@ sap.ui.define([
     "use strict";
 
     /**
-     * Constructor for a new ui/tile/ImageTile.
+     * @alias sap.ushell.ui.tile.ImageTile
+     * @class
+     * @classdesc Constructor for a new ui/tile/ImageTile.
+     * Add your documentation for the newui/tile/ImageTile
      *
      * @param {string} [sId] id for the new control, generated automatically if no id is given
      * @param {object} [mSettings] initial settings for the new control
      *
-     * @class
-     * Add your documentation for the newui/tile/ImageTile
      * @extends sap.ushell.ui.tile.TileBase
      *
      * @private
-     * @name sap.ushell.ui.tile.ImageTile
-     * @ui5-metamodel This control/element also will be described in the UI5 (legacy) designtime metamodel
      */
     var ImageTile = TileBase.extend("sap.ushell.ui.tile.ImageTile", /** @lends sap.ushell.ui.tile.ImageTile.prototype */ {
         metadata: {

package/src/main/js/sap/ushell/ui/tile/ImageTileRenderer.js

@@ -1,12 +1,11 @@
 // Copyright (c) 2009-2023 SAP SE, All Rights Reserved
 
-sap.ui.define(["sap/ui/core/Renderer", "./TileBaseRenderer"],
-	function (Renderer, TileBaseRenderer) {
-	"use strict";
+sap.ui.define(["sap/ui/core/Renderer", "./TileBaseRenderer"], function (Renderer, TileBaseRenderer) {
+    "use strict";
 
     /**
-     * @name sap.ushell.ui.tile.ImageTileRenderer
-     * @static
+     * @alias sap.ushell.ui.tile.ImageTileRenderer
+     * @namespace
      * @private
      */
 
@@ -33,6 +32,6 @@ sap.ui.define(["sap/ui/core/Renderer", "./TileBaseRenderer"],
     };
 
 
-	return ImageTileRenderer;
+    return ImageTileRenderer;
 
 });

package/src/main/js/sap/ushell/ui/tile/StaticTile.js

@@ -16,20 +16,19 @@ sap.ui.define([
     "use strict";
 
     /**
-     * Constructor for a new ui/tile/StaticTile.
+     * @alias sap.ushell.ui.tile.StaticTile
+     * @class
+     * @classdesc Constructor for a new ui/tile/StaticTile.
+     * An applauncher tile for simple, static apps, displaying title, subtitle, an icon and additional information
      *
      * @param {string} [sId] id for the new control, generated automatically if no id is given
      * @param {object} [mSettings] initial settings for the new control
      *
-     * @class
-     * An applauncher tile for simple, static apps, displaying title, subtitle, an icon and additional information
      * @extends sap.ushell.ui.tile.TileBase
      *
      * @since 1.15.0
      * @public
      * @deprecated since 1.120
-     * @name sap.ushell.ui.tile.StaticTile
-     * @ui5-metamodel This control/element also will be described in the UI5 (legacy) designtime metamodel
      */
     var StaticTile = TileBase.extend("sap.ushell.ui.tile.StaticTile", /** @lends sap.ushell.ui.tile.StaticTile.prototype */ {
         metadata: {

package/src/main/js/sap/ushell/ui/tile/StaticTileRenderer.js

@@ -1,12 +1,11 @@
 // Copyright (c) 2009-2023 SAP SE, All Rights Reserved
 
-sap.ui.define(["sap/ui/core/Renderer", "./TileBaseRenderer"],
-	function (Renderer, TileBaseRenderer) {
-	"use strict";
+sap.ui.define(["sap/ui/core/Renderer", "./TileBaseRenderer"], function (Renderer, TileBaseRenderer) {
+    "use strict";
 
     /**
-     * @name sap.ushell.ui.tile.StaticTileRenderer
-     * @static
+     * @alias sap.ushell.ui.tile.StaticTileRenderer
+     * @namespace
      * @private
      */
     var StaticTileRenderer = Renderer.extend(TileBaseRenderer);
@@ -33,6 +32,6 @@ sap.ui.define(["sap/ui/core/Renderer", "./TileBaseRenderer"],
     };
 
 
-	return StaticTileRenderer;
+    return StaticTileRenderer;
 
 });

package/src/main/js/sap/ushell/ui/tile/TileBase.js

@@ -1,6 +1,4 @@
-/*!
- * Copyright (c) 2009-2023 SAP SE, All Rights Reserved
- */
+// Copyright (c) 2009-2023 SAP SE, All Rights Reserved
 
 // Provides control sap.ushell.ui.tile.TileBase.
 sap.ui.define([
@@ -20,18 +18,17 @@ sap.ui.define([
     var TileState = ushellLibrary.ui.tile.State;
 
     /**
-     * Constructor for a new ui/tile/TileBase.
+     * @alias sap.ushell.ui.tile.TileBase
+     * @class
+     * @classdesc Constructor for a new ui/tile/TileBase.
+     * Base class for tiles that already provides several visual elements like title, subtitle, icon and additional information
      *
      * @param {string} [sId] id for the new control, generated automatically if no id is given
      * @param {object} [mSettings] initial settings for the new control
      *
-     * @class
-     * Base class for tiles that already provides several visual elements like title, subtitle, icon and additional information
      * @extends sap.ui.core.Control
      *
      * @private
-     * @name sap.ushell.ui.tile.TileBase
-     * @ui5-metamodel This control/element also will be described in the UI5 (legacy) designtime metamodel
      */
     var TileBase = Control.extend("sap.ushell.ui.tile.TileBase", /** @lends sap.ushell.ui.tile.TileBase.prototype */ {
         metadata: {

package/src/main/js/sap/ushell/ui/tile/TileBaseRenderer.js

@@ -17,8 +17,8 @@ sap.ui.define([
     var TileState = ushellLibrary.ui.tile.State;
 
     /**
-     * @name sap.ushell.ui.tile.TileBaseRenderer
-     * @static
+     * @alias sap.ushell.ui.tile.TileBaseRenderer
+     * @namespace
      * @private
      */
     var TileBaseRenderer = {
@@ -29,7 +29,7 @@ sap.ui.define([
     /**
      * Searches for occurrences of given searchTerms and substitutes substrings with themselves wrapped in HTML bold tag
      *
-     * @param {array} aHighlightTerms an array of strings that will be detected and replaced
+     * @param {string[]} aHighlightTerms an array of strings that will be detected and replaced
      * @param {string} sText contains the text to be highlighted
      * @returns {string} the text with all occurrences wrapped
      * @private

package/src/main/js/sap/ushell/ui/utils.js

@@ -6,7 +6,7 @@
  * This is a utility module that collects common activities implemented
  * by controllers of different ui components.
  *
- * @version 1.120.8
+ * @version 1.121.0
  * @private
  */
 
@@ -46,9 +46,7 @@ sap.ui.define([
      * A <code>null</code> value after the user settings have been processed,
      * regardless of whether the save operation terminated successfully.
      *
-     * @returns {jQuery.Deferred}
-     *
-     * A jQuery promise that is resolved with no arguments when the saving
+     * @returns {jQuery.Promise} Resolved with no arguments when the saving
      * process is completed and rejected with an error message in case at least
      * one of the preferences is not saved.
      *

package/src/main/js/sap/ushell/ui5service/ShellUIService.js

@@ -3,15 +3,8 @@
 /**
  * @fileOverview The ShellUIService UI5 service
  *
- * @version 1.120.8
+ * @version 1.121.0
  */
-
-/**
- * @namespace sap.ushell.ui5service.ShellUIService
- *
- * @public
- */
-
 sap.ui.define([
     "sap/ui/core/service/ServiceFactoryRegistry",
     "sap/ui/core/service/ServiceFactory",
@@ -25,8 +18,14 @@ sap.ui.define([
 ) {
     "use strict";
 
+    /**
+     * @namespace sap.ushell.ui5service.ShellUIService
+     *
+     * @public
+     */
+
     // this function is designed for the qUnit test to inject the stubbed dependencies
-    // directly into the module. Without this function, it's impossbile to stub the
+    // directly into the module. Without this function, it's impossible to stub the
     // dependency modules since they are only available inside this module.
     return fnDefineClass({
         serviceRegistry: ServiceFactoryRegistry,