@pmelab/gtd 58.2.0 → 59.0.0

package/src/workflows/feature/tier.test.ts

@@ -1,166 +0,0 @@
-import { afterEach, describe, expect, it } from "vitest"
-import { installContext, type FlowContext } from "../../flows/index.js"
-import { fixtureContext } from "../shared/text.fixture.js"
-import { productionSignals, readRiskTier, recordRisk, riskTierOn } from "./tier.js"
-
-afterEach(() => installContext(undefined))
-
-const withVars = (vars: Record<string, string>) => installContext(fixtureContext({ vars }))
-
-describe("riskTierOn", () => {
-  it.each([
-    [{ flag_risk_tier: "1" }, true],
-    [{ flag_risk_tier: "0" }, false],
-    [{}, false],
-  ])("%j is %s", (vars, expected) => {
-    withVars(vars)
-    expect(riskTierOn()).toBe(expected)
-  })
-})
-
-describe("readRiskTier", () => {
-  const doc = (body: string) =>
-    `# Requirements\n\n## Risk Tier\n\n${body}\n\n## Answered Questions\n`
-
-  it.each(["low", "`low`", "**Low** — trivial copy", "LOW - copy", "_low_ — x"])(
-    "reads %j as low",
-    (body) => expect(readRiskTier(doc(body))).toBe("low"),
-  )
-
-  it.each(["high", "medium", "lower", "", "   \n\n"])("reads %j as high", (body) =>
-    expect(readRiskTier(doc(body))).toBe("high"),
-  )
-
-  it("reads a missing section and undefined as high", () => {
-    expect(readRiskTier("# Requirements\n\n## Other\n\nlow\n")).toBe("high")
-    expect(readRiskTier(undefined)).toBe("high")
-  })
-
-  it("takes the first non-blank line only and stops at the next section", () => {
-    expect(readRiskTier("## Risk Tier\n\nhigh — why\nlow\n")).toBe("high")
-    expect(readRiskTier("## Risk Tier\n\n## Other\n\nlow\n")).toBe("high")
-  })
-})
-
-describe("readRiskTier fences", () => {
-  it("ignores a backtick-fenced example above the real section", () => {
-    const text = "```\n## Risk Tier\n\nlow\n```\n\n## Risk Tier\n\nhigh\n"
-    expect(readRiskTier(text)).toBe("high")
-  })
-
-  it("reads a fenced example with no real section as high", () => {
-    expect(readRiskTier("```md\n## Risk Tier\n\nlow\n```\n")).toBe("high")
-  })
-
-  it("keeps the signals section open across a fence and skips fenced items", () => {
-    const signals = "## Production Signals\n- before\n```\n# x\n- fake\n```\n- after\n"
-    expect(productionSignals(signals)).toEqual(["before", "after"])
-  })
-
-  it("ignores a tilde-fenced example above the real section", () => {
-    const text = "~~~\n## Risk Tier\n\nlow\n~~~\n\n## Risk Tier\n\nhigh\n"
-    expect(readRiskTier(text)).toBe("high")
-  })
-
-  it("does not read a fence opener's info string as the tier", () => {
-    expect(readRiskTier("## Risk Tier\n\n```low\nhigh\n```\n")).toBe("high")
-    expect(readRiskTier("## Risk Tier\n\n~~~low\nlow\n~~~\n")).toBe("high")
-  })
-
-  it("fails closed on an unclosed fence before the real section", () => {
-    expect(readRiskTier("```\nstray\n\n## Risk Tier\n\nlow\n")).toBe("high")
-  })
-
-  it("does not close a 4-backtick fence with 3 backticks", () => {
-    const text = "````\n```\n## Risk Tier\n\nlow\n````\n"
-    expect(readRiskTier(text)).toBe("high")
-  })
-
-  it("does not open a fence on a backtick line indented 4 spaces", () => {
-    expect(readRiskTier("    ```\n## Risk Tier\n\nlow\n")).toBe("low")
-  })
-})
-
-describe("readRiskTier fence closers", () => {
-  it.each([
-    ["a tilde line does not close a backtick fence", "```\n~~~\n## Risk Tier\n\nlow\n```\n"],
-    ["a closer with an info string does not close", "```\n```js\n## Risk Tier\n\nlow\n```\n"],
-  ])("%s", (_, text) => {
-    expect(readRiskTier(text)).toBe("high")
-  })
-})
-
-describe("productionSignals", () => {
-  it("lists top-level items only, skipping blanks and indented lines", () => {
-    const text = `## Production Signals
-
-- error rate on /pay
-  not a signal
-  - nested detail
--
--    spaced   out\t signal
-* star item
-
-## Answered Questions
-
-- not a signal
-`
-    expect(productionSignals(text)).toEqual([
-      "error rate on /pay",
-      "spaced out signal",
-      "star item",
-    ])
-  })
-
-  it("skips a fenced Production Signals example", () => {
-    const text = "```\n## Production Signals\n- fake\n```\n\n## Production Signals\n- real\n"
-    expect(productionSignals(text)).toEqual(["real"])
-  })
-
-  it("drops control characters", () => {
-    expect(productionSignals("## Production Signals\n- a\u001bb\u0085c\n")).toEqual(["abc"])
-  })
-
-  it("is empty for a missing section or undefined", () => {
-    expect(productionSignals("## Risk Tier\nlow\n")).toEqual([])
-    expect(productionSignals(undefined)).toEqual([])
-  })
-})
-
-describe("recordRisk", () => {
-  const record = (requirements: string | undefined) => {
-    const marks: [string, string][] = []
-    installContext({
-      ...fixtureContext({ read: () => requirements }),
-      mark: (name: string, value: string) => marks.push([name, value]),
-    } as unknown as FlowContext)
-    return { tier: recordRisk(), marks }
-  }
-
-  it("marks the tier first, then one production-signal each", () => {
-    const { tier, marks } = record(
-      "## Risk Tier\nhigh — payments\n\n## Production Signals\n- a\n- b\n",
-    )
-    expect(tier).toBe("high")
-    expect(marks).toEqual([
-      ["risk-tier", "high"],
-      ["production-signal", "a"],
-      ["production-signal", "b"],
-    ])
-  })
-
-  it("marks risk-tier=low too", () => {
-    const { tier, marks } = record("## Risk Tier\nlow — copy\n\n## Production Signals\n- a\n")
-    expect(tier).toBe("low")
-    expect(marks).toEqual([
-      ["risk-tier", "low"],
-      ["production-signal", "a"],
-    ])
-  })
-
-  it("treats a missing file as high", () => {
-    const { tier, marks } = record(undefined)
-    expect(tier).toBe("high")
-    expect(marks).toEqual([["risk-tier", "high"]])
-  })
-})

package/src/workflows/feature/tier.ts

@@ -1,56 +0,0 @@
-import { mark, read, vars } from "../../flows/index.js"
-import { markFenced } from "../shared/fences.js"
-import { REQUIREMENTS } from "../shared/steps.js"
-
-export type RiskTier = "low" | "high"
-
-/** GTD_FLAG_RISK_TIER: pinned at process start, so a mid-process flip never moves a process. */
-export const riskTierOn = (): boolean => vars.flag_risk_tier === "1"
-
-const sectionLines = (
-  text: string | undefined,
-  title: string,
-): readonly { line: string; fenced: boolean }[] => {
-  if (text === undefined) return []
-  const heading = new RegExp(`^##[ \\t]+${title}[ \\t]*$`, "i")
-  // An unclosed fence hides the rest, so the tier reads `high` (fail-closed).
-  const lines = markFenced(text)
-  const start = lines.findIndex((l) => !l.fenced && heading.test(l.line))
-  if (start < 0) return []
-  const rest = lines.slice(start + 1)
-  const end = rest.findIndex((l) => !l.fenced && /^#{1,2}[ \t]/.test(l.line))
-  return end < 0 ? rest : rest.slice(0, end)
-}
-
-/** Anything but a legible `low` is `high`: under-tiering is the risky direction. */
-export const readRiskTier = (requirements: string | undefined): RiskTier => {
-  const first = sectionLines(requirements, "Risk Tier").find(
-    (l) => !l.fenced && l.line.trim() !== "",
-  )?.line
-  const word = first?.trim().split(/\s+/)[0]?.replace(/[`*_]/g, "").toLowerCase()
-  return word === "low" ? "low" : "high"
-}
-
-// eslint-disable-next-line no-control-regex -- the control range IS the point
-const CONTROL = /[\x00-\x1f\x7f-\x9f\u2028\u2029]/g
-
-const tidy = (text: string): string => text.replace(/\s+/g, " ").replace(CONTROL, "").trim()
-
-export const productionSignals = (requirements: string | undefined): readonly string[] => {
-  const items: string[] = []
-  for (const { line, fenced } of sectionLines(requirements, "Production Signals")) {
-    if (fenced) continue
-    const top = /^[-*+][ \t]+(.*)$/.exec(line)
-    if (top !== null) items.push(top[1]!)
-  }
-  return items.map(tidy).filter((item) => item !== "")
-}
-
-/** The tier is always marked, first, so the last `risk-tier` mark opens the current lap's marks. */
-export const recordRisk = (): RiskTier => {
-  const requirements = read(REQUIREMENTS)
-  const tier = readRiskTier(requirements)
-  mark("risk-tier", tier)
-  for (const signal of productionSignals(requirements)) mark("production-signal", signal)
-  return tier
-}

package/src/workflows/fix/fix-lens-origin.feature

@@ -1,114 +0,0 @@
-@inmem
-Feature: each finding at the finding gate names the lens that wrote it
-
-  Lenses append to `.gtd/QUALITY.md` in turn, so a finding belongs to the lens
-  whose turn added it — even when two lenses give findings the same title.
-
-  Background:
-    Given the shipped workflows, as gtd install scaffolds them
-    And an environment variable "GTD_QUALITYREVIEWS" set to "correctness,tests"
-    And a file "src/calc.ts" with:
-      """
-      export const add = (a: number, b: number) => a + b
-      """
-    And the working tree is committed as "feat: add calculator"
-    And a file ".gtd/REVIEW.orig.md" with:
-      """
-      # Review: abc1234
-
-      <!-- base: 0000000 -->
-
-      ## calc
-
-      - [ ] ./src/calc.ts#1-1
-        new add function
-      """
-    And a file ".gtd/REVIEW.md" with:
-      """
-      # Review: abc1234
-
-      <!-- base: 0000000 -->
-
-      ## calc
-
-      - [ ] ./src/calc.ts#1-1
-        new add function — rename it to sum
-      """
-    And the working tree is committed as "chore: hand off a review"
-    And step "notes.fixing" writes "src/calc.ts" with:
-      """
-      export const sum = (a: number, b: number) => a + b
-      """
-    And step "notes.closing" runs its script
-    And step "build.health.check" changes nothing
-    And step "build.quality.correctness.reviewing" writes ".gtd/QUALITY.md" with:
-      """
-      # Quality
-
-      ## sum is untested
-
-      From correctness.
-      """
-    And step "build.quality.tests.reviewing" writes ".gtd/QUALITY.md" with:
-      """
-      # Quality
-
-      ## sum is untested
-
-      From correctness.
-
-      ## sum is untested
-
-      From tests.
-      """
-    And step "build.quality.gating" runs its script
-    And step "build.quality.closing" runs its script
-    And step "build.review.reviewing" writes ".gtd/REVIEW.md" with:
-      """
-      # Review: abc1234
-
-      <!-- base: 0000000 -->
-
-      ## calc
-
-      - [ ] ./src/calc.ts#1-1
-        renamed to sum
-      """
-    And step "build.review.carrying" runs its script
-
-  Scenario: two lenses' findings with one title each name their own lens
-    Given judge step "build.quality.triage" answers:
-      """
-      [{"id":"Q1","answer":"design","p":0.9},{"id":"Q2","answer":"design","p":0.9}]
-      """
-    When gtd opens door "fix"
-    And the process is driven
-    Then the process rests at "build.quality.gate"
-    And ".gtd/QUALITY.md" contains:
-      """
-      ## sum is untested
-
-      _From lens correctness._
-
-      From correctness.
-
-      - [ ] fix
-
-      ## sum is untested
-
-      _From lens tests._
-
-      From tests.
-
-      - [ ] fix
-      """
-    When gtd lands
-    And the process is driven
-    Then the process rests at "build.review.await-review"
-    And ".gtd/REVIEW.md" contains:
-      """
-      Dropped at the finding gate:
-
-      - sum is untested (lens correctness)
-      - sum is untested (lens tests)
-      """

package/src/workflows/fix/fix-quality.feature

@@ -1,212 +0,0 @@
-@inmem
-Feature: fix's quality lap is triaged, and its leftovers are decided at the finding gate
-
-  A judge sorts the lap's findings: mechanical ones are fixed for up to three
-  turns, and the design ones — with whatever the fix turns left, and the
-  noise — wait at the finding gate, never at an escalation. A ticked one is
-  fixed on the spot; the hand-off review lists what became of each in its
-  summary and carries no finding on to the next `fix`. With no requirements
-  to check against, the `criteria-coverage` lens runs no turn.
-
-  Background:
-    Given the shipped workflows, as gtd install scaffolds them
-    And an environment variable "GTD_QUALITYREVIEWS" set to "criteria-coverage, correctness"
-    And a file "src/calc.ts" with:
-      """
-      export const add = (a: number, b: number) => a + b
-      """
-    And the working tree is committed as "feat: add calculator"
-    And a file ".gtd/REVIEW.orig.md" with:
-      """
-      # Review: abc1234
-
-      <!-- base: 0000000 -->
-
-      ## calc
-
-      - [ ] ./src/calc.ts#1-1
-        new add function
-      """
-    And a file ".gtd/REVIEW.md" with:
-      """
-      # Review: abc1234
-
-      <!-- base: 0000000 -->
-
-      ## calc
-
-      - [ ] ./src/calc.ts#1-1
-        new add function — rename it to sum
-      """
-    And the working tree is committed as "chore: hand off a review"
-    And step "notes.fixing" writes "src/calc.ts" with:
-      """
-      export const sum = (a: number, b: number) => a + b
-      """
-    And step "notes.closing" runs its script
-    And step "build.health.check" changes nothing
-    And step "build.quality.correctness.reviewing" writes ".gtd/QUALITY.md" with:
-      """
-      # Quality
-
-      ## sum has no negative test
-
-      Add a test summing negative numbers.
-
-      ## sum should be named plus
-
-      The glossary says plus.
-      """
-    And step "build.quality.sorting" runs its script
-    And step "build.quality.gating" runs its script
-    And step "build.quality.picking" runs its script
-    And step "build.quality.closing" runs its script
-    And step "build.review.reviewing" writes ".gtd/REVIEW.md" with:
-      """
-      # Review: abc1234
-
-      <!-- base: 0000000 -->
-
-      ## calc
-
-      - [ ] ./src/calc.ts#1-1
-        renamed to sum
-      """
-    And step "build.review.carrying" runs its script
-
-  Scenario: a design finding and one the fix cap left reach the finding gate, and a ticked one is fixed there
-    Given judge step "build.quality.triage" answers:
-      """
-      [{"id":"Q1","answer":"mechanical","p":0.9},{"id":"Q2","answer":"design","p":0.9}]
-      """
-    And step "build.fix.quality.fixing" changes nothing
-    When gtd opens door "fix"
-    And the process is driven
-    Then the process rests at "build.quality.gate"
-    And no commit body contains "build.health.describe"
-    And no commit body contains "build.quality.criteria-coverage"
-    And ".gtd/QUALITY.md" contains:
-      """
-      ## sum should be named plus
-
-      _From lens correctness._
-
-      The glossary says plus.
-
-      - [ ] fix
-
-      ## sum has no negative test
-
-      _From lens correctness. The fixer left it unresolved._
-
-      Add a test summing negative numbers.
-
-      - [ ] fix
-      """
-    Given a file ".gtd/QUALITY.md" with:
-      """
-      # Quality
-
-      ## sum should be named plus
-
-      The glossary says plus.
-
-      - [x] fix
-
-      ## sum has no negative test
-
-      Add a test summing negative numbers.
-
-      - [ ] fix
-      """
-    And step "build.fix.quality.fixing" is no longer scripted
-    And step "build.fix.quality.fixing" writes "src/calc.ts" with:
-      """
-      export const plus = (a: number, b: number) => a + b
-      """
-    And step "build.fix.quality.fixing" deletes ".gtd/QUALITY.md"
-    When gtd lands
-    And the process is driven
-    Then the process rests at "build.review.await-review"
-    And ".gtd/QUALITY.md" does not exist
-    And ".gtd/REVIEW.md" contains:
-      """
-      Fixed at the finding gate:
-
-      - sum should be named plus (
-      """
-    And ".gtd/REVIEW.md" contains:
-      """
-      Dropped at the finding gate:
-
-      - sum has no negative test (lens correctness)
-      """
-    And ".gtd/REVIEW.md" does not contain "Tick exactly one:"
-    And the commit subjects end with:
-      """
-      gtd(human): build.quality.gate → build.quality.picking
-      gtd(check): build.quality.picking → build.fix.quality.fixing
-      gtd(agent): build.fix.quality.fixing → build.health.check
-      gtd(check): build.health.check → build.review.reviewing
-      gtd(agent): build.review.reviewing → build.review.carrying
-      gtd(check): build.review.carrying → build.review.await-review
-      """
-
-  Scenario: a fixed finding and a noise one are listed in the review
-    Given judge step "build.quality.triage" answers:
-      """
-      [{"id":"Q1","answer":"mechanical","p":0.9},{"id":"Q2","answer":"noise","p":0.9}]
-      """
-    And step "build.fix.quality.fixing" writes "src/calc.test.ts" with:
-      """
-      it("sums negative numbers", () => {})
-      """
-    And step "build.fix.quality.fixing" deletes ".gtd/QUALITY.md"
-    And step "build.quality.gate" changes nothing
-    When gtd opens door "fix"
-    And the process is driven
-    Then the process rests at "build.review.await-review"
-    And ".gtd/REVIEW.md" contains "Fixed automatically:"
-    And ".gtd/REVIEW.md" contains "- sum has no negative test ("
-    And ".gtd/REVIEW.md" contains the short hash of the commit "gtd(agent): build.fix.quality.fixing → build.health.check"
-    And ".gtd/REVIEW.md" contains "- sum should be named plus (p=0.9, lens correctness)"
-
-  Scenario: a risk the hand-off reviewer marks is fixed and re-reviewed in its own draft, the summary added once
-    Given judge step "build.quality.triage" answers:
-      """
-      [{"id":"Q1","answer":"mechanical","p":0.9},{"id":"Q2","answer":"noise","p":0.9}]
-      """
-    And step "build.fix.quality.fixing" deletes ".gtd/QUALITY.md"
-    And step "build.quality.gate" changes nothing
-    And step "build.review.reviewing" is no longer scripted
-    And step "build.review.reviewing" writes ".gtd/REVIEW.md" with:
-      """
-      # Review: abc1234
-
-      <!-- base: 0000000 -->
-
-      ## calc
-
-      - [ ] ./src/calc.ts#1-1 — Risk: overflows on large numbers
-      """
-    When gtd opens door "fix"
-    And the process is driven
-    Then the process rests at "build.review.fix.risks.fixing"
-    And ".gtd/REVIEW.md" does not contain "## Quality lap"
-    Given step "build.review.reviewing" is no longer scripted
-    And step "build.review.reviewing" replaces the text "Risk: overflows on large numbers" in ".gtd/REVIEW.md" with "sum, now guarded"
-    And step "build.review.fix.risks.fixing" changes nothing
-    When the process is driven
-    Then the process rests at "build.review.await-review"
-    And ".gtd/REVIEW.md" contains "sum, now guarded"
-    And ".gtd/REVIEW.md" contains "## Quality lap" exactly once
-    And ".gtd/REVIEW.md" contains "## calc" exactly once
-    And the commit subjects end with:
-      """
-      gtd(check): build.quality.closing → build.review.reviewing
-      gtd(agent): build.review.reviewing → build.review.fix.risks.fixing
-      gtd(agent): build.review.fix.risks.fixing → build.health.check
-      gtd(check): build.health.check → build.review.reviewing
-      gtd(agent): build.review.reviewing → build.review.carrying
-      gtd(check): build.review.carrying → build.review.await-review
-      """

package/src/workflows/fix/fix.feature

@@ -1,79 +0,0 @@
-Feature: fix fixes the notes a hand-off leaves it
-
-  A hand-off is `.gtd/REVIEW.md` with the human's notes beside the reviewer's
-  own `.gtd/REVIEW.orig.md`; `gtd door fix` picks both up.
-
-  Background:
-    Given the shipped workflows, as gtd install scaffolds them
-    And an environment variable "GTD_QUALITYREVIEWS" set to ""
-    And a file "src/calc.ts" with:
-      """
-      export const add = (a: number, b: number) => a + b
-      """
-    And the working tree is committed as "feat: add calculator"
-
-  Scenario: a handed-off note is fixed, and both review files are removed
-    Given a file ".gtd/REVIEW.orig.md" with:
-      """
-      # Review: abc1234
-
-      <!-- base: 0000000 -->
-
-      ## calc
-
-      - [ ] ./src/calc.ts#1-1
-        new add function
-      """
-    And a file ".gtd/REVIEW.md" with:
-      """
-      # Review: abc1234
-
-      <!-- base: 0000000 -->
-
-      ## calc
-
-      - [ ] ./src/calc.ts#1-1
-        new add function — rename it to sum
-      """
-    And the working tree is committed as "chore: hand off a review"
-    And step "build.health.check" changes nothing
-    And step "build.review.reviewing" writes ".gtd/REVIEW.md" with:
-      """
-      # Review: abc1234
-
-      <!-- base: 0000000 -->
-
-      ## calc
-
-      - [ ] ./src/calc.ts#1-1
-        new add function
-      """
-    And step "notes.fixing" writes "src/calc.ts" with:
-      """
-      export const sum = (a: number, b: number) => a + b
-      """
-    And step "notes.closing" runs its script
-    When gtd opens door "fix"
-    Then the resting step's content contains "rename it to sum"
-    # The fix goes to its own review, which the scripted reviewer writes afresh.
-    When the process is driven
-    Then the process rests at "build.review.await-review"
-    And the commit subjects end with:
-      """
-      gtd(human): notes.fixing
-      gtd(agent): notes.fixing → notes.closing
-      gtd(check): notes.closing → build.health.check
-      gtd(check): build.health.check → build.review.reviewing
-      gtd(agent): build.review.reviewing → build.review.await-review
-      """
-    And ".gtd/REVIEW.orig.md" does not exist
-    And ".gtd/REVIEW.md" contains "new add function"
-    And "src/calc.ts" contains "sum"
-
-  Scenario: a reviewer's copy with no review is refused
-    Given a file ".gtd/REVIEW.orig.md" with:
-      """
-      # Review: abc1234
-      """
-    And the working tree is committed as "chore: stray copy"
-    Then opening door "fix" is refused with "has no .gtd/REVIEW.md"