@pmelab/gtd 58.2.0 → 59.0.0

package/src/workflows/feature/acceptance-criteria.feature

@@ -1,389 +0,0 @@
-@inmem
-Feature: acceptance criteria carry stable IDs, and a sketch that states clear ones skips design
-
-  `.gtd/REQUIREMENTS.md` lists the change's acceptance criteria as
-  `- AC-<n>: …` under `## Acceptance Criteria`. On the full path
-  `design.triage` writes them and the design gate settles them; a sketch
-  that already states its criteria under an `Acceptance criteria` heading
-  is judged at `design.clear`, and a `yes` records them as they are — no
-  triage, no design gate. After design they are frozen.
-
-  Background:
-    Given the shipped workflows, as gtd install scaffolds them
-    And an environment variable "GTD_QUALITYREVIEWS" set to ""
-    And an environment variable "GTD_FLAG_RISK_TIER" set to "0"
-    And a file "src/greeting.ts" with:
-      """
-      export const greeting = "Helo, world"
-      """
-    And the working tree is committed as "feat: add greeting"
-    And step "unwind" changes nothing
-    And step "start-gate.check" changes nothing
-
-  Rule: the full path
-
-    Background:
-      Given a file "TODO.md" with:
-        """
-        # Fix the typo
-
-        greeting says "Helo"; make it "Hello".
-        """
-
-    Scenario: [AC-6] triage writes ID'd criteria that reach the naive pass through the design gate
-      Given step "design.triage" writes ".gtd/REQUIREMENTS.md" with:
-        """
-        # Requirements
-
-        ## Impact
-
-        - the greeting module
-
-        ## Release Flag
-
-        new
-
-        ## Acceptance Criteria
-
-        - AC-1: `greeting` reads "Hello, world".
-        - AC-2: no other export changes.
-        """
-      And step "design.gate.answer" changes nothing
-      When the process is driven
-      Then the process rests at "seam.naive"
-      And ".gtd/REQUIREMENTS.md" contains "- AC-1: `greeting` reads \"Hello, world\"."
-      And ".gtd/REQUIREMENTS.md" contains "- AC-2: no other export changes."
-      And the resting step's content contains "maps where the change lands"
-      And the resting step's content contains "Acceptance Criteria"
-      And the commit subjects end with:
-        """
-        gtd(check): start-gate.check → design.triage
-        gtd(agent): design.triage → design.gate.answer
-        gtd(human): design.gate.answer → seam.naive
-        """
-
-    Scenario: a triage turn whose criteria carry no ID is refused
-      Given step "design.triage" writes ".gtd/REQUIREMENTS.md" with:
-        """
-        # Requirements
-
-        ## Impact
-
-        - the greeting module
-
-        ## Release Flag
-
-        new
-
-        ## Acceptance Criteria
-
-        - `greeting` reads "Hello, world".
-        """
-      Then driving the process is refused with "acceptance-criteria: .gtd/REQUIREMENTS.md has 1 criterion without an ID"
-
-    Scenario: a triage turn reusing an ID is refused
-      Given step "design.triage" writes ".gtd/REQUIREMENTS.md" with:
-        """
-        # Requirements
-
-        ## Impact
-
-        - the greeting module
-
-        ## Release Flag
-
-        new
-
-        ## Acceptance Criteria
-
-        - AC-1: `greeting` reads "Hello, world".
-        - AC-1: no other export changes.
-        """
-      Then driving the process is refused with "duplicate IDs: AC-1"
-
-    Scenario: an implementation turn that edits the settled criteria is refused
-      Given step "design.triage" writes ".gtd/REQUIREMENTS.md" with:
-        """
-        # Requirements
-
-        ## Impact
-
-        - the greeting module
-
-        ## Release Flag
-
-        new
-
-        ## Acceptance Criteria
-
-        - AC-1: `greeting` reads "Hello, world".
-        """
-      And step "design.gate.answer" changes nothing
-      And step "seam.naive" writes "src/acceptance.test.ts" with:
-        """
-        it("[AC-1] holds", () => {})
-        it("[AC-2] holds", () => {})
-        it("[AC-3] holds", () => {})
-        it("[AC-7] holds", () => {})
-        """
-      And step "seam.naive" writes "src/greeting.ts" with:
-        """
-        export const greeting = "Hello, world"
-        """
-      And step "seam.check" writes "src/acceptance.test.ts" with:
-        """
-        it("[AC-1] holds elsewhere", () => {})
-        """
-      And judge step "seam.judge" answers:
-        """
-        [{"id":"shape","answer":"land","p":0.9}]
-        """
-      And step "implement.applying" runs its script
-      And step "implement.building" writes ".gtd/REQUIREMENTS.md" with:
-        """
-        # Requirements
-
-        ## Impact
-
-        - the greeting module
-
-        ## Release Flag
-
-        new
-
-        ## Acceptance Criteria
-
-        - AC-1: `greeting` reads "Hi".
-        """
-      Then driving the process is refused with "criteria-frozen"
-
-  Rule: impact
-
-    Scenario: [AC-1] a triage turn with no Impact section is refused, naming it
-      Given a file "TODO.md" with:
-        """
-        # Fix the typo
-
-        greeting says "Helo"; make it "Hello".
-        """
-      And step "design.triage" writes ".gtd/REQUIREMENTS.md" with:
-        """
-        # Requirements
-
-        ## Release Flag
-
-        new
-
-        ## Acceptance Criteria
-
-        - AC-1: `greeting` reads "Hello, world".
-        """
-      Then driving the process is refused with "impact: .gtd/REQUIREMENTS.md has no \"## Impact\" section"
-
-    Scenario: [AC-9] a design.impact turn that changes the criteria is refused
-      Given a file "TODO.md" with:
-        """
-        # Fix the typo
-
-        ## Acceptance criteria
-
-        - `greeting` reads "Hello, world".
-        """
-      And judge step "design.clear" answers:
-        """
-        [{"id":"clear","answer":"yes","p":0.9}]
-        """
-      And step "design.normalise" runs its script
-      And step "design.impact" writes ".gtd/REQUIREMENTS.md" with:
-        """
-        # Requirements
-
-        ## Impact
-
-        - the greeting module
-
-        ## Release Flag
-
-        new
-
-        ## Acceptance Criteria
-
-        - AC-1: `greeting` reads "Hi".
-        """
-      Then driving the process is refused with "criteria-frozen"
-
-    Scenario: [AC-9] a design.impact turn that adds no Impact section is refused
-      Given a file "TODO.md" with:
-        """
-        # Fix the typo
-
-        ## Acceptance criteria
-
-        - `greeting` reads "Hello, world".
-        """
-      And judge step "design.clear" answers:
-        """
-        [{"id":"clear","answer":"yes","p":0.9}]
-        """
-      And step "design.normalise" runs its script
-      And step "design.impact" appends to ".gtd/REQUIREMENTS.md":
-        """
-        Touches the greeting module.
-        """
-      Then driving the process is refused with "impact: .gtd/REQUIREMENTS.md has no \"## Impact\" section"
-
-    Scenario: [AC-9] a design.impact turn that drops the sketch pointer is refused
-      Given a file "TODO.md" with:
-        """
-        # Fix the typo
-
-        ## Acceptance criteria
-
-        - `greeting` reads "Hello, world".
-        """
-      And judge step "design.clear" answers:
-        """
-        [{"id":"clear","answer":"yes","p":0.9}]
-        """
-      And step "design.normalise" runs its script
-      And step "design.impact" writes ".gtd/REQUIREMENTS.md" with:
-        """
-        # Requirements
-
-        ## Impact
-
-        - the greeting module
-
-        ## Release Flag
-
-        new
-
-        ## Acceptance Criteria
-
-        - AC-1: `greeting` reads "Hello, world".
-        """
-      Then driving the process is refused with "impact-only"
-
-  Rule: the skip path
-
-    Scenario: [AC-9] [AC-10] clear stated criteria are normalised into ID'd requirements with no triage and no design gate
-      Given a file "TODO.md" with:
-        """
-        # Fix the typo
-
-        ## Acceptance criteria
-
-        - [ ] `greeting` reads "Hello, world".
-        - [ ] no other export changes.
-        """
-      And judge step "design.clear" answers:
-        """
-        [{"id":"clear","answer":"yes","p":0.9}]
-        """
-      And step "design.normalise" runs its script
-      And step "design.impact" appends to ".gtd/REQUIREMENTS.md":
-        """
-        ## Impact
-
-        - the greeting module
-        """
-      When the process is driven
-      Then the process rests at "seam.naive"
-      And ".gtd/REQUIREMENTS.md" contains "- AC-1: `greeting` reads \"Hello, world\"."
-      And ".gtd/REQUIREMENTS.md" contains "- AC-2: no other export changes."
-      And ".gtd/REQUIREMENTS.md" contains "Stated in `TODO.md` by the sketch"
-      And the resting step's content contains "maps where the change lands"
-      And the commit subjects end with:
-        """
-        gtd(human): idle → unwind
-        gtd(check): unwind → start-gate.check
-        gtd(check): start-gate.check → design.clear
-        gtd(judge): design.clear → design.normalise
-        gtd(check): design.normalise → design.impact
-        gtd(agent): design.impact → seam.naive
-        """
-
-    Scenario: a fast-path process recorded before design.impact existed fails replay
-      Given a file "TODO.md" with:
-        """
-        # Fix the typo
-
-        ## Acceptance criteria
-
-        - `greeting` reads "Hello, world".
-        """
-      And judge step "design.clear" answers:
-        """
-        [{"id":"clear","answer":"yes","p":0.9}]
-        """
-      And step "design.normalise" runs its script
-      When the process is driven
-      Then the process rests at "design.impact"
-      Given the working tree is committed with the message:
-        """
-        gtd(agent): seam.naive → seam.check
-
-        Gtd-Step: seam.naive#1
-        Gtd-Format: 1
-        """
-      Then driving the process is refused with "the workflow changed under this process"
-
-    Scenario: IDs the sketch already gave its criteria are kept
-      Given a file "TODO.md" with:
-        """
-        ## Acceptance criteria
-
-        1. AC-3: `greeting` reads "Hello, world".
-        2. AC-7: no other export changes.
-        """
-      And judge step "design.clear" answers:
-        """
-        [{"id":"clear","answer":"yes","p":0.9}]
-        """
-      And step "design.normalise" runs its script
-      And step "design.impact" appends to ".gtd/REQUIREMENTS.md":
-        """
-        ## Impact
-
-        - the greeting module
-        """
-      When the process is driven
-      Then the process rests at "seam.naive"
-      And ".gtd/REQUIREMENTS.md" contains "- AC-3: `greeting` reads \"Hello, world\"."
-      And ".gtd/REQUIREMENTS.md" contains "- AC-7: no other export changes."
-
-    Scenario: one criterion the judge finds uncheckable falls back to the full path
-      Given a file "TODO.md" with:
-        """
-        # Fix the typo
-
-        ## Acceptance criteria
-
-        - `greeting` reads "Hello, world".
-        - the greeting feels friendlier.
-        """
-      And judge step "design.clear" answers:
-        """
-        [{"id":"clear","answer":"no","p":0.9}]
-        """
-      When the process is driven
-      Then the process rests at "design.triage"
-      And the commit subjects end with:
-        """
-        gtd(check): start-gate.check → design.clear
-        gtd(judge): design.clear → design.triage
-        """
-
-    Scenario: a sketch with no criteria heading goes straight to triage, unjudged
-      Given a file "TODO.md" with:
-        """
-        # Fix the typo
-
-        - `greeting` reads "Hello, world".
-        """
-      When the process is driven
-      Then the process rests at "design.triage"
-      And the commit subjects end with:
-        """
-        gtd(check): start-gate.check → design.triage
-        """

package/src/workflows/feature/criteria-coverage.feature

@@ -1,102 +0,0 @@
-@inmem
-Feature: the criteria-coverage lens checks the change's tests against its criteria
-
-  The `criteria-coverage` quality lens gets the requirements the change was
-  built to, quoted in its prompt, and writes one finding per acceptance
-  criterion no test exercises. Its findings are triaged like any other lens's.
-
-  Background:
-    Given the shipped workflows, as gtd install scaffolds them
-    And an environment variable "GTD_QUALITYREVIEWS" set to "criteria-coverage"
-    And a file "src/calc.ts" with:
-      """
-      export const add = (a: number, b: number) => a + b
-      """
-    And the working tree is committed as "feat: add calculator"
-    And a file "TODO.md" with:
-      """
-      # Add subtract
-
-      subtract(a, b) returns the difference.
-      """
-    And step "unwind" changes nothing
-    And step "start-gate.check" changes nothing
-    And step "design.triage" writes ".gtd/REQUIREMENTS.md" with:
-      """
-      # Requirements
-
-      ## Impact
-
-      - the calculator module
-
-      ## Acceptance Criteria
-
-      - AC-1: `subtract(5, 3)` returns 2.
-      - AC-2: `subtract(1, 3)` returns -2.
-      """
-    And step "design.gate.answer" changes nothing
-    And step "seam.naive" writes "src/calc.test.ts" with:
-      """
-      it("subtracts", () => expect(subtract(5, 3)).toBe(2))
-      """
-    And step "seam.naive" writes "src/calc.ts" with:
-      """
-      export const add = (a: number, b: number) => a + b
-      export const subtract = (a: number, b: number) => a - b
-      """
-    And step "seam.check" changes nothing
-    And step "implement.applying" runs its script
-    And step "implement.health.check" changes nothing
-    And step "implement.closing" runs its script
-
-  Scenario: the lens gets the closed requirements and its finding per uncovered criterion is fixed
-    When the process is driven
-    Then the process rests at "build.quality.criteria-coverage.reviewing"
-    And ".gtd/REQUIREMENTS.md" does not exist
-    And the resting step's content contains "  > - AC-1: `subtract(5, 3)` returns 2."
-    And the resting step's content contains "  > - AC-2: `subtract(1, 3)` returns -2."
-    And the resting step's content contains "one finding per criterion no test exercises"
-
-    Given step "build.quality.criteria-coverage.reviewing" writes ".gtd/QUALITY.md" with:
-      """
-      # Quality
-
-      ## AC-2 is not tested
-
-      No test subtracts a larger number.
-      """
-    And judge step "build.quality.triage" answers:
-      """
-      [{"id":"Q1","answer":"mechanical","p":0.9}]
-      """
-    And step "build.fix.quality.fixing" writes "src/calc.test.ts" with:
-      """
-      it("subtracts", () => expect(subtract(5, 3)).toBe(2))
-      it("subtracts a larger number", () => expect(subtract(1, 3)).toBe(-2))
-      """
-    And step "build.fix.quality.fixing" deletes ".gtd/QUALITY.md"
-    And step "build.health.check" changes nothing
-    And step "build.review.reviewing" writes ".gtd/REVIEW.md" with:
-      """
-      # Review: abc1234
-
-      <!-- base: 0000000 -->
-
-      ## Subtract
-
-      - [ ] ./src/calc.ts#2-2 — subtract(a, b)
-      """
-    And step "build.review.carrying" runs its script
-    When the process is driven
-    Then the process rests at "build.review.await-review"
-    And ".gtd/REVIEW.md" contains "- AC-2 is not tested ("
-    And the commit subjects end with:
-      """
-      gtd(check): implement.closing → build.quality.criteria-coverage.reviewing
-      gtd(agent): build.quality.criteria-coverage.reviewing → build.quality.triage
-      gtd(judge): build.quality.triage → build.fix.quality.fixing
-      gtd(agent): build.fix.quality.fixing → build.health.check
-      gtd(check): build.health.check → build.review.reviewing
-      gtd(agent): build.review.reviewing → build.review.carrying
-      gtd(check): build.review.carrying → build.review.await-review
-      """

package/src/workflows/feature/criteria.test.ts

@@ -1,147 +0,0 @@
-import { describe, expect, it } from "vitest"
-import type { Change } from "../../flows/index.js"
-import { criteriaOf, criterionIds, hasImpact, statedCriteria, unstableIds } from "./criteria.js"
-
-const added = (path: string, after: string): Change => ({
-  path,
-  status: "added",
-  before: undefined,
-  after,
-})
-
-describe("criteriaOf", () => {
-  it("reads ID'd items, joining wrapped lines, and stops at the next section", () => {
-    expect(
-      criteriaOf(
-        "# R\n\n## Acceptance Criteria\n\n- AC-1: one\n  continued\n- two\n\n## Notes\n\n- AC-9: not one\n",
-      ),
-    ).toEqual([
-      { id: "AC-1", text: "one continued" },
-      { id: "", text: "two" },
-    ])
-  })
-
-  it("skips fenced lines, reads an indented item, and stops at a subheading", () => {
-    expect(
-      criteriaOf(
-        "## Acceptance Criteria\n\n- AC-1: runs\n\n```sh\n# setup\n- key: v\n```\n - AC-2: two\n\n### Notes\n\n- note\n",
-      ),
-    ).toEqual([
-      { id: "AC-1", text: "runs" },
-      { id: "AC-2", text: "two" },
-    ])
-  })
-
-  it("reads only the level-2 section and joins an unindented wrapped line", () => {
-    expect(
-      criteriaOf(
-        "### Acceptance criteria\n\n- x\n\n## Acceptance Criteria\n\n- AC-1: exits 2 when the config\nfile is missing\n",
-      ),
-    ).toEqual([{ id: "AC-1", text: "exits 2 when the config file is missing" }])
-  })
-
-  it("folds a nested sub-bullet into its criterion", () => {
-    expect(
-      criteriaOf(
-        "## Acceptance Criteria\n\n- AC-1: exits 2 when config is bad\n  - missing file\n",
-      ),
-    ).toEqual([{ id: "AC-1", text: "exits 2 when config is bad - missing file" }])
-  })
-
-  it("is undefined without the section", () => {
-    expect(criteriaOf("# R\n\n- AC-1: x\n")).toBeUndefined()
-  })
-})
-
-describe("statedCriteria", () => {
-  it("numbers a stated checklist from AC-1", () => {
-    const sketch = [added("TODO.md", "# T\n\n### Acceptance criteria:\n\n- [ ] a\n* b\n\nprose\n")]
-    expect(statedCriteria(sketch, "abc")).toMatchObject({
-      path: "TODO.md",
-      commit: "abc",
-      criteria: [
-        { id: "AC-1", text: "a" },
-        { id: "AC-2", text: "b" },
-      ],
-    })
-  })
-
-  it("renumbers when the stated IDs are partial or clash", () => {
-    const sketch = [added("TODO.md", "## Acceptance criteria\n\n- AC-4: a\n- b\n")]
-    expect(statedCriteria(sketch, "abc")?.criteria).toEqual([
-      { id: "AC-1", text: "a" },
-      { id: "AC-2", text: "b" },
-    ])
-  })
-
-  it("ignores a list the sketch left unchanged, a file other than TODO.md, a sketch with more in it, and an ambiguous pair", () => {
-    const list = "## Acceptance criteria\n\n- a\n"
-    expect(
-      statedCriteria(
-        [{ path: "TODO.md", status: "modified", before: list, after: `${list}\nmore\n` }],
-        "abc",
-      ),
-    ).toBeUndefined()
-    expect(
-      statedCriteria(
-        [
-          {
-            path: "TODO.md",
-            status: "modified",
-            before: `${list}- \n`,
-            after: `${list}- \n\nmore\n`,
-          },
-        ],
-        "abc",
-      ),
-    ).toBeUndefined()
-    expect(statedCriteria([added("docs/guide.md", list)], "abc")).toBeUndefined()
-    expect(
-      statedCriteria([added("TODO.md", list), added("src/a.ts", "x\n")], "abc"),
-    ).toBeUndefined()
-    expect(
-      statedCriteria([added("TODO.md", list), added(".gtd/TODO.md", list)], "abc"),
-    ).toBeUndefined()
-  })
-})
-
-describe("criterionIds", () => {
-  const requirements = "## Acceptance Criteria\n\n- AC-1: a\n- AC-2: b\n- AC-4: added\n- unnamed\n"
-
-  it("lists every ID'd criterion", () => {
-    expect(criterionIds(requirements)).toEqual(["AC-1", "AC-2", "AC-4"])
-  })
-})
-
-describe("unstableIds", () => {
-  const ids = { closed: ["AC-1", "AC-3"], used: ["AC-1", "AC-2", "AC-3"] }
-
-  it("accepts built IDs kept or dropped and new ones numbered above all handed out", () => {
-    expect(unstableIds(["AC-3", "AC-4", "AC-7"], ids)).toBeUndefined()
-    expect(unstableIds([], ids)).toBeUndefined()
-  })
-
-  it("names a new ID that reuses a number handed out before, even a narrowed-away one", () => {
-    expect(unstableIds(["AC-1", "AC-2", "AC-3"], ids)).toMatch(
-      /^numbers AC-2 at or below AC-3, .* from AC-4$/,
-    )
-  })
-
-  it("names every reused ID", () => {
-    expect(unstableIds(["AC-0", "AC-2"], ids)).toMatch(/^numbers AC-0, AC-2 at or below AC-3/)
-  })
-})
-
-describe("hasImpact", () => {
-  it.each([
-    ["a level-2 heading", "# R\n\n## Impact\n\nx\n", true],
-    ["a mixed-case heading", "## impact\n", true],
-    ["a level-3 heading", "### Impact\n", false],
-    ["a level-1 heading", "# Impact\n", false],
-    ["a longer heading", "## Impactful\n", false],
-    ["a fenced heading", "```md\n## Impact\n```\n", false],
-    ["no heading", "# R\n\nImpact\n", false],
-  ])("%s", (_name, text, expected) => {
-    expect(hasImpact(text)).toBe(expected)
-  })
-})