@pmelab/gtd 58.2.0 → 59.0.0

package/src/workflows/feature/refactor-first.feature

@@ -1,158 +0,0 @@
-# One SDLC path per file, so a changed path reds exactly one fixture — do not merge.
-@inmem
-Feature: a refactor-first judgment walks one fixed path to the review gate
-
-  With GTD_FLAG_RISK_TIER off, a naive pass touching
-  an existing non-allowlisted file is ruled refactor-first, is refactored and
-  that refactor reviewed, and only then implemented and brought to the feature review. The flags are
-  pinned so the per-flag test runs never move it off its path.
-
-  Background:
-    Given the shipped workflows, as gtd install scaffolds them
-    And an environment variable "GTD_QUALITYREVIEWS" set to ""
-    And an environment variable "GTD_REFACTORQUALITYREVIEWS" set to ""
-    And an environment variable "GTD_FLAG_RISK_TIER" set to "0"
-    And a file "src/calc.ts" with:
-      """
-      export const add = (a: number, b: number) => a + b
-      """
-    And the working tree is committed as "feat: add calculator"
-    And a file "TODO.md" with:
-      """
-      # Add subtract
-
-      subtract(a, b) returns the difference.
-      """
-    And step "unwind" changes nothing
-    And step "start-gate.check" changes nothing
-    And step "design.triage" writes ".gtd/REQUIREMENTS.md" with:
-      """
-      # Requirements
-
-      ## Concerns
-
-      ### Subtract
-
-      - `subtract(a, b)` returns `a - b`.
-
-      ## Impact
-
-      - the greeting module
-
-      ## Release Flag
-
-      new
-
-      ## Acceptance Criteria
-
-      - AC-1: the change behaves as described.
-      """
-    And step "design.gate.answer" changes nothing
-
-  Scenario: a refactor-first judgment runs refactor, its review, implement and the quality lap to the feature review
-    Given step "seam.check" changes nothing
-    And step "seam.naive" writes "src/acceptance.test.ts" with:
-      """
-      it("[AC-1] holds", () => {})
-      """
-    And step "seam.naive" writes "src/calc.ts" with:
-      """
-      export const add = (a: number, b: number) => a + b
-      export const subtract = (a: number, b: number) => a - b
-      """
-    And judge step "seam.judge" answers:
-      """
-      [{"id":"shape","answer":"refactor-first","p":0.9}]
-      """
-    And step "seam.note" writes ".gtd/REFACTOR-NOTE.md" with:
-      """
-      Seam: the existing code the strays touch.
-      """
-    And step "refactor.deriving" runs its script
-    When the process is driven
-    Then the process rests at "refactor.building"
-    And ".gtd/REFACTOR.md" contains "calc.ts`"
-
-    Given step "refactor.building" writes "src/calc.ts" with:
-      """
-      export const op = (a: number, b: number, sign: number) => a + sign * b
-      export const add = (a: number, b: number) => op(a, b, 1)
-      """
-    And step "refactor.health.check" changes nothing
-    And step "refactor.closing" runs its script
-    And step "refactor.build.review.carrying" runs its script
-    And step "refactor.build.review.reviewing" writes ".gtd/REVIEW.md" with:
-      """
-      # Review: abc1234
-
-      <!-- base: 0000000 -->
-
-      ## calc
-
-      - [ ] ./src/calc.ts#1-2
-        add built on the shared op
-      """
-    And step "refactor.build.review.closing" runs its script
-    When the process is driven
-    Then the process rests at "refactor.build.review.await-review"
-    And ".gtd/REFACTOR.md" does not exist
-
-    Given a file ".gtd/REVIEW.md" with:
-      """
-      # Review: abc1234
-
-      <!-- base: 0000000 -->
-
-      ## calc
-
-      - [x] ./src/calc.ts#1-2
-        add built on the shared op
-      """
-    When gtd lands
-    And the process is driven
-    Then the process rests at "implement.building"
-    And "src/calc.ts" contains "op(a, b, 1)"
-
-    Given step "implement.building" writes "src/calc.ts" with:
-      """
-      export const op = (a: number, b: number, sign: number) => a + sign * b
-      export const add = (a: number, b: number) => op(a, b, 1)
-      export const subtract = (a: number, b: number) => op(a, b, -1)
-      """
-    And step "implement.building" writes "src/acceptance.test.ts" with:
-      """
-      it("[AC-1] holds", () => {})
-      """
-    And step "implement.health.check" changes nothing
-    And step "implement.closing" runs its script
-    When the process is driven
-    Then the process rests at "build.review.reviewing"
-    And "src/calc.ts" contains "op(a, b, 1)"
-    And "src/calc.ts" contains "subtract"
-    And the commit subjects end with:
-      """
-      gtd(human): idle → unwind
-      gtd(check): unwind → start-gate.check
-      gtd(check): start-gate.check → design.triage
-      gtd(agent): design.triage → design.gate.answer
-      gtd(human): design.gate.answer → seam.naive
-      gtd(agent): seam.naive → seam.check
-      gtd(check): seam.check → seam.judge
-      gtd(judge): seam.judge → seam.note
-      gtd(agent): seam.note → refactor.deriving
-      gtd(check): refactor.deriving → refactor.building
-      gtd(agent): refactor.building → refactor.health.check
-      gtd(check): refactor.health.check → refactor.closing
-      gtd(check): refactor.closing → refactor.build.review.reviewing
-      gtd(agent): refactor.build.review.reviewing → refactor.build.review.await-review
-      gtd(human): refactor.build.review.await-review → refactor.build.review.closing
-      gtd(check): refactor.build.review.closing → implement.building
-      gtd(agent): implement.building → implement.health.check
-      gtd(check): implement.health.check → implement.closing
-      gtd(check): implement.closing → build.review.reviewing
-      """
-    And the commit "gtd(human): idle → unwind" has a body containing "Gtd-Var: flag_risk_tier=0"
-    And the commit "gtd(agent): seam.naive → seam.check" has a body containing "Gtd-Kept:"
-    And the commit "gtd(judge): seam.judge → seam.note" has a body containing "\"answer\":\"refactor-first\""
-    And no commit body contains "Gtd-Approved:"
-    And no commit body contains "Gtd-Workflow:"

package/src/workflows/feature/refactor-lens-models.feature

@@ -1,79 +0,0 @@
-@inmem
-Feature: the refactor review's lenses take their model hints from refactorQualityReviews alone
-
-  Background:
-    Given the shipped workflows, as gtd install scaffolds them
-    And an environment variable "GTD_QUALITYREVIEWS" set to "correctness=base"
-    And an environment variable "GTD_REFACTORQUALITYREVIEWS" set to "correctness, conventions=opus"
-    And an environment variable "GTD_FLAG_RISK_TIER" set to "0"
-    And a file "src/calc.ts" with:
-      """
-      export const add = (a: number, b: number) => a + b
-      """
-    And the working tree is committed as "feat: add calculator"
-    And a file "TODO.md" with:
-      """
-      # Add subtract
-
-      subtract(a, b) returns the difference.
-      """
-    And step "unwind" changes nothing
-    And step "start-gate.check" changes nothing
-    And step "design.triage" writes ".gtd/REQUIREMENTS.md" with:
-      """
-      # Requirements
-
-      ## Concerns
-
-      ### Subtract
-
-      - `subtract(a, b)` returns `a - b`.
-
-      ## Impact
-
-      - the greeting module
-
-      ## Release Flag
-
-      new
-
-      ## Acceptance Criteria
-
-      - AC-1: the change behaves as described.
-      """
-    And step "design.gate.answer" changes nothing
-
-  Scenario: a refactor lens runs on its refactorQualityReviews hint, else its default
-    Given step "seam.check" changes nothing
-    And step "seam.naive" writes "src/acceptance.test.ts" with:
-      """
-      it("[AC-1] holds", () => {})
-      """
-    And step "seam.naive" writes "src/calc.ts" with:
-      """
-      export const add = (a: number, b: number) => a + b
-      export const subtract = (a: number, b: number) => a - b
-      """
-    And judge step "seam.judge" answers:
-      """
-      [{"id":"shape","answer":"refactor-first","p":0.9}]
-      """
-    And step "seam.note" writes ".gtd/REFACTOR-NOTE.md" with:
-      """
-      Seam: the existing code the strays touch.
-      """
-    And step "refactor.deriving" runs its script
-    And step "refactor.building" writes "src/calc.ts" with:
-      """
-      export const op = (a: number, b: number, sign: number) => a + sign * b
-      export const add = (a: number, b: number) => op(a, b, 1)
-      """
-    And step "refactor.health.check" changes nothing
-    And step "refactor.closing" runs its script
-    When the process is driven
-    Then the process rests at "refactor.build.quality.correctness.reviewing"
-    And the output of gtd "next --json" contains "\"model\":\"smart\""
-    Given step "refactor.build.quality.correctness.reviewing" changes nothing
-    When the process is driven
-    Then the process rests at "refactor.build.quality.conventions.reviewing"
-    And the output of gtd "next --json" contains "\"model\":\"opus\""

package/src/workflows/feature/refactor-rebuild.feature

@@ -1,273 +0,0 @@
-# One SDLC path per file, so a changed path reds exactly one fixture — do not merge.
-@inmem
-Feature: refactor-first writes a refactor note, refactors on its own, then rebuilds
-
-  On a refactor-first judgment the naive pass is never applied. `seam.note`
-  reads the whole naive diff and writes `.gtd/REFACTOR-NOTE.md`; the refactor
-  lands on its own with the existing suite green; the rebuild re-implements the
-  change on the refactored base, is asked to carry over every test file the
-  naive pass added or changed, and lands once the suite is green. The note
-  reaches both turns.
-
-  Background:
-    Given the shipped workflows, as gtd install scaffolds them
-    And an environment variable "GTD_QUALITYREVIEWS" set to ""
-    And an environment variable "GTD_REFACTORQUALITYREVIEWS" set to ""
-    And an environment variable "GTD_FLAG_RISK_TIER" set to "0"
-    And a file "src/calc.ts" with:
-      """
-      export const add = (a: number, b: number) => a + b
-      """
-    And a file "src/calc.test.ts" with:
-      """
-      it("adds", () => {})
-      """
-    And the working tree is committed as "feat: add calculator"
-    And a file "TODO.md" with:
-      """
-      # Add subtract
-
-      subtract(a, b) returns the difference.
-      """
-    And step "unwind" changes nothing
-    And step "start-gate.check" changes nothing
-    And step "design.triage" writes ".gtd/REQUIREMENTS.md" with:
-      """
-      # Requirements
-
-      ## Concerns
-
-      ### Subtract
-
-      - `subtract(a, b)` returns `a - b`.
-
-      ## Impact
-
-      - the greeting module
-
-      ## Release Flag
-
-      new
-
-      ## Acceptance Criteria
-
-      - AC-1: subtract returns the difference.
-      """
-    And step "design.gate.answer" changes nothing
-    And step "seam.check" changes nothing
-    And step "seam.naive" writes "src/acceptance.test.ts" with:
-      """
-      it("subtracts", () => {})
-      """
-    And step "seam.naive" writes "src/calc.test.ts" with:
-      """
-      it("adds", () => {})
-      it("subtracts a larger number", () => {})
-      """
-    And step "seam.naive" writes "src/calc.ts" with:
-      """
-      export const add = (a: number, b: number) => a + b
-      export const subtract = (a: number, b: number) => a - b
-      """
-    And judge step "seam.judge" answers:
-      """
-      [{"id":"shape","answer":"refactor-first","p":0.9}]
-      """
-
-  Scenario: the refactor note reaches the refactor turn and the rebuild turn
-    When the process is driven
-    Then the process rests at "seam.note"
-    And the resting step's content contains "git show"
-    And the resting step's content contains ".gtd/REFACTOR-NOTE.md"
-    And "src/calc.ts" does not contain "subtract"
-
-    Given step "seam.note" writes ".gtd/REFACTOR-NOTE.md" with:
-      """
-      # Refactor note
-
-      Seam: route add through a shared `op(a, b, sign)` in src/calc.ts.
-      """
-    And step "refactor.deriving" runs its script
-    When the process is driven
-    Then the process rests at "refactor.building"
-    And ".gtd/REFACTOR.md" contains "## Refactor note"
-    And ".gtd/REFACTOR.md" contains "shared `op(a, b, sign)`"
-    And the resting step's content contains "Refactor note"
-
-    Given step "refactor.building" writes "src/calc.ts" with:
-      """
-      export const op = (a: number, b: number, sign: number) => a + sign * b
-      export const add = (a: number, b: number) => op(a, b, 1)
-      """
-    And step "refactor.health.check" changes nothing
-    And step "refactor.closing" runs its script
-    And step "refactor.build.review.carrying" runs its script
-    And step "refactor.build.review.reviewing" writes ".gtd/REVIEW.md" with:
-      """
-      # Review: abc1234
-
-      <!-- base: 0000000 -->
-
-      ## calc
-
-      - [ ] ./src/calc.ts#1-2
-        add built on the shared op
-      """
-    And step "refactor.build.review.closing" runs its script
-    When the process is driven
-    Then the process rests at "refactor.build.review.await-review"
-
-    Given a file ".gtd/REVIEW.md" with:
-      """
-      # Review: abc1234
-
-      <!-- base: 0000000 -->
-
-      ## calc
-
-      - [x] ./src/calc.ts#1-2
-        add built on the shared op
-      """
-    When gtd lands
-    And the process is driven
-    Then the process rests at "implement.building"
-    And the resting step's content contains "shared `op(a, b, sign)`"
-    And the resting step's content contains "Carry over the naive pass's acceptance tests"
-    And the resting step's content contains "'src/acceptance.test.ts' 'src/calc.test.ts'"
-
-  Scenario: a note turn that changes anything but the note is refused
-    Given step "seam.note" writes "src/calc.ts" with:
-      """
-      export const sub = 1
-      """
-    Then driving the process is refused with "refactor-note"
-
-  Scenario: the refactor lands on its own only with the existing suite green
-    Given step "seam.note" writes ".gtd/REFACTOR-NOTE.md" with:
-      """
-      Seam: a shared `op` in src/calc.ts.
-      """
-    And step "refactor.deriving" runs its script
-    And step "refactor.building" writes "src/calc.ts" with:
-      """
-      export const op = (a: number, b: number, sign: number) => a + sign * b
-      export const add = (a: number, b: number) => op(a, b, -1)
-      """
-    And step "refactor.health.check" writes ".gtd/FEEDBACK.md" with:
-      """
-      FAIL add(1, 2) returned -1
-      """
-    When the process is driven
-    Then the process rests at "refactor.fix.suite.fixing"
-
-    Given step "refactor.fix.suite.fixing" writes "src/calc.ts" with:
-      """
-      export const op = (a: number, b: number, sign: number) => a + sign * b
-      export const add = (a: number, b: number) => op(a, b, 1)
-      """
-    And step "refactor.health.check" changes nothing
-    And step "refactor.closing" runs its script
-    And step "refactor.build.review.carrying" runs its script
-    And step "refactor.build.review.reviewing" writes ".gtd/REVIEW.md" with:
-      """
-      # Review: abc1234
-
-      <!-- base: 0000000 -->
-
-      ## calc
-
-      - [ ] ./src/calc.ts#1-2
-        add built on the shared op
-      """
-    And step "refactor.build.review.closing" runs its script
-    When the process is driven
-    Then the process rests at "refactor.build.review.await-review"
-
-    Given a file ".gtd/REVIEW.md" with:
-      """
-      # Review: abc1234
-
-      <!-- base: 0000000 -->
-
-      ## calc
-
-      - [x] ./src/calc.ts#1-2
-        add built on the shared op
-      """
-    When gtd lands
-    And the process is driven
-    Then the process rests at "implement.building"
-    And "src/calc.ts" contains "op(a, b, 1)"
-    And "src/calc.ts" does not contain "subtract"
-
-  Scenario: the rebuild lands once green, whichever tests it carried
-    Given step "seam.note" writes ".gtd/REFACTOR-NOTE.md" with:
-      """
-      Seam: a shared `op` in src/calc.ts.
-      """
-    And step "refactor.deriving" runs its script
-    And step "refactor.building" writes "src/calc.ts" with:
-      """
-      export const op = (a: number, b: number, sign: number) => a + sign * b
-      export const add = (a: number, b: number) => op(a, b, 1)
-      """
-    And step "refactor.health.check" changes nothing
-    And step "refactor.closing" runs its script
-    And step "refactor.build.review.carrying" runs its script
-    And step "refactor.build.review.reviewing" writes ".gtd/REVIEW.md" with:
-      """
-      # Review: abc1234
-
-      <!-- base: 0000000 -->
-
-      ## calc
-
-      - [ ] ./src/calc.ts#1-2
-        add built on the shared op
-      """
-    And step "refactor.build.review.closing" runs its script
-    When the process is driven
-    Then the process rests at "refactor.build.review.await-review"
-
-    Given a file ".gtd/REVIEW.md" with:
-      """
-      # Review: abc1234
-
-      <!-- base: 0000000 -->
-
-      ## calc
-
-      - [x] ./src/calc.ts#1-2
-        add built on the shared op
-      """
-    When gtd lands
-    And the process is driven
-    Then the process rests at "implement.building"
-
-    Given step "implement.building" writes "src/calc.ts" with:
-      """
-      export const op = (a: number, b: number, sign: number) => a + sign * b
-      export const add = (a: number, b: number) => op(a, b, 1)
-      export const subtract = (a: number, b: number) => op(a, b, -1)
-      """
-    And step "implement.health.check" changes nothing
-    And step "implement.closing" runs its script
-    When the process is driven
-    Then the process rests at "build.review.reviewing"
-    And "src/calc.ts" contains "op(a, b, -1)"
-    And ".gtd/REFACTOR-NOTE.md" does not exist
-    And the commit subjects end with:
-      """
-      gtd(judge): seam.judge → seam.note
-      gtd(agent): seam.note → refactor.deriving
-      gtd(check): refactor.deriving → refactor.building
-      gtd(agent): refactor.building → refactor.health.check
-      gtd(check): refactor.health.check → refactor.closing
-      gtd(check): refactor.closing → refactor.build.review.reviewing
-      gtd(agent): refactor.build.review.reviewing → refactor.build.review.await-review
-      gtd(human): refactor.build.review.await-review → refactor.build.review.closing
-      gtd(check): refactor.build.review.closing → implement.building
-      gtd(agent): implement.building → implement.health.check
-      gtd(check): implement.health.check → implement.closing
-      gtd(check): implement.closing → build.review.reviewing
-      """