@pennyfarthing/core 10.1.0 → 10.2.0

package/pennyfarthing_scripts/tests/test_story_update.py

@@ -14,12 +14,10 @@ Acceptance Criteria:
 """
 
 from pathlib import Path
-from typing import Any
 from unittest.mock import patch
 
 import pytest
 from click.testing import CliRunner
-from ruamel.yaml.comments import CommentedMap
 
 from pennyfarthing_scripts.sprint.story_update import (
     update_story,
@@ -28,7 +26,6 @@ from pennyfarthing_scripts.sprint.yaml_io import (
     read_sprint,
 )
 
-
 # =============================================================================
 # Test Fixtures
 # =============================================================================
@@ -275,8 +272,6 @@ class TestUpdateStoryFields:
 
     def test_no_updates_provided(self, sprint_file: Path) -> None:
         """Calling with no field updates should succeed as a noop."""
-        original_content = sprint_file.read_text()
-
         result = update_story(
             sprint_path=sprint_file,
             story_id="76-3",
@@ -378,8 +373,8 @@ class TestFindStoryAcrossEpics:
 class TestAutoCleanup:
     """Auto-cleanup rules for status transitions."""
 
-    def test_done_removes_assigned_to(self, assigned_story_file: Path) -> None:
-        """Setting status=done should remove assigned_to."""
+    def test_done_preserves_assigned_to(self, assigned_story_file: Path) -> None:
+        """Setting status=done should preserve assigned_to (no auto-removal)."""
         result = update_story(
             sprint_path=assigned_story_file,
             story_id="76-1",
@@ -390,7 +385,7 @@ class TestAutoCleanup:
 
         data = read_sprint(assigned_story_file)
         story = data["epics"][0]["stories"][0]
-        assert "assigned_to" not in story
+        assert story["assigned_to"] == "kavery"
 
     def test_done_auto_sets_completed(self, assigned_story_file: Path) -> None:
         """Setting status=done should auto-set completed to today."""
@@ -611,10 +606,10 @@ class TestCLIIntegration:
 
     def test_update_command_exists(self) -> None:
         """story_update_command should be importable and be a Click command."""
-        from pennyfarthing_scripts.sprint.story_update import story_update_command
-
         import click
 
+        from pennyfarthing_scripts.sprint.story_update import story_update_command
+
         assert isinstance(story_update_command, click.BaseCommand)
 
     def test_basic_update_via_cli(self, runner: CliRunner, sprint_file: Path) -> None:

package/pennyfarthing_scripts/tests/test_tiers.py

@@ -12,11 +12,11 @@ Acceptance Criteria:
 - AC6: Token reduction verified: REFRESH ~600, HANDOFF ~700, MINIMAL ~200
 """
 
-import pytest
 from pathlib import Path
-from unittest.mock import patch, MagicMock
-import yaml
+from unittest.mock import patch
 
+import pytest
+import yaml
 
 # =============================================================================
 # AC1: --tier CLI Argument Tests
@@ -314,10 +314,9 @@ class TestCompressedPersonaFormat:
 
     def test_compressed_persona_has_xml_structure(self, tmp_path: Path) -> None:
         """Test compressed persona uses XML format."""
-        from pennyfarthing_scripts.prime.persona import format_persona_compressed
-
         # Import will fail until function is implemented
         from pennyfarthing_scripts.prime.models import Persona
+        from pennyfarthing_scripts.prime.persona import format_persona_compressed
 
         persona = Persona(
             character="Rosie the Riveter",
@@ -334,8 +333,8 @@ class TestCompressedPersonaFormat:
 
     def test_compressed_persona_includes_voice(self, tmp_path: Path) -> None:
         """Test compressed persona includes voice element."""
-        from pennyfarthing_scripts.prime.persona import format_persona_compressed
         from pennyfarthing_scripts.prime.models import Persona
+        from pennyfarthing_scripts.prime.persona import format_persona_compressed
 
         persona = Persona(
             character="Rosie the Riveter",
@@ -350,8 +349,8 @@ class TestCompressedPersonaFormat:
 
     def test_compressed_persona_includes_style(self, tmp_path: Path) -> None:
         """Test compressed persona includes style element."""
-        from pennyfarthing_scripts.prime.persona import format_persona_compressed
         from pennyfarthing_scripts.prime.models import Persona
+        from pennyfarthing_scripts.prime.persona import format_persona_compressed
 
         persona = Persona(
             character="Rosie the Riveter",
@@ -365,8 +364,8 @@ class TestCompressedPersonaFormat:
 
     def test_compressed_persona_includes_catchphrase_if_present(self, tmp_path: Path) -> None:
         """Test compressed persona includes catchphrase from quote."""
-        from pennyfarthing_scripts.prime.persona import format_persona_compressed
         from pennyfarthing_scripts.prime.models import Persona
+        from pennyfarthing_scripts.prime.persona import format_persona_compressed
 
         persona = Persona(
             character="Rosie the Riveter",
@@ -382,8 +381,8 @@ class TestCompressedPersonaFormat:
 
     def test_compressed_persona_token_count(self, tmp_path: Path) -> None:
         """Test compressed persona is approximately 100 tokens (~400 chars)."""
-        from pennyfarthing_scripts.prime.persona import format_persona_compressed
         from pennyfarthing_scripts.prime.models import Persona
+        from pennyfarthing_scripts.prime.persona import format_persona_compressed
 
         persona = Persona(
             character="Rosie the Riveter",
@@ -402,8 +401,8 @@ class TestCompressedPersonaFormat:
 
     def test_full_persona_token_count(self, tmp_path: Path) -> None:
         """Test full persona is approximately 300 tokens (~1200 chars)."""
+        from pennyfarthing_scripts.prime.models import CrewMember, Persona
         from pennyfarthing_scripts.prime.persona import format_persona_output
-        from pennyfarthing_scripts.prime.models import Persona, CrewMember
 
         persona = Persona(
             character="Rosie the Riveter",
@@ -509,9 +508,10 @@ class TestDefaultBehavior:
 
     def test_existing_flags_still_work_with_tier(self, tmp_path: Path, capsys) -> None:
         """Test existing flags (--quiet, --json, etc.) work with --tier."""
-        from pennyfarthing_scripts.prime.cli import prime
         import json
 
+        from pennyfarthing_scripts.prime.cli import prime
+
         # Setup
         pf_dir = tmp_path / ".pennyfarthing"
         pf_dir.mkdir()
@@ -548,7 +548,7 @@ class TestTierLoadingPaths:
 
     def test_full_tier_with_all_options(self, tmp_path: Path) -> None:
         """Test FULL tier with all context sources available."""
-        from pennyfarthing_scripts.prime.tiers import load_tier_components, ContextTier
+        from pennyfarthing_scripts.prime.tiers import ContextTier, load_tier_components
 
         # Setup complete project
         self._setup_complete_project(tmp_path)
@@ -569,7 +569,7 @@ class TestTierLoadingPaths:
 
     def test_full_tier_with_missing_optional(self, tmp_path: Path) -> None:
         """Test FULL tier gracefully handles missing optional components."""
-        from pennyfarthing_scripts.prime.tiers import load_tier_components, ContextTier
+        from pennyfarthing_scripts.prime.tiers import ContextTier, load_tier_components
 
         # Minimal setup - only agent definition
         pf_dir = tmp_path / ".pennyfarthing"
@@ -590,7 +590,7 @@ class TestTierLoadingPaths:
 
     def test_refresh_tier_components(self, tmp_path: Path) -> None:
         """Test REFRESH tier returns correct component set."""
-        from pennyfarthing_scripts.prime.tiers import load_tier_components, ContextTier
+        from pennyfarthing_scripts.prime.tiers import ContextTier, load_tier_components
 
         self._setup_complete_project(tmp_path)
 
@@ -612,7 +612,7 @@ class TestTierLoadingPaths:
 
     def test_handoff_tier_components(self, tmp_path: Path) -> None:
         """Test HANDOFF tier returns correct component set."""
-        from pennyfarthing_scripts.prime.tiers import load_tier_components, ContextTier
+        from pennyfarthing_scripts.prime.tiers import ContextTier, load_tier_components
 
         self._setup_complete_project(tmp_path)
 
@@ -633,7 +633,7 @@ class TestTierLoadingPaths:
 
     def test_minimal_tier_components(self, tmp_path: Path) -> None:
         """Test MINIMAL tier returns minimal component set."""
-        from pennyfarthing_scripts.prime.tiers import load_tier_components, ContextTier
+        from pennyfarthing_scripts.prime.tiers import ContextTier, load_tier_components
 
         self._setup_complete_project(tmp_path)
 
@@ -990,9 +990,10 @@ class TestTierIntegration:
 
     def test_json_output_includes_tier(self, tmp_path: Path, capsys) -> None:
         """Test JSON output includes current tier."""
-        from pennyfarthing_scripts.prime.cli import prime
         import json
 
+        from pennyfarthing_scripts.prime.cli import prime
+
         pf_dir = tmp_path / ".pennyfarthing"
         pf_dir.mkdir()
         agents_dir = pf_dir / "agents"

package/pennyfarthing_scripts/tests/test_token_counting.py

@@ -15,12 +15,11 @@ Acceptance Criteria:
 This file tests the Python side (AC1, AC2, AC4).
 """
 
-import pytest
+import json
 from pathlib import Path
 from unittest.mock import patch
-import yaml
-import json
 
+import yaml
 
 # =============================================================================
 # AC1: Each component has an approximate token count
@@ -32,7 +31,7 @@ class TestComponentTokenCounting:
 
     def test_load_tier_components_returns_token_counts(self, tmp_path: Path) -> None:
         """Test load_tier_components returns token counts for each component."""
-        from pennyfarthing_scripts.prime.tiers import load_tier_components, ContextTier
+        from pennyfarthing_scripts.prime.tiers import ContextTier, load_tier_components
 
         self._setup_complete_project(tmp_path)
 
@@ -48,7 +47,7 @@ class TestComponentTokenCounting:
 
     def test_token_counts_include_all_full_tier_components(self, tmp_path: Path) -> None:
         """Test FULL tier returns token counts for all components."""
-        from pennyfarthing_scripts.prime.tiers import load_tier_components, ContextTier
+        from pennyfarthing_scripts.prime.tiers import ContextTier, load_tier_components
 
         self._setup_complete_project(tmp_path)
 
@@ -78,7 +77,7 @@ class TestComponentTokenCounting:
 
     def test_token_counts_are_positive_for_loaded_components(self, tmp_path: Path) -> None:
         """Test that loaded components have positive token counts."""
-        from pennyfarthing_scripts.prime.tiers import load_tier_components, ContextTier
+        from pennyfarthing_scripts.prime.tiers import ContextTier, load_tier_components
 
         self._setup_complete_project(tmp_path)
 
@@ -97,7 +96,7 @@ class TestComponentTokenCounting:
 
     def test_token_counts_zero_for_missing_components(self, tmp_path: Path) -> None:
         """Test that missing optional components have zero token counts."""
-        from pennyfarthing_scripts.prime.tiers import load_tier_components, ContextTier
+        from pennyfarthing_scripts.prime.tiers import ContextTier, load_tier_components
 
         # Minimal setup - only agent definition
         pf_dir = tmp_path / ".pennyfarthing"
@@ -120,7 +119,7 @@ class TestComponentTokenCounting:
 
     def test_refresh_tier_only_counts_included_components(self, tmp_path: Path) -> None:
         """Test REFRESH tier only includes counts for its components."""
-        from pennyfarthing_scripts.prime.tiers import load_tier_components, ContextTier
+        from pennyfarthing_scripts.prime.tiers import ContextTier, load_tier_components
 
         self._setup_complete_project(tmp_path)
 
@@ -145,7 +144,7 @@ class TestComponentTokenCounting:
 
     def test_handoff_tier_only_counts_included_components(self, tmp_path: Path) -> None:
         """Test HANDOFF tier only includes counts for its components."""
-        from pennyfarthing_scripts.prime.tiers import load_tier_components, ContextTier
+        from pennyfarthing_scripts.prime.tiers import ContextTier, load_tier_components
 
         self._setup_complete_project(tmp_path)
 
@@ -164,7 +163,7 @@ class TestComponentTokenCounting:
 
     def test_minimal_tier_only_counts_workflow_state(self, tmp_path: Path) -> None:
         """Test MINIMAL tier only counts workflow state."""
-        from pennyfarthing_scripts.prime.tiers import load_tier_components, ContextTier
+        from pennyfarthing_scripts.prime.tiers import ContextTier, load_tier_components
 
         self._setup_complete_project(tmp_path)
 
@@ -187,7 +186,7 @@ class TestComponentTokenCounting:
 
     def test_total_tokens_is_sum_of_components(self, tmp_path: Path) -> None:
         """Test that total_tokens equals sum of component counts."""
-        from pennyfarthing_scripts.prime.tiers import load_tier_components, ContextTier
+        from pennyfarthing_scripts.prime.tiers import ContextTier, load_tier_components
 
         self._setup_complete_project(tmp_path)
 
@@ -464,7 +463,11 @@ def hello():
 
     def test_component_token_count_within_10_percent_of_actual(self, tmp_path: Path) -> None:
         """Test component token counts are within 10% of actual tiktoken count."""
-        from pennyfarthing_scripts.prime.tiers import load_tier_components, ContextTier, estimate_tokens
+        from pennyfarthing_scripts.prime.tiers import (
+            ContextTier,
+            estimate_tokens,
+            load_tier_components,
+        )
 
         # Create a known-content project
         pf_dir = tmp_path / ".pennyfarthing"
@@ -495,7 +498,10 @@ def hello():
 
     def test_total_tokens_within_10_percent_of_sum(self, tmp_path: Path) -> None:
         """Test total_tokens is within 10% of manually summed content."""
-        from pennyfarthing_scripts.prime.tiers import load_tier_components, ContextTier, estimate_tokens
+        from pennyfarthing_scripts.prime.tiers import (
+            ContextTier,
+            load_tier_components,
+        )
 
         pf_dir = tmp_path / ".pennyfarthing"
         pf_dir.mkdir()

package/pennyfarthing_scripts/tests/test_validate_cmd.py

@@ -13,21 +13,16 @@ Acceptance Criteria:
 """
 
 from pathlib import Path
-from typing import Any
-from unittest.mock import patch
 
 import pytest
 from click.testing import CliRunner
 
 from pennyfarthing_scripts.sprint.validate_cmd import (
-    FormatIssue,
-    ValidateResult,
     check_format_drift,
     validate_command,
     validate_sprint_yaml,
 )
 
-
 # =============================================================================
 # Test Fixtures
 # =============================================================================
@@ -382,7 +377,7 @@ class TestFixFlag:
         assert len(issues_before) > 0
 
         # Run validate with --fix
-        result = validate_sprint_yaml(scrambled_keys_file, fix=True)
+        validate_sprint_yaml(scrambled_keys_file, fix=True)
 
         # After fix, re-check should show no drift
         issues_after = check_format_drift(scrambled_keys_file)
@@ -390,7 +385,7 @@ class TestFixFlag:
 
     def test_fix_converts_to_block_scalars(self, wrong_string_style_file: Path) -> None:
         """--fix should convert multiline strings to block scalar style."""
-        result = validate_sprint_yaml(wrong_string_style_file, fix=True)
+        validate_sprint_yaml(wrong_string_style_file, fix=True)
 
         # Read back and check for block scalar
         content = wrong_string_style_file.read_text()

package/pennyfarthing_scripts/tests/test_workflow_check.py

@@ -16,11 +16,9 @@ import json
 import subprocess
 import sys
 from pathlib import Path
-from typing import Any
 from unittest.mock import patch
 
 import pytest
-
 from click.testing import CliRunner
 
 from pennyfarthing_scripts.cli import cli

package/pennyfarthing_scripts/tests/test_yaml_io.py

@@ -11,10 +11,8 @@ Acceptance Criteria:
 4. Key ordering matches sprint-template.yaml
 """
 
-import os
 from pathlib import Path
 from typing import Any
-from unittest.mock import patch
 
 import pytest
 
@@ -27,7 +25,6 @@ from pennyfarthing_scripts.sprint.yaml_io import (
     write_sprint,
 )
 
-
 # =============================================================================
 # Test Fixtures
 # =============================================================================

package/pennyfarthing_scripts/theme/cli.py

@@ -225,9 +225,10 @@ def create(name: str, base: str | None, user: bool):
     Arguments:
       NAME  - Name for the new theme (lowercase, hyphens allowed)
     """
-    import yaml
     from pathlib import Path
 
+    import yaml
+
     from pennyfarthing_scripts.common.config import get_project_root
     from pennyfarthing_scripts.common.themes import (
         get_current_theme,
@@ -282,5 +283,5 @@ def create(name: str, base: str | None, user: bool):
     click.echo(f"  File: {target_path}")
     click.echo()
     click.echo("Next steps:")
-    click.echo(f"  1. Edit the theme file to customize your agents")
+    click.echo("  1. Edit the theme file to customize your agents")
     click.echo(f"  2. Run 'pf theme set {name}' to activate")

package/pennyfarthing_scripts/validate/__init__.py

@@ -0,0 +1,21 @@
+"""Top-level validate command — auto-discovers and runs project validators."""
+
+from __future__ import annotations
+
+from dataclasses import dataclass, field
+
+
+@dataclass
+class ValidateReport:
+    """Unified report from a single validator domain."""
+
+    validator: str
+    passed: int = 0
+    warnings: int = 0
+    errors: int = 0
+    details: list[str] = field(default_factory=list)
+    fixed: bool = False
+
+    @property
+    def success(self) -> bool:
+        return self.errors == 0