@pennyfarthing/core 10.1.0 → 10.2.0

package/pennyfarthing_scripts/tests/test_git_utils.py

@@ -16,21 +16,11 @@ Acceptance Criteria:
 """
 
 import asyncio
-import tempfile
 from pathlib import Path
-from typing import Any
-from unittest.mock import AsyncMock, MagicMock, patch
+from unittest.mock import AsyncMock, patch
 
 import pytest
 
-from pennyfarthing_scripts.git.status_all import (
-    RepoStatus,
-    format_status_brief,
-    format_status_full,
-    format_summary,
-    get_all_repo_status,
-    get_repo_status,
-)
 from pennyfarthing_scripts.git.create_branches import (
     BranchAction,
     BranchResult,
@@ -40,7 +30,14 @@ from pennyfarthing_scripts.git.create_branches import (
     filter_repos,
     format_results,
 )
-
+from pennyfarthing_scripts.git.status_all import (
+    RepoStatus,
+    format_status_brief,
+    format_status_full,
+    format_summary,
+    get_all_repo_status,
+    get_repo_status,
+)
 
 # =============================================================================
 # Test Fixtures
@@ -793,8 +790,8 @@ class TestCrossPlatformCompatibility:
     def test_no_shell_specific_commands(self) -> None:
         """Implementation should not use shell-specific commands."""
         # This is more of a code review check, but we can verify the modules exist
-        import pennyfarthing_scripts.git.status_all as status_mod
         import pennyfarthing_scripts.git.create_branches as branch_mod
+        import pennyfarthing_scripts.git.status_all as status_mod
 
         # Modules should exist and be importable
         assert status_mod is not None

package/pennyfarthing_scripts/tests/test_healthscore.py

@@ -17,19 +17,12 @@ from __future__ import annotations
 
 import asyncio
 import json
-import time
 from dataclasses import asdict
 from pathlib import Path
-from unittest.mock import patch, MagicMock
+from unittest.mock import patch
 
-import pytest
 from click.testing import CliRunner
 
-from pennyfarthing_scripts.healthscore.models import (
-    DimensionScore,
-    HealthscoreResult,
-    DEFAULT_WEIGHTS,
-)
 from pennyfarthing_scripts.healthscore.analyze import (
     analyze_healthscore,
     compute_composite_score,
@@ -37,13 +30,12 @@ from pennyfarthing_scripts.healthscore.analyze import (
     read_cached_score,
     write_cached_score,
 )
-from pennyfarthing_scripts.healthscore.formatters import (
-    format_table,
-    export_json,
-    export_csv,
-)
 from pennyfarthing_scripts.healthscore.cli import healthscore
-
+from pennyfarthing_scripts.healthscore.models import (
+    DEFAULT_WEIGHTS,
+    DimensionScore,
+    HealthscoreResult,
+)
 
 # ---------------------------------------------------------------------------
 # AC1: Module structure
@@ -122,17 +114,17 @@ class TestWeightedScoring:
 
     def test_custom_weights_override_defaults(self):
         """compute_composite_score must accept custom weights."""
-        custom = {k: 1.0 / 8 for k in DEFAULT_WEIGHTS}
-        scores = {k: 80.0 for k in DEFAULT_WEIGHTS}
+        custom = dict.fromkeys(DEFAULT_WEIGHTS, 1.0 / 8)
+        scores = dict.fromkeys(DEFAULT_WEIGHTS, 80.0)
         result = compute_composite_score(scores, custom)
         assert abs(result - 80.0) < 1e-9
 
     def test_unequal_custom_weights(self):
         """Asymmetric weights should shift composite score."""
-        weights = {k: 0.0 for k in DEFAULT_WEIGHTS}
+        weights = dict.fromkeys(DEFAULT_WEIGHTS, 0.0)
         weights["churn"] = 1.0  # All weight on churn
 
-        scores = {k: 50.0 for k in DEFAULT_WEIGHTS}
+        scores = dict.fromkeys(DEFAULT_WEIGHTS, 50.0)
         scores["churn"] = 100.0
 
         result = compute_composite_score(scores, weights)
@@ -148,13 +140,13 @@ class TestScoreRanges:
 
     def test_all_zeros_yields_zero(self):
         """All dimensions at 0 → composite 0."""
-        scores = {k: 0.0 for k in DEFAULT_WEIGHTS}
+        scores = dict.fromkeys(DEFAULT_WEIGHTS, 0.0)
         result = compute_composite_score(scores, DEFAULT_WEIGHTS)
         assert result == 0.0
 
     def test_all_hundreds_yields_hundred(self):
         """All dimensions at 100 → composite 100."""
-        scores = {k: 100.0 for k in DEFAULT_WEIGHTS}
+        scores = dict.fromkeys(DEFAULT_WEIGHTS, 100.0)
         result = compute_composite_score(scores, DEFAULT_WEIGHTS)
         assert abs(result - 100.0) < 1e-9
 
@@ -176,7 +168,7 @@ class TestScoreRanges:
 
     def test_none_dimensions_excluded_and_renormalized(self):
         """Unavailable dimensions (None) are excluded; remaining weights renormalize."""
-        scores = {k: None for k in DEFAULT_WEIGHTS}
+        scores = dict.fromkeys(DEFAULT_WEIGHTS)
         scores["churn"] = 80.0
         scores["complexity"] = 60.0
         # Only churn (0.15) and complexity (0.15) available → renorm to 0.5 each
@@ -186,7 +178,7 @@ class TestScoreRanges:
 
     def test_all_none_dimensions_returns_zero(self):
         """All dimensions unavailable → composite 0."""
-        scores = {k: None for k in DEFAULT_WEIGHTS}
+        scores = dict.fromkeys(DEFAULT_WEIGHTS)
         result = compute_composite_score(scores, DEFAULT_WEIGHTS)
         assert result == 0.0
 
@@ -374,7 +366,7 @@ class TestCaching:
             "pennyfarthing_scripts.healthscore.analyze.read_cached_score",
             return_value=99.0,
         ) as mock_read:
-            result = asyncio.run(
+            asyncio.run(
                 analyze_healthscore(Path("/tmp/project"), cache_ttl=0)
             )
             # With ttl=0, cached values should not be used
@@ -484,7 +476,7 @@ class TestMainCLIRegistration:
     def test_healthscore_registered_in_main_cli(self):
         """Main CLI must have a 'healthscore' command group."""
         from pennyfarthing_scripts.cli import cli
-        command_names = [cmd for cmd in cli.commands]
+        command_names = list(cli.commands)
         assert "healthscore" in command_names
 
 
@@ -507,7 +499,7 @@ class TestAnalyzeIntegration:
 
     def test_analyze_with_custom_weights(self):
         """Custom weights must be accepted and applied."""
-        custom = {k: 1.0 / 8 for k in DEFAULT_WEIGHTS}
+        custom = dict.fromkeys(DEFAULT_WEIGHTS, 1.0 / 8)
         result = asyncio.run(analyze_healthscore(Path("/tmp/nonexistent"), weights=custom))
         assert isinstance(result, HealthscoreResult)
 

package/pennyfarthing_scripts/tests/test_jira_package.py

@@ -7,9 +7,6 @@ after reorganization from flat modules.
 """
 
 from typing import Any
-from unittest.mock import MagicMock, patch
-
-import pytest
 
 
 class TestJiraClient:

package/pennyfarthing_scripts/tests/test_package_structure.py

@@ -10,12 +10,7 @@ These tests verify:
 5. Backwards compatibility for existing imports
 """
 
-import importlib
 import sys
-from pathlib import Path
-from typing import Any
-
-import pytest
 
 
 class TestCommonPackage:
@@ -126,8 +121,6 @@ class TestJiraPackage:
         from pennyfarthing_scripts.jira import (
             JiraClient,
             extract_jira_key,
-            map_status_to_jira,
-            map_jira_to_status,
         )
 
         assert JiraClient is not None
@@ -136,9 +129,7 @@ class TestJiraPackage:
     def test_jira_backwards_compatibility(self) -> None:
         """Old-style imports should still work."""
         # These imports should work for backwards compatibility
-        from pennyfarthing_scripts.jira import JiraClient
-        from pennyfarthing_scripts.jira import get_issue
-        from pennyfarthing_scripts.jira import STATUS_TO_JIRA
+        from pennyfarthing_scripts.jira import STATUS_TO_JIRA, JiraClient, get_issue
 
         assert JiraClient is not None
         assert callable(get_issue)
@@ -188,10 +179,8 @@ class TestSprintPackage:
     def test_sprint_package_reexports(self) -> None:
         """sprint/__init__.py should re-export commonly used items."""
         from pennyfarthing_scripts.sprint import (
-            load_sprint,
             find_epic,
-            find_story,
-            get_all_stories,
+            load_sprint,
         )
 
         assert callable(load_sprint)
@@ -199,9 +188,7 @@ class TestSprintPackage:
 
     def test_sprint_backwards_compatibility(self) -> None:
         """Old-style imports should still work."""
-        from pennyfarthing_scripts.sprint import load_sprint
-        from pennyfarthing_scripts.sprint import find_epic
-        from pennyfarthing_scripts.sprint import load_current_sprint
+        from pennyfarthing_scripts.sprint import find_epic, load_current_sprint, load_sprint
 
         assert callable(load_sprint)
         assert callable(find_epic)

package/pennyfarthing_scripts/tests/test_patch_mode.py

@@ -18,13 +18,9 @@ Acceptance Criteria:
 These tests should FAIL until patch_mode.py is implemented.
 """
 
-import json
-import os
-import subprocess
-import sys
 from pathlib import Path
-from typing import Any, Generator
-from unittest.mock import MagicMock, patch, call
+from typing import Any
+from unittest.mock import MagicMock, patch
 
 import pytest
 import yaml
@@ -32,17 +28,17 @@ import yaml
 # Import will fail until module exists - this is intentional for RED state
 try:
     from pennyfarthing_scripts.patch_mode import (
-        PatchState,
         PatchStack,
+        PatchState,
+        create_patch_branch,
         enter_patch_mode,
         exit_patch_mode,
+        generate_patch_commit_message,
         get_patch_stack,
-        create_patch_branch,
+        is_in_patch_mode,
+        log_patch_to_session,
         merge_patch_branch,
         restore_workflow_state,
-        log_patch_to_session,
-        generate_patch_commit_message,
-        is_in_patch_mode,
     )
     IMPORT_SUCCESS = True
 except ImportError:

package/pennyfarthing_scripts/tests/test_prime.py

@@ -3,21 +3,22 @@
 Tests context loading for prime command.
 """
 
-import pytest
 from pathlib import Path
-from unittest.mock import patch, MagicMock
+from unittest.mock import patch
+
+import pytest
 
+from pennyfarthing_scripts.prime.cli import main, prime
 from pennyfarthing_scripts.prime.loader import (
+    _extract_session_parts,
+    _find_session_file,
     load_agent_definition,
     load_behavior_guide,
-    load_sprint_context,
+    load_domain_docs,
     load_session_context,
     load_sidecars,
-    load_domain_docs,
-    _extract_session_parts,
-    _find_session_file,
+    load_sprint_context,
 )
-from pennyfarthing_scripts.prime.cli import prime, main
 
 
 class TestLoadAgentDefinition:
@@ -407,8 +408,8 @@ class TestWorkflowStateDetection:
 
     def test_detect_finish_state(self, tmp_path: Path) -> None:
         """Test detecting FINISH_STATE when phase is approved."""
-        from pennyfarthing_scripts.prime.workflow import detect_workflow_state
         from pennyfarthing_scripts.prime.models import WorkflowState
+        from pennyfarthing_scripts.prime.workflow import detect_workflow_state
 
         # Setup
         pf_dir = tmp_path / ".pennyfarthing"
@@ -436,10 +437,11 @@ class TestWorkflowStateDetection:
 
     def test_detect_in_progress_state(self, tmp_path: Path) -> None:
         """Test detecting IN_PROGRESS_STATE with active phase."""
-        from pennyfarthing_scripts.prime.workflow import detect_workflow_state
-        from pennyfarthing_scripts.prime.models import WorkflowState
         import yaml
 
+        from pennyfarthing_scripts.prime.models import WorkflowState
+        from pennyfarthing_scripts.prime.workflow import detect_workflow_state
+
         # Setup
         pf_dir = tmp_path / ".pennyfarthing"
         pf_dir.mkdir()
@@ -483,10 +485,11 @@ class TestWorkflowStateDetection:
 
     def test_detect_new_work_state(self, tmp_path: Path) -> None:
         """Test detecting NEW_WORK_STATE with backlog stories."""
-        from pennyfarthing_scripts.prime.workflow import detect_workflow_state
-        from pennyfarthing_scripts.prime.models import WorkflowState
         import yaml
 
+        from pennyfarthing_scripts.prime.models import WorkflowState
+        from pennyfarthing_scripts.prime.workflow import detect_workflow_state
+
         # Setup
         pf_dir = tmp_path / ".pennyfarthing"
         pf_dir.mkdir()
@@ -514,10 +517,11 @@ class TestWorkflowStateDetection:
 
     def test_detect_empty_backlog_state(self, tmp_path: Path) -> None:
         """Test detecting EMPTY_BACKLOG_STATE with no backlog."""
-        from pennyfarthing_scripts.prime.workflow import detect_workflow_state
-        from pennyfarthing_scripts.prime.models import WorkflowState
         import yaml
 
+        from pennyfarthing_scripts.prime.models import WorkflowState
+        from pennyfarthing_scripts.prime.workflow import detect_workflow_state
+
         # Setup
         pf_dir = tmp_path / ".pennyfarthing"
         pf_dir.mkdir()
@@ -587,8 +591,8 @@ class TestCheckRedirect:
 
     def test_redirect_when_wrong_agent(self) -> None:
         """Test redirect is detected when wrong agent is activated."""
-        from pennyfarthing_scripts.prime.workflow import check_redirect
         from pennyfarthing_scripts.prime.models import WorkflowState, WorkflowStatus
+        from pennyfarthing_scripts.prime.workflow import check_redirect
 
         status = WorkflowStatus(
             state=WorkflowState.IN_PROGRESS_STATE,
@@ -606,8 +610,8 @@ class TestCheckRedirect:
 
     def test_no_redirect_when_correct_agent(self) -> None:
         """Test no redirect when correct agent is activated."""
-        from pennyfarthing_scripts.prime.workflow import check_redirect
         from pennyfarthing_scripts.prime.models import WorkflowState, WorkflowStatus
+        from pennyfarthing_scripts.prime.workflow import check_redirect
 
         status = WorkflowStatus(
             state=WorkflowState.IN_PROGRESS_STATE,
@@ -621,8 +625,8 @@ class TestCheckRedirect:
 
     def test_no_redirect_for_new_work(self) -> None:
         """Test no redirect for NEW_WORK_STATE."""
-        from pennyfarthing_scripts.prime.workflow import check_redirect
         from pennyfarthing_scripts.prime.models import WorkflowState, WorkflowStatus
+        from pennyfarthing_scripts.prime.workflow import check_redirect
 
         status = WorkflowStatus(
             state=WorkflowState.NEW_WORK_STATE,
@@ -644,9 +648,10 @@ class TestPersonaLoading:
 
     def test_load_persona_from_theme(self, tmp_path: Path) -> None:
         """Test loading persona from theme YAML."""
-        from pennyfarthing_scripts.prime.persona import load_persona
         import yaml
 
+        from pennyfarthing_scripts.prime.persona import load_persona
+
         # Setup
         pf_dir = tmp_path / ".pennyfarthing"
         pf_dir.mkdir()
@@ -697,9 +702,10 @@ class TestPersonaLoading:
 
     def test_get_crew_manifest(self, tmp_path: Path) -> None:
         """Test getting crew manifest for handoff reference."""
-        from pennyfarthing_scripts.prime.persona import get_crew_manifest
         import yaml
 
+        from pennyfarthing_scripts.prime.persona import get_crew_manifest
+
         # Setup
         pf_dir = tmp_path / ".pennyfarthing"
         pf_dir.mkdir()
@@ -730,8 +736,8 @@ class TestPersonaLoading:
 
     def test_format_persona_output(self) -> None:
         """Test formatting persona as XML."""
+        from pennyfarthing_scripts.prime.models import CrewMember, Persona
         from pennyfarthing_scripts.prime.persona import format_persona_output
-        from pennyfarthing_scripts.prime.models import Persona, CrewMember
 
         persona = Persona(
             character="Naomi Nagata",
@@ -798,9 +804,10 @@ class TestSessionRegistration:
 
     def test_cleanup_old_sessions(self, tmp_path: Path) -> None:
         """Test cleanup of old session files."""
-        from pennyfarthing_scripts.prime.session import cleanup_old_sessions
         import time
 
+        from pennyfarthing_scripts.prime.session import cleanup_old_sessions
+
         # Setup
         pf_dir = tmp_path / ".pennyfarthing"
         pf_dir.mkdir()
@@ -886,11 +893,15 @@ class TestJSONOutput:
     def test_json_output_with_workflow(self, tmp_path: Path, capsys) -> None:
         """Test JSON output includes workflow status."""
         import json
+
         import yaml
 
         # Setup
         pf_dir = tmp_path / ".pennyfarthing"
         pf_dir.mkdir()
+        agents_dir = pf_dir / "agents"
+        agents_dir.mkdir()
+        (agents_dir / "sm.md").write_text("# SM Agent\nScrum Master")
         sprint_dir = tmp_path / "sprint"
         sprint_dir.mkdir()
         (sprint_dir / "current-sprint.yaml").write_text(yaml.dump({
@@ -925,11 +936,15 @@ class TestJSONOutput:
     def test_json_output_with_redirect(self, tmp_path: Path, capsys) -> None:
         """Test JSON output includes redirect info."""
         import json
+
         import yaml
 
         # Setup
         pf_dir = tmp_path / ".pennyfarthing"
         pf_dir.mkdir()
+        agents_dir = pf_dir / "agents"
+        agents_dir.mkdir()
+        (agents_dir / "tea.md").write_text("# TEA Agent\nTest Engineer")
 
         # Create workflow YAML
         workflows_dir = tmp_path / "pennyfarthing-dist" / "workflows"
@@ -1039,6 +1054,9 @@ class TestCLIFlagsV2:
 
         pf_dir = tmp_path / ".pennyfarthing"
         pf_dir.mkdir()
+        agents_dir = pf_dir / "agents"
+        agents_dir.mkdir()
+        (agents_dir / "sm.md").write_text("# SM Agent\nScrum Master")
 
         with patch("pennyfarthing_scripts.prime.cli.get_project_root", return_value=tmp_path):
             result = main(["--agent", "sm", "--session-id", "explicit-123", "--no-workflow"])

package/pennyfarthing_scripts/tests/test_sprint_package.py

@@ -7,10 +7,7 @@ after reorganization from flat modules.
 """
 
 from pathlib import Path
-from typing import Any
-from unittest.mock import MagicMock, patch
-
-import pytest
+from unittest.mock import patch
 
 
 class TestSprintLoader:
@@ -28,8 +25,8 @@ class TestSprintLoader:
 
     def test_load_sprint_with_custom_root(self) -> None:
         """load_sprint should accept custom project root."""
-        from pennyfarthing_scripts.sprint.loader import load_sprint
         from pennyfarthing_scripts.common.config import get_project_root
+        from pennyfarthing_scripts.sprint.loader import load_sprint
 
         root = get_project_root()
         result = load_sprint(project_root=root)
@@ -341,8 +338,7 @@ epics:
 
     def test_get_all_stories_with_shards(self, tmp_path: Path) -> None:
         """get_all_stories should return stories from merged shards."""
-        from pennyfarthing_scripts.sprint.loader import get_all_stories, load_sprint
-        from unittest.mock import patch
+        from pennyfarthing_scripts.sprint.loader import get_all_stories
 
         root = self._create_sharded_sprint(tmp_path)
 
@@ -379,7 +375,6 @@ epics:
     def test_backlog_count_defensive_on_strings(self) -> None:
         """get_backlog_count should not crash on string epics."""
         from pennyfarthing_scripts.prime.workflow import get_backlog_count
-        from unittest.mock import patch
 
         fake_data = {"epics": ["MSSCI-14298", "MSSCI-14317"]}
         with patch("pennyfarthing_scripts.sprint.loader.load_sprint", return_value=fake_data):

package/pennyfarthing_scripts/tests/test_sprint_validator.py

@@ -19,19 +19,18 @@ from typing import Any
 import pytest
 
 from pennyfarthing_scripts.sprint.validator import (
-    ValidationError,
     ValidationResult,
     ValidationSeverity,
     format_validation_errors,
     validate_archived_sprint,
     validate_epic,
+    validate_epic_shard,
     validate_full_sprint,
     validate_sprint,
     validate_sprint_file,
     validate_story,
 )
 
-
 # =============================================================================
 # Test Fixtures - Valid Data
 # =============================================================================
@@ -239,7 +238,7 @@ class TestStoryValidation:
 
     def test_all_valid_story_statuses_pass(self) -> None:
         """All valid status values should pass."""
-        valid_statuses = ["backlog", "in_progress", "done", "cancelled"]
+        valid_statuses = ["backlog", "ready", "in_progress", "done", "canceled", "planning"]
 
         for status in valid_statuses:
             story = {"id": "63-1", "title": "Test", "status": status, "points": 3}
@@ -364,6 +363,55 @@ class TestEpicValidation:
         assert result.valid is False
         assert any("duplicate" in e.message.lower() for e in result.errors)
 
+    def test_integer_epic_id_fails(self) -> None:
+        """Epic with integer id (YAML bare number) should fail.
+
+        YAML parses `id: 87` as int. Cyclist's sprint-data.ts calls
+        epicId.match() which crashes on non-strings, blanking the panel.
+        """
+        epic = {
+            "id": 87,  # Bare integer — not quoted in YAML
+            "title": "Test Epic",
+            "stories": [
+                {"id": "87-1", "title": "Story 1", "status": "backlog", "points": 2},
+            ],
+        }
+
+        result = validate_epic(epic, set())
+
+        assert result.valid is False
+        assert any("must be a string" in e.message.lower() for e in result.errors)
+
+    def test_integer_epic_id_fails_in_shard(self) -> None:
+        """Epic shard with integer id should fail validation."""
+        epic = {
+            "id": 87,
+            "title": "Test Epic",
+            "status": "planning",
+            "stories": [
+                {"id": "87-1", "title": "Story 1", "status": "backlog", "points": 2},
+            ],
+        }
+
+        result = validate_epic_shard(epic)
+
+        assert result.valid is False
+        assert any("must be a string" in e.message.lower() for e in result.errors)
+
+    def test_string_epic_id_passes(self) -> None:
+        """Epic with properly quoted string id should pass."""
+        epic = {
+            "id": "87",  # Quoted in YAML — parsed as string
+            "title": "Test Epic",
+            "stories": [
+                {"id": "87-1", "title": "Story 1", "status": "backlog", "points": 2},
+            ],
+        }
+
+        result = validate_epic(epic, set())
+
+        assert result.valid is True
+
 
 # =============================================================================
 # AC4: Clear error messages for validation failures
@@ -470,7 +518,7 @@ class TestArchivedSprintValidation:
         assert result.valid is True
 
     def test_archived_sprint_allows_all_done_stories(self) -> None:
-        """Archived sprints should allow all stories to be done/cancelled."""
+        """Archived sprints should allow all stories to be done/canceled."""
         data = {
             "sprint": {
                 "number": 11,
@@ -486,7 +534,7 @@ class TestArchivedSprintValidation:
                     "title": "Old Epic",
                     "stories": [
                         {"id": "50-1", "title": "Done Story", "status": "done", "points": 3},
-                        {"id": "50-2", "title": "Cancelled Story", "status": "cancelled", "points": 2},
+                        {"id": "50-2", "title": "Canceled Story", "status": "canceled", "points": 2},
                     ],
                 }
             ],

package/pennyfarthing_scripts/tests/test_story_add.py

@@ -15,11 +15,10 @@ Acceptance Criteria:
 """
 
 from pathlib import Path
-from typing import Any
 
 import pytest
 from click.testing import CliRunner
-from ruamel.yaml.comments import CommentedMap, CommentedSeq
+from ruamel.yaml.comments import CommentedMap
 
 from pennyfarthing_scripts.sprint.story_add import (
     add_story,
@@ -28,10 +27,8 @@ from pennyfarthing_scripts.sprint.story_add import (
 from pennyfarthing_scripts.sprint.yaml_io import (
     STORY_KEY_ORDER,
     read_sprint,
-    write_sprint,
 )
 
-
 # =============================================================================
 # Test Fixtures
 # =============================================================================
@@ -676,7 +673,6 @@ epics:
 """
         p = tmp_path / "current-sprint.yaml"
         p.write_text(yaml_content)
-        original_content = p.read_text()
 
         # Normal add should work fine
         result = add_story(
@@ -699,10 +695,10 @@ class TestCLIIntegration:
 
     def test_story_add_command_exists(self) -> None:
         """story_add_command should be importable and be a Click command."""
-        from pennyfarthing_scripts.sprint.story_add import story_add_command
-
         import click
 
+        from pennyfarthing_scripts.sprint.story_add import story_add_command
+
         assert isinstance(story_add_command, click.BaseCommand)
 
     def test_basic_add_via_cli(self, runner: CliRunner, sprint_file: Path) -> None:

package/pennyfarthing_scripts/tests/test_story_package.py

@@ -5,10 +5,7 @@ Story 63-9: Reorganize pennyfarthing_scripts into fan-out CLI pattern.
 These tests verify the story/ package modules work correctly.
 """
 
-from typing import Any
-from unittest.mock import patch
 
-import pytest
 
 
 class TestStorySizeModule: