@pellux/goodvibes-agent 1.1.7 → 1.3.0

package/src/input/agent-workspace-channels.ts

@@ -20,6 +20,58 @@ export interface AgentWorkspaceChannelStatus {
   readonly nextStep: string;
 }
 
+export type AgentWorkspaceChannelSetupGuideStatus = 'ready' | 'attention' | 'setup-needed';
+export type AgentWorkspaceChannelSetupGuideStepStatus = 'complete' | 'current' | 'pending';
+export type AgentWorkspaceChannelSetupGuideStepSafety = 'read-only' | 'settings' | 'confirmed';
+
+export interface AgentWorkspaceChannelSetupGuideStep {
+  readonly id: string;
+  readonly label: string;
+  readonly status: AgentWorkspaceChannelSetupGuideStepStatus;
+  readonly detail: string;
+  readonly userRoute: string;
+  readonly modelRoute: string;
+  readonly safety: AgentWorkspaceChannelSetupGuideStepSafety;
+}
+
+export interface AgentWorkspaceChannelSetupGuideChannel {
+  readonly channelId: string;
+  readonly label: string;
+  readonly setupState: AgentWorkspaceChannelStatus['setupState'];
+  readonly enabled: boolean;
+  readonly ready: boolean;
+  readonly delivery: AgentWorkspaceChannelStatus['delivery'];
+  readonly riskLabel: string;
+  readonly summary: string;
+  readonly guideRoute: string;
+  readonly modelRoute: string;
+}
+
+export interface AgentWorkspaceChannelSetupGuide {
+  readonly status: AgentWorkspaceChannelSetupGuideStatus;
+  readonly summary: string;
+  readonly progressLabel: string;
+  readonly totalChannels: number;
+  readonly enabledChannels: number;
+  readonly readyChannels: number;
+  readonly attentionChannels: number;
+  readonly configuredTargets: number;
+  readonly currentChannelId: string | null;
+  readonly currentChannelLabel: string | null;
+  readonly currentStepId: string | null;
+  readonly currentStepLabel: string | null;
+  readonly channels: readonly AgentWorkspaceChannelSetupGuideChannel[];
+  readonly steps: readonly AgentWorkspaceChannelSetupGuideStep[];
+  readonly routes: {
+    readonly readiness: string;
+    readonly attention: string;
+    readonly accounts: string;
+    readonly policies: string;
+    readonly status: string;
+  };
+  readonly policy: string;
+}
+
 interface AgentWorkspaceConfigReader {
   get(key: string): unknown;
 }
@@ -273,3 +325,214 @@ function buildChannelStatus(context: CommandContext, spec: AgentWorkspaceChannel
 export function buildAgentWorkspaceChannels(context: CommandContext): readonly AgentWorkspaceChannelStatus[] {
   return AGENT_WORKSPACE_CHANNEL_SPECS.map((spec) => buildChannelStatus(context, spec));
 }
+
+function channelGuideModelRoute(channelId?: string): string {
+  return channelId
+    ? `channels action:"setup" channelId:"${channelId}"`
+    : 'channels action:"setup"';
+}
+
+function summarizeGuideChannel(channel: AgentWorkspaceChannelStatus): string {
+  if (!channel.enabled) return `Enable ${channel.label} only if the user wants this surface.`;
+  if (channel.setupState === 'needs-config') return `Missing ${channel.missingRequiredKeys.length} required config key(s).`;
+  if (channel.setupState === 'needs-target') return 'Ready for explicit targets; default target is not configured.';
+  return `${channel.label} is ready; delivery still requires explicit user action.`;
+}
+
+function rankedChannelGuideChannels(channels: readonly AgentWorkspaceChannelStatus[]): readonly AgentWorkspaceChannelStatus[] {
+  const rank = (channel: AgentWorkspaceChannelStatus): number => {
+    if (channel.setupState === 'needs-config') return 0;
+    if (channel.setupState === 'needs-target') return 1;
+    if (channel.setupState === 'disabled') return 2;
+    return 3;
+  };
+  return [...channels].sort((left, right) => rank(left) - rank(right) || left.label.localeCompare(right.label));
+}
+
+function currentGuideChannel(channels: readonly AgentWorkspaceChannelStatus[]): AgentWorkspaceChannelStatus | null {
+  const ranked = rankedChannelGuideChannels(channels);
+  return ranked[0] ?? null;
+}
+
+function currentGuideStepId(channel: AgentWorkspaceChannelStatus | null): string {
+  if (!channel) return 'choose-channel';
+  if (!channel.enabled) return 'enable-channel';
+  if (channel.setupState === 'needs-config') return 'inspect-setup-schema';
+  if (channel.setupState === 'needs-target') return 'choose-delivery-target';
+  return 'review-policy';
+}
+
+function guideStepStatus(stepId: string, currentStepId: string, order: readonly string[]): AgentWorkspaceChannelSetupGuideStepStatus {
+  const stepIndex = order.indexOf(stepId);
+  const currentIndex = order.indexOf(currentStepId);
+  if (stepIndex < currentIndex) return 'complete';
+  if (stepIndex === currentIndex) return 'current';
+  return 'pending';
+}
+
+function buildGuideSteps(channel: AgentWorkspaceChannelStatus | null): readonly AgentWorkspaceChannelSetupGuideStep[] {
+  const channelId = channel?.id ?? '<channel-id>';
+  const channelLabel = channel?.label ?? 'a channel';
+  const currentStepId = currentGuideStepId(channel);
+  const order = [
+    'choose-channel',
+    'enable-channel',
+    'inspect-setup-schema',
+    'configure-secrets',
+    'choose-delivery-target',
+    'review-policy',
+    'run-live-checks',
+    'send-explicit-test',
+  ] as const;
+  const missingConfig = channel && channel.missingRequiredKeys.length > 0
+    ? channel.missingRequiredKeys.join(', ')
+    : 'the required secret refs or host-owned settings';
+  const targetKeys = channel && channel.defaultTargetKeys.length > 0
+    ? channel.defaultTargetKeys.join(', ')
+    : 'an explicit delivery target';
+  const makeStep = (
+    id: typeof order[number],
+    label: string,
+    detail: string,
+    userRoute: string,
+    modelRoute: string,
+    safety: AgentWorkspaceChannelSetupGuideStepSafety,
+  ): AgentWorkspaceChannelSetupGuideStep => ({
+    id,
+    label,
+    status: guideStepStatus(id, currentStepId, order),
+    detail,
+    userRoute,
+    modelRoute,
+    safety,
+  });
+  return [
+    makeStep(
+      'choose-channel',
+      'Choose channel',
+      'Pick the channel the user actually wants before collecting credentials or exposing delivery routes.',
+      '/channels',
+      'channels action:"status"',
+      'read-only',
+    ),
+    makeStep(
+      'enable-channel',
+      'Enable surface',
+      `Enable ${channelLabel} in the owning GoodVibes host or Agent settings only after the user chooses it.`,
+      `/settings surfaces.${channelId}.enabled`,
+      `settings action:"get" query:"surfaces.${channelId}.enabled" includeParameters:true`,
+      'settings',
+    ),
+    makeStep(
+      'inspect-setup-schema',
+      'Inspect setup schema',
+      `Open the read-only ${channelLabel} setup schema before asking for credentials.`,
+      `/channels setup ${channelId}`,
+      `channels action:"channel" channelId:"${channelId}" includeParameters:true`,
+      'read-only',
+    ),
+    makeStep(
+      'configure-secrets',
+      'Configure secrets',
+      `Configure ${missingConfig}; secret values must stay in the secret manager or owning host.`,
+      `/settings surfaces.${channelId}`,
+      `settings action:"list" query:"surfaces.${channelId}" includeParameters:true`,
+      'settings',
+    ),
+    makeStep(
+      'choose-delivery-target',
+      'Choose target',
+      `Configure ${targetKeys}, or require the user to provide an explicit target on every send.`,
+      `/channels show ${channelId}`,
+      `channels action:"channel" channelId:"${channelId}" includeParameters:true`,
+      'read-only',
+    ),
+    makeStep(
+      'review-policy',
+      'Review allowlist',
+      `Review ${channelLabel} account and allowlist policy before any delivery test.`,
+      '/channels policies',
+      'channels action:"status" includeParameters:true',
+      'read-only',
+    ),
+    makeStep(
+      'run-live-checks',
+      'Run live checks',
+      `Inspect connected-host status and doctor output for ${channelLabel}; do not run repair actions from the guide.`,
+      `/channels doctor ${channelId}`,
+      `channels action:"channel" channelId:"${channelId}" includeParameters:true`,
+      'read-only',
+    ),
+    makeStep(
+      'send-explicit-test',
+      'Send explicit test',
+      'Send one test message only after the user asks for that exact target and confirms the send.',
+      `/channels send --channel ${channelId}:route:Label --message "Test from GoodVibes Agent" --yes`,
+      'agent_channel_send confirm:true explicitUserRequest:"..."',
+      'confirmed',
+    ),
+  ];
+}
+
+export function buildAgentWorkspaceChannelSetupGuide(
+  channels: readonly AgentWorkspaceChannelStatus[],
+  options: { readonly channelId?: string } = {},
+): AgentWorkspaceChannelSetupGuide {
+  const lookup = options.channelId?.trim().toLowerCase();
+  const requested = lookup
+    ? channels.find((channel) => channel.id.toLowerCase() === lookup || channel.label.toLowerCase() === lookup) ?? null
+    : null;
+  const ranked = rankedChannelGuideChannels(channels);
+  const current = requested ?? currentGuideChannel(channels);
+  const enabledChannels = channels.filter((channel) => channel.enabled).length;
+  const readyChannels = channels.filter((channel) => channel.ready).length;
+  const attentionChannels = channels.filter((channel) => channel.enabled && channel.setupState !== 'ready').length;
+  const configuredTargets = channels.filter((channel) => channel.defaultTarget === 'configured').length;
+  const status: AgentWorkspaceChannelSetupGuideStatus = attentionChannels > 0
+    ? 'attention'
+    : readyChannels > 0
+      ? 'ready'
+      : 'setup-needed';
+  const steps = buildGuideSteps(current);
+  const currentStep = steps.find((step) => step.status === 'current') ?? null;
+  const summary = status === 'attention'
+    ? `${attentionChannels} enabled channel(s) need setup. Start with ${current?.label ?? 'the first attention channel'}.`
+    : status === 'ready'
+      ? `${readyChannels}/${channels.length} channel(s) ready. Review allowlists and use explicit delivery tests only on request.`
+      : 'No channel is ready yet. Choose one channel, enable it intentionally, then configure only that surface.';
+  return {
+    status,
+    summary,
+    progressLabel: currentStep ? `${steps.findIndex((step) => step.id === currentStep.id) + 1}/${steps.length} ${currentStep.label}` : `0/${steps.length}`,
+    totalChannels: channels.length,
+    enabledChannels,
+    readyChannels,
+    attentionChannels,
+    configuredTargets,
+    currentChannelId: current?.id ?? null,
+    currentChannelLabel: current?.label ?? null,
+    currentStepId: currentStep?.id ?? null,
+    currentStepLabel: currentStep?.label ?? null,
+    channels: ranked.map((channel) => ({
+      channelId: channel.id,
+      label: channel.label,
+      setupState: channel.setupState,
+      enabled: channel.enabled,
+      ready: channel.ready,
+      delivery: channel.delivery,
+      riskLabel: channel.riskLabel,
+      summary: summarizeGuideChannel(channel),
+      guideRoute: `/channels guide ${channel.id}`,
+      modelRoute: channelGuideModelRoute(channel.id),
+    })),
+    steps,
+    routes: {
+      readiness: '/channels',
+      attention: '/channels attention',
+      accounts: '/channels accounts',
+      policies: '/channels policies',
+      status: '/channels status',
+    },
+    policy: 'Read-only channel setup guide. Credentials stay in secret-backed settings or the owning GoodVibes host, and delivery tests require explicit confirmed user action.',
+  };
+}

package/src/input/agent-workspace-command-editor.ts

@@ -1,7 +1,14 @@
 import type { AgentWorkspaceBasicCommandEditorKind } from './agent-workspace-basic-command-editors.ts';
+import { buildAgentArtifactBrowserPromptSubmission, buildAgentArtifactExportPromptSubmission, buildAgentArtifactPackagePromptSubmission, buildAgentArtifactPromoteKnowledgePromptSubmission } from './agent-workspace-artifact-browser-editor.ts';
 import { buildAgentWorkspaceBasicCommandEditorSubmission, isAgentWorkspaceBasicCommandEditorKind } from './agent-workspace-basic-command-editors.ts';
+import { buildAgentDocumentReviewerReadinessPromptSubmission, buildAgentDocumentReviewPacketPresetPromptSubmission, buildAgentDocumentReviewPacketPresetRefreshPromptSubmission, buildAgentDocumentReviewPacketSharePromptSubmission, buildAgentDocumentReviewPacketWizardPromptSubmission } from './agent-workspace-document-ops-editor.ts';
+import { buildAgentDocumentPromptSubmission } from './agent-workspace-document-editor.ts';
 import { buildAgentKnowledgeUrlEditorSubmission } from './agent-workspace-knowledge-url-editor.ts';
 import { buildAgentKnowledgeQueryEditorSubmission } from './agent-workspace-knowledge-query-editor.ts';
+import { buildAgentModelCompareAnalyticsPromptSubmission, buildAgentModelCompareApplyPromptSubmission, buildAgentModelCompareExportPromptSubmission, buildAgentModelCompareHandoffDiffPromptSubmission, buildAgentModelCompareJudgmentPromptSubmission, buildAgentModelComparePromptSubmission, buildAgentModelCompareReviewPromptSubmission, buildAgentModelCompareRouteDecisionPromptSubmission } from './agent-workspace-model-compare-editor.ts';
+import { buildAgentResearchReportPromptSubmission } from './agent-workspace-research-report-editor.ts';
+import { buildAgentResearchRunPromptSubmission } from './agent-workspace-research-run-editor.ts';
+import { buildAgentResearchSourcePromptSubmission } from './agent-workspace-research-source-editor.ts';
 import { buildAgentReminderScheduleEditorSubmission } from './agent-workspace-reminder-schedule-editor.ts';
 import { buildAgentRoutineScheduleEditorSubmission } from './agent-workspace-routine-schedule-editor.ts';
 import { buildAgentWorkspaceWebResearchSubmission } from './agent-workspace-web-research-editor.ts';
@@ -12,6 +19,9 @@ type AgentWorkspaceCommandEditorKind = AgentWorkspaceBasicCommandEditorKind | Ex
   AgentWorkspaceEditorKind,
   'web-research'
   | 'web-fetch'
+  | 'research-run'
+  | 'research-source'
+  | 'research-report'
   | 'knowledge-url'
   | 'knowledge-urls'
   | 'knowledge-file'
@@ -20,6 +30,32 @@ type AgentWorkspaceCommandEditorKind = AgentWorkspaceBasicCommandEditorKind | Ex
   | 'knowledge-reindex'
   | 'knowledge-search'
   | 'knowledge-ask'
+  | 'model-compare'
+  | 'document-browse'
+  | 'document-show'
+  | 'document-create'
+  | 'document-update'
+  | 'document-review'
+  | 'document-comment'
+  | 'document-resolve-comment'
+  | 'document-suggest'
+  | 'document-accept-suggestion'
+  | 'document-reject-suggestion'
+  | 'document-insert-artifact'
+  | 'document-attach-artifact'
+  | 'document-export'
+  | 'document-reviewer-readiness'
+  | 'document-review-packet-wizard'
+  | 'document-review-packet-preset'
+  | 'document-review-packet-preset-refresh'
+  | 'document-review-packet-share'
+  | 'model-compare-review'
+  | 'model-compare-handoff-diff'
+  | 'model-compare-judge'
+  | 'model-compare-apply'
+  | 'model-compare-route-decision'
+  | 'model-compare-export'
+  | 'model-compare-analytics'
   | 'mcp-server'
   | 'notify-webhook'
   | 'notify-webhook-remove'
@@ -35,6 +71,11 @@ type AgentWorkspaceCommandEditorKind = AgentWorkspaceBasicCommandEditorKind | Ex
   | 'knowledge-bookmarks'
   | 'tts-prompt'
   | 'image-input'
+  | 'artifact-browser'
+  | 'artifact-show'
+  | 'artifact-export-file'
+  | 'artifact-export-package'
+  | 'artifact-promote-knowledge'
   | 'skill-bundle'
   | 'persona-discovery-import'
   | 'routine-discovery-import'
@@ -82,9 +123,43 @@ type AgentWorkspaceCommandEditorSubmission =
 export function isAgentWorkspaceCommandEditorKind(kind: AgentWorkspaceEditorKind): kind is AgentWorkspaceCommandEditorKind {
   return kind === 'web-research'
     || kind === 'web-fetch'
+    || kind === 'research-run'
+    || kind === 'research-source'
+    || kind === 'research-report'
     || kind === 'knowledge-url'
     || kind === 'knowledge-search'
     || kind === 'knowledge-ask'
+    || kind === 'artifact-browser'
+    || kind === 'artifact-show'
+    || kind === 'artifact-export-file'
+    || kind === 'artifact-export-package'
+    || kind === 'artifact-promote-knowledge'
+    || kind === 'model-compare'
+    || kind === 'document-browse'
+    || kind === 'document-show'
+    || kind === 'document-create'
+    || kind === 'document-update'
+    || kind === 'document-review'
+    || kind === 'document-comment'
+    || kind === 'document-resolve-comment'
+    || kind === 'document-suggest'
+    || kind === 'document-accept-suggestion'
+    || kind === 'document-reject-suggestion'
+    || kind === 'document-insert-artifact'
+    || kind === 'document-attach-artifact'
+    || kind === 'document-export'
+    || kind === 'document-reviewer-readiness'
+    || kind === 'document-review-packet-wizard'
+    || kind === 'document-review-packet-preset'
+    || kind === 'document-review-packet-preset-refresh'
+    || kind === 'document-review-packet-share'
+    || kind === 'model-compare-review'
+    || kind === 'model-compare-handoff-diff'
+    || kind === 'model-compare-judge'
+    || kind === 'model-compare-apply'
+    || kind === 'model-compare-route-decision'
+    || kind === 'model-compare-export'
+    || kind === 'model-compare-analytics'
     || kind === 'routine-schedule'
     || kind === 'reminder-schedule'
     || isAgentWorkspaceBasicCommandEditorKind(kind);
@@ -99,10 +174,87 @@ export function buildAgentWorkspaceCommandEditorSubmission(
   if (editor.kind === 'web-research' || editor.kind === 'web-fetch') {
     return buildAgentWorkspaceWebResearchSubmission(editor, readField, promptDispatchAvailable);
   }
+  if (editor.kind === 'research-report') {
+    return buildAgentResearchReportPromptSubmission(editor, readField, promptDispatchAvailable);
+  }
+  if (editor.kind === 'research-run') {
+    return buildAgentResearchRunPromptSubmission(editor, readField, promptDispatchAvailable);
+  }
+  if (editor.kind === 'research-source') {
+    return buildAgentResearchSourcePromptSubmission(editor, readField, promptDispatchAvailable);
+  }
   if (editor.kind === 'knowledge-url') return buildAgentKnowledgeUrlEditorSubmission(editor, readField, commandDispatchAvailable);
   if (editor.kind === 'knowledge-search' || editor.kind === 'knowledge-ask') {
     return buildAgentKnowledgeQueryEditorSubmission(editor, readField, commandDispatchAvailable);
   }
+  if (editor.kind === 'artifact-browser' || editor.kind === 'artifact-show') {
+    return buildAgentArtifactBrowserPromptSubmission(editor, readField, promptDispatchAvailable);
+  }
+  if (editor.kind === 'artifact-export-file') {
+    return buildAgentArtifactExportPromptSubmission(editor, readField, promptDispatchAvailable);
+  }
+  if (editor.kind === 'artifact-export-package') {
+    return buildAgentArtifactPackagePromptSubmission(editor, readField, promptDispatchAvailable);
+  }
+  if (editor.kind === 'artifact-promote-knowledge') {
+    return buildAgentArtifactPromoteKnowledgePromptSubmission(editor, readField, promptDispatchAvailable);
+  }
+  if (
+    editor.kind === 'document-browse'
+    || editor.kind === 'document-show'
+    || editor.kind === 'document-create'
+    || editor.kind === 'document-update'
+    || editor.kind === 'document-review'
+    || editor.kind === 'document-comment'
+    || editor.kind === 'document-resolve-comment'
+    || editor.kind === 'document-suggest'
+    || editor.kind === 'document-accept-suggestion'
+    || editor.kind === 'document-reject-suggestion'
+    || editor.kind === 'document-insert-artifact'
+    || editor.kind === 'document-attach-artifact'
+    || editor.kind === 'document-export'
+  ) {
+    return buildAgentDocumentPromptSubmission(editor, readField, promptDispatchAvailable);
+  }
+  if (editor.kind === 'document-reviewer-readiness') {
+    return buildAgentDocumentReviewerReadinessPromptSubmission(editor, readField, promptDispatchAvailable);
+  }
+  if (editor.kind === 'document-review-packet-wizard') {
+    return buildAgentDocumentReviewPacketWizardPromptSubmission(editor, readField, promptDispatchAvailable);
+  }
+  if (editor.kind === 'document-review-packet-preset') {
+    return buildAgentDocumentReviewPacketPresetPromptSubmission(editor, readField, promptDispatchAvailable);
+  }
+  if (editor.kind === 'document-review-packet-preset-refresh') {
+    return buildAgentDocumentReviewPacketPresetRefreshPromptSubmission(editor, readField, promptDispatchAvailable);
+  }
+  if (editor.kind === 'document-review-packet-share') {
+    return buildAgentDocumentReviewPacketSharePromptSubmission(editor, readField, promptDispatchAvailable);
+  }
+  if (editor.kind === 'model-compare' || editor.kind === 'local-model-benchmark') {
+    return buildAgentModelComparePromptSubmission(editor, readField, promptDispatchAvailable);
+  }
+  if (editor.kind === 'model-compare-review') {
+    return buildAgentModelCompareReviewPromptSubmission(editor, readField, promptDispatchAvailable);
+  }
+  if (editor.kind === 'model-compare-handoff-diff') {
+    return buildAgentModelCompareHandoffDiffPromptSubmission(editor, readField, promptDispatchAvailable);
+  }
+  if (editor.kind === 'model-compare-judge') {
+    return buildAgentModelCompareJudgmentPromptSubmission(editor, readField, promptDispatchAvailable);
+  }
+  if (editor.kind === 'model-compare-apply') {
+    return buildAgentModelCompareApplyPromptSubmission(editor, readField, promptDispatchAvailable);
+  }
+  if (editor.kind === 'model-compare-route-decision') {
+    return buildAgentModelCompareRouteDecisionPromptSubmission(editor, readField, promptDispatchAvailable);
+  }
+  if (editor.kind === 'model-compare-export') {
+    return buildAgentModelCompareExportPromptSubmission(editor, readField, promptDispatchAvailable);
+  }
+  if (editor.kind === 'model-compare-analytics') {
+    return buildAgentModelCompareAnalyticsPromptSubmission(editor, readField, promptDispatchAvailable);
+  }
   if (isAgentWorkspaceBasicCommandEditorKind(editor.kind)) {
     return buildAgentWorkspaceBasicCommandEditorSubmission(editor, readField, commandDispatchAvailable);
   }