@pellux/goodvibes-agent 1.1.7 → 1.3.0

package/src/cli/agent-knowledge-command.ts

@@ -282,7 +282,7 @@ export async function handleAgentKnowledgeCommand(runtime: CliCommandRuntime): P
     };
   }
 
-  if (normalized === 'ingest-file' || normalized === 'ingest-artifact') {
+  if (normalized === 'ingest-file') {
     const values = commandValues(rest);
     const path = values[0];
     if (!path) return { output: 'Usage: goodvibes-agent knowledge ingest-file <path> [--title <title>] [--tags a,b] [--folder <path>] --yes', exitCode: 2 };
@@ -326,6 +326,49 @@ export async function handleAgentKnowledgeCommand(runtime: CliCommandRuntime): P
     };
   }
 
+  if (normalized === 'ingest-artifact') {
+    const values = commandValues(rest);
+    const artifactId = values[0];
+    if (!artifactId) return { output: 'Usage: goodvibes-agent knowledge ingest-artifact <artifactId> [--title <title>] [--tags a,b] [--folder <path>] --yes', exitCode: 2 };
+    if (!confirmation.present) {
+      const failure = {
+        ok: false,
+        kind: 'confirmation_required',
+        error: `Refusing to ingest artifact into Agent Knowledge ${artifactId} without --yes.`,
+        route: AGENT_KNOWLEDGE_METHODS.ingestArtifact.route,
+      };
+      return {
+        output: json ? JSON.stringify(failure, null, 2) : `${failure.error}\nUsage: goodvibes-agent knowledge ingest-artifact <artifactId> [--title <title>] [--tags a,b] [--folder <path>] --yes`,
+        exitCode: 2,
+      };
+    }
+    const title = readOptionValue(rest, '--title');
+    const tags = readStringList(rest, '--tags');
+    const folderPath = readOptionValue(rest, '--folder');
+    const connectorId = readOptionValue(rest, '--connector') ?? 'goodvibes-agent-artifact-browser';
+    const result = await runKnowledgeCall(runtime, AGENT_KNOWLEDGE_METHODS.ingestArtifact, async (connection) => (
+      await postAgentKnowledgeJson(connection, AGENT_KNOWLEDGE_METHODS.ingestArtifact.route, {
+        artifactId,
+        title,
+        tags,
+        folderPath,
+        connectorId,
+        metadata: { originSurface: 'goodvibes-agent-cli' },
+      })
+    ));
+    if (!result.ok) return { output: formatFailure(result, json), exitCode: 1 };
+    return {
+      output: formatJsonOrText(runtime.cli)(result, formatIngest(
+        result.data,
+        artifactId,
+        'ingest-artifact',
+        '/api/goodvibes-agent/knowledge/ingest/artifact',
+        'artifact',
+      )),
+      exitCode: 0,
+    };
+  }
+
   if (normalized === 'import-urls' || normalized === 'import-bookmarks') {
     const values = commandValues(rest);
     const path = values[0];
@@ -460,7 +503,7 @@ export async function handleAgentKnowledgeCommand(runtime: CliCommandRuntime): P
   }
 
   return {
-    output: 'Usage: goodvibes-agent knowledge [status|ask <question>|search <query>|list|sources|nodes|issues|get <id>|map|connectors|ingest-url <url> --yes|ingest-file <path> --yes|ingest-connector <id> --yes|import-urls <path> --yes|import-bookmarks <path> --yes|import-browser-history --yes|reindex --yes]',
+    output: 'Usage: goodvibes-agent knowledge [status|ask <question>|search <query>|list|sources|nodes|issues|get <id>|map|connectors|ingest-url <url> --yes|ingest-file <path> --yes|ingest-artifact <artifactId> --yes|ingest-connector <id> --yes|import-urls <path> --yes|import-bookmarks <path> --yes|import-browser-history --yes|reindex --yes]',
     exitCode: 2,
   };
 }

package/src/cli/help.ts

@@ -38,6 +38,7 @@ export function renderGoodVibesHelp(binary = 'goodvibes-agent'): string {
     '  /model                    Choose provider and model',
     '  /knowledge                Use isolated Agent Knowledge',
     '  /notes                    Open Agent-local scratchpad notes',
+    '  /vibe                    Inspect or create VIBE.md personality',
     '  /personas, /skills        Tune Agent-local behavior',
     '  /routines                 Run local routines in the main conversation',
     '  /schedule remind          Create confirmed reminders or inspect schedules',
@@ -309,6 +310,7 @@ const COMMAND_HELP: Record<string, CommandHelp> = {
       'knowledge connectors [connectorId|doctor <connectorId>]',
       'knowledge ingest-url <url> [--title <title>] [--tags a,b] --yes',
       'knowledge ingest-file <path> [--title <title>] [--tags a,b] --yes',
+      'knowledge ingest-artifact <artifactId> [--title <title>] [--tags a,b] --yes',
       'knowledge ingest-connector <connectorId> [--input <json-or-text>|--path <path>|--content <text>] --yes',
       'knowledge import-urls <path> --yes',
       'knowledge import-bookmarks <path> --yes',
@@ -325,6 +327,7 @@ const COMMAND_HELP: Record<string, CommandHelp> = {
       'knowledge connectors doctor url',
       'knowledge ingest-url https://example.com/page --title "Reference" --yes',
       'knowledge ingest-file ./docs/guide.md --title "Guide" --yes',
+      'knowledge ingest-artifact artifact-123 --title "Reviewed Export" --yes',
       'knowledge ingest-connector url --input https://example.com/reference --yes',
       'knowledge import-urls ~/agent-links.txt --yes',
       'knowledge import-browser-history --browsers chrome,firefox --sources history,bookmark --yes',

package/src/cli/profiles-command.ts

@@ -97,25 +97,28 @@ function renderProfilesResult(result: AgentRuntimeProfileCommandResult): string
         `    persona ${template.personaName}`,
         `    skills ${template.skillNames.join(', ')}`,
         `    routines ${template.routineNames.join(', ')}`,
-      ].join('\n')),
+        template.vibeIncluded ? '    vibe included' : '',
+      ].filter(Boolean).join('\n')),
       'Use goodvibes-agent profiles create <name> --template <id> --yes',
-      'Export/edit/import with goodvibes-agent profiles templates export <id> <path> --yes',
+      'Export/edit/import with goodvibes-agent profiles templates export <id> <path> [--include-vibe] --yes',
     ].join('\n');
   }
   if (result.kind === 'agent.profiles.template.export' && result.data?.template && result.data.path) {
     return [
       `Agent starter template exported: ${result.data.template.id}`,
       `  path ${result.data.path}`,
+      result.data.template.vibeIncluded ? '  vibe included' : '',
       '  edit the JSON, then import it with goodvibes-agent profiles templates import <path> --yes',
-    ].join('\n');
+    ].filter(Boolean).join('\n');
   }
   if (result.kind === 'agent.profiles.template.import' && result.data?.template) {
     return [
       `Agent starter template imported: ${result.data.template.id}`,
       `  name ${result.data.template.name}`,
       `  origin ${formatAgentRecordSource(result.data.template.source)}`,
+      result.data.template.vibeIncluded ? '  vibe included' : '',
       `  use goodvibes-agent profiles create <name> --template ${result.data.template.id} --yes`,
-    ].join('\n');
+    ].filter(Boolean).join('\n');
   }
   if (result.kind === 'agent.profiles.template.from_discovered' && result.data?.template) {
     return [
@@ -124,8 +127,9 @@ function renderProfilesResult(result: AgentRuntimeProfileCommandResult): string
       `  persona ${result.data.template.personaName}`,
       `  skills ${result.data.template.skillNames.join(', ')}`,
       `  routines ${result.data.template.routineNames.join(', ')}`,
+      result.data.template.vibeIncluded ? '  vibe included' : '',
       `  use goodvibes-agent profiles create <name> --template ${result.data.template.id} --yes`,
-    ].join('\n');
+    ].filter(Boolean).join('\n');
   }
   if (result.kind === 'agent.profiles.default') {
     const selected = result.data?.selectedProfile;
@@ -157,8 +161,9 @@ function renderProfilesResult(result: AgentRuntimeProfileCommandResult): string
       `  persona ${result.data.template.personaName}`,
       `  skills ${result.data.template.skillNames.join(', ')}`,
       `  routines ${result.data.template.routineNames.join(', ')}`,
+      result.data.template.vibeIncluded ? '  vibe included' : '',
       `  launch: ${result.data.nextCommand ?? `goodvibes-agent --agent-profile ${result.data.profile.id}`}`,
-    ].join('\n');
+    ].filter(Boolean).join('\n');
   }
   const profile = result.data?.profile;
   if (result.kind === 'agent.profiles.create' && profile) {
@@ -169,9 +174,10 @@ function renderProfilesResult(result: AgentRuntimeProfileCommandResult): string
       ...(template ? [
         `  starter: ${template.id} (${template.name})`,
         `  seeded: ${template.personaIds.length} persona, ${template.skillIds.length} skills, ${template.routineIds.length} routine`,
+        template.vibePath ? `  vibe ${template.vibePath}` : '',
       ] : []),
       `  use ${result.data?.nextCommand ?? `goodvibes-agent --agent-profile ${profile.id}`}`,
-    ].join('\n');
+    ].filter(Boolean).join('\n');
   }
   if (result.kind === 'agent.profiles.delete' && profile) {
     return [
@@ -211,7 +217,7 @@ export async function handleProfilesCommand(runtime: ProfilesCommandRuntime): Pr
           const result: AgentRuntimeProfileCommandResult = {
             ok: false,
             kind: 'agent.profiles.error',
-            error: 'Usage: goodvibes-agent profiles templates from-discovered <id> [--name <name>] [--description <summary>] [--persona <name>] [--skills all|name,name] [--routines all|name,name] [--replace] --yes',
+            error: 'Usage: goodvibes-agent profiles templates from-discovered <id> [--name <name>] [--description <summary>] [--persona <name>] [--skills all|name,name] [--routines all|name,name] [--include-vibe] [--replace] --yes',
           };
           return {
             output: renderProfilesOutput(result, runtime.cli.flags.outputFormat),
@@ -239,6 +245,7 @@ export async function handleProfilesCommand(runtime: ProfilesCommandRuntime): Pr
           persona: flagValue(rawRest, ['--persona']) ?? undefined,
           skills: parseCsvFlag(rawRest, ['--skills']),
           routines: parseCsvFlag(rawRest, ['--routines']),
+          includeVibe: rawRest.includes('--include-vibe'),
           replace: hasYes(rawRest) && rawRest.includes('--replace'),
         });
         const result: AgentRuntimeProfileCommandResult = {
@@ -256,7 +263,7 @@ export async function handleProfilesCommand(runtime: ProfilesCommandRuntime): Pr
           const result: AgentRuntimeProfileCommandResult = {
             ok: false,
             kind: 'agent.profiles.error',
-            error: 'Usage: goodvibes-agent profiles templates export <id> <path> --yes',
+            error: 'Usage: goodvibes-agent profiles templates export <id> <path> [--include-vibe] --yes',
           };
           return {
             output: renderProfilesOutput(result, runtime.cli.flags.outputFormat),
@@ -274,7 +281,13 @@ export async function handleProfilesCommand(runtime: ProfilesCommandRuntime): Pr
             exitCode: 2,
           };
         }
-        const template = exportAgentRuntimeProfileTemplate(runtime.homeDirectory, templateId, templatePath);
+        const template = exportAgentRuntimeProfileTemplate(runtime.homeDirectory, templateId, templatePath, {
+          includeVibe: rawRest.includes('--include-vibe'),
+          shellPaths: {
+            homeDirectory: runtime.homeDirectory,
+            workingDirectory: runtime.workingDirectory,
+          },
+        });
         const result: AgentRuntimeProfileCommandResult = {
           ok: true,
           kind: 'agent.profiles.template.export',
@@ -506,7 +519,7 @@ export async function handleProfilesCommand(runtime: ProfilesCommandRuntime): Pr
         const result: AgentRuntimeProfileCommandResult = {
           ok: false,
           kind: 'agent.profiles.error',
-          error: 'Usage: goodvibes-agent profiles create-from-discovered <name> [--template-id <id>] [--profile-name <display>] [--description <summary>] [--persona <name>] [--skills all|name,name] [--routines all|name,name] [--replace] --yes',
+          error: 'Usage: goodvibes-agent profiles create-from-discovered <name> [--template-id <id>] [--profile-name <display>] [--description <summary>] [--persona <name>] [--skills all|name,name] [--routines all|name,name] [--include-vibe] [--replace] --yes',
         };
         return {
           output: renderProfilesOutput(result, runtime.cli.flags.outputFormat),
@@ -535,6 +548,7 @@ export async function handleProfilesCommand(runtime: ProfilesCommandRuntime): Pr
         persona: flagValue(rawRest, ['--persona']) ?? undefined,
         skills: parseCsvFlag(rawRest, ['--skills']),
         routines: parseCsvFlag(rawRest, ['--routines']),
+        includeVibe: rawRest.includes('--include-vibe'),
         replace: rawRest.includes('--replace'),
       });
       const result: AgentRuntimeProfileCommandResult = {

package/src/config/agent-settings-policy.ts

@@ -1,20 +1,7 @@
-export const AGENT_EXTERNAL_HOST_SETTING_LOCK_REASON = 'GoodVibes Agent uses a connected GoodVibes host. Change host lifecycle and bind posture from the owning host; Agent settings are read-only for those controls.';
+export const AGENT_EXTERNAL_HOST_SETTING_LOCK_REASON = 'This raw daemon/listener danger toggle is protected. Use an explicit confirmed operator action or setup command for lifecycle changes.';
 
 const AGENT_HIDDEN_SETTING_PREFIXES = [
-  ['cloud', 'flare.'].join(''),
-  ['surfaces.', 'home', 'assistant.'].join(''),
-  'batch.',
-  'controlPlane.',
   'danger.',
-  'httpListener.',
-  'network.',
-  'orchestration.',
-  'runtime.',
-  'service.',
-  'sandbox.',
-  'web.',
-  'watchers.',
-  'wrfc.',
 ] as const;
 
 const AGENT_HIDDEN_SETTING_KEYS = new Set<string>([
@@ -22,10 +9,6 @@ const AGENT_HIDDEN_SETTING_KEYS = new Set<string>([
 ]);
 
 const EXTERNAL_HOST_SETTING_PREFIXES = [
-  'service.',
-  'controlPlane.',
-  'httpListener.',
-  'web.',
 ] as const;
 
 const EXTERNAL_HOST_SETTING_KEYS = new Set<string>([

package/src/input/agent-workspace-activation.ts

@@ -1,6 +1,13 @@
 import { createLearnedBehaviorEditor, createLocalEditor, createProfileEditor } from './agent-workspace-editors.ts';
+import { createAgentArtifactBrowserEditor, createAgentArtifactExportEditor, createAgentArtifactPackageEditor, createAgentArtifactPromoteKnowledgeEditor, createAgentArtifactShowEditor } from './agent-workspace-artifact-browser-editor.ts';
+import { createAgentDocumentAcceptSuggestionEditor, createAgentDocumentAttachArtifactEditor, createAgentDocumentBrowseEditor, createAgentDocumentCommentEditor, createAgentDocumentCreateEditor, createAgentDocumentExportEditor, createAgentDocumentInsertArtifactEditor, createAgentDocumentRejectSuggestionEditor, createAgentDocumentResolveCommentEditor, createAgentDocumentReviewEditor, createAgentDocumentShowEditor, createAgentDocumentSuggestEditor, createAgentDocumentUpdateEditor } from './agent-workspace-document-editor.ts';
+import { createAgentDocumentReviewerReadinessEditor, createAgentDocumentReviewPacketPresetEditor, createAgentDocumentReviewPacketPresetRefreshEditor, createAgentDocumentReviewPacketShareEditor, createAgentDocumentReviewPacketWizardEditor } from './agent-workspace-document-ops-editor.ts';
 import { createAgentWorkspaceBasicCommandEditor, isAgentWorkspaceBasicCommandEditorKind } from './agent-workspace-basic-command-editors.ts';
 import { createAgentKnowledgeQueryEditor } from './agent-workspace-knowledge-query-editor.ts';
+import { createAgentLocalModelBenchmarkEditor, createAgentModelCompareAnalyticsEditor, createAgentModelCompareApplyEditor, createAgentModelCompareEditor, createAgentModelCompareExportEditor, createAgentModelCompareHandoffDiffEditor, createAgentModelCompareJudgmentEditor, createAgentModelCompareReviewEditor, createAgentModelCompareRouteDecisionEditor } from './agent-workspace-model-compare-editor.ts';
+import { createAgentResearchReportEditor } from './agent-workspace-research-report-editor.ts';
+import { createAgentResearchRunEditor } from './agent-workspace-research-run-editor.ts';
+import { createAgentResearchSourceEditor } from './agent-workspace-research-source-editor.ts';
 import { createReminderScheduleEditor } from './agent-workspace-reminder-schedule-editor.ts';
 import { createRoutineScheduleEditor } from './agent-workspace-routine-schedule-editor.ts';
 import { createAgentWorkspaceWebResearchEditor } from './agent-workspace-web-research-editor.ts';
@@ -15,6 +22,8 @@ import type {
   AgentWorkspaceLocalEditorKind,
   AgentWorkspaceLocalLibraryItem,
   AgentWorkspaceLocalOperation,
+  AgentWorkspaceRecentReviewerHandoffArtifact,
+  AgentWorkspaceReviewPacketDefaults,
   AgentWorkspaceRuntimeSnapshot,
   AgentWorkspaceRuntimeStarterTemplateItem,
 } from './agent-workspace-types.ts';
@@ -38,6 +47,7 @@ interface AgentWorkspaceActivationHost {
   applyLocalLibraryOperation(operation: AgentWorkspaceLocalOperation): void;
   applySettingAction(action: AgentWorkspaceCategory['actions'][number], requestRender?: () => void): void;
   importTuiSettings(requestRender?: () => void): void;
+  applySetupCheckpointAction(action: AgentWorkspaceCategory['actions'][number], requestRender?: () => void): void;
   openModelPickerAction(action: AgentWorkspaceCategory['actions'][number], requestRender?: () => void): void;
   openSettingsModalAction(action: AgentWorkspaceCategory['actions'][number], requestRender?: () => void): void;
   completeOnboarding(): void;
@@ -69,6 +79,10 @@ export function activateAgentWorkspaceSelection(
     workspace.importTuiSettings(requestRender);
     return;
   }
+  if (action.kind === 'setup-checkpoint') {
+    workspace.applySetupCheckpointAction(action, requestRender);
+    return;
+  }
   if (action.kind === 'model-picker') {
     workspace.openModelPickerAction(action, requestRender);
     return;
@@ -81,6 +95,8 @@ export function activateAgentWorkspaceSelection(
     const editor = createAgentWorkspaceEditor(action.editorKind, {
       runtimeStarterTemplates: workspace.runtimeSnapshot?.runtimeStarterTemplates ?? [],
       selectedRoutine: workspace.selectedLocalLibraryItem('routine'),
+      recentReviewerHandoffArtifacts: workspace.runtimeSnapshot?.recentReviewerHandoffArtifacts ?? [],
+      reviewPacketDefaults: workspace.runtimeSnapshot?.reviewPacketDefaults ?? null,
     });
     if (!editor) {
       workspace.status = `Editor unavailable: ${action.editorKind}.`;
@@ -178,12 +194,49 @@ export function createAgentWorkspaceEditor(
   options: {
     readonly runtimeStarterTemplates?: readonly AgentWorkspaceRuntimeStarterTemplateItem[];
     readonly selectedRoutine?: AgentWorkspaceLocalLibraryItem | null;
+    readonly recentReviewerHandoffArtifacts?: readonly AgentWorkspaceRecentReviewerHandoffArtifact[];
+    readonly reviewPacketDefaults?: AgentWorkspaceReviewPacketDefaults | null;
   } = {},
 ): AgentWorkspaceLocalEditor | null {
   if (editorKind === 'profile') return createProfileEditor(options.runtimeStarterTemplates ?? []);
   if (editorKind === 'learned-behavior') return createLearnedBehaviorEditor();
   if (editorKind === 'web-research') return createAgentWorkspaceWebResearchEditor('research');
   if (editorKind === 'web-fetch') return createAgentWorkspaceWebResearchEditor('fetch');
+  if (editorKind === 'research-run') return createAgentResearchRunEditor();
+  if (editorKind === 'research-source') return createAgentResearchSourceEditor();
+  if (editorKind === 'research-report') return createAgentResearchReportEditor();
+  if (editorKind === 'artifact-browser') return createAgentArtifactBrowserEditor();
+  if (editorKind === 'artifact-show') return createAgentArtifactShowEditor();
+  if (editorKind === 'artifact-export-file') return createAgentArtifactExportEditor();
+  if (editorKind === 'artifact-export-package') return createAgentArtifactPackageEditor();
+  if (editorKind === 'artifact-promote-knowledge') return createAgentArtifactPromoteKnowledgeEditor();
+  if (editorKind === 'document-browse') return createAgentDocumentBrowseEditor();
+  if (editorKind === 'document-show') return createAgentDocumentShowEditor();
+  if (editorKind === 'document-create') return createAgentDocumentCreateEditor();
+  if (editorKind === 'document-update') return createAgentDocumentUpdateEditor();
+  if (editorKind === 'document-review') return createAgentDocumentReviewEditor();
+  if (editorKind === 'document-comment') return createAgentDocumentCommentEditor();
+  if (editorKind === 'document-resolve-comment') return createAgentDocumentResolveCommentEditor();
+  if (editorKind === 'document-suggest') return createAgentDocumentSuggestEditor();
+  if (editorKind === 'document-accept-suggestion') return createAgentDocumentAcceptSuggestionEditor();
+  if (editorKind === 'document-reject-suggestion') return createAgentDocumentRejectSuggestionEditor();
+  if (editorKind === 'document-insert-artifact') return createAgentDocumentInsertArtifactEditor();
+  if (editorKind === 'document-attach-artifact') return createAgentDocumentAttachArtifactEditor();
+  if (editorKind === 'document-export') return createAgentDocumentExportEditor(options.reviewPacketDefaults ?? null);
+  if (editorKind === 'document-reviewer-readiness') return createAgentDocumentReviewerReadinessEditor();
+  if (editorKind === 'document-review-packet-wizard') return createAgentDocumentReviewPacketWizardEditor();
+  if (editorKind === 'document-review-packet-preset') return createAgentDocumentReviewPacketPresetEditor(options.reviewPacketDefaults ?? null);
+  if (editorKind === 'document-review-packet-preset-refresh') return createAgentDocumentReviewPacketPresetRefreshEditor();
+  if (editorKind === 'document-review-packet-share') return createAgentDocumentReviewPacketShareEditor(options.reviewPacketDefaults ?? null);
+  if (editorKind === 'model-compare') return createAgentModelCompareEditor();
+  if (editorKind === 'local-model-benchmark') return createAgentLocalModelBenchmarkEditor();
+  if (editorKind === 'model-compare-review') return createAgentModelCompareReviewEditor();
+  if (editorKind === 'model-compare-handoff-diff') return createAgentModelCompareHandoffDiffEditor(options.recentReviewerHandoffArtifacts ?? []);
+  if (editorKind === 'model-compare-judge') return createAgentModelCompareJudgmentEditor();
+  if (editorKind === 'model-compare-apply') return createAgentModelCompareApplyEditor(options.reviewPacketDefaults ?? null);
+  if (editorKind === 'model-compare-route-decision') return createAgentModelCompareRouteDecisionEditor(options.reviewPacketDefaults ?? null);
+  if (editorKind === 'model-compare-export') return createAgentModelCompareExportEditor(options.reviewPacketDefaults ?? null);
+  if (editorKind === 'model-compare-analytics') return createAgentModelCompareAnalyticsEditor();
   if (editorKind && isAgentWorkspaceBasicCommandEditorKind(editorKind)) return createAgentWorkspaceBasicCommandEditor(editorKind);
   if (editorKind === 'knowledge-ask') return createAgentKnowledgeQueryEditor('ask');
   if (editorKind === 'knowledge-search') return createAgentKnowledgeQueryEditor('search');