@pellux/goodvibes-agent 1.1.7 → 1.3.0

package/src/tools/agent-harness-workspace-actions.ts

@@ -27,6 +27,8 @@ export interface AgentHarnessWorkspaceActionArgs {
 export interface WorkspaceEditorContext {
   readonly runtimeStarterTemplates: AgentWorkspaceRuntimeSnapshot['runtimeStarterTemplates'];
   readonly selectedRoutine: AgentWorkspaceLocalLibraryItem | null;
+  readonly recentReviewerHandoffArtifacts: AgentWorkspaceRuntimeSnapshot['recentReviewerHandoffArtifacts'];
+  readonly reviewPacketDefaults: AgentWorkspaceRuntimeSnapshot['reviewPacketDefaults'] | null;
 }
 
 export interface WorkspaceActionLookup {
@@ -107,7 +109,7 @@ function previewText(value: string, maxLength = 56): string {
 function commandRouteHint(command: string): string {
   const parsed = parseSlashCommand(command);
   const commandName = parsed.name || command.replace(/^\//, '').trim().split(/\s+/)[0] || command;
-  return describeCommandPolicy(commandName).preferredModelTool ?? 'agent_harness mode:"run_command"';
+  return describeCommandPolicy(commandName).preferredModelTool ?? `workspace action:"run_command" commandName:"${commandName}"`;
 }
 
 function editorRouteHint(editorKind: AgentWorkspaceEditorKind): string {
@@ -130,17 +132,44 @@ function editorRouteHint(editorKind: AgentWorkspaceEditorKind): string {
     editorKind === 'knowledge-reindex'
     || editorKind === 'knowledge-review-issue'
     || editorKind === 'knowledge-consolidate'
-  ) return 'agent_harness mode:"run_workspace_action"';
+  ) return 'workspace action:"run"';
   if (editorKind.startsWith('knowledge-')) return 'agent_knowledge';
+  if (
+    editorKind === 'document-review-packet-preset'
+    || editorKind === 'document-review-packet-preset-refresh'
+  ) return 'agent_review_packet_presets';
+  if (editorKind === 'document-review-packet-share') return 'agent_review_packet_share';
+  if (editorKind.startsWith('document-')) return 'agent_documents';
+  if (
+    editorKind === 'artifact-browser'
+    || editorKind === 'artifact-show'
+    || editorKind === 'artifact-export-file'
+    || editorKind === 'artifact-export-package'
+  ) return 'agent_artifacts';
+  if (editorKind === 'artifact-promote-knowledge') return 'agent_knowledge_ingest';
   if (editorKind === 'web-research' || editorKind === 'web-fetch') return 'main conversation prompt';
+  if (editorKind === 'research-run') return 'research action:"create_run"';
+  if (editorKind === 'research-source') return 'research action:"add_source"';
+  if (editorKind === 'research-report') return 'research action:"report"';
   if (editorKind === 'media-generate') return 'agent_media_generate';
+  if (
+    editorKind === 'model-compare'
+    || editorKind === 'local-model-benchmark'
+    || editorKind === 'model-compare-review'
+    || editorKind === 'model-compare-judge'
+    || editorKind === 'model-compare-apply'
+    || editorKind === 'model-compare-route-decision'
+    || editorKind === 'model-compare-export'
+    || editorKind === 'model-compare-analytics'
+  ) return 'agent_model_compare';
   if (editorKind === 'channel-send') return 'agent_channel_send';
   if (editorKind === 'notify-send' || editorKind === 'notify-webhook-test') return 'agent_notify';
-  if (editorKind === 'reminder-schedule') return 'agent_reminder_schedule';
+  if (editorKind === 'reminder-schedule') return 'schedule action:"remind"';
+  if (editorKind === 'schedule-edit') return 'schedule action:"edit"';
+  if (editorKind === 'schedule-run') return 'schedule action:"run"';
   if (
     editorKind.startsWith('approval-')
     || editorKind.startsWith('automation-')
-    || editorKind === 'schedule-run'
   ) return 'agent_operator_action';
   if (editorKind.startsWith('workplan-') || editorKind.startsWith('plan-') || editorKind.startsWith('task-')) return 'agent_work_plan';
   return 'agent_harness mode:"run_workspace_action"';
@@ -153,12 +182,51 @@ function localActionRouteHint(action: AgentWorkspaceAction): string {
 }
 
 function workspaceActionRouteHint(action: AgentWorkspaceAction): string {
+  if (action.kind === 'settings-import') return 'settings action:"import"';
+  if (action.kind === 'setup-checkpoint') {
+    if (action.setupCheckpointOperation === 'mark-current') return 'agent_harness mode:"mark_setup_checkpoint" confirm:true explicitUserRequest:"..."';
+    if (action.setupCheckpointOperation === 'clear') return 'agent_harness mode:"clear_setup_checkpoint" confirm:true explicitUserRequest:"..."';
+    return 'agent_harness mode:"setup_checkpoint"';
+  }
+  if (action.id === 'account-route-readiness') return 'models action:"status" includeParameters:true';
+  if (action.id === 'account-local-model-cookbook') return 'models action:"local"';
+  if (action.id === 'account-local-server-health') return 'models action:"smoke" confirm:true';
+  if (action.id === 'account-run-local-model-benchmark') return 'agent_model_compare';
+  if (action.id === 'account-local-benchmark-evidence') return 'models action:"local" includeParameters:true';
+  if (action.id === 'assistant-browser-cockpit') return 'computer action:"open_browser"';
+  if (action.id === 'research-briefing') return 'research action:"briefing"';
+  if (action.id === 'research-workflow-plan') return 'research action:"plan"';
+  if (action.id === 'research-runner-readiness') return 'research action:"runner"';
+  if (action.id === 'research-run-queue') return 'research action:"runs"';
+  if (action.id === 'research-public-search') return 'research action:"search"';
+  if (action.id === 'research-source-queue') return 'research action:"sources"';
+  if (action.id === 'research-report-artifacts') return 'research action:"reports"';
+  if (action.id === 'work-background-processes') return 'execution action:"processes"';
+  if (action.id === 'work-process-capabilities') return 'process action:"capabilities"';
+  if (action.id === 'context-project-files') return 'context action:"files"';
+  if (action.id === 'context-project-file') return 'context action:"file"';
+  if (action.id === 'context-prompt-context') return 'context action:"prompt" includeParameters:true';
+  if (action.id === 'voice-workflow-posture') return 'device action:"voice"';
+  if (action.id === 'device-capability-map') return 'device action:"status"';
+  if (action.id === 'browser-cockpit-readiness') return 'computer action:"browser"';
+  if (action.id === 'personal-ops-briefing') return 'personal_ops action:"briefing"';
+  if (action.id === 'personal-ops-queue') return 'personal_ops action:"queue"';
+  if (action.id === 'personal-ops-intake') return 'personal_ops action:"intake"';
+  if (
+    action.id === 'personal-ops-autonomy-queue'
+    || action.id === 'work-autonomy-queue'
+    || action.id === 'schedule-autonomy-queue'
+  ) return 'autonomy action:"queue"';
+  if (action.id === 'memory-learning-curator') return 'memory action:"curator"';
+  if (action.id === 'memory-prompt-plan') return 'memory action:"curator" includeParameters:true';
+  if (action.id === 'memory-posture') return 'memory action:"status"';
   if (action.command) return commandRouteHint(action.command);
   if (action.editorKind) return editorRouteHint(action.editorKind);
   if (action.kind === 'local-selection' || action.kind === 'local-operation') return localActionRouteHint(action);
-  if (action.targetCategoryId || action.kind === 'workspace') return 'agent_harness mode:"open_ui_surface"';
+  // Compatibility detail route remains: agent_harness mode:"open_ui_surface".
+  if (action.targetCategoryId || action.kind === 'workspace') return 'workspace action:"open"';
   if (action.kind === 'guidance') return action.safety === 'blocked' ? 'main conversation policy' : 'main conversation';
-  return 'agent_harness mode:"workspace_action"';
+  return 'workspace action:"action"';
 }
 
 function selectedRoutineFromArgs(
@@ -177,11 +245,15 @@ export function buildWorkspaceEditorContext(context: CommandContext, args: Agent
     return {
       runtimeStarterTemplates: snapshot.runtimeStarterTemplates,
       selectedRoutine: selectedRoutineFromArgs(snapshot, args),
+      recentReviewerHandoffArtifacts: snapshot.recentReviewerHandoffArtifacts,
+      reviewPacketDefaults: snapshot.reviewPacketDefaults,
     };
   } catch {
     return {
       runtimeStarterTemplates: [],
       selectedRoutine: null,
+      recentReviewerHandoffArtifacts: [],
+      reviewPacketDefaults: null,
     };
   }
 }
@@ -193,6 +265,8 @@ export function createWorkspaceEditor(
   return createAgentWorkspaceEditor(editorKind, {
     runtimeStarterTemplates: editorContext?.runtimeStarterTemplates ?? [],
     selectedRoutine: editorKind === 'routine-schedule' ? editorContext?.selectedRoutine ?? null : null,
+    recentReviewerHandoffArtifacts: editorContext?.recentReviewerHandoffArtifacts ?? [],
+    reviewPacketDefaults: editorContext?.reviewPacketDefaults ?? null,
   });
 }
 
@@ -211,7 +285,7 @@ export function describeWorkspaceAction(
     detail: action.detail,
     kind: action.kind,
     safety: action.safety,
-    modelRoute: previewText(workspaceActionRouteHint(action)),
+    modelRoute: previewText(workspaceActionRouteHint(action), 72),
     ...(action.command ? { command: action.command } : {}),
     ...(action.targetCategoryId ? { targetCategoryId: action.targetCategoryId } : {}),
     ...(action.editorKind ? { editorKind: action.editorKind } : {}),
@@ -219,6 +293,38 @@ export function describeWorkspaceAction(
     ...(action.localOperation ? { localOperation: action.localOperation } : {}),
     ...(options.lookup ? { lookup: options.lookup } : {}),
     ...(editor ? { editor: describeWorkspaceEditor(editor) } : {}),
+    ...(action.kind === 'settings-import' ? {
+      modelExecution: {
+        route: 'settings-import',
+        dispatcher: 'run_workspace_action',
+        confirmation: 'required',
+        preview: 'available-without-confirmation',
+        note: 'Imports only Agent-owned shared GoodVibes settings and provider subscription state after explicit user confirmation.',
+      },
+    } : {}),
+    ...(action.kind === 'setup-checkpoint' ? {
+      setupCheckpointOperation: action.setupCheckpointOperation ?? 'show',
+      modelExecution: {
+        route: action.setupCheckpointOperation === 'mark-current'
+          ? 'mark_setup_checkpoint'
+          : action.setupCheckpointOperation === 'clear'
+            ? 'clear_setup_checkpoint'
+            : 'setup_checkpoint',
+        dispatcher: 'agent_harness',
+        confirmation: action.setupCheckpointOperation === 'show' ? 'not-required' : 'required',
+        note: 'Setup wizard checkpoints persist only the visible current setup step in Agent-owned state so first-run setup can resume across restarts.',
+      },
+    } : {}),
+    ...(action.id === 'assistant-browser-cockpit' ? {
+      modelExecution: {
+        route: 'open_ui_surface',
+        surfaceId: 'connected-browser-cockpit',
+        confirmation: 'required',
+        readinessRoute: 'agent_harness mode:"ui_surface" surfaceId:"connected-browser-cockpit" includeParameters:true',
+        fallback: 'Inspect host action:"service" endpointId:"web" or host action:"services" when the web cockpit is not enabled.',
+        note: 'Opens the connected-host browser/PWA cockpit through the configured web route; readiness inspection also reports certified workspace category coverage, mobile/PWA controls, and first-run receipt evidence without creating a separate Agent-hosted web app.',
+      },
+    } : {}),
     ...(action.kind === 'local-selection' || action.kind === 'local-operation' ? {
       modelExecution: describeLocalWorkspaceModelExecution(action),
     } : {}),
@@ -241,7 +347,7 @@ function describeWorkspaceActionSummary(
     summary: previewText(action.detail),
     kind: action.kind,
     safety: action.safety,
-    modelRoute: previewText(workspaceActionRouteHint(action)),
+    modelRoute: previewText(workspaceActionRouteHint(action), 72),
     ...(action.command ? { command: action.command } : {}),
     ...(action.targetCategoryId ? { targetCategoryId: action.targetCategoryId } : {}),
     ...(action.editorKind ? { editorKind: action.editorKind } : {}),

package/src/tools/agent-harness-workspace-editor-execution.ts

@@ -60,6 +60,220 @@ export function describeWorkspaceEditorModelExecution(editorKind: AgentWorkspace
       note: 'run_workspace_action returns the main-conversation prompt produced by this editor; use that prompt as the conversation task instead of creating a hidden nested turn.',
     };
   }
+  if (editorKind === 'research-report') {
+    return {
+      route: 'agent_research_report',
+      tool: 'agent_research_report',
+      action: 'save_research_report_artifact',
+      confirmation: 'required',
+      note: 'run_workspace_action saves one reviewed source-grounded report artifact with a visual packet, source map, and citation coverage. It does not ingest Agent Knowledge or send external messages.',
+    };
+  }
+  if (editorKind === 'research-run') {
+    return {
+      route: 'agent_research_runs',
+      tool: 'agent_research_runs',
+      action: 'create_research_run',
+      confirmation: 'required',
+      note: 'run_workspace_action creates one project-local visible research run with plan, next steps, source ids, checkpoint/resume/cancel routes, and no hidden background execution. Web research, source review, reports, Knowledge ingest, and external sends remain separate explicit actions.',
+    };
+  }
+  if (editorKind === 'research-source') {
+    return {
+      route: 'agent_research_sources',
+      tool: 'agent_research_sources',
+      action: 'add_source_candidate',
+      confirmation: 'required',
+      note: 'run_workspace_action adds one source to the project-local research queue. Report saving, Knowledge ingest, and external sends remain separate explicit actions.',
+    };
+  }
+  if (editorKind === 'artifact-browser') {
+    return {
+      route: 'agent_artifacts',
+      tool: 'agent_artifacts',
+      action: 'list_artifacts',
+      confirmation: 'not-required',
+      note: 'run_workspace_action searches saved Agent artifacts through the first-class read-only artifact browser. It never deletes artifacts or inlines binary/base64 bytes.',
+    };
+  }
+  if (editorKind === 'artifact-show') {
+    return {
+      route: 'agent_artifacts',
+      tool: 'agent_artifacts',
+      action: 'show_artifact',
+      confirmation: 'not-required',
+      note: 'run_workspace_action inspects one saved Agent artifact with redacted metadata and bounded text previews only.',
+    };
+  }
+  if (editorKind === 'artifact-export-file') {
+    return {
+      route: 'agent_artifacts',
+      tool: 'agent_artifacts',
+      action: 'export_artifact_file',
+      confirmation: 'required',
+      note: 'run_workspace_action copies one reviewed saved artifact to a workspace file after confirmation. It preserves exact bytes, refuses overwrite unless requested, and never deletes artifacts or prints content.',
+    };
+  }
+  if (editorKind === 'artifact-export-package') {
+    return {
+      route: 'agent_artifacts',
+      tool: 'agent_artifacts',
+      action: 'export_artifact_package',
+      confirmation: 'required',
+      note: 'run_workspace_action copies selected reviewed artifacts into a workspace package directory or ZIP archive after confirmation. It preserves exact bytes, writes a redacted manifest and README, refuses existing outputs unless overwrite is requested, and never deletes artifacts or prints content.',
+    };
+  }
+  if (editorKind === 'artifact-promote-knowledge') {
+    return {
+      route: 'agent_knowledge_ingest',
+      tool: 'agent_knowledge_ingest',
+      action: 'promote_artifact_to_knowledge',
+      confirmation: 'required',
+      note: 'run_workspace_action ingests one reviewed saved artifact into isolated Agent Knowledge by artifact id. It never writes default knowledge or deletes artifacts.',
+    };
+  }
+  if (
+    editorKind === 'document-browse'
+    || editorKind === 'document-show'
+    || editorKind === 'document-create'
+    || editorKind === 'document-update'
+    || editorKind === 'document-review'
+    || editorKind === 'document-comment'
+    || editorKind === 'document-resolve-comment'
+    || editorKind === 'document-suggest'
+    || editorKind === 'document-accept-suggestion'
+    || editorKind === 'document-reject-suggestion'
+    || editorKind === 'document-insert-artifact'
+    || editorKind === 'document-attach-artifact'
+    || editorKind === 'document-export'
+  ) {
+    return {
+      route: 'agent_documents',
+      tool: 'agent_documents',
+      action: editorKind.replace('document-', ''),
+      confirmation: editorKind === 'document-browse' || editorKind === 'document-show' ? 'not-required' : 'required',
+      note: 'run_workspace_action uses Agent-owned markdown drafts with version history, review comments, user-reviewed AI suggestions, artifact attachment, and artifact insertion. Export creates a saved markdown artifact with attachment metadata; insertion appends bounded text or a safe artifact reference. No default knowledge write occurs.',
+    };
+  }
+  if (editorKind === 'document-reviewer-readiness') {
+    return {
+      route: 'agent_harness',
+      tool: 'agent_harness',
+      action: 'inspect_reviewer_readiness_preflight',
+      confirmation: 'not-required',
+      note: 'run_workspace_action inspects the Document Ops reviewer-readiness lane before export, handoff archive, or model-route apply. It is read-only and returns exact repair routes.',
+    };
+  }
+  if (editorKind === 'document-review-packet-wizard') {
+    return {
+      route: 'agent_harness',
+      tool: 'agent_harness',
+      action: 'inspect_review_packet_wizard',
+      confirmation: 'not-required',
+      note: 'run_workspace_action inspects the Document Ops review packet wizard. It is read-only and returns progress, current step, backtrack routes, route-decision posture, and final evidence review guidance.',
+    };
+  }
+  if (editorKind === 'document-review-packet-preset') {
+    return {
+      route: 'agent_review_packet_presets',
+      tool: 'agent_review_packet_presets',
+      action: 'save_review_packet_preset',
+      confirmation: 'required',
+      note: 'run_workspace_action saves the current Document Ops packet ids as one reusable local preset artifact. It does not mutate document drafts, model routing, reviewer handoffs, or handoff archives.',
+    };
+  }
+  if (editorKind === 'document-review-packet-preset-refresh') {
+    return {
+      route: 'agent_review_packet_presets',
+      tool: 'agent_review_packet_presets',
+      action: 'refresh_review_packet_preset',
+      confirmation: 'required',
+      note: 'run_workspace_action saves one new local preset artifact from an existing preset freshness recommendation. It keeps the source preset intact and does not mutate document drafts, model routing, reviewer handoffs, or handoff archives.',
+    };
+  }
+  if (editorKind === 'document-review-packet-share') {
+    return {
+      route: 'agent_review_packet_share',
+      tool: 'agent_review_packet_share',
+      action: 'share_review_packet_archive_reference',
+      confirmation: 'required',
+      note: 'run_workspace_action validates one saved reviewer handoff archive and sends a plain-text archive reference through a configured channel target. It does not print or attach ZIP bytes; exact bytes stay behind artifact export routes.',
+    };
+  }
+  if (editorKind === 'model-compare' || editorKind === 'local-model-benchmark') {
+    return {
+      route: 'agent_model_compare',
+      tool: 'agent_model_compare',
+      action: editorKind === 'local-model-benchmark' ? 'run_local_model_benchmark' : 'run_blind_comparison',
+      confirmation: 'required',
+      note: editorKind === 'local-model-benchmark'
+        ? 'run_workspace_action validates the local benchmark fields, tags the saved artifact as benchmarkKind local-model-route, and executes the first-class blind comparison tool. It never changes the selected model.'
+        : 'run_workspace_action validates the editor fields and executes the first-class blind comparison tool with delayed reveal support. The visible workspace form submits the same request to the main conversation.',
+    };
+  }
+  if (editorKind === 'model-compare-review') {
+    return {
+      route: 'agent_model_compare',
+      tool: 'agent_model_compare',
+      action: 'review_saved_comparison_side_by_side_or_handoff_diff',
+      confirmation: 'not-required',
+      note: 'run_workspace_action renders saved blind comparison artifacts, a read-only review board, a side-by-side related-artifact evidence view, or a visual reviewer handoff diff through the first-class comparison tool; route updates stay separate.',
+    };
+  }
+  if (editorKind === 'model-compare-handoff-diff') {
+    return {
+      route: 'agent_model_compare',
+      tool: 'agent_model_compare',
+      action: 'diff_reviewer_handoff_artifacts',
+      confirmation: 'not-required',
+      note: 'run_workspace_action renders a visual reviewer handoff diff through the first-class comparison tool, with an optional section jump for all, metadata, policy, related artifacts, or comparison evidence.',
+    };
+  }
+  if (editorKind === 'model-compare-judge') {
+    return {
+      route: 'agent_model_compare',
+      tool: 'agent_model_compare',
+      action: 'save_comparison_judgment',
+      confirmation: 'required',
+      note: 'run_workspace_action validates the editor fields and saves a local comparison judgment artifact. It never changes the selected model; route updates require separate confirmation.',
+    };
+  }
+  if (editorKind === 'model-compare-apply') {
+    return {
+      route: 'agent_model_compare',
+      tool: 'agent_model_compare',
+      action: 'apply_comparison_winner',
+      confirmation: 'required',
+      note: 'run_workspace_action applies a revealed saved comparison judgment to provider.model after explicit confirmation.',
+    };
+  }
+  if (editorKind === 'model-compare-route-decision') {
+    return {
+      route: 'agent_model_compare',
+      tool: 'agent_model_compare',
+      action: 'record_comparison_route_decision',
+      confirmation: 'required',
+      note: 'run_workspace_action saves a leave-unchanged route-decision receipt for a revealed comparison judgment without changing provider.model.',
+    };
+  }
+  if (editorKind === 'model-compare-export') {
+    return {
+      route: 'agent_model_compare',
+      tool: 'agent_model_compare',
+      action: 'export_comparison_report_handoff_or_archive',
+      confirmation: 'required',
+      note: 'run_workspace_action creates one local markdown report, reviewer handoff artifact, or reviewer handoff ZIP archive from saved comparison evidence without changing model routing.',
+    };
+  }
+  if (editorKind === 'model-compare-analytics') {
+    return {
+      route: 'agent_model_compare',
+      tool: 'agent_model_compare',
+      action: 'summarize_or_synthesize_comparison_judgments',
+      confirmation: 'not-required',
+      note: 'run_workspace_action summarizes or synthesizes saved comparison judgment artifacts without changing model routing.',
+    };
+  }
   if (isAgentWorkspaceCommandEditorKind(editorKind)) {
     return {
       route: 'slash-command-dispatch',