@openui5/sap.ui.rta 1.136.0 → 1.136.2

package/src/sap/ui/rta/plugin/ExtendControllerPlugin.js

@@ -7,10 +7,12 @@
 sap.ui.define([
 	"sap/ui/core/Lib",
 	"sap/ui/dt/Util",
+	"sap/ui/fl/Utils",
 	"sap/ui/rta/plugin/Plugin"
 ], function(
 	Lib,
 	DtUtil,
+	Utils,
 	Plugin
 ) {
 	"use strict";
@@ -30,7 +32,7 @@ sap.ui.define([
 	 * @class
 	 * @extends sap.ui.rta.plugin.Plugin
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @constructor
 	 * @private
 	 * @since 1.134
@@ -52,6 +54,11 @@ sap.ui.define([
 
 	const FLEX_CHANGE_TYPE = "codeExt";
 
+	function isControlInAsyncView(oOverlay) {
+		// Currently there is no better way to get this information. When this changes, this code must be adapted.
+		return !!Utils.getViewForControl(oOverlay.getElement())?.oAsyncState;
+	}
+
 	/**
 	 * Check if the given overlay should be editable.
 	 *
@@ -70,8 +77,9 @@ sap.ui.define([
 	 * @public
 	 */
 	ExtendControllerPlugin.prototype.isEnabled = function(aElementOverlays) {
-		const bEnabled = aElementOverlays.length === 1 && !this.isInReuseComponentOnS4HanaCloud(aElementOverlays[0]);
-		return bEnabled;
+		return aElementOverlays.length === 1
+			&& !this.isInReuseComponentOnS4HanaCloud(aElementOverlays[0])
+			&& isControlInAsyncView(aElementOverlays[0]);
 	};
 
 	/**
@@ -98,6 +106,11 @@ sap.ui.define([
 		if (this.isInReuseComponentOnS4HanaCloud(oOverlay)) {
 			sText += ` (${Lib.getResourceBundleFor("sap.ui.rta").getText("CTX_DISABLED_REUSE")})`;
 		}
+		// The case where the control is not in an async view
+		// is not enabled and has a special text in parenthesis on the context menu
+		if (!isControlInAsyncView(oOverlay)) {
+			sText += ` (${Lib.getResourceBundleFor("sap.ui.rta").getText("CTX_DISABLED_NOT_ASYNC")})`;
+		}
 		return sText;
 	};
 

package/src/sap/ui/rta/plugin/LocalReset.js

@@ -41,7 +41,7 @@ sap.ui.define([
 	 * @class
 	 * @extends sap.ui.rta.plugin.Plugin
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @constructor
 	 * @private
 	 * @since 1.90

package/src/sap/ui/rta/plugin/Plugin.js

@@ -114,7 +114,7 @@ sap.ui.define([
 	 * @extends sap.ui.dt.Plugin
 	 *
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/plugin/RTAElementMover.js

@@ -35,7 +35,7 @@ function(
 	 * The RTAElementMover is responsible for the RTA specific adaptation of element movements.
 	 *
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/plugin/Remove.js

@@ -29,7 +29,7 @@ sap.ui.define([
 	 * @class The Remove allows trigger remove operations on the overlay
 	 * @extends sap.ui.rta.plugin.Plugin
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @constructor
 	 * @private
 	 * @since 1.34

package/src/sap/ui/rta/plugin/Resize.js

@@ -27,7 +27,7 @@ sap.ui.define([
 	 * @class
 	 * @extends sap.ui.rta.plugin.Plugin
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @constructor
 	 * @private
 	 * @since 1.101

package/src/sap/ui/rta/plugin/Selection.js

@@ -31,7 +31,7 @@ sap.ui.define([
 	 * @class The Selection plugin allows you to select or focus overlays with mouse or keyboard and navigate to others.
 	 * @extends sap.ui.rta.plugin.Plugin
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @constructor
 	 * @private
 	 * @since 1.34

package/src/sap/ui/rta/plugin/Settings.js

@@ -30,7 +30,7 @@ sap.ui.define([
 	 * @class The Settings allows trigger change of settings operations on the overlay
 	 * @extends sap.ui.rta.plugin.Plugin
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @constructor
 	 * @private
 	 * @since 1.44

package/src/sap/ui/rta/plugin/Split.js

@@ -23,7 +23,7 @@ sap.ui.define([
 	 * @class
 	 * @extends sap.ui.rta.plugin.Plugin
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @constructor
 	 * @private
 	 * @since 1.46

package/src/sap/ui/rta/plugin/Stretch.js

@@ -29,7 +29,7 @@ sap.ui.define([
 	 * @extends sap.ui.rta.plugin.Plugin
 	 *
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/plugin/additionalElements/ActionExtractor.js

@@ -32,7 +32,7 @@ sap.ui.define([
 	 * handled by the AdditionalElements Plugin (Reveal, Add Via Delegate, Add Custom)
 	 *
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @private
 	 * @since 1.94
 	 */

package/src/sap/ui/rta/plugin/additionalElements/AddElementsDialog.js

@@ -32,7 +32,7 @@ sap.ui.define([
 	 * @class Context - Dialog for available Fields in Runtime Authoring
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @constructor
 	 * @private
 	 * @since 1.44

package/src/sap/ui/rta/plugin/additionalElements/AdditionalElementsPlugin.js

@@ -119,7 +119,7 @@ sap.ui.define([
 	 * @class The plugin allows to add additional elements that exist either hidden in the UI or in the OData service
 	 * @extends sap.ui.rta.plugin.Plugin
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @constructor
 	 * @private
 	 * @since 1.44

package/src/sap/ui/rta/plugin/additionalElements/AdditionalElementsUtils.js

@@ -17,7 +17,7 @@ sap.ui.define([
 	 * Helper object containing methods for the AdditionalElements plugin
 	 *
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @private
 	 * @since 1.94
 	 */

package/src/sap/ui/rta/plugin/additionalElements/CommandBuilder.js

@@ -25,7 +25,7 @@ sap.ui.define([
 	 * Helper object to build the RTA commands resulting from the AdditionalElements Plugin
 	 *
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @private
 	 * @since 1.94
 	 */

package/src/sap/ui/rta/plugin/annotations/AnnotationChangeDialog.js

@@ -29,7 +29,7 @@ sap.ui.define([
 	 * @class Constructor for a new sap.ui.rta.plugin.annotations.AnnotationChangeDialog.
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @constructor
 	 * @since 1.132
 	 * @private

package/src/sap/ui/rta/plugin/annotations/AnnotationChangeDialogController.js

@@ -35,7 +35,7 @@ sap.ui.define([
 	 * @class Controller for the AnnotationChangeDialog.
 	 * @extends sap.ui.core.mvc.Controller
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @constructor
 	 * @since 1.132
 	 * @private

package/src/sap/ui/rta/plugin/annotations/AnnotationPlugin.js

@@ -8,7 +8,6 @@ sap.ui.define([
 	"sap/base/Log",
 	"sap/ui/base/DesignTime",
 	"sap/ui/core/util/reflection/JsControlTreeModifier",
-	"sap/ui/dt/OverlayRegistry",
 	"sap/ui/dt/Util",
 	"sap/ui/fl/write/api/PersistenceWriteAPI",
 	"sap/ui/fl/Utils",
@@ -19,7 +18,6 @@ sap.ui.define([
 	BaseLog,
 	DesignTime,
 	JsControlTreeModifier,
-	OverlayRegistry,
 	DtUtil,
 	PersistenceWriteAPI,
 	Utils,
@@ -32,8 +30,11 @@ sap.ui.define([
 	async function handleCompositeCommand(oElement, oAction, aAnnotationChanges, aLegacyRenameChanges) {
 		const oCompositeCommand = await this.getCommandFactory().getCommandFor(oElement, "composite");
 		for (const oChange of aAnnotationChanges) {
-			// aLegacyRenameChanges is only passed for singleRename scenarios, where there is only one annotation change to be saved
-			// so we can simply add it in the loop
+			// the annotation could have different text types, depending on where the annotation is used
+			// but the backend needs to know the type, so we just set it to "XFLD" if it is not defined
+			if (oChange.content.text && !oChange.content.textType) {
+				oChange.content.textType = "XFLD";
+			}
 			const oAnnotationCommand = await this.getCommandFactory().getCommandFor(
 				oElement,
 				"annotation",
@@ -41,6 +42,8 @@ sap.ui.define([
 					changeType: oAction.changeType,
 					serviceUrl: oChange.serviceUrl,
 					content: {...oChange.content, objectTemplateInfo: oAction.objectTemplateInfo},
+					// aLegacyRenameChanges is only passed for singleRename scenarios, where there is only one annotation change to be saved
+					// so we can simply add it in the loop
 					changesToDelete: aLegacyRenameChanges
 				}
 			);
@@ -102,7 +105,7 @@ sap.ui.define([
 	 * @class
 	 * @extends sap.ui.rta.plugin.Plugin
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @constructor
 	 * @private
 	 * @since 1.132

package/src/sap/ui/rta/plugin/iframe/AddIFrame.js

@@ -119,7 +119,7 @@ sap.ui.define([
 	 * @class The AddIFrame allows trigger AddIFrame operations on the overlay.
 	 * @extends sap.ui.rta.plugin.BaseCreate
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @constructor
 	 * @private
 	 * @since 1.75

package/src/sap/ui/rta/plugin/iframe/AddIFrameDialog.js

@@ -159,7 +159,7 @@ sap.ui.define([
 	 * @class Context - Dialog for IFrame settings in Runtime Authoring
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @constructor
 	 * @private
 	 * @since 1.78

package/src/sap/ui/rta/plugin/rename/Rename.js

@@ -28,7 +28,7 @@ sap.ui.define([
 	 * @extends sap.ui.rta.plugin.Plugin
 	 *
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/plugin/rename/RenameDialog.js

@@ -27,7 +27,7 @@ sap.ui.define([
 	 * @class Constructor for a new sap.ui.rta.plugin.rename.RenameDialog.
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @constructor
 	 * @since 1.136
 	 * @private

package/src/sap/ui/rta/service/Action.js

@@ -24,7 +24,7 @@ sap.ui.define([
 	 * @name sap.ui.rta.service.Action
 	 * @author SAP SE
 	 * @since 1.58
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @private
 	 * @ui5-restricted
 	 *

package/src/sap/ui/rta/service/ControllerExtension.js

@@ -30,7 +30,7 @@ sap.ui.define([
 	 * @name sap.ui.rta.service.ControllerExtension
 	 * @author SAP SE
 	 * @since 1.58
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @private
 	 * @ui5-restricted
 	*/

package/src/sap/ui/rta/service/Outline.js

@@ -43,7 +43,7 @@ sap.ui.define([
 	 * @name sap.ui.rta.service.Outline
 	 * @author SAP SE
 	 * @since 1.56
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @private
 	 * @ui5-restricted
 	 */

package/src/sap/ui/rta/service/Property.js

@@ -27,7 +27,7 @@ sap.ui.define([
 	 * @name sap.ui.rta.service.Property
 	 * @author SAP SE
 	 * @since 1.58
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @private
 	 * @ui5-restricted
 	*/

package/src/sap/ui/rta/service/Selection.js

@@ -14,7 +14,7 @@ sap.ui.define(function() {
 	 * @name sap.ui.rta.service.Selection
 	 * @author SAP SE
 	 * @since 1.58
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @private
 	 * @ui5-restricted
 	*/

package/src/sap/ui/rta/service/SupportTools.js

@@ -30,7 +30,7 @@ sap.ui.define([
 	 * @name sap.ui.rta.service.SupportTools
 	 * @author SAP SE
 	 * @since 1.106
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @private
 	 * @ui5-restricted
 	 */

package/src/sap/ui/rta/toolbar/ActionsMenu.fragment.xml

@@ -75,8 +75,6 @@
 		<MenuItem
 				id="sapUiRta_newFeaturesOverview"
 				icon="sap-icon://newspaper"
-				enabled="{controls>/newFeaturesOverview/enabled}"
-				visible="{controls>/newFeaturesOverview/visible}"
 				text="{i18n>BTN_WHATS_NEW_DIALOG_OVERVIEW}"
 				tooltip="{i18n>BTN_WHATS_NEW_DIALOG_OVERVIEW_TOOLTIP}"
 				press=".openWhatsNewOverviewDialog"/>

package/src/sap/ui/rta/toolbar/Adaptation.js

@@ -67,7 +67,7 @@ sap.ui.define([
 	 * @extends sap.ui.rta.toolbar.Base
 	 *
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/toolbar/Base.js

@@ -33,7 +33,7 @@ sap.ui.define([
 	 * @extends sap.m.HBox
 	 *
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/toolbar/Fiori.js

@@ -34,7 +34,7 @@ function(
 	 * @extends sap.ui.rta.toolbar.Adaptation
 	 *
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 *
 	 * @constructor
 	 * @private
@@ -71,8 +71,10 @@ function(
 			const sLogoPath = this.getUshellApi().getLogo();
 
 			if (sLogoPath) {
-				// Unstable: if FLP changes ID of <img> element, logo could be not found
-				const oLogo = this._oFioriHeader.getDomRef().querySelector("#shell-header-icon");
+				// get all images from the Fiori Header
+				const aHeaderImages = this._oFioriHeader.getDomRef().querySelectorAll("img");
+				// check if one of the images is the logo
+				const oLogo = Array.from(aHeaderImages).find((oImage) => oImage.src.includes(sLogoPath));
 				let iWidth;
 				let iHeight;
 

package/src/sap/ui/rta/toolbar/FioriLike.js

@@ -22,7 +22,7 @@ function(
 	 * @extends sap.ui.rta.toolbar.Adaptation
 	 *
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/toolbar/OverflowToolbarButton.js

@@ -23,7 +23,7 @@ sap.ui.define([
 	 * @extends sap.m.OverflowToolbarButton
 	 *
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/toolbar/Standalone.js

@@ -22,7 +22,7 @@ function(
 	 * @extends sap.ui.rta.toolbar.Adaptation
 	 *
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/toolbar/contextBased/SaveAsAdaptation.js

@@ -45,7 +45,7 @@ sap.ui.define([
 	 * @class
 	 *
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/toolbar/translation/Translation.js

@@ -53,7 +53,7 @@ sap.ui.define([
 	 * @class
 	 *
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/toolbar/versioning/Versioning.js

@@ -38,7 +38,7 @@ sap.ui.define([
 	 * @class
 	 *
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/util/PluginManager.js

@@ -64,7 +64,7 @@ sap.ui.define([
 	 * Constructor for a new sap.ui.rta.util.PluginManager
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @constructor
 	 * @private
 	 * @since 1.86

package/src/sap/ui/rta/util/PopupManager.js

@@ -42,7 +42,7 @@ sap.ui.define([
 	 * Constructor for a new sap.ui.rta.util.PopupManager
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @constructor
 	 * @private
 	 * @since 1.48

package/src/sap/ui/rta/util/ReloadManager.js

@@ -30,7 +30,7 @@ sap.ui.define([
 	 * @namespace sap.ui.rta.util.ReloadManager
 	 * @alias sap.ui.rta.util.ReloadManager
 	 * @since 1.104
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @private
 	 * @ui5-restricted
 	 */

package/src/sap/ui/rta/util/ServiceEventBus.js

@@ -19,7 +19,7 @@ function(
 	 *
 	 * @extends sap.ui.core.EventBus
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @private
 	 * @since 1.56.0
 	 * @alias sap.ui.rta.util.ServiceEventBus

package/src/sap/ui/rta/util/ServiceManager.js

@@ -27,7 +27,7 @@ sap.ui.define([
 	 *
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @constructor
 	 * @private
 	 * @since 1.121

package/src/sap/ui/rta/util/changeVisualization/ChangeIndicator.js

@@ -46,7 +46,7 @@ sap.ui.define([
 	 * @alias sap.ui.rta.util.changeVisualization.ChangeIndicator
 	 * @author SAP SE
 	 * @since 1.84.0
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @private
 	 */
 	const ChangeIndicator = Control.extend("sap.ui.rta.util.changeVisualization.ChangeIndicator", {

package/src/sap/ui/rta/util/changeVisualization/ChangeIndicatorRegistry.js

@@ -37,7 +37,7 @@ sap.ui.define([
 	 * @alias sap.ui.rta.util.changeVisualization.ChangeIndicatorRegistry
 	 * @author SAP SE
 	 * @since 1.86.0
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @private
 	 */
 	const ChangeIndicatorRegistry = ManagedObject.extend("sap.ui.rta.util.changeVisualization.ChangeIndicatorRegistry", {

package/src/sap/ui/rta/util/changeVisualization/ChangeVisualization.js

@@ -84,7 +84,7 @@ sap.ui.define([
 	 * @alias sap.ui.rta.util.changeVisualization.ChangeVisualization
 	 * @author SAP SE
 	 * @since 1.84.0
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @private
 	 */
 	const ChangeVisualization = Control.extend("sap.ui.rta.util.changeVisualization.ChangeVisualization", {

package/src/sap/ui/rta/util/guidedTour/GuidedTour.js

@@ -27,7 +27,7 @@ sap.ui.define([
 	 * @class Constructor for a new sap.ui.rta.util.guidedTour.GuidedTour
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @constructor
 	 * @since 1.136
 	 * @private

package/src/sap/ui/rta/util/guidedTour/content/GeneralTour.js

@@ -20,7 +20,7 @@ sap.ui.define([
 	function filterAvailableBurgerMenuActions(oGeneralTour) {
 		const oControlsModelData = Element.getElementById("sapUIRta_toolbar").getModel("controls").getData();
 		const aAvailableBurgerMenuActions = {
-			newFeaturesOverview: oControlsModelData.newFeaturesOverview.visible,
+			newFeaturesOverview: true,
 			translation: oControlsModelData.translation.visible,
 			generalTour: true,
 			appVariantMenu: oControlsModelData.appVariantMenu.visible,

package/src/sap/ui/rta/util/whatsNew/WhatsNew.js

@@ -33,7 +33,7 @@ sap.ui.define([
 	 * @class Constructor for a new sap.ui.rta.util.whatsNew.WhatsNew
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.136.0
+	 * @version 1.136.2
 	 * @constructor
 	 * @since 1.129
 	 * @private