@openui5/sap.ui.rta 1.134.0 → 1.135.0

package/src/sap/ui/rta/toolbar/Fiori.js

@@ -32,7 +32,7 @@ function(
 	 * @extends sap.ui.rta.toolbar.Adaptation
 	 *
 	 * @author SAP SE
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 *
 	 * @constructor
 	 * @private
@@ -81,8 +81,9 @@ function(
 				this.getControl("iconBox").addItem(
 					new Image(`${this.getId()}_fragment--sapUiRta_icon`, {
 						src: sLogoPath,
-						width: iWidth ? `${iWidth}px` : iWidth,
-						height: iHeight ? `${iHeight}px` : iHeight
+						// type check required cause of image could have zero width and height
+						width: typeof iWidth === "number" ? `${iWidth}px` : iWidth,
+						height: typeof iHeight === "number" ? `${iHeight}px` : iHeight
 					})
 				);
 			}

package/src/sap/ui/rta/toolbar/FioriLike.js

@@ -20,7 +20,7 @@ function(
 	 * @extends sap.ui.rta.toolbar.Adaptation
 	 *
 	 * @author SAP SE
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/toolbar/OverflowToolbarButton.js

@@ -23,7 +23,7 @@ sap.ui.define([
 	 * @extends sap.m.OverflowToolbarButton
 	 *
 	 * @author SAP SE
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/toolbar/Standalone.js

@@ -22,7 +22,7 @@ function(
 	 * @extends sap.ui.rta.toolbar.Adaptation
 	 *
 	 * @author SAP SE
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/toolbar/contextBased/SaveAsAdaptation.js

@@ -45,7 +45,7 @@ sap.ui.define([
 	 * @class
 	 *
 	 * @author SAP SE
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/toolbar/translation/Translation.js

@@ -53,7 +53,7 @@ sap.ui.define([
 	 * @class
 	 *
 	 * @author SAP SE
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/toolbar/versioning/Versioning.js

@@ -38,7 +38,7 @@ sap.ui.define([
 	 * @class
 	 *
 	 * @author SAP SE
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/util/PluginManager.js

@@ -64,7 +64,7 @@ sap.ui.define([
 	 * Constructor for a new sap.ui.rta.util.PluginManager
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 * @constructor
 	 * @private
 	 * @since 1.86

package/src/sap/ui/rta/util/PopupManager.js

@@ -42,7 +42,7 @@ sap.ui.define([
 	 * Constructor for a new sap.ui.rta.util.PopupManager
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 * @constructor
 	 * @private
 	 * @since 1.48

package/src/sap/ui/rta/util/ReloadManager.js

@@ -30,7 +30,7 @@ sap.ui.define([
 	 * @namespace sap.ui.rta.util.ReloadManager
 	 * @alias sap.ui.rta.util.ReloadManager
 	 * @since 1.104
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 * @private
 	 * @ui5-restricted
 	 */

package/src/sap/ui/rta/util/ServiceEventBus.js

@@ -19,7 +19,7 @@ function(
 	 *
 	 * @extends sap.ui.core.EventBus
 	 * @author SAP SE
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 * @private
 	 * @since 1.56.0
 	 * @alias sap.ui.rta.util.ServiceEventBus

package/src/sap/ui/rta/util/ServiceManager.js

@@ -27,7 +27,7 @@ sap.ui.define([
 	 *
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 * @constructor
 	 * @private
 	 * @since 1.121

package/src/sap/ui/rta/util/changeVisualization/ChangeIndicator.js

@@ -46,7 +46,7 @@ sap.ui.define([
 	 * @alias sap.ui.rta.util.changeVisualization.ChangeIndicator
 	 * @author SAP SE
 	 * @since 1.84.0
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 * @private
 	 */
 	const ChangeIndicator = Control.extend("sap.ui.rta.util.changeVisualization.ChangeIndicator", {

package/src/sap/ui/rta/util/changeVisualization/ChangeIndicatorRegistry.js

@@ -37,7 +37,7 @@ sap.ui.define([
 	 * @alias sap.ui.rta.util.changeVisualization.ChangeIndicatorRegistry
 	 * @author SAP SE
 	 * @since 1.86.0
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 * @private
 	 */
 	const ChangeIndicatorRegistry = ManagedObject.extend("sap.ui.rta.util.changeVisualization.ChangeIndicatorRegistry", {

package/src/sap/ui/rta/util/changeVisualization/ChangeVisualization.js

@@ -84,7 +84,7 @@ sap.ui.define([
 	 * @alias sap.ui.rta.util.changeVisualization.ChangeVisualization
 	 * @author SAP SE
 	 * @since 1.84.0
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 * @private
 	 */
 	const ChangeVisualization = Control.extend("sap.ui.rta.util.changeVisualization.ChangeVisualization", {
@@ -420,7 +420,7 @@ sap.ui.define([
 			return sCommand;
 		}
 
-		if (!oChange.getSelector || !oChange.getSelector() || isEmptyObject(oChange.getSelector())) {
+		if (!oChange.canBeVisualized()) {
 			return false;
 		}
 

package/src/sap/ui/rta/util/whatsNew/WhatsNew.js

@@ -33,7 +33,7 @@ sap.ui.define([
 	 * @class Constructor for a new sap.ui.rta.util.whatsNew.WhatsNew
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 * @constructor
 	 * @since 1.129
 	 * @private

package/src/sap/ui/rta/command/AppDescriptorCommand.js

@@ -1,114 +0,0 @@
-/*!
- * OpenUI5
- * (c) Copyright 2009-2025 SAP SE or an SAP affiliate company.
- * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
- */
-sap.ui.define([
-	"sap/ui/rta/command/BaseCommand",
-	"sap/ui/fl/write/_internal/appVariant/AppVariantInlineChangeFactory",
-	"sap/ui/fl/descriptorRelated/api/DescriptorChangeFactory"
-], function(
-	BaseCommand,
-	AppVariantInlineChangeFactory,
-	DescriptorChangeFactory
-) {
-	"use strict";
-
-	/**
-	 * Implementation of a command template for App Descriptor changes
-	 *
-	 * @class
-	 * @extends sap.ui.rta.command.BaseCommand
-	 *
-	 * @author SAP SE
-	 * @version 1.134.0
-	 *
-	 * @constructor
-	 * @private
-	 * @since 1.49
-	 * @alias sap.ui.rta.command.AppDescriptorCommand
-	 */
-	var AppDescriptorCommand = BaseCommand.extend("sap.ui.rta.command.AppDescriptorCommand", {
-		metadata: {
-			library: "sap.ui.rta",
-			properties: {
-				reference: {
-					type: "string"
-				},
-				appComponent: {
-					type: "object"
-				},
-				layer: {
-					type: "string"
-				},
-				changeType: {
-					type: "string"
-				},
-				parameters: {
-					type: "object"
-				},
-				texts: {
-					type: "object"
-				}
-			},
-			events: {}
-		}
-	});
-
-	/**
-	 * For app descriptor commands to take effect usually the app needs to be restarted as server-side processing is involved.
-	 */
-	AppDescriptorCommand.prototype.needsReload = true;
-
-	/**
-	 * Prepare the app descriptor change, setting the layer.
-	 * @param  {object} mFlexSettings - Map of flex settings
-	 * @param  {string} mFlexSettings.layer - Layer where the change is applied
-	 * @returns {boolean} <code>true</true>
-	 */
-	AppDescriptorCommand.prototype.prepare = function(mFlexSettings) {
-		this.setLayer(mFlexSettings.layer);
-		return true;
-	};
-
-	/**
-	 * Retrieves the prepared change for e.g. undo execution.
-	 * @return {sap.ui.fl.apply._internal.flexObjects.UIChange} Returns change after being created and stored
-	 */
-	AppDescriptorCommand.prototype.getPreparedChange = function() {
-		return this._oPreparedChange;
-	};
-
-	AppDescriptorCommand.prototype.setCompositeId = function(sCompositeId) {
-		this._sCompositeId = sCompositeId;
-	};
-
-	/**
-	 * Create the change for the app descriptor and adds it to the Flex Persistence.
-	 * @return {Promise} Returns Promise resolving after change has been created and stored
-	 */
-	AppDescriptorCommand.prototype.createAndStoreChange = function() {
-		return AppVariantInlineChangeFactory.createDescriptorInlineChange({
-			changeType: this.getChangeType(),
-			content: this.getParameters(),
-			texts: this.getTexts(),
-			support: {
-				compositeCommand: this._sCompositeId || ""
-			}
-		})
-		.then(function(oAppDescriptorChangeContent) {
-			return new DescriptorChangeFactory().createNew(
-				this.getReference(),
-				oAppDescriptorChangeContent,
-				this.getLayer(),
-				this.getAppComponent(),
-				"sap.ui.rta.AppDescriptorCommand"
-			);
-		}.bind(this))
-		.then(function(oAppDescriptorChange) {
-			var oChange = oAppDescriptorChange.store();
-			this._oPreparedChange = oChange;
-		}.bind(this));
-	};
-	return AppDescriptorCommand;
-});