@openui5/sap.ui.rta 1.103.1 → 1.106.0

package/src/sap/ui/rta/util/changeVisualization/ChangeIndicator.js

@@ -8,37 +8,29 @@ sap.ui.define([
 	"sap/ui/core/Fragment",
 	"sap/ui/model/json/JSONModel",
 	"sap/ui/core/Control",
-	"sap/m/Text",
 	"sap/ui/core/format/DateFormat",
 	"sap/ui/events/KeyCodes",
-	"sap/ui/rta/util/changeVisualization/categories/getVisualizationCategory",
+	"sap/ui/rta/util/changeVisualization/commands/getCommandVisualization",
 	"sap/ui/fl/Utils",
 	"sap/ui/fl/util/resolveBinding",
 	"sap/ui/rta/util/changeVisualization/ChangeVisualizationUtils",
-	"sap/ui/core/Core"
+	"sap/ui/core/Core",
+	"sap/ui/rta/util/changeVisualization/ChangeCategories"
 ], function(
 	Fragment,
 	JSONModel,
 	Control,
-	Text,
 	DateFormat,
 	KeyCodes,
-	getVisualizationCategory,
+	getCommandVisualization,
 	FlUtils,
 	resolveBinding,
 	ChangeVisualizationUtils,
-	Core
+	Core,
+	ChangeCategories
 ) {
 	"use strict";
 
-	var CATEGORY_ICONS = {
-		add: "sap-icon://add",
-		move: "sap-icon://move",
-		rename: "sap-icon://edit",
-		combinesplit: "sap-icon://combine",
-		remove: "sap-icon://less"
-	};
-
 	/**
 	 * @class
 	 * Constructor for a new <code>sap.ui.rta.util.changeVisualization.ChangeIndicator</code> class.
@@ -48,7 +40,7 @@ sap.ui.define([
 	 * @alias sap.ui.rta.util.changeVisualization.ChangeIndicator
 	 * @author SAP SE
 	 * @since 1.84.0
-	 * @version 1.103.1
+	 * @version 1.106.0
 	 * @private
 	 */
 	var ChangeIndicator = Control.extend("sap.ui.rta.util.changeVisualization.ChangeIndicator", {
@@ -160,7 +152,7 @@ sap.ui.define([
 
 	function centerVertically(oIndicator) {
 		var oIndicatorDomRef = oIndicator.getDomRef();
-		var iOverlayHeight = document.getElementById(oIndicator.getOverlayId()).offsetHeight;
+		var iOverlayHeight = Core.byId(oIndicator.getOverlayId()).getDomRef().offsetHeight;
 		var iIndicatorHeight = oIndicatorDomRef.offsetHeight;
 		// the indicator should be centered only if the element has a small enough height to improve the design and visibility
 		if (iOverlayHeight < iIndicatorHeight * 5) {
@@ -168,6 +160,93 @@ sap.ui.define([
 		}
 	}
 
+	function getTexts(mChangeInformation, oRtaResourceBundle, sOverlayId) {
+		var oAffectedElement = Core.byId(mChangeInformation.affectedElementId);
+		var mPayload = Object.keys(mChangeInformation.payload || {}).reduce(function(mPayload, sKey) {
+			var vOriginalValue = mChangeInformation.payload[sKey];
+			var bIsBinding = FlUtils.isBinding(vOriginalValue);
+			var vValue = bIsBinding
+				? resolveBinding(vOriginalValue, oAffectedElement)
+				: vOriginalValue;
+			mPayload[sKey] = vValue;
+			return mPayload;
+		}, {});
+
+		var mPropertyBag = { appComponent: FlUtils.getAppComponentForControl(oAffectedElement) };
+		var oOverlay = Core.byId(sOverlayId);
+		var sElementLabel = oOverlay.getDesignTimeMetadata().getLabel(oAffectedElement);
+		var oCommandVisualization = getCommandVisualization(mChangeInformation);
+		var oDescription = oCommandVisualization && oCommandVisualization.getDescription(mPayload, sElementLabel, mPropertyBag) || {};
+		var sCommandName = mChangeInformation.commandName;
+		var sDescriptionText;
+		var sDescriptionTooltip;
+
+		// 'Settings' with a custom description should overwrite the description from the CommandVisualization
+		if (sCommandName === "settings" && mPayload.description) {
+			oDescription.descriptionText = mPayload.description;
+			oDescription.descriptionTooltip = mPayload.descriptionTooltip;
+		} else if (mChangeInformation.changeCategory === "other") {
+			// To retrieve the generic description for commands without visualization
+			sCommandName = "other";
+		}
+
+		if (oDescription.descriptionText) {
+			sDescriptionText = oDescription.descriptionText;
+			sDescriptionTooltip = oDescription.descriptionTooltip || "";
+		} else {
+			sElementLabel = sElementLabel && "'" + sElementLabel + "'";
+			var sShortenedElementLabel = ChangeVisualizationUtils.shortenString(sElementLabel);
+			var sChangeTextKey = (
+				"TXT_CHANGEVISUALIZATION_CHANGE_"
+				+ sCommandName.toUpperCase()
+			);
+			sDescriptionText = oRtaResourceBundle.getText(sChangeTextKey, sShortenedElementLabel);
+			sDescriptionTooltip = oRtaResourceBundle.getText(sChangeTextKey, sElementLabel);
+		}
+		sDescriptionTooltip = sDescriptionText.length < sDescriptionTooltip.length ? sDescriptionTooltip : null;
+		var sDetailButtonText = oDescription && oDescription.buttonText;
+		var sIconTooltip = oRtaResourceBundle.getText(
+			"TXT_CHANGEVISUALIZATION_OVERVIEW_"
+			+ mChangeInformation.changeCategory.toUpperCase()
+		);
+
+		return {
+			description: sDescriptionText,
+			tooltip: sDescriptionTooltip,
+			buttonText: sDetailButtonText,
+			iconTooltip: sIconTooltip
+		};
+	}
+
+	function getDates(mChangeInformation, oRtaResourceBundle) {
+		var sCreationDate = mChangeInformation.change.getCreation();
+		var oDate = new Date(sCreationDate);
+		var sFallbackDate = oRtaResourceBundle.getText("TXT_CHANGEVISUALIZATION_CREATED_IN_SESSION_DATE");
+
+		return {
+			fullDate: sCreationDate ? DateFormat.getDateTimeInstance().format(oDate) : sFallbackDate,
+			relativeDate: sCreationDate ? DateFormat.getDateTimeInstance({ relative: "true" }).format(oDate) : sFallbackDate
+		};
+	}
+
+	function formatChangesModelItem(sOverlayId, mChangeInformation) {
+		var oRtaResourceBundle = Core.getLibraryResourceBundle("sap.ui.rta");
+		var oTexts = getTexts(mChangeInformation, oRtaResourceBundle, sOverlayId);
+		var oDates = getDates(mChangeInformation, oRtaResourceBundle);
+
+		return {
+			id: mChangeInformation.id,
+			change: mChangeInformation,
+			description: oTexts.description,
+			descriptionTooltip: oTexts.tooltip,
+			fullDate: oDates.fullDate,
+			relativeDate: oDates.relativeDate,
+			detailButtonText: oTexts.buttonText,
+			icon: ChangeCategories.getIconForCategory(mChangeInformation.changeCategory),
+			iconTooltip: oTexts.iconTooltip
+		};
+	}
+
 	ChangeIndicator.prototype.init = function() {
 		this._iOldTabIndex = 0;
 		handleBrowserEventsOnElement.call(this, this, "attachBrowserEvent");
@@ -203,11 +282,28 @@ sap.ui.define([
 		this._bScheduledForFocus = true;
 	};
 
+	ChangeIndicator.prototype.setOverlayId = function(sOverlayId) {
+		// Overlays don't have aggregations, thus the indicator dom ref must be placed as
+		// a child of the overlay dom ref manually
+		// If the overlay that the indicator should be attached to changes, it is possible that the
+		// indicator is not rendered yet or that the old overlay and thus the nested indicator were destroyed
+		// To properly render it, the indicator must temporarily be placed in the static area
+		// Once it is rendered, it can move itself to the actual overlay dom ref (see onAfterRendering)
+		var oDomRef = this.getDomRef();
+		if (oDomRef) {
+			oDomRef.parentNode.removeChild(oDomRef);
+		}
+		this.placeAt(Core.getStaticAreaRef());
+
+		this.setProperty("overlayId", sOverlayId);
+		return this;
+	};
+
 	ChangeIndicator.prototype.onAfterRendering = function() {
-		var oOverlay = document.getElementById(this.getOverlayId());
+		var oOverlay = Core.getElementById(this.getOverlayId());
 		if (oOverlay) {
 			// Attach to the overlay
-			oOverlay.appendChild(this.getDomRef());
+			oOverlay.getDomRef().appendChild(this.getDomRef());
 			centerVertically(this);
 		}
 		// Restore the Tabindex if stored before; set to 0 as default
@@ -237,7 +333,7 @@ sap.ui.define([
 
 	ChangeIndicator.prototype.setChanges = function(aChanges) {
 		this.setProperty("changes", aChanges);
-		this._oDetailModel.setData((aChanges || []).reverse().map(this._formatChangesModelItem.bind(this)));
+		this._oDetailModel.setData((aChanges || []).reverse().map(formatChangesModelItem.bind(this, this.getOverlayId())));
 	};
 
 	ChangeIndicator.prototype._onSelect = function(oEvent) {
@@ -270,50 +366,6 @@ sap.ui.define([
 		this[sFunctionName]("sapUiRtaHover");
 	};
 
-	ChangeIndicator.prototype._formatChangesModelItem = function(mChangeInformation) {
-		var oAffectedElement = Core.byId(mChangeInformation.affectedElementId);
-		var mPayload = Object.keys(mChangeInformation.payload || {}).reduce(function(mPayload, sKey) {
-			var vOriginalValue = mChangeInformation.payload[sKey];
-			var bIsBinding = FlUtils.isBinding(vOriginalValue);
-			var vValue = bIsBinding
-				? resolveBinding(vOriginalValue, oAffectedElement)
-				: vOriginalValue;
-			mPayload[sKey] = vValue;
-			return mPayload;
-		}, {});
-
-		var mPropertyBag = { appComponent: FlUtils.getAppComponentForControl(oAffectedElement) };
-		var oOverlay = Core.byId(this.getOverlayId());
-		var sElementLabel = oOverlay.getDesignTimeMetadata().getLabel(oAffectedElement);
-		var oVisualizationUtil = getVisualizationCategory(mChangeInformation.commandName);
-		var oDescription = oVisualizationUtil && oVisualizationUtil.getDescription(mPayload, sElementLabel, mPropertyBag);
-		var oRtaResourceBundle = Core.getLibraryResourceBundle("sap.ui.rta");
-		sElementLabel = sElementLabel && "'" + sElementLabel + "'";
-		var sShortenedElementLabel = ChangeVisualizationUtils.shortenString(sElementLabel);
-		var sChangeTextKey = (
-			"TXT_CHANGEVISUALIZATION_CHANGE_"
-			+ mChangeInformation.commandName.toUpperCase()
-		);
-		var sDescriptionText = oDescription ? oDescription.descriptionText : oRtaResourceBundle.getText(sChangeTextKey, sShortenedElementLabel);
-		var sDescriptionTooltip = oDescription ? oDescription.descriptionTooltip : oRtaResourceBundle.getText(sChangeTextKey, sElementLabel);
-		var sCreationDate = mChangeInformation.change.getCreation();
-		var oDate = new Date(sCreationDate);
-		var sFallbackDate = oRtaResourceBundle.getText("TXT_CHANGEVISUALIZATION_CREATED_IN_SESSION_DATE");
-		var sFullDate = sCreationDate ? DateFormat.getDateTimeInstance().format(oDate) : sFallbackDate;
-		var sRelativeDate = sCreationDate ? DateFormat.getDateTimeInstance({ relative: "true" }).format(oDate) : sFallbackDate;
-		var sDetailButtonText = oDescription && oDescription.buttonText;
-		return {
-			id: mChangeInformation.id,
-			change: mChangeInformation,
-			description: sDescriptionText,
-			descriptionTooltip: sDescriptionTooltip && sDescriptionText.length < sDescriptionTooltip.length ? sDescriptionTooltip : null,
-			fullDate: sFullDate,
-			relativeDate: sRelativeDate,
-			detailButtonText: sDetailButtonText,
-			icon: CATEGORY_ICONS[mChangeInformation.commandCategory]
-		};
-	};
-
 	ChangeIndicator.prototype._openDetailPopover = function() {
 		if (!this.getAggregation("_popover")) {
 			//store the tabindex (tabindex will be removed on opening the popover)

package/src/sap/ui/rta/util/changeVisualization/ChangeIndicatorCategorySelection.fragment.xml

@@ -18,13 +18,13 @@
 		</MessageStrip>
 		<List
 			class="sapUiRtaChangesList"
-			items="{visualizationModel>/commandCategories/}">
+			items="{visualizationModel>/changeCategories/}">
 			<StandardListItem
 				title="{visualizationModel>title}"
 				counter="{visualizationModel>count}"
 				type="{= ${visualizationModel>count} > 0 ? 'Active' : 'Inactive'}"
 				icon="{visualizationModel>icon}"
-				press=".onCommandCategorySelection"/>
+				press=".onChangeCategorySelection"/>
 		</List>
 	</Popover>
 </core:FragmentDefinition>

package/src/sap/ui/rta/util/changeVisualization/ChangeIndicatorPopover.fragment.xml

@@ -31,7 +31,8 @@
 					<cells>
 						<core:Icon
 							src="{details>icon}"
-							class="sapUiTinyMarginBegin"/>
+							class="sapUiTinyMarginBegin"
+							tooltip="{details>iconTooltip}"/>
 						<HBox alignItems="Center">
 							<Text
 								text="{details>description}"

package/src/sap/ui/rta/util/changeVisualization/ChangeIndicatorRegistry.js

@@ -5,15 +5,29 @@
  */
 
 sap.ui.define([
-	"sap/ui/base/ManagedObject",
 	"sap/base/util/includes",
 	"sap/base/util/values",
-	"sap/base/util/restricted/_omit"
+	"sap/base/util/restricted/_omit",
+	"sap/base/Log",
+	"sap/ui/base/ManagedObject",
+	"sap/ui/core/util/reflection/JsControlTreeModifier",
+	"sap/ui/dt/ElementUtil",
+	"sap/ui/fl/write/api/ChangesWriteAPI",
+	"sap/ui/fl/Utils",
+	"sap/ui/fl/changeHandler/common/ChangeCategories",
+	"sap/ui/core/Core"
 ], function(
-	ManagedObject,
 	includes,
 	values,
-	_omit
+	_omit,
+	Log,
+	ManagedObject,
+	JsControlTreeModifier,
+	ElementUtil,
+	ChangesWriteAPI,
+	FlUtils,
+	ChangeCategories,
+	Core
 ) {
 	"use strict";
 
@@ -25,7 +39,7 @@ sap.ui.define([
 	 * @alias sap.ui.rta.util.changeVisualization.ChangeIndicatorRegistry
 	 * @author SAP SE
 	 * @since 1.86.0
-	 * @version 1.103.1
+	 * @version 1.106.0
 	 * @private
 	 */
 	var ChangeIndicatorRegistry = ManagedObject.extend("sap.ui.rta.util.changeVisualization.ChangeIndicatorRegistry", {
@@ -34,15 +48,25 @@ sap.ui.define([
 				/**
 				 * Available command categories
 				 */
-				commandCategories: {
+				changeCategories: {
 					type: "object",
 					defaultValue: []
+				},
+				/**
+				 * Id of the component or control to visualize the changes for
+				 */
+				 rootControlId: {
+					type: "string"
 				}
 			}
 		},
 		constructor: function () {
 			ManagedObject.prototype.constructor.apply(this, arguments);
-			this._oChanges = {};
+
+			// List of entries with indicator data, grouped by Change ID
+			this._oRegisteredChanges = {};
+
+			// List of actual change indicator objects, grouped by selector
 			this._oChangeIndicators = {};
 		}
 	});
@@ -52,12 +76,12 @@ sap.ui.define([
 	};
 
 	/**
-	 * Returns all registered changes.
+	 * Returns the change indicator data for all registered changes.
 	 *
-	 * @returns {object[]} Registered changes
+	 * @returns {object[]} Change indicator data for all registered changes
 	 */
-	ChangeIndicatorRegistry.prototype.getChanges = function () {
-		return values(this._oChanges || {}).map(function (oChange) {
+	ChangeIndicatorRegistry.prototype.getAllRegisteredChanges = function () {
+		return values(this._oRegisteredChanges || {}).map(function (oChange) {
 			return Object.assign({}, oChange);
 		});
 	};
@@ -65,69 +89,65 @@ sap.ui.define([
 	/**
 	 * Returns the IDs of all registered changes.
 	 *
-	 * @returns {string[]} Promise with both design time and runtime change
+	 * @returns {string[]} Array with both design time and runtime registered changes
 	 */
-	ChangeIndicatorRegistry.prototype.getChangeIds = function () {
-		return Object.keys(this._oChanges || {});
+	ChangeIndicatorRegistry.prototype.getRegisteredChangeIds = function () {
+		return Object.keys(this._oRegisteredChanges || {});
 	};
 
 	/**
-	 * Returns a registered change.
+	 * Returns a data entry of a registered change indicator for a change ID.
 	 *
 	 * @param {string} sChangeId - ID of the registered change
 	 * @returns {object} Registered change
 	 */
-	ChangeIndicatorRegistry.prototype.getChange = function (sChangeId) {
-		return this._oChanges[sChangeId] && Object.assign({}, this._oChanges[sChangeId]);
+	ChangeIndicatorRegistry.prototype.getRegisteredChange = function (sChangeId) {
+		return this._oRegisteredChanges[sChangeId] && Object.assign({}, this._oRegisteredChanges[sChangeId]);
 	};
 
 	/**
 	 * Groups all registered changes by their selectors and returns a list of selectors
-	 * with all dependent and non-dependent changes.
+	 * with all dependent and non-dependent change indicator data.
 	 *
-	 * @returns {object[]} Change indicators
+	 * @returns {object} List of selectors with change indicator data.
 	 */
-	ChangeIndicatorRegistry.prototype.getChangeIndicatorData = function () {
+	ChangeIndicatorRegistry.prototype.getSelectorsWithRegisteredChanges = function () {
 		var oChangeIndicators = {};
 
-		function addSelector (sSelectorId, sAffectedElementId, oChange, bDependent) {
+		function addSelector (sSelectorId, sAffectedElementId, oChangeIndicatorData, bDependent) {
 			if (oChangeIndicators[sSelectorId] === undefined) {
 				oChangeIndicators[sSelectorId] = [];
 			}
 			oChangeIndicators[sSelectorId].push(Object.assign(
 				{
-					id: oChange.change.getId(),
+					id: oChangeIndicatorData.change.getId(),
 					dependent: bDependent,
 					affectedElementId: sAffectedElementId,
-					payload: oChange.visualizationInfo.payload || {}
+					payload: oChangeIndicatorData.visualizationInfo.payload || {}
 				},
-				_omit(oChange, ["visualizationInfo"])
+				_omit(oChangeIndicatorData, ["visualizationInfo"])
 			));
 		}
 
-		values(this._oChanges).forEach(function (oChange) {
-			oChange.visualizationInfo.displayElementIds.forEach(function (sSelectorId, iIndex) {
-				addSelector(sSelectorId, oChange.visualizationInfo.affectedElementIds[iIndex], oChange, false);
-			});
+		values(this._oRegisteredChanges)
+			.forEach(function (oChangeIndicatorData) {
+				oChangeIndicatorData.visualizationInfo.displayElementIds
+				.forEach(function (sId, iIndex) {
+					// in some cases (like with simple forms) you have to pass the stable id of the child element because the parent id is unstable
+					if (oChangeIndicatorData.visualizationInfo.hasParentWithUnstableId) {
+						sId = Core.byId(sId).getParent().getId();
+					}
+					addSelector(sId, oChangeIndicatorData.visualizationInfo.affectedElementIds[iIndex], oChangeIndicatorData, false);
+				});
 
-			oChange.visualizationInfo.dependentElementIds.forEach(function (sSelectorId) {
-				addSelector(sSelectorId, sSelectorId, oChange, true);
+				oChangeIndicatorData.visualizationInfo.dependentElementIds.forEach(function (sId) {
+					addSelector(sId, sId, oChangeIndicatorData, true);
+				});
 			});
-		});
 
 		return oChangeIndicators;
 	};
 
-	/**
-	 * Checks if the given element ID was registered as a change indicator.
-	 *
-	 * @param {string} sSelectorId - ID of the element to check
-	 * @returns {boolean} Whether the element was registered as an indicator
-	 */
-	ChangeIndicatorRegistry.prototype.hasChangeIndicator = function (sSelectorId) {
-		return !!this._oChangeIndicators[sSelectorId];
-	};
-
 	/**
 	 * Returns the registered change indicator for the given element ID.
 	 *
@@ -152,25 +172,88 @@ sap.ui.define([
 	 *
 	 * @param {object} oChange - The change to register
 	 * @param {string} sCommandName - Command name of the change
+	 * @returns {Promise<undefined>} Resolves as soon as the change is registered
 	 */
-	ChangeIndicatorRegistry.prototype.registerChange = function (oChange, sCommandName) {
-		var aCategories = this.getCommandCategories();
-		var oNewChangeInformation = {
-			change: oChange,
-			commandName: sCommandName,
-			commandCategory: Object.keys(aCategories).find(function (sCommandCategoryName) {
-				return includes(aCategories[sCommandCategoryName], sCommandName);
-			}),
-			visualizationInfo: {
-				affectedElementIds: [],
-				displayElementIds: [],
-				dependentElementIds: []
+	ChangeIndicatorRegistry.prototype.registerChange = function(oChange, sCommandName) {
+		var oAppComponent = FlUtils.getAppComponentForControl(ElementUtil.getElementInstance(this.getRootControlId()));
+		return getVisualizationInfo(oChange, oAppComponent).then(function(mChangeVisualizationInfo) {
+			var aCategories = this.getChangeCategories();
+			var sChangeCategory;
+			// For "settings", the control developer can choose one of the existing categories
+			if (sCommandName === "settings" && includes(Object.keys(aCategories), mChangeVisualizationInfo.payload.category)) {
+				sChangeCategory = mChangeVisualizationInfo.payload.category;
+			} else {
+				sChangeCategory = Object.keys(aCategories).find(function (sChangeCategoryName) {
+					return includes(aCategories[sChangeCategoryName], sCommandName);
+				});
+				if (!sChangeCategory) {
+					sChangeCategory = ChangeCategories.OTHER;
+				}
 			}
-		};
 
-		this._oChanges[oChange.getId()] = oNewChangeInformation;
+			this._oRegisteredChanges[oChange.getId()] = {
+				change: oChange,
+				commandName: sCommandName,
+				changeCategory: sChangeCategory,
+				visualizationInfo: mChangeVisualizationInfo
+			};
+		}.bind(this));
 	};
 
+	function getVisualizationInfo(oChange, oAppComponent) {
+		function getSelectorIds(aSelectorList) {
+			if (!aSelectorList) {
+				return undefined;
+			}
+			return aSelectorList
+				.map(function(vSelector) {
+					var oElement = typeof vSelector.getId === "function"
+						? vSelector
+						: JsControlTreeModifier.bySelector(vSelector, oAppComponent);
+					return oElement && oElement.getId();
+				})
+				.filter(Boolean);
+		}
+
+		return getInfoFromChangeHandler(oAppComponent, oChange)
+			.then(function(oInfoFromChangeHandler) {
+				var mVisualizationInfo = oInfoFromChangeHandler || {};
+				var aAffectedElementIds = getSelectorIds(mVisualizationInfo.affectedControls || [oChange.getSelector()]);
+
+				return {
+					affectedElementIds: aAffectedElementIds,
+					dependentElementIds: getSelectorIds(mVisualizationInfo.dependentControls) || [],
+					displayElementIds: getSelectorIds(mVisualizationInfo.displayControls) || aAffectedElementIds,
+					hasParentWithUnstableId: mVisualizationInfo.hasParentWithUnstableId,
+					payload: mVisualizationInfo.payload || {}
+				};
+			});
+	}
+
+	function getInfoFromChangeHandler(oAppComponent, oChange) {
+		var oControl = JsControlTreeModifier.bySelector(oChange.getSelector(), oAppComponent);
+		if (oControl) {
+			return ChangesWriteAPI.getChangeHandler({
+				changeType: oChange.getChangeType(),
+				element: oControl,
+				modifier: JsControlTreeModifier,
+				layer: oChange.getLayer()
+			})
+				.then(function(oChangeHandler) {
+					if (oChangeHandler && typeof oChangeHandler.getChangeVisualizationInfo === "function") {
+						return oChangeHandler.getChangeVisualizationInfo(oChange, oAppComponent);
+					}
+					return undefined;
+				})
+				.catch(function(vErr) {
+					Log.error(vErr);
+					return undefined;
+				});
+		}
+
+		return Promise.resolve();
+	}
+
 	/**
 	 * Adds a change indicator to the registry.
 	 *
@@ -181,31 +264,12 @@ sap.ui.define([
 		this._oChangeIndicators[sSelectorId] = oChangeIndicator;
 	};
 
-	/**
-	 * Adds selectors for a registered change.
-	 *
-	 * @param {string} sChangeId - ID of the registered change
-	 * @param {object} mVisualizationInfo - Map of selector IDs to register
-	 * @param {string[]} [mVisualizationInfo.affectedElementIds] - Array of affected element IDs
-	 * @param {string[]} [mVisualizationInfo.displayElementIds] - Array of element IDs that the indicators are attached to
-	 * @param {string[]} [mVisualizationInfo.dependentElementIds] - Array of element IDs that the dependent indicators are attached to
-	 * @param {object} [mVisualizationInfo.payload] - Command category specific visualization information
-	 */
-	ChangeIndicatorRegistry.prototype.addVisualizationInfo = function (sChangeId, mVisualizationInfo) {
-		var oChange = this._oChanges[sChangeId];
-		if (oChange === undefined) {
-			throw new Error("Change id is not registered");
-		}
-
-		oChange.visualizationInfo = Object.assign({}, oChange.visualizationInfo, mVisualizationInfo);
-	};
-
 	/**
 	 * Resets the change and change indicator registries.
 	 */
 	ChangeIndicatorRegistry.prototype.reset = function () {
-		Object.keys(this._oChanges).forEach(function (sKeyToRemove) {
-			this.removeChange(sKeyToRemove);
+		Object.keys(this._oRegisteredChanges).forEach(function (sKeyToRemove) {
+			this.removeRegisteredChange(sKeyToRemove);
 		}.bind(this));
 
 		values(this._oChangeIndicators).forEach(function (oIndicator) {
@@ -215,12 +279,12 @@ sap.ui.define([
 	};
 
 	/**
-	 * Removes a change.
+	 * Removes a data entry of a registered change indicator.
 	 *
 	 * @param {string} sChangeId - ID of the registered change
 	 */
-	ChangeIndicatorRegistry.prototype.removeChange = function (sChangeId) {
-		delete this._oChanges[sChangeId];
+	ChangeIndicatorRegistry.prototype.removeRegisteredChange = function (sChangeId) {
+		delete this._oRegisteredChanges[sChangeId];
 	};
 
 	return ChangeIndicatorRegistry;