@openui5/sap.ui.mdc 1.97.1 → 1.100.0

package/test/sap/ui/mdc/testutils/opa/link/TestObjects.js

@@ -0,0 +1,112 @@
+/*!
+ * ${copyright}
+ */
+sap.ui.define([
+	"sap/ui/test/Opa5",
+	"./Actions",
+	"./Assertions",
+	"../p13n/Actions",
+    "./waitForLink"
+], function(
+	Opa5,
+	linkActions,
+	linkAssertions,
+	p13nActions,
+    waitForLink
+) {
+	"use strict";
+
+	Opa5.createPageObjects({
+		onTheMDCLink: {
+			actions: {
+                /**
+                 * Object to identify a <code>sap.ui.mdc.Link</code>. Should contain at least one of the following properties: <code>text</code> and <code>id</code>.
+                 * @typedef {object} LinkIdentifier
+                 * @property {string} id ID of a given <code>sap.m.Link</code> that represents the <code>sap.ui.mdc.Link</code>
+                 * @property {string} text Text of a given <code>sap.m.Link</code> that represents the <code>sap.ui.mdc.Link</code>
+                 */
+                /**
+                 * Opa5 test action
+                 * @param {LinkIdentifier} oLinkIdentifier The object to identify the <code>sap.ui.mdc.Link</code>
+                 * @param {string[]} aLinks Array containing the texts of the links that are the result of the personalization
+                 * @returns {Promise} OPA waitFor
+                 * 1. Opens the personalization dialog of a given <code>sap.ui.mdc.Link</code>.
+                 * 2. Selects all links given by <code>aLinks</code> and deselects all other links.
+                 * 3. Closes the personalization dialog.
+                 */
+                iPersonalizeTheLinks: function(oLinkIdentifier, aLinks) {
+                    return waitForLink.call(this, oLinkIdentifier, {
+                        success: function(oLink) {
+                            p13nActions.iPersonalizeLink.call(this, oLink, aLinks);
+                        }
+                    });
+                },
+                /**
+                 * Opa5 test action
+                 * @param {LinkIdentifier} oLinkIdentifier The object to identify the <code>sap.ui.mdc.Link</code> that is reset
+                 * @returns {Promise} OPA waitFor
+                 * 1. Opens the personalization dialog of a given <code>sap.ui.mdc.Link</code>.
+                 * 2. Presses the Reset personalization button.
+                 * 3. Confirms the Reset dialog.
+                 * 4. Closes the personalization dialog.
+                 */
+                iResetThePersonalization: function(oLinkIdentifier) {
+                    return waitForLink.call(this, oLinkIdentifier, {
+                        success: function(oLink) {
+                            p13nActions.iResetThePersonalization.call(this, oLink);
+                        }
+                    });
+                },
+                /**
+                * Opa5 test action
+                * @param {LinkIdentifier} oLinkIdentifier The object to identify the <code>sap.ui.mdc.Link</code> that is pressed
+                * @returns {Promise} OPA waitFor
+                */
+                iPressTheLink: function(oLinkIdentifier) {
+                    return linkActions.iPressTheLink.call(this, oLinkIdentifier);
+                },
+                /**
+                * Opa5 test action
+                * @param {LinkIdentifier} oLinkIdentifier The object to identify the <code>sap.ui.mdc.Link</code> that opens the popover
+                * @param {string} sLink The text of the link that is to be clicked on the popover
+                * @returns {Promise} OPA waitFor
+                * 1. Presses a given <code>sap.ui.mdc.Link</code> to open its popover.
+                * 2. Presses a link on the opened popover defined by <code>sLink</code>.
+                */
+                iPressLinkOnPopover: function(oLinkIdentifier, sLink) {
+                    return linkActions.iPressLinkOnPopover.call(this, oLinkIdentifier, sLink);
+                },
+                /**
+                 * Opa5 test action
+                 * @returns {Promise} OPA waitFor
+                 * Closes an open popover of the <code>sap.ui.mdc.Link</code>.
+                 */
+                iCloseThePopover: function() {
+                    return linkActions.iCloseThePopover.call(this);
+                }
+            },
+            assertions: {
+                /**
+                * Opa5 test action
+                * @param {LinkIdentifier} oLinkIdentifier The object to identify the <code>sap.ui.mdc.Link</code> that opens the popover
+                * @returns {Promise} OPA waitFor
+                * Creates an assumption that there is an open popover for a given <code>sap.ui.mdc.Link</code>.
+                */
+                iShouldSeeAPopover: function(oLinkIdentifier) {
+                    return linkAssertions.iShouldSeeAPopover.call(this, oLinkIdentifier);
+                },
+                /**
+                 * Opa5 test action
+                 * @param {LinkIdentifier} oLinkIdentifier The object to identify the <code>sap.ui.mdc.Link</code> that opens the popover
+                 * @param {string[]} aLinks Array containing the texts of the links that are visible on the popover
+                 * @returns {Promise} OPA waitFor
+                 * Creates an assumption that there is an open popover for a given <code>sap.ui.mdc.Link</code> and checks that all given links defined in <code>aLinks</code> are on that popover in a defined order.
+                 */
+                iShouldSeeLinksOnPopover: function(oLinkIdentifier, aLinks) {
+                    return linkAssertions.iShouldSeeLinksOnPopover.call(this, oLinkIdentifier, aLinks);
+                }
+            }
+        }
+    });
+
+});

package/test/sap/ui/mdc/testutils/opa/link/waitForLink.js

@@ -0,0 +1,50 @@
+/*!
+ * ${copyright}
+ */
+sap.ui.define([
+	"sap/ui/test/Opa5",
+    "sap/ui/test/matchers/PropertyStrictEquals"
+], function(
+	Opa5,
+    PropertyStrictEquals
+) {
+	"use strict";
+
+	return function waitForLink(oLinkIdentifier, oSettings) {
+        var sText = oLinkIdentifier.text;
+        var sId = oLinkIdentifier.id;
+        Opa5.assert.ok(sText || sId, "LinkIdentifier correct Text: '" + sText + "' - ID: '" + sId + "'");
+        var fnCallSuccess = function(oLink) {
+            if (typeof oSettings.success === "function") {
+                oSettings.success.call(this, oLink);
+            }
+        };
+
+        var oOpaSettings = {
+            controlType: "sap.m.Link",
+            actions: oSettings.actions
+        };
+
+        if (sText) {
+            oOpaSettings.matchers = new PropertyStrictEquals({
+                name: "text",
+                value: sText
+            });
+        }
+
+        if (sId) {
+            oOpaSettings.id = sId;
+            oOpaSettings.success = function(oLinkControl) {
+                Opa5.assert.ok(oLinkControl, "sap.ui.mdc.Link found");
+                fnCallSuccess.call(this, oLinkControl);
+            };
+        } else {
+            oOpaSettings.success = function(aLinkControls) {
+                Opa5.assert.equal(aLinkControls.length, 1, "sap.ui.mdc.Link found");
+                fnCallSuccess.call(this, aLinkControls[0]);
+            };
+        }
+
+        return this.waitFor(oOpaSettings);
+    };
+});

package/test/sap/ui/mdc/testutils/opa/p13n/Actions.js

@@ -16,7 +16,9 @@ sap.ui.define([
 	"./waitForSelectWithSelectedTextOnPanel",
 	"./Util",
 	"sap/base/Log",
-	"sap/base/util/UriParameters"
+	"sap/base/util/UriParameters",
+	"sap/ui/core/Core",
+	"sap/ui/Device"
 ], function(
 	Opa5,
 	Matcher,
@@ -31,11 +33,13 @@ sap.ui.define([
 	waitForSelectWithSelectedTextOnPanel,
 	Util,
 	Log,
-	UriParameters
+	UriParameters,
+	oCore,
+	Device
 ) {
 	"use strict";
 
-	var oMDCBundle = sap.ui.getCore().getLibraryResourceBundle("sap.ui.mdc");
+	var oMDCBundle = oCore.getLibraryResourceBundle("sap.ui.mdc");
 
 	var iOpenThePersonalizationDialog = function(oControl, oSettings) {
 		var sControlId = typeof oControl === "string" ? oControl : oControl.getId();
@@ -46,51 +50,88 @@ sap.ui.define([
 			success: function(oControlInstance) {
 				Opa5.assert.ok(oControlInstance);
 
-				aButtonMatchers.push(new Ancestor(oControlInstance));
+				if (oControlInstance.isA("sap.m.Link")) {
+					// mdc.Link handling
 
-				if (oControlInstance.isA("sap.ui.comp.smartchart.SmartChart")) {
-					aDialogMatchers.push(function(oP13nDialog) {
-						return oP13nDialog.getParent().getChart() === oControlInstance.getChart().getId();
+					new Press().executeOn(oControlInstance);
+					this.waitFor({
+						controlType: "sap.ui.mdc.link.Panel",
+						success: function(aPanels) {
+							Opa5.assert.equal(aPanels.length, 1, "mdc.link.Panel found");
+							var oPanel = aPanels[0];
+
+							waitForP13nButtonWithMatchers.call(this, {
+								actions: new Press(),
+								matchers: [
+									new Ancestor(oPanel, false),
+									new PropertyStrictEquals({
+										name: "text",
+										value: oMDCBundle.getText("info.POPOVER_DEFINE_LINKS")
+									})
+								],
+								success: function() {
+									waitForP13nDialog.call(this, {
+										matchers: new PropertyStrictEquals({
+											name: "title",
+											value: oMDCBundle.getText("info.SELECTION_DIALOG_ALIGNEDTITLE")
+										}),
+										success:  function(oP13nDialog) {
+											if (oSettings && typeof oSettings.success === "function") {
+												oSettings.success.call(this, oP13nDialog);
+											}
+										}
+									});
+								}
+							});
+						}
 					});
 				} else {
-					aDialogMatchers.push(new Ancestor(oControlInstance, false));
-				}
+					aButtonMatchers.push(new Ancestor(oControlInstance));
 
-				if (oControlInstance.isA("sap.ui.mdc.FilterBar")) {
-					// Add matcher for p13n button text
-					var oMatcher = new Matcher();
-					oMatcher.isMatching = function(oButton) {
-						return oButton.getText().includes(oMDCBundle.getText("filterbar.ADAPT"));
-					};
-					aButtonMatchers.push(oMatcher);
-					aDialogMatchers.push(new Properties({
-						title: oMDCBundle.getText("filterbar.ADAPT_TITLE")
-					}));
-				} else {
-					// Add matcher for p13n button icon
-					aButtonMatchers.push(new Properties({
-						icon: Util.icons.settings
-					}));
-					aDialogMatchers.push(new Properties({
-						title: oMDCBundle.getText("p13nDialog.VIEW_SETTINGS")
-					}));
-				}
+					if (oControlInstance.isA("sap.ui.comp.smartchart.SmartChart")) {
+						aDialogMatchers.push(function(oP13nDialog) {
+							return oP13nDialog.getParent().getChart() === oControlInstance.getChart().getId();
+						});
+					} else {
+						aDialogMatchers.push(new Ancestor(oControlInstance, false));
+					}
 
-				waitForP13nButtonWithMatchers.call(this, {
-					actions: new Press(),
-					matchers: aButtonMatchers,
-					success: function() {
-						waitForP13nDialog.call(this, {
-							matchers: aDialogMatchers,
-							success:  function(oP13nDialog) {
-								if (oSettings && typeof oSettings.success === "function") {
-									oSettings.success.call(this, oP13nDialog);
+					if (oControlInstance.isA("sap.ui.mdc.FilterBar")) {
+						// Add matcher for p13n button text
+						var oMatcher = new Matcher();
+						oMatcher.isMatching = function(oButton) {
+							return oButton.getText().includes(oMDCBundle.getText("filterbar.ADAPT"));
+						};
+						aButtonMatchers.push(oMatcher);
+						aDialogMatchers.push(new Properties({
+							title: oMDCBundle.getText("filterbar.ADAPT_TITLE")
+						}));
+					} else {
+						// Add matcher for p13n button icon
+						aButtonMatchers.push(new Properties({
+							icon: Util.icons.settings
+						}));
+						aDialogMatchers.push(new Properties({
+							title: oMDCBundle.getText("p13nDialog.VIEW_SETTINGS")
+						}));
+					}
+
+					waitForP13nButtonWithMatchers.call(this, {
+						actions: new Press(),
+						matchers: aButtonMatchers,
+						success: function() {
+							waitForP13nDialog.call(this, {
+								matchers: aDialogMatchers,
+								success:  function(oP13nDialog) {
+									if (oSettings && typeof oSettings.success === "function") {
+										oSettings.success.call(this, oP13nDialog);
+									}
 								}
-							}
-						});
-					},
-					errorMessage: "Control '" + sControlId + "' has no P13n button"
-				});
+							});
+						},
+						errorMessage: "Control '" + sControlId + "' has no P13n button"
+					});
+				}
 			},
 			errorMessage: "Control '" + sControlId + "' not found."
 		});
@@ -456,7 +497,7 @@ sap.ui.define([
 
 	var iPersonalizeListViewItems = function(oP13nDialog, aItems) {
 		this.waitFor({
-			controlType: oP13nDialog.getContent()[0].getView("columns") && oP13nDialog.getContent()[0].getView("columns").getContent().isA("sap.ui.mdc.p13n.panels.ListView") ? "sap.ui.mdc.p13n.panels.ListView" : "sap.m.p13n.SelectionPanel",
+			controlType: oP13nDialog.getContent()[0].getView("columns") && oP13nDialog.getContent()[0].getView("columns").getContent().isA("sap.m.p13n.SelectionPanel") ? "sap.m.p13n.SelectionPanel" : "sap.m.p13n.SelectionPanel",
 			matchers: new Ancestor(oP13nDialog, false),
 			success: function(aListViews) {
 				var oListView = aListViews[0];
@@ -611,21 +652,111 @@ sap.ui.define([
 		});
 	};
 
-    return {
+	var iPersonalizeOldChartP13n = function(oControl, sChartType, aItems, oP13nDialog) {
+		this.waitFor({
+			controlType: "sap.m.P13nDimMeasurePanel",
+			matchers: new Ancestor(oP13nDialog, false),
+			success: function(aP13nDimMeasurePanels) {
+				var oP13nDimMeasurePanel = aP13nDimMeasurePanels[0];
+				this.waitFor({
+				controlType: "sap.m.OverflowToolbar",
+				matchers: new Ancestor(oP13nDimMeasurePanel, false),
+				success: function(aOverflowToolbars) {
+					var oOverflowToolbar = aOverflowToolbars[0];
+					this.waitFor({
+						controlType: "sap.m.ComboBox",
+						matchers: new Ancestor(oOverflowToolbar),
+						success: function(aComboBoxes) {
+							var oComboBox = aComboBoxes[0];
+							iChangeComboBoxSelection.call(this, oComboBox, sChartType, {
+								success: function() {
+									this.waitFor({
+										controlType: "sap.m.ColumnListItem",
+										matchers: [
+											new Ancestor(oP13nDialog, false)
+										],
+										actions: function(oColumnListItem) {
+											this.waitFor({
+												controlType: "sap.m.Text",
+												matchers: new Ancestor(oColumnListItem),
+												success: function(aTexts) {
+													var oText = aTexts[0];
+													var oItem = aItems.find(function(oItem) {
+														return oText.getText() === oItem.key;
+													});
+													var bItemIsPresent = !!oItem;
+
+													this.waitFor({
+														controlType: "sap.m.CheckBox",
+														matchers: new Ancestor(oColumnListItem),
+														actions: function(oCheckBox) {
+															if ((!oCheckBox.getSelected() && bItemIsPresent) ||
+																(oCheckBox.getSelected() && !bItemIsPresent)) {
+																new Press().executeOn(oCheckBox);
+															}
+														},
+														success: function() {
+															if (bItemIsPresent) {
+																this.waitFor({
+																	controlType: "sap.m.Select",
+																	matchers: new Ancestor(oColumnListItem),
+																	actions: function(oSelect) {
+																		iChangeSelectSelection.call(this, oSelect, oItem.role);
+																	}.bind(this)
+																});
+															}
+														}
+													});
+												}
+											});
+										}.bind(this),
+										success: function() {
+											iPressTheOKButtonOnTheDialog.call(this,oP13nDialog);
+										}
+									});
+								}
+							});
+						}
+					});
+				}
+				});
+			}
+		});
+	};
+
+	return {
 		iPressTheOKButtonOnTheDialog: function(oDialog, oSettings) {
 			return iPressTheOKButtonOnTheDialog.call(this, oDialog, oSettings);
 		},
 		iOpenThePersonalizationDialog: function(oControl, oSettings) {
 			return iOpenThePersonalizationDialog.call(this, oControl, oSettings);
 		},
+		/**
+		 * @typedef {object} ChartPersonalizationConfiguration
+		 * @property {string} key Key of the value that is the result of the personalization
+		 * @property {string} role Role of the given value
+		 */
+		/**
+		 * OPA5 test action
+		 * 1. Opens the personalization dialog of a given chart.
+		 * 2. Selects a chart type given by <code>sChartType</code>.
+		 * 3. Executes the given <code>ChartPersonalizationConfiguration</code>.
+		 * 4. Closes the personalization dialog.
+		 * @param {sap.ui.core.Control | string} oControl Instance / ID of the <code>SmartChart</code> that is personalized
+		 * @param {string} sChartType String containing the type of chart that is displayed
+		 * @param {ChartPersonalizationConfiguration[]} aItems Array containing the chart personalization configuration objects
+		 * @returns {Promise} OPA waitFor
+		 */
 		iPersonalizeChart: function(oControl, sChartType, aItems) {
 			return iPersonalize.call(this, oControl, Util.texts.chart, {
 				success: function(oP13nDialog) {
 
-					if (UriParameters.fromQuery(window.location.search).get("newChartP13n") === "true") {
-
+					//oP13nDialog.getContent()[0].getView("item") && oP13nDialog.getContent()[0].getView("item").getContent().isA("sap.m.p13n.SelectionPanel")
+					if (oP13nDialog.getContent()[0].getView("dimeasure").getContent().isA("sap.m.P13nDimMeasurePanel")){
+						iPersonalizeOldChartP13n.call(this, oControl, sChartType, aItems, oP13nDialog);
+					} else {
 						this.waitFor({
-							controlType: "sap.ui.mdc.p13n.panels.ChartItemPanelNew",
+							controlType: "sap.ui.mdc.p13n.panels.ChartItemPanel",
 							matchers: new Ancestor(oP13nDialog, false),
 							success: function(aItemPanels) {
 								//This is done in 3 steps
@@ -768,84 +899,17 @@ sap.ui.define([
 								});
 							}
 						});
-					} else {
-						this.waitFor({
-							controlType: "sap.m.P13nDimMeasurePanel",
-							matchers: new Ancestor(oP13nDialog, false),
-							success: function(aP13nDimMeasurePanels) {
-								var oP13nDimMeasurePanel = aP13nDimMeasurePanels[0];
-								this.waitFor({
-								controlType: "sap.m.OverflowToolbar",
-								matchers: new Ancestor(oP13nDimMeasurePanel, false),
-								success: function(aOverflowToolbars) {
-									var oOverflowToolbar = aOverflowToolbars[0];
-									this.waitFor({
-										controlType: "sap.m.ComboBox",
-										matchers: new Ancestor(oOverflowToolbar),
-										success: function(aComboBoxes) {
-											var oComboBox = aComboBoxes[0];
-											iChangeComboBoxSelection.call(this, oComboBox, sChartType, {
-												success: function() {
-													this.waitFor({
-														controlType: "sap.m.ColumnListItem",
-														matchers: [
-															new Ancestor(oP13nDialog, false)
-														],
-														actions: function(oColumnListItem) {
-															this.waitFor({
-																controlType: "sap.m.Text",
-																matchers: new Ancestor(oColumnListItem),
-																success: function(aTexts) {
-																	var oText = aTexts[0];
-																	var oItem = aItems.find(function(oItem) {
-																		return oText.getText() === oItem.key;
-																	});
-																	var bItemIsPresent = !!oItem;
-
-																	this.waitFor({
-																		controlType: "sap.m.CheckBox",
-																		matchers: new Ancestor(oColumnListItem),
-																		actions: function(oCheckBox) {
-																			if ((!oCheckBox.getSelected() && bItemIsPresent) ||
-																				(oCheckBox.getSelected() && !bItemIsPresent)) {
-																				new Press().executeOn(oCheckBox);
-																			}
-																		},
-																		success: function() {
-																			if (bItemIsPresent) {
-																				this.waitFor({
-																					controlType: "sap.m.Select",
-																					matchers: new Ancestor(oColumnListItem),
-																					actions: function(oSelect) {
-																						iChangeSelectSelection.call(this, oSelect, oItem.role);
-																					}.bind(this)
-																				});
-																			}
-																		}
-																	});
-																}
-															});
-														}.bind(this),
-														success: function() {
-															iPressTheOKButtonOnTheDialog.call(this,oP13nDialog);
-														}
-													});
-												}
-											});
-										}
-									});
-								}
-								});
-							}
-						});
 					}
 				}
 			});
 		},
 		/**
-		 *
+		 * OPA5 test action
+		 * 1. Opens the personalization dialog of a given table.
+		 * 2. Selects all columns determined by the given labels. Also deselects all other columns that are selected but not included in the given labels.
+		 * 3. Closes the personalization dialog.
 		 * @param {sap.ui.core.Control | string} oControl Instance / ID of the control which is to be personalized
-		 * @param {string[]} aColumns Array containing the keys of the columns that should be result of the personalisation
+		 * @param {string[]} aColumns Array containing the labels of the columns that are the result of the personalization
 		 * @returns {Promise} Opa waitFor
 		 */
 		 iPersonalizeColumns: function(oControl, aColumns) {
@@ -907,18 +971,68 @@ sap.ui.define([
 				}
 			});
 		},
+		/**
+		 * @param {sap.ui.core.Control | string} oControl Instance / ID of the control which is to be personalized
+		 * @param {string[]} aLinks an array containing the names of the links that should be result of the personalisation
+		 * @returns {Promise} Opa waitFor
+		 */
+		iPersonalizeLink: function(oControl, aLinks) {
+			return iOpenThePersonalizationDialog.call(this, oControl, {
+				success: function(oP13nDialog) {
+					this.waitFor({
+						controlType: "sap.ui.mdc.p13n.panels.LinkSelectionPanel",
+						matchers: new Ancestor(oP13nDialog, false),
+						success: function(aLinkSelectionPanels) {
+							Opa5.assert.equal(aLinkSelectionPanels.length, 1, "sap.ui.mdc.p13n.panels.LinkSelectionPanel found");
+							var oLinkSelectionPanel = aLinkSelectionPanels[0];
+							this.waitFor({
+								controlType: "sap.m.ColumnListItem",
+								matchers: new Ancestor(oLinkSelectionPanel, false),
+								actions: function(oColumnListItem) {
+									this.waitFor({
+										controlType: "sap.m.Link",
+										matchers: new Ancestor(oColumnListItem, false),
+										success: function(aLinkControls) {
+											var oLinkControl = aLinkControls[0];
+											this.waitFor({
+												controlType: "sap.m.CheckBox",
+												matchers: [
+													new Ancestor(oColumnListItem, false)
+												],
+												actions: function(oCheckBox) {
+													if ((!oCheckBox.getSelected() && aLinks.includes(oLinkControl.getText())) ||
+														(oCheckBox.getSelected() && !aLinks.includes(oLinkControl.getText()))) {
+														new Press().executeOn(oCheckBox);
+													}
+												}
+											});
+										}
+									});
+								}.bind(this),
+								success: function() {
+									iPressTheOKButtonOnTheDialog.call(this, oP13nDialog);
+								}
+							});
+						}
+					});
+				}
+			});
+		},
 		/**
 		 * @typedef {object} FilterPersonalizationConfiguration
-		 * @property {string} key of the item that should be result of the personalisation
-		 * @property {string} operator operator in which the items should be filtered
-		 * @property {string[]} values filter values for the given operator
-		 * @property {string} inputControl
+		 * @property {string} key Key of the value that is the result of the personalization
+		 * @property {string} operator Operator defining how the items are filtered
+		 * @property {string[]} values Filter values for the given operator
+		 * @property {string} inputControl <code>Control</code> that is used as input for the value
 		 */
 		/**
-		 *
-		 * @param {sap.ui.core.Control | string} oControl Instance / ID of the control which is to be reset
-		 * @param {FilterPersonalizationConfiguration[]} aConfigurations an array containing the group personalization configuration objects
-		 * @returns {Promise} Opa waitFor
+		 * OPA5 test action
+		 * 1. Opens the personalization dialog of a given chart.
+		 * 2. Executes the given <code>FilterPersonalizationConfiguration</code>.
+		 * 3. Closes the personalization dialog.
+		 * @param {sap.ui.core.Control | string} oControl Instance / ID of the <code>Control</code> that is filtered
+		 * @param {FilterPersonalizationConfiguration[]} aConfigurations Array containing the filter personalization configuration objects
+		 * @returns {Promise} OPA waitFor
 		 */
 		iPersonalizeFilter: function(oControl, aConfigurations) {
 			return iPersonalize.call(this, oControl, Util.texts.filter, {
@@ -965,11 +1079,14 @@ sap.ui.define([
 		},
 		/**
 		 * @typedef {object} GroupPersonalizationConfiguration
-		 * @property {string} key of the item that should be result of the personalisation
-		 * @property {boolean} showFieldAsColumn determinating if the "Show Field as Column" checkbox should be checked
+		 * @property {string} key of the item that is the result of the personalization
+		 * @property {boolean} showFieldAsColumn Determines if the "Show Field as Column" checkbox is to be checked
 		 */
 		/**
-		 *
+		 * Opa5 test action:
+		 * 1. Opens the personalization dialog of a given control.
+		 * 2. Executes the given <code>GroupPersonalizationConfiguration</code>.
+		 * 3. Closes the personalization dialog.
 		 * @param {sap.ui.core.Control | string} oControl Instance / ID of the control which is to be reset
 		 * @param {GroupPersonalizationConfiguration[]} aConfigurations an array containing the group personalization configuration objects
 		 * @returns {Promise} Opa waitFor
@@ -1007,14 +1124,17 @@ sap.ui.define([
 		},
 		/**
 		 * @typedef {object} SortPersonalizationConfiguration
-		 * @property {string} key of the item that should be result of the personalisation
-		 * @property {boolean} descending determinating if the sort direction is descending
+		 * @property {string} key Key of the item that is the result of the personalization
+		 * @property {boolean} descending Determines whether the sort direction is descending
 		 */
 		/**
-		 *
-		 * @param {sap.ui.core.Control | string} oControl Instance / ID of the control which is to be reset
-		 * @param {SortPersonalizationConfiguration[]} aConfigurations an array containing the sort personalization configuration objects
-		 * @returns {Promise} Opa waitFor
+		 * OPA5 test action
+		 * 1. Opens the personalization dialog of a given chart.
+		 * 2. Executes the given <code>SortPersonalizationConfiguration</code>.
+		 * 3. Closes the personalization dialog.
+		 * @param {sap.ui.core.Control | string} oControl Instance / ID of the <code>Control</code> that is sorted
+		 * @param {SortPersonalizationConfiguration[]} aConfigurations Array containing the sort personalization configuration objects
+		 * @returns {Promise} OPA waitFor
 		 */
 		iPersonalizeSort: function(oControl, aConfigurations) {
 			return iPersonalize.call(this, oControl, Util.texts.sort, {
@@ -1048,8 +1168,13 @@ sap.ui.define([
 			});
 		},
 		/**
-		 * @param {sap.ui.core.Control | string} oControl Instance / ID of the control which is to be reset
-		 * @returns {Promise} Opa waitFor
+		 * Opa5 test action
+		 * 1. Opens the personalization dialog of a given chart.
+		 * 2. Presses the reset personalization button.
+		 * 3. Confirms the reset dialog.
+		 * 4. Closes the personalization dialog.
+		 * @param {sap.ui.core.Control | string} oControl Instance / ID of the <code>Control</code> that is reset
+		 * @returns {Promise} OPA waitFor
 		 */
 		iResetThePersonalization: function (oControl) {
 			return iOpenThePersonalizationDialog.call(this, oControl, {
@@ -1070,5 +1195,5 @@ sap.ui.define([
 				}
 			});
 		}
-    };
+	};
 });