@openui5/sap.ui.mdc 1.97.1 → 1.100.0

package/src/sap/ui/mdc/util/PropertyHelper.js

@@ -21,28 +21,69 @@ sap.ui.define([
 
 	/*global Set, WeakMap */
 
+	/**
+	 * @typedef {object} sap.ui.mdc.util.PropertyInfo
+	 *
+	 * @property {string} name
+	 *   Unique, stable key for the property. It must only contain characters allowed for IDs, see {@link sap.ui.core.ID}. Does not have to be an
+	 *   existing attribute in the data model or the technical name of an attribute in the data model.
+	 * @property {string} [path]
+	 *   The technical path for a data source property.
+	 * @property {string} label
+	 *   Translatable text that labels the property.
+	 * @property {boolean} [visible=true]
+	 *   Whether the property is or can be visible to a user.
+	 * @property {string[]} [propertyInfos]
+	 *   The availability of this property makes <code>PropertyInfo</code> a complex <code>PropertyInfo</code>. Provides a list of related properties
+	 *   (by name).
+	 *   These related properties must be no complex <code>PropertyInfo</code> to avoid deep nesting.
+	 * @property {object} [typeConfig]
+	 *   Object which contains type-specific information about the property, especially the type instance (for example, for model filter creation in
+	 *   Table <code>rebind</code>).
+	 * @property {object} [extension]
+	 *   Reserved attribute. Must not be provided by the delegate directly as part of the <code>PropertyInfo</code>, but separately in
+	 *   the <code>fetchPropertyExtensions</code> method of the delegate. The <code>PropertyInfoExtension</code> is a key-value map where the key is
+	 *   the property name and the value is the additional information. The structure of the additional information depends on the delegate.
+	 *   Used to add model-specific information. For example, for analytics in OData, see sap.ui.mdc.odata.v4.TableDelegate.
+	 *
+	 * @private
+	 * @experimental
+	 * @ui5-restricted sap.fe
+	 * MDC_PUBLIC_CANDIDATE
+	 */
+
 	/*
 	 * Key-value map to define the characteristics of a property attribute, where the key is the name of the attribute.
 	 *
 	 * Metadata information:
 	 * - type
-	 *     Can be any type that is also allowed for a control property, plus "PropertyReference" for references to simple properties.
+	 * 	   Can be any type that is also allowed for a control property, plus "PropertyReference" for references to simple properties.
 	 *     Complex types can be specified with an object that describes sub-attributes.
 	 *     Examples: "string", "string[]", "sap.ui.mdc.MyEnum", "any", "PropertyReference",
 	 *               {
-	 *                   subAttribute: {type: "string", defaultValue: "myDefaultValue"}
+	 *                   subAttribute: {
+	 *  				     type: "string",
+	 * 					     default: {
+	 *                           value: "myDefaultValue"
+	 *                       }
+	 *                   }
 	 *                   ...
 	 *               }
 	 * - mandatory (optional, default=false, only for top-level attribute)
 	 *     Whether this attribute must be provided.
 	 * - allowedForComplexProperty (optional, default=false)
-	 *     Whether it is allowed to provide this attribute for a complex property.
+	 *	   Whether it is allowed to provide this attribute for a complex property.
 	 * - valueForComplexProperty (optional):
 	 *     For a complex property, this defines the value of an attribute that is not allowed for complex properties.
-	 * - defaultValue (optional)
-	 *     This can either be a value, or a reference to another attribute in the form "attribute:x", with x being the name of the other
-	 *     attribute. The default value of this attribute is then the value of the other attribute. This works only one level deep.
-	 *     Examples: "attribute:name", "attribute:attributeName.subAttributeName"
+	 * - default: { (optional, type: Object) - specifies the default value property of the attribute
+	 * 	   - value
+	 * 	   	   This can either be a value, or a reference to another attribute in the form "attribute:x", with x being the name of the other
+	 *     	   attribute. The default value of this attribute is then the value of the other attribute. This works only one level deep.
+	 *     	   Examples: "attribute:name", "attribute:attributeName.subAttributeName"
+	 *     - ignoreIfNull (default=false)
+	 *     	   Prevents setting the default value for this attribute if set to <code>true</code>.
+	 * 	       Defines the entire attribute as <code>null</code> if the attribute value itself is from type <code>null</code>.
+	 * 	}
 	 */
 	var mAttributeMetadata = { // TODO: "allowedForComplexProperty" propagation to children + reserved reference attribute, e.g. unit -> unitProperty
 		// Common
@@ -58,7 +99,9 @@ sap.ui.define([
 		},
 		visible: { // Whether the property is visible in the "Items" personalization.
 			type: "boolean",
-			defaultValue: true,
+			"default": {
+				value: true
+			},
 			allowedForComplexProperty: true
 		},
 		path: { // The technical path for a data source property.
@@ -84,12 +127,16 @@ sap.ui.define([
 		// TODO: What's the meaning? type = boolean? Is used only once in FilterBarBase: oProperty.maxConditions !== -1
 		maxConditions: {
 			type: "int",
-			defaultValue: -1,
+			"default": {
+				value: -1
+			},
 			valueForComplexProperty: null
 		},
 		caseSensitive: {
 			type: "boolean",
-			defaultValue: true
+			"default": {
+				value: true
+			}
 		},
 		group: { // Key of the group the property is inside. Used to visually group properties in personalization dialogs.
 			type: "string",
@@ -103,12 +150,16 @@ sap.ui.define([
 		// Table, Chart, P13N
 		filterable: { // Whether it is possible to filter by this property.
 			type: "boolean",
-			defaultValue: true,
+			"default": {
+				value: true
+			},
 			valueForComplexProperty: false
 		},
 		sortable: { // Whether it is possible to sort by this property.
 			type: "boolean",
-			defaultValue: true,
+			"default": {
+				value: true
+			},
 			valueForComplexProperty: false
 		},
 
@@ -136,7 +187,59 @@ sap.ui.define([
 			allowedForComplexProperty: true
 		},
 		visualSettings: { // This object contains all relevant properties for visual adjustments
-			type: "object"
+			type: {
+				widthCalculation: { // This object contains all properties and their default values for the column width calculation
+					type: {
+						minWidth: {
+							type: "int",
+							"default": {
+								value: 2
+							}
+						},
+						maxWidth: {
+							type: "int",
+							"default": {
+								value: 19
+							}
+						},
+						defaultWidth: {
+							type: "int",
+							"default": {
+								value: 8
+							}
+						},
+						gap: {
+							type: "float",
+							"default": {
+								value: 0
+							}
+						},
+						includeLabel: {
+							type: "boolean",
+							"default": {
+								value: true
+							}
+						},
+						verticalArrangement: {
+							type: "boolean",
+							"default": {
+								value: false
+							}
+						},
+						excludeProperties: {
+							type: "PropertyReference[]"
+						}
+					},
+					"default": {
+						value: {},
+						ignoreIfNull: true
+					}
+				}
+			},
+			"default": {
+				value: {}
+			},
+			allowedForComplexProperty: true
 		},
 
 		// Chart
@@ -150,11 +253,11 @@ sap.ui.define([
 		}
 
 		// Reserved attributes
-		// extension - Used to add model-specific information. For example, for analytics in OData, see sap.ui.mdc.odata.v4.TableDelegate.
+		// extension - Used to add model-specific information. For example, for analytics in OData, see sap/ui/mdc/odata/v4/TableDelegate.
 	};
 
 	/**
-	 * The methods listed in this map are added to every property info object.
+	 * The methods listed in this map are added to every <code>PropertyInfo</code> object.
 	 */
 	var mPropertyMethods = {
 		/**
@@ -177,7 +280,7 @@ sap.ui.define([
 			return this.propertyInfosProperties || [];
 		},
 		/**
-		 * Gets all sortable properties referenced by the property, including the property itself if it is non-complex.
+		 * Gets all sortable properties referenced by the property, including the property itself if it is not complex.
 		 *
 		 * @this PropertyInfo
 		 * @returns {object[]} The sortable properties
@@ -188,7 +291,7 @@ sap.ui.define([
 			});
 		},
 		/**
-		 * Gets all filterable properties referenced by the property, including the property itself if it is non-complex.
+		 * Gets all filterable properties referenced by the property, including the property itself if it is not complex.
 		 *
 		 * @this PropertyInfo
 		 * @returns {object[]} The filterable properties
@@ -199,7 +302,7 @@ sap.ui.define([
 			});
 		},
 		/**
-		 * Gets all groupable properties referenced by the property, including the property itself if it is non-complex.
+		 * Gets all groupable properties referenced by the property, including the property itself if it is not complex.
 		 *
 		 * @this PropertyInfo
 		 * @returns {object[]} The groupable properties
@@ -210,7 +313,7 @@ sap.ui.define([
 			});
 		},
 		/**
-		 * Gets all visible properties referenced by the property, including the property itself if it is non-complex.
+		 * Gets all visible properties referenced by the property, including the property itself if it is not complex.
 		 *
 		 * @this PropertyInfo
 		 * @returns {object[]} The visible properties
@@ -351,7 +454,7 @@ sap.ui.define([
 			}
 
 			if (vValue == null) {
-				setAttributeDefault(oPropertySection, mAttribute, sPath, sAttribute, aDependenciesForDefaults);
+				setAttributeDefault(oPropertySection, mAttribute, sPath, sAttribute, aDependenciesForDefaults, vValue);
 			}
 
 			if (typeof mAttribute.type === "object") {
@@ -384,21 +487,30 @@ sap.ui.define([
 		});
 	}
 
-	function setAttributeDefault(oPropertySection, mAttributeSection, sSection, sAttribute, aDependenciesForDefaults) {
-		if ("defaultValue" in mAttributeSection) {
-			if (typeof mAttributeSection.defaultValue === "string" && mAttributeSection.defaultValue.startsWith("attribute:")) {
+	function setAttributeDefault(oPropertySection, mAttributeSection, sSection, sAttribute, aDependenciesForDefaults, vValue) {
+		if ("default" in mAttributeSection) {
+			var oDefault = mAttributeSection.default;
+
+			// ignoreIfNull will applies only if a default value for the attribute has been specified in its metadata
+			if (vValue === null && oDefault.ignoreIfNull && oDefault.value !== undefined) {
+				return;
+			}
+
+			if (oDefault.value === undefined) {
+				oPropertySection[sAttribute] = getTypeDefault(mAttributeSection.type);
+			} else if (typeof oDefault.value === "string" && oDefault.value.startsWith("attribute:")) {
 				// Attributes that reference another attribute for the default value need to be processed in a second step.
 				// This is only supported 1 level deep.
 				aDependenciesForDefaults.push({
-					source: mAttributeSection.defaultValue.substring(mAttributeSection.defaultValue.indexOf(":") + 1),
+					source: oDefault.value.substring(oDefault.value.indexOf(":") + 1),
 					targetPath: sSection,
 					targetAttribute: sAttribute,
 					targetType: mAttributeSection.type
 				});
-			} else if (typeof mAttributeSection.defaultValue === "object" && mAttributeSection.defaultValue !== null) {
-				oPropertySection[sAttribute] = merge({}, mAttributeSection.defaultValue);
+			} else if (typeof oDefault.value === "object") {
+				oPropertySection[sAttribute] = merge({}, oDefault.value);
 			} else {
-				oPropertySection[sAttribute] = mAttributeSection.defaultValue;
+				oPropertySection[sAttribute] = oDefault.value;
 			}
 		} else {
 			oPropertySection[sAttribute] = getTypeDefault(mAttributeSection.type);
@@ -422,16 +534,33 @@ sap.ui.define([
 		}
 	}
 
+	function finalizeAttributeMetadata(mAttributeSection, sPath, bParentAllowedForComplexProperty) {
+		for (var sAttribute in mAttributeSection) {
+			var mAttribute = mAttributeSection[sAttribute];
+			var sAttributePath = sPath == null ? sAttribute : sPath + "." + sAttribute;
+
+			if (sPath === "extension") {
+				finalizeAttributeMetadata(mAttribute.type, sAttributePath);
+				continue;
+			}
+
+			if (bParentAllowedForComplexProperty && mAttribute.allowedForComplexProperty !== false) {
+				mAttribute.allowedForComplexProperty = true;
+			}
+
+			if (typeof mAttribute.type === "object") {
+				finalizeAttributeMetadata(mAttribute.type, sAttributePath, mAttribute.allowedForComplexProperty);
+			}
+		}
+	}
+
 	function mergeExtensionsIntoProperties(aProperties, mExtensions) {
 		var iMatchingExtensions = 0;
-
 		mExtensions = mExtensions || {};
-
 		for (var i = 0; i < aProperties.length; i++) {
 			if ("extension" in aProperties[i]) {
 				throwInvalidPropertyError("Property contains invalid attribute 'extension'.", aProperties[i]);
 			}
-
 			if (aProperties[i].name in mExtensions) {
 				aProperties[i].extension = mExtensions[aProperties[i].name];
 				iMatchingExtensions++;
@@ -439,39 +568,94 @@ sap.ui.define([
 				aProperties[i].extension = {};
 			}
 		}
-
 		if (iMatchingExtensions !== Object.keys(mExtensions).length) {
 			throw new Error("At least one property extension does not point to an existing property.");
 		}
 	}
 
+	function _createPrivate(oInstance, oParent, aProperties, mExtensions, aAllowedAttributes, mExtensionAttributeMetadata) {
+		var mPrivate = {};
+		var mInstanceAttributeMetadata = aCommonAttributes.concat(aAllowedAttributes || []).reduce(function(mMetadata, sAttribute) {
+			if (sAttribute in mAttributeMetadata) {
+				mMetadata[sAttribute] = mAttributeMetadata[sAttribute];
+			}
+			return mMetadata;
+		}, Object.assign({}, oInstance._mExperimentalAdditionalAttributes));
+		if (mExtensionAttributeMetadata) {
+			mPrivate.mAttributeMetadata = Object.assign({
+				extension: {
+					type: mExtensionAttributeMetadata,
+					mandatory: true,
+					allowedForComplexProperty: true
+				}
+			}, mInstanceAttributeMetadata);
+			mPrivate.aMandatoryExtensionAttributes = Object.keys(mExtensionAttributeMetadata).filter(function(sAttribute) {
+				return mExtensionAttributeMetadata[sAttribute].mandatory;
+			});
+		} else {
+			mPrivate.mAttributeMetadata = mInstanceAttributeMetadata;
+			mPrivate.aMandatoryExtensionAttributes = [];
+		}
+
+		finalizeAttributeMetadata(mPrivate.mAttributeMetadata);
+
+		mPrivate.aMandatoryAttributes = Object.keys(mPrivate.mAttributeMetadata).filter(function(sAttribute) {
+			return mPrivate.mAttributeMetadata[sAttribute].mandatory;
+		});
+
+		var aClonedProperties = merge([], aProperties);
+		var mProperties = createPropertyMap(aClonedProperties);
+		if (mExtensionAttributeMetadata) {
+			mergeExtensionsIntoProperties(aClonedProperties, merge({}, mExtensions));
+		}
+
+		var oPreviousPrivate = _private.get(oInstance);
+		var aPreviousProperties = oPreviousPrivate && oPreviousPrivate.aRawProperties;
+		_private.set(oInstance, mPrivate);
+		oInstance.validateProperties(aClonedProperties, aPreviousProperties);
+
+
+		mPrivate.oParent = oParent || null;
+		mPrivate.aRawProperties = aProperties;
+		mPrivate.aProperties = aClonedProperties;
+		mPrivate.mProperties = mProperties;
+		mPrivate._ = {
+			mExtensions: mExtensions,
+			aAllowedAttributes: aAllowedAttributes,
+			mExtensionAttributeMetadata: mExtensionAttributeMetadata
+		};
+
+		enrichProperties(oInstance, aClonedProperties);
+		prepareProperties(oInstance, aClonedProperties);
+	}
+
 	/**
 	 * Constructor for a new helper for the given properties.
 	 *
 	 * @param {object[]} aProperties
 	 *     The properties to process in this helper
-	 * @param {object<string, object>} [mExtensions]
+	 * @param {Object<string, object>} [mExtensions]
 	 *     Key-value map, where the key is the name of the property and the value is the extension containing mode-specific information.
 	 *     The extension of a property is stored in a reserved <code>extension</code> attribute and its attributes must be specified with
 	 *     <code>mExtensionAttributeMetadata</code>.
 	 * @param {sap.ui.base.ManagedObject} [oParent]
 	 *     A reference to an instance that will act as the parent of this helper
      * @param {string[]} [aAllowedAttributes]
-	 *     List of attributes the property infos may contain.
+	 *     List of attributes that the <code>PropertyInfo</code> may contain.
 	 *     The following common attributes are always allowed:
 	 *     name, label, visible, path, typeConfig, maxConditions, group, groupLabel
 	 * @param {object} [mExtensionAttributeMetadata]
 	 *     The attribute metadata for the model-specific property extension
 	 *
 	 * @class
-	 * Property helpers give this library a consistent and standardized view on properties and their attributes.
+	 * Property helpers in this SAPUI5 library provide a consistent and standardized structure of properties and their attributes.
 	 * Validates the given properties, sets defaults, and provides utilities to work with these properties.
 	 * The utilities can only be used for properties that are known to the helper. Known properties are all those that are passed to the constructor.
 	 *
 	 * @extends sap.ui.base.Object
 	 *
 	 * @author SAP SE
-	 * @version 1.97.1
+	 * @version 1.100.0
 	 *
 	 * @private
 	 * @experimental
@@ -494,7 +678,6 @@ sap.ui.define([
 					throw new Error("Property extensions must be a plain object.");
 				}
 			}
-
 			if (oParent && !BaseObject.isA(oParent, "sap.ui.base.ManagedObject")) {
 				throw new Error("The type of the parent is invalid.");
 			}
@@ -507,50 +690,7 @@ sap.ui.define([
 				}.bind(this));
 			}
 
-			var mPrivate = {};
-			var mInstanceAttributeMetadata = aCommonAttributes.concat(aAllowedAttributes || []).reduce(function(mMetadata, sAttribute) {
-				if (sAttribute in mAttributeMetadata) {
-					mMetadata[sAttribute] = mAttributeMetadata[sAttribute];
-				}
-				return mMetadata;
-			}, Object.assign({}, this._mExperimentalAdditionalAttributes));
-
-			if (mExtensionAttributeMetadata) {
-				mPrivate.mAttributeMetadata = Object.assign({
-					extension: {
-						type: mExtensionAttributeMetadata,
-						mandatory: true,
-						allowedForComplexProperty: true
-					}
-				}, mInstanceAttributeMetadata);
-				mPrivate.aMandatoryExtensionAttributes = Object.keys(mExtensionAttributeMetadata).filter(function(sAttribute) {
-					return mExtensionAttributeMetadata[sAttribute].mandatory;
-				});
-			} else {
-				mPrivate.mAttributeMetadata = mInstanceAttributeMetadata;
-				mPrivate.aMandatoryExtensionAttributes = [];
-			}
-
-			mPrivate.aMandatoryAttributes = Object.keys(mPrivate.mAttributeMetadata).filter(function(sAttribute) {
-				return mPrivate.mAttributeMetadata[sAttribute].mandatory;
-			});
-
-			var aClonedProperties = merge([], aProperties);
-			var mProperties = createPropertyMap(aClonedProperties);
-
-			if (mExtensionAttributeMetadata) {
-				mergeExtensionsIntoProperties(aClonedProperties, merge({}, mExtensions));
-			}
-
-			_private.set(this, mPrivate);
-			this.validateProperties(aClonedProperties);
-
-			mPrivate.oParent = oParent || null;
-			mPrivate.aProperties = aClonedProperties;
-			mPrivate.mProperties = mProperties;
-
-			enrichProperties(this, aClonedProperties);
-			prepareProperties(this, aClonedProperties);
+			_createPrivate(this, oParent, aProperties, mExtensions, aAllowedAttributes, mExtensionAttributeMetadata);
 		}
 	});
 
@@ -562,14 +702,15 @@ sap.ui.define([
 	 * any method that tries to access them might not work as expected.
 	 *
 	 * @param {object[]} aProperties The properties to validate
+	 * @param {object[]} [aPreviousProperties] The previous set of properties to validate against
 	 * @throws {Error} If the properties are invalid
 	 * @protected
 	 */
-	PropertyHelper.prototype.validateProperties = function(aProperties) {
+	PropertyHelper.prototype.validateProperties = function(aProperties, aPreviousProperties) {
 		var oUniquePropertiesSet = new Set();
 
 		for (var i = 0; i < aProperties.length; i++) {
-			this.validateProperty(aProperties[i], aProperties);
+			this.validateProperty(aProperties[i], aProperties, aPreviousProperties);
 			oUniquePropertiesSet.add(aProperties[i].name);
 		}
 
@@ -582,15 +723,16 @@ sap.ui.define([
 	 * Validates a property. The entire array of properties needs to be provided for validation of a complex property.
 	 *
 	 * <b>Note for classes that override this method:</b>
-	 * No other method of the helper may be called from here. The properties are not yet stored in the helper, and therefore
+	 * No other method of the helper must be called from here. The properties are not yet stored in the helper, and therefore
 	 * any method that tries to access them might not work as expected.
 	 *
 	 * @param {object} oProperty The property to validate
 	 * @param {object[]} aProperties The entire array properties
+	 * @param {object[]} [aPreviousProperties] The previous set of properties to validate against
 	 * @throws {Error} If the property is invalid
 	 * @protected
 	 */
-	PropertyHelper.prototype.validateProperty = function(oProperty, aProperties) {
+	PropertyHelper.prototype.validateProperty = function(oProperty, aProperties, aPreviousProperties) {
 		if (!isPlainObject(oProperty)) {
 			throwInvalidPropertyError("Property info must be a plain object.", oProperty);
 		}
@@ -610,7 +752,6 @@ sap.ui.define([
 				throwInvalidPropertyError("Property does not contain mandatory attribute '" + sMandatoryAttribute + "'.", oProperty);
 			}
 		});
-
 		_private.get(this).aMandatoryExtensionAttributes.forEach(function(sMandatoryAttribute) {
 			if (!(sMandatoryAttribute in oProperty.extension)) {
 				reportInvalidProperty("Property does not contain mandatory attribute 'extension." + sMandatoryAttribute + "'.", oProperty);
@@ -718,6 +859,21 @@ sap.ui.define([
 		return oPrivate ? oPrivate.oParent : null;
 	};
 
+
+	/**
+	 * Sets all properties known to this helper.
+  	 *
+	 * @param {object[]} aProperties The properties to process in this helper
+	 * @returns {sap.ui.mdc.util.PropertyHelper} returns propertyhelper instance
+	 * @public
+	 * @since 1.100.0
+	 */
+	 PropertyHelper.prototype.setProperties = function (aProperties) {
+		var mPrivate = _private.get(this);
+		_createPrivate(this, mPrivate.oParent, aProperties, mPrivate._.mExtensions, mPrivate._.aAllowedAttributes, mPrivate._.mExtensionAttributeMetadata);
+		return this;
+	};
+
 	/**
 	 * Gets all properties known to this helper.
 	 *
@@ -763,9 +919,9 @@ sap.ui.define([
 	};
 
 	/**
-	 * Checks whether a property is a complex property. Works with any property info, even if unknown to the property helper.
+	 * Checks whether a property is a complex property. Works with any <code>PropertyInfo</code>, even if unknown to the property helper.
 	 *
-	 * @param {object} oProperty A property info object
+	 * @param {object} oProperty A <code>PropertyInfo</code> object
 	 * @returns {boolean} Whether the property is complex
 	 * @protected
 	 * @static

package/src/sap/ui/mdc/util/TypeUtil.js

@@ -6,8 +6,9 @@
 
 sap.ui.define([
 		'sap/ui/mdc/enum/BaseType',
-		'sap/base/util/ObjectPath'
-	], function(BaseType, ObjectPath) {
+		'sap/base/util/ObjectPath',
+		'sap/ui/model/SimpleType'
+	], function(BaseType, ObjectPath, SimpleType) {
 	"use strict";
 
 	/**
@@ -59,7 +60,7 @@ sap.ui.define([
 		 *
 		 * As default <code>string</code> is returned.
 		 *
-		 * @param {string} vType Given type string or sap.ui.model.SimpleType
+		 * @param {string} sType Given type string or sap.ui.model.SimpleType
 		 * @param {object} oFormatOptions Used <code>FormatOptions</code>
 		 * @param {object} oConstraints Used <code>Constraints</code>
 		 * @returns {sap.ui.mdc.enum.BaseType} output <code>Date</code>, <code>DateTime</code> or <code>Time</code>...
@@ -154,7 +155,7 @@ sap.ui.define([
 
 			var oType, sDataType;
 
-			if (vType instanceof sap.ui.model.SimpleType) {
+			if (vType instanceof SimpleType) {
 				oType = vType;
 			} else {
 				var sDataTypeClass = this.getDataTypeClassName(vType);
@@ -172,4 +173,4 @@ sap.ui.define([
 
 	return TypeUtil;
 
-}, /* bExport= */ true);
+});

package/src/sap/ui/mdc/valuehelp/Dialog.js

@@ -37,12 +37,13 @@ sap.ui.define([
 	 * @param {object} [mSettings] Initial settings for the new control
 	 * @class Container for the <code>sap.ui.mdc.ValueHelp</code> element showing a dialog.
 	 * @extends sap.ui.mdc.valuehelp.base.Container
-	 * @version 1.97.1
+	 * @version 1.100.0
 	 * @constructor
 	 * @abstract
 	 * @private
 	 * @ui5-restricted sap.ui.mdc
 	 * @since 1.95.0
+	 * @experimental As of version 1.95
 	 * @alias sap.ui.mdc.valuehelp.Dialog
 	 * @ui5-metamodel This control/element also will be described in the UI5 (legacy) designtime metamodel
 	 */
@@ -210,7 +211,7 @@ sap.ui.define([
 					oDialog.addStyleClass("sapMdcValueHelpTitle");
 					oDialog.addStyleClass("sapMdcValueHelpTitleShadow");
 
-					var oVBox = new VBox({ fitContainer: true});
+					var oVBox = new VBox(this.getId() + "-Content", { fitContainer: true});
 					oVBox.addStyleClass("sapMdcValueHelpPanel");
 					oDialog.addContent(oVBox);
 
@@ -350,7 +351,7 @@ sap.ui.define([
 				var BackgroundDesign = MLibrary.BackgroundDesign;
 				var ButtonType = MLibrary.ButtonType;
 
-				this.oTokenizerPanel = new Panel( {
+				this.oTokenizerPanel = new Panel(this.getId() + "-TokenPanel", {
 					backgroundDesign: BackgroundDesign.Transparent,
 					expanded: true,
 					visible: { parts: ['$valueHelp>/_config/maxConditions', '$help>/content'], formatter:
@@ -385,20 +386,22 @@ sap.ui.define([
 				});
 				this.oTokenizerPanel.addStyleClass("sapMdcTokenizerPanel");
 
-				var oHBox = new HBox({fitContainer: true, width: "100%"});
+				var oHBox = new HBox(this.getId() + "-TokenBox", {fitContainer: true, width: "100%"});
 
 				var oFilter = new Filter({path:'isEmpty', operator:'NE', value1:true});
 
 				var oValueHelpModel = this.getModel("$valueHelp");
 				var oConfig = oValueHelpModel ? oValueHelpModel.getProperty("/_config") : {};
+				var oParent = this.getParent();
 				var oFormatOptions = { // TODO: is more needed?
 							maxConditions: -1, // as for tokens there should not be a limit on type side
 							valueType: oConfig.dataType,
 							operators: oConfig.operators,
-							display: oConfig.display
+							display: oConfig.display,
+							fieldHelpID: oParent && oParent.getId() // needed to get description for Token (if not provided)
 						};
-				var oTokenTemplate = new Token({text: {path: '$valueHelp>', type: new ConditionType(oFormatOptions)}});
-				this.oTokenizer = new Tokenizer({
+				var oTokenTemplate = new Token(this.getId() + "-Token", {text: {path: '$valueHelp>', type: new ConditionType(oFormatOptions)}});
+				this.oTokenizer = new Tokenizer(this.getId() + "-Tokenizer", {
 					width: "100%",
 					tokenDelete: function(oEvent) {
 						if (oEvent.getParameter("tokens")) {
@@ -422,7 +425,7 @@ sap.ui.define([
 				this.oTokenizer.addAriaDescribedBy( this.oTokenizer.getTokensInfoId());
 				this.oTokenizer.addStyleClass("sapMdcTokenizer");
 
-				this.oRemoveAllBtn = new Button({
+				this.oRemoveAllBtn = new Button(this.getId() + "-TokenRemoveAll", {
 					press: function(oEvent) {
 						this.fireSelect({type: SelectType.Set, conditions: []});