@openui5/sap.ui.mdc 1.97.1 → 1.100.0

package/src/sap/ui/mdc/designtime/table/Table.designtime.js

@@ -4,18 +4,16 @@
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
  */
 sap.ui.define([
-	"sap/ui/mdc/p13n/Engine"
-], function (Engine) {
+	"sap/ui/mdc/p13n/Engine",
+	"sap/ui/mdc/Table",
+	"../Util"
+], function (Engine, Table, Util) {
 	"use strict";
 
-	return {
+	// initial structure of designTime object
+	var oDesignTime = {
 		name: "{name}",
 		description: "{description}",
-		aggregations: {
-			_content: {
-				ignore: false
-			}
-		},
 		actions: {
 			settings: function () {
 				//RTA expects the settings to be returned as function
@@ -25,7 +23,36 @@ sap.ui.define([
 					}
 				};
 			}
+		},
+		properties: {},
+		aggregations: {
+			_content: {
+				propagateMetadata: function(oElement) {
+					if (oElement.isA("sap.ui.mdc.ActionToolbar")) {
+						return {
+							actions: {
+								settings: {}
+							}
+						};
+					}
+
+					return {
+						actions: "not-adaptable" // other controls within the conten aggregation will not be adaptable for RTA and Visual Editor
+					};
+				}
+			}
 		}
 	};
+	// array containing all allowed control properties. Update the aAllowedProperties to enable a property for DTA
+	var aAllowedProperties = ["width", "height", "headerLevel",
+			"header", "headerVisible", "showRowCount", "threshold",
+			"noDataText", "enableExport", "busyIndicatorDelay","enableColumnResize",
+			"showPasteButton", "multiSelectMode"],
+		// array containing all allowed control aggregations. Update the aAllowedAggregations to enable an aggregation for DTA
+		aAllowedAggregations = [
+			"_content"
+		];
+
+	return Util.getDesignTime(Table, aAllowedProperties, aAllowedAggregations, oDesignTime);
 
 });

package/src/sap/ui/mdc/field/BoolFieldHelp.js

@@ -35,7 +35,7 @@ sap.ui.define([
 	 * @param {object} [mSettings] Initial settings for the new control
 	 * @class A field help used in the <code>FieldHelp</code> association in <code>FieldBase</code> controls that shows a list for Boolean values.
 	 * @extends sap.ui.mdc.field.FieldHelpBase
-	 * @version 1.97.1
+	 * @version 1.100.0
 	 * @constructor
 	 * @private
 	 * @ui5-restricted sap.ui.mdc.field.FieldBase

package/src/sap/ui/mdc/field/ConditionFieldHelp.js

@@ -35,7 +35,7 @@ sap.ui.define([
 	 * @param {object} [mSettings] Initial settings for the new control
 	 * @class A field help used in the <code>FieldHelp</code> association in <code>FieldBase</code> controls to show a popover of conditions.
 	 * @extends sap.ui.mdc.field.FieldHelpBase
-	 * @version 1.97.1
+	 * @version 1.100.0
 	 * @constructor
 	 * @private
 	 * @ui5-restricted sap.ui.mdc.field.FieldBase, sap.fe

package/src/sap/ui/mdc/field/ConditionType.js

@@ -18,6 +18,7 @@ sap.ui.define([
 	'sap/ui/mdc/enum/BaseType',
 	'sap/ui/mdc/enum/ConditionValidated',
 	'sap/base/util/merge',
+	'sap/base/strings/whitespaceReplacer',
 	'sap/ui/base/SyncPromise'
 ],
 	function(
@@ -33,6 +34,7 @@ sap.ui.define([
 		BaseType,
 		ConditionValidated,
 		merge,
+		whitespaceReplacer,
 		SyncPromise
 		) {
 	"use strict";
@@ -46,7 +48,7 @@ sap.ui.define([
 	 * @extends sap.ui.model.SimpleType
 	 *
 	 * @author SAP SE
-	 * @version 1.97.1
+	 * @version 1.100.0
 	 *
 	 * @since 1.62.0
 	 * @private
@@ -72,6 +74,7 @@ sap.ui.define([
 	 * @param {sap.ui.mdc.condition.ConditionModel} [oFormatOptions.conditionModel] <code>ConditionModel</code>, if bound to one
 	 * @param {string} [oFormatOptions.conditionModelName] Name of the <code>ConditionModel</code>, if bound to one
 	 * @param {string} [oFormatOptions.defaultOperatorName] Name of the default <code>Operator</code>
+	 * @param {boolean} [oFormatOptions.convertWhitespaces] If set, whitespaces will be replaced by special characters to display whitespaces in HTML
 	 * @param {object} [oConstraints] Value constraints
 	 * @alias sap.ui.mdc.field.ConditionType
 	 */
@@ -204,7 +207,15 @@ sap.ui.define([
 			throw new FormatException("No valid condition provided, Operator wrong.");
 		}
 
-		return oOperator.format(oCondition, oType, sDisplay, bHideOperator);
+		var sResult = oOperator.format(oCondition, oType, sDisplay, bHideOperator);
+		var bConvertWhitespaces = this.oFormatOptions.convertWhitespaces;
+
+		if (bConvertWhitespaces && (_getBaseType.call(this, oType) === BaseType.String || sDisplay !== FieldDisplay.Value)) {
+			// convert only string types to prevent unwanted side effects
+			sResult = whitespaceReplacer(sResult);
+		}
+
+		return sResult;
 
 	}
 
@@ -527,8 +538,8 @@ sap.ui.define([
 				oType.validateValue(vCheckParsedValue);
 			}
 		} catch (oException) {
-			if (oException && !(oException instanceof ParseException) && !(oException instanceof ValidateException)) {// FormatException could also occur
-				// unknown error -> just raise it
+			if (oException && !(bCheckDescription && (oException instanceof ParseException || oException instanceof ValidateException))) {
+				// unknown error or no search for description -> just raise it
 				throw oException;
 			}
 			bCheckKey = false; // cannot be a valid key
@@ -635,14 +646,14 @@ sap.ui.define([
 			throw new ValidateException(this._oResourceBundle.getText("field.VALUE_NOT_VALID"));
 		}
 
-		var oOperator = FilterOperatorUtil.getOperator(oCondition.operator, aOperators);
+		var oOperator = FilterOperatorUtil.getOperator(oCondition.operator);
 
 		if (bIsUnit) {
 			// only use unit in condition
 			oOperator = FilterOperatorUtil.getEQOperator(); // as only EQ is allowed for unit
 		}
 
-		if (!oOperator) {
+		if (!oOperator || aOperators.indexOf(oOperator.name) === -1) {
 			throw new ValidateException("No valid condition provided, Operator wrong.");
 		}
 

package/src/sap/ui/mdc/field/ConditionsType.js

@@ -36,7 +36,7 @@ sap.ui.define([
 	 * @extends sap.ui.model.SimpleType
 	 *
 	 * @author SAP SE
-	 * @version 1.97.1
+	 * @version 1.100.0
 	 *
 	 * @since 1.62.0
 	 * @private
@@ -62,6 +62,7 @@ sap.ui.define([
 	 * @param {sap.ui.mdc.condition.ConditionModel} [oFormatOptions.conditionModel] <code>ConditionModel</code>, if bound to one
 	 * @param {string} [oFormatOptions.conditionModelName] Name of the <code>ConditionModel</code>, if bound to one
 	 * @param {string} [oFormatOptions.defaultOperatorName] Name of the default <code>Operator</code>
+	 * @param {boolean} [oFormatOptions.convertWhitespaces] If set, whitespaces will be replaced by special characters to display whitespaces in HTML
 	 * @param {object} [oConstraints] Value constraints
 	 * @alias sap.ui.mdc.field.ConditionsType
 	 */

package/src/sap/ui/mdc/field/CustomFieldHelp.js

@@ -16,7 +16,7 @@ sap.ui.define([
 	 * @param {object} [mSettings] Initial settings for the new control
 	 * @class A field help used in the <code>FieldHelp</code> association in <code>FieldBase</code> controls that allows you to add custom content.
 	 * @extends sap.ui.mdc.field.FieldHelpBase
-	 * @version 1.97.1
+	 * @version 1.100.0
 	 * @constructor
 	 * @private
 	 * @ui5-restricted sap.fe

package/src/sap/ui/mdc/field/CustomFieldInfo.js

@@ -16,7 +16,7 @@ sap.ui.define([
 	 * @param {object} [mSettings] Initial settings for the new control
 	 * @class A field help used in the <code>FieldInfo</code> aggregation in <code>FieldBase</code> controls that allows you to add custom content.
 	 * @extends sap.ui.mdc.field.FieldInfoBase
-	 * @version 1.97.1
+	 * @version 1.100.0
 	 * @constructor
 	 * @private
 	 * @ui5-restricted sap.fe

package/src/sap/ui/mdc/field/DefineConditionPanel.js

@@ -29,10 +29,11 @@ sap.ui.define([
 	'sap/ui/layout/Grid',
 	'sap/ui/layout/GridData',
 	'sap/m/library',
-	'sap/m/ScrollContainer',
 	'sap/m/Button',
 	'sap/m/Panel',
-	'sap/base/Log'
+	'sap/base/Log',
+	'sap/ui/core/InvisibleMessage',
+	'sap/ui/thirdparty/jquery'
 ], function(
 		Control,
 		ManagedObjectObserver,
@@ -59,10 +60,11 @@ sap.ui.define([
 		Grid,
 		GridData,
 		mLibrary,
-		ScrollContainer,
 		Button,
 		Panel,
-		Log
+		Log,
+		InvisibleMessage,
+		jQuery
 		) {
 	"use strict";
 
@@ -74,6 +76,7 @@ sap.ui.define([
 
 	var ButtonType = mLibrary.ButtonType;
 	var ValueState = coreLibrary.ValueState;
+	var InvisibleMessageMode = coreLibrary.InvisibleMessageMode;
 
 	/**
 	 * Constructor for a new <code>DefineConditionPanel</code>.
@@ -88,7 +91,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.97.1
+	 * @version 1.100.0
 	 *
 	 * @constructor
 	 * @alias sap.ui.mdc.field.DefineConditionPanel
@@ -194,6 +197,8 @@ sap.ui.define([
 
 			Control.prototype.init.apply(this, arguments);
 
+			this.oInvisibleMessage = InvisibleMessage.getInstance();
+
 			this._oManagedObjectModel = new ManagedObjectModel(this);
 
 			this._oObserver = new ManagedObjectObserver(_observeChanges.bind(this));
@@ -259,6 +264,8 @@ sap.ui.define([
 				this._bFocusLastRemoveBtn = true; // as remove-Button will disappear and focus should set on the last row remove button
 			}
 
+			this.oInvisibleMessage.announce(oMessageBundle.getText("valuehelp.DEFINECONDITIONS_REMOVECONDITION_ANNOUNCE"), InvisibleMessageMode.Polite);
+
 			// try to reset valueState and value of value Fields inside the removed row
 			var oGrid = this.byId("conditions");
 			var aGridContent = oGrid.getContent();
@@ -275,8 +282,15 @@ sap.ui.define([
 				}
 			}
 
+			if (aConditions.length === 1 && iIndex === 0) {
+				// the only one existing condition is removed. -> add dummy condition to have it in update in one step
+				this.addDummyCondition(1); // TODO: without setProperty to update condition at once?
+				aConditions = this.getConditions();
+			}
+
 			aConditions.splice(iIndex, 1);
 			this.setProperty("conditions", aConditions, true); // do not invalidate whole DefineConditionPanel
+			_checkInvalidInput.call(this, undefined); // check if invalid condition was removed
 
 			this.fireConditionProcessed();
 		},
@@ -301,8 +315,10 @@ sap.ui.define([
 			var sOperator = oOperator.name;
 			var oCondition = Condition.createCondition(sOperator, oOperator.valueDefaults ? oOperator.valueDefaults : [], undefined, undefined, ConditionValidated.NotValidated);
 
-			// mark the condition as initial and not modified by the user
-			oCondition.isInitial = true;
+			if (oOperator.valueTypes[0] && oOperator.valueTypes[0] !== Operator.ValueType.Static) {
+				// mark the condition as initial and not modified by the user
+				oCondition.isInitial = true;
+			}
 
 			FilterOperatorUtil.updateConditionValues(oCondition);
 			FilterOperatorUtil.checkConditionsEmpty(oCondition, aOperators);
@@ -313,6 +329,11 @@ sap.ui.define([
 				aConditions.push(oCondition);
 			}
 			this.setProperty("conditions", aConditions, true); // do not invalidate whole DefineConditionPanel
+
+			if (!oCondition.isInitial) {
+				// static condition added, it is ready to use -> fire event
+				this.fireConditionProcessed();
+			}
 		},
 
 		updateDefineConditions: function() {
@@ -350,6 +371,21 @@ sap.ui.define([
 
 		onSelectChange: function(oEvent) {
 			var oField = oEvent.getSource();
+			var oCondition = oField.getBindingContext("$this").getObject();
+			var aConditions = this.getConditions();
+			var iIndex = FilterOperatorUtil.indexOfCondition(oCondition, aConditions);
+			if (iIndex >= 0) {
+				oCondition = aConditions[iIndex]; // to get right instance
+			}
+
+			if (!oEvent.getParameter("valid")) { // if Operator in error state -> don't update values
+				oCondition.invalid = true;
+				this.setProperty("conditions", aConditions, true); // do not invalidate whole DefineConditionPanel
+				oField._sOldKey = oField.getValue();
+				_checkInvalidInput.call(this, true); // set imediately, not only if row left
+				return;
+			}
+
 			var sKey = oField.getValue();
 			var sOldKey = oField._sOldKey;
 			var oOperator = FilterOperatorUtil.getOperator(sKey); // operator must exist as List is created from valid operators
@@ -357,16 +393,11 @@ sap.ui.define([
 
 			if (oOperator && oOperatorOld) {
 				var bUpdate = false;
-				var oCondition = oField.getBindingContext("$this").getObject();
-				var aConditions = this.getConditions();
-				var iIndex = FilterOperatorUtil.indexOfCondition(oCondition, aConditions);
 
 				if (!deepEqual(oOperator.valueTypes[0], oOperatorOld.valueTypes[0]) && oOperator.valueTypes[0] !== Operator.ValueType.Static ) {
 					// type changed -> remove entered value (only if changed by user in Select)
 					// As Static text updated on condition change, don't delete it here.
 					if (iIndex >= 0) {
-						oCondition = aConditions[iIndex]; // to get right instance
-
 						oCondition.values.forEach(function(value, index) {
 							if (value !== null) {
 								if ((oOperator.valueTypes[index] === Operator.ValueType.Self && oOperatorOld.valueTypes[index] === Operator.ValueType.SelfNoParse) ||
@@ -391,8 +422,6 @@ sap.ui.define([
 
 				if (iIndex >= 0 && oOperator.valueDefaults) {
 					// sets the default values for the operator back to default, if the condition is inital or the value is null
-					oCondition = aConditions[iIndex];
-
 					oCondition.values.forEach(function(value, index) {
 						if ((oCondition.isInitial && value !== oOperator.valueDefaults[index]) ||  (value === null)) {
 							// set the default value and mark the condition as initial
@@ -407,7 +436,6 @@ sap.ui.define([
 				if (!oOperator.valueTypes[1] && oOperatorOld.valueTypes[1]) {
 					// switch from BT to EQ -> remove second value even if filled
 					if (iIndex >= 0) {
-						oCondition = aConditions[iIndex]; // to get right instance
 						if (oCondition.values.length > 1 && oCondition.values[1]) {
 							oCondition.values = oCondition.values.slice(0, 1);
 							bUpdate = true;
@@ -415,9 +443,14 @@ sap.ui.define([
 					}
 				}
 
+				if (oCondition.invalid) {
+					delete oCondition.invalid;
+					bUpdate = true;
+				}
 				if (bUpdate) {
 					FilterOperatorUtil.checkConditionsEmpty(oCondition, _getOperators.call(this));
 					this.setProperty("conditions", aConditions, true); // do not invalidate whole DefineConditionPanel
+					_checkInvalidInput.call(this, false); // set imediately, not only if row left
 				}
 			}
 
@@ -674,7 +707,8 @@ sap.ui.define([
 			oControl = new Field(sId, {
 				delegate: _getDelegate.call(this),
 				value: { path: "$this>", type: oNullableType, mode: 'TwoWay', targetType: 'raw' },
-				editMode: {path: "$condition>operator", formatter: _getEditModeFromOperator},
+				editMode: {parts: [{path: "$condition>operator"}, {path: "$condition>invalid"}], formatter: _getEditModeFromOperator},
+				multipleLines: false,
 				width: "100%"
 			});
 		}
@@ -788,7 +822,7 @@ sap.ui.define([
 			// default operator not valid -> cannot use -> use first include-operator which requires some values
 			for (var i = 0; i < aOperators.length; i++) {
 				oOperator = FilterOperatorUtil.getOperator(aOperators[i]);
-				if (oOperator.exclude || !oOperator.hasRequiredValues()) {
+				if (!oOperator || oOperator.exclude || !oOperator.hasRequiredValues()) {
 					oOperator = undefined;
 				} else {
 					break;
@@ -955,7 +989,7 @@ sap.ui.define([
 			if (oOperator && oOperator.valueTypes[0] === Operator.ValueType.Static && (oCondition.values.length === 0 || bTypeChange)) {
 				// if type changed the text needs to be new formatted (setting of type and conditions might be async.)
 				if (oOperator.getStaticText) {
-					var sText = oOperator.getStaticText(oDataType);
+					var sText = oOperator.getStaticText(oDataType, _getBaseType.call(this, oDataType));
 					if (oCondition.values.length > 0) {
 						oCondition.values[0] = sText;
 					} else {
@@ -1000,6 +1034,11 @@ sap.ui.define([
 		oPanel.addContent(oInvisibleOperatorText);
 		oPanel.addContent(oGrid);
 
+		this._oInvisibleAddOperatorButtonText = new InvisibleText({
+			text: oMessageBundle.getText("valuehelp.DEFINECONDITIONS_ADDCONDITION_DESCRIPTION")
+		});
+		oPanel.addContent(this._oInvisibleAddOperatorButtonText);
+
 		var oAddBtn = new Button(this.getId() + "--addBtn", {
 			press: this.addCondition.bind(this),
 			type: ButtonType.Default,
@@ -1011,8 +1050,9 @@ sap.ui.define([
 				visibleS: {path: "$this>/conditions", formatter: _getAddButtonVisible.bind(this)},
 				visibleM: {path: "$this>/conditions", formatter: _getAddButtonVisible.bind(this)},
 				visibleL: {path: "$this>/conditions", formatter: _getAddButtonVisible.bind(this)},
-				visibleXL: {path: "$this>/conditions", formatter: _getAddButtonVisible.bind(this)}})}
-		);
+				visibleXL: {path: "$this>/conditions", formatter: _getAddButtonVisible.bind(this)}}),
+			ariaDescribedBy: this._oInvisibleAddOperatorButtonText
+		});
 
 		oGrid.addContent(oAddBtn);
 
@@ -1136,7 +1176,9 @@ sap.ui.define([
 		var oOperatorField = new Field(sIdPrefix + "-operator", {
 			value: {path: "$this>operator", type: this._oOperatorFieldType},
 			width: "100%",
-			display: "Description",
+			display: FieldDisplay.Description,
+			editMode: EditMode.Editable,
+			multipleLines: false,
 			fieldHelp: this.getId() + "--rowSelect-help",
 			change: this.onSelectChange.bind(this),
 			ariaLabelledBy: this.getId() + "--ivtOperator"
@@ -1210,10 +1252,12 @@ sap.ui.define([
 
 	}
 
-	function _getEditModeFromOperator(sOperator) {
+	function _getEditModeFromOperator(sOperator, bInvalid) {
 
 		if (!sOperator) {
 			return EditMode.Display;
+		} else if (bInvalid) {
+			return EditMode.ReadOnly;
 		}
 
 		var oOperator = FilterOperatorUtil.getOperator(sOperator);
@@ -1231,7 +1275,7 @@ sap.ui.define([
 
 		var oOperator = sOperator && FilterOperatorUtil.getOperator(sOperator);
 
-		if (!oOperator || !oOperator.valueTypes[0]) {
+		if (!oOperator || !oOperator.valueTypes[0] || (oOperator.valueTypes[0] === Operator.ValueType.Static && !oOperator.getStaticText)) {
 			return "XL8 L8 M8 S0";
 		} else {
 			return "";
@@ -1309,6 +1353,10 @@ sap.ui.define([
 		if (oBindingContext) {
 			oOperatorField.setFieldGroupIds([oBindingContext.getPath()]); // use path to have a ID for every condition
 		}
+		if (oOperatorField.getValueState() === ValueState.Error && !oCondition.invalid) {
+			// remove error and show right value
+			oOperatorField.setValue(oOperatorField.getValue());
+		}
 		iIndex++;
 
 		var oRemoveButton = aGridContent[iIndex];
@@ -1323,8 +1371,7 @@ sap.ui.define([
 		var oValue0Field = aGridContent[iIndex];
 		var oValue1Field;
 		if (oValue0Field.hasOwnProperty("_iValueIndex") && oValue0Field._iValueIndex === 0) {
-			var sEditMode = _getEditModeFromOperator(oCondition.operator);
-			if (oCondition.values.length > 0 || sEditMode === EditMode.Display) { // as static text for display controls is created after update
+			if (oCondition.values.length > 0) {
 				oValueBindingContext = this._oManagedObjectModel.getContext(oBindingContext.getPath() + "values/0/");
 				oValue0Field.setBindingContext(oValueBindingContext, "$this");
 				oValue0Field.setBindingContext(oBindingContext, "$condition");
@@ -1421,9 +1468,9 @@ sap.ui.define([
 		var oField2; // also update second Field if exist
 		var oCondition = oBindingContext.getObject();
 		var oOperator = FilterOperatorUtil.getOperator(oCondition.operator);
-		var bInvalid = false;
+		var bInvalid = !!oCondition.invalid;
 
-		if (oOperator.valueTypes.length > 0 && oOperator.valueTypes[0] !== Operator.ValueType.Static) {
+		if (!bInvalid && oOperator.valueTypes.length > 0 && oOperator.valueTypes[0] !== Operator.ValueType.Static) {
 			// check only not static operators
 			if (oOperator.valueTypes.length > 1 && oOperator.valueTypes[1]) {
 				// two fields exist
@@ -1467,14 +1514,26 @@ sap.ui.define([
 
 	function _checkInvalidInput(bInvalid) {
 
+		var i = 0;
+
 		if (bInvalid !== true) {
 			// if already known that invalid input exist -> no additional check needed
+			var aConditions = this.getConditions();
+			for (i = 0; i < aConditions.length; i++) {
+				if (aConditions[i].invalid) {
+					bInvalid = true;
+					break;
+				}
+			}
+		}
+
+		if (bInvalid !== true) {
 			var oGrid = this.byId("conditions");
 			var aContent = oGrid.getContent();
 			bInvalid = false;
-			for (var i = 0; i < aContent.length; i++) {
+			for (i = 0; i < aContent.length; i++) {
 				var oControl = aContent[i];
-				if (oControl instanceof Field && oControl.hasOwnProperty("_iValueIndex") && oControl.getValueState() === ValueState.Error) {
+				if (oControl.hasOwnProperty("_iValueIndex") && oControl.getValueState && oControl.getValueState() === ValueState.Error) {
 					bInvalid = true;
 					break;
 				}