@openui5/sap.ui.fl 1.94.0 → 1.97.0

package/src/sap/ui/fl/registry/Settings.js

@@ -3,21 +3,37 @@
  * (c) Copyright 2009-2021 SAP SE or an SAP affiliate company.
  * Licensed under the Apache License, Version 2.0 - see LICENSE.txt.
  */
-/*global Error */
 
 sap.ui.define([
 	"sap/ui/fl/write/_internal/Storage",
+	"sap/ui/fl/Utils",
 	"sap/base/Log"
 ], function(
 	Storage,
+	Utils,
 	Log
 ) {
 	"use strict";
 
+	function retrieveUserId() {
+		var oUShellContainer = Utils.getUshellContainer();
+		if (oUShellContainer) {
+			return Utils.getUShellService("UserInfo")
+				.then(function(oUserInfoService) {
+					var oUser = oUserInfoService.getUser();
+					return oUser && oUser.getId();
+				})
+				.catch(function(oError) {
+					Log.error("Error getting service from Unified Shell: " + oError.message);
+				});
+		}
+		return Promise.resolve();
+	}
+
 	/**
 	 * FlexSettings access
 	 *
-	 * @param {object} oSettings settings as JSON object
+	 * @param {object} oSettings - Settings as JSON object
 	 * @constructor
 	 * @alias sap.ui.fl.registry.Settings
 	 * @private
@@ -33,8 +49,8 @@ sap.ui.define([
 	/**
 	 * attaches a callback to an event on the event provider of Settings
 	 *
-	 * @param {string} sEventId name of the event
-	 * @param {function} oCallback
+	 * @param {string} sEventId - Name of the event
+	 * @param {function} oCallback - Callback that should be attached to the event
 	 */
 	Settings.attachEvent = function(sEventId, oCallback) {
 		Settings._oEventProvider.attachEvent(sEventId, oCallback);
@@ -43,8 +59,8 @@ sap.ui.define([
 	/**
 	 * detaches a callback to an event on the event provider of Settings
 	 *
-	 * @param {string} sEventId name of the event
-	 * @param {function} oCallback
+	 * @param {string} sEventId - Name of the event
+	 * @param {function} oCallback - Callback that should be detached from the event
 	 */
 	Settings.detachEvent = function(sEventId, oCallback) {
 		Settings._oEventProvider.detachEvent(sEventId, oCallback);
@@ -54,7 +70,7 @@ sap.ui.define([
 	 * Returns a settings instance after reading the settings from the back end if not already done. There is only one instance of settings during a
 	 * session.
 	 *
-	 * @returns {Promise} with parameter <code>oInstance</code> of type {sap.ui.fl.registry.Settings}
+	 * @returns {Promise} With parameter <code>oInstance</code> of type {sap.ui.fl.registry.Settings}
 	 */
 	Settings.getInstance = function() {
 		if (Settings._instance) {
@@ -72,29 +88,36 @@ sap.ui.define([
 	 * @returns {Promise} With parameter <code>oInstance</code> of type {sap.ui.fl.registry.Settings}
 	 */
 	Settings._loadSettings = function() {
-		var oLoadingPromise = Storage.loadFeatures().then(function (oSettings) {
-			if (!oSettings) {
-				Log.error("The request for flexibility settings failed; A default response is generated and returned to consuming APIs");
-				// in case the back end cannot respond resolve with a default response
-				oSettings = {
-					isKeyUser: false,
-					isKeyUserTranslationEnabled: false,
-					isVariantSharingEnabled: false,
-					isVariantPersonalizationEnabled: true,
-					isAtoAvailable: false,
-					isAtoEnabled: false,
-					isAppVariantSaveAsEnabled: false,
-					isCondensingEnabled: false,
-					isProductiveSystem: true,
-					isPublicLayerAvailable: false,
-					isVariantAdaptationEnabled: false,
-					versioning: {},
-					_bFlexChangeMode: false,
-					_bFlexibilityAdaptationButtonAllowed: false
-				};
-			}
-			return Settings._storeInstance(oSettings);
-		});
+		var oSettings;
+		var oLoadingPromise = Storage.loadFeatures()
+			.then(function(oLoadedSettings) {
+				oSettings = oLoadedSettings;
+				return retrieveUserId();
+			})
+			.then(function (sUserId) {
+				if (!oSettings) {
+					Log.error("The request for flexibility settings failed; A default response is generated and returned to consuming APIs");
+					// in case the back end cannot respond resolve with a default response
+					oSettings = {
+						isKeyUser: false,
+						isKeyUserTranslationEnabled: false,
+						isVariantSharingEnabled: false,
+						isVariantPersonalizationEnabled: true,
+						isAtoAvailable: false,
+						isAtoEnabled: false,
+						isAppVariantSaveAsEnabled: false,
+						isCondensingEnabled: false,
+						isProductiveSystem: true,
+						isPublicLayerAvailable: false,
+						isVariantAdaptationEnabled: false,
+						versioning: {},
+						_bFlexChangeMode: false,
+						_bFlexibilityAdaptationButtonAllowed: false
+					};
+				}
+				oSettings.userId = sUserId;
+				return Settings._storeInstance(oSettings);
+			});
 		Settings._oLoadSettingsPromise = oLoadingPromise;
 		return oLoadingPromise;
 	};
@@ -103,7 +126,7 @@ sap.ui.define([
 	 * Writes the data received from the storage into an internal instance and then returns the settings object within a Promise.
 	 *
 	 * @param {object} oSettings - Data received from the storage
-	 * @returns {Promise} with parameter <code>oInstance</code> of type {sap.ui.fl.registry.Settings}
+	 * @returns {Promise} With parameter <code>oInstance</code> of type {sap.ui.fl.registry.Settings}
 	 *
 	 */
 	Settings._storeInstance = function(oSettings) {
@@ -117,7 +140,7 @@ sap.ui.define([
 	 * Returns a settings instance from the local instance cache. There is only one instance of settings during a session. If no instance has been
 	 * created before, undefined will be returned.
 	 *
-	 * @returns {sap.ui.fl.registry.Settings} instance or undefined if no instance has been created so far
+	 * @returns {sap.ui.fl.registry.Settings} Instance or undefined if no instance has been created so far
 	 */
 	Settings.getInstanceOrUndef = function() {
 		return Settings._instance;
@@ -154,7 +177,7 @@ sap.ui.define([
 	/**
 	 * Reads boolean property of settings.
 	 *
-	 * @param {string} sPropertyName name of property
+	 * @param {string} sPropertyName - Name of property
 	 * @returns {boolean} <code>true</code> if the property exists and is true
 	 */
 	Settings.prototype._getBooleanProperty = function(sPropertyName) {
@@ -173,7 +196,7 @@ sap.ui.define([
 	/**
 	 * Returns the information if translation is enabled for the KeyUser or not (has admin role).
 	 *
-	 * @returns {boolean} true if the user is a flexibility key user and has the admin role.
+	 * @returns {boolean} <code>true</code> if the user is a flexibility key user and has the admin role.
 	 */
 	Settings.prototype.isKeyUserTranslationEnabled = function() {
 		return this._getBooleanProperty("isKeyUserTranslationEnabled");
@@ -290,24 +313,34 @@ sap.ui.define([
 	};
 
 	/**
-	 * Getter for the system Id of the connected backend.
+	 * Getter for the system ID of the connected back end.
 	 * Taken from the property 'system' of the flex settings. Only filled for an ABAP backend.
 	 *
-	 * @returns {String} system Id of the connected backend or undefined (when property 'system' does not exist in the flex settings file)
+	 * @returns {string} System ID of the connected back end or undefined (when property <code>system</code> does not exist in the flex settings file)
 	 */
 	Settings.prototype.getSystem = function() {
 		return this._oSettings.system;
 	};
 
 	/**
-	 * Getter for the client of the connected backend.
+	 * Getter for the client of the connected back end.
 	 * Taken from the property 'client' of the flex settings. Only filled for an ABAP backend.
 	 *
-	 * @returns {String} client of the connected backend or undefined (when property 'system' does not exist in the flex settings file)
+	 * @returns {string} Client of the connected backend or undefined (when property <code>system</code> does not exist in the flex settings file)
 	 */
 	Settings.prototype.getClient = function() {
 		return this._oSettings.client;
 	};
 
+	/**
+	 * Getter for the id of the current user.
+	 * Taken from the property 'userId' of the flex settings. Only filled when UShell is available.
+	 *
+	 * @returns {string} User ID of the current user. Undefined if UShell is not available.
+	 */
+	 Settings.prototype.getUserId = function() {
+		return this._oSettings.userId;
+	};
+
 	return Settings;
 }, /* bExport= */true);

package/src/sap/ui/fl/support/Flexibility.js

@@ -13,25 +13,35 @@ sap.ui.define([
 	"sap/ui/model/json/JSONModel",
 	"sap/ui/fl/FlexController",
 	"sap/ui/fl/ChangePersistenceFactory",
-	"sap/ui/fl/Utils",
 	"sap/ui/fl/support/apps/uiFlexibilityDiagnostics/helper/Extractor",
 	"sap/ui/core/mvc/XMLView",
 	"sap/ui/core/Component"
-], function (each, Plugin, Support, JsControlTreeModifier, JSONModel, FlexController, ChangePersistenceFactory, Utils, Extractor, XMLView, CoreComponent) {
+], function(
+	each,
+	Plugin,
+	Support,
+	JsControlTreeModifier,
+	JSONModel,
+	FlexController,
+	ChangePersistenceFactory,
+	Extractor,
+	XMLView,
+	CoreComponent
+) {
 	"use strict";
 
 	/**
-		 * Creates an instance of sap.ui.fl.support.Flexibility.
-		 * @class This class represents the plugin for the support tool functionality of UI5.
-		 * This class is internal and all its functions must not be used by an application
-		 *
-		 * @abstract
-		 * @extends sap.ui.core.support.Plugin
-		 * @version 1.94.0
-		 * @private
-		 * @ui5-restricted
-		 * @constructor
-		 */
+	 * Creates an instance of <code>sap.ui.fl.support.Flexibility</code>.
+	 * @class This class represents the plugin for the support tool functionality of UI5.
+	 * This class is internal and all its functions must not be used by an application
+	 *
+	 * @abstract
+	 * @extends sap.ui.core.support.Plugin
+	 * @version 1.97.0
+	 * @private
+	 * @ui5-restricted
+	 * @constructor
+	 */
 	var Flexibility = Plugin.extend("sap.ui.fl.support.Flexibility", {
 		constructor: function (oSupportStub) {
 			Plugin.apply(this, ["sapUiSupportFlexibility", "Flexibility", oSupportStub]);
@@ -54,11 +64,11 @@ sap.ui.define([
 	Flexibility.prototype.sDelimiter = ";";
 
 	/**
-		 * Creation of the support plugin.
-		 * On tool plugin site a rendering as well as a model creation for later data receiving is created.
-		 *
-		 * @param {sap.ui.core.support.Support} oSupportStub - support instance created within the support window instantiation
-		 */
+	 * Creation of the support plugin.
+	 * On the tool plugin site a rendering as well as a model creation for later data receiving is created.
+	 *
+	 * @param {sap.ui.core.support.Support} oSupportStub - Support instance created within the support window instantiation
+	 */
 	Flexibility.prototype.init = function (oSupportStub) {
 		Plugin.prototype.init.apply(this, arguments);
 
@@ -86,13 +96,15 @@ sap.ui.define([
 	};
 
 	/**
-		 * Rendering of the tool plugin side of the UI.
-		 * This creates a plain html-rendered header as well as a view containing the hierarchy of the flexibility data:
-		 * - Hierarchical List of controls and their changes
-		 * - details View with information to selected changes
-		 *
-		 * @private
-		 */
+	 * Rendering of the tool plugin side of the UI.
+	 * This creates a plain html-rendered header as well as a view containing the hierarchy of the flexibility data:
+	 * <ul>
+	 * <li>hierarchical list of controls and their changes</li>
+	 * <li>details view with information to selected changes</li>
+	 * </ul>
+	 *
+	 * @private
+	 */
 	Flexibility.prototype._renderToolPlugin = function () {
 		var _doPlainRendering = function () {
 			var rm = sap.ui.getCore().createRenderManager();
@@ -122,18 +134,18 @@ sap.ui.define([
 	};
 
 	/**
-		 * Requests the data from the application side support plugin
-		 *
-		 * @private
-		 * @restricted sap.ui.fl.support
-		 */
+	 * Requests the data from the application side support plugin.
+	 *
+	 * @private
+	 * @restricted sap.ui.fl.support
+	 */
 	Flexibility.prototype.onRefresh = function () {
 		Support.getStub().sendEvent(this.getId() + "GetApps", {});
 	};
 
 	/**
-		 * Collect list of apps
-		 */
+	 * Collects a list of apps.
+	 */
 	Flexibility.prototype.onsapUiSupportFlexibilityGetApps = function () {
 		var aApps = [];
 
@@ -153,7 +165,7 @@ sap.ui.define([
 
 	/**
 	 * Parses all registered components and extracts <code>sap.ui5/appVariantHierarchy</code>.
-	 * @param {string} sReference
+	 * @param {string} sReference - Flex reference
 	 * @returns {string} Joined app variant hierarchy and its app version
 	 */
 	Flexibility.prototype.getAppVariantHierarchy = function (sReference) {
@@ -173,11 +185,10 @@ sap.ui.define([
 	};
 
 	/**
-		 * Collect data of changes
-		 *
-		 * @param {sap.ui.base.Event} oEvent Event sent from the tool side plugin to request changes
-		 *
-		 */
+	 * Collects data of changes.
+	 *
+	 * @param {sap.ui.base.Event} oEvent - Event sent from the tool side plugin to request changes
+	 */
 	Flexibility.prototype.onsapUiSupportFlexibilityGetChangesMaps = function (oEvent) {
 		var sAppKey = oEvent.mParameters.appKey;
 		var aAppParameters = sAppKey.split(this.sDelimiter);
@@ -186,20 +197,20 @@ sap.ui.define([
 	};
 
 	/**
-		 * Handler on tool plugin side; passes the received data from the application plugin tool to a model.
-		 *
-		 * @param {sap.ui.base.Event} oEvent Event sent from the application side plugin with the applications
-		 */
+	 * Handler on tool plugin side; passes the received data from the application plugin tool to a model.
+	 *
+	 * @param {sap.ui.base.Event} oEvent - Event sent from the application side plugin with the applications
+	 */
 	Flexibility.prototype.onsapUiSupportFlexibilitySetApps = function (oEvent) {
 		var mApps = oEvent.getParameters();
 		this.oAppModel.setData(mApps);
 	};
 
 	/**
-		 * Handler on tool plugin side; passes the received data from the application plugin tool to a model.
-		 *
-		 * @param {sap.ui.base.Event} oEvent Event sent from the application side plugin with the changes
-		 */
+	 * Handler on tool plugin side; passes the received data from the application plugin tool to a model.
+	 *
+	 * @param {sap.ui.base.Event} oEvent - Event sent from the application side plugin with the changes
+	 */
 	Flexibility.prototype.onsapUiSupportFlexibilitySetChangesMaps = function (oEvent) {
 		var mCacheEntries = oEvent.getParameters();
 		this.oChangesModel.setData(mCacheEntries);
@@ -212,14 +223,21 @@ sap.ui.define([
 	};
 
 	/**
-		 * Collect data of changes
-		 *
-		 * @param {string} sAppName Name of the application
-		 *
-		 * @private
-		 */
+	 * Collects data of changes.
+	 *
+	 * @param {string} sAppName - Name of the application
+	 *
+	 * @private
+	 */
 	Flexibility.prototype._getChangesMapForApp = function (sAppName) {
-		function _collectChangesData(mChanges, sControlId) {
+		var mChangedControls = {};
+		var mChanges = {};
+		var aTreeNodes = [];
+		var oChangePersistence = ChangePersistenceFactory.getChangePersistenceForComponent(sAppName);
+		var mChangeFromPersistence = oChangePersistence._mChanges.mChanges;
+		var mDependencies = oChangePersistence._mChangesInitial.mDependencies;
+
+		function collectChangesData(mChanges, sControlId) {
 			mChangedControls[sControlId] = [];
 			var aChangesForControl = mChangeFromPersistence[sControlId];
 			var oControl = sap.ui.getCore().byId(sControlId);
@@ -238,10 +256,10 @@ sap.ui.define([
 				}
 			}
 
-			mChangedControls[sControlId] = aChangesForControl.map(_collectDataForSingleChange.bind(this, oControl, aAppliedChanges, aFailedChangesJs, aFailedChangesXml, mChanges));
+			mChangedControls[sControlId] = aChangesForControl.map(collectDataForSingleChange.bind(this, oControl, aAppliedChanges, aFailedChangesJs, aFailedChangesXml, mChanges));
 		}
 
-		function _collectDataForSingleChange(oControl, aAppliedChanges, aFailedChangesJs, aFailedChangesXml, mChanges, oChange) {
+		function collectDataForSingleChange(oControl, aAppliedChanges, aFailedChangesJs, aFailedChangesXml, mChanges, oChange) {
 			var oChangeDetails = {
 				id: oChange.getId(),
 				changeType: oChange.getChangeType(),
@@ -285,7 +303,7 @@ sap.ui.define([
 			return oChangeDetails;
 		}
 
-		function _setIsInSubTreeInformation(oChangeDetails, sKey, oDependency) {
+		function setIsInSubTreeInformation(oChangeDetails, sKey, oDependency) {
 			var aChangeIds = oDependency.dependencies;
 			if (aChangeIds.indexOf(oChangeDetails.id) !== -1) {
 				var bSameSelector = JSON.stringify(mChanges[sKey].selector) === JSON.stringify(oChangeDetails.selector);
@@ -293,9 +311,9 @@ sap.ui.define([
 			}
 		}
 
-		function _setDependentChangeRelatedInformation(sControlId, mChangesOnControl) {
+		function setDependentChangeRelatedInformation(sControlId, mChangesOnControl) {
 			mChangesOnControl.forEach(function (oChangeDetails) {
-				jQuery.each(mDependencies, _setIsInSubTreeInformation.bind(this, oChangeDetails));
+				jQuery.each(mDependencies, setIsInSubTreeInformation.bind(this, oChangeDetails));
 
 				oChangeDetails.allDependendingControlsPresent = oChangeDetails.dependentControls.every(function (mControl) {
 					return mControl.controlPresent;
@@ -327,7 +345,7 @@ sap.ui.define([
 			});
 		}
 
-		function _fnCreateChangesNode(aChangesDetails) {
+		function fnCreateChangesNode(aChangesDetails) {
 			aChangesDetails = aChangesDetails.filter(function (oChange) {
 				return !aChangesDetails.some(function (oChangeInSameHierarchy) {
 					return oChangeInSameHierarchy.dependentChanges.some(function (oDependentChange) {
@@ -340,28 +358,21 @@ sap.ui.define([
 				return {
 					id: oChange.id,
 					text: oChange.changeType,
-					nodes: oChange.dependentChanges ? _fnCreateChangesNode(oChange.dependentChanges) : []
+					nodes: oChange.dependentChanges ? fnCreateChangesNode(oChange.dependentChanges) : []
 				};
 			});
 		}
 
-		function _createRootNodes(sControlId, aChangesDetails) {
+		function createRootNodes(sControlId, aChangesDetails) {
 			aTreeNodes.push({
 				text: sControlId,
-				nodes: _fnCreateChangesNode(aChangesDetails)
+				nodes: fnCreateChangesNode(aChangesDetails)
 			});
 		}
 
-		var mChanges = {};
-		var mChangedControls = {};
-		var aTreeNodes = [];
-		var oChangePersistence = ChangePersistenceFactory.getChangePersistenceForComponent(sAppName);
-		var mChangeFromPersistence = oChangePersistence._mChanges.mChanges;
-		var mDependencies = oChangePersistence._mChangesInitial.mDependencies;
-
-		Object.keys(mChangeFromPersistence).forEach(_collectChangesData.bind(this, mChanges));
-		jQuery.each(mChangedControls, _setDependentChangeRelatedInformation);
-		jQuery.each(mChangedControls, _createRootNodes);
+		Object.keys(mChangeFromPersistence).forEach(collectChangesData.bind(this, mChanges));
+		jQuery.each(mChangedControls, setDependentChangeRelatedInformation);
+		jQuery.each(mChangedControls, createRootNodes);
 
 		this._oStub.sendEvent(this.getId() + "SetChangesMaps", {
 			changes: mChanges,

package/src/sap/ui/fl/support/apps/contentbrowser/controller/ContentDetails.controller.js

@@ -36,7 +36,7 @@ sap.ui.define([
 	 * @constructor
 	 * @alias sap.ui.fl.support.apps.contentbrowser.controller.ContentDetails
 	 * @author SAP SE
-	 * @version 1.94.0
+	 * @version 1.97.0
 	 * @experimental Since 1.45
 	 */
 	return Controller.extend("sap.ui.fl.support.apps.contentbrowser.controller.ContentDetails", {
@@ -68,8 +68,8 @@ sap.ui.define([
 		/**
 		 * Handler if a route was matched;
 		 * Obtains information about layer, namespace, filename, and file type from the route's arguments, and then requests content from Layered Repository.
-		 * @param {Object} oRouteMatch - route object which is specified in the router and matched via regexp
-		 * @returns {Promise} - <code>LRepConnector</code> "getContent" promise
+		 * @param {object} oRouteMatch - Route object which is specified in the router and matched via regexp
+		 * @returns {Promise} <code>LRepConnector</code> "getContent" promise
 		 * @private
 		 */
 		_onRouteMatched: function (oRouteMatch) {
@@ -101,11 +101,11 @@ sap.ui.define([
 		/**
 		 * Handler if content data was received;
 		 * Formats the received data into the correct file type and requests the file metadata.
-		 * @param {Object} oModelData - model data of current page
-		 * @param {Object} oPage - current page used to set display busy mode on/off
-		 * @param {Object} sContentSuffix - content suffix for sending the metadata request
-		 * @param {Object} oData - data which is received from <code>LRepConnector</code> "getContent" promise
-		 * @returns {Promise} - <code>LRepConnector</code> "getContent" promise
+		 * @param {object} oModelData - Model data of current page
+		 * @param {object} oPage - Current page used to set display busy mode on/off
+		 * @param {object} sContentSuffix - Content suffix for sending the metadata request
+		 * @param {object} oData - Data which is received from <code>LRepConnector</code> "getContent" promise
+		 * @returns {Promise} <code>LRepConnector</code> "getContent" promise
 		 * @private
 		 */
 		_onContentReceived: function (oModelData, oPage, sContentSuffix, oData) {
@@ -127,9 +127,9 @@ sap.ui.define([
 		/**
 		 * Handler if content metadata was received;
 		 * Sets the received data to the current content model, updates the icon tab bar, and releases the busy mode of the current page.
-		 * @param {Object} oModelData - model data of current page
-		 * @param {Object} oPage - current page used to set display busy mode on/off
-		 * @param {Object} oMetadata - metadata which is received from <code>LRepConnector</code> "getContent" promise
+		 * @param {object} oModelData - Model data of current page
+		 * @param {object} oPage - Current page used to set display busy mode on/off
+		 * @param {object} oMetadata - Metadata which is received from <code>LRepConnector</code> "getContent" promise
 		 * @private
 		 */
 		_onContentMetadataReceived: function (oModelData, oPage, oMetadata) {
@@ -282,7 +282,7 @@ sap.ui.define([
 
 		/**
 		 * Handler if a deletion was confirmed.
-		 * @returns {Promise} - <code>LRepConnector</code> "deleteFile" promise
+		 * @returns {Promise} <code>LRepConnector</code> "deleteFile" promise
 		 * @private
 		 */
 		_deleteFile: function (sLayer, sNamespace, sFileName, sFileType, sTransportId, sSelectedLayer) {

package/src/sap/ui/fl/support/apps/contentbrowser/controller/ContentDetailsEdit.controller.js

@@ -36,7 +36,7 @@ sap.ui.define([
 	 * @constructor
 	 * @alias sap.ui.fl.support.apps.contentbrowser.controller.ContentDetailsEdit
 	 * @author SAP SE
-	 * @version 1.94.0
+	 * @version 1.97.0
 	 * @experimental Since 1.45
 	 */
 	return Controller.extend("sap.ui.fl.support.apps.contentbrowser.controller.ContentDetailsEdit", {
@@ -67,7 +67,7 @@ sap.ui.define([
 		/**
 		 * Handler if a route was matched;
 		 * Obtains information about layer, namespace, filename, and file type from the route's arguments, and then requests content from Layered Repository.
-		 * @param {Object} oRouteMatch - route object which is specified in the router and matched via regexp
+		 * @param {object} oRouteMatch - Route object which is specified in the router and matched via regexp
 		 * @returns {Promise} - <code>LRepConnector</code> "getContent" promise
 		 * @private
 		 */
@@ -101,11 +101,11 @@ sap.ui.define([
 		/**
 		 * Handler if content data was received;
 		 * Formats the received data into the correct file type and requests the file metadata.
-		 * @param {Object} oModelData - model data of current page
-		 * @param {Object} oPage - current page used to set display busy mode on/off
-		 * @param {Object} sContentSuffix - content suffix to send metadata request
-		 * @param {Object} oData - data which is received from <code>LRepConnector</code> "getContent" promise
-		 * @returns {Promise} - <code>LRepConnector</code> "getContent" promise
+		 * @param {object} oModelData - Model data of current page
+		 * @param {object} oPage - Current page used to set display busy mode on/off
+		 * @param {object} sContentSuffix - Content suffix to send metadata request
+		 * @param {object} oData - Data which is received from <code>LRepConnector</code> "getContent" promise
+		 * @returns {Promise} <code>LRepConnector</code> "getContent" promise
 		 * @private
 		 */
 		_onContentReceived: function (oModelData, oPage, sContentSuffix, oData) {
@@ -202,7 +202,7 @@ sap.ui.define([
 		/**
 		 * Send request to back end to saved file.
 		 * After the file has been successfully saved, navigates to "Display" mode of the content.
-		 * @returns {Promise} - <code>LRepConnector</code> "saveFiles" promise
+		 * @returns {Promise} <code>LRepConnector</code> "saveFiles" promise
 		 * @private
 		 */
 		_saveFile: function (sLayer, sNameSpace, sFileName, sFileType, sData, sTransportId, sPackageName) {

package/src/sap/ui/fl/support/apps/contentbrowser/controller/LayerContentMaster.controller.js

@@ -27,7 +27,7 @@ sap.ui.define([
 	 * @constructor
 	 * @alias sap.ui.fl.support.apps.contentbrowser.controller.LayerContentMaster
 	 * @author SAP SE
-	 * @version 1.94.0
+	 * @version 1.97.0
 	 * @experimental Since 1.45
 	 */
 	return Controller.extend("sap.ui.fl.support.apps.contentbrowser.controller.LayerContentMaster", {
@@ -48,7 +48,7 @@ sap.ui.define([
 		/**
 		 * Handler if a route was matched;
 		 * Checks if the matched route is current route and then requests content from Layered Repository.
-		 * @param {Object} oRouteMatch - route object specified in the router which was matched via regexp
+		 * @param {object} oRouteMatch - Route object specified in the router which was matched via regexp
 		 * @private
 		 */
 		_onRouteMatched: function (oRouteMatch) {
@@ -73,8 +73,8 @@ sap.ui.define([
 		/**
 		 * Handler if content data was received;
 		 * Sets the received data to the current content model.
-		 * @param {Object} oPage
-		 * @param {Object} oData - data which is received from <code>LRepConnector</code> "getContent" promise
+		 * @param {object} oPage - Page instance
+		 * @param {object} oData - Data which is received from <code>LRepConnector</code> "getContent" promise
 		 * @private
 		 */
 		_onContentReceived: function (oPage, oData) {
@@ -87,7 +87,7 @@ sap.ui.define([
 
 		/**
 		 * Searches for a specific namespace inside layer.
-		 * @param {Object} oEvent - "liveChange" event of search field
+		 * @param {object} oEvent - <code>liveChange</code> event of search field
 		 * @public
 		 */
 		onSearch: function (oEvent) {
@@ -98,7 +98,7 @@ sap.ui.define([
 		/**
 		 * Filters the binding of the master list;
 		 * This function is also called once navigation to the page to clear the filters or input search entry.
-		 * @param {String} sQuery - entered string within the search field
+		 * @param {string} sQuery - Entered string within the search field
 		 * @public
 		 */
 		filterListByQuery: function (sQuery) {
@@ -123,7 +123,7 @@ sap.ui.define([
 		/**
 		 * Handles the selection of a layer entry in the master page;
 		 * Gathers the selected namespace and the current layer, then navigates to the target.
-		 * @param {Object} oEvent - press event of master components list
+		 * @param {object} oEvent - Press event of master components list
 		 * @public
 		 */
 		onContentSelected: function (oEvent) {
@@ -173,7 +173,7 @@ sap.ui.define([
 		/**
 		 * Formatter to shorten namespaces with multiple hierarchies;
 		 * If the hierarchy has more than two levels only the first and last levels are shown.
-		 * @returns {String} - shortened namespace for display
+		 * @returns {string} - Shortened namespace for display
 		 * @private
 		 */
 		_shortenNamespace: function () {
@@ -193,7 +193,7 @@ sap.ui.define([
 		/**
 		 * Handler for displaying errors;
 		 * Calls the "ErrorUtils" helper class for error handling.
-		 * @param oEvent - press event on the error button
+		 * @param {object} oEvent - Press event on the error button
 		 * @public
 		 */
 		handleMessagePopoverPress: function (oEvent) {