@openui5/sap.ui.core 1.122.1 → 1.123.1

package/src/sap/ui/model/odata/v4/Context.js

@@ -42,7 +42,7 @@ sap.ui.define([
 		 * @hideconstructor
 		 * @public
 		 * @since 1.39.0
-		 * @version 1.122.1
+		 * @version 1.123.1
 		 */
 		Context = BaseContext.extend("sap.ui.model.odata.v4.Context", {
 				constructor : constructor
@@ -321,6 +321,17 @@ sap.ui.define([
 				throw new Error("Cannot delete " + this);
 			}
 		}
+		if (this.oBinding.mParameters.$$aggregation) {
+			if (this.iIndex === undefined) {
+				throw new Error("Unsupported kept-alive context: " + this);
+			}
+			if (sGroupId !== null) {
+				const sEffectiveGroupId = sGroupId ?? this.oBinding.getUpdateGroupId();
+				if (this.oModel.isApiGroup(sEffectiveGroupId)) {
+					throw new Error("Unsupported group ID: " + sEffectiveGroupId);
+				}
+			}
+		}
 		if (sGroupId === null) {
 			oEditUrlPromise = SyncPromise.resolve();
 			bDoNotRequestCount = true;
@@ -670,7 +681,7 @@ sap.ui.define([
 	 *   If <code>true</code>, the value is returned in external format using a UI5 type for the
 	 *   given property path that formats corresponding to the property's EDM type and constraints.
 	 * @param {boolean} [bCached]
-	 *   Whether to return cached values only and not trigger a request
+	 *   Whether to return cached values only and not initiate a request
 	 * @returns {sap.ui.base.SyncPromise} a promise on the formatted value
 	 *
 	 * @private
@@ -707,7 +718,7 @@ sap.ui.define([
 	 * @param {sap.ui.model.odata.v4.ODataPropertyBinding} [oListener]
 	 *   A property binding which registers itself as listener at the cache
 	 * @param {boolean} [bCached]
-	 *   Whether to return cached values only and not trigger a request
+	 *   Whether to return cached values only and not initiate a request
 	 * @returns {sap.ui.base.SyncPromise}
 	 *   A promise on the outcome of the binding's <code>fetchValue</code> call; it is rejected
 	 *   in case cached values are asked for, but not found
@@ -914,7 +925,7 @@ sap.ui.define([
 	 * Note that the function clones the result. Modify values via
 	 * {@link sap.ui.model.odata.v4.ODataPropertyBinding#setValue}.
 	 *
-	 * Returns <code>undefined</code> if the data is not (yet) available; no request is triggered.
+	 * Returns <code>undefined</code> if the data is not (yet) available; no request is initiated.
 	 * Use {@link #requestObject} for asynchronous access.
 	 *
 	 * The header context of a list binding only delivers <code>$count</code> and
@@ -965,7 +976,7 @@ sap.ui.define([
 	/**
 	 * Returns the property value for the given path relative to this context. The path is expected
 	 * to point to a structural property with primitive type. Returns <code>undefined</code>
-	 * if the data is not (yet) available; no request is triggered. Use {@link #requestProperty}
+	 * if the data is not (yet) available; no request is initiated. Use {@link #requestProperty}
 	 * for asynchronous access.
 	 *
 	 * @param {string} sPath
@@ -1047,7 +1058,7 @@ sap.ui.define([
 	 * Note that the function returns the cache instance. Do not modify the result, use
 	 * {@link sap.ui.model.odata.v4.ODataPropertyBinding#setValue} instead.
 	 *
-	 * Returns <code>undefined</code> if the data is not (yet) available; no request is triggered.
+	 * Returns <code>undefined</code> if the data is not (yet) available; no request is initiated.
 	 *
 	 * @param {string} [sPath=""]
 	 *   A path, absolute or relative to this context
@@ -1270,21 +1281,31 @@ sap.ui.define([
 	 *
 	 * This context's {@link #getIndex index} may change and, in case of
 	 * <code>oAggregation.expandTo : 1</code>, it becomes "created persisted", with
-	 * {@link #isTransient} returning <code>false</code> etc.
+	 * {@link #isTransient} returning <code>false</code> etc. In case of
+	 * <code>oAggregation.expandTo >= Number.MAX_SAFE_INTEGER</code>, a created node becomes simply
+	 * "persisted", with {@link #isTransient} returning <code>undefined</code> etc.
 	 *
 	 * @param {object} [oParameters] - A parameter object
 	 * @param {sap.ui.model.odata.v4.Context} [oParameters.parent=null] - The new parent's context
 	 * @returns {Promise<void>}
 	 *   A promise which is resolved without a defined result when the move is finished, or
 	 *   rejected in case of an error
-	 * @throws {Error}
-	 *   If the parent is (a descendant of) this node, or if <code>oAggregation.expandTo</code> is
-	 *   unsupported.
+	 * @throws {Error} If
+	 *   <ul>
+	 *     <li> the parent is (a descendant of) this node,
+	 *     <li> <code>oAggregation.expandTo</code> is unsupported,
+	 *     <li> this node is {@link #isDeleted deleted},
+	 *     <li> this node is {@link #isTransient transient},
+	 *     <li> this node is not in the collection (has no {@link #getIndex index}).
+	 *   </ul>
 	 *
 	 * @experimental As of version 1.119.0
 	 * @public
 	 */
 	Context.prototype.move = function ({parent : oParent = null} = {}) {
+		if (this.isDeleted() || this.isTransient() || this.iIndex === undefined) {
+			throw new Error("Cannot move " + this);
+		}
 		if (this.isAncestorOf(oParent)) {
 			throw new Error("Unsupported parent context: " + oParent);
 		}
@@ -1607,7 +1628,7 @@ sap.ui.define([
 	 *     this case.
 	 * </ul>
 	 * Key predicates must be available in this context's path. Avoid
-	 * navigation properties as part of a binding's $select system query option as they may trigger
+	 * navigation properties as part of a binding's $select system query option as they may initiate
 	 * pointless requests. There must be only context bindings between this context and its first
 	 * ancestor binding which uses own data service requests.
 	 *
@@ -1700,8 +1721,8 @@ sap.ui.define([
 	 *       {@link sap.ui.model.odata.v4.ODataListBinding#setAggregation})
 	 *   </ul>
 	 * @public
-	 * @see sap.ui.model.odata.v4.ODataContextBinding#execute
 	 * @see sap.ui.model.odata.v4.ODataContextBinding#getBoundContext
+	 * @see sap.ui.model.odata.v4.ODataContextBinding#invoke
 	 * @see sap.ui.model.odata.v4.ODataListBinding#getHeaderContext
 	 * @see sap.ui.model.odata.v4.ODataModel#bindContext
 	 * @since 1.61.0
@@ -1785,7 +1806,7 @@ sap.ui.define([
 		}, []);
 		aPathsForBinding = _Helper.filterPaths(aPathsForModel, aPathsForBinding);
 
-		sGroupId = sGroupId || this.getUpdateGroupId();
+		sGroupId ??= this.getUpdateGroupId();
 
 		return Promise.resolve(
 			SyncPromise.resolve(
@@ -1887,10 +1908,11 @@ sap.ui.define([
 	/**
 	 * Resets all property changes, created entities, and entity deletions of this context. Resets
 	 * also invalid user input and inactive contexts which had their activation prevented (see
-	 * {@link sap.ui.model.odata.v4.Context#isInactive}). This function does not reset the execution
-	 * of OData operations (see {@link sap.ui.model.odata.v4.ODataContextBinding#execute}). For a
-	 * context which is currently {@link #delete deleted} on the client, but not yet on the server,
-	 * this method cancels the deletion and restores the context.
+	 * {@link sap.ui.model.odata.v4.Context#isInactive}). This function does not reset the
+	 * invocation of OData operations (see
+	 * {@link sap.ui.model.odata.v4.ODataContextBinding#invoke}). For a context which is currently
+	 * {@link #delete deleted} on the client, but not yet on the server, this method cancels the
+	 * deletion and restores the context.
 	 *
 	 * @returns {Promise<void>}
 	 *   A promise which is resolved without a defined result as soon as all changes in the context
@@ -2004,10 +2026,10 @@ sap.ui.define([
 	 * @param {boolean} bKeepAlive
 	 *   Whether to keep the context alive
 	 * @param {function((sap.ui.model.odata.v4.Context|undefined))} [fnOnBeforeDestroy]
-	 *   Callback function that is executed once for a kept-alive context without any argument just
+	 *   Callback function that is called once for a kept-alive context without any argument just
 	 *   before the context is destroyed; see {@link #destroy}. If a context has been replaced in a
 	 *   list binding (see {@link #replaceWith} and
-	 *   {@link sap.ui.odata.v4.ODataContextBinding#execute}), the callback will later also be
+	 *   {@link sap.ui.odata.v4.ODataContextBinding#invoke}), the callback will later also be
 	 *   called just before the replacing context is destroyed, but with that context as the only
 	 *   argument. Supported since 1.84.0
 	 * @param {boolean} [bRequestMessages]
@@ -2083,12 +2105,30 @@ sap.ui.define([
 		this.iGeneration = iGenerationCounter;
 	};
 
+	/**
+	 * Sets this context's state from "created persisted" to "persisted".
+	 *
+	 * Note: this is a private and internal API. Do not call this!
+	 *
+	 * @throws {Error} If this context is not "created" or still transient
+	 *
+	 * @private
+	 */
+	Context.prototype.setPersisted = function () {
+		if (this.isTransient() !== false) {
+			throw new Error("Not 'created persisted'");
+		}
+		this.bInactive = undefined;
+		this.oCreatedPromise = undefined;
+		this.oSyncCreatePromise = undefined;
+	};
+
 	/**
 	 * Sets a new value for the property identified by the given path. The path is relative to this
 	 * context and is expected to point to a structural property with primitive type or, since
 	 * 1.85.0, to an instance annotation. Since 1.122.0 the client-side annotation
 	 * "@$ui5.context.isSelected" can be given as a path. Note: Writing to a client-side
-	 * annotation never triggers a PATCH request, even if <code>sGroupId</code> is given.
+	 * annotation never initiates a PATCH request, even if <code>sGroupId</code> is given.
 	 * Thus, reverting the value of this annotation cannot be done via {@link #resetChanges}.
 	 *
 	 * @param {string} sPath
@@ -2170,7 +2210,8 @@ sap.ui.define([
 	 * the preconditions of {@link #setKeepAlive} hold, a best effort is made to implicitly keep a
 	 * selected context alive in order to preserve the selection state. Once the selection is no
 	 * longer needed, for example because you perform an operation on this context which logically
-	 * removes it from its list, you need to reset the selection.
+	 * removes it from its list, you need to reset the selection. If this context is a header
+	 * context of a list binding, the new selection state is propagated to all row contexts.
 	 *
 	 * <b>Note:</b> It is unsafe to keep a reference to a context instance which is not
 	 * {@link #isKeepAlive kept alive}.
@@ -2192,8 +2233,11 @@ sap.ui.define([
 			throw new Error("Must not select a deleted entity: " + this);
 		}
 		if (bSelected !== this.bSelected) {
-			if (this.mChangeListeners) {
+			if (this.mChangeListeners) { // header context: "select all"
 				_Helper.fireChange(this.mChangeListeners, "", bSelected);
+				this.oBinding._getAllExistingContexts().forEach(function (oContext) {
+					oContext.setSelected(bSelected);
+				});
 			}
 			this.withCache((oCache, sPath) => {
 				if (this.oBinding) {

package/src/sap/ui/model/odata/v4/ODataBinding.js

@@ -357,7 +357,7 @@ sap.ui.define([
 				oCache = this.doCreateCache(sResourcePath, this.mCacheQueryOptions, oContext,
 					sDeepResourcePath, sGroupId, oOldCache);
 				if (!(this.mParameters && this.mParameters.$$sharedRequest)) {
-					this.mCacheByResourcePath = this.mCacheByResourcePath || {};
+					this.mCacheByResourcePath ??= {};
 					this.mCacheByResourcePath[sResourcePath] = oCache;
 				}
 				oCache.$deepResourcePath = sDeepResourcePath;
@@ -703,9 +703,8 @@ sap.ui.define([
 				.then(function (sReducedPath) {
 					if (sReducedPath) {
 						vQueryOptions = undefined;
-					} else if (!vQueryOptions) {
-						// fetchCache only creates a cache if there are query options
-						vQueryOptions = {};
+					} else { // fetchCache only creates a cache if there are query options
+						vQueryOptions ??= {};
 					}
 					return wrapQueryOptions(false, sReducedPath);
 				});
@@ -743,7 +742,7 @@ sap.ui.define([
 		if (!this.bRelative) {
 			return SyncPromise.resolve(this.sPath.slice(1));
 		}
-		oContext = oContext || this.oContext;
+		oContext ??= this.oContext;
 		if (!oContext) {
 			return SyncPromise.resolve();
 		}
@@ -981,8 +980,8 @@ sap.ui.define([
 	/**
 	 * Returns <code>true</code> if this binding or its dependent bindings have property changes,
 	 * created entities, or entity deletions which have not been sent successfully to the server.
-	 * This function does not take the execution of OData operations
-	 * (see {@link sap.ui.model.odata.v4.ODataContextBinding#execute}) into account. Since 1.98.0,
+	 * This function does not take the invocation of OData operations
+	 * (see {@link sap.ui.model.odata.v4.ODataContextBinding#invoke}) into account. Since 1.98.0,
 	 * {@link sap.ui.model.odata.v4.Context#isInactive inactive} contexts are ignored, unless
 	 * (since 1.100.0) their
 	 * {@link sap.ui.model.odata.v4.ODataListBinding#event:createActivate activation} has been
@@ -1159,7 +1158,7 @@ sap.ui.define([
 	 * @see sap.ui.model.odata.v4.ODataModel#lockGroup
 	 */
 	ODataBinding.prototype.lockGroup = function (sGroupId, bLocked, bModifying, fnCancel) {
-		sGroupId = sGroupId || (bModifying ? this.getUpdateGroupId() : this.getGroupId());
+		sGroupId ??= (bModifying ? this.getUpdateGroupId() : this.getGroupId());
 		return this.oModel.lockGroup(sGroupId, this, bLocked, bModifying, fnCancel);
 	};
 
@@ -1213,7 +1212,7 @@ sap.ui.define([
 	 * <code>$$ownRequest</code> parameter (see {@link sap.ui.model.odata.v4.ODataModel#bindList}
 	 * and {@link sap.ui.model.odata.v4.ODataModel#bindContext})
 	 *
-	 * Note: When calling {@link #refresh} multiple times, the result of the request triggered by
+	 * Note: When calling {@link #refresh} multiple times, the result of the request initiated by
 	 * the last call determines the binding's data; it is <b>independent</b> of the order of calls
 	 * to {@link sap.ui.model.odata.v4.ODataModel#submitBatch} with the given group ID.
 	 *
@@ -1572,12 +1571,12 @@ sap.ui.define([
 	 *
 	 * @private
 	 */
-	ODataBinding.prototype.withCache = function (fnProcessor, sPath, bSync, bWithOrWithoutCache) {
+	ODataBinding.prototype.withCache = function (fnProcessor, sPath = "", bSync = false,
+			bWithOrWithoutCache = false) {
 		var oCachePromise = bSync ? SyncPromise.resolve(this.oCache) : this.oCachePromise,
 			sRelativePath,
 			that = this;
 
-		sPath = sPath || "";
 		return oCachePromise.then(function (oCache) {
 			if (oCache) {
 				sRelativePath = that.getRelativePath(sPath);