@openui5/sap.ui.core 1.122.1 → 1.123.1

package/test/sap/ui/core/qunit/odata/v4/ODataListBinding.qunit.js

@@ -57,14 +57,14 @@ sap.ui.define([
 	 * @returns {object}
 	 *   the data
 	 */
-	function createData(iLength, iStart, bDrillDown, iCount, bKeyPredicates) {
+	// eslint-disable-next-line default-param-last
+	function createData(iLength, iStart = 0, bDrillDown, iCount, bKeyPredicates) {
 		var oData = {value : []},
 			i;
 
 		if (iCount !== undefined) {
 			oData.value.$count = iCount;
 		}
-		iStart = iStart || 0;
 		for (i = 0; i < iLength; i += 1) {
 			oData.value[i] = {
 				Name : "Name " + (iStart + i),
@@ -93,7 +93,7 @@ sap.ui.define([
 			// create ODataModel
 			this.oModel = new ODataModel({serviceUrl : "/service/?sap-client=111"});
 			this.oModel.setSizeLimit(3);
-			// ensure that the requestor does not trigger requests
+			// ensure that the requestor does not invoke requests
 			this.mock(this.oModel.oRequestor).expects("request").never();
 			// avoid that the cache requests actual metadata for faked responses
 			this.mock(this.oModel.oRequestor.oModelInterface).expects("fetchMetadata").atLeast(0)
@@ -4042,11 +4042,19 @@ sap.ui.define([
 
 			QUnit.test(sTitle, function (assert) {
 				var oBinding = this.bindList("/EMPLOYEES", {/*oContext*/}),
-					aContexts = [{}, {}, {}],
+					aContexts = [
+						{setSelected : mustBeMocked},
+						{setSelected : mustBeMocked},
+						{setSelected : mustBeMocked}
+					],
 					oContextMock = this.mock(Context),
 					i,
 					sPath,
-					aResults = [{}, {}, {}],
+					aResults = [
+						{setSelected : mustBeMocked},
+						{setSelected : mustBeMocked},
+						{setSelected : mustBeMocked}
+					],
 					iServerIndex,
 					iStart = 2;
 
@@ -4070,7 +4078,11 @@ sap.ui.define([
 						.withExactArgs(sinon.match.same(this.oModel), sinon.match.same(oBinding),
 							sPath, iServerIndex)
 						.returns(aContexts[i - iStart]);
+					this.mock(aContexts[i - iStart]).expects("setSelected")
+						.withExactArgs("~selected~");
 				}
+				this.mock(oBinding.oHeaderContext).expects("isSelected").exactly(aContexts.length)
+					.withExactArgs().returns("~selected~");
 
 				// code under test
 				assert.strictEqual(oBinding.createContexts(iStart, aResults), true);
@@ -4097,7 +4109,7 @@ sap.ui.define([
 
 			function result(iLength, iCount) {
 				// only active created contexts add to $count
-				iCount = iCount && iCount + (bCreated ? 1 : 0);
+				iCount &&= iCount + (bCreated ? 1 : 0);
 				return createData(iLength, 0, true, iCount);
 			}
 
@@ -4226,7 +4238,7 @@ sap.ui.define([
 		var oBinding = this.bindList("/EMPLOYEES", {/*oContext*/}),
 			oContext1 = Context.create(this.oModel, oBinding, "/EMPLOYEES/1", 1),
 			oContext2 = Context.create(this.oModel, oBinding, "/EMPLOYEES/2", 2),
-			oContext3 = {},
+			oContext3 = {setSelected : mustBeMocked},
 			oContextMock = this.mock(Context);
 
 		oBinding.mPreviousContextsByPath = {
@@ -4240,6 +4252,9 @@ sap.ui.define([
 			.withExactArgs(sinon.match.same(this.oModel), sinon.match.same(oBinding),
 				"/EMPLOYEES/3", 3)
 			.returns(oContext3);
+		this.mock(oBinding.oHeaderContext).expects("isSelected")
+			.withExactArgs().returns("~selected~");
+		this.mock(oContext3).expects("setSelected").withExactArgs("~selected~");
 		this.mock(this.oModel).expects("addPrerenderingTask")
 			.withExactArgs(sinon.match.func).callsArg(0);
 		this.mock(oBinding).expects("destroyPreviousContexts").withExactArgs(["/EMPLOYEES/0"]);
@@ -4329,7 +4344,7 @@ sap.ui.define([
 		var oBinding = this.bindList("/EMPLOYEES"),
 			oCreatedContext = Context.create(this.oModel, oBinding, "/EMPLOYEES('1')", -1,
 				SyncPromise.resolve()),
-			oNewContext = {};
+			oNewContext = {setSelected : mustBeMocked};
 
 		oBinding.mPreviousContextsByPath = {
 			"/EMPLOYEES('1')" : oCreatedContext
@@ -4339,6 +4354,9 @@ sap.ui.define([
 			.withExactArgs(sinon.match.same(this.oModel), sinon.match.same(oBinding),
 				"/EMPLOYEES('1')", 0)
 			.returns(oNewContext);
+		this.mock(oBinding.oHeaderContext).expects("isSelected")
+			.withExactArgs().returns("~selected~");
+		this.mock(oNewContext).expects("setSelected").withExactArgs("~selected~");
 		this.mock(this.oModel).expects("addPrerenderingTask")
 			.withExactArgs(sinon.match.func).callsArg(0);
 		this.mock(oCreatedContext).expects("destroy").withExactArgs();
@@ -4735,25 +4753,6 @@ sap.ui.define([
 	});
 });
 
-	//*********************************************************************************************
-	QUnit.test("_delete: recursive hierarchy, restrictions not met", function (assert) {
-		const oBinding = this.bindList("/EMPLOYEES");
-
-		// Note: autoExpandSelect at model would be required for hierarchyQualifier, but that leads
-		// too far :-(
-		oBinding.mParameters.$$aggregation = {hierarchyQualifier : "X"};
-
-		const oContext = {
-			// noIndex
-			toString : function () { return "~toString~"; } // cannot be mocked?
-		};
-
-		assert.throws(function () {
-			// code under test
-			oBinding.delete("~oGroupLock~", "~sEditUrl~", oContext);
-		}, new Error("Unsupported kept-alive context: ~toString~"));
-	});
-
 	//*********************************************************************************************
 	QUnit.test("create: callbacks and eventing", function (assert) {
 		var oBinding = this.bindList("/EMPLOYEES"),
@@ -5361,12 +5360,14 @@ sap.ui.define([
 					created : function () {},
 					fetchValue : function () {},
 					getPath : function () {},
+					setSelected : mustBeMocked,
 					updateAfterCreate : function () {}
 				},
 				oNewContext1 = {
 					created : function () {},
 					fetchValue : function () {},
 					getPath : function () {},
+					setSelected : mustBeMocked,
 					updateAfterCreate : function () {}
 				},
 				bNotAllowed = aAtEnd[0] && !aAtEnd[1],
@@ -5399,6 +5400,9 @@ sap.ui.define([
 					oNewContext0.oCreatedPromise = Promise.resolve(arguments[4]);
 					return oNewContext0;
 				});
+			this.mock(oBinding.oHeaderContext).expects("isSelected").exactly(bNotAllowed ? 1 : 2)
+				.withExactArgs().returns("~selected~");
+			this.mock(oNewContext0).expects("setSelected").withExactArgs("~selected~");
 			this.mock(oNewContext0).expects("created").exactly(bTransient ? 1 : 0)
 				.withExactArgs()
 				.callsFake(function () {
@@ -5451,6 +5455,7 @@ sap.ui.define([
 						oNewContext1.oCreatedPromise = Promise.resolve(arguments[4]);
 						return oNewContext1;
 					});
+				this.mock(oNewContext1).expects("setSelected").withExactArgs("~selected~");
 				this.mock(oNewContext1).expects("created").exactly(bTransient ? 1 : 0)
 					.withExactArgs()
 					.callsFake(function () {
@@ -5518,6 +5523,7 @@ sap.ui.define([
 				created : function () {},
 				fetchValue : function () {},
 				getPath : function () { return ""; },
+				setSelected : mustBeMocked,
 				refreshDependentBindings : function () {}
 			};
 
@@ -5535,6 +5541,9 @@ sap.ui.define([
 				sinon.match.same(oBinding), sinon.match.string, -oBinding.iCreatedContexts - 1,
 				sinon.match.instanceOf(SyncPromise), undefined)
 			.returns(oNewContext);
+		this.mock(oBinding.oHeaderContext).expects("isSelected")
+			.withExactArgs().returns("~selected~");
+		this.mock(oNewContext).expects("setSelected").withExactArgs("~selected~");
 		this.mock(oNewContext).expects("fetchValue").withExactArgs().resolves(undefined);
 		this.mock(_Helper).expects("setPrivateAnnotation").never();
 
@@ -5704,12 +5713,15 @@ sap.ui.define([
 					.and(sinon.match({"@$ui5.node.parent" : "canonical/path"})),
 				false, sinon.match.func, sinon.match.func)
 			.returns(SyncPromise.resolve(Promise.resolve("~oCreatedEntity~")));
-		const oContext = {fetchValue : mustBeMocked};
+		const oContext = {fetchValue : mustBeMocked, setSelected : mustBeMocked};
 		this.mock(Context).expects("create")
 			.withExactArgs(sinon.match.same(this.oModel), sinon.match.same(oBinding),
 				"~sResolvedPath~($uid=id-1-23)", /*iChildIndex*/3,
 				sinon.match.instanceOf(SyncPromise), undefined)
 			.returns(oContext);
+		this.mock(oBinding.oHeaderContext).expects("isSelected")
+			.withExactArgs().returns("~selected~");
+		this.mock(oContext).expects("setSelected").withExactArgs("~selected~");
 		this.mock(oContext).expects("fetchValue").withExactArgs()
 			.returns(SyncPromise.resolve()); //TODO
 		this.mock(oBinding).expects("_fireChange")
@@ -5758,12 +5770,15 @@ sap.ui.define([
 				sinon.match(rTransientPredicate), "~oEntityData~",
 				false, sinon.match.func, sinon.match.func)
 			.returns(SyncPromise.resolve(Promise.resolve("~oCreatedEntity~")));
-		const oContext = {fetchValue : mustBeMocked};
+		const oContext = {fetchValue : mustBeMocked, setSelected : mustBeMocked};
 		this.mock(Context).expects("create")
 			.withExactArgs(sinon.match.same(this.oModel), sinon.match.same(oBinding),
 				"~sResolvedPath~($uid=id-1-23)", /*iChildIndex*/0,
 				sinon.match.instanceOf(SyncPromise), undefined)
 			.returns(oContext);
+		this.mock(oBinding.oHeaderContext).expects("isSelected")
+			.withExactArgs().returns("~selected~");
+		this.mock(oContext).expects("setSelected").withExactArgs("~selected~");
 		this.mock(oContext).expects("fetchValue").withExactArgs()
 			.returns(SyncPromise.resolve()); //TODO
 		this.mock(oBinding).expects("_fireChange")
@@ -10223,21 +10238,9 @@ sap.ui.define([
 	//*********************************************************************************************
 [false, true].forEach(function (bFireChange) {
 	QUnit.test("getAllCurrentContexts: bFireChange = " + bFireChange, function (assert) {
-		var aAllCurrentContexts,
-			oBinding = this.bindList("/EMPLOYEES"),
-			oCache = {
-				getAllElements : function () {}
-			},
-			oKeptContext0 = {isEffectivelyKeptAlive : function () {}},
-			oKeptContext1 = {isEffectivelyKeptAlive : function () {}},
-			oNotKeptContext = {isEffectivelyKeptAlive : function () {}}; // BCP 2270081950:
-			// there is a point in time when contexts with keepAlive=false are present in
-			// mPreviousContextsByPath which need be filtered out.
-
-		oBinding.mPreviousContextsByPath = {
-			"~sPath1~" : oKeptContext0,
-			"~sPath2~" : oKeptContext1,
-			"~sPath3~" : oNotKeptContext
+		const oBinding = this.bindList("/EMPLOYEES");
+		const oCache = {
+			getAllElements : function () {}
 		};
 
 		this.mock(oBinding).expects("withCache").withExactArgs(sinon.match.func, "", true)
@@ -10245,46 +10248,61 @@ sap.ui.define([
 		this.mock(oCache).expects("getAllElements").withExactArgs("path/to/cache")
 			.returns("~aElements~");
 		this.mock(oBinding).expects("createContexts").withExactArgs(0, "~aElements~")
-			.callsFake(function () {
-				oBinding.aContexts = ["~oContext0~", undefined, "~oContext2~"];
-				return bFireChange;
-			});
+			.returns(bFireChange);
 		this.mock(oBinding).expects("_fireChange").withExactArgs({reason : ChangeReason.Change})
 			.exactly(bFireChange ? 1 : 0);
 
-		this.mock(oKeptContext0).expects("isEffectivelyKeptAlive").withExactArgs().returns(true);
-		this.mock(oKeptContext1).expects("isEffectivelyKeptAlive").withExactArgs().returns(true);
-		this.mock(oNotKeptContext).expects("isEffectivelyKeptAlive").withExactArgs().returns(false);
+		this.mock(oBinding).expects("_getAllExistingContexts").withExactArgs()
+			.returns("~aContexts~");
 
 		// code under test
-		aAllCurrentContexts = oBinding.getAllCurrentContexts();
-
-		assert.deepEqual(aAllCurrentContexts,
-			["~oContext0~", "~oContext2~", oKeptContext0, oKeptContext1]);
-		assert.strictEqual(aAllCurrentContexts[2], oKeptContext0);
-		assert.strictEqual(aAllCurrentContexts[3], oKeptContext1);
+		assert.deepEqual(oBinding.getAllCurrentContexts(), "~aContexts~");
 	});
 });
 
 	//*********************************************************************************************
 	QUnit.test("getAllCurrentContexts: currently no cache", function (assert) {
 		const oBinding = this.bindList("relativePath");
-		oBinding.aContexts = ["~oTransientContext~"];
-
-		const oKeptContext = {isEffectivelyKeptAlive : function () {}};
-		oBinding.mPreviousContextsByPath = {"~sPath~" : oKeptContext};
 
 		this.mock(oBinding).expects("withCache").withExactArgs(sinon.match.func, "", true);
 		this.mock(oBinding).expects("createContexts").never();
 		this.mock(oBinding).expects("_fireChange").never();
-		this.mock(oKeptContext).expects("isEffectivelyKeptAlive").withExactArgs().returns(true);
+		this.mock(oBinding).expects("_getAllExistingContexts").withExactArgs()
+			.returns("~aResults~");
 
 		// code under test
 		const aContexts = oBinding.getAllCurrentContexts();
 
-		assert.strictEqual(aContexts.length, 2);
+		assert.strictEqual(aContexts, "~aResults~");
+	});
+
+	//*********************************************************************************************
+	QUnit.test("_getAllExistingContexts", function (assert) {
+		const oBinding = this.bindList("relativePath");
+		oBinding.aContexts = [/*empty*/, undefined, "~oTransientContext~"];
+		const oKeptContext0 = {isEffectivelyKeptAlive : function () {}};
+		const oKeptContext1 = {isEffectivelyKeptAlive : function () {}};
+		const oNotKeptContext = {isEffectivelyKeptAlive : function () {}}; // BCP 2270081950:
+		// there is a point in time when contexts with keepAlive=false are present in
+		// mPreviousContextsByPath which need be filtered out.
+
+		oBinding.mPreviousContextsByPath = {
+			"~sPath1~" : oKeptContext0,
+			"~sPath2~" : oKeptContext1,
+			"~sPath3~" : oNotKeptContext
+		};
+
+		this.mock(oKeptContext0).expects("isEffectivelyKeptAlive").withExactArgs().returns(true);
+		this.mock(oKeptContext1).expects("isEffectivelyKeptAlive").withExactArgs().returns(true);
+		this.mock(oNotKeptContext).expects("isEffectivelyKeptAlive").withExactArgs().returns(false);
+
+		// code under test
+		const aContexts = oBinding._getAllExistingContexts();
+
+		assert.strictEqual(aContexts.length, 3);
 		assert.strictEqual(aContexts[0], "~oTransientContext~");
-		assert.strictEqual(aContexts[1], oKeptContext);
+		assert.strictEqual(aContexts[1], oKeptContext0);
+		assert.strictEqual(aContexts[2], oKeptContext1);
 	});
 
 	//*********************************************************************************************
@@ -10860,7 +10878,7 @@ sap.ui.define([
 
 	//*********************************************************************************************
 [false, true].forEach((bCreated) => {
-	[-1, +1, 0].forEach((iDirection) => { // child is before or after parent (or right in place)
+	[-1, +1, 0].forEach((iDirection) => { // child starts before or after target (or right in place)
 		[false, true].forEach((bIsExpanded) => {
 			[1, 4].forEach((iCount) => {
 				[1, Number.MAX_SAFE_INTEGER, 1E16].forEach((iExpandTo) => {
@@ -10868,24 +10886,27 @@ sap.ui.define([
 	const sTitle = `move: created=${bCreated}, direction=${iDirection}, expanded=${bIsExpanded},
 child nodes added=${iCount}, expandTo=${iExpandTo}, make root=${bMakeRoot}`;
 
-	if (bMakeRoot && (iDirection < 0 || iCount > 1)) {
+	if (bMakeRoot && (iDirection < 0 && iExpandTo === 1 || iCount > 1)) {
 		return;
 	}
 
 	QUnit.test(sTitle, function (assert) {
 		const iParentIndex = bMakeRoot ? -1 : 42;
-		let iChildIndex = iParentIndex + 1;
+		let iNewIndex = iExpandTo > 1 ? 42 : iParentIndex + 1;
+		let iOldIndex = iNewIndex;
 		if (iDirection < 0) {
-			iChildIndex = 23;
+			iOldIndex = 23;
 		} else if (iDirection > 0) {
-			iChildIndex = 64;
+			iOldIndex = 64;
 		}
 		const oChildContext = {
-			iIndex : iChildIndex,
+			iIndex : iOldIndex,
 			created : mustBeMocked,
 			getCanonicalPath : mustBeMocked,
+			getModelIndex : mustBeMocked,
 			isExpanded : mustBeMocked,
-			setCreatedPersisted : mustBeMocked
+			setCreatedPersisted : mustBeMocked,
+			setPersisted : mustBeMocked
 		};
 		this.mock(oChildContext).expects("isExpanded").withExactArgs().returns(bIsExpanded);
 		this.mock(oChildContext).expects("getCanonicalPath").withExactArgs().returns("/~child~");
@@ -10916,31 +10937,35 @@ child nodes added=${iCount}, expandTo=${iExpandTo}, make root=${bMakeRoot}`;
 			.returns(new SyncPromise((resolve) => {
 				setTimeout(() => {
 					if (oParentContext) {
-						this.mock(oParentContext).expects("getModelIndex")
-							.exactly(iCount > 1 ? 1 : 0).withExactArgs().returns("~iModelIndex~");
+						this.mock(oParentContext).expects("getModelIndex").atLeast(0)
+							.withExactArgs().returns(iParentIndex);
 					}
 					this.mock(oBinding).expects("insertGap").exactly(iCount > 1 ? 1 : 0)
-						.withExactArgs("~iModelIndex~", iCount - 1);
+						.withExactArgs(iParentIndex, iCount - 1);
 					for (let i = 0; i < 100; i += 1) {
 						if (i % 5) {
 							oBinding.aContexts[i] = {iIndex : i};
 						} // else: leave some gaps ;-)
 					}
-					oBinding.aContexts[iChildIndex] = oChildContext;
-					if (oParentContext) {
+					this.mock(oChildContext).expects("getModelIndex").withExactArgs()
+						.returns(iOldIndex);
+					oBinding.aContexts[iOldIndex] = oChildContext;
+					if (oParentContext && iExpandTo === 1) {
 						oBinding.aContexts[iParentIndex] = oParentContext;
 					}
 					this.mock(oChildContext).expects("created").withExactArgs()
 						.returns(bCreated ? {/*Promise*/} : undefined);
 					this.mock(oChildContext).expects("setCreatedPersisted")
-						.exactly(bCreated || iExpandTo > 1 ? 0 : 1).withExactArgs();
+						.exactly(!bCreated && iExpandTo === 1 ? 1 : 0).withExactArgs();
+					this.mock(oChildContext).expects("setPersisted")
+						.exactly(bCreated && iExpandTo > 1 ? 1 : 0).withExactArgs();
 					this.mock(oBinding).expects("expand").exactly(bIsExpanded ? 1 : 0)
 						.withExactArgs(sinon.match.same(oChildContext))
 						.returns(SyncPromise.resolve());
 					this.mock(oBinding).expects("_fireChange").exactly(bIsExpanded ? 0 : 1)
 						.withExactArgs({reason : ChangeReason.Change});
 
-					resolve(iCount);
+					resolve(iExpandTo > 1 ? [iCount, iNewIndex] : [iCount]);
 				}, 0);
 			}));
 
@@ -10950,12 +10975,15 @@ child nodes added=${iCount}, expandTo=${iExpandTo}, make root=${bMakeRoot}`;
 		assert.strictEqual(oSyncPromise.isPending(), true);
 
 		return oSyncPromise.then(function (vResult) {
-			const iNewParentIndex = iDirection < 0 ? iParentIndex - 1 : iParentIndex;
 			assert.strictEqual(vResult, undefined, "without a defined result");
-			if (oParentContext) {
-				assert.strictEqual(oBinding.aContexts[iNewParentIndex], oParentContext);
+			if (iExpandTo === 1) {
+				const iNewParentIndex = iDirection < 0 ? iParentIndex - 1 : iParentIndex;
+				if (oParentContext) {
+					assert.strictEqual(oBinding.aContexts[iNewParentIndex], oParentContext);
+				}
+				iNewIndex = iNewParentIndex + 1;
 			}
-			assert.strictEqual(oBinding.aContexts[iNewParentIndex + 1], oChildContext);
+			assert.strictEqual(oBinding.aContexts[iNewIndex], oChildContext);
 			for (let i = 0; i < 100; i += 1) {
 				if (oBinding.aContexts[i]) {
 					assert.strictEqual(oBinding.aContexts[i].iIndex, i, `iIndex @ ${i}`);
@@ -11030,13 +11058,15 @@ child nodes added=${iCount}, expandTo=${iExpandTo}, make root=${bMakeRoot}`;
 			iIndex : 43,
 			created : mustBeMocked,
 			getCanonicalPath : mustBeMocked,
+			getModelIndex : mustBeMocked,
 			isExpanded : mustBeMocked
 		};
 		this.mock(oChildContext).expects("isExpanded").withExactArgs().returns(true);
 		this.mock(oChildContext).expects("getCanonicalPath").withExactArgs().returns("/~child~");
 		const oParentContext = {
 			iIndex : 42,
-			getCanonicalPath : mustBeMocked
+			getCanonicalPath : mustBeMocked,
+			getModelIndex : mustBeMocked
 		};
 		this.mock(oParentContext).expects("getCanonicalPath").withExactArgs().returns("/~parent~");
 		const oBinding = this.bindList("/EMPLOYEES");
@@ -11053,10 +11083,10 @@ child nodes added=${iCount}, expandTo=${iExpandTo}, make root=${bMakeRoot}`;
 		};
 		oBinding.oCache = oCache;
 		this.mock(oCache).expects("move").withExactArgs("~oGroupLock~", "~child~", "~parent~")
-			.returns(SyncPromise.resolve(1));
+			.returns(SyncPromise.resolve([1]));
 		this.mock(oBinding).expects("insertGap").never();
-		oBinding.aContexts[43] = oChildContext;
-		oBinding.aContexts[42] = oParentContext;
+		this.mock(oChildContext).expects("getModelIndex").withExactArgs().returns(43);
+		this.mock(oParentContext).expects("getModelIndex").withExactArgs().returns(42);
 		this.mock(oChildContext).expects("created").withExactArgs().returns(true);
 		this.mock(oBinding).expects("expand")
 			.withExactArgs(sinon.match.same(oChildContext))

package/test/sap/ui/core/qunit/odata/v4/ODataMetaModel.qunit.js

@@ -2676,7 +2676,7 @@ sap.ui.define([
 				assert.strictEqual(that.oMetaModel.getObject("/tea_busi_supplier.v0001."),
 					mReferencedScope["tea_busi_supplier.v0001."]);
 
-				// now check that "not.found." does not trigger another read(),
+				// now check that "not.found." does not invoke another read(),
 				// does finish synchronously and logs a warning
 				that.oLogMock.expects("warning").exactly(bWarn ? 1 : 0)
 					.withExactArgs("/a/default/iwbep/tea_busi_product/0001/$metadata"
@@ -2799,7 +2799,7 @@ sap.ui.define([
 					.then(function (vResult) {
 						assert.strictEqual(vResult, mScopeA["A."]);
 
-						// Note: must not trigger read() again!
+						// Note: must not invoke read() again!
 						return that.oMetaModel.fetchObject("/B.B.")
 							.then(function (vResult) {
 								assert.strictEqual(vResult, mScopeB["B.B."]);
@@ -2920,7 +2920,7 @@ sap.ui.define([
 			delete oProperty.__constraints;
 			if (!bNullable) {
 				oProperty.$Nullable = false;
-				oConstraints = oConstraints || {};
+				oConstraints ??= {};
 				oConstraints.nullable = false;
 			}