@openui5/sap.ui.core 1.122.1 → 1.123.1

package/test/sap/ui/core/qunit/odata/v2/ODataPropertyBinding.qunit.js

@@ -1,13 +1,11 @@
 /*global QUnit, sinon*/
 sap.ui.define([
 	"test-resources/sap/ui/core/qunit/odata/data/ODataModelFakeService",
-	"sap/ui/model/odata/v2/ODataModel",
-	"sap/m/Text"
-], function(
-		fakeService,
-		ODataModel,
-		Text
-	) {
+	"sap/m/Text",
+	'sap/ui/model/ChangeReason',
+	"sap/ui/model/odata/ODataPropertyBinding",
+	"sap/ui/model/odata/v2/ODataModel"
+], function(fakeService, Text, ChangeReason, ODataPropertyBinding, ODataModel) {
 
 	"use strict";
 	// time to wait for server responses
@@ -120,4 +118,77 @@ sap.ui.define([
 			});
 		});
 	});
+
+	//*********************************************************************************************
+	QUnit.test("setValue: bSuspended = true", function(assert) {
+		const oBinding = {bSuspended: true};
+
+		// code under test
+		ODataPropertyBinding.prototype.setValue.call(oBinding, "~vValue");
+
+		assert.strictEqual(oBinding.oValue, undefined);
+	});
+
+	//*********************************************************************************************
+["~sValue", 1, {"ms": 12345}, undefined].forEach(function(vValue, i) {
+	QUnit.test("setValue: new value = old value " + i, function(assert) {
+		const oBinding = {oValue: vValue};
+
+		// code under test
+		ODataPropertyBinding.prototype.setValue.call(oBinding, vValue);
+
+		assert.strictEqual(oBinding.oValue, vValue);
+	});
+});
+
+	//*********************************************************************************************
+	QUnit.test("setValue: ODataModel#setProperty returns false", function(assert) {
+		const oBinding = {
+			oContext: "~oContext",
+			oModel: {
+				setProperty() {}
+			},
+			sPath: "~sPath",
+			oValue: "~oOldValue"
+		};
+		this.mock(oBinding.oModel).expects("setProperty")
+			.withExactArgs("~sPath", "~oNewValue", "~oContext", true)
+			.returns(false);
+
+		// code under test
+		ODataPropertyBinding.prototype.setValue.call(oBinding, "~oNewValue");
+
+		assert.strictEqual(oBinding.oValue, "~oOldValue");
+	});
+
+	//*********************************************************************************************
+	QUnit.test("setValue", function(assert) {
+		const oBinding = {
+			oContext: "~oContext",
+			oModel: {
+				firePropertyChange() {},
+				setProperty() {}
+			},
+			sPath: "~sPath",
+			oValue: "~oValue",
+			getDataState() {}
+		};
+		const oModelMock = this.mock(oBinding.oModel);
+		oModelMock.expects("setProperty").withExactArgs("~sPath", "~oNewValue", "~oContext", true).returns(true);
+		const oDataState = {setValue() {}};
+		this.mock(oBinding).expects("getDataState").withExactArgs().returns(oDataState);
+		this.mock(oDataState).expects("setValue").withExactArgs("~oNewValue");
+		oModelMock.expects("firePropertyChange")
+			.withExactArgs({
+				reason: ChangeReason.Binding,
+				path: "~sPath",
+				context: "~oContext",
+				value: "~oNewValue"
+			});
+
+		// code under test
+		ODataPropertyBinding.prototype.setValue.call(oBinding, "~oNewValue");
+
+		assert.strictEqual(oBinding.oValue, "~oNewValue");
+	});
 });

package/test/sap/ui/core/qunit/odata/v4/Context.qunit.js

@@ -90,6 +90,10 @@ sap.ui.define([
 			// code under test
 			oContext.setCreatedPersisted();
 		}, new Error("Already 'created', currently transient: true"));
+		assert.throws(function () {
+			// code under test
+			oContext.setPersisted();
+		}, new Error("Not 'created persisted'"));
 
 		fnResolve("bar");
 		return oCreatedPromise.then(function () {
@@ -104,6 +108,7 @@ sap.ui.define([
 		// code under test
 		oContext.setCreatedPersisted();
 
+		assert.strictEqual(oContext.isInactive(), undefined);
 		assert.strictEqual(oContext.isTransient(), false);
 		assert.ok(oContext.created() instanceof Promise);
 
@@ -117,6 +122,25 @@ sap.ui.define([
 		});
 	});
 
+	//*********************************************************************************************
+	QUnit.test("setPersisted", function (assert) {
+		const oContext
+			= Context.create({/*oModel*/}, {/*oBinding*/}, "/foo", 42, SyncPromise.resolve());
+		oContext.bInactive = false; // "was created in an inactive state and has been activated"
+
+		// code under test
+		oContext.setPersisted();
+
+		assert.strictEqual(oContext.isInactive(), undefined);
+		assert.strictEqual(oContext.isTransient(), undefined);
+		assert.strictEqual(oContext.created(), undefined);
+
+		assert.throws(function () {
+			// code under test
+			oContext.setPersisted();
+		}, new Error("Not 'created persisted'"));
+	});
+
 	//*********************************************************************************************
 	QUnit.test("getGeneration: after Context.createNewContext", function (assert) {
 		var oBinding = {},
@@ -1212,7 +1236,8 @@ sap.ui.define([
 [
 	{transient : false, groupId : "myGroup"},
 	{transient : true, groupId : "myGroup"},
-	{transient : true, groupId : null}
+	{transient : true, groupId : null},
+	{transient : true, groupId : null, hierarchy : true}
 ].forEach(function (oFixture) {
 	QUnit.test("delete: success " + JSON.stringify(oFixture), function (assert) {
 		var oBinding = {
@@ -1221,7 +1246,7 @@ sap.ui.define([
 				getHeaderContext : function () {},
 				lockGroup : function () {},
 				onKeepAliveChanged : function () {},
-				mParameters : "~mParameters~"
+				mParameters : {}
 			},
 			oContext = Context.create("~oModel~", oBinding, "/Foo/Bar('42')", 42,
 				oFixture.transient ? new SyncPromise(function () {}) : /*oCreatePromise*/undefined),
@@ -1229,9 +1254,12 @@ sap.ui.define([
 			oExpectation,
 			bSelected = !!oFixture.groupId;
 
+		if (oFixture.hierarchy) {
+			oBinding.mParameters.$$aggregation = {hierarchyQualifier : "X"};
+		}
 		oContext.bSelected = bSelected;
 		this.mock(_Helper).expects("isDataAggregation")
-			.withExactArgs("~mParameters~").returns(false);
+			.withExactArgs(sinon.match.same(oBinding.mParameters)).returns(false);
 		this.mock(oBinding).expects("checkSuspended").withExactArgs();
 		this.mock(_Helper).expects("checkGroupId").exactly(oFixture.transient ? 0 : 1)
 			.withExactArgs("myGroup", false, true);
@@ -1317,16 +1345,20 @@ sap.ui.define([
 				checkSuspended : function () {},
 				delete : function () {},
 				lockGroup : function () {},
-				mParameters : "~mParameters~"
+				mParameters : {$$aggregation : {hierarchyQualifier : "X"}}
+			},
+			oModel = {
+				isApiGroup : mustBeMocked
 			},
-			oContext = Context.create("~oModel~", oBinding, "/Foo/Bar('42')", 42),
+			oContext = Context.create(oModel, oBinding, "/Foo/Bar('42')", 42),
 			oGroupLock = {
 				unlock : function () {}
 			};
 
 		this.mock(_Helper).expects("isDataAggregation")
-			.withExactArgs("~mParameters~").returns(false);
+			.withExactArgs(sinon.match.same(oBinding.mParameters)).returns(false);
 		this.mock(oBinding).expects("checkSuspended").withExactArgs();
+		this.mock(oModel).expects("isApiGroup").withExactArgs("myGroup").returns(false);
 		this.mock(_Helper).expects("checkGroupId").withExactArgs("myGroup", false, true);
 		this.mock(oContext).expects("fetchCanonicalPath").withExactArgs()
 			.returns(SyncPromise.reject("~oError~"));
@@ -1359,6 +1391,40 @@ sap.ui.define([
 		}, new Error("Cannot delete " + oContext + " when using data aggregation"));
 	});
 
+	//*********************************************************************************************
+	QUnit.test("delete: recursive hierarchy, restrictions not met", function (assert) {
+		const oBinding = {
+			checkSuspended : function () {},
+			getUpdateGroupId : mustBeMocked,
+			mParameters : {$$aggregation : {hierarchyQualifier : "X"}}
+		};
+		const oModel = {
+			isApiGroup : mustBeMocked
+		};
+
+		const oContext = Context.create(oModel, oBinding, "/EMPLOYEES/42");
+		assert.throws(function () {
+			// code under test
+			oContext.delete();
+		}, new Error("Unsupported kept-alive context: " + oContext));
+
+		oContext.iIndex = 42;
+		this.mock(oBinding).expects("getUpdateGroupId").withExactArgs().returns("~groupId~");
+		this.mock(oModel).expects("isApiGroup").twice().withExactArgs("~groupId~").returns(true);
+
+		assert.throws(function () {
+			// code under test
+			oContext.delete();
+		}, new Error("Unsupported group ID: ~groupId~"));
+
+		oContext.iIndex = 0;
+
+		assert.throws(function () {
+			// code under test
+			oContext.delete("~groupId~");
+		}, new Error("Unsupported group ID: ~groupId~"));
+	});
+
 	//*********************************************************************************************
 	QUnit.test("delete: no lock, but not a kept-alive context", function (assert) {
 		var oBinding = {
@@ -2126,8 +2192,11 @@ sap.ui.define([
 		const oBinding = {
 			move : mustBeMocked
 		};
-		const oContext = Context.create({/*oModel*/}, oBinding, "/EMPLOYEES('42')");
+		const oContext = Context.create({/*oModel*/}, oBinding, "/EMPLOYEES('42')", 42);
 		let bResolved = false;
+		this.stub(oContext, "toString"); // called by SinonJS, would call #isTransient :-(
+		this.mock(oContext).expects("isDeleted").withExactArgs().returns(false);
+		this.mock(oContext).expects("isTransient").withExactArgs().returns(false);
 		this.mock(oContext).expects("isAncestorOf").withExactArgs(i ? null : "~oParent~")
 			.returns(false);
 		this.mock(oBinding).expects("move")
@@ -2169,21 +2238,29 @@ sap.ui.define([
 });
 
 	//*********************************************************************************************
-	QUnit.test("move: fails", function (assert) {
-		const oBinding = {
-			move : mustBeMocked
-		};
-		const oContext = Context.create({/*oModel*/}, oBinding, "/EMPLOYEES('42')");
-
-		const oContextMock = this.mock(oContext);
-		oContextMock.expects("isAncestorOf").withExactArgs("~oParent~").returns(true);
+	QUnit.test("move: Unsupported parent context", function (assert) {
+		const oContext = Context.create({/*oModel*/}, {/*oBinding*/}, "/EMPLOYEES('42')", 42);
+		this.stub(oContext, "toString"); // called by SinonJS, would call #isTransient :-(
+		this.mock(oContext).expects("isDeleted").withExactArgs().returns(false);
+		this.mock(oContext).expects("isTransient").withExactArgs().returns(false);
+		this.mock(oContext).expects("isAncestorOf").withExactArgs("~oParent~").returns(true);
 
 		assert.throws(function () {
 			// code under test
 			oContext.move({parent : "~oParent~"});
 		}, new Error("Unsupported parent context: ~oParent~"));
+	});
 
-		oContextMock.expects("isAncestorOf").withExactArgs("~oParent~").returns(false);
+	//*********************************************************************************************
+	QUnit.test("move: fails", function (assert) {
+		const oBinding = {
+			move : mustBeMocked
+		};
+		const oContext = Context.create({/*oModel*/}, oBinding, "/EMPLOYEES('42')", 42);
+		this.stub(oContext, "toString"); // called by SinonJS, would call #isTransient :-(
+		this.mock(oContext).expects("isDeleted").withExactArgs().returns(false);
+		this.mock(oContext).expects("isTransient").withExactArgs().returns(false);
+		this.mock(oContext).expects("isAncestorOf").withExactArgs("~oParent~").returns(false);
 		this.mock(oBinding).expects("move").withExactArgs(sinon.match.same(oContext), "~oParent~")
 			.returns(SyncPromise.reject("~error~"));
 
@@ -2198,6 +2275,44 @@ sap.ui.define([
 		});
 	});
 
+	//*********************************************************************************************
+	QUnit.test("move: Cannot move; deleted", function (assert) {
+		const oContext = Context.create({/*oModel*/}, {/*oBinding*/}, "/EMPLOYEES('42')", 42);
+		// Note: cannot easily mock #toString which calls #isDeleted etc.
+		this.mock(oContext).expects("isDeleted").withExactArgs().atLeast(1).returns(true);
+
+		assert.throws(function () {
+			// code under test
+			oContext.move();
+		}, new Error("Cannot move " + oContext));
+	});
+
+	//*********************************************************************************************
+	QUnit.test("move: Cannot move; transient", function (assert) {
+		const oContext = Context.create({/*oModel*/}, {/*oBinding*/}, "/EMPLOYEES('42')", 42);
+		// Note: cannot easily mock #toString which calls #isDeleted etc.
+		this.mock(oContext).expects("isDeleted").withExactArgs().atLeast(1).returns(false);
+		this.mock(oContext).expects("isTransient").withExactArgs().atLeast(1).returns(true);
+
+		assert.throws(function () {
+			// code under test
+			oContext.move();
+		}, new Error("Cannot move " + oContext));
+	});
+
+	//*********************************************************************************************
+	QUnit.test("move: Cannot move; outside collection", function (assert) {
+		const oContext = Context.create({/*oModel*/}, {/*oBinding*/}, "/EMPLOYEES('42')");
+		// Note: cannot easily mock #toString which calls #isDeleted etc.
+		this.mock(oContext).expects("isDeleted").withExactArgs().atLeast(1).returns(false);
+		this.mock(oContext).expects("isTransient").withExactArgs().atLeast(1).returns(false);
+
+		assert.throws(function () {
+			// code under test
+			oContext.move();
+		}, new Error("Cannot move " + oContext));
+	});
+
 	//*********************************************************************************************
 	QUnit.test("patch", function (assert) {
 		var oCache = {
@@ -4458,11 +4573,21 @@ sap.ui.define([
 [false, true].forEach(function (bHasChangeListeners) {
 	QUnit.test("setSelected: with change listeners=" + bHasChangeListeners, function () {
 		const oCache = {setProperty : mustBeMocked};
-		const oBinding = {getHeaderContext : "~function~"};
+		const oBinding = {getHeaderContext : "~function~", _getAllExistingContexts : mustBeMocked};
 		// Note: oBinding is optional, it might already be missing in certain cases!
 		const oContext = Context.create({/*oModel*/}, oBinding, "/some/path", 42);
+		const aRowContexts = [
+			{setSelected : mustBeMocked},
+			{setSelected : mustBeMocked}
+		];
+
 		if (bHasChangeListeners) {
 			oContext.mChangeListeners = "~mChangeListeners~";
+			this.mock(oBinding).expects("_getAllExistingContexts").withExactArgs()
+				.returns(aRowContexts);
+			aRowContexts.forEach((oRowContext) => {
+				this.mock(oRowContext).expects("setSelected").withExactArgs("~selected~");
+			});
 		}
 
 		this.mock(oContext).expects("isDeleted").withExactArgs().returns(false);