@openui5/sap.ui.core 1.118.0 → 1.119.1

package/test/sap/ui/core/qunit/mvc/testdata/TypedViewWithRendererRenderer.js

@@ -1,8 +1,8 @@
 /*!
  * ${copyright}
  */
-sap.ui.define(["sap/ui/core/mvc/JSViewRenderer"], function(JSViewRenderer) {
+sap.ui.define(["sap/ui/core/mvc/ViewRenderer"], function(ViewRenderer) {
 	"use strict";
 
-	return JSViewRenderer;
+	return ViewRenderer;
 });

package/test/sap/ui/core/qunit/mvc/testdata/stashed/manifest.json

@@ -17,7 +17,8 @@
 	"sap.ui5": {
 		"dependencies": {
 			"libs": {
-				"sap.m": {}
+				"sap.m": {},
+				"sap.ui.core": {}
 			}
         },
         "models" : {

package/test/sap/ui/core/qunit/mvc/viewprocessing/ViewProcessing.qunit.js

@@ -3,6 +3,7 @@ sap.ui.define([
 	"sap/ui/core/mvc/Controller",
 	"sap/ui/core/UIComponent",
 	'sap/ui/core/Component',
+	"sap/ui/core/Element",
 	"sap/m/Panel",
 	"sap/m/HBox",
 	'sap/ui/core/qunit/mvc/viewprocessing/MyGlobal',
@@ -10,7 +11,7 @@ sap.ui.define([
 	"sap/ui/core/mvc/XMLView",
 	"sap/ui/core/StashedControlSupport",
 	"sap/ui/qunit/utils/nextUIUpdate"
-], function(Controller, UIComponent, Component, Panel, HBox, MyGlobal, SyncPromise, XMLView, StashedControlSupport, nextUIUpdate) {
+], function(Controller, UIComponent, Component, Element, Panel, HBox, MyGlobal, SyncPromise, XMLView, StashedControlSupport, nextUIUpdate) {
 
 	"use strict";
 
@@ -496,7 +497,7 @@ sap.ui.define([
 					assert.strictEqual(oOwnerComponent.getId(), oComponent.getId(), "Stashed Panel should have owner component");
 				}
 
-				var oStashedPanel = sap.ui.getCore().byId(oView.createId("panel"));
+				var oStashedPanel = Element.getElementById(oView.createId("panel"));
 				oOwnerComponent = Component.getOwnerComponentFor(oStashedPanel);
 				assert.ok(oOwnerComponent, "Owner Component for StashedControl of panel can be found");
 				if (oOwnerComponent) {
@@ -533,7 +534,7 @@ sap.ui.define([
 				assert.ok(oRealPanel.isA("sap.m.Panel"), "The real panel instance is created after unstash");
 
 				// check for additional stashed control inside the now unstashed panel
-				oStashedControlForButtonInPanel = sap.ui.getCore().byId(oView.createId("stashedButton"));
+				oStashedControlForButtonInPanel = Element.getElementById(oView.createId("stashedButton"));
 				oNormalButtonInStashedParent = oView.byId("normalButtonInStashedParent");
 
 				assert.ok(oStashedControlForButtonInPanel, "Stashed button in stashed area is created");

package/test/sap/ui/core/qunit/mvc/viewprocessing/ViewProcessing_legacyAPIs.qunit.js

@@ -2,6 +2,7 @@
 sap.ui.define([
 	"sap/ui/core/UIComponent",
 	'sap/ui/core/Component',
+	"sap/ui/core/Element",
 	"sap/m/Panel",
 	"sap/m/HBox",
 	'sap/ui/core/qunit/mvc/viewprocessing/MyGlobal',
@@ -9,7 +10,7 @@ sap.ui.define([
 	"sap/ui/core/mvc/XMLProcessingMode",
 	"sap/ui/core/StashedControlSupport",
 	"sap/ui/qunit/utils/nextUIUpdate"
-], function(UIComponent, Component, Panel, HBox, MyGlobal, SyncPromise, XMLProcessingMode, StashedControlSupport, nextUIUpdate) {
+], function(UIComponent, Component, Element, Panel, HBox, MyGlobal, SyncPromise, XMLProcessingMode, StashedControlSupport, nextUIUpdate) {
 
 	"use strict";
 
@@ -594,7 +595,7 @@ sap.ui.define([
 					assert.strictEqual(oOwnerComponent.getId(), oComponent.getId(), "Stashed Panel should have owner component");
 				}
 
-				var oStashedPanel = sap.ui.getCore().byId(oView.createId("panel"));
+				var oStashedPanel = Element.getElementById(oView.createId("panel"));
 				oOwnerComponent = Component.getOwnerComponentFor(oStashedPanel);
 				assert.ok(oOwnerComponent, "Owner Component for StashedControl of panel can be found");
 				if (oOwnerComponent) {
@@ -631,7 +632,7 @@ sap.ui.define([
 				assert.ok(oRealPanel.isA("sap.m.Panel"), "The real panel instance is created after unstash");
 
 				// check for additional stashed control inside the now unstashed panel
-				oStashedControlForButtonInPanel = sap.ui.getCore().byId(oView.createId("stashedButton"));
+				oStashedControlForButtonInPanel = Element.getElementById(oView.createId("stashedButton"));
 				oNormalButtonInStashedParent = oView.byId("normalButtonInStashedParent");
 
 				assert.ok(oStashedControlForButtonInPanel, "Stashed button in stashed area is created");

package/test/sap/ui/core/qunit/mvc_legacyAPIs/AsyncXMLView_legacyAPIs.qunit.js

@@ -3,6 +3,7 @@ sap.ui.define([
 	"sap/ui/base/Object",
 	"sap/ui/core/cache/CacheManager",
 	"sap/ui/core/Component",
+	"sap/ui/core/Element",
 	"sap/ui/core/mvc/View",
 	"sap/ui/core/mvc/XMLView",
 	"sap/ui/VersionInfo",
@@ -16,6 +17,7 @@ sap.ui.define([
 	BaseObject,
 	Cache,
 	Component,
+	Element,
 	View,
 	XMLView,
 	VersionInfo,
@@ -72,7 +74,7 @@ sap.ui.define([
 		var sId = "erroneous_view_1";
 
 		return sap.ui.xmlview(sId, {async:true, viewContent:sXml}).loaded().catch(function(error) {
-			assert.notOk(sap.ui.getCore().byId(sId), "Must deregister an erroneous instance");
+			assert.notOk(Element.getElementById(sId), "Must deregister an erroneous instance");
 			assert.equal(error.message, sError, "Must reject with an error");
 		});
 	});
@@ -91,7 +93,7 @@ sap.ui.define([
 		var sId = "erroneous_view_2";
 
 		return sap.ui.xmlview(sId, {async:true, viewContent:sXml}).loaded().catch(function(error) {
-			assert.notOk(sap.ui.getCore().byId(sId), "Must deregister an erroneous instance");
+			assert.notOk(Element.getElementById(sId), "Must deregister an erroneous instance");
 			assert.equal(error.message, sError, "Must reject with an error");
 		});
 	});
@@ -110,7 +112,7 @@ sap.ui.define([
 			}
 		});
 		return sap.ui.xmlview(sId, {async:true, viewContent:sXml}).loaded().catch(function(error) {
-			assert.notOk(sap.ui.getCore().byId(sId), "Must deregister an erroneous instance");
+			assert.notOk(Element.getElementById(sId), "Must deregister an erroneous instance");
 			assert.equal(error.message, "Controller error", "Must reject with an error");
 		});
 	});

package/test/sap/ui/core/qunit/mvc_legacyAPIs/XMLView_legacyAPIs.qunit.js

@@ -1,6 +1,7 @@
 /*global QUnit, sinon */
 sap.ui.define([
 	'sap/base/Log',
+	"sap/ui/core/Element",
 	'sap/ui/core/library',
 	'sap/ui/core/mvc/View',
 	'sap/ui/core/mvc/XMLView',
@@ -14,7 +15,7 @@ sap.ui.define([
 	'sap/ui/thirdparty/jquery',
 	"sap/ui/core/Configuration",
 	"sap/ui/qunit/utils/nextUIUpdate"
-], function(Log, coreLibrary, View, XMLView, RenderManager, JSONModel, VerticalLayout, XMLHelper, Button, Panel, testsuite, jQuery, Configuration, nextUIUpdate) {
+], function(Log, Element, coreLibrary, View, XMLView, RenderManager, JSONModel, VerticalLayout, XMLHelper, Button, Panel, testsuite, jQuery, Configuration, nextUIUpdate) {
 	"use strict";
 
 	// shortcut for sap.ui.core.mvc.ViewType
@@ -680,7 +681,7 @@ sap.ui.define([
 		await nextUIUpdate();
 
 		expectedControls.forEach(function(sId) {
-			var oControl = sap.ui.getCore().byId(sId);
+			var oControl = Element.getElementById(sId);
 			assert.ok(oControl, "control with id '" + sId + "' should exist");
 			assert.ok(oControl.getDomRef(), "control with id '" + sId + "' should have DOM");
 		});
@@ -688,7 +689,7 @@ sap.ui.define([
 		// install delegates on each control to assert later that all have been rendered
 		var count = 0;
 		expectedControls.forEach(function(sId) {
-			var oControl = sap.ui.getCore().byId(sId);
+			var oControl = Element.getElementById(sId);
 			oControl.addDelegate({
 				onBeforeRendering: function() {
 					count += 100;
@@ -706,7 +707,7 @@ sap.ui.define([
 		// Assert: everythging has been rendered again
 		assert.equal(count, 101 * expectedControls.length, "all controls should have participated in the rendering");
 		expectedControls.forEach(function(sId) {
-			var oControl = sap.ui.getCore().byId(sId);
+			var oControl = Element.getElementById(sId);
 			assert.ok(oControl, "control with id '" + sId + "' should exist");
 			assert.ok(oControl.getDomRef(), "control with id '" + sId + "' should have DOM");
 			assert.notOk(document.getElementById(RenderManager.RenderPrefixes.Dummy + sId), "there should be no more Dummy-Element for id '" + sId + "'");
@@ -715,7 +716,7 @@ sap.ui.define([
 
 		oView.destroy();
 		expectedControls.forEach(function(sId) {
-			var oControl = sap.ui.getCore().byId(sId);
+			var oControl = Element.getElementById(sId);
 			assert.notOk(oControl, "control with id '" + sId + "' should no longer exist");
 			assert.notOk(document.getElementById(sId), "there should be no more DOM with id '" + sId + "'");
 		});

package/test/sap/ui/core/qunit/odata/ODataMessageParserNoFakeService.qunit.js

@@ -1751,20 +1751,21 @@ sap.ui.define([
 
 	//*********************************************************************************************
 	QUnit.test("_parseBodyJSON: plain text", function (assert) {
-		var oError = new Error("~error"),
+		var oJSONSpy = sinon.spy(JSON, "parse"),
 			oMessageParser = new ODataMessageParser("/foo"),
 			oResponse = {body : "~foo"},
 			mRequestInfo = {
 				response : oResponse
 			};
 
-		this.mock(JSON).expects("parse").withExactArgs("~foo").throws(oError);
 		this.mock(oMessageParser).expects("_createGenericError").never();
 
 		// code under test
 		assert.throws(function () {
 			oMessageParser._parseBodyJSON(oResponse, mRequestInfo);
-		}, oError);
+		}, SyntaxError);
+
+		assert.ok(oJSONSpy.calledWith("~foo"));
 	});
 
 	//*********************************************************************************************
@@ -2299,6 +2300,7 @@ sap.ui.define([
 				targets : "~targets1",
 				type : "~type1"
 			}],
+			oJSONSpy = sinon.spy(JSON, "stringify"),
 			oMessageParser = new ODataMessageParser("/foo"),
 			oMessage0 = {
 				getCode : function () {},
@@ -2326,14 +2328,16 @@ sap.ui.define([
 		this.mock(oMessage1).expects("getPersistent").withExactArgs().returns("~persistent1");
 		this.mock(oMessage1).expects("getTargets").withExactArgs().returns("~targets1");
 		this.mock(oMessage1).expects("getType").withExactArgs().returns("~type1");
-		this.mock(JSON).expects("stringify")
-			.withExactArgs(aExpectedMessageLogDetails)
-			.returns("~details");
 		this.oLogMock.expects("error")
-			.withExactArgs("Request failed with status code ~statusCode: ~method ~uri", "~details",
+			.withExactArgs("Request failed with status code ~statusCode: ~method ~uri",
+				'[{"code":"~code0","message":"~message0","persistent":"~persistent0",'
+				+ '"targets":"~targets0","type":"~type0"},{"code":"~code1","message":"~message1",'
+				+ '"persistent":"~persistent1","targets":"~targets1","type":"~type1"}]',
 				sClassName);
 
 		// code under test
 		oMessageParser._logErrorMessages([oMessage0, oMessage1], oRequest, "~statusCode");
+
+		assert.ok(oJSONSpy.calledWith(aExpectedMessageLogDetails));
 	});
 });

package/test/sap/ui/core/qunit/odata/ODataMetaModel.qunit.js

@@ -4225,6 +4225,23 @@ sap.ui.define([
 		});
 	});
 
+	//*********************************************************************************************
+	QUnit.test("requestCurrencyCodes: no CurrencyCodes annotation", function (assert) {
+		const oDataModel = new ODataModel("/fake/emptySchema", {});
+		const oMetaModel = oDataModel.getMetaModel();
+		this.mock(oMetaModel).expects("fetchCodeList").withExactArgs("CurrencyCodes")
+			.returns(SyncPromise.resolve(null));
+		this.mock(_Helper).expects("merge").never();
+
+		// code under test
+		const oCurrencyCodesPromise = oMetaModel.requestCurrencyCodes();
+
+		assert.ok(oCurrencyCodesPromise instanceof Promise);
+		return oCurrencyCodesPromise.then(function (oCodeList) {
+			assert.strictEqual(oCodeList, null);
+		});
+	});
+
 	//*********************************************************************************************
 	QUnit.test("requestUnitsOfMeasure", function (assert) {
 		var oDataModel = new ODataModel("/fake/emptySchema", {}),
@@ -4247,6 +4264,24 @@ sap.ui.define([
 		});
 	});
 
+	//*********************************************************************************************
+	QUnit.test("requestUnitsOfMeasure: no UnitOfMeasure annotation", function (assert) {
+		const oDataModel = new ODataModel("/fake/emptySchema", {});
+		const oMetaModel = oDataModel.getMetaModel();
+
+		this.mock(oMetaModel).expects("fetchCodeList").withExactArgs("UnitsOfMeasure")
+			.returns(SyncPromise.resolve(null));
+		this.mock(_Helper).expects("merge").never();
+
+		// code under test
+		const oUnitsOfMeasurePromise = oMetaModel.requestUnitsOfMeasure();
+
+		assert.ok(oUnitsOfMeasurePromise instanceof Promise);
+		return oUnitsOfMeasurePromise.then(function (oCodeList) {
+			assert.strictEqual(oCodeList, null);
+		});
+	});
+
 	//*********************************************************************************************
 	QUnit.test("getCodeListTerm", function (assert) {
 		assert.strictEqual(ODataMetaModel.getCodeListTerm(), undefined);

package/test/sap/ui/core/qunit/odata/_AnnotationHelperBasics.qunit.js

@@ -238,11 +238,16 @@ sap.ui.define([
 			value : {result : "expression", value : "foo(${path})"},
 			binding : "{=foo(${path})}",
 			expression : "foo(${path})"
+		}, {
+			value : {result : "binding", value : "path"},
+			binding : "{path}",
+			expression : "%{path}",
+			raw : true
 		}].forEach(function (oFixture) {
-			assert.strictEqual(Basics.resultToString(oFixture.value, false), oFixture.binding,
-				oFixture.binding);
-			assert.strictEqual(Basics.resultToString(oFixture.value, true), oFixture.expression,
-				oFixture.expression);
+			assert.strictEqual(Basics.resultToString(oFixture.value, false, undefined, oFixture.raw),
+				oFixture.binding, oFixture.binding);
+			assert.strictEqual(Basics.resultToString(oFixture.value, true, undefined, oFixture.raw),
+				oFixture.expression, oFixture.expression);
 		});
 
 		assert.strictEqual(
@@ -252,6 +257,7 @@ sap.ui.define([
 			Basics.resultToString({result : "composite", value : "{FirstName} {LastName}"}, true);
 		}, /Trying to embed a composite binding into an expression binding/,
 			"composite to expression");
+		assert.strictEqual(Basics.resultToString({result : "not_supported"}), undefined, "not_supported");
 	});
 
 	//*********************************************************************************************

package/test/sap/ui/core/qunit/odata/data/ODataModelFakeService.js

@@ -149,7 +149,7 @@ sap.ui.define([], function() {
         "Products(4)?$expand=Category":
           [200, oXMLHeaders, sProducts4ExpCategoryXML],
         "Invoices/$count":
-          [200, oCountHeaders, "9"],
+          [200, oCountHeaders, "8"],
         "Invoices?$skip=0&$top=100":
           [200, oJSONHeaders, sInvoicesJSON],
         "Invoices":

package/test/sap/ui/core/qunit/odata/type/DateTimeBase.qunit.js

@@ -80,6 +80,11 @@ sap.ui.define([
 	 */
 	function module(sTitle) {
 		QUnit.module(sTitle, {
+			before : function () {
+				if (sTitle === "sap.ui.model.odata.type.DateTimeBase") {
+					this.__ignoreIsolatedCoverage__ = true;
+				}
+			},
 			beforeEach : function () {
 				this.sDefaultCalendarType = Configuration.getCalendarType();
 				this.sDefaultLanguage = Configuration.getLanguage();

package/test/sap/ui/core/qunit/odata/type/ODataType.qunit.js

@@ -105,6 +105,15 @@ sap.ui.define([
 		assert.strictEqual(oType.getEmptyValue(null, true), 0);
 	});
 
+	//*********************************************************************************************
+	QUnit.test("getEmptyValue: without format options", function (assert) {
+		var oType = new ODataType();
+
+		// code under test
+		assert.strictEqual(oType.getEmptyValue("", true), null);
+		assert.strictEqual(oType.getEmptyValue(null, true), null);
+	});
+
 	//*****************************************************************************************
 [undefined, {"~constraint" : 2}].forEach(function (oConstraints) {
 	QUnit.test("checkParseEmptyValueToZero logs warning", function (assert) {

package/test/sap/ui/core/qunit/odata/v2/Context.qunit.js

@@ -556,6 +556,18 @@ sap.ui.define([
 		oContext.removeSubContext("~subContext42");
 	});
 
+	//*********************************************************************************************
+	QUnit.test("removeSubContext: non matching single entry", function (assert) {
+		var oContext = new Context("~oModel", "~sPath");
+
+		oContext.mSubContexts = {foo: "~subContext0"};
+
+		// code under test
+		oContext.removeSubContext("~subContext1");
+
+		assert.deepEqual(oContext.mSubContexts, {foo: "~subContext0"});
+	});
+
 	//*********************************************************************************************
 	QUnit.test("removeFromTransientParent", function (assert) {
 		var oParent = new Context("~oModel", "~sParentPath"),