@openui5/sap.ui.core 1.118.0 → 1.119.1

package/test/sap/ui/core/internal/samples/composite/xmlcomposite/exTableWrapperOuterBinding/Test.controller.js

@@ -2,9 +2,10 @@ sap.ui.define([
 	"sap/m/Column",
 	"sap/m/ColumnListItem",
 	"sap/m/Text",
+	"sap/ui/core/Element",
 	"sap/ui/core/mvc/Controller",
 	"sap/ui/model/json/JSONModel"
-], function (Column, ColumnListItem, Text, Controller, JSONModel) {
+], function (Column, ColumnListItem, Text, Element, Controller, JSONModel) {
 	"use strict";
 	return Controller.extend("sap.ui.core.internal.samples.composite.xmlcomposite.exTableWrapperOuterBinding.Test", {
 		onInit: function () {
@@ -32,7 +33,7 @@ sap.ui.define([
 			};
 			var oModel = new JSONModel(oData);
 
-			var oTable = sap.ui.getCore().byId(this.getView().getId() + "--" + "myTable");
+			var oTable = Element.getElementById(this.getView().getId() + "--" + "myTable");
 
 			oTable.setModel(oModel);
 

package/test/sap/ui/core/internal/samples/odata/v2/SalesOrders/Main.controller.js

@@ -453,7 +453,7 @@ sap.ui.define([
 
 		onMessageSelected : function (oEvent) {
 			var oMessage = oEvent.getParameter("item").getBindingContext("messages").getObject(),
-				oControl = Element.registry.get(oMessage.getControlId());
+				oControl = Element.getElementById(oMessage.getControlId());
 
 			if (oControl) {
 				this.getView().byId("page").scrollToElement(oControl.getDomRef(), 200, [0, -100]);

package/test/sap/ui/core/internal/samples/odata/v2/SalesOrders/Main.view.xml

@@ -9,7 +9,8 @@
 	xmlns:form="sap.ui.layout.form"
 	xmlns:mvc="sap.ui.core.mvc"
 	xmlns:plugins="sap.m.plugins"
-	xmlns:t="sap.ui.table">
+	xmlns:t="sap.ui.table"
+	xmlns:trm="sap.ui.table.rowmodes">
 <App>
 	<Page id="page" floatingFooter="true" showHeader="false">
 		<content>
@@ -199,8 +200,10 @@
 						},
 						parameters : {transitionMessagesOnly : true, usePreliminaryContext : true},
 						path : 'ToLineItems'
-					}" rowSelectionChange="onSelectItem" selectionMode="Single" threshold="0"
-					visibleRowCount="4">
+					}" rowSelectionChange="onSelectItem" selectionMode="Single" threshold="0">
+					<t:rowMode>
+						<trm:Interactive rowCount="4"/>
+					</t:rowMode>
 					<t:dependents>
 						<plugins:DataStateIndicator />
 					</t:dependents>

package/test/sap/ui/core/internal/samples/odata/v2/TreeTable/Main.view.xml

@@ -35,7 +35,7 @@
 					</form:SimpleForm>
 				</content>
 			</Panel>
-			<t:TreeTable id="treetable" visibleRowCountMode="Auto" selectionBehavior="Row"
+			<t:TreeTable id="treetable" rowMode="Auto" selectionBehavior="Row"
 				selectionMode="Single" rowSelectionChange="onRowSelection" threshold="10">
 				<t:extension>
 					<Toolbar>

package/test/sap/ui/core/qunit/ControlDefinition.qunit.js

@@ -1,5 +1,6 @@
-/*global QUnit, my */
+/*global QUnit */
 sap.ui.define([
+	"sap/base/util/ObjectPath",
 	"sap/ui/base/Object",
 	"sap/ui/core/Control",
 	"sap/ui/core/Element",
@@ -7,7 +8,7 @@ sap.ui.define([
 	"sap/m/Input",
 	"sap/ui/qunit/utils/createAndAppendDiv",
 	"sap/ui/qunit/utils/nextUIUpdate"
-], function(BaseObject, Control, Element, Button, Input, createAndAppendDiv, nextUIUpdate) {
+], function(ObjectPath, BaseObject, Control, Element, Button, Input, createAndAppendDiv, nextUIUpdate) {
 	"use strict";
 
 	createAndAppendDiv("content");
@@ -30,14 +31,20 @@ sap.ui.define([
 
 
 	/* test creating a control from scratch */
-
+	var MyControl;
 
 	QUnit.test("Extend sap.ui.core.Control", async function(assert) {
-		assert.expect(4);
+		let expectedAsserts = 4;
+		/**
+		 * @deprecated global exports are deprecated, therefore one assert will disappear in 2.0
+		 */
+		expectedAsserts += 1;
+
+		assert.expect(expectedAsserts);
 		assert.equal(window.my, undefined, "'my' should not be defined yet");
 
 		// define control
-		var MyLibControlClass = Control.extend("my.lib.MyControl", {
+		MyControl = Control.extend("my.lib.MyControl", {
 			metadata : {
 				properties : {
 					"text" : "string",
@@ -83,12 +90,12 @@ sap.ui.define([
 
 				apiVersion: 2,
 
-				render: function(rm, c) {
-					if (c._assert) {
-						c._assert.ok(true, "Renderer was called");
+				render: function(rm, ctrl) {
+					if (ctrl._assert) {
+						ctrl._assert.ok(true, "Renderer was called");
 					}
-					rm.openStart("span", c).attr("tabindex", "0").openEnd();
-						rm.text(c.getText());
+					rm.openStart("span", ctrl).attr("tabindex", "0").openEnd();
+						rm.text(ctrl.getText());
 					rm.close("span");
 				}
 
@@ -96,9 +103,13 @@ sap.ui.define([
 		});
 
 		// check control type
-		assert.ok(my.lib.MyControl, "my.lib.MyControl should be defined now");
+		assert.ok(MyControl, "MyControl should be defined now");
+		/**
+		 * @deprecated global exports are deprecated
+		 */
+		assert.strictEqual(MyControl, ObjectPath.get("my.lib.MyControl"), "returned class and globally exported class should be identical");
 
-		var myControl = new MyLibControlClass("myControl", undefined, assert);
+		var myControl = new MyControl("myControl", undefined, assert);
 
 		myControl.placeAt("content");
 		await nextUIUpdate();
@@ -109,7 +120,7 @@ sap.ui.define([
 
 	QUnit.module("", {
 		beforeEach: function() {
-			this.myControl = new my.lib.MyControl("myControl", {
+			this.myControl = new MyControl("myControl", {
 				text : "test"
 			});
 		},
@@ -123,15 +134,21 @@ sap.ui.define([
 
 		// check control instance
 		assert.ok(this.myControl, "myControl should be a control instance now");
-		assert.ok(this.myControl instanceof my.lib.MyControl, "myControl should be an instance of my.lib.MyControl");
 		assert.ok(this.myControl instanceof Control, "myControl should inherit from sap.ui.Core.Control");
 
 		// renderer should not be added as function...
 		assert.equal(this.myControl.renderer, undefined, "renderer should not be added as function");
 
 		// ...but a renderer should exist now
-		assert.ok(my.lib.MyControlRenderer, "my.lib.MyControlRenderer should be defined"); // TODO: is this the case?
-		assert.equal(typeof my.lib.MyControlRenderer.render, "function", "my.lib.MyControlRenderer.render must be a function");
+		const MyControlRenderer = MyControl.getMetadata().getRenderer();
+		assert.ok(MyControlRenderer, "renderer of my.lib.MyControl should be defined");
+		assert.equal(typeof MyControlRenderer.render, "function", "render property must be a function");
+		/**
+		 * @deprecated global exports are deprecated
+		 */
+		assert.strictEqual(MyControlRenderer, ObjectPath.get("my.lib.MyControlRenderer"),
+			"even embedded renderers should be exported under the default global name");
+
 	});
 
 
@@ -159,7 +176,7 @@ sap.ui.define([
 
 
 	QUnit.test("Methods", function(assert) {
-		assert.equal(this.myControl.add, my.lib.MyControl.prototype.add, "myControl's add function should actually be a function of the my.lib.MyControl.prototype");
+		assert.equal(this.myControl.add, MyControl.prototype.add, "myControl's add function should actually be a function of the my.lib.MyControl.prototype");
 		assert.equal(this.myControl.add(1, 2), 3, "myControl's add function should work");
 	});
 
@@ -358,7 +375,7 @@ sap.ui.define([
 	var MyInput;
 
 	QUnit.test("Extend sap.m.Input", function(assert) {
-		var result = MyInput = Input.extend("my.lib.MyInput", {
+		MyInput = Input.extend("my.lib.MyInput", {
 
 			setValue : function(value) {
 				value = value + valueSuffix;
@@ -372,13 +389,16 @@ sap.ui.define([
 				}
 			}
 		});
-		assert.strictEqual(typeof result, "function", "result is a function (a constructor)");
+		assert.strictEqual(typeof MyInput, "function", "result is a function (a constructor)");
+		/**
+		 * @deprecated global exports are deprecated
+		 */
+		assert.strictEqual(MyInput, ObjectPath.get("my.lib.MyInput"), "returned class should be the same as the globally exported class");
 	});
 
 	QUnit.test("Instantiate MyInput", function(assert) {
 		var myInput = new MyInput("myInput", {value:"test"});
 		assert.ok(myInput, "myInput should be a control instance now");
-		assert.ok(myInput instanceof my.lib.MyInput, "myInput should be an instance of my.lib.MyTextField");
 		assert.ok(myInput instanceof Input, "myInput should inherit from sap.m.Input");
 		assert.equal(myInput.getValue(), "test" + valueSuffix, "value should be modified by overridden method");
 		myInput.destroy();

package/test/sap/ui/core/qunit/ControlRenderer.qunit.js

@@ -296,7 +296,7 @@ sap.ui.define([
 		assert.notEqual(document.getElementById("child2").style.width, "500px", "Width is not set for the 2nd child since we initially do dom-based rendering");
 		assert.notOk(document.getElementById("child2").hasAttribute("hack"), "Hack attribute is not set");
 
-		Element.registry.get("child2").setWidth('300px;" hack="true"');
+		Element.getElementById("child2").setWidth('300px;" hack="true"');
 		await nextUIUpdate();
 		assert.notEqual(document.getElementById("child2").style.width, "300px", "Width is not set for the 2nd child since patching encodes semicolon");
 		assert.notOk(document.getElementById("child2").hasAttribute("hack"), "Hack attribute is not set");

package/test/sap/ui/core/qunit/Core.qunit.js

@@ -13,10 +13,11 @@ sap.ui.define([
 	'sap/ui/core/Configuration',
 	'sap/ui/core/Rendering',
 	'sap/ui/core/RenderManager',
+	'sap/ui/core/Theming',
 	'sap/ui/core/theming/ThemeManager',
 	'sap/ui/qunit/utils/createAndAppendDiv',
 	"sap/ui/qunit/utils/nextUIUpdate"
-], function(ResourceBundle, Log, LoaderExtensions, ObjectPath, Device, Interface, VersionInfo, oCore, UIArea, Element, Configuration, Rendering, RenderManager, ThemeManager, createAndAppendDiv, nextUIUpdate) {
+], function(ResourceBundle, Log, LoaderExtensions, ObjectPath, Device, Interface, VersionInfo, oCore, UIArea, Element, Configuration, Rendering, RenderManager, Theming, ThemeManager, createAndAppendDiv, nextUIUpdate) {
 	"use strict";
 
 	var privateLoaderAPI = sap.ui.loader._;
@@ -108,7 +109,7 @@ sap.ui.define([
 		this.spy(Log, 'error');
 
 		assert.strictEqual(new oRealCore.constructor(), sap.ui.getCore(), "consecutive calls to the constructor should return the facade");
-		sinon.assert.calledWith(Log.error, sinon.match(/Only.*must create an instance of .*Core/).and(sinon.match(/use .*sap.ui.getCore\(\)/)));
+		sinon.assert.calledWith(Log.error, sinon.match(/Only.*must create an instance of .*Core/).and(sinon.match(/use the module export directly without using 'new'/)));
 	});
 
 	QUnit.test("loadLibrary", function(assert) {
@@ -183,12 +184,12 @@ sap.ui.define([
 		var oBtn = new TestButton("testMyButton", {text:"Hallo JSUnit"});
 		oBtn.onThemeChanged = function(oCtrlEvent) {
 			assert.ok(oCtrlEvent, "TestButton#onThemeChanged is called");
-			assert.equal(oCtrlEvent.theme, oCore.getConfiguration().getTheme(), "Default theme is passed along control event");
+			assert.equal(oCtrlEvent.theme, Theming.getTheme(), "Default theme is passed along control event");
 		};
 
 		function handler(oEvent) {
 			assert.ok(oEvent, "attachThemeChanged is called");
-			assert.equal(oEvent.getParameter("theme"), oCore.getConfiguration().getTheme(), "Default theme is passed along Core event");
+			assert.equal(oEvent.getParameter("theme"), Theming.getTheme(), "Default theme is passed along Core event");
 
 			// cleanup
 			oCore.detachThemeChanged(handler);

package/test/sap/ui/core/qunit/Core_libraryTerminologies_integration.qunit.js

@@ -1,8 +1,9 @@
 /*global QUnit*/
 sap.ui.define([
 	"sap/ui/core/ComponentContainer",
+	"sap/ui/core/Element",
 	"sap/base/util/Deferred"
-], function (ComponentContainer, Deferred) {
+], function (ComponentContainer, Element, Deferred) {
 	"use strict";
 
 	QUnit.module("Integration Tests", {
@@ -32,14 +33,14 @@ sap.ui.define([
 				assert.ok(oComponent, "Component should be available.");
 
 				// The first three pages are statically available
-				assert.equal(sap.ui.getCore().byId("__component0---mainView--appContentOnly_label").getText(), 'I am a Transportation text (application)', "The label text should be verticalized.");
-				assert.equal(sap.ui.getCore().byId("__component0---mainView--appContentOnly_button").getText(), 'Transportation Button (application)', "The button text should be verticalized.");
-				assert.equal(sap.ui.getCore().byId("__xmlview0--reuse_component_common_label").getText(), 'I am a Transportation text (reuse-library)', "The label text inside the reuse view should be verticalized.");
-				assert.equal(sap.ui.getCore().byId("__xmlview0--reuse_component_common_button").getText(), 'Transportation Button (reuse-library)', "The button text inside the reuse view should be verticalized.");
+				assert.equal(Element.getElementById("__component0---mainView--appContentOnly_label").getText(), 'I am a Transportation text (application)', "The label text should be verticalized.");
+				assert.equal(Element.getElementById("__component0---mainView--appContentOnly_button").getText(), 'Transportation Button (application)', "The button text should be verticalized.");
+				assert.equal(Element.getElementById("__xmlview0--reuse_component_common_label").getText(), 'I am a Transportation text (reuse-library)', "The label text inside the reuse view should be verticalized.");
+				assert.equal(Element.getElementById("__xmlview0--reuse_component_common_button").getText(), 'Transportation Button (reuse-library)', "The button text inside the reuse view should be verticalized.");
 
 				oComponent.getModel("i18n_reuse_lib_async").getResourceBundle().then(function() {
-					assert.equal(sap.ui.getCore().byId("__component0---mainView--reuse_fragment_label").getText(), 'I am a Transportation text (reuse-library)', "The label text inside the reuse fragment should be verticalized.");
-					assert.equal(sap.ui.getCore().byId("__component0---mainView--reuse_fragment_button").getText(), 'Transportation Button (reuse-library)', "The button text inside the reuse fragment should be verticalized.");
+					assert.equal(Element.getElementById("__component0---mainView--reuse_fragment_label").getText(), 'I am a Transportation text (reuse-library)', "The label text inside the reuse fragment should be verticalized.");
+					assert.equal(Element.getElementById("__component0---mainView--reuse_fragment_button").getText(), 'Transportation Button (reuse-library)', "The button text inside the reuse fragment should be verticalized.");
 					oResourceBundleLoadedDeferred.resolve();
 				});
 
@@ -53,10 +54,10 @@ sap.ui.define([
 				oNestedContainer.attachComponentCreated(function(oParams) {
 					var oNestedComponent = oParams.getParameter("component");
 					assert.ok(oNestedComponent, "Nested component should be available.");
-					assert.equal(sap.ui.getCore().byId("reuseComponent---reuseDefaultView--reuse_label").getText(), 'I am a Transportation text (reuse-component)', "The label text inside the reuse component should be verticalized.");
-					assert.equal(sap.ui.getCore().byId("reuseComponent---reuseDefaultView--reuse_button").getText(), 'Transportation Button (reuse-component)', "The button text inside the reuse component should be verticalized.");
-					assert.equal(sap.ui.getCore().byId("reuseComponent---reuseDefaultView--reuseCommonView--reuse_component_common_label").getText(), 'I am a Transportation text (reuse-library)', "The label text inside the reuse library of the reuse component should be verticalized.");
-					assert.equal(sap.ui.getCore().byId("reuseComponent---reuseDefaultView--reuseCommonView--reuse_component_common_button").getText(), 'Transportation Button (reuse-library)', "The button text inside the reuse library of the reuse component should be verticalized.");
+					assert.equal(Element.getElementById("reuseComponent---reuseDefaultView--reuse_label").getText(), 'I am a Transportation text (reuse-component)', "The label text inside the reuse component should be verticalized.");
+					assert.equal(Element.getElementById("reuseComponent---reuseDefaultView--reuse_button").getText(), 'Transportation Button (reuse-component)', "The button text inside the reuse component should be verticalized.");
+					assert.equal(Element.getElementById("reuseComponent---reuseDefaultView--reuseCommonView--reuse_component_common_label").getText(), 'I am a Transportation text (reuse-library)', "The label text inside the reuse library of the reuse component should be verticalized.");
+					assert.equal(Element.getElementById("reuseComponent---reuseDefaultView--reuseCommonView--reuse_component_common_button").getText(), 'Transportation Button (reuse-library)', "The button text inside the reuse library of the reuse component should be verticalized.");
 
 					oComponentCreatedDeferred.resolve();
 				});