@opengsd/gsd-core 1.10.0 → 1.12.0

package/gsd-core/bin/lib/assumption-delta.cjs

@@ -21,22 +21,25 @@
  *    tunable (config + the `terms` parameter) so teams can widen it.
  *  - FENCED CODE BLOCKS ARE STRIPPED first (via the markdown-sectionizer seam)
  *    so a trigger term that appears only inside a code snippet does not fire.
- *  - Mirrors ui-safety-gate.cts: a pure function + a STDIN-reading CLI whose
- *    exit codes mirror grep (0 = signal found, 1 = none, 2 = usage error).
+ *  - Mirrors ui-safety-gate.cts: a pure function + a STDIN-reading CLI.
  *
  * Public API:
  *   detectAssumptionDelta(text, terms?) -> { detected, signals, terms }
  *   DEFAULT_ASSUMPTION_DELTA_TERMS
  *
- * CLI:
+ * CLI (ADR-3889 Phase 3, #3907):
  *   echo "$PHASE_SECTION" | node gsd-core/bin/lib/assumption-delta.cjs [--json]
- *     exit 0 = signal detected, 1 = none, 2 = startup error
- *     --json additionally prints the typed IR on stdout
+ *     exit 0 = signal detected, 1 = none (real input, examined, no signal),
+ *     NO_INPUT (registry, src/cli-exit.cts) = stdin empty/whitespace-only,
+ *     UNAVAILABLE (registry) = stdin read failed
+ *     --json additionally prints the typed IR on stdout (unchanged for 0/1);
+ *     NO_INPUT/UNAVAILABLE print {skipped:true, reason:"no_input"|"stdin_error"}
  */
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.DEFAULT_ASSUMPTION_DELTA_TERMS = void 0;
 exports.detectAssumptionDelta = detectAssumptionDelta;
 const markdown_sectionizer_cjs_1 = require("./markdown-sectionizer.cjs");
+const pattern_cjs_1 = require("./pattern.cjs");
 /**
  * Curated default trigger vocabulary. Each kind lists cue terms that signal a
  * core-assumption monopoly has been lost. ADDITIVE-ONLY (Hyrum's Law: once
@@ -168,7 +171,7 @@ function detectAssumptionDelta(text, terms) {
             continue;
         // Word-boundary anchored, case-insensitive — same shape as ui-safety-gate.
         // (^|[^a-zA-Z0-9])(TERM)([^a-zA-Z0-9]|$) prevents interior-substring matches.
-        const escaped = cueTerms.map(escapeRegex).join('|');
+        const escaped = cueTerms.map(pattern_cjs_1.escapeRegex).join('|');
         const pattern = new RegExp('(^|[^a-zA-Z0-9])(' + escaped + ')([^a-zA-Z0-9]|$)', 'gi');
         const seen = new Set();
         for (const line of stripped.split('\n')) {
@@ -188,16 +191,26 @@ function detectAssumptionDelta(text, terms) {
     }
     return { detected: signals.length > 0, signals, terms: effective };
 }
-function escapeRegex(s) {
-    return s.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
-}
 // ── CLI entry point ──────────────────────────────────────────────────────────
 // Reads phase-section text from STDIN (not argv) to avoid OS ARG_MAX limits.
 // Invoked by workflow bash as: echo "$PHASE_SECTION" | node .../assumption-delta.cjs [--json]
-// Exit 0 = signal detected, 1 = none, 2 = startup error. Mirrors ui-safety-gate.
+//
+// Exit codes (ADR-3889 Phase 3, #3907): 0 = signal detected, 1 = none (real
+// input, examined, no signal), NO_INPUT (registry — src/cli-exit.cts) = stdin
+// empty/whitespace-only, UNAVAILABLE (registry) = stdin read failed. The prior
+// single "2 = startup error" arm let empty input flow into the detector and
+// exit 1 — an unexamined input reported as an authoritative negative. Under
+// --json, NO_INPUT/UNAVAILABLE emit `{skipped:true, reason:"no_input"|
+// "stdin_error"}` — no `detected` key, so a stale `detected:false` can never
+// sit beside `skipped:true`; the detected/no-signal `--json` payloads are
+// byte-identical to before. Terminates via terminateNow (write-then-terminate,
+// total by construction), not raw process.exit — these exits fire from inside
+// a stdin event handler. Mirrors ui-safety-gate.cjs / api-coverage.cjs.
 if (require.main === module) {
     const argv = process.argv.slice(2);
     const wantJson = argv.includes('--json');
+    // eslint-disable-next-line @typescript-eslint/no-require-imports
+    const cliExit = require('./cli-exit.cjs');
     // --terms <csv>: config-tunable vocabulary override. Replaces the
     // pluralization cues (the primary trigger); optional/chosen keep defaults.
     // An EMPTY value ("") or a flag-shaped value restores the curated defaults
@@ -218,14 +231,18 @@ if (require.main === module) {
     process.stdin.on('data', (chunk) => chunks.push(chunk));
     process.stdin.on('end', () => {
         const input = chunks.join('');
-        const result = detectAssumptionDelta(input, termsOverride);
-        if (wantJson) {
-            process.stdout.write(JSON.stringify(result) + '\n');
+        // Whitespace-only counts as empty (ADR-3889 §1's NO_INPUT: "zero units
+        // were in scope, and that emptiness is known to be genuine"). Real input
+        // — including a lone NUL byte, which .trim() does not strip — always
+        // falls through to the detector.
+        if (input.trim().length === 0) {
+            cliExit.terminateNow('NO_INPUT', wantJson ? { skipped: true, reason: 'no_input' } : undefined);
         }
-        process.exit(result.detected ? 0 : 1);
+        const result = detectAssumptionDelta(input, termsOverride);
+        cliExit.terminateNow(result.detected ? 'PASS' : 'FAIL', wantJson ? result : undefined);
     });
     process.stdin.on('error', (err) => {
         process.stderr.write(`ERROR: assumption-delta.cjs stdin read failed: ${err.message}\n`);
-        process.exit(2);
+        cliExit.terminateNow('UNAVAILABLE', wantJson ? { skipped: true, reason: 'stdin_error' } : undefined);
     });
 }

package/gsd-core/bin/lib/audit-command-router.cjs

@@ -71,7 +71,7 @@ function routeAuditOpen({ args, cwd, raw, error, _audit, _core }) {
     routeHubCommandFamily({
         family: 'audit-open',
         args: hubArgs,
-        subcommands: ['run'],
+        subcommands: ['run', 'acknowledge'],
         defaultSubcommand: 'run',
         handlers: {
             run: () => {
@@ -86,8 +86,15 @@ function routeAuditOpen({ args, cwd, raw, error, _audit, _core }) {
                     c.output(null, true, a.formatAuditReport(result));
                 }
             },
+            // #3458 follow-up (design point A4): `audit-open acknowledge --category
+            // ... --milestone ...` writes/refreshes an `audit_acknowledged`
+            // suppression marker. `hubArgs.slice(2)` drops the family token and the
+            // `acknowledge` subcommand token itself, leaving just this
+            // subcommand's OWN `--flag value` pairs — the same slice
+            // `routeHubCommandFamily` itself passes to `hub.dispatch`'s `args`.
+            acknowledge: () => a.cmdAuditAcknowledge(cwd, hubArgs.slice(2), raw),
         },
-        unknownMessage: (subcommand) => `Unknown audit-open subcommand: "${subcommand}". audit-open takes no subcommands (use --json for JSON output).`,
+        unknownMessage: (subcommand) => `Unknown audit-open subcommand: "${subcommand}". Available: run (default, use --json for JSON output), acknowledge.`,
         error,
         cwd,
         raw,