@opengsd/gsd-core 1.10.0 → 1.12.0

package/scripts/lint-test-file-count.allowlist.json

@@ -1,16 +1,47 @@
 {
   "_doc": "Baseline of modules currently exceeding the 2-test-file limit. Each entry locks in TODAY's exact test filenames as the allowlisted set (identity ratchet). Adding a NEW test file to a capped module fails (novel). Removing one requires pruning this list (stale, ratchet-down). When a cluster drops to \u2264 2, remove its entry entirely. New entries require justification in PR description.",
   "modules": {
+    "adr-parser": {
+      "files": [
+        "adr-parser.property.test.cjs",
+        "adr-parser.test.cjs",
+        "adr-parser.unit.test.cjs"
+      ],
+      "issue": "3227",
+      "justification": "Grandfathered by #3227 when the testEffectivePrefix() dot/hyphen bucketing fix first made this pre-existing over-cap cluster visible to the gate; not new test sprawl."
+    },
     "config": {
       "files": [
         "config-defaults-runtime-exclusion.test.cjs",
         "config-field-docs.test.cjs",
         "config-get-default.test.cjs",
-        "config-schema.property.test.cjs",
+        "config-get-raw-guard.test.cjs",
+        "config-validation.test.cjs",
         "config.test.cjs"
       ],
       "issue": "TBD"
     },
+    "context-predicates": {
+      "files": [
+        "context-predicates-query.test.cjs",
+        "context-predicates.property.test.cjs",
+        "context-predicates.test.cjs"
+      ],
+      "issue": "3227",
+      "justification": "Grandfathered by #3227 when the testEffectivePrefix() dot/hyphen bucketing fix first made this pre-existing over-cap cluster visible to the gate; not new test sprawl."
+    },
+    "frontmatter": {
+      "files": [
+        "frontmatter-cli.test.cjs",
+        "frontmatter-golden-parity.test.cjs",
+        "frontmatter-roundtrip.property.test.cjs",
+        "frontmatter.property.test.cjs",
+        "frontmatter.test.cjs",
+        "frontmatter.unit.test.cjs"
+      ],
+      "issue": "3881",
+      "justification": "Grandfathered by #3227 for the original 4-file cluster (pre-existing over-cap, not new sprawl). #3881 (ADR-3473 \u00a78.1, the js-yaml parser migration) adds two more: frontmatter-golden-parity.test.cjs (D-series golden-corpus diff against the legacy parser, ~900 real documents \u2014 cannot be folded into an existing file without losing its independent-of-current-parser provenance) and frontmatter-roundtrip.property.test.cjs (fast-check property coverage the migration's bijective-contract rule requires). Both are migration-specific, not incidental sprawl."
+    },
     "graphify": {
       "files": [
         "graphify-auto-update.slow.test.cjs",
@@ -33,16 +64,30 @@
     },
     "milestone": {
       "files": [
+        "milestone-archive-hygiene.test.cjs",
         "milestone-archive.test.cjs",
         "milestone-helper.test.cjs",
         "milestone-prefixed-convention.test.cjs",
         "milestone-summary.test.cjs",
+        "milestone-window-drift-guard.test.cjs",
+        "milestone-window-single-owner.test.cjs",
         "milestone.test.cjs"
       ],
-      "issue": "TBD"
+      "issue": "3216"
+    },
+    "phase": {
+      "files": [
+        "phase-completion-single-owner.test.cjs",
+        "phase-dependency-levels.test.cjs",
+        "phase-resolution-parity.test.cjs",
+        "phase-structure.test.cjs",
+        "phase.test.cjs"
+      ],
+      "issue": "3186"
     },
     "roadmap": {
       "files": [
+        "roadmap-disk-consistency.test.cjs",
         "roadmap-mode-field.test.cjs",
         "roadmap-phase-fallback.test.cjs",
         "roadmap.test.cjs"
@@ -54,9 +99,10 @@
         "runtime-artifact-layout-descriptor-drive.test.cjs",
         "runtime-artifact-layout-install-profiles.test.cjs",
         "runtime-artifact-layout-surface.test.cjs",
+        "runtime-artifact-layout-trigger-surface.test.cjs",
         "runtime-artifact-layout.test.cjs"
       ],
-      "issue": "TBD"
+      "issue": "2871"
     },
     "security": {
       "files": [
@@ -71,15 +117,19 @@
       "files": [
         "state-acquirestatelock-non-eexist.test.cjs",
         "state-command-cutover.test.cjs",
+        "state-consistency.test.cjs",
+        "state-field-drift.test.cjs",
         "state-prune.test.cjs",
         "state-rebuild-cli.test.cjs",
         "state-rebuild.test.cjs",
+        "state-write-path-drift-guard.test.cjs",
         "state.test.cjs"
       ],
       "issue": "180"
     },
     "verify": {
       "files": [
+        "verify-archive-dirs-live-path.test.cjs",
         "verify-health.test.cjs",
         "verify-mvp-uat.test.cjs",
         "verify-npm-publish.test.cjs",
@@ -87,20 +137,22 @@
         "verify-work-auto-transition.test.cjs",
         "verify.test.cjs"
       ],
-      "issue": "3767"
+      "issue": "#3813 \u2014 the live-path #1883 suite drives buildPlanningSnapshot in-process with an fs fault; the verify module suites are CLI-driving and cannot host an fs monkeypatch",
+      "justification": "verify-command-grounding added by #2401/#3678; allowlist follow-up landed with #3606 (base was red on this lane)."
     },
     "install": {
       "files": [
         "install-minimal-hooks.test.cjs",
         "install-nested-layout.test.cjs",
         "install-path-detection.test.cjs",
+        "install-profile-workflow-spawns.test.cjs",
         "install-regressions.test.cjs",
         "install-runtime-artifacts.test.cjs",
         "install-update-marker.test.cjs",
         "install-write-confinement.test.cjs",
         "install.test.cjs"
       ],
-      "issue": "1679"
+      "issue": "#3798 \u2014 the profile-closure spawn test reads the real repo surface (commands+workflows+agents); consolidating it into install.test.cjs would put a whole-repo scan behind the suite's heaviest file"
     },
     "edge-probe": {
       "files": [
@@ -131,17 +183,94 @@
       "files": [
         "prompt-budget-cli.test.cjs",
         "prompt-budget-parity.test.cjs",
-        "prompt-budget.test.cjs"
+        "prompt-budget.property.test.cjs",
+        "prompt-budget.test.cjs",
+        "prompt-budget.unit.test.cjs"
       ],
       "issue": "2929"
     },
+    "mcp-catalog": {
+      "files": [
+        "mcp-catalog-parity.install.test.cjs",
+        "mcp-catalog.property.test.cjs",
+        "mcp-catalog.test.cjs"
+      ],
+      "issue": "3227",
+      "justification": "Grandfathered by #3227 when the testEffectivePrefix() dot/hyphen bucketing fix first made this pre-existing over-cap cluster visible to the gate; not new test sprawl."
+    },
+    "model-catalog": {
+      "files": [
+        "model-catalog-runtime-defaults.test.cjs",
+        "model-catalog-valid-tiers.test.cjs",
+        "model-catalog.unit.test.cjs"
+      ],
+      "issue": "3227",
+      "justification": "Grandfathered by #3227 when the testEffectivePrefix() dot/hyphen bucketing fix first made this pre-existing over-cap cluster visible to the gate; not new test sprawl."
+    },
+    "package-legitimacy": {
+      "files": [
+        "package-legitimacy-gate.test.cjs",
+        "package-legitimacy.property.test.cjs",
+        "package-legitimacy.test.cjs"
+      ],
+      "issue": "3227",
+      "justification": "Grandfathered by #3227 when the testEffectivePrefix() dot/hyphen bucketing fix first made this pre-existing over-cap cluster visible to the gate; not new test sprawl."
+    },
+    "runtime-homes": {
+      "files": [
+        "runtime-homes-descriptor-drive.test.cjs",
+        "runtime-homes-legacy-ids-drift-guard.test.cjs",
+        "runtime-homes.property.test.cjs"
+      ],
+      "issue": "3227",
+      "justification": "Grandfathered by #3227 when the testEffectivePrefix() dot/hyphen bucketing fix first made this pre-existing over-cap cluster visible to the gate; not new test sprawl."
+    },
+    "section-manifest": {
+      "files": [
+        "section-manifest-init-facts.test.cjs",
+        "section-manifest.property.test.cjs",
+        "section-manifest.test.cjs"
+      ],
+      "issue": "3227",
+      "justification": "Grandfathered by #3227 when the testEffectivePrefix() dot/hyphen bucketing fix first made this pre-existing over-cap cluster visible to the gate; not new test sprawl."
+    },
+    "workflow-fragments": {
+      "files": [
+        "workflow-fragments-emission.install.test.cjs",
+        "workflow-fragments.property.test.cjs",
+        "workflow-fragments.test.cjs"
+      ],
+      "issue": "3227",
+      "justification": "Grandfathered by #3227 when the testEffectivePrefix() dot/hyphen bucketing fix first made this pre-existing over-cap cluster visible to the gate; not new test sprawl."
+    },
+    "docs": {
+      "files": [
+        "docs-hooks-table-parity.test.cjs",
+        "docs-parity-live-registry.test.cjs",
+        "docs-state-md-locale-parity.test.cjs",
+        "docs-update.test.cjs"
+      ],
+      "issue": "3873 | #3839 \u2014 the hook-event parity suite cross-checks the four docs hook tables against src/runtime-hooks-surface.cts registrations; a generated-docs concern distinct from content freshness and registry parity",
+      "justification": "ADR-3473 \u00a78.8 makes docs/reference/state-md.md and its four locale siblings generated-and-committed and adds the repo's first locale-parity check (verified: no locale-parity lint precedent exists here). That check is a distinct concern from docs-update (content freshness) and docs-parity-live-registry (registry parity); folding it into either would place an unrelated subject inside them purely to satisfy a count. The section it guards is absent from all four translations today and documents the status enum behind #3853."
+    },
     "audit": {
       "files": [
         "audit-command-cutover.test.cjs",
         "audit-fix-command.test.cjs",
-        "fix-2766-audit-uat-archived-and-table-shapes.test.cjs"
+        "audit-milestone-filename-guard.test.cjs",
+        "audit-open-remainder-count.test.cjs",
+        "audit-uat-acknowledged.test.cjs",
+        "audit-workstream-layouts.test.cjs"
+      ],
+      "issue": "#3804/#3805 \u2014 audit-layout and acknowledged-marker suites drive the real audit-uat CLI against on-disk fixtures | #3817 \u2014 regression suite proving countReal counts the truncation remainder marker instead of treating it as one phantom item"
+    },
+    "shell-command-projection": {
+      "files": [
+        "shell-command-projection-dispatch.test.cjs",
+        "shell-command-projection-md-normalize.test.cjs",
+        "shell-command-projection-path-sep.test.cjs"
       ],
-      "issue": "2766"
+      "issue": "#3854 \u2014 the tight-list suite pins the markdown write-normalizer's blank-line policy through the exported normalizeContent/platformWriteSync seam; a distinct concern from dispatch routing and path separation"
     }
   }
 }

package/scripts/lint-test-file-count.cjs

@@ -74,7 +74,16 @@ function prodPrefix(filename) {
 function testEffectivePrefix(testName) {
   const bare = testName
     .replace(/\.integration\.test\.(ts|cjs)$/, '')
-    .replace(/\.test\.(ts|cjs)$/, '');
+    .replace(/\.test\.(ts|cjs)$/, '')
+    // #3227: strip a trailing suite/kind qualifier (`.unit`, `.property`,
+    // `.security`, `.slow`, `.install`, `.rule`, `.regression`, `.qa`, ...).
+    // A production prefix comes from `prodPrefix`, which strips only the file
+    // extension, so it never contains a dot — any surviving trailing `.<word>`
+    // is a qualifier. Without this, `frontmatter.property` matched no module at
+    // all (65 files counted against nothing repo-wide) and `state-contract.unit`
+    // matched the SHORTER `state` module through the `prefix + '-'` rule
+    // (9 files mis-bucketed).
+    .replace(/\.[a-z0-9]+$/i, '');
   const m = bare.match(/^(?:feat|bug|enh|fix)-\d+(?:-\d+)*-(.+)$/);
   return m ? m[1] : bare;
 }
@@ -109,12 +118,25 @@ function buildTestMap(prodPrefixes, allTestFiles) {
   const map = new Map([...prodPrefixes.keys()].map(p => [p, []]));
   for (const tf of allTestFiles) {
     const ep = testEffectivePrefix(path.basename(tf));
+    // fs.readdirSync order (and therefore prodPrefixes' Map insertion order,
+    // which is built from it in collectProdPrefixes) is NOT stable across
+    // platforms/filesystems — e.g. ext4 hash order on Linux CI differs from
+    // HFS+/APFS on macOS. When one module's name is a hyphen-extension of
+    // another's (e.g. `verify` and `verify-command-grounding`), first-match-
+    // wins bucketing is therefore platform-dependent. Scan every candidate
+    // and keep the longest (most specific) matching prefix, so the bucket a
+    // test file lands in is decided by specificity, never iteration order.
+    let bestPrefix = null;
     for (const prefix of prodPrefixes.keys()) {
       if (ep === prefix || ep.startsWith(prefix + '-')) {
-        map.get(prefix).push(tf);
-        break;
+        if (bestPrefix === null || prefix.length > bestPrefix.length) {
+          bestPrefix = prefix;
+        }
       }
     }
+    if (bestPrefix !== null) {
+      map.get(bestPrefix).push(tf);
+    }
   }
   return map;
 }