@opengsd/gsd-core 1.10.0 → 1.12.0

package/scripts/{test-failure-reasons.cjs → gsd-test-gate-reasons.cjs}

@@ -1,5 +1,11 @@
 'use strict';
 
+// Renamed (was `test-failure-reasons.cjs`): the old basename matched Node's
+// `test-*.EXT` test-collection pattern, so the remote push-gate runner
+// collected and executed this SOURCE file as a test while GitHub CI (which
+// globs only tests/**/*.test.cjs) never saw it — see
+// scripts/lint-source-test-name-collision.cjs.
+
 const TEST_GATE_REASON = Object.freeze({
   PASS: 'pass',
   TEST_FAILURE: 'test_failure',

package/scripts/lib/alias-drift-families.cjs

@@ -0,0 +1,46 @@
+'use strict';
+
+/**
+ * Single source of truth for the command-alias drift surface.
+ *
+ * Two parallel surfaces consume this: `scripts/check-alias-drift.cjs`, which
+ * validates the built alias artifacts, and `.githooks/pre-commit`, which decides
+ * when to run that validation. Until #2725 the hook's watched-path list had
+ * drifted from the checker's family table until every pattern named either the
+ * retired `sdk/` tree (ADR-0174) or a gitignored build output, so the guard was
+ * silently inert. Both surfaces derive from this list now, and
+ * `tests/precommit-alias-drift-hook.test.cjs` fails if they diverge again.
+ */
+
+/**
+ * Alias families the drift check validates. `router` is the module basename,
+ * shared by the `src/<router>.cts` source and the `gsd-core/bin/lib/<router>.cjs`
+ * artifact it compiles to.
+ */
+const FAMILIES = Object.freeze([
+  { commandAliases: 'STATE_COMMAND_ALIASES', subcommands: 'STATE_SUBCOMMANDS', router: 'state-command-router' },
+  { commandAliases: 'VERIFY_COMMAND_ALIASES', subcommands: 'VERIFY_SUBCOMMANDS', router: 'verify-command-router' },
+  { commandAliases: 'INIT_COMMAND_ALIASES', subcommands: 'INIT_SUBCOMMANDS', router: 'init-command-router' },
+  { commandAliases: 'PHASE_COMMAND_ALIASES', subcommands: 'PHASE_SUBCOMMANDS', router: 'phase-command-router' },
+  { commandAliases: 'PHASES_COMMAND_ALIASES', subcommands: 'PHASES_SUBCOMMANDS', router: 'phases-command-router' },
+  { commandAliases: 'VALIDATE_COMMAND_ALIASES', subcommands: 'VALIDATE_SUBCOMMANDS', router: 'validate-command-router' },
+  { commandAliases: 'ROADMAP_COMMAND_ALIASES', subcommands: 'ROADMAP_SUBCOMMANDS', router: 'roadmap-command-router' },
+  { commandAliases: 'EVAL_COMMAND_ALIASES', subcommands: 'EVAL_SUBCOMMANDS', router: 'eval-command-router' },
+].map(Object.freeze));
+
+/** Basename of the generated alias table every family is checked against. */
+const ALIAS_TABLE = 'command-aliases';
+
+/**
+ * Repo-relative TRACKED sources whose edit should re-run the drift check.
+ *
+ * Deliberately the `src/*.cts` sources, never the `gsd-core/bin/lib/*.cjs`
+ * build outputs they compile to: those are gitignored, so
+ * `git diff --cached --name-only` can never list them and a pre-commit guard
+ * keyed on them can never fire (#2725).
+ */
+function stagedSourcePaths() {
+  return [`src/${ALIAS_TABLE}.cts`, ...FAMILIES.map((family) => `src/${family.router}.cts`)];
+}
+
+module.exports = { FAMILIES, ALIAS_TABLE, stagedSourcePaths };

package/scripts/lib/ci-job-timing.cjs

@@ -0,0 +1,72 @@
+'use strict';
+
+/**
+ * scripts/lib/ci-job-timing.cjs
+ *
+ * Pure budget-percentage arithmetic shared by the in-job near-cap check
+ * (scripts/ci-check-job-near-cap.cjs) and the scheduled trending report
+ * (scripts/ci-timeout-report.cjs). See #4036.
+ */
+
+/** A job at or above this fraction of its `timeout-minutes` cap is "near-cap". */
+const THRESHOLD_PCT = 0.9;
+
+/**
+ * @param {{startedAt: string, completedAt: string, timeoutMinutes: number}} args
+ * @returns {{elapsedMs: number, capMs: number, pct: number}}
+ */
+function computeElapsedPct({ startedAt, completedAt, timeoutMinutes }) {
+  if (!Number.isFinite(timeoutMinutes) || timeoutMinutes <= 0) {
+    throw new Error(`timeoutMinutes must be a positive finite number, got ${timeoutMinutes}`);
+  }
+
+  const startMs = new Date(startedAt).getTime();
+  const endMs = new Date(completedAt).getTime();
+
+  if (!Number.isFinite(startMs)) {
+    throw new Error(`startedAt is not a valid timestamp: ${startedAt}`);
+  }
+  if (!Number.isFinite(endMs)) {
+    throw new Error(`completedAt is not a valid timestamp: ${completedAt}`);
+  }
+
+  const elapsedMs = endMs - startMs;
+  if (elapsedMs < 0) {
+    throw new Error(`completedAt (${completedAt}) is before startedAt (${startedAt})`);
+  }
+
+  const capMs = timeoutMinutes * 60000;
+  return { elapsedMs, capMs, pct: elapsedMs / capMs };
+}
+
+/**
+ * @param {number} pct
+ * @param {number} [threshold]
+ * @returns {boolean}
+ */
+function isNearCap(pct, threshold = THRESHOLD_PCT) {
+  return pct >= threshold;
+}
+
+/**
+ * @param {{label: string, pct: number, elapsedMs: number, capMs: number}} args
+ * @returns {{warningLine: string, summaryMarkdown: string}}
+ */
+function formatNearCapNotice({ label, pct, elapsedMs, capMs }) {
+  const pctStr = `${Math.round(pct * 100)}%`;
+  const elapsedMin = (elapsedMs / 60000).toFixed(1);
+  const capMin = (capMs / 60000).toFixed(1);
+  const detail = `${label} at ${pctStr} of its ${capMin}m cap (${elapsedMin}m elapsed)`;
+
+  return {
+    warningLine: `::warning title=CI budget::${detail}`,
+    summaryMarkdown: `- **${label}** — ${pctStr} of ${capMin}m cap (${elapsedMin}m elapsed)`,
+  };
+}
+
+module.exports = {
+  THRESHOLD_PCT,
+  computeElapsedPct,
+  isNearCap,
+  formatNearCapNotice,
+};