@open-mercato/core 0.4.5-develop-2e9903a57a → 0.4.5-develop-eeccf7adf4

package/src/modules/sales/__integration__/TC-SALES-020.spec.ts

@@ -1,107 +0,0 @@
-import { expect, test } from '@playwright/test';
-import { login } from '@open-mercato/core/modules/core/__integration__/helpers/auth';
-import { getAuthToken, apiRequest } from '@open-mercato/core/modules/core/__integration__/helpers/api';
-import { createSalesOrderFixture, deleteSalesEntityIfExists } from '@open-mercato/core/modules/core/__integration__/helpers/salesFixtures';
-
-const WIDGET_LOAD_TIMEOUT = 10_000;
-
-/**
- * TC-SALES-020: Document History Widget
- * Verifies the History tab renders all 3 entry kinds (action, status, comment)
- * and that each Filters dropdown option correctly scopes visible entries.
- *
- * Fixtures created via API (no reliance on seeded demo data):
- *   - Order creation  → 'action' entry (sales.orders.create command log)
- *   - Note creation   → 'comment' entry (SalesNote, source: note)
- *   - Status update   → 'status' entry (command bus before/after snapshot diff)
- */
-test.describe('TC-SALES-020: Document History Widget', () => {
-  test('should show action, status, and comment entries and filter each kind correctly', async ({ page }) => {
-    test.setTimeout(60_000);
-    const token = await getAuthToken(page.request, 'admin');
-    let orderId: string | null = null;
-
-    try {
-      // 1. Create order → logs an 'action' entry via sales.orders.create command
-      orderId = await createSalesOrderFixture(page.request, token);
-
-      // 2. Create a note → produces a 'comment' entry (SalesNote, source: 'note')
-      await apiRequest(page.request, 'POST', '/api/sales/notes', {
-        token,
-        data: { contextType: 'order', contextId: orderId, body: 'QA test history comment' },
-      });
-
-      // 3. Update order status → produces a 'status' entry via command-bus before/after snapshots
-      const statusListRes = await apiRequest(page.request, 'GET', '/api/sales/order-statuses?pageSize=5', { token });
-      expect(statusListRes.ok(), 'Failed to load order statuses').toBeTruthy();
-      const statusList = (await statusListRes.json()) as { items?: Array<{ id: string }> };
-      const statusId = statusList.items?.[0]?.id;
-      expect(statusId, 'No order statuses are seeded — cannot produce a status history entry').toBeTruthy();
-      await apiRequest(page.request, 'PUT', '/api/sales/orders', {
-        token,
-        data: { id: orderId, statusEntryId: statusId },
-      });
-
-      // --- Navigate to order detail page ---
-      await login(page, 'admin');
-      await page.goto(`/backend/sales/documents/${orderId}?kind=order`);
-      await page.waitForLoadState('networkidle');
-
-      // Open History tab
-      const historyButton = page.getByRole('button', { name: 'History', exact: true });
-      await expect(historyButton).toBeVisible({ timeout: WIDGET_LOAD_TIMEOUT });
-      await historyButton.scrollIntoViewIfNeeded();
-      await historyButton.click();
-
-      const filterButton = page.getByRole('button', { name: /Filters/i });
-      await expect(filterButton).toBeVisible({ timeout: WIDGET_LOAD_TIMEOUT });
-
-      // Wait for at least one timeline entry to be visible
-      await expect(page.locator('.relative.flex.gap-3').first()).toBeVisible({ timeout: WIDGET_LOAD_TIMEOUT });
-      await expect(page.getByText(/No history entries yet/i)).toHaveCount(0);
-
-      // --- Verify all 4 filter options are present ---
-      await filterButton.click();
-      const filterMenu = page.getByRole('listbox', { name: /Filters/i });
-      await expect(filterMenu).toBeVisible();
-      await expect(filterMenu.getByRole('option', { name: /^All$/i })).toBeVisible();
-      await expect(filterMenu.getByRole('option', { name: /Status changes/i })).toBeVisible();
-      await expect(filterMenu.getByRole('option', { name: /^Actions$/i })).toBeVisible();
-      await expect(filterMenu.getByRole('option', { name: /^Comments$/i })).toBeVisible();
-      await filterMenu.getByRole('option', { name: /^All$/i }).click();
-      await expect(filterMenu).toBeHidden();
-
-      // Helper: apply a filter and assert at least one entry is visible
-      const assertKindHasEntries = async (optionName: string | RegExp, label: string) => {
-        await page.getByRole('button', { name: /Filters/i }).click();
-        const menu = page.getByRole('listbox', { name: /Filters/i });
-        await expect(menu).toBeVisible();
-        await menu.getByRole('option', { name: optionName }).click();
-        await expect(menu).toBeHidden();
-        await expect(
-          page.getByText(/No history entries yet/i),
-          `"${label}" filter shows empty state — expected at least one entry`,
-        ).toHaveCount(0, { timeout: WIDGET_LOAD_TIMEOUT });
-        await expect(
-          page.locator('.relative.flex.gap-3').first(),
-          `"${label}" filter shows no timeline items`,
-        ).toBeVisible({ timeout: WIDGET_LOAD_TIMEOUT });
-      };
-
-      // Each of the 3 entry kinds must be present as real data
-      await assertKindHasEntries(/^Actions$/i, 'Actions');
-      await assertKindHasEntries(/Status changes/i, 'Status changes');
-      await assertKindHasEntries(/^Comments$/i, 'Comments');
-
-      // --- Reset to All and verify label clears ---
-      await page.getByRole('button', { name: /Filters/i }).click();
-      const resetMenu = page.getByRole('listbox', { name: /Filters/i });
-      await expect(resetMenu).toBeVisible();
-      await resetMenu.getByRole('option', { name: /^All$/i }).click();
-      await expect(resetMenu).toBeHidden();
-      await expect(page.getByRole('button', { name: /^Filters$/i })).toBeVisible();
-    } finally {
-      await deleteSalesEntityIfExists(page.request, token, '/api/sales/orders', orderId);
-    }
-  });
-});

package/src/modules/sales/api/__tests__/channels.route.test.ts

@@ -1,50 +0,0 @@
-import { buildSearchFilters, decorateChannelsWithOfferCounts, parseIdList } from '../channels/route'
-
-jest.mock('@open-mercato/shared/lib/i18n/server', () => ({
-  resolveTranslations: jest.fn().mockResolvedValue({
-    translate: (_key: string, fallback?: string) => fallback ?? _key,
-  }),
-}))
-
-describe('sales channels route helpers', () => {
-  it('parses UUID lists and discards invalid entries', () => {
-    expect(parseIdList('11111111-1111-4111-8111-111111111111, invalid, 22222222-2222-4222-8222-222222222222')).toEqual([
-      '11111111-1111-4111-8111-111111111111',
-      '22222222-2222-4222-8222-222222222222',
-    ])
-    expect(parseIdList(undefined)).toEqual([])
-  })
-
-  it('builds search filters with sanitized terms and flags', () => {
-    const filters = buildSearchFilters({
-      search: ' Flash % ',
-      ids: '11111111-1111-4111-8111-111111111111,00000000-0000-4000-8000-000000000000',
-      isActive: 'false',
-    } as any)
-
-    expect(filters.id).toEqual({ $in: ['11111111-1111-4111-8111-111111111111', '00000000-0000-4000-8000-000000000000'] })
-    expect(filters.$or).toEqual([
-      { name: { $ilike: '%Flash \\%%' } },
-      { code: { $ilike: '%Flash \\%%' } },
-      { description: { $ilike: '%Flash \\%%' } },
-    ])
-    expect(filters.is_active).toBe(false)
-  })
-
-  it('decorates listed channels with aggregated offer counts', async () => {
-    const items: Array<{ id: string | null; offerCount?: number }> = [{ id: 'ch-1' }, { id: 'ch-2' }, { id: null }]
-    const offers = [
-      { id: 'offer-1', channelId: 'ch-1' },
-      { id: 'offer-2', channelId: 'ch-1' },
-      { id: 'offer-3', channelId: 'ch-3' },
-    ]
-    const em = { find: jest.fn().mockResolvedValue(offers) }
-    const ctx = { container: { resolve: jest.fn().mockReturnValue(em) } } as any
-
-    await decorateChannelsWithOfferCounts({ items }, ctx)
-
-    expect(items[0].offerCount).toBe(2)
-    expect(items[1].offerCount).toBe(0)
-    expect(em.find).toHaveBeenCalledWith(expect.any(Function), { channelId: { $in: ['ch-1', 'ch-2'] }, deletedAt: null }, expect.any(Object))
-  })
-})

package/src/modules/sales/api/__tests__/document-history.test.ts

@@ -1,146 +0,0 @@
-import { detectStatusChange, normalizeActionLogToHistoryEntry } from '../../lib/historyHelpers'
-
-function makeLog(overrides: Partial<{
-  id: string
-  snapshotBefore: unknown
-  snapshotAfter: unknown
-  actionLabel: string | null
-  commandId: string
-  actorUserId: string | null
-  createdAt: Date
-}> = {}): any {
-  return {
-    id: 'log-1',
-    commandId: 'cmd-1',
-    actionLabel: 'Update sales order',
-    actorUserId: null,
-    createdAt: new Date('2024-01-01T10:00:00Z'),
-    snapshotBefore: null,
-    snapshotAfter: null,
-    ...overrides,
-  }
-}
-
-describe('detectStatusChange', () => {
-  it('returns null for creations (null snapshotBefore)', () => {
-    const log = makeLog({ snapshotBefore: null, snapshotAfter: { order: { status: 'draft' } } })
-    expect(detectStatusChange(log)).toBeNull()
-  })
-
-  it('detects direct status change from logStatusChange entries', () => {
-    const log = makeLog({
-      snapshotBefore: { status: 'draft' },
-      snapshotAfter: { status: 'confirmed' },
-    })
-    expect(detectStatusChange(log)).toEqual({ statusFrom: 'draft', statusTo: 'confirmed' })
-  })
-
-  it('detects null-to-value transition from dedicated logStatusChange entry', () => {
-    const log = makeLog({
-      snapshotBefore: { status: null },
-      snapshotAfter: { status: 'confirmed' },
-    })
-    expect(detectStatusChange(log)).toEqual({ statusFrom: null, statusTo: 'confirmed' })
-  })
-
-  it('detects status change in nested order snapshot from update commands', () => {
-    const log = makeLog({
-      snapshotBefore: { order: { id: 'o1', status: 'draft', note: 'x' } },
-      snapshotAfter: { order: { id: 'o1', status: 'confirmed', note: 'x' } },
-    })
-    expect(detectStatusChange(log)).toEqual({ statusFrom: 'draft', statusTo: 'confirmed' })
-  })
-
-  it('detects status change in nested quote snapshot from update commands', () => {
-    const log = makeLog({
-      snapshotBefore: { quote: { id: 'q1', status: 'pending' } },
-      snapshotAfter: { quote: { id: 'q1', status: 'accepted' } },
-    })
-    expect(detectStatusChange(log)).toEqual({ statusFrom: 'pending', statusTo: 'accepted' })
-  })
-
-  it('returns null when status did not change in update', () => {
-    const log = makeLog({
-      snapshotBefore: { order: { status: 'confirmed', note: 'old' } },
-      snapshotAfter: { order: { status: 'confirmed', note: 'new' } },
-    })
-    expect(detectStatusChange(log)).toBeNull()
-  })
-
-  it('returns null when neither snapshot has a status field', () => {
-    const log = makeLog({
-      snapshotBefore: { order: { note: 'old' } },
-      snapshotAfter: { order: { note: 'new' } },
-    })
-    expect(detectStatusChange(log)).toBeNull()
-  })
-})
-
-describe('normalizeActionLogToHistoryEntry', () => {
-  it('classifies as status when order snapshot contains a status change', () => {
-    const log = makeLog({
-      snapshotBefore: { order: { status: 'draft' } },
-      snapshotAfter: { order: { status: 'confirmed' } },
-      actionLabel: 'Update sales order',
-    })
-    const entry = normalizeActionLogToHistoryEntry(log, 'order')
-    expect(entry.kind).toBe('status')
-    expect(entry.metadata?.statusFrom).toBe('draft')
-    expect(entry.metadata?.statusTo).toBe('confirmed')
-    expect(entry.action).toBe('confirmed')
-  })
-
-  it('classifies as action when status did not change', () => {
-    const log = makeLog({
-      snapshotBefore: { order: { status: 'draft', note: 'old' } },
-      snapshotAfter: { order: { status: 'draft', note: 'new' } },
-      actionLabel: 'Update sales order',
-    })
-    const entry = normalizeActionLogToHistoryEntry(log, 'order')
-    expect(entry.kind).toBe('action')
-    expect(entry.action).toBe('Update sales order')
-  })
-
-  it('classifies create as action (null snapshotBefore)', () => {
-    const log = makeLog({
-      snapshotBefore: null,
-      snapshotAfter: { order: { status: 'draft' } },
-      actionLabel: 'Create sales order',
-    })
-    const entry = normalizeActionLogToHistoryEntry(log, 'order')
-    expect(entry.kind).toBe('action')
-    expect(entry.action).toBe('Create sales order')
-  })
-
-  it('resolves actor name from displayUsers map', () => {
-    const log = makeLog({ actorUserId: 'user-uuid-1' })
-    const entry = normalizeActionLogToHistoryEntry(log, 'order', { 'user-uuid-1': 'Jane Doe' })
-    expect(entry.actor.label).toBe('Jane Doe')
-    expect(entry.actor.id).toBe('user-uuid-1')
-  })
-
-  it('falls back to userId string when not in displayUsers map', () => {
-    const log = makeLog({ actorUserId: 'user-uuid-2' })
-    const entry = normalizeActionLogToHistoryEntry(log, 'order', {})
-    expect(entry.actor.label).toBe('user-uuid-2')
-  })
-
-  it('uses "system" for null actorUserId', () => {
-    const log = makeLog({ actorUserId: null })
-    const entry = normalizeActionLogToHistoryEntry(log, 'order')
-    expect(entry.actor.label).toBe('system')
-    expect(entry.actor.id).toBeNull()
-  })
-
-  it('uses commandId as action fallback when actionLabel is null', () => {
-    const log = makeLog({ actionLabel: null, commandId: 'my-command-id' })
-    const entry = normalizeActionLogToHistoryEntry(log, 'order')
-    expect(entry.action).toBe('my-command-id')
-  })
-
-  it('includes documentKind in metadata', () => {
-    const log = makeLog()
-    expect(normalizeActionLogToHistoryEntry(log, 'order').metadata?.documentKind).toBe('order')
-    expect(normalizeActionLogToHistoryEntry(log, 'quote').metadata?.documentKind).toBe('quote')
-  })
-})

package/src/modules/sales/api/__tests__/documents.factory.test.ts

@@ -1,98 +0,0 @@
-/** @jest-environment node */
-
-jest.mock('@open-mercato/shared/lib/i18n/server', () => ({
-  resolveTranslations: jest.fn().mockResolvedValue({
-    translate: (_key: string, fallback?: string) => fallback ?? _key,
-  }),
-}))
-
-jest.mock('@open-mercato/core/generated/entities.ids.generated', () => ({
-  E: {
-    sales: {
-      sales_order: 'sales:sales_order',
-      sales_quote: 'sales:sales_quote',
-    },
-  },
-}))
-
-import { buildDocumentCrudOptions } from '../documents/factory'
-import { SalesOrder, SalesQuote } from '../../data/entities'
-import { E } from '#generated/entities.ids.generated'
-
-describe('buildDocumentCrudOptions', () => {
-  describe('buildFilters', () => {
-    const orderBinding = {
-      kind: 'order' as const,
-      entity: SalesOrder,
-      entityId: E.sales.sales_order,
-      numberField: 'orderNumber' as const,
-      createCommandId: 'sales.orders.create',
-      updateCommandId: 'sales.orders.update',
-      deleteCommandId: 'sales.orders.delete',
-      manageFeature: 'sales.orders.manage',
-      viewFeature: 'sales.orders.view',
-    }
-
-    const quoteBinding = {
-      kind: 'quote' as const,
-      entity: SalesQuote,
-      entityId: E.sales.sales_quote,
-      numberField: 'quoteNumber' as const,
-      createCommandId: 'sales.quotes.create',
-      updateCommandId: 'sales.quotes.update',
-      deleteCommandId: 'sales.quotes.delete',
-      manageFeature: 'sales.quotes.manage',
-      viewFeature: 'sales.quotes.view',
-    }
-
-    it('should filter orders by order_number when search is provided', async () => {
-      const options = buildDocumentCrudOptions(orderBinding)
-      const filters = await options.list.buildFilters({ search: 'ORD-123' })
-
-      expect(filters).toEqual({
-        order_number: { $ilike: '%ORD-123%' },
-      })
-    })
-
-    it('should filter quotes by quote_number when search is provided', async () => {
-      const options = buildDocumentCrudOptions(quoteBinding)
-      const filters = await options.list.buildFilters({ search: 'QUO-456' })
-
-      expect(filters).toEqual({
-        quote_number: { $ilike: '%QUO-456%' },
-      })
-    })
-
-    it('should escape percent signs in search term', async () => {
-      const options = buildDocumentCrudOptions(orderBinding)
-      const filters = await options.list.buildFilters({ search: '50%' })
-
-      expect(filters).toEqual({
-        order_number: { $ilike: '%50\\%%' },
-      })
-    })
-
-    it('should trim whitespace from search term', async () => {
-      const options = buildDocumentCrudOptions(orderBinding)
-      const filters = await options.list.buildFilters({ search: '  ORD-123  ' })
-
-      expect(filters).toEqual({
-        order_number: { $ilike: '%ORD-123%' },
-      })
-    })
-
-    it('should not add filter when search is empty', async () => {
-      const options = buildDocumentCrudOptions(orderBinding)
-      const filters = await options.list.buildFilters({ search: '' })
-
-      expect(filters).toEqual({})
-    })
-
-    it('should not add filter when search is whitespace only', async () => {
-      const options = buildDocumentCrudOptions(orderBinding)
-      const filters = await options.list.buildFilters({ search: '   ' })
-
-      expect(filters).toEqual({})
-    })
-  })
-})

package/src/modules/sales/api/__tests__/documents.routes.test.ts

@@ -1,149 +0,0 @@
-/** @jest-environment node */
-import { PUT as updateOrder } from '@open-mercato/core/modules/sales/api/orders/route'
-import { PUT as updateQuote } from '@open-mercato/core/modules/sales/api/quotes/route'
-
-const mockCommandBus = { execute: jest.fn() }
-const mockDataEngine = {
-  updateOrmEntity: jest.fn(),
-  markOrmEntityChange: jest.fn(),
-  flushOrmEntityChanges: jest.fn(),
-}
-const mockEm = {
-  findOne: jest.fn(),
-  fork: jest.fn(),
-}
-
-jest.mock('@open-mercato/shared/lib/auth/server', () => ({
-  getAuthFromRequest: jest.fn(),
-}))
-
-jest.mock('@open-mercato/shared/lib/di/container', () => ({
-  createRequestContainer: jest.fn(async () => ({
-    resolve: (token: string) => {
-      if (token === 'commandBus') return mockCommandBus
-      if (token === 'dataEngine') return mockDataEngine
-      if (token === 'em') return mockEm
-      if (token === 'accessLogService') return null
-      return null
-    },
-  })),
-}))
-
-jest.mock('@open-mercato/shared/lib/i18n/server', () => ({
-  resolveTranslations: jest.fn().mockResolvedValue({
-    translate: (_key: string, fallback?: string) => fallback ?? _key,
-  }),
-}))
-
-jest.mock('@open-mercato/core/modules/directory/utils/organizationScope', () => ({
-  resolveOrganizationScopeForRequest: jest.fn(),
-}))
-
-function makeRequest(body: unknown) {
-  return new Request('http://localhost/api/sales/documents', {
-    method: 'PUT',
-    headers: { 'content-type': 'application/json' },
-    body: JSON.stringify(body),
-  })
-}
-
-function setupEntityMocks() {
-  mockEm.fork.mockReturnValue(mockEm)
-  mockEm.findOne.mockResolvedValue(null)
-  mockDataEngine.updateOrmEntity.mockImplementation(async ({ apply }: any) => {
-    const entity = {
-      id: 'doc-1',
-      organizationId: 'org-1',
-      tenantId: 'tenant-1',
-      comments: null,
-      customerEntityId: null,
-      customerContactId: null,
-      customerSnapshot: null,
-      billingAddressId: null,
-      shippingAddressId: null,
-      billingAddressSnapshot: null,
-      shippingAddressSnapshot: null,
-      shippingMethodId: null,
-      shippingMethodCode: null,
-      shippingMethodSnapshot: null,
-      paymentMethodId: null,
-      paymentMethodCode: null,
-      paymentMethodSnapshot: null,
-      currencyCode: 'USD',
-      channelId: null,
-      statusEntryId: null,
-      status: null,
-      placedAt: null,
-      expectedDeliveryAt: null,
-      metadata: null,
-    }
-    await apply(entity)
-    return entity
-  })
-  mockDataEngine.markOrmEntityChange.mockResolvedValue(undefined)
-  mockDataEngine.flushOrmEntityChanges.mockResolvedValue(undefined)
-}
-
-describe('sales document update routes', () => {
-  beforeEach(async () => {
-    jest.clearAllMocks()
-    setupEntityMocks()
-    const { getAuthFromRequest } = await import('@open-mercato/shared/lib/auth/server')
-    const { resolveOrganizationScopeForRequest } = await import('@open-mercato/core/modules/directory/utils/organizationScope')
-    ;(getAuthFromRequest as jest.Mock).mockResolvedValue({
-      sub: 'user-1',
-      tenantId: '00000000-0000-4000-8000-000000000000',
-      orgId: '11111111-1111-4111-8111-111111111111',
-    })
-    ;(resolveOrganizationScopeForRequest as jest.Mock).mockResolvedValue({
-      selectedId: '11111111-1111-4111-8111-111111111111',
-      filterIds: ['11111111-1111-4111-8111-111111111111'],
-      allowedIds: ['11111111-1111-4111-8111-111111111111'],
-    })
-    mockCommandBus.execute.mockImplementation(async (commandId: string, payload: any) => {
-      const id =
-        payload?.input?.id ??
-        payload?.input?.body?.id ??
-        payload?.input?.query?.id ??
-        '00000000-0000-4000-8000-000000000000'
-      const entityKey = commandId.includes('quote') ? 'quote' : 'order'
-      return {
-        result: { [entityKey]: { id } },
-        logEntry: {
-          id: 'log-1',
-          undoToken: 'undo-1',
-          commandId,
-          resourceId: id,
-          resourceKind: commandId.includes('quote') ? 'sales.quote' : 'sales.order',
-          createdAt: new Date().toISOString(),
-        },
-      }
-    })
-  })
-
-  it('uses command bus for order updates and returns operation metadata', async () => {
-    const res = await updateOrder(makeRequest({ id: '22222222-2222-4222-8222-222222222222', comment: 'Updated order' }))
-
-    expect(res.status).toBe(200)
-    expect(mockCommandBus.execute).toHaveBeenCalledWith(
-      'sales.orders.update',
-      expect.objectContaining({
-        input: expect.objectContaining({ id: '22222222-2222-4222-8222-222222222222', comment: 'Updated order' }),
-      })
-    )
-    expect(res.headers.get('x-om-operation')).toBeTruthy()
-  })
-
-  it('uses command bus for quote updates and returns operation metadata', async () => {
-    const res = await updateQuote(makeRequest({ id: '33333333-3333-4333-8333-333333333333', comment: 'Updated quote' }))
-
-    expect(res.status).toBe(200)
-    expect(mockCommandBus.execute).toHaveBeenCalledWith(
-      'sales.quotes.update',
-      expect.objectContaining({
-        input: expect.objectContaining({ id: '33333333-3333-4333-8333-333333333333', comment: 'Updated quote' }),
-      })
-    )
-    expect(res.headers.get('x-om-operation')).toBeTruthy()
-  })
-})