@open-mercato/core 0.4.5-develop-2e9903a57a → 0.4.5-develop-eeccf7adf4

package/src/modules/customers/components/detail/__tests__/ActivityForm.validation.test.ts

@@ -1,37 +0,0 @@
-jest.mock('@open-mercato/ui/backend/CrudForm', () => ({
-  CrudForm: () => null,
-}))
-
-import { z } from 'zod'
-import { buildActivityValidationError } from '../ActivityForm'
-
-describe('buildActivityValidationError', () => {
-  const t = (key: string, fallback?: string) => fallback ?? key
-
-  it('throws CrudFormError with field mapping when available', () => {
-    const issue: z.ZodIssue = {
-      code: z.ZodIssueCode.custom,
-      message: 'Activity type is required',
-      path: ['activityType'],
-    }
-    const thrower = () => buildActivityValidationError([issue], t)
-    expect(thrower).toThrow('Activity type is required')
-    try {
-      thrower()
-    } catch (error) {
-      expect(error).toMatchObject({
-        message: 'Activity type is required',
-        fieldErrors: { activityType: 'Activity type is required' },
-      })
-    }
-  })
-
-  it('uses fallback message when missing', () => {
-    const issue: z.ZodIssue = {
-      code: z.ZodIssueCode.custom,
-      message: undefined as unknown as string,
-      path: [],
-    }
-    expect(() => buildActivityValidationError([issue], t)).toThrow('customers.people.detail.activities.error')
-  })
-})

package/src/modules/customers/components/detail/__tests__/DealForm.validation.test.ts

@@ -1,45 +0,0 @@
-jest.mock('@open-mercato/ui/backend/CrudForm', () => ({
-  CrudForm: () => null,
-}))
-jest.mock('react-markdown', () => ({
-  __esModule: true,
-  default: () => null,
-}))
-jest.mock('remark-gfm', () => ({
-  __esModule: true,
-  default: () => undefined,
-}))
-
-import { z } from 'zod'
-import { buildDealValidationError } from '../DealForm'
-
-describe('buildDealValidationError', () => {
-  const t = (key: string, fallback?: string) => fallback ?? key
-
-  it('throws CrudFormError with message and field when available', () => {
-    const issue: z.ZodIssue = {
-      code: z.ZodIssueCode.custom,
-      message: 'Title is required',
-      path: ['title'],
-    }
-    const thrower = () => buildDealValidationError([issue], t)
-    expect(thrower).toThrow('Title is required')
-    try {
-      thrower()
-    } catch (error) {
-      expect(error).toMatchObject({
-        message: 'Title is required',
-        fieldErrors: { title: 'Title is required' },
-      })
-    }
-  })
-
-  it('throws with fallback message when issue is missing', () => {
-    const issue: z.ZodIssue = {
-      code: z.ZodIssueCode.custom,
-      message: undefined as unknown as string,
-      path: [],
-    }
-    expect(() => buildDealValidationError([issue], t)).toThrow('Failed to save deal.')
-  })
-})

package/src/modules/customers/components/detail/__tests__/InlineEditors.test.tsx

@@ -1,166 +0,0 @@
-/**
- * @jest-environment jsdom
- */
-import * as React from 'react'
-import { fireEvent, render, screen } from '@testing-library/react'
-import { InlineMultilineEditor, InlineTextEditor, renderMultilineMarkdownDisplay } from '../InlineEditors'
-
-// jsdom does not provide requestAnimationFrame by default.
-;(global as any).requestAnimationFrame =
-  (global as any).requestAnimationFrame || ((cb: FrameRequestCallback) => setTimeout(cb, 0))
-
-const reactMarkdownMock = jest.fn((props: any) => <div data-testid="react-markdown">{props.children}</div>)
-
-jest.mock('react-markdown', () => ({
-  __esModule: true,
-  default: (props: any) => reactMarkdownMock(props),
-}))
-
-jest.mock('remark-gfm', () => ({
-  __esModule: true,
-  default: () => null,
-}))
-
-jest.mock('next/dynamic', () => () => {
-  return function MockDynamicComponent(props: any) {
-    return <div data-testid="dynamic-import" {...props} />
-  }
-})
-
-jest.mock('@uiw/react-md-editor', () => (props: any) => {
-  return <textarea data-testid="markdown-editor" value={props.value ?? ''} onChange={(event) => props.onChange?.(event.target.value)} />
-})
-
-jest.mock('@open-mercato/ui/primitives/button', () => ({
-  Button: ({ children, ...props }: any) => (
-    <button type={props.type || 'button'} {...props}>
-      {children}
-    </button>
-  ),
-}))
-
-jest.mock('@open-mercato/ui/backend/detail', () => ({
-  LoadingMessage: ({ label }: { label?: string }) => <div>{label ?? 'loading'}</div>,
-}))
-
-jest.mock('@open-mercato/ui/backend/FlashMessages', () => ({
-  flash: jest.fn(),
-}))
-
-jest.mock('@open-mercato/ui/backend/inputs/PhoneNumberField', () => ({
-  PhoneNumberField: ({ value, onValueChange, placeholder }: any) => (
-    <input
-      data-testid="phone-input"
-      value={value ?? ''}
-      onChange={(event) => onValueChange?.(event.target.value)}
-      placeholder={placeholder}
-    />
-  ),
-}))
-
-jest.mock('@tanstack/react-query', () => ({
-  useQueryClient: () => ({
-    invalidateQueries: jest.fn(),
-  }),
-}))
-
-jest.mock('@open-mercato/shared/lib/i18n/context', () => ({
-  useT: () => (key: string, fallback?: string) => fallback ?? key,
-}))
-
-jest.mock('../../../backend/hooks/useEmailDuplicateCheck', () => ({
-  useEmailDuplicateCheck: () => ({ duplicate: null, checking: false }),
-}))
-
-jest.mock('../../../utils/phoneDuplicates', () => ({
-  lookupPhoneDuplicate: jest.fn(),
-}))
-
-jest.mock('@open-mercato/core/modules/dictionaries/components/AppearanceSelector', () => ({
-  AppearanceSelector: ({ children }: { children?: React.ReactNode }) => <div>{children}</div>,
-}))
-
-jest.mock('@open-mercato/shared/lib/i18n/context', () => ({
-  useT: () => (key: string, fallback?: string) => fallback ?? key,
-}))
-
-describe('Inline multiline editors', () => {
-  it('renders markdown preview and falls back to empty label', () => {
-    const { rerender } = render(
-      <>
-        {renderMultilineMarkdownDisplay({
-          value: 'Hello **world**',
-          emptyLabel: 'Empty state',
-        })}
-      </>,
-    )
-
-    expect(reactMarkdownMock).toHaveBeenCalledWith(
-      expect.objectContaining({
-        children: 'Hello **world**',
-        remarkPlugins: expect.any(Array),
-      }),
-    )
-
-    rerender(
-      <>
-        {renderMultilineMarkdownDisplay({
-          value: '   ',
-          emptyLabel: 'Empty state',
-        })}
-      </>,
-    )
-
-    expect(screen.getByText('Empty state')).toBeInTheDocument()
-  })
-
-  it('activates edit mode on click and shows save shortcut label', () => {
-    const handleSave = jest.fn().mockResolvedValue(undefined)
-    const { container } = render(
-      <InlineMultilineEditor
-        label="Description"
-        value="Link text"
-        placeholder="Description"
-        emptyLabel="No description"
-        onSave={handleSave}
-        renderDisplay={({ value }) => (
-          <a href="https://example.com" data-testid="description-link">
-            {value}
-          </a>
-        )}
-        activateOnClick
-      />,
-    )
-
-    const wrapper = container.firstChild as HTMLElement
-    expect(wrapper).toHaveClass('cursor-pointer')
-
-    const link = screen.getByTestId('description-link')
-    fireEvent.click(link)
-
-    expect(screen.getByRole('textbox')).toBeInTheDocument()
-    expect(screen.getByText('Save ⌘⏎ / Ctrl+Enter')).toBeInTheDocument()
-  })
-})
-
-describe('Inline text editor', () => {
-  it('renders save shortcut label with fallback text', () => {
-    const handleSave = jest.fn().mockResolvedValue(undefined)
-    render(
-      <InlineTextEditor
-        label="Domain"
-        value="https://example.com"
-        placeholder="Domain"
-        emptyLabel="No domain"
-        onSave={handleSave}
-        activateOnClick
-        type="url"
-      />,
-    )
-
-    fireEvent.click(screen.getByRole('link'))
-
-    expect(screen.getByRole('textbox')).toBeInTheDocument()
-    expect(screen.getByText('Save ⌘⏎ / Ctrl+Enter')).toBeInTheDocument()
-  })
-})

package/src/modules/customers/components/detail/__tests__/TaskForm.submit.test.ts

@@ -1,21 +0,0 @@
-jest.mock('@open-mercato/ui/backend/CrudForm', () => ({
-  CrudForm: () => null,
-}))
-
-import { buildTaskSubmitPayload } from '../TaskForm'
-
-describe('buildTaskSubmitPayload', () => {
-  const t = (key: string, fallback?: string) => fallback ?? key
-
-  it('throws when title is missing', () => {
-    expect(() => buildTaskSubmitPayload({}, t)).toThrow('Task name is required.')
-  })
-
-  it('returns normalized payload when title is provided', () => {
-    const payload = buildTaskSubmitPayload({ title: '  Follow up  ', is_done: true, cf_priority: 'high' }, t)
-    expect(payload).toEqual({
-      base: { title: 'Follow up', is_done: true },
-      custom: { priority: 'high' },
-    })
-  })
-})

package/src/modules/customers/components/detail/hooks/__tests__/useCustomerDictionary.test.ts

@@ -1,97 +0,0 @@
-import { QueryClient } from '@tanstack/query-core'
-import {
-  ensureCustomerDictionary,
-  invalidateCustomerDictionary,
-} from '../useCustomerDictionary'
-
-jest.mock('@open-mercato/ui/backend/utils/apiCall', () => ({
-  readApiResultOrThrow: jest.fn(),
-}))
-
-import { readApiResultOrThrow } from '@open-mercato/ui/backend/utils/apiCall'
-
-const mockReadApiResultOrThrow = readApiResultOrThrow as jest.Mock
-
-const createApiResponse = (items: unknown[]) => ({ items })
-
-describe('ensureCustomerDictionary', () => {
-  let queryClient: QueryClient
-
-  beforeEach(() => {
-    queryClient = new QueryClient()
-    mockReadApiResultOrThrow.mockReset()
-  })
-
-  afterEach(() => {
-    queryClient?.clear?.()
-  })
-
-  it('normalizes API payload into dictionary data', async () => {
-    mockReadApiResultOrThrow.mockResolvedValueOnce(
-      createApiResponse([
-        {
-          id: 'status-1',
-          value: 'new',
-          label: 'New',
-          color: '#AABBCC',
-          icon: '⭐',
-          organizationId: 'org-123',
-          isInherited: false,
-        },
-      ]),
-    )
-
-    const result = await ensureCustomerDictionary(queryClient, 'statuses', 0)
-
-    expect(mockReadApiResultOrThrow).toHaveBeenCalledWith(
-      '/api/customers/dictionaries/statuses',
-      undefined,
-      { errorMessage: 'Failed to load dictionary entries.' },
-    )
-    expect(result.entries).toEqual([
-      { value: 'new', label: 'New', color: '#aabbcc', icon: '⭐' },
-    ])
-    expect(result.map['new']).toEqual({ value: 'new', label: 'New', color: '#aabbcc', icon: '⭐' })
-    expect(result.fullEntries[0]).toMatchObject({
-      id: 'status-1',
-      value: 'new',
-      label: 'New',
-      color: '#aabbcc',
-      icon: '⭐',
-      organizationId: 'org-123',
-      isInherited: false,
-    })
-  })
-
-  it('refetches freshly after invalidation and returns updated entries', async () => {
-    mockReadApiResultOrThrow
-      .mockResolvedValueOnce(createApiResponse([{ id: 'status-1', value: 'alpha', label: 'Alpha' }]))
-      .mockResolvedValueOnce(createApiResponse([{ id: 'status-2', value: 'beta', label: 'Beta' }]))
-
-    const first = await ensureCustomerDictionary(queryClient, 'statuses', 0)
-    expect(first.entries.map((entry) => entry.value)).toEqual(['alpha'])
-    expect(mockReadApiResultOrThrow).toHaveBeenCalledTimes(1)
-
-    await invalidateCustomerDictionary(queryClient, 'statuses')
-
-    const second = await ensureCustomerDictionary(queryClient, 'statuses', 0)
-    expect(mockReadApiResultOrThrow).toHaveBeenCalledTimes(2)
-    expect(second.entries.map((entry) => entry.value)).toEqual(['beta'])
-  })
-
-  it('isolates cached data per scope version', async () => {
-    mockReadApiResultOrThrow
-      .mockResolvedValueOnce(createApiResponse([{ id: 'source-1', value: 'scope-0', label: 'Scope Zero' }]))
-      .mockResolvedValueOnce(createApiResponse([{ id: 'source-2', value: 'scope-1', label: 'Scope One' }]))
-
-    const scopeZero = await ensureCustomerDictionary(queryClient, 'sources', 0)
-    expect(scopeZero.entries[0]?.value).toBe('scope-0')
-
-    const scopeOne = await ensureCustomerDictionary(queryClient, 'sources', 1)
-    expect(scopeOne.entries[0]?.value).toBe('scope-1')
-
-    const cachedKeys = queryClient.getQueryCache().findAll().map((query) => query.queryKey)
-    expect(cachedKeys).toContainEqual(['customers', 'dictionaries', 'sources', 'scope:0'])
-    expect(cachedKeys).toContainEqual(['customers', 'dictionaries', 'sources', 'scope:1'])
-  })
-})

package/src/modules/customers/lib/__tests__/customFieldRouting.test.ts

@@ -1,107 +0,0 @@
-import {
-  CUSTOMER_ENTITY_ID,
-  PERSON_ENTITY_ID,
-  resolvePersonCustomFieldRouting,
-  mergePersonCustomFieldValues,
-} from '../customFieldRouting'
-import { CustomFieldDef } from '@open-mercato/core/modules/entities/data/entities'
-
-describe('customers lib - custom field routing', () => {
-  it('prefers definitions with higher score and lower penalty', async () => {
-    const find = jest.fn().mockResolvedValue([
-      {
-        id: 'def-1',
-        key: 'priority',
-        kind: 'dictionary',
-        configJson: JSON.stringify({ filterable: true, priority: 5 }),
-        entityId: CUSTOMER_ENTITY_ID,
-      },
-      {
-        id: 'def-2',
-        key: 'priority',
-        kind: 'dictionary',
-        configJson: JSON.stringify({ filterable: true, priority: 1 }),
-        entityId: PERSON_ENTITY_ID,
-      },
-      {
-        id: 'def-3',
-        key: 'notes',
-        kind: 'multiline',
-        configJson: null,
-        entityId: PERSON_ENTITY_ID,
-      },
-    ])
-
-    const em = { find } as unknown as Parameters<typeof resolvePersonCustomFieldRouting>[0]
-
-    const routing = await resolvePersonCustomFieldRouting(em, 'tenant-1', 'org-1')
-
-    expect(find).toHaveBeenCalledTimes(1)
-    const [, where] = find.mock.calls[0]
-    expect(where).toMatchObject({
-      entityId: { $in: expect.arrayContaining([CUSTOMER_ENTITY_ID, PERSON_ENTITY_ID]) },
-      deletedAt: null,
-      isActive: true,
-    })
-    expect(where.$and).toEqual(
-      expect.arrayContaining([
-        { $or: [{ tenantId: 'tenant-1' }, { tenantId: null }] },
-        { $or: [{ organizationId: 'org-1' }, { organizationId: null }] },
-      ])
-    )
-
-    expect(routing.get('priority')).toBe(PERSON_ENTITY_ID)
-    expect(routing.get('notes')).toBe(PERSON_ENTITY_ID)
-  })
-
-  it('falls back to customer entity when scores are equal', async () => {
-    const find = jest.fn().mockResolvedValue([
-      {
-        id: 'def-1',
-        key: 'priority',
-        kind: 'dictionary',
-        configJson: { filterable: true, priority: 2 },
-        entityId: CUSTOMER_ENTITY_ID,
-      },
-      {
-        id: 'def-2',
-        key: 'priority',
-        kind: 'dictionary',
-        configJson: { filterable: true, priority: 2 },
-        entityId: PERSON_ENTITY_ID,
-      },
-    ])
-    const em = { find } as unknown as Parameters<typeof resolvePersonCustomFieldRouting>[0]
-    const routing = await resolvePersonCustomFieldRouting(em, null, null)
-    expect(find).toHaveBeenCalledWith(CustomFieldDef, expect.any(Object))
-    const [, where] = find.mock.calls[0]
-    expect(where.$and).toEqual([{ tenantId: null }])
-    expect(routing.get('priority')).toBe(CUSTOMER_ENTITY_ID)
-  })
-
-  it('merges customer and profile custom field values correctly', () => {
-    const routing = new Map<string, string>([
-      ['fieldA', PERSON_ENTITY_ID],
-      ['fieldB', CUSTOMER_ENTITY_ID],
-      ['fieldC', PERSON_ENTITY_ID],
-    ])
-    const entityValues = {
-      cf_fieldB: 'entity-value',
-      cf_fieldC: 'old-value',
-    }
-    const profileValues = {
-      cf_fieldA: 'profile-A',
-      fieldB: 'profile-should-not-overwrite',
-      cf_fieldC: 'profile-C',
-      cf_fieldD: 'profile-D',
-    }
-    const merged = mergePersonCustomFieldValues(routing, entityValues, profileValues)
-    expect(merged).toEqual({
-      cf_fieldB: 'entity-value',
-      cf_fieldC: 'profile-C',
-      cf_fieldA: 'profile-A',
-      cf_fieldD: 'profile-D',
-      fieldB: 'profile-should-not-overwrite',
-    })
-  })
-})

package/src/modules/customers/utils/__tests__/addressFormat.test.ts

@@ -1,105 +0,0 @@
-import {
-  formatAddressJson,
-  formatAddressLines,
-  formatAddressString,
-} from '../addressFormat'
-
-describe('customers utils - address formatting', () => {
-  it('normalizes address fields to trimmed values or null', () => {
-    const json = formatAddressJson(
-      {
-        addressLine1: '  123 Baker Street  ',
-        addressLine2: '  Suite 5 ',
-        buildingNumber: ' 10 ',
-        flatNumber: ' 2B ',
-        postalCode: ' NW1 ',
-        city: ' London ',
-        region: '  Greater London ',
-      country: '  UK ',
-      companyName: '  Widgets Inc. ',
-    },
-    'street_first'
-  )
-  expect(json).toEqual({
-    format: 'street_first',
-    companyName: 'Widgets Inc.',
-    addressLine1: '123 Baker Street',
-    addressLine2: 'Suite 5',
-    buildingNumber: '10',
-      flatNumber: '2B',
-      postalCode: 'NW1',
-      city: 'London',
-      region: 'Greater London',
-      country: 'UK',
-    })
-  })
-
-  it('formats lines in street_first mode with merged street data', () => {
-    const lines = formatAddressLines(
-      {
-        addressLine1: 'Baker Street',
-        addressLine2: 'Suite 5',
-        buildingNumber: '10',
-        flatNumber: '2B',
-        postalCode: 'NW1',
-        city: 'London',
-        region: 'Greater London',
-        country: 'UK',
-      },
-      'street_first'
-    )
-    expect(lines).toEqual([
-      'Baker Street 10/2B',
-      'Suite 5',
-      'NW1 London',
-      'Greater London',
-      'UK',
-    ])
-  })
-
-  it('adds company name as the first line when present', () => {
-    const lines = formatAddressLines(
-      {
-        companyName: 'Widgets Inc.',
-        addressLine1: 'Baker Street',
-        buildingNumber: '10',
-        postalCode: 'NW1',
-        city: 'London',
-      },
-      'street_first'
-    )
-    expect(lines[0]).toBe('Widgets Inc.')
-    expect(lines.slice(1)).toEqual(['Baker Street 10', 'NW1 London'])
-  })
-
-  it('formats lines in line_first mode preserving primary line', () => {
-    const lines = formatAddressLines(
-      {
-        addressLine1: 'Headquarters',
-        addressLine2: 'North Entrance',
-        buildingNumber: '10',
-        postalCode: 'NW1',
-        city: 'London',
-        country: 'UK',
-      },
-      'line_first'
-    )
-    expect(lines).toEqual([
-      'Headquarters 10',
-      'North Entrance',
-      'NW1 London',
-      'UK',
-    ])
-  })
-
-  it('joins formatted lines into a single string', () => {
-    const address = {
-      addressLine1: 'Baker Street',
-      buildingNumber: '10',
-      postalCode: 'NW1',
-      city: 'London',
-    }
-    expect(formatAddressString(address, 'street_first')).toBe('Baker Street 10, NW1 London')
-    expect(formatAddressString(address, 'line_first', ' | ')).toBe('Baker Street 10 | NW1 London')
-  })
-})

package/src/modules/customers/utils/__tests__/phoneDuplicates.test.ts

@@ -1,98 +0,0 @@
-jest.mock('@open-mercato/ui/backend/utils/apiCall', () => ({
-  apiCall: jest.fn(),
-}))
-
-import { lookupPhoneDuplicate } from '../phoneDuplicates'
-import { apiCall } from '@open-mercato/ui/backend/utils/apiCall'
-
-const mockedApiCall = apiCall as jest.MockedFunction<typeof apiCall>
-
-const createResponse = (payload: unknown, ok = true) => {
-  return {
-    ok,
-    status: ok ? 200 : 500,
-    result: payload,
-    response: {} as Response,
-    cacheStatus: null,
-  }
-}
-
-describe('customers utils - phone duplicate lookup', () => {
-  beforeEach(() => {
-    mockedApiCall.mockReset()
-  })
-
-  it('returns null when no digits are provided', async () => {
-    const result = await lookupPhoneDuplicate(' (   ) ')
-    expect(result).toBeNull()
-    expect(mockedApiCall).not.toHaveBeenCalled()
-  })
-
-  it('returns first matching duplicate and builds link', async () => {
-    mockedApiCall.mockResolvedValueOnce(
-      createResponse({
-        items: [
-          { id: 'c1', display_name: 'Ada Lovelace', primary_phone: '+1 (555) 123-4567' },
-        ],
-        total: 1,
-      })
-    )
-    const result = await lookupPhoneDuplicate('+1 555 123-4567')
-    expect(result).toEqual({
-      id: 'c1',
-      label: 'Ada Lovelace',
-      href: '/backend/customers/people/c1',
-    })
-    expect(mockedApiCall).toHaveBeenCalledWith(
-      '/api/customers/people?hasPhone=true&page=1&pageSize=50&sortField=createdAt&sortDir=desc'
-    )
-  })
-
-  it('skips current record and continues scanning subsequent pages', async () => {
-    mockedApiCall
-      .mockResolvedValueOnce(
-        createResponse({
-          items: [
-            { id: 'current', display_name: 'Keep', primary_phone: '+1 555 123-4567' },
-          ],
-          total: 120,
-        })
-      )
-      .mockResolvedValueOnce(
-        createResponse({
-          items: [
-            { id: 'duplicate', display_name: 'Grace Hopper', primary_phone: '+1 555 123-4567' },
-          ],
-          total: 120,
-        })
-      )
-      .mockResolvedValue(createResponse({ items: [], total: 120 }))
-
-    const result = await lookupPhoneDuplicate('+1 555 123-4567', { recordId: 'current' })
-    expect(result).toEqual({
-      id: 'duplicate',
-      label: 'Grace Hopper',
-      href: '/backend/customers/people/duplicate',
-    })
-    expect(mockedApiCall).toHaveBeenCalledTimes(2)
-  })
-
-  it('ignores failed requests and returns null when nothing matches', async () => {
-    mockedApiCall
-      .mockRejectedValueOnce(new Error('network'))
-      .mockResolvedValueOnce(
-        createResponse({
-          items: [
-            { id: 'c1', display_name: 'Incomplete', primary_phone: '+1 555 000-0000' },
-            { id: 'c2', display_name: null, primary_phone: '+1 555 123-4567' },
-          ],
-          total: 200,
-        })
-      )
-      .mockResolvedValue(createResponse({ items: [], total: 200 }))
-
-    const result = await lookupPhoneDuplicate('+1 555 999-9999')
-    expect(result).toBeNull()
-    expect(mockedApiCall).toHaveBeenCalledTimes(3)
-  })
-})