@open-mercato/core 0.4.5-develop-2e9903a57a → 0.4.5-develop-eeccf7adf4

package/src/modules/notifications/__tests__/deliver-notification.test.ts

@@ -1,285 +0,0 @@
-import type { Notification } from '../data/entities'
-import type { NotificationDeliveryConfig } from '../lib/deliveryConfig'
-import type { NotificationDeliveryStrategy } from '../lib/deliveryStrategies'
-
-const sendEmail = jest.fn()
-const getNotificationDeliveryStrategies = jest.fn()
-const resolveNotificationDeliveryConfig = jest.fn()
-const resolveNotificationPanelUrl = jest.fn()
-const findOneWithDecryption = jest.fn()
-const NotificationEmail = jest.fn(() => 'notification-email')
-
-jest.mock('@open-mercato/shared/lib/email/send', () => ({
-  sendEmail: (...args: unknown[]) => sendEmail(...args),
-}))
-
-jest.mock('../lib/deliveryStrategies', () => ({
-  getNotificationDeliveryStrategies: (...args: unknown[]) => getNotificationDeliveryStrategies(...args),
-}))
-
-jest.mock('../lib/deliveryConfig', () => ({
-  DEFAULT_NOTIFICATION_DELIVERY_CONFIG: {
-    panelPath: '/backend/notifications',
-    strategies: {
-      database: { enabled: true },
-      email: { enabled: true },
-      custom: {},
-    },
-  },
-  resolveNotificationDeliveryConfig: (...args: unknown[]) => resolveNotificationDeliveryConfig(...args),
-  resolveNotificationPanelUrl: (...args: unknown[]) => resolveNotificationPanelUrl(...args),
-}))
-
-jest.mock('@open-mercato/shared/lib/i18n/server', () => ({
-  loadDictionary: jest.fn().mockResolvedValue({}),
-}))
-
-jest.mock('@open-mercato/shared/lib/i18n/translate', () => ({
-  createFallbackTranslator: () => (key: string, fallback?: string) => fallback ?? key,
-}))
-
-jest.mock('@open-mercato/shared/lib/encryption/find', () => ({
-  findOneWithDecryption: (...args: unknown[]) => findOneWithDecryption(...args),
-}))
-
-jest.mock('../emails/NotificationEmail', () => ({
-  __esModule: true,
-  default: (...args: unknown[]) => NotificationEmail(...args),
-}))
-
-describe('deliver notification subscriber', () => {
-  const notification: Notification = {
-    id: '32e22a6e-7aa9-4f3b-8a7b-42c2d1223a5f',
-    recipientUserId: '3eae68bb-1e4c-4b21-85c7-b8f5b2c22b01',
-    tenantId: 'c33b6f78-8c4b-4ef4-9c54-2b64b5f5d0d0',
-    organizationId: null,
-    type: 'system',
-    title: 'New notification',
-    body: 'Check details',
-    titleKey: null,
-    bodyKey: null,
-    titleVariables: null,
-    bodyVariables: null,
-    icon: null,
-    severity: 'info',
-    actionData: {
-      actions: [{ id: 'action-1', label: 'Review' }],
-      primaryActionId: 'action-1',
-    },
-    sourceModule: null,
-    sourceEntityType: null,
-    sourceEntityId: null,
-    linkHref: null,
-    groupKey: null,
-    status: 'unread',
-    readAt: null,
-    actionedAt: null,
-    dismissedAt: null,
-    createdAt: new Date(),
-    updatedAt: new Date(),
-    expiresAt: null,
-    actionTaken: null,
-    actionResult: null,
-  } as Notification
-
-  const baseConfig: NotificationDeliveryConfig = {
-    appUrl: 'https://app.example.com',
-    panelPath: '/backend/notifications',
-    strategies: {
-      database: { enabled: true },
-      email: {
-        enabled: true,
-        from: 'notifications@example.com',
-        replyTo: 'reply@example.com',
-        subjectPrefix: '[OM]',
-      },
-      custom: {},
-    },
-  }
-
-  beforeEach(() => {
-    jest.clearAllMocks()
-  })
-
-  it('sends email notifications when enabled', async () => {
-    resolveNotificationDeliveryConfig.mockResolvedValue(baseConfig)
-    resolveNotificationPanelUrl.mockReturnValue('https://app.example.com/backend/notifications')
-    getNotificationDeliveryStrategies.mockReturnValue([])
-    findOneWithDecryption.mockResolvedValue({ email: 'user@example.com', name: 'User' })
-
-    const em = {
-      findOne: jest.fn().mockResolvedValue(notification),
-    }
-
-    const { default: handle } = await import('../subscribers/deliver-notification')
-
-    await handle(
-      {
-        notificationId: notification.id,
-        recipientUserId: notification.recipientUserId,
-        tenantId: notification.tenantId,
-        organizationId: null,
-      },
-      {
-        resolve: (name: string) => {
-          if (name === 'em') return em
-          throw new Error(`Missing dependency: ${name}`)
-        },
-      }
-    )
-
-    expect(NotificationEmail).toHaveBeenCalledWith(
-      expect.objectContaining({
-        title: notification.title,
-        panelUrl: `https://app.example.com/backend/notifications?notificationId=${notification.id}`,
-      })
-    )
-    expect(sendEmail).toHaveBeenCalledWith(
-      expect.objectContaining({
-        to: 'user@example.com',
-        from: baseConfig.strategies.email.from,
-        replyTo: baseConfig.strategies.email.replyTo,
-        subject: `${baseConfig.strategies.email.subjectPrefix} ${notification.title}`,
-      })
-    )
-  })
-
-  it('executes enabled custom delivery strategies', async () => {
-    const customStrategy: NotificationDeliveryStrategy = {
-      id: 'webhook',
-      deliver: jest.fn(),
-    }
-    resolveNotificationDeliveryConfig.mockResolvedValue({
-      ...baseConfig,
-      strategies: {
-        ...baseConfig.strategies,
-        email: { enabled: false },
-        custom: {
-          webhook: { enabled: true, config: { url: 'https://hooks.example.com' } },
-        },
-      },
-    })
-    resolveNotificationPanelUrl.mockReturnValue('https://app.example.com/backend/notifications')
-    getNotificationDeliveryStrategies.mockReturnValue([customStrategy])
-    findOneWithDecryption.mockResolvedValue({ email: 'user@example.com', name: 'User' })
-
-    const em = {
-      findOne: jest.fn().mockResolvedValue(notification),
-    }
-
-    const { default: handle } = await import('../subscribers/deliver-notification')
-
-    await handle(
-      {
-        notificationId: notification.id,
-        recipientUserId: notification.recipientUserId,
-        tenantId: notification.tenantId,
-        organizationId: null,
-      },
-      {
-        resolve: (name: string) => {
-          if (name === 'em') return em
-          throw new Error(`Missing dependency: ${name}`)
-        },
-      }
-    )
-
-    expect(customStrategy.deliver).toHaveBeenCalledWith(
-      expect.objectContaining({
-        config: { enabled: true, config: { url: 'https://hooks.example.com' } },
-        panelLink: `https://app.example.com/backend/notifications?notificationId=${notification.id}`,
-      })
-    )
-    expect(sendEmail).not.toHaveBeenCalled()
-  })
-
-  it('uses action href when provided instead of panelLink', async () => {
-    const notificationWithActionHref: Notification = {
-      ...notification,
-      actionData: {
-        actions: [
-          { id: 'view', label: 'View Details', href: '/backend/orders/123' },
-        ],
-        primaryActionId: 'view',
-      },
-    } as Notification
-
-    resolveNotificationDeliveryConfig.mockResolvedValue(baseConfig)
-    resolveNotificationPanelUrl.mockReturnValue('https://app.example.com/backend/notifications')
-    getNotificationDeliveryStrategies.mockReturnValue([])
-    findOneWithDecryption.mockResolvedValue({ email: 'user@example.com', name: 'User' })
-
-    const em = {
-      findOne: jest.fn().mockResolvedValue(notificationWithActionHref),
-    }
-
-    const { default: handle } = await import('../subscribers/deliver-notification')
-
-    await handle(
-      {
-        notificationId: notificationWithActionHref.id,
-        recipientUserId: notificationWithActionHref.recipientUserId,
-        tenantId: notificationWithActionHref.tenantId,
-        organizationId: null,
-      },
-      {
-        resolve: (name: string) => {
-          if (name === 'em') return em
-          throw new Error(`Missing dependency: ${name}`)
-        },
-      }
-    )
-
-    expect(NotificationEmail).toHaveBeenCalledWith(
-      expect.objectContaining({
-        actions: [
-          {
-            id: 'view',
-            label: 'View Details',
-            href: 'https://app.example.com/backend/orders/123',
-          },
-        ],
-      })
-    )
-  })
-
-  it('returns null when appUrl is missing', async () => {
-    const configWithoutAppUrl: NotificationDeliveryConfig = {
-      panelPath: '/backend/notifications',
-      strategies: {
-        database: { enabled: true },
-        email: { enabled: true },
-        custom: {},
-      },
-    }
-
-    resolveNotificationDeliveryConfig.mockResolvedValue(configWithoutAppUrl)
-    resolveNotificationPanelUrl.mockReturnValue(null)
-    getNotificationDeliveryStrategies.mockReturnValue([])
-    findOneWithDecryption.mockResolvedValue({ email: 'user@example.com', name: 'User' })
-
-    const em = {
-      findOne: jest.fn().mockResolvedValue(notification),
-    }
-
-    const { default: handle } = await import('../subscribers/deliver-notification')
-
-    await handle(
-      {
-        notificationId: notification.id,
-        recipientUserId: notification.recipientUserId,
-        tenantId: notification.tenantId,
-        organizationId: null,
-      },
-      {
-        resolve: (name: string) => {
-          if (name === 'em') return em
-          throw new Error(`Missing dependency: ${name}`)
-        },
-      }
-    )
-
-    // Email should not be sent when panelUrl is null
-    expect(sendEmail).not.toHaveBeenCalled()
-  })
-})

package/src/modules/notifications/__tests__/deliveryStrategies.test.ts

@@ -1,19 +0,0 @@
-import { type NotificationDeliveryStrategy } from '../lib/deliveryStrategies'
-
-describe('notification delivery strategies', () => {
-  it('orders strategies by priority', async () => {
-    jest.resetModules()
-    const { registerNotificationDeliveryStrategy, getNotificationDeliveryStrategies } = await import('../lib/deliveryStrategies')
-
-    const first: NotificationDeliveryStrategy = { id: 'first', deliver: jest.fn() }
-    const second: NotificationDeliveryStrategy = { id: 'second', deliver: jest.fn() }
-    const third: NotificationDeliveryStrategy = { id: 'third', deliver: jest.fn() }
-
-    registerNotificationDeliveryStrategy(first, { priority: 1 })
-    registerNotificationDeliveryStrategy(second, { priority: 10 })
-    registerNotificationDeliveryStrategy(third, { priority: 5 })
-
-    const ids = getNotificationDeliveryStrategies().map((strategy) => strategy.id)
-    expect(ids).toEqual(['second', 'third', 'first'])
-  })
-})

package/src/modules/notifications/__tests__/notificationService.test.ts

@@ -1,248 +0,0 @@
-import { createNotificationService } from '../lib/notificationService'
-import { NOTIFICATION_EVENTS } from '../lib/events'
-import type { Notification } from '../data/entities'
-import { getRecipientUserIdsForFeature } from '../lib/notificationRecipients'
-
-jest.mock('../lib/notificationRecipients', () => ({
-  getRecipientUserIdsForRole: jest.fn(),
-  getRecipientUserIdsForFeature: jest.fn(),
-}))
-
-const baseNotificationInput = {
-  type: 'system',
-  title: 'Hello',
-  recipientUserId: '2d4a4c33-9c4b-4e39-8e15-0a3cd9a7f432',
-} as const
-
-const baseCtx = {
-  tenantId: '7f4c85ef-f8f7-4e53-9df1-42e95bd8d48e',
-  organizationId: null,
-  userId: '2d4a4c33-9c4b-4e39-8e15-0a3cd9a7f432',
-}
-
-const buildEm = () => {
-  const em = {
-    fork: jest.fn(),
-    transactional: jest.fn(),
-    create: jest.fn(),
-    persistAndFlush: jest.fn(),
-    flush: jest.fn(),
-    findOne: jest.fn(),
-    findOneOrFail: jest.fn(),
-    count: jest.fn(),
-    find: jest.fn(),
-    getConnection: jest.fn(),
-  }
-  em.fork.mockReturnValue(em)
-  em.transactional.mockImplementation(async (cb: (tx: typeof em) => Promise<unknown>) => cb(em))
-  em.getConnection.mockReturnValue({
-    getKnex: () => ({}),
-  })
-  return em
-}
-
-describe('notification service', () => {
-  beforeEach(() => {
-    jest.clearAllMocks()
-  })
-
-  it('creates a notification and emits event', async () => {
-    const em = buildEm()
-    const eventBus = { emit: jest.fn().mockResolvedValue(undefined) }
-
-    em.create.mockImplementation((_entity, data: Notification) => ({
-      id: 'note-1',
-      ...data,
-    }))
-
-    const service = createNotificationService({ em, eventBus })
-
-    const notification = await service.create(baseNotificationInput, baseCtx)
-
-    expect(notification.id).toBe('note-1')
-    expect(em.flush).toHaveBeenCalled()
-    expect(eventBus.emit).toHaveBeenCalledWith(
-      NOTIFICATION_EVENTS.CREATED,
-      expect.objectContaining({
-        notificationId: notification.id,
-        recipientUserId: baseNotificationInput.recipientUserId,
-        tenantId: baseCtx.tenantId,
-      })
-    )
-  })
-
-  it('reuses grouped notification instead of creating duplicates', async () => {
-    const em = buildEm()
-    const eventBus = { emit: jest.fn().mockResolvedValue(undefined) }
-    const existing = {
-      id: 'note-existing',
-      recipientUserId: baseNotificationInput.recipientUserId,
-      tenantId: baseCtx.tenantId,
-      organizationId: null,
-      type: 'system',
-      groupKey: 'system:record:1',
-      status: 'read',
-      createdAt: new Date('2026-02-21T09:00:00.000Z'),
-    } as Notification
-
-    em.findOne.mockResolvedValue(existing)
-
-    const service = createNotificationService({ em, eventBus })
-
-    const notification = await service.create({
-      ...baseNotificationInput,
-      body: 'Updated body',
-      groupKey: 'system:record:1',
-    }, baseCtx)
-
-    expect(notification.id).toBe('note-existing')
-    expect(em.create).not.toHaveBeenCalled()
-    expect(notification.status).toBe('unread')
-    expect(notification.body).toBe('Updated body')
-    expect(em.flush).toHaveBeenCalled()
-    expect(eventBus.emit).toHaveBeenCalledWith(
-      NOTIFICATION_EVENTS.CREATED,
-      expect.objectContaining({
-        notificationId: 'note-existing',
-      }),
-    )
-  })
-
-  it('creates batch notifications and emits events for each', async () => {
-    const em = buildEm()
-    const eventBus = { emit: jest.fn().mockResolvedValue(undefined) }
-
-    em.create.mockImplementation((_entity, data: Notification) => ({
-      id: `note-${data.recipientUserId}`,
-      ...data,
-    }))
-
-    const service = createNotificationService({ em, eventBus })
-
-    const notifications = await service.createBatch(
-      {
-        type: 'system',
-        title: 'Hello',
-        recipientUserIds: ['e2c9ac54-ecdb-4d79-8d73-8328ca0f16f0', 'e2d9e79c-3f2f-4b8c-9455-6c19b671dc5c'],
-      },
-      baseCtx
-    )
-
-    expect(notifications).toHaveLength(2)
-    expect(em.flush).toHaveBeenCalled()
-    expect(eventBus.emit).toHaveBeenCalledTimes(2)
-  })
-
-  it('returns empty list when no recipients match feature', async () => {
-    const em = buildEm()
-    const eventBus = { emit: jest.fn().mockResolvedValue(undefined) }
-    const service = createNotificationService({ em, eventBus })
-
-    ;(getRecipientUserIdsForFeature as jest.Mock).mockResolvedValue([])
-
-    const result = await service.createForFeature(
-      {
-        type: 'system',
-        title: 'Hello',
-        requiredFeature: 'notifications.view',
-      },
-      baseCtx
-    )
-
-    expect(result).toEqual([])
-    expect(em.flush).not.toHaveBeenCalled()
-    expect(eventBus.emit).not.toHaveBeenCalled()
-  })
-
-  it('marks a notification as read and emits event', async () => {
-    const em = buildEm()
-    const eventBus = { emit: jest.fn().mockResolvedValue(undefined) }
-    const service = createNotificationService({ em, eventBus })
-
-    const notification: Notification = {
-      id: 'note-2',
-      recipientUserId: baseCtx.userId ?? null,
-      tenantId: baseCtx.tenantId,
-      status: 'unread',
-      readAt: null,
-    } as Notification
-
-    em.findOneOrFail.mockResolvedValue(notification)
-
-    const result = await service.markAsRead(notification.id, baseCtx)
-
-    expect(result.status).toBe('read')
-    expect(result.readAt).toBeInstanceOf(Date)
-    expect(em.flush).toHaveBeenCalled()
-    expect(eventBus.emit).toHaveBeenCalledWith(
-      NOTIFICATION_EVENTS.READ,
-      expect.objectContaining({
-        notificationId: notification.id,
-        userId: baseCtx.userId,
-        tenantId: baseCtx.tenantId,
-      })
-    )
-  })
-
-  it('executes notification action via command bus', async () => {
-    const em = buildEm()
-    const eventBus = { emit: jest.fn().mockResolvedValue(undefined) }
-    const commandBus = { execute: jest.fn().mockResolvedValue({ result: { ok: true } }) }
-    const container = { resolve: jest.fn() }
-    const service = createNotificationService({ em, eventBus, commandBus, container })
-
-    const notification: Notification = {
-      id: 'note-3',
-      recipientUserId: baseCtx.userId ?? null,
-      tenantId: baseCtx.tenantId,
-      status: 'unread',
-      readAt: null,
-      sourceEntityId: '1f9d8d1c-319f-48d4-b803-77665b6b2510',
-      actionData: {
-        actions: [
-          {
-            id: 'approve',
-            label: 'Approve',
-            commandId: 'sales.approve',
-          },
-        ],
-        primaryActionId: 'approve',
-      },
-    } as Notification
-
-    em.findOneOrFail.mockResolvedValue(notification)
-
-    const result = await service.executeAction(
-      notification.id,
-      { actionId: 'approve', payload: { note: 'ok' } },
-      baseCtx
-    )
-
-    expect(commandBus.execute).toHaveBeenCalledWith(
-      'sales.approve',
-      expect.objectContaining({
-        input: expect.objectContaining({
-          id: notification.sourceEntityId,
-          note: 'ok',
-        }),
-        metadata: expect.objectContaining({
-          tenantId: baseCtx.tenantId,
-          organizationId: baseCtx.organizationId,
-          resourceKind: 'notifications',
-        }),
-      })
-    )
-    expect(result.result).toEqual({ ok: true })
-    expect(notification.status).toBe('actioned')
-    expect(notification.actionTaken).toBe('approve')
-    expect(eventBus.emit).toHaveBeenCalledWith(
-      NOTIFICATION_EVENTS.ACTIONED,
-      expect.objectContaining({
-        notificationId: notification.id,
-        actionId: 'approve',
-        userId: baseCtx.userId,
-        tenantId: baseCtx.tenantId,
-      })
-    )
-  })
-})

package/src/modules/planner/__tests__/availabilityMerge.test.ts

@@ -1,99 +0,0 @@
-process.env.TZ = 'UTC'
-
-import { getMergedAvailabilityWindows, type AvailabilityRange, type AvailabilityRuleLike } from '../lib/availabilityMerge'
-
-function toIsoWindow(window: { start: Date; end: Date }) {
-  return { start: window.start.toISOString(), end: window.end.toISOString() }
-}
-
-describe('getMergedAvailabilityWindows', () => {
-  it('expands daily rules and respects exdates', () => {
-    const range: AvailabilityRange = {
-      start: new Date('2024-01-01T00:00:00Z'),
-      end: new Date('2024-01-04T00:00:00Z'),
-    }
-    const rules: AvailabilityRuleLike[] = [
-      {
-        id: 'rule-1',
-        rrule: 'DTSTART:20240101T090000Z;DURATION:PT2H;FREQ=DAILY;COUNT=3',
-        exdates: ['2024-01-02'],
-      },
-    ]
-
-    const windows = getMergedAvailabilityWindows({ rules, range }).map(toIsoWindow)
-
-    expect(windows).toEqual([
-      { start: '2024-01-01T09:00:00.000Z', end: '2024-01-01T11:00:00.000Z' },
-      { start: '2024-01-03T09:00:00.000Z', end: '2024-01-03T11:00:00.000Z' },
-    ])
-  })
-
-  it('subtracts unavailability windows from availability', () => {
-    const range: AvailabilityRange = {
-      start: new Date('2024-01-01T00:00:00Z'),
-      end: new Date('2024-01-02T00:00:00Z'),
-    }
-    const rules: AvailabilityRuleLike[] = [
-      {
-        id: 'availability',
-        rrule: 'DTSTART:20240101T090000Z;DURATION:PT8H;FREQ=DAILY',
-        kind: 'availability',
-      },
-      {
-        id: 'unavailability',
-        rrule: 'DTSTART:20240101T120000Z;DURATION:PT1H;FREQ=DAILY',
-        kind: 'unavailability',
-      },
-    ]
-
-    const windows = getMergedAvailabilityWindows({ rules, range }).map(toIsoWindow)
-
-    expect(windows).toEqual([
-      { start: '2024-01-01T09:00:00.000Z', end: '2024-01-01T12:00:00.000Z' },
-      { start: '2024-01-01T13:00:00.000Z', end: '2024-01-01T17:00:00.000Z' },
-    ])
-  })
-
-  it('drops availability on days overridden by once unavailability rules', () => {
-    const range: AvailabilityRange = {
-      start: new Date('2024-01-02T00:00:00Z'),
-      end: new Date('2024-01-03T00:00:00Z'),
-    }
-    const rules: AvailabilityRuleLike[] = [
-      {
-        id: 'availability',
-        rrule: 'DTSTART:20240101T090000Z;DURATION:PT8H;FREQ=DAILY',
-        kind: 'availability',
-      },
-      {
-        id: 'override',
-        rrule: 'DTSTART:20240102T090000Z;DURATION:PT1H;FREQ=DAILY;COUNT=1',
-        kind: 'unavailability',
-      },
-    ]
-
-    const windows = getMergedAvailabilityWindows({ rules, range })
-
-    expect(windows).toEqual([])
-  })
-
-  it('creates a full-day window for once availability overrides', () => {
-    const range: AvailabilityRange = {
-      start: new Date('2024-01-02T00:00:00Z'),
-      end: new Date('2024-01-03T00:00:00Z'),
-    }
-    const rules: AvailabilityRuleLike[] = [
-      {
-        id: 'override',
-        rrule: 'DTSTART:20240102T090000Z;DURATION:PT1H;FREQ=DAILY;COUNT=1',
-        kind: 'availability',
-      },
-    ]
-
-    const windows = getMergedAvailabilityWindows({ rules, range }).map(toIsoWindow)
-
-    expect(windows).toEqual([
-      { start: '2024-01-02T00:00:00.000Z', end: '2024-01-03T00:00:00.000Z' },
-    ])
-  })
-})