@oneuptime/common 14.0.3 → 14.0.5

package/Tests/UI/Components/HeaderRightRail.test.tsx

@@ -67,11 +67,18 @@ describe("Header right-hand rail", () => {
   });
 
   test("an entry can still opt itself out of small screens", () => {
+    /*
+     * Written the way the dashboard's own call site writes it:
+     * `max-lg:hidden`, not `hidden`. A foreign `.hidden { display: none
+     * !important }` rule (Bootstrap 3, HTML5 Boilerplate, a browser
+     * extension) beats `lg:flex`, so the bare-`hidden` form of this opt-out
+     * also takes the entry off every desktop.
+     */
     render(
       <Header
         rightComponents={
           <>
-            <div className="hidden items-center lg:flex">
+            <div className="max-lg:hidden items-center lg:flex">
               <button type="button">Ask AI</button>
             </div>
             <button type="button">Profile</button>
@@ -87,11 +94,44 @@ describe("Header right-hand rail", () => {
 
     expect(isVisibleAtWidth(askAi, PHONE_WIDTH_IN_PX)).toBe(false);
     expect(isVisibleAtWidth(askAi, LAPTOP_WIDTH_IN_PX)).toBe(true);
+    expect(
+      isVisibleAtWidth(askAi, LAPTOP_WIDTH_IN_PX, {
+        withForeignHiddenRule: true,
+      }),
+    ).toBe(true);
 
     // ... without dragging its neighbours off the screen with it.
     expect(isVisibleAtWidth(profile, PHONE_WIDTH_IN_PX)).toBe(true);
   });
 
+  test("the bare-hidden form of that opt-out is lost on a desktop to a foreign .hidden rule", () => {
+    render(
+      <Header
+        rightComponents={
+          <div className="hidden items-center lg:flex">
+            <button type="button">Ask AI</button>
+          </div>
+        }
+      />,
+    );
+
+    const askAi: HTMLElement = screen.getByRole("button", { name: "Ask AI" });
+
+    /*
+     * Identical to the max-lg form on a clean page, which is why the
+     * difference never showed up in review ...
+     */
+    expect(isVisibleAtWidth(askAi, PHONE_WIDTH_IN_PX)).toBe(false);
+    expect(isVisibleAtWidth(askAi, LAPTOP_WIDTH_IN_PX)).toBe(true);
+
+    // ... and gone at every width on the customer's page.
+    expect(
+      isVisibleAtWidth(askAi, LAPTOP_WIDTH_IN_PX, {
+        withForeignHiddenRule: true,
+      }),
+    ).toBe(false);
+  });
+
   test("left and center components still render alongside the rail", () => {
     render(
       <Header

package/Tests/UI/Components/LogsEntityNames.test.ts

@@ -233,6 +233,7 @@ describe("LOGS_RESOURCE_FACET_ENTITY_TYPES", () => {
       cloudResourceId: ServiceType.CloudResource,
       rumApplicationId: ServiceType.RealUserMonitor,
       iotFleetId: ServiceType.IoTDevice,
+      databaseServerId: ServiceType.DatabaseServer,
     });
   });
 
@@ -1499,7 +1500,7 @@ describe("catalog resource types the viewer does not preload", () => {
       },
     );
 
-  test("are exactly the eight new catalog types", () => {
+  test("are exactly the catalog types beyond the four preloaded ones", () => {
     expect(
       unpreloaded.map((definition: ResourceFacetDefinition): string => {
         return definition.facetKey;
@@ -1513,6 +1514,7 @@ describe("catalog resource types the viewer does not preload", () => {
       "cloudResourceId",
       "rumApplicationId",
       "iotFleetId",
+      "databaseServerId",
     ]);
   });
 
@@ -1675,6 +1677,19 @@ describe("catalog resource types the viewer does not preload", () => {
     );
   });
 
+  test("a Database id is hinted DatabaseServer, straight to its own table", () => {
+    const id: string = idFor(8);
+    expect(
+      collectLogsEntityIdsToResolve({
+        filters: [chip("databaseServerId", id, "Database")],
+        maps,
+      }).typeHints,
+    ).toEqual({ [id]: ServiceType.DatabaseServer });
+    expect(TELEMETRY_ENTITY_TYPES[ServiceType.DatabaseServer].label).toBe(
+      "Database",
+    );
+  });
+
   test("the preloaded four still skip the resolver when their maps name them", () => {
     const request: LogsEntityResolutionRequest = collectLogsEntityIdsToResolve({
       filters: [

package/Tests/UI/Components/LogsFacetSidebarHiddenFacets.test.tsx

@@ -233,15 +233,19 @@ describe("LogsFacetSidebar hides empty resource facets", () => {
 
     render(sidebarElement({ facetData: allEmpty }));
 
+    // One per catalog type (thirteen, Databases included).
+    const count: number = RESOURCE_FACET_CATALOG.length;
+    expect(count).toBe(13);
+
     expect(sectionTitles()).toEqual(["Severity"]);
-    expect(footer()).toHaveTextContent("12 empty filters hidden");
-    expect(screen.getByText("12 empty filters hidden")).toHaveAttribute(
+    expect(footer()).toHaveTextContent(`${count} empty filters hidden`);
+    expect(screen.getByText(`${count} empty filters hidden`)).toHaveAttribute(
       "title",
       CATALOG_LABELS.join(", "),
     );
 
     fireEvent.click(
-      screen.getByRole("button", { name: "Show 12 empty filters" }),
+      screen.getByRole("button", { name: `Show ${count} empty filters` }),
     );
 
     expect(sectionTitles()).toEqual(["Severity", ...CATALOG_LABELS]);

package/Tests/UI/Components/ResourceFacetConfigs.test.ts

@@ -26,7 +26,7 @@ describe("buildResourceFacetConfigs", () => {
         return config.key;
       }),
     ).toEqual([...RESOURCE_FACET_CATALOG_KEYS]);
-    expect(configs).toHaveLength(12);
+    expect(configs).toHaveLength(13);
   });
 
   test("covers every resource type, not only the original four", () => {
@@ -49,6 +49,7 @@ describe("buildResourceFacetConfigs", () => {
       "cloudResourceId",
       "rumApplicationId",
       "iotFleetId",
+      "databaseServerId",
     ]) {
       expect(keys).toContain(key);
     }

package/Tests/UI/Components/RuleCriteria/RuleCriteriaModelTable.test.tsx

@@ -332,9 +332,9 @@ More details stay here.
       },
     );
 
-    expect(staticRuleFormFiles).toHaveLength(64);
-    expect(helpFormFiles).toHaveLength(57);
-    expect(helpMarkdown).toHaveLength(63);
+    expect(staticRuleFormFiles).toHaveLength(66);
+    expect(helpFormFiles).toHaveLength(59);
+    expect(helpMarkdown).toHaveLength(65);
 
     for (const markdown of helpMarkdown) {
       const transformed: string = replaceRuleCriteriaHelpMarkdown(markdown);