@oneuptime/common 14.0.3 → 14.0.5

package/Tests/Types/Monitor/Recommendation/MonitorRecommendationCatalog.test.ts

@@ -8,6 +8,8 @@ import {
   buildRecommendationId,
 } from "../../../../Types/Monitor/Recommendation/MonitorRecommendationTypes";
 import MonitorType from "../../../../Types/Monitor/MonitorType";
+import MonitorStep from "../../../../Types/Monitor/MonitorStep";
+import ObjectID from "../../../../Types/ObjectID";
 
 import { getAllCephAlertTemplates } from "../../../../Types/Monitor/CephAlertTemplates";
 import { getAllDockerAlertTemplates } from "../../../../Types/Monitor/DockerAlertTemplates";
@@ -24,6 +26,22 @@ import {
   getLanguagesWithServiceAlertTemplates,
   getServiceAlertTemplates,
 } from "../../../../Types/Monitor/ServiceAlertTemplates";
+import {
+  DatabaseAlertTemplate,
+  getAllDatabaseAlertTemplates,
+  getDatabaseAlertTemplates,
+  getDatabaseEnginesWithAlertTemplates,
+} from "../../../../Types/Monitor/DatabaseAlertTemplates";
+
+/*
+ * Resource types whose recommendation set is EMPTY without context, on
+ * purpose: a database with no known engine has no template that applies to
+ * it (every database template reads one engine receiver's metrics). Every
+ * other resource type has a non-empty context-free subset, and the tests
+ * below keep holding them to that.
+ */
+const RESOURCE_TYPES_WITHOUT_CONTEXT_FREE_SUBSET: Array<MonitorRecommendationResourceType> =
+  [MonitorRecommendationResourceType.DatabaseServer];
 
 /*
  * The catalog is the seam between ten independently-maintained alert-template
@@ -69,7 +87,8 @@ interface ModuleExpectation {
     | "hostIdentifier"
     | "fleetIdentifier"
     | "rumApplicationId"
-    | "serviceId";
+    | "serviceId"
+    | "databaseServerId";
 }
 
 const MODULE_EXPECTATIONS: Array<ModuleExpectation> = [
@@ -164,6 +183,18 @@ const MODULE_EXPECTATIONS: Array<ModuleExpectation> = [
     contextFreeTemplateCount: getServiceAlertTemplates(null).length,
     identifierFieldName: "serviceId",
   },
+  {
+    resourceType: MonitorRecommendationResourceType.DatabaseServer,
+    monitorTypes: [MonitorType.Metrics],
+    templateCount: getAllDatabaseAlertTemplates().length,
+    /*
+     * Zero, and deliberately so — see RESOURCE_TYPES_WITHOUT_CONTEXT_FREE_SUBSET.
+     * `getDatabaseAlertTemplates(null)` is the module's own answer to "what
+     * applies to a database whose engine is unknown".
+     */
+    contextFreeTemplateCount: getDatabaseAlertTemplates(null).length,
+    identifierFieldName: "databaseServerId",
+  },
 ];
 
 describe("MonitorRecommendationCatalog", () => {
@@ -215,7 +246,17 @@ describe("MonitorRecommendationCatalog", () => {
           );
 
         expect(expectation.templateCount).toBeGreaterThan(0);
-        expect(expectation.contextFreeTemplateCount).toBeGreaterThan(0);
+
+        if (
+          RESOURCE_TYPES_WITHOUT_CONTEXT_FREE_SUBSET.includes(
+            expectation.resourceType,
+          )
+        ) {
+          expect(expectation.contextFreeTemplateCount).toBe(0);
+        } else {
+          expect(expectation.contextFreeTemplateCount).toBeGreaterThan(0);
+        }
+
         expect(recommendations.length).toBe(
           expectation.contextFreeTemplateCount,
         );
@@ -363,9 +404,22 @@ describe("MonitorRecommendationCatalog", () => {
       }
     });
 
+    /*
+     * Both run over EVERY recommendation a type can produce, not the
+     * context-free subset: a database has no context-free subset at all, and a
+     * service's is missing every runtime template — checking only that would
+     * leave exactly the engine- and runtime-specific half unchecked.
+     */
     it("stamps every recommendation with one of its definition's monitorTypes and its resourceType", () => {
       for (const definition of MonitorRecommendationCatalog.getResourceTypeDefinitions()) {
-        for (const recommendation of definition.getRecommendations()) {
+        const recommendations: Array<MonitorRecommendation> =
+          MonitorRecommendationCatalog.getAllPossibleRecommendations(
+            definition.resourceType,
+          );
+
+        expect(recommendations.length).toBeGreaterThan(0);
+
+        for (const recommendation of recommendations) {
           expect(definition.monitorTypes).toContain(recommendation.monitorType);
           expect(recommendation.resourceType).toBe(definition.resourceType);
         }
@@ -376,11 +430,11 @@ describe("MonitorRecommendationCatalog", () => {
       for (const definition of MonitorRecommendationCatalog.getResourceTypeDefinitions()) {
         const usedTypes: Array<MonitorType> = Array.from(
           new Set(
-            definition
-              .getRecommendations()
-              .map((recommendation: MonitorRecommendation) => {
-                return recommendation.monitorType;
-              }),
+            MonitorRecommendationCatalog.getAllPossibleRecommendations(
+              definition.resourceType,
+            ).map((recommendation: MonitorRecommendation) => {
+              return recommendation.monitorType;
+            }),
           ),
         );
 
@@ -549,7 +603,10 @@ describe("MonitorRecommendationCatalog", () => {
       for (const resourceType of Object.values(
         MonitorRecommendationResourceType,
       )) {
-        if (resourceType === MonitorRecommendationResourceType.Service) {
+        if (
+          resourceType === MonitorRecommendationResourceType.Service ||
+          resourceType === MonitorRecommendationResourceType.DatabaseServer
+        ) {
           continue;
         }
 
@@ -662,4 +719,191 @@ describe("MonitorRecommendationCatalog", () => {
       }
     });
   });
+
+  /*
+   * Databases: the second context-dependent resource type, and the first
+   * whose context-free set is empty. The failure modes mirror Service's —
+   * a PostgreSQL monitor offered to a Redis server — plus one of their own:
+   * a monitor offered to a database whose engine metrics never arrive, which
+   * either never fires or (Engine Metrics Stopped) fires the moment it is
+   * created.
+   */
+  describe("database recommendations", () => {
+    function databaseRecommendationIds(
+      context?: MonitorRecommendationContext | undefined,
+    ): Array<string> {
+      return MonitorRecommendationCatalog.getRecommendations(
+        MonitorRecommendationResourceType.DatabaseServer,
+        context,
+      ).map((recommendation: MonitorRecommendation) => {
+        return recommendation.recommendationId;
+      });
+    }
+
+    function templateIdsFor(engine: string): Array<string> {
+      return getDatabaseAlertTemplates(engine).map(
+        (template: DatabaseAlertTemplate) => {
+          return buildRecommendationId(
+            MonitorRecommendationResourceType.DatabaseServer,
+            template.id,
+          );
+        },
+      );
+    }
+
+    it("offers nothing when the engine is not known", () => {
+      expect(databaseRecommendationIds()).toEqual([]);
+      expect(databaseRecommendationIds({})).toEqual([]);
+      expect(databaseRecommendationIds({ databaseEngine: null })).toEqual([]);
+      expect(databaseRecommendationIds({ databaseEngine: "" })).toEqual([]);
+      expect(
+        databaseRecommendationIds({ databaseEngineMetricsReported: true }),
+      ).toEqual([]);
+    });
+
+    it("offers exactly the engine's templates, in the module's order", () => {
+      for (const engine of getDatabaseEnginesWithAlertTemplates()) {
+        expect(
+          databaseRecommendationIds({
+            databaseEngine: engine,
+            databaseEngineMetricsReported: true,
+          }),
+        ).toEqual(templateIdsFor(engine));
+      }
+    });
+
+    it("withholds everything from a database whose engine metrics never arrived", () => {
+      for (const engine of getDatabaseEnginesWithAlertTemplates()) {
+        expect(
+          databaseRecommendationIds({
+            databaseEngine: engine,
+            databaseEngineMetricsReported: false,
+          }),
+        ).toEqual([]);
+      }
+    });
+
+    it("treats an unknown metrics state as 'do not withhold'", () => {
+      for (const reported of [null, undefined]) {
+        expect(
+          databaseRecommendationIds({
+            databaseEngine: "postgresql",
+            databaseEngineMetricsReported: reported,
+          }),
+        ).toEqual(templateIdsFor("postgresql"));
+      }
+    });
+
+    it("never offers one engine's recommendations to another", () => {
+      const forPostgres: Array<string> = databaseRecommendationIds({
+        databaseEngine: "postgresql",
+      });
+      const forRedis: Array<string> = databaseRecommendationIds({
+        databaseEngine: "redis",
+      });
+
+      expect(forPostgres.length).toBeGreaterThan(0);
+      expect(forRedis.length).toBeGreaterThan(0);
+
+      for (const recommendationId of forPostgres) {
+        expect(forRedis).not.toContain(recommendationId);
+      }
+    });
+
+    it("offers a fork its family receiver's recommendations", () => {
+      expect(databaseRecommendationIds({ databaseEngine: "mariadb" })).toEqual(
+        databaseRecommendationIds({ databaseEngine: "mysql" }),
+      );
+      expect(databaseRecommendationIds({ databaseEngine: "valkey" })).toEqual(
+        databaseRecommendationIds({ databaseEngine: "redis" }),
+      );
+    });
+
+    it("offers nothing for an engine no template receiver covers", () => {
+      expect(
+        databaseRecommendationIds({ databaseEngine: "cassandra" }),
+      ).toEqual([]);
+    });
+
+    it("keeps the two context-dependent resource types independent", () => {
+      expect(databaseRecommendationIds({ serviceLanguage: "java" })).toEqual(
+        [],
+      );
+
+      const serviceIds: Array<string> =
+        MonitorRecommendationCatalog.getRecommendations(
+          MonitorRecommendationResourceType.Service,
+        ).map((recommendation: MonitorRecommendation) => {
+          return recommendation.recommendationId;
+        });
+
+      expect(
+        MonitorRecommendationCatalog.getRecommendations(
+          MonitorRecommendationResourceType.Service,
+          { databaseEngine: "postgresql" },
+        ).map((recommendation: MonitorRecommendation) => {
+          return recommendation.recommendationId;
+        }),
+      ).toEqual(serviceIds);
+    });
+
+    it("stays exhaustive and resolvable by id with no context", () => {
+      const all: Array<MonitorRecommendation> =
+        MonitorRecommendationCatalog.getAllPossibleRecommendations(
+          MonitorRecommendationResourceType.DatabaseServer,
+        );
+
+      expect(all.length).toBe(getAllDatabaseAlertTemplates().length);
+
+      for (const recommendation of all) {
+        expect(recommendation.monitorType).toBe(MonitorType.Metrics);
+        expect(
+          MonitorRecommendationCatalog.getRecommendationById(
+            recommendation.recommendationId,
+          )?.templateId,
+        ).toBe(recommendation.templateId);
+      }
+    });
+
+    it("threads the database id into every query of every recommendation", () => {
+      const databaseServerId: string = "d0000000-0000-4000-8000-000000000007";
+
+      for (const recommendation of MonitorRecommendationCatalog.getAllPossibleRecommendations(
+        MonitorRecommendationResourceType.DatabaseServer,
+      )) {
+        const step: MonitorStep = recommendation.getMonitorStep({
+          resourceIdentifier: databaseServerId,
+          onlineMonitorStatusId: ObjectID.generate(),
+          offlineMonitorStatusId: ObjectID.generate(),
+          defaultIncidentSeverityId: ObjectID.generate(),
+          defaultAlertSeverityId: ObjectID.generate(),
+          monitorName: "PostgreSQL db.prod:5432",
+        });
+
+        for (const queryConfig of step.data!.metricMonitor!.metricViewConfig
+          .queryConfigs) {
+          expect(
+            (
+              queryConfig.metricQueryData.filterData.attributes as Record<
+                string,
+                unknown
+              >
+            )["oneuptime.database.server.id"],
+          ).toBe(databaseServerId);
+        }
+      }
+    });
+
+    it("lists categories in first-declaration order for an engine", () => {
+      const categories: Array<string> =
+        MonitorRecommendationCatalog.getCategories(
+          MonitorRecommendationResourceType.DatabaseServer,
+          { databaseEngine: "postgresql" },
+        );
+
+      // Availability (Engine Metrics Stopped) always leads.
+      expect(categories[0]).toBe("Availability");
+      expect(new Set(categories).size).toBe(categories.length);
+    });
+  });
 });

package/Tests/Types/Monitor/Recommendation/MonitorRecommendationCoverage.test.ts

@@ -513,11 +513,13 @@ describe("MonitorRecommendationUtil.getCoveredRecommendationMonitorIds", () => {
      * both a covered and an uncovered answer are exercised for all eight
      * resource types.
      */
-    expect(RESOURCE_TYPE_DEFINITIONS.length).toBe(11);
+    expect(RESOURCE_TYPE_DEFINITIONS.length).toBe(12);
 
     for (const definition of RESOURCE_TYPE_DEFINITIONS) {
       const recommendations: Array<MonitorRecommendation> =
-        definition.getRecommendations();
+        MonitorRecommendationCatalog.getAllPossibleRecommendations(
+          definition.resourceType,
+        );
       const args: MonitorRecommendationArgs = buildArgs();
 
       const createdRecommendations: Array<MonitorRecommendation> =
@@ -623,7 +625,9 @@ describe("MonitorRecommendationUtil.getCoveredRecommendationMonitorIds", () => {
      */
     for (const definition of RESOURCE_TYPE_DEFINITIONS) {
       const recommendations: Array<MonitorRecommendation> =
-        definition.getRecommendations();
+        MonitorRecommendationCatalog.getAllPossibleRecommendations(
+          definition.resourceType,
+        );
       const args: MonitorRecommendationArgs = buildArgs();
 
       const first: MonitorRecommendation = recommendations[0]!;
@@ -680,7 +684,9 @@ describe("MonitorRecommendationUtil.getCoveredRecommendationMonitorIds", () => {
   it("ignores the monitor-status and severity args entirely", () => {
     for (const definition of RESOURCE_TYPE_DEFINITIONS) {
       const recommendations: Array<MonitorRecommendation> =
-        definition.getRecommendations();
+        MonitorRecommendationCatalog.getAllPossibleRecommendations(
+          definition.resourceType,
+        );
 
       const realArgs: MonitorRecommendationArgs = buildArgs();
 
@@ -749,7 +755,9 @@ describe("MonitorRecommendationUtil.getCoveredRecommendationMonitorIds", () => {
         Array<string>
       >();
 
-      for (const recommendation of definition.getRecommendations()) {
+      for (const recommendation of MonitorRecommendationCatalog.getAllPossibleRecommendations(
+        definition.resourceType,
+      )) {
         const fingerprint: string = getSerializedFingerprint(
           recommendation,
           args,

package/Tests/Types/Monitor/Recommendation/MonitorRecommendationNotificationMode.test.ts

@@ -168,7 +168,9 @@ const ALL_RECOMMENDATIONS: Array<MonitorRecommendation> =
 const ONE_PER_RESOURCE_TYPE: Array<MonitorRecommendation> =
   MonitorRecommendationCatalog.getResourceTypeDefinitions().map(
     (definition: MonitorRecommendationResourceTypeDefinition) => {
-      return definition.getRecommendations()[0]!;
+      return MonitorRecommendationCatalog.getAllPossibleRecommendations(
+        definition.resourceType,
+      )[0]!;
     },
   );
 
@@ -194,7 +196,7 @@ describe("MonitorRecommendationNotificationMode", () => {
     it("has recommendations to test at all", () => {
       // Guards every for-loop in this file against a vacuous pass.
       expect(ALL_RECOMMENDATIONS.length).toBeGreaterThan(0);
-      expect(ONE_PER_RESOURCE_TYPE.length).toBe(11);
+      expect(ONE_PER_RESOURCE_TYPE.length).toBe(12);
     });
 
     it("ships every unhealthy criteria with createIncidents AND createAlerts true, and both arrays populated", () => {

package/Tests/Types/Monitor/Recommendation/MonitorRecommendationUtil.test.ts

@@ -16,6 +16,7 @@ import MonitorSteps from "../../../../Types/Monitor/MonitorSteps";
 import MonitorCriteriaInstance from "../../../../Types/Monitor/MonitorCriteriaInstance";
 import { CriteriaIncident } from "../../../../Types/Monitor/CriteriaIncident";
 import { CriteriaAlert } from "../../../../Types/Monitor/CriteriaAlert";
+import { getDatabaseEnginesWithAlertTemplates } from "../../../../Types/Monitor/DatabaseAlertTemplates";
 import ObjectID from "../../../../Types/ObjectID";
 
 /*
@@ -95,7 +96,9 @@ const ALL_RECOMMENDATIONS: Array<MonitorRecommendation> =
 const ONE_PER_RESOURCE_TYPE: Array<MonitorRecommendation> =
   MonitorRecommendationCatalog.getResourceTypeDefinitions().map(
     (definition: MonitorRecommendationResourceTypeDefinition) => {
-      return definition.getRecommendations()[0]!;
+      return MonitorRecommendationCatalog.getAllPossibleRecommendations(
+        definition.resourceType,
+      )[0]!;
     },
   );
 
@@ -154,6 +157,30 @@ describe("MonitorRecommendationUtil", () => {
         expect(new Set(names).size).toBe(names.length);
       }
     });
+
+    it("produces distinct names within the set one database is offered, for every engine", () => {
+      /*
+       * A database's set is empty without context, so the loop above proves
+       * nothing for it. Per engine is the unit that matters: one database
+       * only ever renders one engine's recommendations ("Engine Metrics
+       * Stopped" repeats across engines on purpose).
+       */
+      for (const engine of getDatabaseEnginesWithAlertTemplates()) {
+        const names: Array<string> =
+          MonitorRecommendationCatalog.getRecommendations(
+            MonitorRecommendationResourceType.DatabaseServer,
+            { databaseEngine: engine, databaseEngineMetricsReported: true },
+          ).map((recommendation: MonitorRecommendation) => {
+            return MonitorRecommendationUtil.getMonitorName({
+              recommendation: recommendation,
+              resourceDisplayName: "PostgreSQL db.prod:5432",
+            });
+          });
+
+        expect(names.length).toBeGreaterThan(0);
+        expect(new Set(names).size).toBe(names.length);
+      }
+    });
   });
 
   describe("getMonitorStep — every recommendation, every resource type", () => {
@@ -802,7 +829,9 @@ describe("MonitorRecommendationUtil", () => {
     it("works for every resource type, not just Kubernetes", () => {
       for (const definition of MonitorRecommendationCatalog.getResourceTypeDefinitions()) {
         const recommendations: Array<MonitorRecommendation> =
-          definition.getRecommendations();
+          MonitorRecommendationCatalog.getAllPossibleRecommendations(
+            definition.resourceType,
+          );
         const args: MonitorRecommendationArgs = buildArgs();
         const created: MonitorRecommendation = recommendations[0]!;
 
@@ -961,4 +990,84 @@ describe("MonitorRecommendationUtil", () => {
       expect(lastCriticalIndex).toBeLessThan(firstWarningIndex);
     });
   });
+
+  /*
+   * A database's monitors are generic Metrics monitors whose only resource
+   * identity is the `oneuptime.database.server.id` filter on every query. The
+   * already-created diff has to read that as the resource, or every database
+   * in the project would share one set of "created" cards.
+   */
+  describe("database fingerprints", () => {
+    const DATABASE_A: string = "d0000000-0000-4000-8000-00000000000a";
+    const DATABASE_B: string = "d0000000-0000-4000-8000-00000000000b";
+
+    const postgresRecommendations: Array<MonitorRecommendation> =
+      MonitorRecommendationCatalog.getRecommendations(
+        MonitorRecommendationResourceType.DatabaseServer,
+        { databaseEngine: "postgresql", databaseEngineMetricsReported: true },
+      );
+
+    it("reads the database id off the query filter as the resource identifier", () => {
+      expect(postgresRecommendations.length).toBeGreaterThan(0);
+
+      for (const recommendation of postgresRecommendations) {
+        const fingerprint: MonitorRecommendationFingerprint | undefined =
+          MonitorRecommendationUtil.getFingerprintFromMonitorStep(
+            recommendation.getMonitorStep(
+              buildArgs({ resourceIdentifier: DATABASE_A }),
+            ),
+          );
+
+        expect(fingerprint?.configKind).toBe("metricMonitor");
+        expect(fingerprint?.resourceIdentifier).toBe(DATABASE_A);
+      }
+    });
+
+    it("never lets one database's monitor cover another database's recommendation", () => {
+      const existing: Array<MonitorStep> = postgresRecommendations.map(
+        (recommendation: MonitorRecommendation) => {
+          return recommendation.getMonitorStep(
+            buildArgs({ resourceIdentifier: DATABASE_A }),
+          );
+        },
+      );
+
+      expect(
+        MonitorRecommendationUtil.getCoveredRecommendationIds({
+          recommendations: postgresRecommendations,
+          existingMonitorSteps: existing,
+          args: buildArgs({ resourceIdentifier: DATABASE_B }),
+        }).size,
+      ).toBe(0);
+
+      expect(
+        MonitorRecommendationUtil.getCoveredRecommendationIds({
+          recommendations: postgresRecommendations,
+          existingMonitorSteps: existing,
+          args: buildArgs({ resourceIdentifier: DATABASE_A }),
+        }).size,
+      ).toBe(postgresRecommendations.length);
+    });
+
+    it("leaves a project-wide metric monitor's identity empty", () => {
+      /*
+       * The fallback only reads the database scope attribute: a Metrics
+       * monitor with no such filter is not about any one resource, and must
+       * not suddenly start claiming one.
+       */
+      const step: MonitorStep = postgresRecommendations[0]!.getMonitorStep(
+        buildArgs({ resourceIdentifier: DATABASE_A }),
+      );
+
+      for (const queryConfig of step.data!.metricMonitor!.metricViewConfig
+        .queryConfigs) {
+        queryConfig.metricQueryData.filterData.attributes = {};
+      }
+
+      expect(
+        MonitorRecommendationUtil.getFingerprintFromMonitorStep(step)
+          ?.resourceIdentifier,
+      ).toBe("");
+    });
+  });
 });

package/Tests/Types/Monitor/Recommendation/RecommendationCriteriaBuilder.test.ts

@@ -371,6 +371,67 @@ describe("RecommendationCriteriaBuilder", () => {
       expect(
         firstFilter(buildHealthy()).metricMonitorOptions?.onNoDataPolicy,
       ).toBeUndefined();
+      expect(
+        firstFilter(buildUnhealthy()).metricMonitorOptions?.onNoDataPolicy,
+      ).toBeUndefined();
+    });
+
+    /*
+     * The heartbeat shape the database "Engine Metrics Stopped" templates
+     * use: silence IS the breach, so the firing side must say Trigger.
+     */
+    test("triggerOnNoData puts the Trigger policy on every breach filter", () => {
+      const instance: MonitorCriteriaInstance = buildUnhealthy({
+        triggerOnNoData: true,
+        additionalFilters: [
+          {
+            metricAlias: "second_heartbeat",
+            filterType: FilterType.LessThan,
+            value: 0,
+          },
+        ],
+      });
+
+      const filters: Array<CriteriaFilter> = instance.data
+        ?.filters as Array<CriteriaFilter>;
+
+      expect(filters.length).toBe(2);
+
+      for (const filter of filters) {
+        expect(filter.metricMonitorOptions?.onNoDataPolicy).toBe(
+          NoDataPolicy.Trigger,
+        );
+      }
+    });
+
+    test("triggerOnNoData wins over treatNoDataAsZero — one answer per criteria", () => {
+      expect(
+        firstFilter(
+          buildUnhealthy({ triggerOnNoData: true, treatNoDataAsZero: true }),
+        ).metricMonitorOptions?.onNoDataPolicy,
+      ).toBe(NoDataPolicy.Trigger);
+
+      // ...and treatNoDataAsZero alone still behaves exactly as before.
+      expect(
+        firstFilter(buildUnhealthy({ treatNoDataAsZero: true }))
+          .metricMonitorOptions?.onNoDataPolicy,
+      ).toBe(NoDataPolicy.TreatAsZero);
+    });
+
+    test("triggerOnNoData keeps the breach sustained and its threshold as given", () => {
+      const filter: CriteriaFilter = firstFilter(
+        buildUnhealthy({
+          triggerOnNoData: true,
+          filterType: FilterType.LessThan,
+          value: 0,
+        }),
+      );
+
+      expect(filter.metricMonitorOptions?.metricAggregationType).toBe(
+        SustainedEvaluation,
+      );
+      expect(filter.filterType).toBe(FilterType.LessThan);
+      expect(filter.value).toBe(0);
     });
 
     test("filterCondition is overridable so multi-alias recovery can require ALL", () => {