@oneuptime/common 13.0.6 → 13.0.8

package/Server/Static/Brand/README.md

@@ -15,26 +15,26 @@ browser drew a broken image. See
 https://github.com/OneUptime/oneuptime/issues/3457.
 
 Every service mounts this directory read-only at `/oneuptime-assets/brand` (see
-`Common/Server/Utils/VendorAssets.ts`). Reference the files from a view by that
+`packages/Common/Server/Utils/VendorAssets.ts`). Reference the files from a view by that
 absolute path, or from server code via the `OneUptimeLogoUrl` constant -
-`Common/Tests/Server/Utils/OfflineAssetHygiene.test.ts` fails the build on a
+`packages/Common/Tests/Server/Utils/OfflineAssetHygiene.test.ts` fails the build on a
 `/oneuptime-assets/...` URL that does not resolve to a file on disk.
 
 ## Contents
 
 | Path                      | Source                                                  |
 | ------------------------- | ------------------------------------------------------- |
-| `oneuptime-logo.svg`      | `Common/UI/Images/logos/OneUptimeSVG/3-transparent.svg` |
-| `ou-wb.svg`, `hou-wb.svg` | `Home/Static/img/`                                      |
-| `favicons/`               | `Home/Static/img/favicons/`                             |
+| `oneuptime-logo.svg`      | `packages/Common/UI/Images/logos/OneUptimeSVG/3-transparent.svg` |
+| `ou-wb.svg`, `hou-wb.svg` | `packages/Home/Static/img/`                                      |
+| `favicons/`               | `packages/Home/Static/img/favicons/`                             |
 
 `favicons/oneuptime-up-v1.svg` is the cache-versioned browser-tab icon shared
 by the Dashboard, Admin Dashboard, and Home page. It keeps the white `Up.` mark
 on its own dark background so the lettering remains visible in both light and
 dark browser chrome.
 
-`Common/Tests/Server/Utils/VendorAssets.test.ts` asserts `oneuptime-logo.svg` is
-byte-identical to the copies under `Common/UI` and `Home/Static`, so a rebrand
+`packages/Common/Tests/Server/Utils/VendorAssets.test.ts` asserts `oneuptime-logo.svg` is
+byte-identical to the copies under `packages/Common/UI` and `packages/Home/Static`, so a rebrand
 that updates one of them and not this one fails the build rather than leaving
 the acknowledge page on the old mark.
 

package/Server/Static/Vendor/README.md

@@ -7,11 +7,11 @@ CDN `<script>` does not degrade, it hangs. See
 https://github.com/OneUptime/oneuptime/issues/2570.
 
 Every service mounts this directory read-only at `/oneuptime-assets` (see
-`Common/Server/Utils/VendorAssets.ts`). Reference the files from a view by that
+`packages/Common/Server/Utils/VendorAssets.ts`). Reference the files from a view by that
 absolute path, never by a CDN URL -
-`Common/Tests/Server/Utils/OfflineAssetHygiene.test.ts` fails the build on a CDN
-URL in any `.ejs` under `Common/Server/Views`, `App/FeatureSet/*/{Views,views}`
-or `Home/Views`.
+`packages/Common/Tests/Server/Utils/OfflineAssetHygiene.test.ts` fails the build on a CDN
+URL in any `.ejs` under `packages/Common/Server/Views`, `packages/App/FeatureSet/*/{Views,views}`
+or `packages/Home/Views`.
 
 ## Contents
 
@@ -19,10 +19,10 @@ or `Home/Views`.
 | -------------------------- | ----------------------------------------------------------- |
 | `tailwind/tailwind-3.4.5.js` | Tailwind Play CDN build 3.4.5                              |
 | `highlight/`               | highlight.js 11.11.1, from cdnjs                             |
-| `fonts/InterVariable.woff2` | Inter variable font, byte-identical to the copies under `App/FeatureSet/{Docs,APIReference}/Static/fonts/` |
+| `fonts/InterVariable.woff2` | Inter variable font, byte-identical to the copies under `packages/App/FeatureSet/{Docs,APIReference}/Static/fonts/` |
 
 The Tailwind file is the **only** copy in the tree. The five frontends used to
-commit one each; `Common/UI/esbuild-config.js` now copies this one into each
+commit one each; `packages/Common/UI/esbuild-config.js` now copies this one into each
 `public/assets/js/` at build time, next to where it already copies Monaco, and
 the built copies are gitignored. Their `index.ejs` still loads it from their own
 prefix (`/dashboard/assets/js/...`) rather than through `/oneuptime-assets` - the
@@ -49,7 +49,7 @@ highlighting offline.
 
 ```bash
 BASE="https://cdnjs.cloudflare.com/ajax/libs/highlight.js/11.11.1"
-DEST="Common/Server/Static/Vendor/highlight"
+DEST="packages/Common/Server/Static/Vendor/highlight"
 
 curl -sSfL "$BASE/highlight.min.js" -o "$DEST/highlight.min.js"
 

package/Server/Types/Database/Permissions/BasePermission.ts

@@ -70,16 +70,18 @@ export default class BasePermission {
         props,
       );
 
-      if (!props.isMultiTenantRequest) {
-        // We will check for this permission in recursive function.
-
+      /*
+       * Only TenantPermission's per-project recursion returns an array of
+       * queries whose permissions have already been checked. The incoming
+       * query is copied into an ordinary object above, so a caller cannot
+       * supply this array. A multi-tenant request scoped to the current user
+       * (such as pending team invitations) still needs every check below.
+       */
+      if (!Array.isArray(query)) {
         // check model level permissions.
         TablePermission.checkTableLevelPermissions(modelType, props, type);
 
-        /*
-         * We will check for this permission in recursive function.
-         * check query permissions.
-         */
+        // check query permissions.
         QueryPermission.checkQueryPermission(modelType, query, props);
 
         query = await AccessControlPermission.addAccessControlIdsToQuery(

package/Server/Types/Database/Permissions/Index.ts

@@ -7,9 +7,40 @@ import ReadPermission, { CheckReadPermissionType } from "./ReadPermission";
 import UpdatePermission from "./UpdatePermission";
 import BaseModel from "../../../../Models/DatabaseModels/DatabaseBaseModel/DatabaseBaseModel";
 import DatabaseCommonInteractionProps from "../../../../Types/BaseDatabase/DatabaseCommonInteractionProps";
+import DatabaseCommonInteractionPropsUtil from "../../../../Types/BaseDatabase/DatabaseCommonInteractionPropsUtil";
+import NotAuthenticatedException from "../../../../Types/Exception/NotAuthenticatedException";
+import NotAuthorizedException from "../../../../Types/Exception/NotAuthorizedException";
 import CaptureSpan from "../../../Utils/Telemetry/CaptureSpan";
 
 export default class ModelPermission {
+  /*
+   * A refusal of a caller with no credentials at all is a 401.
+   *
+   * The login check near the top of every permission check passes an
+   * anonymous caller straight through on models that are readable (or
+   * creatable) by Public - Probe, AIAgent, LlmProvider and friends - and the
+   * column, select and query checks that follow then refuse it with 422
+   * NotAuthorizedException. For the dashboard that caller is a signed-in user
+   * whose access-token cookie expired, and only a 401 makes the browser client
+   * refresh the session and replay the request. Callers with credentials keep
+   * the 422 they always got; the message is kept either way.
+   */
+  private static toAnonymousRefusal(
+    error: unknown,
+    props: DatabaseCommonInteractionProps,
+  ): unknown {
+    if (
+      error instanceof NotAuthorizedException &&
+      !props.isRoot &&
+      !props.isMasterAdmin &&
+      DatabaseCommonInteractionPropsUtil.isAnonymous(props)
+    ) {
+      return new NotAuthenticatedException(error.message);
+    }
+
+    return error;
+  }
+
   @CaptureSpan()
   public static async checkDeletePermissionByModel<
     TBaseModel extends BaseModel,
@@ -18,7 +49,11 @@ export default class ModelPermission {
     fetchModelWithAccessControlIds: () => Promise<TBaseModel | null>;
     props: DatabaseCommonInteractionProps;
   }): Promise<void> {
-    return DeletePermission.checkDeletePermissionByModel(data);
+    try {
+      return await DeletePermission.checkDeletePermissionByModel(data);
+    } catch (error) {
+      throw ModelPermission.toAnonymousRefusal(error, data.props);
+    }
   }
 
   @CaptureSpan()
@@ -29,7 +64,11 @@ export default class ModelPermission {
     fetchModelWithAccessControlIds: () => Promise<TBaseModel | null>;
     props: DatabaseCommonInteractionProps;
   }): Promise<void> {
-    return UpdatePermission.checkUpdatePermissionByModel(data);
+    try {
+      return await UpdatePermission.checkUpdatePermissionByModel(data);
+    } catch (error) {
+      throw ModelPermission.toAnonymousRefusal(error, data.props);
+    }
   }
 
   @CaptureSpan()
@@ -38,7 +77,15 @@ export default class ModelPermission {
     query: Query<TBaseModel>,
     props: DatabaseCommonInteractionProps,
   ): Promise<Query<TBaseModel>> {
-    return DeletePermission.checkDeletePermission(modelType, query, props);
+    try {
+      return await DeletePermission.checkDeletePermission(
+        modelType,
+        query,
+        props,
+      );
+    } catch (error) {
+      throw ModelPermission.toAnonymousRefusal(error, props);
+    }
   }
 
   @CaptureSpan()
@@ -48,12 +95,16 @@ export default class ModelPermission {
     data: QueryDeepPartialEntity<TBaseModel>,
     props: DatabaseCommonInteractionProps,
   ): Promise<Query<TBaseModel>> {
-    return UpdatePermission.checkUpdatePermissions(
-      modelType,
-      query,
-      data,
-      props,
-    );
+    try {
+      return await UpdatePermission.checkUpdatePermissions(
+        modelType,
+        query,
+        data,
+        props,
+      );
+    } catch (error) {
+      throw ModelPermission.toAnonymousRefusal(error, props);
+    }
   }
 
   @CaptureSpan()
@@ -62,7 +113,11 @@ export default class ModelPermission {
     data: TBaseModel,
     props: DatabaseCommonInteractionProps,
   ): void {
-    return CreatePermission.checkCreatePermissions(modelType, data, props);
+    try {
+      return CreatePermission.checkCreatePermissions(modelType, data, props);
+    } catch (error) {
+      throw ModelPermission.toAnonymousRefusal(error, props);
+    }
   }
 
   @CaptureSpan()
@@ -72,6 +127,15 @@ export default class ModelPermission {
     select: Select<TBaseModel> | null,
     props: DatabaseCommonInteractionProps,
   ): Promise<CheckReadPermissionType<TBaseModel>> {
-    return ReadPermission.checkReadPermission(modelType, query, select, props);
+    try {
+      return await ReadPermission.checkReadPermission(
+        modelType,
+        query,
+        select,
+        props,
+      );
+    } catch (error) {
+      throw ModelPermission.toAnonymousRefusal(error, props);
+    }
   }
 }

package/Server/Types/Database/Permissions/OwnedScopePermission.ts

@@ -62,13 +62,19 @@ export default class OwnedScopePermission {
 
     /*
      * Owned scope only restricts resources that can carry ownership:
-     * operational resources (own *OwnerUser / *OwnerTeam tables) or
+     * operational resources, explicitly registered ownership roots, or
      * nested resources that inherit ownership via @OwnedThrough. For
      * everything else (settings / config tables like IncidentState,
      * Label, Team, etc.) the table-level permission check is the only
      * gate — Owned has no resources to scope to, so it's a no-op.
+     * Registry membership only enables ownership filtering; operational
+     * wildcard grants still require the existing decorator.
      */
-    if (!model.isOperationalResource && !model.ownedThrough) {
+    if (
+      !model.isOperationalResource &&
+      !model.ownedThrough &&
+      !this.getOwnerTableRegistry().has(model.constructor.name)
+    ) {
       return query;
     }
 
@@ -212,6 +218,15 @@ export default class OwnedScopePermission {
     }
   }
 
+  private static getOwnerTableRegistry(): Map<string, OwnerTablePair> {
+    /*
+     * Services in this registry extend DatabaseService, which imports this
+     * permission class. Resolve at request time after both classes exist.
+     */
+    // eslint-disable-next-line @typescript-eslint/no-require-imports, @typescript-eslint/no-var-requires
+    return require("./OwnerTableRegistry").default;
+  }
+
   /*
    * Computes the set of resource IDs the requesting user can access via
    * ownership: those where they personally sit in *OwnerUser OR where any of
@@ -244,14 +259,8 @@ export default class OwnedScopePermission {
       : // eslint-disable-next-line @typescript-eslint/no-explicit-any
         [(modelType as any).name];
 
-    /*
-     * Lazy require to avoid the circular dep cycle: this file is reachable
-     * from DatabaseService at module-load time, and the registry imports
-     * services that extend DatabaseService.
-     */
     const ownerTableRegistry: Map<string, OwnerTablePair> =
-      // eslint-disable-next-line @typescript-eslint/no-require-imports, @typescript-eslint/no-var-requires
-      require("./OwnerTableRegistry").default;
+      this.getOwnerTableRegistry();
 
     const seen: Set<string> = new Set<string>();
 

package/Server/Types/Database/Permissions/OwnerTableRegistry.ts

@@ -30,6 +30,18 @@ import CloudResourceOwnerTeamService from "../../../Services/CloudResourceOwnerT
 import CloudResourceOwnerUserService from "../../../Services/CloudResourceOwnerUserService";
 import RumApplicationOwnerTeamService from "../../../Services/RumApplicationOwnerTeamService";
 import RumApplicationOwnerUserService from "../../../Services/RumApplicationOwnerUserService";
+import ProxmoxClusterOwnerTeamService from "../../../Services/ProxmoxClusterOwnerTeamService";
+import ProxmoxClusterOwnerUserService from "../../../Services/ProxmoxClusterOwnerUserService";
+import CephClusterOwnerTeamService from "../../../Services/CephClusterOwnerTeamService";
+import CephClusterOwnerUserService from "../../../Services/CephClusterOwnerUserService";
+import DockerSwarmClusterOwnerTeamService from "../../../Services/DockerSwarmClusterOwnerTeamService";
+import DockerSwarmClusterOwnerUserService from "../../../Services/DockerSwarmClusterOwnerUserService";
+import VMwareVCenterOwnerTeamService from "../../../Services/VMwareVCenterOwnerTeamService";
+import VMwareVCenterOwnerUserService from "../../../Services/VMwareVCenterOwnerUserService";
+import IoTFleetOwnerTeamService from "../../../Services/IoTFleetOwnerTeamService";
+import IoTFleetOwnerUserService from "../../../Services/IoTFleetOwnerUserService";
+import NetworkDeviceOwnerTeamService from "../../../Services/NetworkDeviceOwnerTeamService";
+import NetworkDeviceOwnerUserService from "../../../Services/NetworkDeviceOwnerUserService";
 import StatusPageOwnerTeamService from "../../../Services/StatusPageOwnerTeamService";
 import StatusPageOwnerUserService from "../../../Services/StatusPageOwnerUserService";
 import WorkflowOwnerTeamService from "../../../Services/WorkflowOwnerTeamService";
@@ -49,6 +61,12 @@ import KubernetesClusterService from "../../../Services/KubernetesClusterService
 import ServerlessFunctionService from "../../../Services/ServerlessFunctionService";
 import CloudResourceService from "../../../Services/CloudResourceService";
 import RumApplicationService from "../../../Services/RumApplicationService";
+import ProxmoxClusterService from "../../../Services/ProxmoxClusterService";
+import CephClusterService from "../../../Services/CephClusterService";
+import DockerSwarmClusterService from "../../../Services/DockerSwarmClusterService";
+import VMwareVCenterService from "../../../Services/VMwareVCenterService";
+import IoTFleetService from "../../../Services/IoTFleetService";
+import NetworkDeviceService from "../../../Services/NetworkDeviceService";
 
 /*
  * Maps an operational model name (e.g. "Monitor") to the two services that
@@ -248,6 +266,70 @@ const ownerTableRegistry: Map<string, OwnerTablePair> = new Map<
       modelService: RumApplicationService,
     },
   ],
+  [
+    "ProxmoxCluster",
+    {
+      ownerUserService: ProxmoxClusterOwnerUserService,
+      ownerTeamService: ProxmoxClusterOwnerTeamService,
+      fkColumn: "proxmoxClusterId",
+      canOwnTelemetry: true,
+      modelService: ProxmoxClusterService,
+    },
+  ],
+  [
+    "CephCluster",
+    {
+      ownerUserService: CephClusterOwnerUserService,
+      ownerTeamService: CephClusterOwnerTeamService,
+      fkColumn: "cephClusterId",
+      canOwnTelemetry: true,
+      modelService: CephClusterService,
+    },
+  ],
+  [
+    "DockerSwarmCluster",
+    {
+      ownerUserService: DockerSwarmClusterOwnerUserService,
+      ownerTeamService: DockerSwarmClusterOwnerTeamService,
+      fkColumn: "dockerSwarmClusterId",
+      canOwnTelemetry: true,
+      modelService: DockerSwarmClusterService,
+    },
+  ],
+  [
+    "VMwareVCenter",
+    {
+      ownerUserService: VMwareVCenterOwnerUserService,
+      ownerTeamService: VMwareVCenterOwnerTeamService,
+      fkColumn: "vmwareVCenterId",
+      canOwnTelemetry: true,
+      modelService: VMwareVCenterService,
+    },
+  ],
+  [
+    /*
+     * IoT telemetry carries the fleet ID in primaryEntityId even though its
+     * primaryEntityType discriminator is IoTDevice. Ownership is fleet-wide.
+     */
+    "IoTFleet",
+    {
+      ownerUserService: IoTFleetOwnerUserService,
+      ownerTeamService: IoTFleetOwnerTeamService,
+      fkColumn: "iotFleetId",
+      canOwnTelemetry: true,
+      modelService: IoTFleetService,
+    },
+  ],
+  [
+    "NetworkDevice",
+    {
+      ownerUserService: NetworkDeviceOwnerUserService,
+      ownerTeamService: NetworkDeviceOwnerTeamService,
+      fkColumn: "networkDeviceId",
+      canOwnTelemetry: true,
+      modelService: NetworkDeviceService,
+    },
+  ],
   [
     "Workflow",
     {

package/Server/Types/Database/Permissions/TablePermission.ts

@@ -168,35 +168,31 @@ export default class TablePermission {
     const modelPermissions: Array<Permission> =
       TablePermission.getTablePermission(modelType, type);
 
-    const intersectingPermissions: Array<Permission> =
-      PermissionHelper.getIntersectingPermissions(
-        userPermissions.map((userPermission: UserPermission) => {
-          return userPermission.permission;
-        }) || [],
-        modelPermissions,
-      );
-
-    if (intersectingPermissions && intersectingPermissions.length > 0) {
-      for (const permission of intersectingPermissions) {
-        const userPermission: UserPermission = userPermissions.find(
-          (userPermission: UserPermission) => {
-            return userPermission.permission === permission;
-          },
-        ) as UserPermission;
-
-        if (
-          userPermission &&
+    /*
+     * The user gets one block row per TeamPermission across all of their
+     * teams, unmerged and unordered, so the same permission can be blocked
+     * both for some labels and for the whole table. A row without labels
+     * blocks the whole table and must win whichever row comes first:
+     * ReadPermission and AccessControlPermission only enforce the labelled
+     * rows, so an unlabelled row missed here is enforced nowhere.
+     */
+    const tableWideBlock: UserPermission | undefined = userPermissions.find(
+      (userPermission: UserPermission) => {
+        return (
+          modelPermissions.includes(userPermission.permission) &&
           (!userPermission.labelIds || userPermission.labelIds.length === 0)
-        ) {
-          throw new NotAuthorizedException(
-            `You are not authorized to ${type} ${
-              new modelType().singularName
-            } because ${
-              userPermission.permission
-            } is in your team's permission block list.`,
-          );
-        }
-      }
+        );
+      },
+    );
+
+    if (tableWideBlock) {
+      throw new NotAuthorizedException(
+        `You are not authorized to ${type} ${
+          new modelType().singularName
+        } because ${
+          tableWideBlock.permission
+        } is in your team's permission block list.`,
+      );
     }
   }
 }

package/Server/Utils/AI/AIChatPrivacyFilter.ts

@@ -1,4 +1,5 @@
 import DatabaseCommonInteractionProps from "../../../Types/BaseDatabase/DatabaseCommonInteractionProps";
+import DatabaseCommonInteractionPropsUtil from "../../../Types/BaseDatabase/DatabaseCommonInteractionPropsUtil";
 import NotAuthorizedException from "../../../Types/Exception/NotAuthorizedException";
 
 /*
@@ -16,6 +17,13 @@ export function pinQueryToRequestingUser<TQuery>(
     return query;
   }
 
+  /*
+   * No credentials at all is an expired session, not someone else's data:
+   * 401 so the client refreshes. The countBy overrides reach this before the
+   * permission layer's own login check does.
+   */
+  DatabaseCommonInteractionPropsUtil.assertCredentialsPresent(props);
+
   if (!props.userId) {
     throw new NotAuthorizedException(
       "AI conversations are personal and can only be accessed by the user who created them.",

package/Server/Utils/AI/AIRunPrivacyFilter.ts

@@ -1,4 +1,5 @@
 import DatabaseCommonInteractionProps from "../../../Types/BaseDatabase/DatabaseCommonInteractionProps";
+import DatabaseCommonInteractionPropsUtil from "../../../Types/BaseDatabase/DatabaseCommonInteractionPropsUtil";
 import { FindWhereProperty } from "../../../Types/BaseDatabase/Query";
 import NotAuthorizedException from "../../../Types/Exception/NotAuthorizedException";
 import AIRunType from "../../../Types/AI/AIRunType";
@@ -57,6 +58,13 @@ export function getAIRunPrivacyRaw(
    * /ai-run nor /code-fix-run grants today. That is a separate product
    * decision and must not ride in as a side effect of this filter.
    */
+  /*
+   * No credentials at all is an expired session, not someone else's data:
+   * 401 so the client refreshes. The countBy overrides reach this before the
+   * permission layer's own login check does.
+   */
+  DatabaseCommonInteractionPropsUtil.assertCredentialsPresent(props);
+
   if (!props.userId) {
     throw new NotAuthorizedException(
       "AI runs are personal and can only be accessed by the user who created them.",

package/Server/Utils/AI/Chat/ChatAgentRunner.ts

@@ -9,7 +9,10 @@ import { JSONObject } from "../../../../Types/JSON";
 import ObjectID from "../../../../Types/ObjectID";
 import AIChatMessageRole from "../../../../Types/AI/AIChatMessageRole";
 import AIChatMessageStatus from "../../../../Types/AI/AIChatMessageStatus";
-import { AIChatPageContext } from "../../../../Types/AI/AIChatPageContext";
+import {
+  AIChatPageContext,
+  AIChatPageContextHelper,
+} from "../../../../Types/AI/AIChatPageContext";
 import AIChatPermissionMode from "../../../../Types/AI/AIChatPermissionMode";
 import AIRunEventType from "../../../../Types/AI/AIRunEventType";
 import AIRunStatus from "../../../../Types/AI/AIRunStatus";
@@ -54,9 +57,10 @@ export interface ChatTurnRequest {
    * subject; later turns that arrive without a page context (the user
    * navigated away mid-conversation) fall back to that persisted subject so
    * "this incident" keeps resolving. Not needed on resume (the paused state
-   * already contains the built prompt).
+   * already contains the built prompt). Explicit null detaches the page and
+   * clears that persisted subject.
    */
-  pageContext?: AIChatPageContext | undefined;
+  pageContext?: AIChatPageContext | null | undefined;
   // The requesting user's real permission props, captured at request time.
   props: DatabaseCommonInteractionProps;
 }
@@ -1377,6 +1381,15 @@ export default class ChatAgentRunner {
     request: ChatTurnRequest,
   ): Promise<AIChatPageContext | undefined> {
     try {
+      if (request.pageContext === null) {
+        await AIConversationService.updateOneById({
+          id: request.conversationId,
+          data: { pageContext: null } as never,
+          props: { isRoot: true },
+        });
+        return undefined;
+      }
+
       const conversation: AIConversation | null =
         await AIConversationService.findOneById({
           id: request.conversationId,
@@ -1400,11 +1413,11 @@ export default class ChatAgentRunner {
        * stale first subject would silently flip the conversation back.
        */
       const persistedSignature: string = persisted
-        ? `${persisted.type}:${persisted.entityId || ""}`
+        ? AIChatPageContextHelper.getIdentity(persisted)
         : "";
-      const incomingSignature: string = `${request.pageContext.type}:${
-        request.pageContext.entityId || ""
-      }`;
+      const incomingSignature: string = AIChatPageContextHelper.getIdentity(
+        request.pageContext,
+      );
 
       if (persistedSignature !== incomingSignature) {
         await AIConversationService.updateOneById({
@@ -1423,7 +1436,7 @@ export default class ChatAgentRunner {
           error instanceof Error ? error.message : String(error)
         }`,
       );
-      return request.pageContext;
+      return request.pageContext || undefined;
     }
   }