@oneuptime/common 13.0.6 → 13.0.8

package/Tests/Server/Utils/Monitor/Criteria/ExternalStatusPageMonitorCriteria.test.ts

@@ -242,7 +242,7 @@ describe("ExternalStatusPageMonitorCriteria.isMonitorInstanceCriteriaFilterMet",
 
       expect(result).toContain("External Status Page Response Time");
       expect(result).toContain("500");
-      expect(result).toContain("greater than 100");
+      expect(result).toContain("above the 100 threshold");
     });
 
     test("response time below threshold + GreaterThan → not met", async () => {
@@ -294,7 +294,7 @@ describe("ExternalStatusPageMonitorCriteria.isMonitorInstanceCriteriaFilterMet",
       );
 
       expect(result).toContain("External Status Page Response Time");
-      expect(result).toContain("greater than or equal to 100");
+      expect(result).toContain("at or above the 100 threshold");
     });
 
     test("response time below threshold + LessThan → met", async () => {
@@ -311,7 +311,7 @@ describe("ExternalStatusPageMonitorCriteria.isMonitorInstanceCriteriaFilterMet",
         },
       );
 
-      expect(result).toContain("less than 100");
+      expect(result).toContain("below the 100 threshold");
     });
 
     test("numeric string threshold is accepted", async () => {
@@ -328,7 +328,7 @@ describe("ExternalStatusPageMonitorCriteria.isMonitorInstanceCriteriaFilterMet",
         },
       );
 
-      expect(result).toContain("greater than 100");
+      expect(result).toContain("above the 100 threshold");
     });
 
     test("undefined threshold → undecidable", async () => {
@@ -410,7 +410,7 @@ describe("ExternalStatusPageMonitorCriteria.isMonitorInstanceCriteriaFilterMet",
       );
 
       expect(result).toContain("250");
-      expect(result).toContain("greater than 100");
+      expect(result).toContain("above the 100 threshold");
     });
 
     /*
@@ -823,7 +823,7 @@ describe("ExternalStatusPageMonitorCriteria.isMonitorInstanceCriteriaFilterMet",
 
       expect(result).toContain("External Status Page Active Incidents");
       expect(result).toContain("3");
-      expect(result).toContain("greater than 2");
+      expect(result).toContain("above the 2 threshold");
     });
 
     test("incident count equal to threshold + GreaterThan → not met (boundary)", async () => {
@@ -857,7 +857,7 @@ describe("ExternalStatusPageMonitorCriteria.isMonitorInstanceCriteriaFilterMet",
         },
       );
 
-      expect(result).toContain("greater than or equal to 2");
+      expect(result).toContain("at or above the 2 threshold");
     });
 
     /*
@@ -876,7 +876,7 @@ describe("ExternalStatusPageMonitorCriteria.isMonitorInstanceCriteriaFilterMet",
       );
 
       expect(result).toContain("0");
-      expect(result).toContain("less than or equal to 5");
+      expect(result).toContain("at or below the 5 threshold");
     });
 
     test("zero incidents + GreaterThan zero → not met", async () => {
@@ -910,7 +910,7 @@ describe("ExternalStatusPageMonitorCriteria.isMonitorInstanceCriteriaFilterMet",
         },
       );
 
-      expect(result).toContain("greater than 2");
+      expect(result).toContain("above the 2 threshold");
     });
   });
 });

package/Tests/Server/Utils/Monitor/Criteria/MetricMonitorCriteria.test.ts

@@ -118,7 +118,7 @@ describe("MetricMonitorCriteria.isMonitorInstanceCriteriaFilterMet", () => {
      * ms is written "2.5 sec"; the threshold gets the same treatment so
      * the two halves of the sentence cannot disagree.
      */
-    expect(message).toContain("greater than 2 sec");
+    expect(message).toContain("above the 2 sec threshold");
     expect(message).toContain("2.5 sec");
     expect(criteriaFilter.metricCriteriaContext?.unit).toBe("ms");
     expect(criteriaFilter.metricCriteriaContext?.breachingSample?.value).toBe(
@@ -149,7 +149,7 @@ describe("MetricMonitorCriteria.isMonitorInstanceCriteriaFilterMet", () => {
       await MetricMonitorCriteria.isMonitorInstanceCriteriaFilterMet(inputs);
 
     expect(message).toBeTruthy();
-    expect(message).toContain("greater than 2 sec");
+    expect(message).toContain("above the 2 sec threshold");
     expect(message).toContain("2.5 sec");
     expect(criteriaFilter.metricCriteriaContext?.unit).toBe("sec");
     expect(criteriaFilter.metricCriteriaContext?.breachingSample?.value).toBe(
@@ -179,7 +179,7 @@ describe("MetricMonitorCriteria.isMonitorInstanceCriteriaFilterMet", () => {
       await MetricMonitorCriteria.isMonitorInstanceCriteriaFilterMet(inputs);
 
     expect(message).toBeTruthy();
-    expect(message).toContain("greater than 2 GB");
+    expect(message).toContain("above the 2 GB threshold");
     expect(message).toContain("2.5 GB");
     expect(criteriaFilter.metricCriteriaContext?.unit).toBe("GB");
   });
@@ -519,8 +519,10 @@ describe("MetricMonitorCriteria.isMonitorInstanceCriteriaFilterMet", () => {
      * land on a different scale than the other once values spread far
      * enough apart.
      */
-    expect(message).toContain("10 samples between 110 ms and 200 ms");
-    expect(message).toContain("greater than 100 ms");
+    expect(message).toContain(
+      "ranged from 110 ms to 200 ms across all 10 readings",
+    );
+    expect(message).toContain("above the 100 ms threshold");
     // The raw comma-joined dump is no longer in the message
     expect(message).not.toContain("110, 120, 130, 140, 150, 160");
   });

package/Tests/Server/Utils/Monitor/Criteria/ProfileMonitorCriteria.test.ts

@@ -47,7 +47,7 @@ describe("ProfileMonitorCriteria.isMonitorInstanceCriteriaFilterMet", () => {
       });
       expect(result).toBeTruthy();
       expect(result).toContain("Profile Count");
-      expect(result).toContain("greater than");
+      expect(result).toContain("above the 5 threshold");
     });
 
     test("count equal to threshold → not met (strict comparison)", async () => {
@@ -111,7 +111,7 @@ describe("ProfileMonitorCriteria.isMonitorInstanceCriteriaFilterMet", () => {
         value: 0,
       });
       expect(result).toBeTruthy();
-      expect(result).toContain("equal to 0");
+      expect(result).toContain("equal to the 0 threshold");
     });
 
     test("some profiles equal to 0 → not met", async () => {

package/Tests/Server/Utils/Monitor/Criteria/ServerMonitorCriteria.test.ts

@@ -279,7 +279,7 @@ describe("ServerMonitorCriteria.isMonitorInstanceCriteriaFilterMet", () => {
       );
 
       expect(result).toContain(CheckOn.CPUUsagePercent);
-      expect(result).toContain("greater than");
+      expect(result).toContain("above the 50 threshold");
       expect(result).toContain("80");
     });
 
@@ -1114,8 +1114,9 @@ describe("ServerMonitorCriteria.isMonitorInstanceCriteriaFilterMet", () => {
         },
       );
 
-      expect(result).toContain("All values of");
-      expect(result).toContain("95");
+      expect(result).toBe(
+        "Disk Usage (in %) on disk / over the last 5 minutes ranged from 95 to 97 across all 3 readings, above the 90 threshold.",
+      );
     });
 
     test("disk usage does not fire while its window is unusable", async () => {

package/Tests/Server/Utils/Monitor/Criteria/SnmpMonitorCriteria.test.ts

@@ -108,7 +108,7 @@ describe("SnmpMonitorCriteria.isMonitorInstanceCriteriaFilterMet", () => {
 
       expect(result).toBeTruthy();
       expect(result).toContain(PSU_OID);
-      expect(result).toContain("equal to 3");
+      expect(result).toContain("equal to the 3 threshold");
     });
 
     test("Integer 3 equals 5 → criteria is not met", async () => {
@@ -163,7 +163,7 @@ describe("SnmpMonitorCriteria.isMonitorInstanceCriteriaFilterMet", () => {
         });
 
       expect(result).toBeTruthy();
-      expect(result).toContain("not equal to 6");
+      expect(result).toContain("different from the 6 threshold");
     });
 
     test("Integer 3 contains '3' → criteria is met (string fallback path)", async () => {