@oneuptime/common 12.0.8 → 12.0.9

package/Tests/Types/Workflow/Templates.test.ts

@@ -10,15 +10,35 @@
  * argument is "value" (not "log-message"), the Schedule trigger's is
  * "schedule" (not "schedule-at"), the Manual trigger leaves by "success" and
  * the Schedule trigger by "execute" (neither is "out").
+ *
+ * Two things here are load-bearing and easy to get wrong when extending this
+ * file:
+ *
+ *   1. The registry is the MERGED one (loadComponentsAndCategories), not the
+ *      static Components array. Templates use database-model components like
+ *      `incident-on-create`, which only exist in the merged registry. Against
+ *      the static array those nodes get `metadata: undefined`, the linter's
+ *      isRealNode silently drops them, and the lint test passes on a graph it
+ *      never checked.
+ *
+ *   2. References are classified with parseReferencePath rather than by
+ *      assuming every {{...}} is local.components.*. Templates now also carry
+ *      {{local.variables.*}}, and a test that assumes otherwise fails on
+ *      correct templates.
  */
 
 import {
+  WORKFLOW_TEMPLATE_VARIABLE_NAME_REGEX,
   WorkflowTemplate,
+  WorkflowTemplateCategories,
+  WorkflowTemplateCategory,
+  WorkflowTemplateVariable,
   buildGraphForTemplate,
   getTemplateGraphSpec,
+  getWorkflowTemplate,
   getWorkflowTemplates,
+  getWorkflowTemplatesByCategory,
 } from "../../../Types/Workflow/Templates";
-import Components from "../../../Types/Workflow/Components";
 import ComponentMetadata, {
   Argument,
   ComponentType,
@@ -26,7 +46,8 @@ import ComponentMetadata, {
   Port,
   ReturnValue,
 } from "../../../Types/Workflow/Component";
-import { JSONObject } from "../../../Types/JSON";
+import { JSONObject, JSONValue } from "../../../Types/JSON";
+import IconProp from "../../../Types/Icon/IconProp";
 import {
   LintGraphEdge,
   LintGraphNode,
@@ -35,10 +56,28 @@ import {
   WorkflowLintSeverity,
   lintWorkflowGraph,
 } from "../../../UI/Components/Workflow/GraphLint";
+import { loadComponentsAndCategories } from "../../../UI/Components/Workflow/Utils";
+import {
+  ParsedReferencePath,
+  ReferenceRootType,
+  TemplateExpression,
+  TemplateExpressionKind,
+  parseReferencePath,
+  parseTemplateExpressions,
+} from "../../../Types/Workflow/TemplateSyntax";
 import { describe, expect, test } from "@jest/globals";
+import ComponentID from "../../../Types/Workflow/ComponentID";
+import CronTab from "../../../Utils/CronTab";
 
 const templates: Array<WorkflowTemplate> = getWorkflowTemplates();
 
+/*
+ * The same registry the builder loads: static components plus one set per
+ * database model. Built once — it walks every entity in the models index.
+ */
+const registry: Array<ComponentMetadata> =
+  loadComponentsAndCategories().components;
+
 type FindMetadataFunction = (
   metadataId: string,
 ) => ComponentMetadata | undefined;
@@ -46,7 +85,7 @@ type FindMetadataFunction = (
 const findMetadata: FindMetadataFunction = (
   metadataId: string,
 ): ComponentMetadata | undefined => {
-  return Components.find((component: ComponentMetadata) => {
+  return registry.find((component: ComponentMetadata) => {
     return component.id === metadataId;
   });
 };
@@ -60,6 +99,30 @@ const generateId: GenerateIdFunction = (): string => {
   return `generated-${idCounter}`;
 };
 
+interface TemplateNodeSpec {
+  componentId: string;
+  metadataId: string;
+  componentType: ComponentType;
+  args?: JSONObject | undefined;
+}
+
+interface TemplateEdgeSpec {
+  fromComponentId: string;
+  toComponentId: string;
+  fromPort: string;
+}
+
+interface TemplateSpec {
+  nodes: Array<TemplateNodeSpec>;
+  edges: Array<TemplateEdgeSpec>;
+}
+
+type SpecOfFunction = (templateId: string) => TemplateSpec;
+
+const specOf: SpecOfFunction = (templateId: string): TemplateSpec => {
+  return getTemplateGraphSpec(templateId) as unknown as TemplateSpec;
+};
+
 /**
  * Build a template's graph and hydrate each node with its real metadata, the
  * way the builder does on load. Without the metadata the linter cannot check
@@ -110,9 +173,128 @@ const hydrate: HydrateFunction = (
   return { nodes: nodes, edges: edges };
 };
 
+/** Every string an argument holds, including strings nested inside JSON objects. */
+type CollectStringsFunction = (value: JSONValue | undefined) => Array<string>;
+
+const collectStrings: CollectStringsFunction = (
+  value: JSONValue | undefined,
+): Array<string> => {
+  if (typeof value === "string") {
+    return [value];
+  }
+
+  if (Array.isArray(value)) {
+    return value.flatMap((entry: JSONValue) => {
+      return collectStrings(entry);
+    });
+  }
+
+  if (value && typeof value === "object") {
+    return Object.values(value as JSONObject).flatMap((entry: JSONValue) => {
+      return collectStrings(entry);
+    });
+  }
+
+  return [];
+};
+
+interface TemplateReference {
+  /** The full {{...}} text. */
+  raw: string;
+  inner: string;
+  parsed: ParsedReferencePath;
+  /** The component id the argument lives on. */
+  onComponentId: string;
+}
+
+type ReferencesOfFunction = (templateId: string) => Array<TemplateReference>;
+
+const referencesOf: ReferencesOfFunction = (
+  templateId: string,
+): Array<TemplateReference> => {
+  const spec: TemplateSpec = specOf(templateId);
+  const references: Array<TemplateReference> = [];
+
+  for (const node of spec.nodes) {
+    for (const value of Object.values(node.args || {})) {
+      for (const text of collectStrings(value as JSONValue)) {
+        const expressions: Array<TemplateExpression> =
+          parseTemplateExpressions(text);
+
+        for (const expression of expressions) {
+          if (expression.kind !== TemplateExpressionKind.Reference) {
+            continue;
+          }
+
+          references.push({
+            raw: expression.raw,
+            inner: expression.inner,
+            parsed: parseReferencePath(expression.inner),
+            onComponentId: node.componentId,
+          });
+        }
+      }
+    }
+  }
+
+  return references;
+};
+
+/**
+ * Whether a trigger's `select` argument actually asks for the field a
+ * reference reads. The runtime only hydrates what `select` names, so
+ * {{…returnValues.model.title}} against a select without `title` resolves to
+ * nothing — and an unresolved reference is not an error, it just ships the
+ * literal braces.
+ */
+type SelectCoversFunction = (
+  select: JSONValue | undefined,
+  path: Array<string>,
+) => boolean;
+
+const selectCovers: SelectCoversFunction = (
+  select: JSONValue | undefined,
+  path: Array<string>,
+): boolean => {
+  if (path.length === 0) {
+    return true;
+  }
+
+  /*
+   * ObjectID, Email, Phone and Date values are serialized for workflow storage
+   * as { _type, value }. Selecting the database column selects that wrapper;
+   * `.value` is a serialization detail rather than another database column.
+   */
+  if (path.length === 1 && path[0] === "value" && Boolean(select)) {
+    return true;
+  }
+
+  // The runtime always adds _id to the select it issues.
+  if (path.length === 1 && (path[0] === "_id" || path[0] === "id")) {
+    return true;
+  }
+
+  if (!select || typeof select !== "object" || Array.isArray(select)) {
+    return false;
+  }
+
+  const head: string = path[0] as string;
+  const branch: JSONValue | undefined = (select as JSONObject)[head];
+
+  if (branch === undefined) {
+    return false;
+  }
+
+  if (path.length === 1) {
+    return Boolean(branch);
+  }
+
+  return selectCovers(branch, path.slice(1));
+};
+
 describe("workflow templates", () => {
-  test("there is at least one", () => {
-    expect(templates.length).toBeGreaterThan(0);
+  test("there are plenty to choose from", () => {
+    expect(templates.length).toBeGreaterThan(10);
   });
 
   test("each has a unique id", () => {
@@ -123,6 +305,20 @@ describe("workflow templates", () => {
     expect(new Set(ids).size).toBe(ids.length);
   });
 
+  test("each id is dash-cased, so it is safe in a URL and in a test name", () => {
+    for (const template of templates) {
+      expect(template.id).toMatch(/^[a-z0-9]+(-[a-z0-9]+)*$/);
+    }
+  });
+
+  test("each suggests a distinct workflow name", () => {
+    const names: Array<string> = templates.map((template: WorkflowTemplate) => {
+      return template.workflowName;
+    });
+
+    expect(new Set(names).size).toBe(names.length);
+  });
+
   test("each is described well enough to choose between them", () => {
     for (const template of templates) {
       expect(template.name.length).toBeGreaterThan(0);
@@ -133,35 +329,306 @@ describe("workflow templates", () => {
     }
   });
 
+  test("each belongs to a category the picker knows how to show", () => {
+    for (const template of templates) {
+      expect(WorkflowTemplateCategories).toContain(template.category);
+    }
+  });
+
+  test("each category in the picker has at least one template", () => {
+    for (const category of WorkflowTemplateCategories) {
+      expect(getWorkflowTemplatesByCategory(category).length).toBeGreaterThan(
+        0,
+      );
+    }
+  });
+
+  test("grouping by category accounts for every template exactly once", () => {
+    const grouped: Array<WorkflowTemplate> = WorkflowTemplateCategories.flatMap(
+      (category: WorkflowTemplateCategory) => {
+        return getWorkflowTemplatesByCategory(category);
+      },
+    );
+
+    expect(grouped).toHaveLength(templates.length);
+  });
+
+  test("each has an icon that exists", () => {
+    const iconValues: Array<string> = Object.values(IconProp);
+
+    for (const template of templates) {
+      expect(iconValues).toContain(template.icon);
+    }
+  });
+
+  test("getWorkflowTemplate finds each one, and nothing else", () => {
+    for (const template of templates) {
+      expect(getWorkflowTemplate(template.id)?.name).toBe(template.name);
+    }
+
+    expect(getWorkflowTemplate("does-not-exist")).toBeNull();
+  });
+
   test("an unknown template id yields nothing rather than throwing", () => {
     expect(getTemplateGraphSpec("does-not-exist")).toBeNull();
     expect(buildGraphForTemplate("does-not-exist", generateId)).toBeNull();
   });
+
+  test("the public template carries no graph, so the picker cannot depend on one", () => {
+    for (const template of templates) {
+      expect((template as unknown as JSONObject)["graph"]).toBeUndefined();
+    }
+  });
+
+  /*
+   * Every field on WorkflowTemplate has to survive the trip out of the module.
+   * The accessor used to hand-enumerate its output fields, which silently
+   * dropped anything newly added — the picker would render a card with no icon
+   * and the wizard would show no variables step.
+   */
+  test("no declared field is dropped on the way out", () => {
+    for (const template of templates) {
+      expect(Object.keys(template).sort()).toEqual(
+        [
+          "category",
+          "description",
+          "icon",
+          "id",
+          "name",
+          "teaches",
+          "variables",
+          "workflowDescription",
+          "workflowName",
+        ].sort(),
+      );
+    }
+  });
+});
+
+describe("workflow template variables", () => {
+  test("names are usable in a reference path", () => {
+    for (const template of templates) {
+      for (const variable of template.variables) {
+        expect(variable.name).toMatch(WORKFLOW_TEMPLATE_VARIABLE_NAME_REGEX);
+      }
+    }
+  });
+
+  /*
+   * A dot is fatal specifically: VMUtil.deepFind splits the whole path on
+   * dots, so local.variables.slack.url looks for a variable called "slack".
+   */
+  test("no name contains a dot or whitespace", () => {
+    for (const template of templates) {
+      for (const variable of template.variables) {
+        expect(variable.name).not.toContain(".");
+        expect(variable.name).not.toMatch(/\s/);
+      }
+    }
+  });
+
+  test("names are unique within a template, because they become one row each", () => {
+    for (const template of templates) {
+      const names: Array<string> = template.variables.map(
+        (variable: WorkflowTemplateVariable) => {
+          return variable.name;
+        },
+      );
+
+      expect(new Set(names).size).toBe(names.length);
+    }
+  });
+
+  test("each is described well enough to fill in", () => {
+    for (const template of templates) {
+      for (const variable of template.variables) {
+        expect(variable.title.length).toBeGreaterThan(0);
+        expect(variable.description.length).toBeGreaterThan(0);
+        expect(variable.placeholder.length).toBeGreaterThan(0);
+        expect(typeof variable.required).toBe("boolean");
+        expect(typeof variable.isSecret).toBe("boolean");
+      }
+    }
+  });
+
+  /*
+   * A variable name is reused across templates on purpose (slackWebhookUrl
+   * appears in many), and each template is free to label and explain it in its
+   * own words — "URL to call" reads better on an hourly poll than "URL to
+   * check" does. Variables are workflow-scoped, so two templates never share a
+   * row, and nothing forces the wording to agree.
+   *
+   * What must NOT drift is the behaviour attached to the name. `required`
+   * decides whether a row is written at all, and `isSecret` decides whether
+   * the value is redacted from run logs. The same field being secret in one
+   * template and not in another is a bug, not a wording choice.
+   */
+  test("a name reused across templates behaves the same way", () => {
+    const byName: Map<string, { required: boolean; isSecret: boolean }> =
+      new Map();
+
+    for (const template of templates) {
+      for (const variable of template.variables) {
+        const behaviour: { required: boolean; isSecret: boolean } = {
+          required: variable.required,
+          isSecret: variable.isSecret,
+        };
+
+        const seen: { required: boolean; isSecret: boolean } | undefined =
+          byName.get(variable.name);
+
+        if (!seen) {
+          byName.set(variable.name, behaviour);
+          continue;
+        }
+
+        expect({ name: variable.name, ...behaviour }).toEqual({
+          name: variable.name,
+          ...seen,
+        });
+      }
+    }
+  });
+
+  test("secrets are the ones that should be secret", () => {
+    for (const template of templates) {
+      for (const variable of template.variables) {
+        if (!variable.isSecret) {
+          continue;
+        }
+
+        expect(variable.title.toLowerCase()).toMatch(
+          /url|token|password|key|secret/,
+        );
+      }
+    }
+  });
+});
+
+describe("workflow template runtime contracts", () => {
+  test("JavaScript transform receives the webhook body as an object-shaped whole argument", () => {
+    const javascriptNode: TemplateNodeSpec = specOf(
+      "javascript-transform",
+    ).nodes.find((node: TemplateNodeSpec) => {
+      return node.componentId === "javascript-1";
+    }) as TemplateNodeSpec;
+
+    expect(javascriptNode.args?.["arguments"]).toBe(
+      "{{local.components.webhook-1.returnValues.request-body}}",
+    );
+    expect(javascriptNode.args?.["code"] as string).toContain(
+      "const body = args || {};",
+    );
+  });
+
+  test("AI incident data stays in the protected context instead of the prompt", () => {
+    const aiNode: TemplateNodeSpec = specOf(
+      "incident-created-ai-summary",
+    ).nodes.find((node: TemplateNodeSpec) => {
+      return node.componentId === "ai-1";
+    }) as TemplateNodeSpec;
+
+    expect(aiNode.args?.["prompt"] as string).not.toContain("{{");
+    expect(aiNode.args?.["context"]).toBe(
+      "{{local.components.incident-on-create-1.returnValues.model}}",
+    );
+  });
+
+  test.each(["subscriber-added-slack", "subscriber-added-forward"])(
+    "%s waits for confirmation updates and normalizes the contact method",
+    (templateId: string) => {
+      const spec: TemplateSpec = specOf(templateId);
+      const trigger: TemplateNodeSpec = spec.nodes.find(
+        (node: TemplateNodeSpec) => {
+          return node.componentType === ComponentType.Trigger;
+        },
+      ) as TemplateNodeSpec;
+
+      expect(trigger.metadataId).toBe("status-page-subscriber-on-update");
+      expect(trigger.args?.["listen-on"]).toEqual({
+        isSubscriptionConfirmed: true,
+      });
+      expect(
+        spec.nodes.some((node: TemplateNodeSpec) => {
+          return node.componentId === "subscriber-normalize-1";
+        }),
+      ).toBe(true);
+    },
+  );
+
+  test("on-call notification follows real execution updates, not the scheduled create event", () => {
+    const trigger: TemplateNodeSpec = specOf(
+      "oncall-executed-slack",
+    ).nodes.find((node: TemplateNodeSpec) => {
+      return node.componentType === ComponentType.Trigger;
+    }) as TemplateNodeSpec;
+
+    expect(trigger.metadataId).toBe(
+      "on-call-duty-policy-execution-log-on-update",
+    );
+    expect(trigger.args?.["listen-on"]).toEqual({ status: true });
+  });
+
+  test("credential-bearing destination URLs are treated as secrets", () => {
+    for (const template of templates) {
+      for (const variable of template.variables) {
+        const normalizedVariableName: string = variable.name.toLowerCase();
+
+        if (
+          !["webhookurl", "forwardurl", "targeturl", "heartbeaturl"].some(
+            (secretUrlName: string): boolean => {
+              return normalizedVariableName.includes(secretUrlName);
+            },
+          )
+        ) {
+          continue;
+        }
+
+        expect({
+          template: template.id,
+          variable: variable.name,
+          isSecret: variable.isSecret,
+        }).toEqual({
+          template: template.id,
+          variable: variable.name,
+          isSecret: true,
+        });
+      }
+    }
+  });
 });
 
 describe.each(
   templates.map((template: WorkflowTemplate) => {
     return [template.id, template] as [string, WorkflowTemplate];
   }),
-)("template %s", (templateId: string) => {
+)("template %s", (templateId: string, template: WorkflowTemplate) => {
   test("every component it uses exists in the registry", () => {
-    const spec: { nodes: Array<{ metadataId: string }> } = getTemplateGraphSpec(
-      templateId,
-    ) as { nodes: Array<{ metadataId: string }> };
+    for (const node of specOf(templateId).nodes) {
+      expect({
+        metadataId: node.metadataId,
+        found: Boolean(findMetadata(node.metadataId)),
+      }).toEqual({ metadataId: node.metadataId, found: true });
+    }
+  });
 
-    for (const node of spec.nodes) {
-      expect(findMetadata(node.metadataId)).toBeDefined();
+  /*
+   * The builder throws BadDataException on load for a node whose metadataId is
+   * not in the registry, which breaks the whole page rather than one node. So
+   * a typo here does not degrade a template, it bricks it.
+   */
+  test("the node's declared componentType matches the registry's", () => {
+    for (const node of specOf(templateId).nodes) {
+      const metadata: ComponentMetadata = findMetadata(
+        node.metadataId,
+      ) as ComponentMetadata;
+
+      expect(node.componentType).toBe(metadata.componentType);
     }
   });
 
   test("every argument it sets is a real argument on that component", () => {
-    const spec: {
-      nodes: Array<{ metadataId: string; args?: JSONObject | undefined }>;
-    } = getTemplateGraphSpec(templateId) as {
-      nodes: Array<{ metadataId: string; args?: JSONObject | undefined }>;
-    };
-
-    for (const node of spec.nodes) {
+    for (const node of specOf(templateId).nodes) {
       const metadata: ComponentMetadata = findMetadata(
         node.metadataId,
       ) as ComponentMetadata;
@@ -173,7 +640,31 @@ describe.each(
           },
         );
 
-        expect(argument).toBeDefined();
+        expect({
+          node: node.componentId,
+          argumentId: argumentId,
+          found: Boolean(argument),
+        }).toEqual({
+          node: node.componentId,
+          argumentId: argumentId,
+          found: true,
+        });
+      }
+    }
+  });
+
+  test("every required argument is filled in", () => {
+    for (const node of specOf(templateId).nodes) {
+      const metadata: ComponentMetadata = findMetadata(
+        node.metadataId,
+      ) as ComponentMetadata;
+
+      for (const argument of metadata.arguments) {
+        if (!argument.required) {
+          continue;
+        }
+
+        expect(Object.keys(node.args || {})).toContain(argument.id);
       }
     }
   });
@@ -184,20 +675,14 @@ describe.each(
    * first step.
    */
   test("every edge leaves a port the component actually has", () => {
-    const spec: {
-      nodes: Array<{ componentId: string; metadataId: string }>;
-      edges: Array<{ fromComponentId: string; fromPort: string }>;
-    } = getTemplateGraphSpec(templateId) as {
-      nodes: Array<{ componentId: string; metadataId: string }>;
-      edges: Array<{ fromComponentId: string; fromPort: string }>;
-    };
+    const spec: TemplateSpec = specOf(templateId);
 
     for (const edge of spec.edges) {
-      const node: { metadataId: string } = spec.nodes.find(
-        (candidate: { componentId: string }) => {
+      const node: TemplateNodeSpec = spec.nodes.find(
+        (candidate: TemplateNodeSpec) => {
           return candidate.componentId === edge.fromComponentId;
         },
-      ) as { metadataId: string };
+      ) as TemplateNodeSpec;
 
       const metadata: ComponentMetadata = findMetadata(
         node.metadataId,
@@ -209,89 +694,336 @@ describe.each(
         },
       );
 
-      expect(port).toBeDefined();
+      expect({
+        from: edge.fromComponentId,
+        port: edge.fromPort,
+        found: Boolean(port),
+      }).toEqual({
+        from: edge.fromComponentId,
+        port: edge.fromPort,
+        found: true,
+      });
     }
   });
 
-  test("every required argument is filled in", () => {
-    const spec: {
-      nodes: Array<{ metadataId: string; args?: JSONObject | undefined }>;
-    } = getTemplateGraphSpec(templateId) as {
-      nodes: Array<{ metadataId: string; args?: JSONObject | undefined }>;
-    };
+  test("every fallible component handles its Error port", () => {
+    const spec: TemplateSpec = specOf(templateId);
 
     for (const node of spec.nodes) {
       const metadata: ComponentMetadata = findMetadata(
         node.metadataId,
       ) as ComponentMetadata;
+      const hasErrorPort: boolean = metadata.outPorts.some((port: Port) => {
+        return port.id === "error";
+      });
 
-      for (const argument of metadata.arguments) {
-        if (!argument.required) {
-          continue;
-        }
+      if (!hasErrorPort) {
+        continue;
+      }
 
-        expect(Object.keys(node.args || {})).toContain(argument.id);
+      expect({
+        componentId: node.componentId,
+        handlesError: spec.edges.some((edge: TemplateEdgeSpec) => {
+          return (
+            edge.fromComponentId === node.componentId &&
+            edge.fromPort === "error"
+          );
+        }),
+      }).toEqual({ componentId: node.componentId, handlesError: true });
+    }
+  });
+
+  test("Slack messages start with an emoji and a scannable heading", () => {
+    for (const node of specOf(templateId).nodes) {
+      if (node.metadataId !== ComponentID.SlackSendMessageToChannel) {
+        continue;
       }
+
+      expect(node.args?.["text"]).toEqual(expect.any(String));
+      expect(node.args?.["text"] as string).toMatch(
+        /^:[a-z0-9_+-]+: \*[^\n]+\*/,
+      );
     }
   });
 
-  test("every {{...}} reference points at a return value that exists", () => {
-    const spec: {
-      nodes: Array<{ componentId: string; metadataId: string }>;
-    } = getTemplateGraphSpec(templateId) as {
-      nodes: Array<{ componentId: string; metadataId: string }>;
-    };
+  test("schedule expressions are valid cron", () => {
+    for (const node of specOf(templateId).nodes) {
+      if (node.metadataId !== ComponentID.Schedule) {
+        continue;
+      }
 
-    const graph: { nodes: Array<LintGraphNode>; edges: Array<LintGraphEdge> } =
-      hydrate(templateId);
+      expect(CronTab.isValid(node.args?.["schedule"] as string)).toBe(true);
+    }
+  });
 
-    const references: Array<string> = [];
+  test("every edge connects component ids the template declares", () => {
+    const spec: TemplateSpec = specOf(templateId);
 
-    for (const node of graph.nodes) {
-      for (const value of Object.values(node.data.arguments || {})) {
-        if (typeof value !== "string") {
-          continue;
-        }
+    const componentIds: Array<string> = spec.nodes.map(
+      (node: TemplateNodeSpec) => {
+        return node.componentId;
+      },
+    );
+
+    for (const edge of spec.edges) {
+      expect(componentIds).toContain(edge.fromComponentId);
+      expect(componentIds).toContain(edge.toComponentId);
+    }
+  });
+
+  test("component ids are unique and dot-free", () => {
+    const componentIds: Array<string> = specOf(templateId).nodes.map(
+      (node: TemplateNodeSpec) => {
+        return node.componentId;
+      },
+    );
+
+    expect(new Set(componentIds).size).toBe(componentIds.length);
+
+    for (const componentId of componentIds) {
+      expect(componentId).not.toContain(".");
+    }
+  });
+
+  test("has exactly one trigger, and it is a real trigger component", () => {
+    const triggers: Array<TemplateNodeSpec> = specOf(templateId).nodes.filter(
+      (node: TemplateNodeSpec) => {
+        return node.componentType === ComponentType.Trigger;
+      },
+    );
+
+    expect(triggers).toHaveLength(1);
+
+    const metadata: ComponentMetadata = findMetadata(
+      triggers[0]?.metadataId as string,
+    ) as ComponentMetadata;
+
+    expect(metadata.componentType).toBe(ComponentType.Trigger);
+  });
+
+  /*
+   * saveTriggerFromGraph takes the LAST trigger node in the graph while the
+   * runner takes the FIRST, so a second trigger would denormalize one id and
+   * run another.
+   */
+  test("no node other than the trigger is a trigger", () => {
+    const spec: TemplateSpec = specOf(templateId);
+
+    for (const node of spec.nodes) {
+      const metadata: ComponentMetadata = findMetadata(
+        node.metadataId,
+      ) as ComponentMetadata;
 
-        const matches: Array<string> = value.match(/{{(.*?)}}/g) || [];
-        references.push(...matches);
+      if (node.componentType === ComponentType.Trigger) {
+        continue;
       }
+
+      expect(metadata.componentType).not.toBe(ComponentType.Trigger);
     }
+  });
 
-    for (const reference of references) {
-      const path: string = reference.slice(2, -2);
-      const parts: Array<string> = path.split(".");
+  test("every reference is a root the runtime actually has", () => {
+    for (const reference of referencesOf(templateId)) {
+      expect({
+        reference: reference.raw,
+        rootType: reference.parsed.rootType,
+      }).not.toEqual({
+        reference: reference.raw,
+        rootType: ReferenceRootType.Unknown,
+      });
+    }
+  });
 
-      expect(parts[0]).toBe("local");
-      expect(parts[1]).toBe("components");
+  /*
+   * The runtime hands the raw capture to deepFind without trimming, so a space
+   * inside the braces resolves to nothing. The linter calls it an error too.
+   */
+  test("no reference has whitespace inside its braces", () => {
+    for (const reference of referencesOf(templateId)) {
+      expect(reference.raw).toBe(`{{${reference.inner}}}`);
+      expect(reference.inner).not.toMatch(/\s/);
+    }
+  });
 
-      const referencedNode: { metadataId: string } = spec.nodes.find(
-        (candidate: { componentId: string }) => {
-          return candidate.componentId === parts[2];
-        },
-      ) as { metadataId: string };
+  test("every component reference points at a component in this template", () => {
+    const componentIds: Array<string> = specOf(templateId).nodes.map(
+      (node: TemplateNodeSpec) => {
+        return node.componentId;
+      },
+    );
 
-      expect(referencedNode).toBeDefined();
-      expect(parts[3]).toBe("returnValues");
+    for (const reference of referencesOf(templateId)) {
+      if (
+        reference.parsed.rootType !== ReferenceRootType.ComponentReturnValue
+      ) {
+        continue;
+      }
+
+      expect(componentIds).toContain(reference.parsed.componentId);
+    }
+  });
+
+  test("every component reference points at a return value that exists", () => {
+    const spec: TemplateSpec = specOf(templateId);
+
+    for (const reference of referencesOf(templateId)) {
+      if (
+        reference.parsed.rootType !== ReferenceRootType.ComponentReturnValue
+      ) {
+        continue;
+      }
+
+      const referenced: TemplateNodeSpec = spec.nodes.find(
+        (node: TemplateNodeSpec) => {
+          return node.componentId === reference.parsed.componentId;
+        },
+      ) as TemplateNodeSpec;
 
       const metadata: ComponentMetadata = findMetadata(
-        referencedNode.metadataId,
+        referenced.metadataId,
       ) as ComponentMetadata;
 
       const returnValue: ReturnValue | undefined = metadata.returnValues.find(
         (candidate: ReturnValue) => {
-          return candidate.id === parts[4];
+          return candidate.id === reference.parsed.returnValueId;
         },
       );
 
-      expect(returnValue).toBeDefined();
+      expect({
+        reference: reference.raw,
+        found: Boolean(returnValue),
+      }).toEqual({ reference: reference.raw, found: true });
     }
   });
 
   /*
-   * The end-to-end check: run the shipped template through the same linter the
-   * builder applies to a graph someone is editing. Zero errors is the bar.
+   * The one that catches the subtlest template bug there is. A database
+   * trigger only hydrates the columns its `select` names, so reading
+   * .model.title without asking for `title` yields nothing — and yielding
+   * nothing is not an error anywhere in the stack. The run succeeds and posts
+   * "Incident: {{local.components.…}}" to Slack.
    */
+  test("every field read off a database record was asked for in select", () => {
+    const spec: TemplateSpec = specOf(templateId);
+
+    for (const reference of referencesOf(templateId)) {
+      if (
+        reference.parsed.rootType !== ReferenceRootType.ComponentReturnValue
+      ) {
+        continue;
+      }
+
+      if (reference.parsed.returnValueId !== "model") {
+        continue;
+      }
+
+      const referenced: TemplateNodeSpec = spec.nodes.find(
+        (node: TemplateNodeSpec) => {
+          return node.componentId === reference.parsed.componentId;
+        },
+      ) as TemplateNodeSpec;
+
+      const select: JSONValue | undefined = (referenced.args || {})[
+        "select"
+      ] as JSONValue | undefined;
+
+      const segments: Array<string> = reference.inner.split(".");
+      // local . components . <id> . returnValues . model . <field...>
+      const fieldPath: Array<string> = segments.slice(5);
+
+      if (fieldPath.length === 0) {
+        continue;
+      }
+
+      expect({
+        reference: reference.raw,
+        covered: selectCovers(select, fieldPath),
+      }).toEqual({ reference: reference.raw, covered: true });
+    }
+  });
+
+  test("every variable it declares is actually used by the graph", () => {
+    const used: Set<string> = new Set(
+      referencesOf(templateId)
+        .filter((reference: TemplateReference) => {
+          return reference.parsed.rootType === ReferenceRootType.LocalVariable;
+        })
+        .map((reference: TemplateReference) => {
+          return reference.parsed.variableName as string;
+        }),
+    );
+
+    for (const variable of template.variables) {
+      expect({
+        variable: variable.name,
+        used: used.has(variable.name),
+      }).toEqual({ variable: variable.name, used: true });
+    }
+  });
+
+  /*
+   * The inverse, and the more dangerous direction: a reference to a variable
+   * the wizard never asks for means no row is ever written for it, and the
+   * literal braces ship.
+   */
+  test("every variable the graph references is declared by the template", () => {
+    const declared: Array<string> = template.variables.map(
+      (variable: WorkflowTemplateVariable) => {
+        return variable.name;
+      },
+    );
+
+    for (const reference of referencesOf(templateId)) {
+      if (reference.parsed.rootType !== ReferenceRootType.LocalVariable) {
+        continue;
+      }
+
+      expect({
+        reference: reference.raw,
+        declared: declared.includes(reference.parsed.variableName as string),
+      }).toEqual({ reference: reference.raw, declared: true });
+    }
+  });
+
+  /*
+   * The wizard only ever writes workflow-scoped variables, so a template
+   * reaching for a project-global one would silently find nothing.
+   */
+  test("it does not reach for project-global variables", () => {
+    for (const reference of referencesOf(templateId)) {
+      expect(reference.parsed.rootType).not.toBe(
+        ReferenceRootType.GlobalVariable,
+      );
+    }
+  });
+
+  /*
+   * An optional variable's reference must be the ENTIRE argument value. That
+   * is what lets the wizard drop the argument when the field is left blank; a
+   * reference embedded in a longer string would survive the strip and leave
+   * the braces behind in the saved workflow.
+   */
+  test("an optional variable's reference is the whole argument, so it can be dropped", () => {
+    for (const variable of template.variables) {
+      if (variable.required) {
+        continue;
+      }
+
+      const spec: TemplateSpec = specOf(templateId);
+      const token: string = `{{local.variables.${variable.name}}}`;
+
+      for (const node of spec.nodes) {
+        for (const value of Object.values(node.args || {})) {
+          if (typeof value !== "string" || !value.includes(token)) {
+            continue;
+          }
+
+          expect(value.trim()).toBe(token);
+        }
+      }
+    }
+  });
+
   test("passes the builder's own graph checks with no errors", () => {
     const result: WorkflowLintResult = lintWorkflowGraph(hydrate(templateId));
 
@@ -308,26 +1040,19 @@ describe.each(
     ).toEqual([]);
   });
 
-  test("has exactly one trigger, and it is a real trigger component", () => {
-    const spec: {
-      nodes: Array<{ metadataId: string; componentType: ComponentType }>;
-    } = getTemplateGraphSpec(templateId) as {
-      nodes: Array<{ metadataId: string; componentType: ComponentType }>;
-    };
-
-    const triggers: Array<{ metadataId: string }> = spec.nodes.filter(
-      (node: { componentType: ComponentType }) => {
-        return node.componentType === ComponentType.Trigger;
-      },
-    );
-
-    expect(triggers).toHaveLength(1);
-
-    const metadata: ComponentMetadata = findMetadata(
-      triggers[0]?.metadataId as string,
-    ) as ComponentMetadata;
+  /*
+   * Warnings too. UnreachableComponent is only a warning, so without this a
+   * template could ship with a stray node that never runs and no test would
+   * notice.
+   */
+  test("passes the builder's own graph checks with no warnings either", () => {
+    const result: WorkflowLintResult = lintWorkflowGraph(hydrate(templateId));
 
-    expect(metadata.componentType).toBe(ComponentType.Trigger);
+    expect(
+      result.issues.map((issue: WorkflowLintIssue) => {
+        return issue.message;
+      }),
+    ).toEqual([]);
   });
 
   /*
@@ -360,7 +1085,52 @@ describe.each(
     }
   });
 
+  test("builds fresh edge ids each time too", () => {
+    type EdgeIdsFunction = (graph: JSONObject) => Array<string>;
+
+    const edgeIds: EdgeIdsFunction = (graph: JSONObject): Array<string> => {
+      return (graph["edges"] as Array<JSONObject>).map((edge: JSONObject) => {
+        return edge["id"] as string;
+      });
+    };
+
+    const first: Array<string> = edgeIds(
+      buildGraphForTemplate(templateId, generateId) as JSONObject,
+    );
+    const second: Array<string> = edgeIds(
+      buildGraphForTemplate(templateId, generateId) as JSONObject,
+    );
+
+    for (const id of first) {
+      expect(second).not.toContain(id);
+    }
+  });
+
   test("keeps stable component ids, because references point at them", () => {
+    type ComponentIdsFunction = (graph: JSONObject) => Array<string>;
+
+    const componentIds: ComponentIdsFunction = (
+      graph: JSONObject,
+    ): Array<string> => {
+      return (graph["nodes"] as Array<JSONObject>).map((node: JSONObject) => {
+        return (node["data"] as JSONObject)["id"] as string;
+      });
+    };
+
+    expect(
+      componentIds(buildGraphForTemplate(templateId, generateId) as JSONObject),
+    ).toEqual(
+      componentIds(buildGraphForTemplate(templateId, generateId) as JSONObject),
+    );
+  });
+
+  /*
+   * A built graph gets edited afterwards — by the wizard stripping arguments
+   * for blank optional variables, and by the builder. Sharing the argument
+   * object with the shipped definition would let that editing leak into every
+   * later workflow built in the same process.
+   */
+  test("built graphs do not share argument objects with the definition", () => {
     const first: JSONObject = buildGraphForTemplate(
       templateId,
       generateId,
@@ -370,17 +1140,25 @@ describe.each(
       generateId,
     ) as JSONObject;
 
-    type ComponentIdsFunction = (graph: JSONObject) => Array<string>;
-
-    const componentIds: ComponentIdsFunction = (
+    const argumentsOf: (graph: JSONObject, index: number) => JSONObject = (
       graph: JSONObject,
-    ): Array<string> => {
-      return (graph["nodes"] as Array<JSONObject>).map((node: JSONObject) => {
-        return (node["data"] as JSONObject)["id"] as string;
-      });
+      index: number,
+    ): JSONObject => {
+      const node: JSONObject = (graph["nodes"] as Array<JSONObject>)[
+        index
+      ] as JSONObject;
+
+      return (node["data"] as JSONObject)["arguments"] as JSONObject;
     };
 
-    expect(componentIds(first)).toEqual(componentIds(second));
+    const firstArguments: JSONObject = argumentsOf(first, 0);
+
+    (firstArguments as JSONObject)["__scribbled"] = "yes";
+
+    expect(argumentsOf(second, 0)["__scribbled"]).toBeUndefined();
+    expect(
+      (specOf(templateId).nodes[0]?.args || {})["__scribbled"],
+    ).toBeUndefined();
   });
 
   test("edges connect nodes that are in the graph", () => {
@@ -400,4 +1178,41 @@ describe.each(
       expect(nodeIds).toContain(edge["target"] as string);
     }
   });
+
+  test("every edge targets the in port, which is what react-flow attaches to", () => {
+    const graph: JSONObject = buildGraphForTemplate(
+      templateId,
+      generateId,
+    ) as JSONObject;
+
+    for (const edge of graph["edges"] as Array<JSONObject>) {
+      expect(edge["targetHandle"]).toBe("in");
+    }
+  });
+
+  test("every non-trigger node has an in port for that edge to land on", () => {
+    const spec: TemplateSpec = specOf(templateId);
+
+    const targeted: Set<string> = new Set(
+      spec.edges.map((edge: TemplateEdgeSpec) => {
+        return edge.toComponentId;
+      }),
+    );
+
+    for (const node of spec.nodes) {
+      if (!targeted.has(node.componentId)) {
+        continue;
+      }
+
+      const metadata: ComponentMetadata = findMetadata(
+        node.metadataId,
+      ) as ComponentMetadata;
+
+      expect(
+        metadata.inPorts.map((port: Port) => {
+          return port.id;
+        }),
+      ).toContain("in");
+    }
+  });
 });