@onerjs/core 8.42.7 → 8.42.8

package/Materials/PBR/openpbrMaterial.js

@@ -1312,7 +1312,7 @@ export class OpenPBRMaterial extends OpenPBRMaterialBase {
         }
         const previousEffect = subMesh.effect;
         const lightDisposed = defines._areLightsDisposed;
-        let effect = this._prepareEffect(mesh, subMesh.getRenderingMesh(), defines, this.onCompiled, this.onError, useInstances, null);
+        const effect = this._prepareEffect(mesh, subMesh.getRenderingMesh(), defines, this.onCompiled, this.onError, useInstances, null);
         let forceWasNotReadyPreviously = false;
         if (effect) {
             if (this._onEffectCreatedObservable) {
@@ -1322,7 +1322,6 @@ export class OpenPBRMaterial extends OpenPBRMaterialBase {
             }
             // Use previous effect while new one is compiling
             if (this.allowShaderHotSwapping && previousEffect && !effect.isReady()) {
-                effect = previousEffect;
                 defines.markAsUnprocessed();
                 forceWasNotReadyPreviously = this.isFrozen;
                 if (lightDisposed) {
@@ -1429,11 +1428,10 @@ export class OpenPBRMaterial extends OpenPBRMaterialBase {
         const mustRebind = this._mustRebind(scene, effect, subMesh, mesh.visibility);
         // Bones
         BindBonesParameters(mesh, this._activeEffect, this.prePassConfiguration);
-        let radianceTexture = null;
         const ubo = this._uniformBuffer;
         if (mustRebind) {
             this.bindViewProjection(effect);
-            radianceTexture = this._getRadianceTexture();
+            const radianceTexture = this._getRadianceTexture();
             if (!ubo.useUbo || !this.isFrozen || !ubo.isSync || subMesh._drawWrapper._forceRebindOnNextCall) {
                 // Texture uniforms
                 if (scene.texturesEnabled) {
@@ -1697,7 +1695,7 @@ export class OpenPBRMaterial extends OpenPBRMaterialBase {
         if (defines.TANGENT) {
             fallbacks.addFallback(fallbackRank++, "TANGENT");
         }
-        fallbackRank = HandleFallbacksForShadows(defines, fallbacks, this._maxSimultaneousLights, fallbackRank++);
+        fallbackRank = HandleFallbacksForShadows(defines, fallbacks, this._maxSimultaneousLights, fallbackRank);
         if (defines.SPECULARTERM) {
             fallbacks.addFallback(fallbackRank++, "SPECULARTERM");
         }