@nathapp/nax 0.28.0 → 0.29.0

package/test/unit/registry.test.ts

@@ -1,288 +0,0 @@
-// RE-ARCH: keep
-/**
- * Tests for src/plugins/registry.ts
- *
- * Covers: PluginRegistry getters and teardownAll
- */
-
-import { describe, expect, it, mock } from "bun:test";
-import { PluginRegistry } from "../../src/plugins/registry";
-import type { NaxPlugin } from "../../src/plugins/types";
-
-// ─────────────────────────────────────────────────────────────────────────────
-// Test fixtures
-// ─────────────────────────────────────────────────────────────────────────────
-
-const createMockPlugin = (name: string, provides: string[], extensions: any = {}): NaxPlugin => ({
-  name,
-  version: "1.0.0",
-  provides,
-  extensions,
-  init: async () => {},
-});
-
-// ─────────────────────────────────────────────────────────────────────────────
-// PluginRegistry.getOptimizers
-// ─────────────────────────────────────────────────────────────────────────────
-
-describe("PluginRegistry.getOptimizers", () => {
-  it("returns empty array when no optimizer plugins", () => {
-    const registry = new PluginRegistry([createMockPlugin("agent-plugin", ["agent"])]);
-
-    const optimizers = registry.getOptimizers();
-    expect(optimizers.length).toBe(0);
-  });
-
-  it("returns all optimizer plugins", () => {
-    const optimizer1 = { name: "optimizer1", optimize: async () => "optimized" };
-    const optimizer2 = { name: "optimizer2", optimize: async () => "optimized" };
-
-    const registry = new PluginRegistry([
-      createMockPlugin("opt-1", ["optimizer"], { optimizer: optimizer1 }),
-      createMockPlugin("opt-2", ["optimizer"], { optimizer: optimizer2 }),
-    ]);
-
-    const optimizers = registry.getOptimizers();
-    expect(optimizers.length).toBe(2);
-    expect(optimizers).toContain(optimizer1);
-    expect(optimizers).toContain(optimizer2);
-  });
-
-  it("filters out plugins without optimizer extension", () => {
-    const optimizer1 = { name: "optimizer1", optimize: async () => "optimized" };
-
-    const registry = new PluginRegistry([
-      createMockPlugin("opt-1", ["optimizer"], { optimizer: optimizer1 }),
-      createMockPlugin("no-opt", ["optimizer"], {}),
-    ]);
-
-    const optimizers = registry.getOptimizers();
-    expect(optimizers.length).toBe(1);
-    expect(optimizers[0]).toBe(optimizer1);
-  });
-});
-
-// ─────────────────────────────────────────────────────────────────────────────
-// PluginRegistry.getRouters
-// ─────────────────────────────────────────────────────────────────────────────
-
-describe("PluginRegistry.getRouters", () => {
-  it("returns empty array when no router plugins", () => {
-    const registry = new PluginRegistry([createMockPlugin("agent-plugin", ["agent"])]);
-
-    const routers = registry.getRouters();
-    expect(routers.length).toBe(0);
-  });
-
-  it("returns all router plugins in load order", () => {
-    const router1 = { name: "router1" } as any;
-    const router2 = { name: "router2" } as any;
-
-    const registry = new PluginRegistry([
-      createMockPlugin("router-1", ["router"], { router: router1 }),
-      createMockPlugin("router-2", ["router"], { router: router2 }),
-    ]);
-
-    const routers = registry.getRouters();
-    expect(routers.length).toBe(2);
-    expect(routers[0]).toBe(router1);
-    expect(routers[1]).toBe(router2);
-  });
-});
-
-// ─────────────────────────────────────────────────────────────────────────────
-// PluginRegistry.getAgent
-// ─────────────────────────────────────────────────────────────────────────────
-
-describe("PluginRegistry.getAgent", () => {
-  it("returns undefined when no agent plugins", () => {
-    const registry = new PluginRegistry([createMockPlugin("optimizer-plugin", ["optimizer"])]);
-
-    const agent = registry.getAgent("claude");
-    expect(agent).toBeUndefined();
-  });
-
-  it("returns agent by name", () => {
-    const claudeAgent = { name: "claude" } as any;
-    const cursorAgent = { name: "cursor" } as any;
-
-    const registry = new PluginRegistry([
-      createMockPlugin("claude-plugin", ["agent"], { agent: claudeAgent }),
-      createMockPlugin("cursor-plugin", ["agent"], { agent: cursorAgent }),
-    ]);
-
-    const agent = registry.getAgent("claude");
-    expect(agent).toBe(claudeAgent);
-  });
-
-  it("returns undefined when agent name not found", () => {
-    const claudeAgent = { name: "claude" } as any;
-
-    const registry = new PluginRegistry([createMockPlugin("claude-plugin", ["agent"], { agent: claudeAgent })]);
-
-    const agent = registry.getAgent("windsurf");
-    expect(agent).toBeUndefined();
-  });
-
-  it("last loaded wins on name collision", () => {
-    const claudeAgent1 = { name: "claude", version: 1 } as any;
-    const claudeAgent2 = { name: "claude", version: 2 } as any;
-
-    const registry = new PluginRegistry([
-      createMockPlugin("claude-v1", ["agent"], { agent: claudeAgent1 }),
-      createMockPlugin("claude-v2", ["agent"], { agent: claudeAgent2 }),
-    ]);
-
-    const agent = registry.getAgent("claude");
-    expect(agent).toBe(claudeAgent2);
-  });
-});
-
-// ─────────────────────────────────────────────────────────────────────────────
-// PluginRegistry.getReviewers
-// ─────────────────────────────────────────────────────────────────────────────
-
-describe("PluginRegistry.getReviewers", () => {
-  it("returns empty array when no reviewer plugins", () => {
-    const registry = new PluginRegistry([createMockPlugin("agent-plugin", ["agent"])]);
-
-    const reviewers = registry.getReviewers();
-    expect(reviewers.length).toBe(0);
-  });
-
-  it("returns all reviewer plugins", () => {
-    const reviewer1 = { name: "reviewer1" } as any;
-    const reviewer2 = { name: "reviewer2" } as any;
-
-    const registry = new PluginRegistry([
-      createMockPlugin("rev-1", ["reviewer"], { reviewer: reviewer1 }),
-      createMockPlugin("rev-2", ["reviewer"], { reviewer: reviewer2 }),
-    ]);
-
-    const reviewers = registry.getReviewers();
-    expect(reviewers.length).toBe(2);
-    expect(reviewers).toContain(reviewer1);
-    expect(reviewers).toContain(reviewer2);
-  });
-});
-
-// ─────────────────────────────────────────────────────────────────────────────
-// PluginRegistry.getContextProviders
-// ─────────────────────────────────────────────────────────────────────────────
-
-describe("PluginRegistry.getContextProviders", () => {
-  it("returns empty array when no context provider plugins", () => {
-    const registry = new PluginRegistry([createMockPlugin("agent-plugin", ["agent"])]);
-
-    const providers = registry.getContextProviders();
-    expect(providers.length).toBe(0);
-  });
-
-  it("returns all context provider plugins", () => {
-    const provider1 = { name: "provider1" } as any;
-    const provider2 = { name: "provider2" } as any;
-
-    const registry = new PluginRegistry([
-      createMockPlugin("prov-1", ["context-provider"], { contextProvider: provider1 }),
-      createMockPlugin("prov-2", ["context-provider"], { contextProvider: provider2 }),
-    ]);
-
-    const providers = registry.getContextProviders();
-    expect(providers.length).toBe(2);
-    expect(providers).toContain(provider1);
-    expect(providers).toContain(provider2);
-  });
-});
-
-// ─────────────────────────────────────────────────────────────────────────────
-// PluginRegistry.getReporters
-// ─────────────────────────────────────────────────────────────────────────────
-
-describe("PluginRegistry.getReporters", () => {
-  it("returns empty array when no reporter plugins", () => {
-    const registry = new PluginRegistry([createMockPlugin("agent-plugin", ["agent"])]);
-
-    const reporters = registry.getReporters();
-    expect(reporters.length).toBe(0);
-  });
-
-  it("returns all reporter plugins", () => {
-    const reporter1 = { name: "reporter1" } as any;
-    const reporter2 = { name: "reporter2" } as any;
-
-    const registry = new PluginRegistry([
-      createMockPlugin("rep-1", ["reporter"], { reporter: reporter1 }),
-      createMockPlugin("rep-2", ["reporter"], { reporter: reporter2 }),
-    ]);
-
-    const reporters = registry.getReporters();
-    expect(reporters.length).toBe(2);
-    expect(reporters).toContain(reporter1);
-    expect(reporters).toContain(reporter2);
-  });
-});
-
-// ─────────────────────────────────────────────────────────────────────────────
-// PluginRegistry.teardownAll
-// ─────────────────────────────────────────────────────────────────────────────
-
-describe("PluginRegistry.teardownAll", () => {
-  it("calls teardown on all plugins with teardown method", async () => {
-    const teardown1 = mock(async () => {});
-    const teardown2 = mock(async () => {});
-
-    const plugin1 = createMockPlugin("plugin-1", ["agent"]);
-    plugin1.teardown = teardown1;
-
-    const plugin2 = createMockPlugin("plugin-2", ["optimizer"]);
-    plugin2.teardown = teardown2;
-
-    const registry = new PluginRegistry([plugin1, plugin2]);
-
-    await registry.teardownAll();
-
-    expect(teardown1).toHaveBeenCalledTimes(1);
-    expect(teardown2).toHaveBeenCalledTimes(1);
-  });
-
-  it("skips plugins without teardown method", async () => {
-    const teardown1 = mock(async () => {});
-
-    const plugin1 = createMockPlugin("plugin-1", ["agent"]);
-    plugin1.teardown = teardown1;
-
-    const plugin2 = createMockPlugin("plugin-2", ["optimizer"]);
-    // plugin2 has no teardown
-
-    const registry = new PluginRegistry([plugin1, plugin2]);
-
-    await registry.teardownAll();
-
-    expect(teardown1).toHaveBeenCalledTimes(1);
-  });
-
-  it("continues teardown even if one plugin fails", async () => {
-    const teardown1 = mock(async () => {
-      throw new Error("Teardown failed");
-    });
-    const teardown2 = mock(async () => {});
-
-    const plugin1 = createMockPlugin("plugin-1", ["agent"]);
-    plugin1.teardown = teardown1;
-
-    const plugin2 = createMockPlugin("plugin-2", ["optimizer"]);
-    plugin2.teardown = teardown2;
-
-    const registry = new PluginRegistry([plugin1, plugin2]);
-
-    await registry.teardownAll();
-
-    expect(teardown1).toHaveBeenCalledTimes(1);
-    expect(teardown2).toHaveBeenCalledTimes(1);
-  });
-
-  it("handles empty plugin list", async () => {
-    const registry = new PluginRegistry([]);
-    await expect(registry.teardownAll()).resolves.toBeUndefined();
-  });
-});

package/test/unit/review/runner.test.ts

@@ -1,117 +0,0 @@
-/**
- * Unit tests for src/review/runner.ts
- * RQ-001: Assert clean working tree before running review typecheck/lint (BUG-049)
- *
- * Tests verify that runReview() checks for uncommitted tracked-file changes
- * (via git diff --name-only HEAD) before running typecheck or lint.
- */
-
-import { afterEach, beforeEach, describe, expect, mock, test } from "bun:test";
-import { _deps, runReview } from "../../../src/review/runner";
-import type { ReviewConfig } from "../../../src/review/types";
-
-/** Minimal ReviewConfig with typecheck enabled but command set to disable via executionConfig */
-const typecheckConfig: ReviewConfig = {
-  enabled: true,
-  checks: ["typecheck"],
-  commands: {},
-};
-
-/** ReviewConfig with no checks — used to isolate the dirty-tree guard logic */
-const noChecksConfig: ReviewConfig = {
-  enabled: true,
-  checks: [],
-  commands: {},
-};
-
-describe("runReview — dirty working tree guard (RQ-001)", () => {
-  let originalGetUncommittedFiles: typeof _deps.getUncommittedFiles;
-
-  beforeEach(() => {
-    originalGetUncommittedFiles = _deps.getUncommittedFiles;
-  });
-
-  afterEach(() => {
-    mock.restore();
-    _deps.getUncommittedFiles = originalGetUncommittedFiles;
-  });
-
-  describe("dirty working tree", () => {
-    test("returns failure with uncommitted files listed in failureReason", async () => {
-      _deps.getUncommittedFiles = mock(async (_workdir: string) => [
-        "src/types.ts",
-        "src/routing.ts",
-      ]);
-
-      const result = await runReview(typecheckConfig, "/tmp/fake-workdir");
-
-      expect(result.success).toBe(false);
-      expect(result.failureReason).toBeDefined();
-      expect(result.failureReason).toContain("src/types.ts");
-      expect(result.failureReason).toContain("src/routing.ts");
-    });
-
-    test("does not run typecheck when working tree is dirty", async () => {
-      _deps.getUncommittedFiles = mock(async (_workdir: string) => ["src/types.ts"]);
-
-      // If typecheck were run it would fail (no real workdir), but we expect
-      // an early return with zero checks executed.
-      const result = await runReview(typecheckConfig, "/tmp/fake-workdir");
-
-      expect(result.checks).toHaveLength(0);
-    });
-
-    test("calls getUncommittedFiles with the provided workdir", async () => {
-      const mockFn = mock(async (_workdir: string) => ["src/types.ts"]);
-      _deps.getUncommittedFiles = mockFn;
-
-      await runReview(typecheckConfig, "/tmp/my-project");
-
-      expect(mockFn).toHaveBeenCalledWith("/tmp/my-project");
-    });
-  });
-
-  describe("clean working tree", () => {
-    test("proceeds past dirty-tree guard when no uncommitted files", async () => {
-      _deps.getUncommittedFiles = mock(async (_workdir: string) => []);
-
-      // typecheckCommand: null disables the check so no real process is spawned.
-      const result = await runReview(typecheckConfig, "/tmp/fake-workdir", {
-        typecheckCommand: null,
-        maxIterations: 5,
-        iterationDelayMs: 0,
-        costLimit: 10,
-        sessionTimeoutSeconds: 300,
-        verificationTimeoutSeconds: 60,
-        maxStoriesPerFeature: 20,
-        contextProviderTokenBudget: 2000,
-        rectification: { enabled: false, maxIterations: 3 },
-        regressionGate: { enabled: false },
-      });
-
-      expect(result.success).toBe(true);
-    });
-
-    test("calls getUncommittedFiles before running checks", async () => {
-      const mockFn = mock(async (_workdir: string) => []);
-      _deps.getUncommittedFiles = mockFn;
-
-      await runReview(noChecksConfig, "/tmp/clean-workdir");
-
-      expect(mockFn).toHaveBeenCalledWith("/tmp/clean-workdir");
-    });
-  });
-
-  describe("untracked files only", () => {
-    test("review proceeds when git diff HEAD returns empty (only untracked files exist)", async () => {
-      // git diff --name-only HEAD only reports tracked files with changes.
-      // Untracked files are invisible to this command — working tree is considered clean.
-      _deps.getUncommittedFiles = mock(async (_workdir: string) => []);
-
-      const result = await runReview(noChecksConfig, "/tmp/fake-workdir");
-
-      // Should succeed — no dirty tracked files, review can proceed
-      expect(result.success).toBe(true);
-    });
-  });
-});

package/test/unit/routing/content-hash.test.ts

@@ -1,99 +0,0 @@
-/**
- * computeStoryContentHash — RRP-003
- *
- * AC-2: helper function computes a hash of title+description+ACs+tags
- */
-
-import { describe, expect, test } from "bun:test";
-import { computeStoryContentHash } from "../../../src/routing";
-import type { UserStory } from "../../../src/prd/types";
-
-// ---------------------------------------------------------------------------
-// Helpers
-// ---------------------------------------------------------------------------
-
-function makeStory(overrides?: Partial<UserStory>): UserStory {
-  return {
-    id: "US-001",
-    title: "Add login page",
-    description: "Users can log in with email and password",
-    acceptanceCriteria: ["Shows email field", "Shows password field", "Submits form"],
-    tags: ["auth", "ui"],
-    dependencies: [],
-    status: "pending",
-    passes: false,
-    escalations: [],
-    attempts: 0,
-    ...overrides,
-  };
-}
-
-// ---------------------------------------------------------------------------
-// AC-2: computeStoryContentHash exists and returns a string
-// ---------------------------------------------------------------------------
-
-describe("computeStoryContentHash", () => {
-  test("returns a non-empty string", () => {
-    const story = makeStory();
-    const hash = computeStoryContentHash(story);
-    expect(typeof hash).toBe("string");
-    expect(hash.length).toBeGreaterThan(0);
-  });
-
-  test("same story content produces the same hash (deterministic)", () => {
-    const story1 = makeStory();
-    const story2 = makeStory();
-    expect(computeStoryContentHash(story1)).toBe(computeStoryContentHash(story2));
-  });
-
-  test("different title produces different hash", () => {
-    const base = makeStory();
-    const changed = makeStory({ title: "Add registration page" });
-    expect(computeStoryContentHash(base)).not.toBe(computeStoryContentHash(changed));
-  });
-
-  test("different description produces different hash", () => {
-    const base = makeStory();
-    const changed = makeStory({ description: "Users can log in via OAuth" });
-    expect(computeStoryContentHash(base)).not.toBe(computeStoryContentHash(changed));
-  });
-
-  test("different acceptanceCriteria produces different hash", () => {
-    const base = makeStory();
-    const changed = makeStory({
-      acceptanceCriteria: ["Shows email field", "Shows password field"],
-    });
-    expect(computeStoryContentHash(base)).not.toBe(computeStoryContentHash(changed));
-  });
-
-  test("different tags produces different hash", () => {
-    const base = makeStory();
-    const changed = makeStory({ tags: ["auth", "api"] });
-    expect(computeStoryContentHash(base)).not.toBe(computeStoryContentHash(changed));
-  });
-
-  test("story ID, status, and attempts do NOT affect the hash (only content fields)", () => {
-    const base = makeStory({ id: "US-001", status: "pending", attempts: 0 });
-    const differentMeta = makeStory({ id: "US-099", status: "in-progress", attempts: 3 });
-    expect(computeStoryContentHash(base)).toBe(computeStoryContentHash(differentMeta));
-  });
-
-  test("empty acceptanceCriteria and tags produce a valid hash", () => {
-    const story = makeStory({ acceptanceCriteria: [], tags: [] });
-    const hash = computeStoryContentHash(story);
-    expect(typeof hash).toBe("string");
-    expect(hash.length).toBeGreaterThan(0);
-  });
-
-  test("adding an AC changes the hash", () => {
-    const before = makeStory({ acceptanceCriteria: ["AC1", "AC2"] });
-    const after = makeStory({ acceptanceCriteria: ["AC1", "AC2", "AC3 — new"] });
-    expect(computeStoryContentHash(before)).not.toBe(computeStoryContentHash(after));
-  });
-
-  test("adding a tag changes the hash", () => {
-    const before = makeStory({ tags: ["backend"] });
-    const after = makeStory({ tags: ["backend", "security"] });
-    expect(computeStoryContentHash(before)).not.toBe(computeStoryContentHash(after));
-  });
-});