@nathapp/nax 0.28.0 → 0.29.0

package/test/unit/pipeline/stages/autofix.test.ts

@@ -1,97 +0,0 @@
-// RE-ARCH: keep
-import { describe, expect, test } from "bun:test";
-import { autofixStage, _autofixDeps } from "../../../../src/pipeline/stages/autofix";
-import type { PipelineContext } from "../../../../src/pipeline/types";
-import { DEFAULT_CONFIG } from "../../../../src/config";
-
-function makeReviewResult(success: boolean) {
-  return { success, checks: [], summary: "" } as any;
-}
-
-function makeCtx(overrides: Partial<PipelineContext> = {}): PipelineContext {
-  return {
-    config: {
-      ...DEFAULT_CONFIG,
-      quality: {
-        ...DEFAULT_CONFIG.quality,
-        commands: {
-          ...DEFAULT_CONFIG.quality.commands,
-          lintFix: "biome check --fix",
-          formatFix: "biome format --write",
-        },
-        autofix: { enabled: true, maxAttempts: 2 },
-      },
-    } as any,
-    prd: { stories: [] } as any,
-    story: { id: "US-001", title: "t", status: "in-progress", acceptanceCriteria: [] } as any,
-    stories: [],
-    routing: { complexity: "simple", modelTier: "fast", testStrategy: "test-after", reasoning: "" },
-    workdir: "/tmp",
-    hooks: {},
-    ...overrides,
-  };
-}
-
-describe("autofixStage", () => {
-  test("disabled when reviewResult is undefined", () => {
-    expect(autofixStage.enabled(makeCtx())).toBe(false);
-  });
-
-  test("disabled when review passed", () => {
-    expect(autofixStage.enabled(makeCtx({ reviewResult: makeReviewResult(true) }))).toBe(false);
-  });
-
-  test("disabled when autofix.enabled = false", () => {
-    const ctx = makeCtx({
-      reviewResult: makeReviewResult(false),
-      config: {
-        ...DEFAULT_CONFIG,
-        quality: { ...DEFAULT_CONFIG.quality, autofix: { enabled: false } },
-      } as any,
-    });
-    expect(autofixStage.enabled(ctx)).toBe(false);
-  });
-
-  test("escalates when no fix commands configured", async () => {
-    const ctx = makeCtx({
-      reviewResult: makeReviewResult(false),
-      config: {
-        ...DEFAULT_CONFIG,
-        quality: {
-          ...DEFAULT_CONFIG.quality,
-          commands: { test: "bun test" },
-          autofix: { enabled: true },
-        },
-      } as any,
-    });
-    const result = await autofixStage.execute(ctx);
-    expect(result.action).toBe("escalate");
-  });
-
-  test("returns retry when recheck passes", async () => {
-    const saved = { ..._autofixDeps };
-    _autofixDeps.runCommand = async () => ({ exitCode: 0, output: "" });
-    _autofixDeps.recheckReview = async () => true;
-
-    const ctx = makeCtx({ reviewResult: makeReviewResult(false) });
-    const result = await autofixStage.execute(ctx);
-
-    Object.assign(_autofixDeps, saved);
-
-    expect(result.action).toBe("retry");
-    if (result.action === "retry") expect(result.fromStage).toBe("review");
-  });
-
-  test("escalates when recheck still fails after max attempts", async () => {
-    const saved = { ..._autofixDeps };
-    _autofixDeps.runCommand = async () => ({ exitCode: 1, output: "lint error" });
-    _autofixDeps.recheckReview = async () => false;
-
-    const ctx = makeCtx({ reviewResult: makeReviewResult(false) });
-    const result = await autofixStage.execute(ctx);
-
-    Object.assign(_autofixDeps, saved);
-
-    expect(result.action).toBe("escalate");
-  });
-});

package/test/unit/pipeline/stages/completion-review-gate.test.ts

@@ -1,218 +0,0 @@
-/**
- * Unit tests for review-gate trigger wiring in completion stage (TC-004)
- *
- * Covers:
- * - review-gate trigger fires after each story passes when enabled
- * - review-gate is disabled by default
- * - trigger responds abort → logs warning (non-blocking)
- * - trigger responds approve → continues normally
- */
-
-import { afterEach, describe, expect, mock, test } from "bun:test";
-import { mkdtempSync } from "fs";
-import { tmpdir } from "os";
-import type { NaxConfig } from "../../../../src/config";
-import { InteractionChain } from "../../../../src/interaction/chain";
-import type { InteractionPlugin, InteractionResponse } from "../../../../src/interaction/types";
-import { _completionDeps } from "../../../../src/pipeline/stages/completion";
-import type { PipelineContext } from "../../../../src/pipeline/types";
-import type { PRD, UserStory } from "../../../../src/prd";
-
-// ─────────────────────────────────────────────────────────────────────────────
-// Save originals for restoration
-// ─────────────────────────────────────────────────────────────────────────────
-
-const originalCheckReviewGate = _completionDeps.checkReviewGate;
-
-// ─────────────────────────────────────────────────────────────────────────────
-// Helpers
-// ─────────────────────────────────────────────────────────────────────────────
-
-function makeChain(action: InteractionResponse["action"]): InteractionChain {
-  const chain = new InteractionChain({ defaultTimeout: 5000, defaultFallback: "abort" });
-  const plugin: InteractionPlugin = {
-    name: "test",
-    send: mock(async () => {}),
-    receive: mock(async (id: string): Promise<InteractionResponse> => ({
-      requestId: id,
-      action,
-      respondedBy: "user",
-      respondedAt: Date.now(),
-    })),
-  };
-  chain.register(plugin);
-  return chain;
-}
-
-function makeConfig(triggers: Record<string, unknown>): NaxConfig {
-  return {
-    autoMode: { defaultAgent: "test-agent" },
-    models: { fast: "claude-haiku-4-5", balanced: "claude-sonnet-4-5", powerful: "claude-opus-4-5" },
-    execution: {
-      sessionTimeoutSeconds: 60,
-      dangerouslySkipPermissions: false,
-      costLimit: 10,
-      maxIterations: 10,
-      rectification: { maxRetries: 3 },
-    },
-    interaction: {
-      plugin: "cli",
-      defaults: { timeout: 30000, fallback: "abort" as const },
-      triggers,
-    },
-  } as unknown as NaxConfig;
-}
-
-function makeStory(): UserStory {
-  return {
-    id: "US-001",
-    title: "Test Story",
-    description: "Test",
-    acceptanceCriteria: [],
-    tags: [],
-    dependencies: [],
-    status: "in-progress",
-    passes: false,
-    escalations: [],
-    attempts: 1,
-  };
-}
-
-function makePRD(): PRD {
-  return {
-    project: "test",
-    feature: "my-feature",
-    branchName: "test-branch",
-    createdAt: new Date().toISOString(),
-    updatedAt: new Date().toISOString(),
-    userStories: [makeStory()],
-  };
-}
-
-function makeCtx(config: NaxConfig, interaction?: InteractionChain): PipelineContext {
-  const tempDir = mkdtempSync(`${tmpdir()}/nax-test-`);
-  return {
-    config,
-    prd: makePRD(),
-    story: makeStory(),
-    stories: [makeStory()],
-    routing: { complexity: "simple", modelTier: "fast", testStrategy: "test-after", reasoning: "" },
-    workdir: tempDir,
-    featureDir: tempDir,
-    agentResult: { success: true, estimatedCost: 0.01, output: "", stderr: "", exitCode: 0, rateLimited: false },
-    hooks: {} as PipelineContext["hooks"],
-    interaction,
-    storyStartTime: new Date().toISOString(),
-  } as unknown as PipelineContext;
-}
-
-afterEach(() => {
-  mock.restore();
-  _completionDeps.checkReviewGate = originalCheckReviewGate;
-});
-
-// ─────────────────────────────────────────────────────────────────────────────
-// review-gate trigger tests (via _completionDeps injection)
-// ─────────────────────────────────────────────────────────────────────────────
-
-describe("completionStage — review-gate trigger", () => {
-  test("calls review-gate trigger after story passes when enabled", async () => {
-    const { completionStage } = await import("../../../../src/pipeline/stages/completion");
-    _completionDeps.checkReviewGate = mock(async () => true);
-
-    const config = makeConfig({ "review-gate": { enabled: true } });
-    const chain = makeChain("approve");
-    const ctx = makeCtx(config, chain);
-
-    const result = await completionStage.execute(ctx);
-
-    expect(result.action).toBe("continue");
-    expect(_completionDeps.checkReviewGate).toHaveBeenCalledTimes(1);
-  });
-
-  test("does not call trigger when review-gate is disabled (default)", async () => {
-    const { completionStage } = await import("../../../../src/pipeline/stages/completion");
-    _completionDeps.checkReviewGate = mock(async () => true);
-
-    const config = makeConfig({});
-    const chain = makeChain("approve");
-    const ctx = makeCtx(config, chain);
-
-    const result = await completionStage.execute(ctx);
-
-    expect(result.action).toBe("continue");
-    expect(_completionDeps.checkReviewGate).not.toHaveBeenCalled();
-  });
-
-  test("does not fail pipeline when trigger responds abort", async () => {
-    const { completionStage } = await import("../../../../src/pipeline/stages/completion");
-    _completionDeps.checkReviewGate = mock(async () => false);
-
-    const config = makeConfig({ "review-gate": { enabled: true } });
-    const chain = makeChain("abort");
-    const ctx = makeCtx(config, chain);
-
-    const result = await completionStage.execute(ctx);
-
-    expect(result.action).toBe("continue");
-    expect(_completionDeps.checkReviewGate).toHaveBeenCalledTimes(1);
-  });
-
-  test("continues normally when trigger approves", async () => {
-    const { completionStage } = await import("../../../../src/pipeline/stages/completion");
-    _completionDeps.checkReviewGate = mock(async () => true);
-
-    const config = makeConfig({ "review-gate": { enabled: true } });
-    const chain = makeChain("approve");
-    const ctx = makeCtx(config, chain);
-
-    const result = await completionStage.execute(ctx);
-
-    expect(result.action).toBe("continue");
-  });
-
-  test("does not call trigger when no interaction chain", async () => {
-    const { completionStage } = await import("../../../../src/pipeline/stages/completion");
-    _completionDeps.checkReviewGate = mock(async () => true);
-
-    const config = makeConfig({ "review-gate": { enabled: true } });
-    const ctx = makeCtx(config); // no chain
-
-    const result = await completionStage.execute(ctx);
-
-    expect(result.action).toBe("continue");
-    expect(_completionDeps.checkReviewGate).not.toHaveBeenCalled();
-  });
-
-  test("passes correct context to checkReviewGate", async () => {
-    const { completionStage } = await import("../../../../src/pipeline/stages/completion");
-    _completionDeps.checkReviewGate = mock(async () => true);
-
-    const config = makeConfig({ "review-gate": { enabled: true } });
-    const chain = makeChain("approve");
-    const ctx = makeCtx(config, chain);
-
-    await completionStage.execute(ctx);
-
-    const callArgs = (_completionDeps.checkReviewGate as any).mock.calls[0];
-    expect(callArgs[0].featureName).toBe("my-feature");
-    expect(callArgs[0].storyId).toBe("US-001");
-  });
-
-  test("calls trigger for each story when multiple stories passed", async () => {
-    const { completionStage } = await import("../../../../src/pipeline/stages/completion");
-    _completionDeps.checkReviewGate = mock(async () => true);
-
-    const config = makeConfig({ "review-gate": { enabled: true } });
-    const chain = makeChain("approve");
-    const ctx = makeCtx(config, chain);
-
-    const story2 = makeStory();
-    story2.id = "US-002";
-    ctx.stories = [makeStory(), story2];
-
-    await completionStage.execute(ctx);
-
-    expect(_completionDeps.checkReviewGate).toHaveBeenCalledTimes(2);
-  });
-});

package/test/unit/pipeline/stages/execution-ambiguity.test.ts

@@ -1,311 +0,0 @@
-/**
- * Unit tests for story-ambiguity trigger and isAmbiguousOutput helper (TC-004)
- *
- * Covers:
- * - isAmbiguousOutput() detects all 6 keyword phrases (case-insensitive)
- * - story-ambiguity trigger fires when output is ambiguous and trigger enabled
- * - story-ambiguity is disabled by default
- * - trigger responds abort → escalate
- * - trigger responds approve → continue
- * - Trigger does not fire when output is clear
- */
-
-import { afterEach, describe, expect, mock, test } from "bun:test";
-import type { NaxConfig } from "../../../../src/config";
-import { InteractionChain } from "../../../../src/interaction/chain";
-import type { InteractionPlugin, InteractionResponse } from "../../../../src/interaction/types";
-import { isAmbiguousOutput, _executionDeps } from "../../../../src/pipeline/stages/execution";
-import type { PipelineContext } from "../../../../src/pipeline/types";
-import type { PRD, UserStory } from "../../../../src/prd";
-
-// ─────────────────────────────────────────────────────────────────────────────
-// Save originals for restoration
-// ─────────────────────────────────────────────────────────────────────────────
-
-const originalGetAgent = _executionDeps.getAgent;
-const originalCheckStoryAmbiguity = _executionDeps.checkStoryAmbiguity;
-const originalIsAmbiguousOutput = _executionDeps.isAmbiguousOutput;
-
-// ─────────────────────────────────────────────────────────────────────────────
-// Helpers
-// ─────────────────────────────────────────────────────────────────────────────
-
-function makeChain(action: InteractionResponse["action"]): InteractionChain {
-  const chain = new InteractionChain({ defaultTimeout: 5000, defaultFallback: "abort" });
-  const plugin: InteractionPlugin = {
-    name: "test",
-    send: mock(async () => {}),
-    receive: mock(async (id: string): Promise<InteractionResponse> => ({
-      requestId: id,
-      action,
-      respondedBy: "user",
-      respondedAt: Date.now(),
-    })),
-  };
-  chain.register(plugin);
-  return chain;
-}
-
-function makeConfig(triggers: Record<string, unknown>): NaxConfig {
-  return {
-    autoMode: { defaultAgent: "test-agent" },
-    models: { fast: "claude-haiku-4-5", balanced: "claude-sonnet-4-5", powerful: "claude-opus-4-5" },
-    execution: {
-      sessionTimeoutSeconds: 60,
-      dangerouslySkipPermissions: false,
-      costLimit: 10,
-      maxIterations: 10,
-      rectification: { maxRetries: 3 },
-    },
-    interaction: {
-      plugin: "cli",
-      defaults: { timeout: 30000, fallback: "abort" as const },
-      triggers,
-    },
-  } as unknown as NaxConfig;
-}
-
-function makeStory(): UserStory {
-  return {
-    id: "US-001",
-    title: "Test Story",
-    description: "Test",
-    acceptanceCriteria: [],
-    tags: [],
-    dependencies: [],
-    status: "in-progress",
-    passes: false,
-    escalations: [],
-    attempts: 1,
-  };
-}
-
-function makePRD(): PRD {
-  return {
-    project: "test",
-    feature: "my-feature",
-    branchName: "test-branch",
-    createdAt: new Date().toISOString(),
-    updatedAt: new Date().toISOString(),
-    userStories: [makeStory()],
-  };
-}
-
-function makeAgent(output: string) {
-  return {
-    name: "test-agent",
-    capabilities: { supportedTiers: ["fast", "balanced", "powerful"] },
-    run: mock(async () => ({
-      success: true,
-      exitCode: 0,
-      output,
-      stderr: "",
-      rateLimited: false,
-      durationMs: 100,
-      estimatedCost: 0.01,
-    })),
-  };
-}
-
-function makeCtx(config: NaxConfig, interaction?: InteractionChain): PipelineContext {
-  return {
-    config,
-    prd: makePRD(),
-    story: makeStory(),
-    stories: [makeStory()],
-    routing: { complexity: "simple", modelTier: "fast", testStrategy: "test-after", reasoning: "" },
-    workdir: "/tmp/test",
-    prompt: "Do something",
-    hooks: {} as PipelineContext["hooks"],
-    interaction,
-  } as unknown as PipelineContext;
-}
-
-afterEach(() => {
-  mock.restore();
-  _executionDeps.getAgent = originalGetAgent;
-  _executionDeps.checkStoryAmbiguity = originalCheckStoryAmbiguity;
-  _executionDeps.isAmbiguousOutput = originalIsAmbiguousOutput;
-});
-
-// ─────────────────────────────────────────────────────────────────────────────
-// isAmbiguousOutput helper tests
-// ─────────────────────────────────────────────────────────────────────────────
-
-describe("isAmbiguousOutput", () => {
-  test("detects 'unclear' keyword (case-insensitive)", () => {
-    expect(isAmbiguousOutput("This is unclear")).toBe(true);
-    expect(isAmbiguousOutput("This is UNCLEAR")).toBe(true);
-    expect(isAmbiguousOutput("This is UnClEaR")).toBe(true);
-  });
-
-  test("detects 'ambiguous' keyword", () => {
-    expect(isAmbiguousOutput("The requirement is ambiguous")).toBe(true);
-    expect(isAmbiguousOutput("The requirement is AMBIGUOUS")).toBe(true);
-  });
-
-  test("detects 'need clarification' phrase", () => {
-    expect(isAmbiguousOutput("I need clarification on this")).toBe(true);
-    expect(isAmbiguousOutput("I NEED CLARIFICATION on this")).toBe(true);
-  });
-
-  test("detects 'please clarify' phrase", () => {
-    expect(isAmbiguousOutput("Please clarify what you mean")).toBe(true);
-    expect(isAmbiguousOutput("PLEASE CLARIFY what you mean")).toBe(true);
-  });
-
-  test("detects 'which one' phrase", () => {
-    expect(isAmbiguousOutput("Which one should I use?")).toBe(true);
-    expect(isAmbiguousOutput("WHICH ONE should I use?")).toBe(true);
-  });
-
-  test("detects 'not sure which' phrase", () => {
-    expect(isAmbiguousOutput("I'm not sure which option to pick")).toBe(true);
-    expect(isAmbiguousOutput("I'm NOT SURE WHICH option to pick")).toBe(true);
-  });
-
-  test("returns false for clear output", () => {
-    expect(isAmbiguousOutput("Implementation complete")).toBe(false);
-    expect(isAmbiguousOutput("Tests passing")).toBe(false);
-    expect(isAmbiguousOutput("")).toBe(false);
-  });
-
-  test("returns false for empty string", () => {
-    expect(isAmbiguousOutput("")).toBe(false);
-  });
-
-  test("detects multiple keywords in same output", () => {
-    expect(isAmbiguousOutput("This is unclear and ambiguous")).toBe(true);
-  });
-});
-
-// ─────────────────────────────────────────────────────────────────────────────
-// story-ambiguity trigger tests (via _executionDeps injection)
-// ─────────────────────────────────────────────────────────────────────────────
-
-describe("executionStage — story-ambiguity trigger", () => {
-  test("returns escalate when ambiguity detected and trigger responds abort", async () => {
-    const { executionStage } = await import("../../../../src/pipeline/stages/execution");
-    const agent = makeAgent("This is unclear about requirements");
-    _executionDeps.getAgent = mock(() => agent as ReturnType<typeof _executionDeps.getAgent>);
-    _executionDeps.checkStoryAmbiguity = mock(async () => false);
-
-    const config = makeConfig({ "story-ambiguity": { enabled: true } });
-    const chain = makeChain("abort");
-    const ctx = makeCtx(config, chain);
-
-    const result = await executionStage.execute(ctx);
-
-    expect(result.action).toBe("escalate");
-    expect((result as { reason?: string }).reason).toContain("ambiguity");
-    expect(_executionDeps.checkStoryAmbiguity).toHaveBeenCalledTimes(1);
-  });
-
-  test("returns continue when ambiguity detected but trigger approves", async () => {
-    const { executionStage } = await import("../../../../src/pipeline/stages/execution");
-    const agent = makeAgent("I need clarification on this");
-    _executionDeps.getAgent = mock(() => agent as ReturnType<typeof _executionDeps.getAgent>);
-    _executionDeps.checkStoryAmbiguity = mock(async () => true);
-
-    const config = makeConfig({ "story-ambiguity": { enabled: true } });
-    const chain = makeChain("approve");
-    const ctx = makeCtx(config, chain);
-
-    const result = await executionStage.execute(ctx);
-
-    expect(result.action).toBe("continue");
-    expect(_executionDeps.checkStoryAmbiguity).toHaveBeenCalledTimes(1);
-  });
-
-  test("does not call trigger when story-ambiguity is disabled (default)", async () => {
-    const { executionStage } = await import("../../../../src/pipeline/stages/execution");
-    const agent = makeAgent("This is unclear");
-    _executionDeps.getAgent = mock(() => agent as ReturnType<typeof _executionDeps.getAgent>);
-    _executionDeps.checkStoryAmbiguity = mock(async () => false);
-
-    const config = makeConfig({});
-    const chain = makeChain("abort");
-    const ctx = makeCtx(config, chain);
-
-    const result = await executionStage.execute(ctx);
-
-    expect(result.action).toBe("continue");
-    expect(_executionDeps.checkStoryAmbiguity).not.toHaveBeenCalled();
-  });
-
-  test("does not call trigger when output is clear", async () => {
-    const { executionStage } = await import("../../../../src/pipeline/stages/execution");
-    const agent = makeAgent("Implementation complete successfully");
-    _executionDeps.getAgent = mock(() => agent as ReturnType<typeof _executionDeps.getAgent>);
-    _executionDeps.checkStoryAmbiguity = mock(async () => false);
-
-    const config = makeConfig({ "story-ambiguity": { enabled: true } });
-    const chain = makeChain("abort");
-    const ctx = makeCtx(config, chain);
-
-    const result = await executionStage.execute(ctx);
-
-    expect(result.action).toBe("continue");
-    expect(_executionDeps.checkStoryAmbiguity).not.toHaveBeenCalled();
-  });
-
-  test("does not call trigger when no interaction chain", async () => {
-    const { executionStage } = await import("../../../../src/pipeline/stages/execution");
-    const agent = makeAgent("Which one should I use?");
-    _executionDeps.getAgent = mock(() => agent as ReturnType<typeof _executionDeps.getAgent>);
-    _executionDeps.checkStoryAmbiguity = mock(async () => false);
-
-    const config = makeConfig({ "story-ambiguity": { enabled: true } });
-    const ctx = makeCtx(config); // no chain
-
-    const result = await executionStage.execute(ctx);
-
-    expect(result.action).toBe("continue");
-    expect(_executionDeps.checkStoryAmbiguity).not.toHaveBeenCalled();
-  });
-
-  test("does not call trigger when agent session failed", async () => {
-    const { executionStage } = await import("../../../../src/pipeline/stages/execution");
-    _executionDeps.getAgent = mock(() => ({
-      name: "test-agent",
-      capabilities: { supportedTiers: ["fast", "balanced", "powerful"] },
-      run: mock(async () => ({
-        success: false,
-        exitCode: 1,
-        output: "This is unclear",
-        stderr: "Error occurred",
-        rateLimited: false,
-        durationMs: 100,
-        estimatedCost: 0.01,
-      })),
-    } as ReturnType<typeof _executionDeps.getAgent>));
-    _executionDeps.checkStoryAmbiguity = mock(async () => false);
-
-    const config = makeConfig({ "story-ambiguity": { enabled: true } });
-    const chain = makeChain("abort");
-    const ctx = makeCtx(config, chain);
-
-    const result = await executionStage.execute(ctx);
-
-    expect(result.action).toBe("escalate");
-    expect(_executionDeps.checkStoryAmbiguity).not.toHaveBeenCalled();
-  });
-
-  test("passes correct context to checkStoryAmbiguity", async () => {
-    const { executionStage } = await import("../../../../src/pipeline/stages/execution");
-    const agent = makeAgent("not sure which");
-    _executionDeps.getAgent = mock(() => agent as ReturnType<typeof _executionDeps.getAgent>);
-    _executionDeps.checkStoryAmbiguity = mock(async () => true);
-
-    const config = makeConfig({ "story-ambiguity": { enabled: true } });
-    const chain = makeChain("approve");
-    const ctx = makeCtx(config, chain);
-
-    await executionStage.execute(ctx);
-
-    const callArgs = (_executionDeps.checkStoryAmbiguity as any).mock.calls[0];
-    expect(callArgs[0].featureName).toBe("my-feature");
-    expect(callArgs[0].storyId).toBe("US-001");
-    expect(callArgs[0].reason).toContain("Agent output suggests ambiguity");
-  });
-});